On Friday 30 January 2009, hartleys wrote:
I'd support an overall cleanup patch that fixes all those things at once.
How's this for a starting point? I'm willing to create a cleanup patch
for all the mach-omap1, mach-omap2, and mach-pxa users.
Signed-off-by: H Hartley Sweeten
On Thursday, January 29, 2009 5:58 PM, David Brownell wrote:
On Thursday 29 January 2009, hartleys wrote:
+/* Boards have uniqe mappings of {col, row} -- keycode.
+ * Column and row are 4 bits, but range only from 0..7;
+ * a PERSISTENT_KEY is always on and never reported.
+ */
On Wednesday, January 21, 2009 5:13 PM, David Brownell wrote:
Driver for the twl4030 family keypad controller. This controller
supports a key matrix of up to 8 rows by 8 columns. Board init
code passes a description of the key matrix to the driver.
Signed-off-by: David Brownell
Hi,
On Wednesday 21 January 2009, Trilok Soni wrote:
+
+static void twl4030_kp_scan(struct twl4030_keypad *kp, int release_all)
+{
+ u16 new_state[MAX_ROWS];
+ int col, row;
+
+ ...
+
+ key = twl4030_find_key(kp, col, row);
+
Hi David,
On Thu, Jan 22, 2009 at 11:12 PM, David Brownell davi...@pacbell.net wrote:
Hi,
---
drivers/input/keyboard/twl4030_keypad.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
--- a/drivers/input/keyboard/twl4030_keypad.c
+++
Hi David,
+
+static void twl4030_kp_scan(struct twl4030_keypad *kp, int release_all)
+{
+ u16 new_state[MAX_ROWS];
+ int col, row;
+
+ if (release_all)
+ memset(new_state, 0, sizeof(new_state));
+ else {
+ /* check for any changes */