Re: usb_nop_xceiv_register() missing when OTG built as modules

2010-05-26 Thread Felipe Balbi
Hi, On Sun, May 23, 2010 at 01:53:10AM +0200, ext Amit Kucheria wrote: From 3df714f995b0895e905090760482194233f66a1d Mon Sep 17 00:00:00 2001 Message-Id: 3df714f995b0895e905090760482194233f66a1d.1274570700.git.amit.kuche...@canonical.com From: Amit Kucheria amit.kuche...@canonical.com Date:

RE: usb_nop_xceiv_register() missing when OTG built as modules

2010-05-26 Thread Gupta, Ajay Kumar
Hi, On Mon, May 24, 2010 at 09:07:37AM +0200, ext Gupta, Ajay Kumar wrote: Attempting to remove usb_nop_xceiv_register() completely will require someone with more knowledge of davinci and blackfin archs to comment on what boards need the platform_device defined. NAK.. This is an

RE: usb_nop_xceiv_register() missing when OTG built as modules

2010-05-26 Thread Gupta, Ajay Kumar
ps: you really think that adding more and more ifdefs is better than Amit's patch ?? We can avoid using #ifdefs by introducing '.neednop' flag to board_data. Here is the patch for this which can be used on top of my earlier patch. --- cut here --- diff --git

RE: usb_nop_xceiv_register() missing when OTG built as modules

2010-05-24 Thread Gupta, Ajay Kumar
Hi, Here is a compile-tested patch since I haven't seen this fixed in mainline yet. It applies to the tip of Linus' tree. Attempting to remove usb_nop_xceiv_register() completely will require someone with more knowledge of davinci and blackfin archs to comment on what boards need the

Re: usb_nop_xceiv_register() missing when OTG built as modules

2010-05-22 Thread Amit Kucheria
On 10 Mar 05, Kevin Hilman wrote: m...@felipebalbi.com writes: On Fri, 05 Mar 2010 09:59:52 -0800, Kevin Hilman It would be my fault if I wrote those board files. ;) sure, sorry. Maybe I didn't express myself really well. I suggest you keep usb as a module, but keep nop xceiv

Re: usb_nop_xceiv_register() missing when OTG built as modules

2010-03-05 Thread Felipe Balbi
On Thu, Mar 04, 2010 at 06:32:40PM +0100, ext Kevin Hilman wrote: Yes, I did that intentionally. I *want* USB compiled as a module. If I do that, the build fails, and that's a bug that needs to be fixed. it depends on where you're calling usb_nop_xceiv_register(), if you're calling from a

Re: usb_nop_xceiv_register() missing when OTG built as modules

2010-03-05 Thread me
On Fri, 05 Mar 2010 09:59:52 -0800, Kevin Hilman It would be my fault if I wrote those board files. ;) sure, sorry. Maybe I didn't express myself really well. I suggest you keep usb as a module, but keep nop xceiv built-in. Yes, that's the workaround I'm already using, but it is not a fix.

Re: usb_nop_xceiv_register() missing when OTG built as modules

2010-03-05 Thread Kevin Hilman
m...@felipebalbi.com writes: On Fri, 05 Mar 2010 09:59:52 -0800, Kevin Hilman It would be my fault if I wrote those board files. ;) sure, sorry. Maybe I didn't express myself really well. I suggest you keep usb as a module, but keep nop xceiv built-in. Yes, that's the workaround I'm

Re: usb_nop_xceiv_register() missing when OTG built as modules

2010-03-04 Thread Kevin Hilman
Gupta, Ajay Kumar ajay.gu...@ti.com writes: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Kevin Hilman Sent: Thursday, March 04, 2010 5:39 AM To: linux-omap@vger.kernel.org Subject: usb_nop_xceiv_register() missing

RE: usb_nop_xceiv_register() missing when OTG built as modules

2010-03-04 Thread Gupta, Ajay Kumar
-Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Thursday, March 04, 2010 11:03 PM To: Gupta, Ajay Kumar Cc: linux-omap@vger.kernel.org Subject: Re: usb_nop_xceiv_register() missing when OTG built as modules Gupta, Ajay Kumar ajay.gu...@ti.com

RE: usb_nop_xceiv_register() missing when OTG built as modules

2010-03-03 Thread Gupta, Ajay Kumar
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Kevin Hilman Sent: Thursday, March 04, 2010 5:39 AM To: linux-omap@vger.kernel.org Subject: usb_nop_xceiv_register() missing when OTG built as modules This just