Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-03-11 Thread Pierre Ossman
On Tue, 10 Mar 2009 19:33:50 -0800 David Brownell davi...@pacbell.net wrote: It'd be nice to have a nice unambiguous set_voltage() request from the MMC core. The set_ios() thing has always been confusing. set_ios() should be taken out back. But someone has to have the time to reimplement

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-03-10 Thread David Brownell
On Monday 23 February 2009, Adrian Hunter wrote: Although I have not tested it, I very much doubt dual-voltage cards work.  That is because VMMC1_185V is zero, which has the side-effect of turning the regulator off (see arch/arm/mach-omap2/mmc-twl4030.c) And a second reason to know they don't

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-03-02 Thread Adrian Hunter
From a2ad80abeb9550782d4962472980e47df4055434 Mon Sep 17 00:00:00 2001 From: Kim Kyuwon chamm...@gmail.com Date: Fri, 20 Feb 2009 13:10:08 +0100 Subject: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming Most registers lose its state when the processor wakes up from

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-03-02 Thread Tony Lindgren
* Adrian Hunter adrian.hun...@nokia.com [090302 04:27]: From a2ad80abeb9550782d4962472980e47df4055434 Mon Sep 17 00:00:00 2001 From: Kim Kyuwon chamm...@gmail.com Date: Fri, 20 Feb 2009 13:10:08 +0100 Subject: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming Most

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-03-02 Thread Pierre Ossman
On Mon, 2 Mar 2009 08:44:14 -0800 Tony Lindgren t...@atomide.com wrote: * Adrian Hunter adrian.hun...@nokia.com [090302 04:27]: From a2ad80abeb9550782d4962472980e47df4055434 Mon Sep 17 00:00:00 2001 From: Kim Kyuwon chamm...@gmail.com Date: Fri, 20 Feb 2009 13:10:08 +0100 Subject:

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-02-27 Thread Tony Lindgren
* David Brownell davi...@pacbell.net [090224 14:14]: On Tuesday 24 February 2009, Adrian Hunter wrote: I agree that code removed by this patch is ugly and worth removing if it's not actually needed for MMC1. Here is a patch against current OMAP tree. From: Adrian Hunter

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-02-24 Thread Adrian Hunter
David Brownell wrote: On Monday 23 February 2009, Adrian Hunter wrote: Also, you will need the following patch if you actually want the power to go off. Current GIT already has a patch supporting power-off for MMC2; tested on SDP and some custom hardware. So this patch won't apply. Sorry,

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-02-24 Thread David Brownell
On Tuesday 24 February 2009, Adrian Hunter wrote: I agree that code removed by this patch is ugly and worth removing if it's not actually needed for MMC1. Here is a patch against current OMAP tree. From: Adrian Hunter ext-adrian.hun...@nokia.com Date: Tue, 24 Feb 2009 14:48:16 +0200

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-02-24 Thread David Brownell
On Tuesday 24 February 2009, Adrian Hunter wrote: I would still like the other two issues I raised considered. They were: 1.  'host' can be NULL in omap_mmc_suspend() / omap_mmc_resume() 2. wait for SDBP bit Someone from Nokia was going to be shepherding HSMMC patches, as I

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-02-23 Thread Kyungmin Park
Hi, On Mon, Feb 23, 2009 at 5:04 PM, Adrian Hunter ext-adrian.hun...@nokia.com wrote: ext Kim Kyuwon wrote: Hi, On Sat, Feb 21, 2009 at 6:11 AM, David Brownell davi...@pacbell.net wrote: On Friday 20 February 2009, Kim Kyuwon wrote: +static void omap_hsmmc_init(struct mmc_omap_host *host)

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-02-23 Thread Adrian Hunter
Kyungmin Park wrote: Hi, On Mon, Feb 23, 2009 at 5:04 PM, Adrian Hunter ext-adrian.hun...@nokia.com wrote: ext Kim Kyuwon wrote: Hi, On Sat, Feb 21, 2009 at 6:11 AM, David Brownell davi...@pacbell.net wrote: On Friday 20 February 2009, Kim Kyuwon wrote: +static void

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-02-23 Thread David Brownell
On Monday 23 February 2009, Adrian Hunter wrote: Also, you will need the following patch if you actually want the power to go off. Current GIT already has a patch supporting power-off for MMC2; tested on SDP and some custom hardware. So this patch won't apply. Are you sure that's needed for

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-02-23 Thread David Brownell
On Monday 23 February 2009, Kyungmin Park wrote: Although I have not tested it, I very much doubt dual-voltage cards work.  That is because VMMC1_185V is zero, which has the side-effect of turning the regulator off (see arch/arm/mach-omap2/mmc-twl4030.c) Right, looks like a longstanding

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-02-22 Thread Kim Kyuwon
Hi, On Sat, Feb 21, 2009 at 6:11 AM, David Brownell davi...@pacbell.net wrote: On Friday 20 February 2009, Kim Kyuwon wrote: +static void omap_hsmmc_init(struct mmc_omap_host *host) +{ + u32 hctl, capa, value; + + /* Only MMC1 supports 3.0V */ + if (host-id ==

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-02-22 Thread Adrian Hunter
ext Kim Kyuwon wrote: Hi, On Sat, Feb 21, 2009 at 6:11 AM, David Brownell davi...@pacbell.net wrote: On Friday 20 February 2009, Kim Kyuwon wrote: +static void omap_hsmmc_init(struct mmc_omap_host *host) +{ + u32 hctl, capa, value; + + /* Only MMC1 supports 3.0V */ +

Re: [PATCH] OMAP: HSMMC: Initialize hsmmc controller registers when resuming

2009-02-20 Thread David Brownell
On Friday 20 February 2009, Kim Kyuwon wrote: +static void omap_hsmmc_init(struct mmc_omap_host *host) +{ +   u32 hctl, capa, value; + +   /* Only MMC1 supports 3.0V */ +   if (host-id == OMAP_MMC1_DEVID) { +   hctl = SDVS30; Shouldn't it be remembering what voltage