Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-07-13 Thread Paul Walmsley
On Tue, 12 Jul 2011, Pavel Machek wrote: On Wed 2011-06-29 18:40:23, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM at boot and after wake-up from CORE OFF mode. However only a

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-07-12 Thread Pavel Machek
On Wed 2011-06-29 18:40:23, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM at boot and after wake-up from CORE OFF mode. However only a small part of the code really needs to run from

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-30 Thread Peter De Schrijver
+/* + * This function implements the erratum ID i581 WA: + * SDRC state restore before accessing the SDRAM + * + * Only used at return from non-OFF mode. For OFF + * mode the ROM code configures the SDRC and + * the DPLL before calling the restore code directly + * from DDR. + */ + +/*

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread Kevin Hilman
jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM at boot and after wake-up from CORE OFF mode. However only a small part of the code really needs to run from internal SRAM. This fix

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread Jean Pihet
On Wed, Jun 29, 2011 at 7:29 PM, Kevin Hilman khil...@ti.com wrote: jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM at boot and after wake-up from CORE OFF mode. However only a small

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread Russell King - ARM Linux
On Wed, Jun 29, 2011 at 10:29:49AM -0700, Kevin Hilman wrote: Russell, if you're OK with it, can you add it to your suspend branch for the upcoming merge window? Yes - though I think we can go a little bit further - this patch is on top of my code so far, and is untested. There isn't a need

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread Kevin Hilman
Russell King - ARM Linux li...@arm.linux.org.uk writes: On Wed, Jun 29, 2011 at 10:29:49AM -0700, Kevin Hilman wrote: Russell, if you're OK with it, can you add it to your suspend branch for the upcoming merge window? Yes - though I think we can go a little bit further - this patch is on

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread Russell King - ARM Linux
On Wed, Jun 29, 2011 at 06:40:23PM +0200, jean.pi...@newoldbits.com wrote: @@ -309,7 +308,7 @@ static irqreturn_t prcm_interrupt_handler (int irq, void *dev_id) static void omap34xx_do_sram_idle(unsigned long save_state) { - _omap_sram_idle(omap3_arm_context, save_state); +

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread Russell King - ARM Linux
On Wed, Jun 29, 2011 at 12:06:07PM -0700, Kevin Hilman wrote: Russell King - ARM Linux li...@arm.linux.org.uk writes: On Wed, Jun 29, 2011 at 10:29:49AM -0700, Kevin Hilman wrote: Russell, if you're OK with it, can you add it to your suspend branch for the upcoming merge window? Yes -

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread Kevin Hilman
Russell King - ARM Linux li...@arm.linux.org.uk writes: On Wed, Jun 29, 2011 at 12:06:07PM -0700, Kevin Hilman wrote: Russell King - ARM Linux li...@arm.linux.org.uk writes: On Wed, Jun 29, 2011 at 10:29:49AM -0700, Kevin Hilman wrote: Russell, if you're OK with it, can you add it to your

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-24 Thread Jean Pihet
Hi Kevin, On Fri, Jun 24, 2011 at 2:17 AM, Kevin Hilman khil...@ti.com wrote: Hi Jean, Can you rebase/retest this on top of my pm-wip/idle-suspend branch, which now contains Russell's major cleanup to use the common code as well as an additional patch from me to remove the unncessary

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-24 Thread Kevin Hilman
Jean Pihet jean.pi...@newoldbits.com writes: Hi Kevin, On Fri, Jun 24, 2011 at 2:17 AM, Kevin Hilman khil...@ti.com wrote: Hi Jean, Can you rebase/retest this on top of my pm-wip/idle-suspend branch, which now contains Russell's major cleanup to use the common code as well as an

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-23 Thread Kevin Hilman
jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM and run from there. However only a small part of the code really needs to run from internal SRAM. This fix lets most of the ASM idle

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-17 Thread Santosh Shilimkar
On 6/17/2011 2:22 PM, jean.pi...@newoldbits.com wrote: From: Jean Pihetj-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM and run from there. However only a small part of the code really needs to run from internal SRAM. This fix lets most