Re: [PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-26 Thread Linus Walleij
On Wed, Oct 24, 2012 at 4:19 PM, Kevin Hilman khil...@deeprootsystems.com wrote: Linus, please revert if it's not too late, and I'll come up with a more targetted fix. OK I ditched it, no big deal. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap in

Re: [PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-24 Thread Santosh Shilimkar
On Tuesday 23 October 2012 11:39 PM, Kevin Hilman wrote: From: Kevin Hilman khil...@ti.com When debounce clocks are disabled, ensure that the banks dbck_enable_mask is cleared also. Otherwise, context restore on subsequent off-mode transition will restore previous value from the shadow copies

Re: [PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-24 Thread Felipe Balbi
On Tue, Oct 23, 2012 at 03:00:09PM -0700, Kevin Hilman wrote: Felipe Balbi ba...@ti.com writes: Hi, On Tue, Oct 23, 2012 at 11:09:31AM -0700, Kevin Hilman wrote: From: Kevin Hilman khil...@ti.com When debounce clocks are disabled, ensure that the banks dbck_enable_mask is cleared

Re: [PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-24 Thread Linus Walleij
On Tue, Oct 23, 2012 at 8:09 PM, Kevin Hilman khil...@deeprootsystems.com wrote: From: Kevin Hilman khil...@ti.com When debounce clocks are disabled, ensure that the banks dbck_enable_mask is cleared also. Otherwise, context restore on subsequent off-mode transition will restore previous

Re: [PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-24 Thread Igor Grinberg
On 10/24/12 10:16, Linus Walleij wrote: On Tue, Oct 23, 2012 at 8:09 PM, Kevin Hilman khil...@deeprootsystems.com wrote: From: Kevin Hilman khil...@ti.com When debounce clocks are disabled, ensure that the banks dbck_enable_mask is cleared also. Otherwise, context restore on subsequent

Re: [PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-24 Thread Grazvydas Ignotas
On Tue, Oct 23, 2012 at 9:09 PM, Kevin Hilman khil...@deeprootsystems.com wrote: From: Kevin Hilman khil...@ti.com When debounce clocks are disabled, ensure that the banks dbck_enable_mask is cleared also. Otherwise, context restore on subsequent off-mode transition will restore previous

Re: [PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-24 Thread Santosh Shilimkar
On Wednesday 24 October 2012 05:32 PM, Grazvydas Ignotas wrote: On Tue, Oct 23, 2012 at 9:09 PM, Kevin Hilman khil...@deeprootsystems.com wrote: From: Kevin Hilman khil...@ti.com When debounce clocks are disabled, ensure that the banks dbck_enable_mask is cleared also. Otherwise, context

Re: [PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-24 Thread Grazvydas Ignotas
On Wed, Oct 24, 2012 at 3:49 PM, Santosh Shilimkar santosh.shilim...@ti.com wrote: On Wednesday 24 October 2012 05:32 PM, Grazvydas Ignotas wrote: On Tue, Oct 23, 2012 at 9:09 PM, Kevin Hilman khil...@deeprootsystems.com wrote: From: Kevin Hilman khil...@ti.com When debounce clocks are

Re: [PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-24 Thread Kevin Hilman
Grazvydas Ignotas nota...@gmail.com writes: On Tue, Oct 23, 2012 at 9:09 PM, Kevin Hilman khil...@deeprootsystems.com wrote: From: Kevin Hilman khil...@ti.com When debounce clocks are disabled, ensure that the banks dbck_enable_mask is cleared also. Otherwise, context restore on

Re: [PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-24 Thread Santosh Shilimkar
On Wednesday 24 October 2012 07:49 PM, Kevin Hilman wrote: Grazvydas Ignotas nota...@gmail.com writes: On Tue, Oct 23, 2012 at 9:09 PM, Kevin Hilman khil...@deeprootsystems.com wrote: From: Kevin Hilman khil...@ti.com When debounce clocks are disabled, ensure that the banks dbck_enable_mask

Re: [PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-23 Thread Felipe Balbi
Hi, On Tue, Oct 23, 2012 at 11:09:31AM -0700, Kevin Hilman wrote: From: Kevin Hilman khil...@ti.com When debounce clocks are disabled, ensure that the banks dbck_enable_mask is cleared also. Otherwise, context restore on subsequent off-mode transition will restore previous value from the

Re: [PATCH] gpio/omap: fix off-mode bug: clear debounce clock enable mask on disable

2012-10-23 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: Hi, On Tue, Oct 23, 2012 at 11:09:31AM -0700, Kevin Hilman wrote: From: Kevin Hilman khil...@ti.com When debounce clocks are disabled, ensure that the banks dbck_enable_mask is cleared also. Otherwise, context restore on subsequent off-mode transition