Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-07 Thread Ezequiel Garcia
On Wed, Mar 6, 2013 at 1:54 PM, Ezequiel Garcia elezegar...@gmail.com wrote: On Wed, Mar 6, 2013 at 1:46 PM, Jon Hunter jon-hun...@ti.com wrote: On 03/06/2013 05:58 AM, Ezequiel Garcia wrote: I'll submit this driver by the end of this week, in case you want to take a look at it. Ok, but

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-06 Thread Mark Jackson
On 05/03/13 21:34, Jon Hunter wrote: On 03/05/2013 11:30 AM, Jon Hunter wrote: On 03/05/2013 10:20 AM, Mark Jackson wrote: [snip] But I can see in physmap_of.c that the device gets registered without any call to devm_pinctrl_get_select_default() and hence no probe deferring takes

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-06 Thread Ezequiel Garcia
Jon, On Tue, Mar 5, 2013 at 6:34 PM, Jon Hunter jon-hun...@ti.com wrote: By the way, with this version you should remove simple-bus from your gpmc node compatible strings. I now call of_platform_device_create() to create the child device during the GPMC probe. I think that this is a safer

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-06 Thread Mark Jackson
On 06/03/13 10:23, Mark Jackson wrote: On 05/03/13 21:34, Jon Hunter wrote: On 03/05/2013 11:30 AM, Jon Hunter wrote: On 03/05/2013 10:20 AM, Mark Jackson wrote: [snip] But I can see in physmap_of.c that the device gets registered without any call to devm_pinctrl_get_select_default()

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-06 Thread Jon Hunter
On 03/06/2013 07:30 AM, Mark Jackson wrote: On 06/03/13 10:23, Mark Jackson wrote: On 05/03/13 21:34, Jon Hunter wrote: On 03/05/2013 11:30 AM, Jon Hunter wrote: On 03/05/2013 10:20 AM, Mark Jackson wrote: [snip] But I can see in physmap_of.c that the device gets registered without any

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-06 Thread Jon Hunter
On 03/06/2013 05:58 AM, Ezequiel Garcia wrote: Jon, On Tue, Mar 5, 2013 at 6:34 PM, Jon Hunter jon-hun...@ti.com wrote: By the way, with this version you should remove simple-bus from your gpmc node compatible strings. I now call of_platform_device_create() to create the child device

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-06 Thread Mark Jackson
On 06/03/13 16:44, Jon Hunter wrote: On 03/06/2013 07:30 AM, Mark Jackson wrote: On 06/03/13 10:23, Mark Jackson wrote: snip [1.541884] gpmc_probe_nor_child 1 [1.545483] GPMC_CS_CONFIG7_0 : 0f48 [1.549621] GPMC_CS_CONFIG7_1 : 0f58 [1.553812] GPMC_CS_CONFIG7_2 :

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-06 Thread Ezequiel Garcia
On Wed, Mar 6, 2013 at 1:46 PM, Jon Hunter jon-hun...@ti.com wrote: On 03/06/2013 05:58 AM, Ezequiel Garcia wrote: I'll submit this driver by the end of this week, in case you want to take a look at it. Ok, but this is not for omap right? No, this is a new driver for a memory controller

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-06 Thread Jon Hunter
On 03/06/2013 10:48 AM, Mark Jackson wrote: On 06/03/13 16:44, Jon Hunter wrote: On 03/06/2013 07:30 AM, Mark Jackson wrote: On 06/03/13 10:23, Mark Jackson wrote: snip [1.541884] gpmc_probe_nor_child 1 [1.545483] GPMC_CS_CONFIG7_0 : 0f48 [1.549621] GPMC_CS_CONFIG7_1 :

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-06 Thread Jon Hunter
On 03/06/2013 11:00 AM, Jon Hunter wrote: On 03/06/2013 10:48 AM, Mark Jackson wrote: On 06/03/13 16:44, Jon Hunter wrote: On 03/06/2013 07:30 AM, Mark Jackson wrote: On 06/03/13 10:23, Mark Jackson wrote: snip [1.541884] gpmc_probe_nor_child 1 [1.545483] GPMC_CS_CONFIG7_0 :

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-05 Thread Mark Jackson
On 26/02/13 17:30, Jon Hunter wrote: NOR flash is not currently supported when booting with device-tree on OMAP2+ devices. Add support to detect and configure NOR devices when booting with device-tree. Add documentation for the TI GPMC NOR binding. Signed-off-by: Jon Hunter

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-05 Thread Jon Hunter
On 03/05/2013 08:34 AM, Mark Jackson wrote: On 26/02/13 17:30, Jon Hunter wrote: NOR flash is not currently supported when booting with device-tree on OMAP2+ devices. Add support to detect and configure NOR devices when booting with device-tree. Add documentation for the TI GPMC NOR

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-05 Thread Mark Jackson
On 05/03/13 14:46, Jon Hunter wrote: On 03/05/2013 08:34 AM, Mark Jackson wrote: On 26/02/13 17:30, Jon Hunter wrote: NOR flash is not currently supported when booting with device-tree on OMAP2+ devices. Add support to detect and configure NOR devices when booting with device-tree. Add

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-05 Thread Jon Hunter
On 03/05/2013 10:20 AM, Mark Jackson wrote: On 05/03/13 14:46, Jon Hunter wrote: On 03/05/2013 08:34 AM, Mark Jackson wrote: On 26/02/13 17:30, Jon Hunter wrote: NOR flash is not currently supported when booting with device-tree on OMAP2+ devices. Add support to detect and configure NOR

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-05 Thread Ezequiel Garcia
Hi Jon, On Tue, Mar 5, 2013 at 2:30 PM, Jon Hunter jon-hun...@ti.com wrote: This really highlights a weakness in the GPMC driver, particularly for NOR, where the child device can only be probed once the parent is probed. I don't see this as being DT specific issue, because even on older OMAP

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-05 Thread Jon Hunter
On 03/05/2013 11:43 AM, Ezequiel Garcia wrote: Hi Jon, On Tue, Mar 5, 2013 at 2:30 PM, Jon Hunter jon-hun...@ti.com wrote: This really highlights a weakness in the GPMC driver, particularly for NOR, where the child device can only be probed once the parent is probed. I don't see this as

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-05 Thread Jon Hunter
On 03/05/2013 11:30 AM, Jon Hunter wrote: On 03/05/2013 10:20 AM, Mark Jackson wrote: [snip] But I can see in physmap_of.c that the device gets registered without any call to devm_pinctrl_get_select_default() and hence no probe deferring takes place is the pinctrl device hasn't yet been

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-04 Thread Ezequiel Garcia
Hi Jon, On Tue, Feb 26, 2013 at 2:30 PM, Jon Hunter jon-hun...@ti.com wrote: + +Example: + +gpmc: gpmc@6e00 { + compatible = ti,omap3430-gpmc, simple-bus; I'm concern about using simple-bus, and I'm not entirely sure this will work. AFAIK, you can't correlate a parent-child

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-04 Thread Jon Hunter
On 03/04/2013 05:57 AM, Ezequiel Garcia wrote: Hi Jon, On Tue, Feb 26, 2013 at 2:30 PM, Jon Hunter jon-hun...@ti.com wrote: + +Example: + +gpmc: gpmc@6e00 { + compatible = ti,omap3430-gpmc, simple-bus; I'm concern about using simple-bus, and I'm not entirely sure this will

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-04 Thread Jon Hunter
On 03/04/2013 11:51 AM, Jon Hunter wrote: On 03/04/2013 05:57 AM, Ezequiel Garcia wrote: Hi Jon, On Tue, Feb 26, 2013 at 2:30 PM, Jon Hunter jon-hun...@ti.com wrote: + +Example: + +gpmc: gpmc@6e00 { + compatible = ti,omap3430-gpmc, simple-bus; I'm concern about using

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-01 Thread Ezequiel Garcia
Hi Jon, On Tue, Feb 26, 2013 at 2:30 PM, Jon Hunter jon-hun...@ti.com wrote: [...] +static int gpmc_probe_nor_child(struct platform_device *pdev, + struct device_node *child) +{ + struct gpmc_settings gpmc_s; + struct gpmc_timings gpmc_t; +

Re: [PATCH 11/14] ARM: OMAP2+: Add device-tree support for NOR flash

2013-03-01 Thread Jon Hunter
On 03/01/2013 03:25 PM, Ezequiel Garcia wrote: Hi Jon, On Tue, Feb 26, 2013 at 2:30 PM, Jon Hunter jon-hun...@ti.com wrote: [...] +static int gpmc_probe_nor_child(struct platform_device *pdev, + struct device_node *child) +{ + struct gpmc_settings