Re: [PATCH 2/4] wl1251: move power GPIO handling into the driver

2013-11-05 Thread Pavel Machek
On Sun 2013-10-27 17:14:27, Sebastian Reichel wrote: Move the power GPIO handling from the board code into the driver. This is a dependency for device tree support. Signed-off-by: Sebastian Reichel s...@debian.org Reviewed-by: Pavel Machek pa...@ucw.cz -- (english)

Re: [PATCH 2/4] wl1251: move power GPIO handling into the driver

2013-10-28 Thread Grazvydas Ignotas
On Sun, Oct 27, 2013 at 10:12 PM, Sebastian Reichel s...@debian.org wrote: On Sun, Oct 27, 2013 at 08:24:16PM +0400, Alexander Shiyan wrote: Move the power GPIO handling from the board code into the driver. This is a dependency for device tree support. Signed-off-by: Sebastian Reichel

Re: [PATCH 2/4] wl1251: move power GPIO handling into the driver

2013-10-28 Thread Mark Brown
On Mon, Oct 28, 2013 at 07:29:52PM +0200, Grazvydas Ignotas wrote: When wl12xx family of chips is connected through SDIO, we already have that pin set up as a regulator controlled with the help of mmc subsystem. When time comes to communicate with the chip, mmc subsystem sees this as yet

Re: [PATCH 2/4] wl1251: move power GPIO handling into the driver

2013-10-28 Thread Sebastian Reichel
Hi, On Mon, Oct 28, 2013 at 12:23:54PM -0700, Mark Brown wrote: On Mon, Oct 28, 2013 at 07:29:52PM +0200, Grazvydas Ignotas wrote: When wl12xx family of chips is connected through SDIO, we already have that pin set up as a regulator controlled with the help of mmc subsystem. When time

Re: [PATCH 2/4] wl1251: move power GPIO handling into the driver

2013-10-28 Thread Mark Brown
On Tue, Oct 29, 2013 at 12:26:26AM +0100, Sebastian Reichel wrote: 1. The pin is named PMEN in the Nokia N900 schematics 2. PMEN is described as Power management enable - system shutdown in a crippled datasheet of the wl1253, which I found in the internet. I don't think this is supposed

Re: [PATCH 2/4] wl1251: move power GPIO handling into the driver

2013-10-27 Thread Sebastian Reichel
On Sun, Oct 27, 2013 at 08:24:16PM +0400, Alexander Shiyan wrote: Move the power GPIO handling from the board code into the driver. This is a dependency for device tree support. Signed-off-by: Sebastian Reichel s...@debian.org --- arch/arm/mach-omap2/board-omap3pandora.c | 2 ++