Re: [PATCH V2 4/5] drivers/rtc/rtc-ds1307.c: Support optional wakeup interrupt source

2015-07-01 Thread Alexandre Belloni
Hi, On 24/06/2015 at 11:26:54 -0500, Nishanth Menon wrote : I am wrong here - code just returns 0 and ignores err. So, how about the following patch instead: (Alexandre, please do let me know if the entire series needs to be reposted): Can you resend just that one as v3? I'll take it right

Re: [PATCH V2 4/5] drivers/rtc/rtc-ds1307.c: Support optional wakeup interrupt source

2015-06-25 Thread Grygorii Strashko
On 06/24/2015 07:26 PM, Nishanth Menon wrote: On 11:07-20150624, Nishanth Menon wrote: On 06/24/2015 10:36 AM, Grygorii Strashko wrote: On 06/23/2015 07:15 PM, Nishanth Menon wrote: [...] + ds1307-wakeirq = of_irq_get(node, 1); + if (ds1307-wakeirq = 0) { +

Re: [PATCH V2 4/5] drivers/rtc/rtc-ds1307.c: Support optional wakeup interrupt source

2015-06-24 Thread Tony Lindgren
* Nishanth Menon n...@ti.com [150623 09:21]: With the recent pinctrl-single changes, SoCs such as Texas Instrument's OMAP processors can treat wake-up events from deeper idle states as interrupts. Let's add support for the optional second interrupt for wake-up using the generic wakeirq

Re: [PATCH V2 4/5] drivers/rtc/rtc-ds1307.c: Support optional wakeup interrupt source

2015-06-24 Thread Grygorii Strashko
On 06/23/2015 07:15 PM, Nishanth Menon wrote: With the recent pinctrl-single changes, SoCs such as Texas Instrument's OMAP processors can treat wake-up events from deeper idle states as interrupts. Let's add support for the optional second interrupt for wake-up using the generic wakeirq support

Re: [PATCH V2 4/5] drivers/rtc/rtc-ds1307.c: Support optional wakeup interrupt source

2015-06-24 Thread Nishanth Menon
On 06/24/2015 10:36 AM, Grygorii Strashko wrote: On 06/23/2015 07:15 PM, Nishanth Menon wrote: [...] +ds1307-wakeirq = of_irq_get(node, 1); +if (ds1307-wakeirq = 0) { +if (ds1307-wakeirq == -EPROBE_DEFER) { +err =

Re: [PATCH V2 4/5] drivers/rtc/rtc-ds1307.c: Support optional wakeup interrupt source

2015-06-24 Thread Grygorii Strashko
On 06/24/2015 07:07 PM, Nishanth Menon wrote: On 06/24/2015 10:36 AM, Grygorii Strashko wrote: On 06/23/2015 07:15 PM, Nishanth Menon wrote: [...] + ds1307-wakeirq = of_irq_get(node, 1); + if (ds1307-wakeirq = 0) { + if (ds1307-wakeirq ==

Re: [PATCH V2 4/5] drivers/rtc/rtc-ds1307.c: Support optional wakeup interrupt source

2015-06-24 Thread Nishanth Menon
On 11:07-20150624, Nishanth Menon wrote: On 06/24/2015 10:36 AM, Grygorii Strashko wrote: On 06/23/2015 07:15 PM, Nishanth Menon wrote: [...] + ds1307-wakeirq = of_irq_get(node, 1); + if (ds1307-wakeirq = 0) { + if (ds1307-wakeirq == -EPROBE_DEFER) {