Re: [PATCH v2 1/5] drivers: phy: add generic PHY framework

2013-02-24 Thread kishon
Hi, On Sunday 24 February 2013 04:14 AM, Rob Landley wrote: On 02/18/2013 11:53:14 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle.

Re: [PATCH v2 1/5] drivers: phy: add generic PHY framework

2013-02-23 Thread Rob Landley
On 02/18/2013 11:53:14 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. To obtain a reference to the PHY without using phandle, the

Re: [PATCH v2 1/5] drivers: phy: add generic PHY framework

2013-02-19 Thread Felipe Balbi
Hi, On Tue, Feb 19, 2013 at 11:23:14AM +0530, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. To obtain a reference to the PHY without

Re: [PATCH v2 1/5] drivers: phy: add generic PHY framework

2013-02-19 Thread Arnd Bergmann
On Tuesday 19 February 2013, Kishon Vijay Abraham I wrote: +static struct class *phy_class; +static LIST_HEAD(phy_list); +static DEFINE_MUTEX(phy_list_mutex); +static LIST_HEAD(phy_bind_list); Hmm, so you actually do have a 'class'. There is a GregKH mandated ban on new classes, meaning that

Re: [PATCH v2 1/5] drivers: phy: add generic PHY framework

2013-02-19 Thread kishon
Hi, On Tuesday 19 February 2013 06:26 PM, Arnd Bergmann wrote: On Tuesday 19 February 2013, Kishon Vijay Abraham I wrote: +static struct class *phy_class; +static LIST_HEAD(phy_list); +static DEFINE_MUTEX(phy_list_mutex); +static LIST_HEAD(phy_bind_list); Hmm, so you actually do have a

Re: [PATCH v2 1/5] drivers: phy: add generic PHY framework

2013-02-19 Thread Arnd Bergmann
On Tuesday 19 February 2013, kishon wrote: + + devname = dev_name(dev); + device_initialize(phy-dev); + phy-desc = desc; + phy-dev.class = phy_class; + phy-dev.parent = dev; + phy-dev.bus = desc-bus; + ret = dev_set_name(phy-dev, %s, devname); Passing a bus_type