Re: [PATCH v3] gpio/omap: fix off-mode bug: clear debounce clock enable mask on free/reset

2012-10-27 Thread Linus Walleij
On Fri, Oct 26, 2012 at 12:52 AM, Jon Hunter jon-hun...@ti.com wrote: Subject: [PATCH] gpio/omap: fix clearing of debounce settings on gpio free/reset When a GPIO is freed or shutdown, we need to ensure that any debounce settings are cleared and if the GPIO is the only GPIO in the bank that

Re: [PATCH v3] gpio/omap: fix off-mode bug: clear debounce clock enable mask on free/reset

2012-10-26 Thread Santosh Shilimkar
Jon, On Friday 26 October 2012 04:22 AM, Jon Hunter wrote: Hi Kevin, On 10/25/2012 11:34 AM, Kevin Hilman wrote: From: Kevin Hilman khil...@ti.com [...] diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index 94cbc84..ce1da19 100644 --- a/drivers/gpio/gpio-omap.c +++

Re: [PATCH v3] gpio/omap: fix off-mode bug: clear debounce clock enable mask on free/reset

2012-10-26 Thread Jon Hunter
On 10/26/2012 01:01 AM, Santosh Shilimkar wrote: Jon, On Friday 26 October 2012 04:22 AM, Jon Hunter wrote: Hi Kevin, On 10/25/2012 11:34 AM, Kevin Hilman wrote: From: Kevin Hilman khil...@ti.com [...] diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index

Re: [PATCH v3] gpio/omap: fix off-mode bug: clear debounce clock enable mask on free/reset

2012-10-25 Thread Jon Hunter
Hi Kevin, On 10/25/2012 11:34 AM, Kevin Hilman wrote: From: Kevin Hilman khil...@ti.com When a GPIO is freed or shutdown, ensure that the proper bit in dbck_enable_mask is cleared also. Otherwise, context restore on subsequent off-mode transition will restore previous debounce values from

Re: [PATCH v3] gpio/omap: fix off-mode bug: clear debounce clock enable mask on free/reset

2012-10-25 Thread Kevin Hilman
Jon Hunter jon-hun...@ti.com writes: Hi Kevin, On 10/25/2012 11:34 AM, Kevin Hilman wrote: From: Kevin Hilman khil...@ti.com When a GPIO is freed or shutdown, ensure that the proper bit in dbck_enable_mask is cleared also. Otherwise, context restore on subsequent off-mode transition