Re: [PATCH v3 0/5] common clk framework

2011-11-26 Thread Turquette, Mike
On Fri, Nov 25, 2011 at 11:06 PM, Shawn Guo shawn@freescale.com wrote: On Mon, Nov 21, 2011 at 05:40:42PM -0800, Mike Turquette wrote:   .speaking of which, clk_set_rate has been overhauled and is now recursive. *collective groan*.  clk_set_rate is still simple for the common case of

Re: [PATCH v3 0/5] common clk framework

2011-11-25 Thread Shawn Guo
On Mon, Nov 21, 2011 at 05:40:42PM -0800, Mike Turquette wrote: [...] .the most notable change is the removal of struct clk_hw. Happy to see that. This extra layer of abstraction is only necessary if we want hide the definition of struct clk from platform code. Many developers expressed

Re: [PATCH v3 0/5] common clk framework

2011-11-22 Thread Greg KH
On Mon, Nov 21, 2011 at 05:40:42PM -0800, Mike Turquette wrote: .sysfs support. Visualize your clk tree at /sys/clk! Where would be a better place to put the clk tree besides the root of /sys/? Um, in the proper place for it under /sys/devices like the rest of the device tree is? When a

Re: [PATCH v3 0/5] common clk framework

2011-11-22 Thread Russell King - ARM Linux
On Tue, Nov 22, 2011 at 07:42:59AM -0800, Greg KH wrote: On Mon, Nov 21, 2011 at 05:40:42PM -0800, Mike Turquette wrote: .sysfs support. Visualize your clk tree at /sys/clk! Where would be a better place to put the clk tree besides the root of /sys/? Um, in the proper place for it

Re: [PATCH v3 0/5] common clk framework

2011-11-22 Thread Mike Turquette
On Tue, Nov 22, 2011 at 9:45 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Nov 22, 2011 at 07:42:59AM -0800, Greg KH wrote: On Mon, Nov 21, 2011 at 05:40:42PM -0800, Mike Turquette wrote:   .sysfs support.  Visualize your clk tree at /sys/clk!  Where would be a better

Re: [PATCH v3 0/5] common clk framework

2011-11-22 Thread Greg KH
On Tue, Nov 22, 2011 at 10:09:29AM -0800, Mike Turquette wrote: On Tue, Nov 22, 2011 at 9:45 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Nov 22, 2011 at 07:42:59AM -0800, Greg KH wrote: On Mon, Nov 21, 2011 at 05:40:42PM -0800, Mike Turquette wrote:   .sysfs

Re: [PATCH v3 0/5] common clk framework

2011-11-22 Thread Mark Brown
On Tue, Nov 22, 2011 at 11:12:26AM -0800, Greg KH wrote: On Tue, Nov 22, 2011 at 10:09:29AM -0800, Mike Turquette wrote: If others also agree that it should reside only in debugfs then I'll move it there for V4. If it's only for debug stuff, then yes, it belongs in debugfs. All distros