Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-17 Thread Daniel Mack
Hi Nishanth, On 11/15/2013 03:39 PM, Nishanth Menon wrote: To trigger the fail, I created a custom Test case on TI vendor kernel based on v3.12 tag: On beagleBone-Black test scenario (BBB): Boot from SD card ensure firmware is loaded (rev 0x182) run LTP fsstress [1] in

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-15 Thread Nishanth Menon
On 11/07/2013 02:42 PM, Vaibhav Bedia wrote: Hi Nishanth :) On Thu, Nov 7, 2013 at 10:48 AM, Nishanth Menon n...@ti.com wrote: On 11/07/2013 09:36 AM, Daniel Mack wrote: On 11/07/2013 04:18 PM, Nishanth Menon wrote: Tested this on a vendor V3.12 tag based kernel: Test patch:

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Gururaja Hebbar
On Wednesday 06 November 2013 11:06 PM, Joel Fernandes wrote: Hi Vaibhav, On 10/31/2013 05:25 PM, Vaibhav Bedia wrote: Hi Daniel, On Wed, Oct 30, 2013 at 4:21 PM, Daniel Mack zon...@gmail.com wrote: [...] + +static SIMPLE_DEV_PM_OPS(edma_pm_ops, edma_pm_suspend, edma_pm_resume); +

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Daniel Mack
On 11/07/2013 02:30 PM, Gururaja Hebbar wrote: On Wednesday 06 November 2013 11:06 PM, Joel Fernandes wrote: Hi Vaibhav, On 10/31/2013 05:25 PM, Vaibhav Bedia wrote: Hi Daniel, On Wed, Oct 30, 2013 at 4:21 PM, Daniel Mack zon...@gmail.com wrote: [...] + +static

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Nishanth Menon
On 11/07/2013 07:32 AM, Daniel Mack wrote: On 11/07/2013 02:30 PM, Gururaja Hebbar wrote: On Wednesday 06 November 2013 11:06 PM, Joel Fernandes wrote: Hi Vaibhav, On 10/31/2013 05:25 PM, Vaibhav Bedia wrote: Hi Daniel, On Wed, Oct 30, 2013 at 4:21 PM, Daniel Mack zon...@gmail.com wrote:

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Nishanth Menon
On 10/30/2013 03:21 PM, Daniel Mack wrote: [...] diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index 8e1a024..f15cdb9 100644 --- a/arch/arm/common/edma.c +++ b/arch/arm/common/edma.c [...] +static int edma_pm_suspend(struct device *dev) +{ + int j; + +

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Daniel Mack
On 11/07/2013 04:18 PM, Nishanth Menon wrote: Tested this on a vendor V3.12 tag based kernel: Test patch: http://pastebin.com/AmnktQ7B test: echo -n 1/sys/power/pm_print_times; rtcwake -d /dev/rtc0 -m mem -s 5 with the current patch: http://pastebin.com/RujarRLV suspend_late and

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Nishanth Menon
On 11/07/2013 09:36 AM, Daniel Mack wrote: On 11/07/2013 04:18 PM, Nishanth Menon wrote: Tested this on a vendor V3.12 tag based kernel: Test patch: http://pastebin.com/AmnktQ7B test: echo -n 1/sys/power/pm_print_times; rtcwake -d /dev/rtc0 -m mem -s 5 with the current patch:

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Grygorii Strashko
On 11/07/2013 05:34 PM, Nishanth Menon wrote: On 10/30/2013 03:21 PM, Daniel Mack wrote: [...] diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index 8e1a024..f15cdb9 100644 --- a/arch/arm/common/edma.c +++ b/arch/arm/common/edma.c [...] +static int edma_pm_suspend(struct device

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Joel Fernandes
Hi Daniel, Thanks for your followup patch on this. It looks much better now using existing functions to save/restore the state. On 10/30/2013 03:21 PM, Daniel Mack wrote: This patch makes the edma driver resume correctly after suspend. Tested on an AM33xx platform with cyclic audio streams and

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Joel Fernandes
On 11/07/2013 10:34 AM, Joel Fernandes wrote: Hi Daniel, Thanks for your followup patch on this. It looks much better now using existing functions to save/restore the state. On 10/30/2013 03:21 PM, Daniel Mack wrote: This patch makes the edma driver resume correctly after suspend.

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Daniel Mack
Hi Joel, On 11/07/2013 05:34 PM, Joel Fernandes wrote: Thanks for your followup patch on this. It looks much better now using existing functions to save/restore the state. Yes, thanks for the suggesting it in the first place. On 10/30/2013 03:21 PM, Daniel Mack wrote: diff --git

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Vaibhav Bedia
Hi Joel, On Wed, Nov 6, 2013 at 12:36 PM, Joel Fernandes jo...@ti.com wrote: Hi Vaibhav, On 10/31/2013 05:25 PM, Vaibhav Bedia wrote: Hi Daniel, On Wed, Oct 30, 2013 at 4:21 PM, Daniel Mack zon...@gmail.com wrote: [...] + +static SIMPLE_DEV_PM_OPS(edma_pm_ops, edma_pm_suspend,

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Vaibhav Bedia
Hi Nishanth :) On Thu, Nov 7, 2013 at 10:48 AM, Nishanth Menon n...@ti.com wrote: On 11/07/2013 09:36 AM, Daniel Mack wrote: On 11/07/2013 04:18 PM, Nishanth Menon wrote: Tested this on a vendor V3.12 tag based kernel: Test patch: http://pastebin.com/AmnktQ7B test: echo -n

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Vaibhav Bedia
Hi Grygorii :) On Thu, Nov 7, 2013 at 11:27 AM, Grygorii Strashko grygorii.stras...@ti.com wrote: On 11/07/2013 05:34 PM, Nishanth Menon wrote: On 10/30/2013 03:21 PM, Daniel Mack wrote: [...] diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c index 8e1a024..f15cdb9 100644 ---

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Joel Fernandes
On 11/07/2013 11:37 AM, Daniel Mack wrote: [..] I know ti,edma-regions property is not currently being used, but we should future proof this by setting up DRAE for like done in probe: for (i = 0; i info[j]-n_region; i++) { edma_write_array2(j,

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Gururaja Hebbar
On Thursday 07 November 2013 11:07 PM, Daniel Mack wrote: Hi Joel, On 11/07/2013 05:34 PM, Joel Fernandes wrote: Thanks for your followup patch on this. It looks much better now using existing functions to save/restore the state. Yes, thanks for the suggesting it in the first place.

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-07 Thread Daniel Mack
On 11/08/2013 05:07 AM, Gururaja Hebbar wrote: On Thursday 07 November 2013 11:07 PM, Daniel Mack wrote: I'm running long-time tests here on a device which has a mwifiex connected to omap_hsmmc. The test procedure includes: a) a script on the device that puts the device to sleep some seconds

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-11-06 Thread Joel Fernandes
Hi Vaibhav, On 10/31/2013 05:25 PM, Vaibhav Bedia wrote: Hi Daniel, On Wed, Oct 30, 2013 at 4:21 PM, Daniel Mack zon...@gmail.com wrote: [...] + +static SIMPLE_DEV_PM_OPS(edma_pm_ops, edma_pm_suspend, edma_pm_resume); + static struct platform_driver edma_driver = { .driver = {

Re: [PATCH v4] ARM: omap: edma: add suspend suspend/resume hooks

2013-10-31 Thread Vaibhav Bedia
Hi Daniel, On Wed, Oct 30, 2013 at 4:21 PM, Daniel Mack zon...@gmail.com wrote: [...] + +static SIMPLE_DEV_PM_OPS(edma_pm_ops, edma_pm_suspend, edma_pm_resume); + static struct platform_driver edma_driver = { .driver = { .name = edma, + .pm =