Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-12 Thread Tony Lindgren
* Eliad Peller el...@wizery.com [150310 10:01]: On Tue, Mar 10, 2015 at 6:18 PM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150310 09:11]: On Tue, Mar 10, 2015 at 5:52 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 16:31:33 Eliad Peller wrote:

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-12 Thread Eliad Peller
On Wed, Mar 11, 2015 at 3:21 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Wed, Mar 11, 2015 at 2:17 PM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 14:07:11 Javier Martinez Canillas wrote: Right now it seems that all boards in mainline with a WiLink6 part are

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-12 Thread Arnd Bergmann
On Wednesday 11 March 2015 02:00:59 Javier Martinez Canillas wrote: Hello Tony, On Tue, Mar 10, 2015 at 6:35 PM, Tony Lindgren t...@atomide.com wrote: we do have to make sure these wl18xx bindings are future-compatible with the wl12xx ones, but i think the current bindings are pretty

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-12 Thread Arnd Bergmann
On Wednesday 11 March 2015 14:07:11 Javier Martinez Canillas wrote: Right now it seems that all boards in mainline with a WiLink6 part are using internal clocks. So as a first step I think that adding an optional refclock-frequency and tcxoclock-frequency properties should be enough. It

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-12 Thread Tony Lindgren
* Eliad Peller el...@wizery.com [150311 06:39]: On Wed, Mar 11, 2015 at 3:21 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Wed, Mar 11, 2015 at 2:17 PM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 14:07:11 Javier Martinez Canillas wrote: Right now it seems

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-12 Thread Arnd Bergmann
On Tuesday 10 March 2015 16:31:33 Eliad Peller wrote: On Tue, Mar 10, 2015 at 4:11 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 13:00:19 Eliad Peller wrote: On Tue, Mar 10, 2015 at 12:49 AM, Tony Lindgren t...@atomide.com wrote: I was expecting you to remove all calls

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-12 Thread Arnd Bergmann
On Monday 09 March 2015 23:03:30 Eliad Peller wrote: On Mon, Mar 9, 2015 at 9:50 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 09 March 2015 17:36:42 Eliad Peller wrote: --- a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts +++ b/arch/arm/boot/dts/omap3-igep0030-rev-g.dts @@ -64,4 +64,13 @@

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-12 Thread Tony Lindgren
* Arnd Bergmann a...@arndb.de [150310 08:48]: On Tuesday 10 March 2015 07:28:05 Tony Lindgren wrote: Oops I forgot about the omap3-sbc-t3730, so yes we have to keep the platform data a little bit longer. But nothing stopping us moving all the other ones to use a proper device tree based

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Javier Martinez Canillas
Hello Arnd, On Wed, Mar 11, 2015 at 10:53 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 02:00:59 Javier Martinez Canillas wrote: What do you mean by parsing here? IIUC there isn't a clock driver for these clocks and are setup directly in the

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Javier Martinez Canillas
Hello Arnd, On Wed, Mar 11, 2015 at 1:40 PM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 12:34:03 Javier Martinez Canillas wrote: Hello Arnd, On Wed, Mar 11, 2015 at 10:53 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 02:00:59 Javier Martinez Canillas

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Javier Martinez Canillas
On Wed, Mar 11, 2015 at 2:17 PM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 14:07:11 Javier Martinez Canillas wrote: Right now it seems that all boards in mainline with a WiLink6 part are using internal clocks. So as a first step I think that adding an optional

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Arnd Bergmann
On Wednesday 11 March 2015 14:12:54 Eliad Peller wrote: On Wed, Mar 11, 2015 at 1:34 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: I think that patch [0] should not be needed since for external clocks, the IP providing the clocks should have its own clock driver and for internal

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Arnd Bergmann
On Wednesday 11 March 2015 12:34:03 Javier Martinez Canillas wrote: Hello Arnd, On Wed, Mar 11, 2015 at 10:53 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 11 March 2015 02:00:59 Javier Martinez Canillas wrote: What do you mean by parsing here? IIUC there isn't a clock driver for

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Eliad Peller
hi Javier, On Wed, Mar 11, 2015 at 2:28 AM, Javier Martinez Canillas jav...@dowhile0.org wrote: Hello Eliad, On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote: Add wl18xx (wilink8) bindings to omap3-igep0030-rev-g and omap3-igep0020-rev-f dts files, instead of defining the

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Eliad Peller
hi Javier, On Wed, Mar 11, 2015 at 3:19 AM, Javier Martinez Canillas jav...@dowhile0.org wrote: Hello Eliad, On Wed, Mar 11, 2015 at 1:28 AM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote: ---

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Javier Martinez Canillas
Hello Eliad, On Wed, Mar 11, 2015 at 12:59 PM, Eliad Peller el...@wizery.com wrote: On Wed, Mar 11, 2015 at 3:19 AM, Javier Martinez Canillas jav...@dowhile0.org wrote: But there wasn't a DT binding to describe that so most boards use the same hack which is to define a fake fixed-regulator

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-11 Thread Eliad Peller
On Wed, Mar 11, 2015 at 1:34 PM, Javier Martinez Canillas jav...@dowhile0.org wrote: I think that patch [0] should not be needed since for external clocks, the IP providing the clocks should have its own clock driver and for internal clocks, a property should be used instead as you said. If

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Eliad Peller
On Tue, Mar 10, 2015 at 12:49 AM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150309 14:03]: On Mon, Mar 9, 2015 at 9:50 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 09 March 2015 17:36:42 Eliad Peller wrote: --- a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Tony Lindgren
* Arnd Bergmann a...@arndb.de [150310 07:11]: On Tuesday 10 March 2015 13:00:19 Eliad Peller wrote: On Tue, Mar 10, 2015 at 12:49 AM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150309 14:03]: On Mon, Mar 9, 2015 at 9:50 PM, Arnd Bergmann a...@arndb.de wrote:

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Eliad Peller
On Tue, Mar 10, 2015 at 4:11 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 13:00:19 Eliad Peller wrote: On Tue, Mar 10, 2015 at 12:49 AM, Tony Lindgren t...@atomide.com wrote: I was expecting you to remove all calls to legacy_init_wl12xx from this file, including the

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Sekhar Nori
On Tuesday 10 March 2015 07:41 PM, Arnd Bergmann wrote: On Tuesday 10 March 2015 13:00:19 Eliad Peller wrote: On Tue, Mar 10, 2015 at 12:49 AM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150309 14:03]: On Mon, Mar 9, 2015 at 9:50 PM, Arnd Bergmann a...@arndb.de

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Arnd Bergmann
On Tuesday 10 March 2015 13:00:19 Eliad Peller wrote: On Tue, Mar 10, 2015 at 12:49 AM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150309 14:03]: On Mon, Mar 9, 2015 at 9:50 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 09 March 2015 17:36:42 Eliad Peller

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Eliad Peller
On Tue, Mar 10, 2015 at 6:18 PM, Tony Lindgren t...@atomide.com wrote: * Eliad Peller el...@wizery.com [150310 09:11]: On Tue, Mar 10, 2015 at 5:52 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 16:31:33 Eliad Peller wrote: On Tue, Mar 10, 2015 at 4:11 PM, Arnd Bergmann

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Javier Martinez Canillas
Hello Tony, On Tue, Mar 10, 2015 at 6:35 PM, Tony Lindgren t...@atomide.com wrote: we do have to make sure these wl18xx bindings are future-compatible with the wl12xx ones, but i think the current bindings are pretty much standard (and are actually a subset of the bindings needed by wl12xx),

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Javier Martinez Canillas
Hello Eliad, On Wed, Mar 11, 2015 at 1:28 AM, Javier Martinez Canillas jav...@dowhile0.org wrote: On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote: --- a/arch/arm/boot/dts/omap3-igep0020-rev-f.dts +++ b/arch/arm/boot/dts/omap3-igep0020-rev-f.dts @@ -42,4 +42,13 @@

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Eliad Peller
On Tue, Mar 10, 2015 at 5:52 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 16:31:33 Eliad Peller wrote: On Tue, Mar 10, 2015 at 4:11 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 13:00:19 Eliad Peller wrote: On Tue, Mar 10, 2015 at 12:49 AM, Tony Lindgren

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Arnd Bergmann
On Tuesday 10 March 2015 07:28:05 Tony Lindgren wrote: Oops I forgot about the omap3-sbc-t3730, so yes we have to keep the platform data a little bit longer. But nothing stopping us moving all the other ones to use a proper device tree based configuration. For all I can tell, the t3730

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Tony Lindgren
* Eliad Peller el...@wizery.com [150310 09:11]: On Tue, Mar 10, 2015 at 5:52 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 16:31:33 Eliad Peller wrote: On Tue, Mar 10, 2015 at 4:11 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 10 March 2015 13:00:19 Eliad Peller

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Arnd Bergmann
On Tuesday 10 March 2015 10:35:50 Tony Lindgren wrote: * Eliad Peller el...@wizery.com [150310 10:01]: i'm really not familiar with the common clock framework, but there still doesn't seem to be a way to determine whether a clock is XTAL or not (which is what Luca's patch was about). should

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-10 Thread Javier Martinez Canillas
Hello Eliad, On Mon, Mar 9, 2015 at 4:36 PM, Eliad Peller el...@wizery.com wrote: Add wl18xx (wilink8) bindings to omap3-igep0030-rev-g and omap3-igep0020-rev-f dts files, instead of defining the platform data through the pdata-quirks. The patch was compile-tested only. You should look at

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-09 Thread Eliad Peller
On Mon, Mar 9, 2015 at 9:50 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 09 March 2015 17:36:42 Eliad Peller wrote: --- a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts +++ b/arch/arm/boot/dts/omap3-igep0030-rev-g.dts @@ -64,4 +64,13 @@ vmmc-supply = lbep5clwmc_wlen;

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-09 Thread Arnd Bergmann
On Monday 09 March 2015 17:36:42 Eliad Peller wrote: --- a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts +++ b/arch/arm/boot/dts/omap3-igep0030-rev-g.dts @@ -64,4 +64,13 @@ vmmc-supply = lbep5clwmc_wlen; bus-width = 4; non-removable; + + #address-cells = 1; +

Re: [PATCH v5 3/3] ARM: dts: igep00x0: add wl18xx bindings

2015-03-09 Thread Tony Lindgren
* Eliad Peller el...@wizery.com [150309 14:03]: On Mon, Mar 9, 2015 at 9:50 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 09 March 2015 17:36:42 Eliad Peller wrote: --- a/arch/arm/boot/dts/omap3-igep0030-rev-g.dts +++ b/arch/arm/boot/dts/omap3-igep0030-rev-g.dts @@ -64,4 +64,13 @@