Re: [PATCHv3 19/41] OMAPDSS: panel-dpi: Add DT support

2014-04-28 Thread Tomi Valkeinen
On 26/04/14 02:53, Tony Lindgren wrote: * Tomi Valkeinen tomi.valkei...@ti.com [140424 02:53]: On 18/04/14 18:51, Tony Lindgren wrote: + gpio = of_get_gpio(node, 0); + if (gpio_is_valid(gpio) || gpio == -ENOENT) { + ddata-enable_gpio = gpio; + } else { +

Re: [PATCHv3 19/41] OMAPDSS: panel-dpi: Add DT support

2014-04-28 Thread Tony Lindgren
* Tomi Valkeinen tomi.valkei...@ti.com [140428 03:44]: On 26/04/14 02:53, Tony Lindgren wrote: * Tomi Valkeinen tomi.valkei...@ti.com [140424 02:53]: On 18/04/14 18:51, Tony Lindgren wrote: +gpio = of_get_gpio(node, 0); +if (gpio_is_valid(gpio) || gpio == -ENOENT) { +

Re: [PATCHv3 19/41] OMAPDSS: panel-dpi: Add DT support

2014-04-25 Thread Tony Lindgren
* Tomi Valkeinen tomi.valkei...@ti.com [140424 02:53]: On 18/04/14 18:51, Tony Lindgren wrote: + gpio = of_get_gpio(node, 0); + if (gpio_is_valid(gpio) || gpio == -ENOENT) { + ddata-enable_gpio = gpio; + } else { + dev_err(pdev-dev, failed to parse enable gpio\n);

Re: [PATCHv3 19/41] OMAPDSS: panel-dpi: Add DT support

2014-04-24 Thread Tomi Valkeinen
On 18/04/14 18:51, Tony Lindgren wrote: +gpio = of_get_gpio(node, 0); +if (gpio_is_valid(gpio) || gpio == -ENOENT) { +ddata-enable_gpio = gpio; +} else { +dev_err(pdev-dev, failed to parse enable gpio\n); +return gpio; +} We should set

Re: [PATCHv3 19/41] OMAPDSS: panel-dpi: Add DT support

2014-04-24 Thread Laurent Pinchart
Hi Tomi, On Thursday 24 April 2014 12:52:42 Tomi Valkeinen wrote: On 18/04/14 18:51, Tony Lindgren wrote: + gpio = of_get_gpio(node, 0); + if (gpio_is_valid(gpio) || gpio == -ENOENT) { + ddata-enable_gpio = gpio; + } else { + dev_err(pdev-dev, failed to parse

Re: [PATCHv3 19/41] OMAPDSS: panel-dpi: Add DT support

2014-04-24 Thread Tomi Valkeinen
On 24/04/14 15:44, Laurent Pinchart wrote: I attached prototype patches (based on -rc2) for panel dpi using that approach. It's a bit messier than I'd like, because for non-DT boot we need to request the gpio using the old API, and then convert it to gpio_desc. We can remove that code when

Re: [PATCHv3 19/41] OMAPDSS: panel-dpi: Add DT support

2014-04-18 Thread Tony Lindgren
Hi, Just trying to summarize what has been discussed so far in various threads regarding changes needed to this patch. * Tomi Valkeinen tomi.valkei...@ti.com [140121 03:01]: --- a/drivers/video/omap2/displays-new/panel-dpi.c +++ b/drivers/video/omap2/displays-new/panel-dpi.c @@ -182,6 +186,52

Re: [PATCHv3 19/41] OMAPDSS: panel-dpi: Add DT support

2014-04-08 Thread Tony Lindgren
* Tomi Valkeinen tomi.valkei...@ti.com [140407 22:42]: On 08/04/14 03:13, Tony Lindgren wrote: Tomi, * Tomi Valkeinen tomi.valkei...@ti.com [140121 03:01]: Add DT support for panel-dpi. Looks like this patch did not get merged or am I missing something? Yes, I dropped it. None

Re: [PATCHv3 19/41] OMAPDSS: panel-dpi: Add DT support

2014-04-07 Thread Tony Lindgren
Tomi, * Tomi Valkeinen tomi.valkei...@ti.com [140121 03:01]: Add DT support for panel-dpi. Looks like this patch did not get merged or am I missing something? As you probably are aware, we have at least these boards needing it before we can remove the omap3 legacy support: board-am3517evm.c

Re: [PATCHv3 19/41] OMAPDSS: panel-dpi: Add DT support

2014-04-07 Thread Tomi Valkeinen
On 08/04/14 03:13, Tony Lindgren wrote: Tomi, * Tomi Valkeinen tomi.valkei...@ti.com [140121 03:01]: Add DT support for panel-dpi. Looks like this patch did not get merged or am I missing something? Yes, I dropped it. None of the boards that I converted used panel-dpi. There was so much