Re: regression: crash from 'ls /sys/modules/wl1251_spi/notes'

2010-01-05 Thread Andrew Morton
On Thu, 31 Dec 2009 22:15:08 +0100 Helge Deller del...@gmx.de wrote: On 12/30/2009 04:49 PM, James Bottomley wrote: A better, and more comprehensive patch would be to try not to count the empty text sections when we're building the notes section (and actually anywhere else in the file).

Re: regression: crash from 'ls /sys/modules/wl1251_spi/notes'

2010-01-02 Thread James Bottomley
On Fri, 2010-01-01 at 11:08 +0800, Américo Wang wrote: This patch looks fine for me, except that I don't think it's necessary to introduce an inline function for that... Actually, I really think we do. The whole reason we got into this mess in the first place is that it wasn't obvious from the

Re: regression: crash from 'ls /sys/modules/wl1251_spi/notes'

2009-12-31 Thread Helge Deller
On 12/30/2009 04:49 PM, James Bottomley wrote: A better, and more comprehensive patch would be to try not to count the empty text sections when we're building the notes section (and actually anywhere else in the file). This patch actually relies on the fact that if sh_size is zero for the text

Re: regression: crash from 'ls /sys/modules/wl1251_spi/notes'

2009-12-31 Thread Américo Wang
On Wed, Dec 30, 2009 at 11:49 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Wed, 2009-12-30 at 13:41 +0200, Kalle Valo wrote: Hello, I noticed weird crashes related to wl1251_spi notes sysfs directory with current wireless-testing (2.6.33-rc2 plus some wireless patches).

regression: crash from 'ls /sys/modules/wl1251_spi/notes'

2009-12-30 Thread Kalle Valo
Hello, I noticed weird crashes related to wl1251_spi notes sysfs directory with current wireless-testing (2.6.33-rc2 plus some wireless patches). The simplest way to reproduce the problem is to do this on a nokia n900 (arm/omap 3430): # ls /sys/module/wl1251_spi/notes/ [ 4776.503234] Unable to

Re: regression: crash from 'ls /sys/modules/wl1251_spi/notes'

2009-12-30 Thread James Bottomley
On Wed, 2009-12-30 at 13:41 +0200, Kalle Valo wrote: Hello, I noticed weird crashes related to wl1251_spi notes sysfs directory with current wireless-testing (2.6.33-rc2 plus some wireless patches). The simplest way to reproduce the problem is to do this on a nokia n900 (arm/omap 3430):

Re: regression: crash from 'ls /sys/modules/wl1251_spi/notes'

2009-12-30 Thread Kalle Valo
James Bottomley james.bottom...@hansenpartnership.com writes: On Wed, 2009-12-30 at 13:41 +0200, Kalle Valo wrote: Also removing wl1251_spi causes a crash. The reason for this is that a sysfs file with a null string as name is trying to be removed from the notes directory. Yes, this is