Re: [PATCH 01/02] OMAP3 CPUidle driver

2008-06-23 Thread Högander Jouni
ext Kevin Hilman [EMAIL PROTECTED] writes: [EMAIL PROTECTED] (Högander Jouni) writes: ext Kevin Hilman [EMAIL PROTECTED] writes: Rajendra Nayak [EMAIL PROTECTED] writes: Rajendra Nayak [EMAIL PROTECTED] writes: This patch adds the OMAP3 cpuidle driver. Irq enable/disable is done in

Re: [RFC/PATCH 1/2] Triton Battery charger interface driver for OMAP3430

2008-06-23 Thread Felipe Balbi
On Fri, 20 Jun 2008 17:33:41 +0530 (IST), [EMAIL PROTECTED] wrote: Index: linux-omap-2.6/arch/arm/mach-omap2/devices.c === --- linux-omap-2.6.orig/arch/arm/mach-omap2/devices.c 2008-06-20 15:39:56.0 +0530 +++

Re: [RFC/PATCH 2/2] Triton Battery charger interface driver for OMAP3430

2008-06-23 Thread Felipe Balbi
On Fri, 20 Jun 2008 17:36:00 +0530 (IST), [EMAIL PROTECTED] wrote: +#ifdef CONFIG_TWL4030_BCI_BATTERY +extern int twl4030charger_usb_en(int enable); +#else +static inline int twl4030charger_usb_en(int enable) { return 0; } +#endif this should be in include/linux/i2c/twl4030.h you should

Re: [PATCH 11/21] ARM: OMAP: McBSP: Prepare for splitting into omap1 and omap2 code

2008-06-23 Thread Tony Lindgren
* Tony Lindgren [EMAIL PROTECTED] [080617 11:43]: * Russell King - ARM Linux [EMAIL PROTECTED] [080614 11:17]: On Fri, Jun 06, 2008 at 06:30:43PM -0700, Tony Lindgren wrote: +#if defined(CONFIG_OMAP_MCBSP) || defined(CONFIG_OMAP_MCBSP_MODULE) + +static struct platform_device

Re: [PATCH 11/21] ARM: OMAP: McBSP: Prepare for splitting intoomap1 and omap2 code

2008-06-23 Thread shekhar, chandra
Hi, i was about to send the same patch. it works fine for me. chandra Shekhar - Original Message - From: Tony Lindgren [EMAIL PROTECTED] To: Russell King - ARM Linux [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; Eduardo Valentin [EMAIL PROTECTED]; linux-omap@vger.kernel.org; Nikula

Re: [PATCH 1/1] ARM:OMAP: fix driver MODULE_ALIAS()

2008-06-23 Thread Tony Lindgren
* Hiroshi DOYU [EMAIL PROTECTED] [080613 02:53]: Add a correct MODULE_ALIAS() entry for this driver to enable udev module loading. Pushing today. Tony Signed-off-by: Hiroshi DOYU [EMAIL PROTECTED] --- drivers/input/keyboard/omap-twl4030keypad.c |2 ++

Re: [PATCH 0/3] Updates for tea5761 (take #3)

2008-06-23 Thread Tony Lindgren
* Eduardo Valentin [EMAIL PROTECTED] [080610 20:46]: From: Eduardo Valentin [EMAIL PROTECTED] Hi guys, Following recommendation from v4l people, I'm sending this update to our tea5761 driver. They already had a tuner for this device which communicates through i2c. I needed to update

Re: [PATCH] The fix prevents kernel crash caused by twl4030 power button malfunction.

2008-06-23 Thread Tony Lindgren
* Roman Tereshonkov [EMAIL PROTECTED] [080617 16:49]: If i2c connection is broken the twl4030 power button driver is unregistered. The function input_free_device has to be called only when input_register_device failed. Otherwise input_unregister_device is used. Pushing today. Tony

Re: [PATCH] USB: H4/OHCI/ISP1301 fixes

2008-06-23 Thread Tony Lindgren
Hi, * Imre Deak [EMAIL PROTECTED] [080522 16:34]: While trying to make H4 USB work I had the following issues, attached are patches to fix those: - Fix the H4 board config for the wiring of the ISP1301 transceiver. The platform config had 4 wire configuration but the driver has the 3

Re: [PATCH 2/2] ARM: OMAP: SmartReflex driver integration

2008-06-23 Thread Tony Lindgren
* Kalle Jokiniemi [EMAIL PROTECTED] [080617 10:22]: This patch integrates TI's SmartReflex driver into linux-omap. SmartReflex is a module that adjusts OMAP3 VDD1 and VDD2 operating voltages around the nominal values of current operating point depending on silicon characteristics and operating

Re: [PATCH 1/4] usb: musb: musb on omap3 has 32 endpoints

2008-06-23 Thread Tony Lindgren
* Felipe Balbi [EMAIL PROTECTED] [080613 13:05]: Fix hdrc_cnf.h for omap3 configuration. Does this break the configuration for omap2? We should set these dynamically if different for omap2 and omap3 so we can compile both into the same kernel. Tony Signed-off-by: Felipe Balbi [EMAIL

Re: [PATCH 2/4] usb: musb: add MODULE_ALIAS for udev module loading

2008-06-23 Thread Tony Lindgren
* Felipe Balbi [EMAIL PROTECTED] [080613 13:06]: platform drivers should add MODULE_ALIAS for allowing udev module loading. Pushing today. Tony Signed-off-by: Felipe Balbi [EMAIL PROTECTED] --- drivers/usb/musb/musb_core.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)

Re: [PATCH 4/4] i2c: add MODULE_ALIAS to twl4030 drivers

2008-06-23 Thread Tony Lindgren
* Felipe Balbi [EMAIL PROTECTED] [080613 13:06]: When built as module, it helps udev to probe them. Pushing today. Tony Signed-off-by: Felipe Balbi [EMAIL PROTECTED] --- drivers/i2c/chips/twl4030-core.c|1 + drivers/i2c/chips/twl4030-gpio.c|1 +

Re: [PATCH 1/2] usb: musb: MUSB_OTG should depend on PM

2008-06-23 Thread Tony Lindgren
* Felipe Balbi [EMAIL PROTECTED] [080611 14:09]: Current musb Kconfig causes cyclic depency on x86 arch. The best fix is to depend on PM in order to build on OTG mode. Anyone interested in reproducing the error in your linux-omap trees, just make ARCH=x86 menuconfig I guess this is now

Re: [PATCH 1/4] usb: musb: musb on omap3 has 32 endpoints

2008-06-23 Thread Felipe Balbi
On Mon, Jun 23, 2008 at 02:10:09PM +0300, Tony Lindgren wrote: * Felipe Balbi [EMAIL PROTECTED] [080613 13:05]: Fix hdrc_cnf.h for omap3 configuration. Does this break the configuration for omap2? We should set these dynamically if different for omap2 and omap3 so we can compile both

Re: [PATCH 1/4] usb: musb: musb on omap3 has 32 endpoints

2008-06-23 Thread Tony Lindgren
* Felipe Balbi [EMAIL PROTECTED] [080623 14:16]: On Mon, Jun 23, 2008 at 02:10:09PM +0300, Tony Lindgren wrote: * Felipe Balbi [EMAIL PROTECTED] [080613 13:05]: Fix hdrc_cnf.h for omap3 configuration. Does this break the configuration for omap2? We should set these dynamically if

Re: [PATCH 1/3] Renaming files to reflect name change from 2430OSK to OMAP2EVM

2008-06-23 Thread Tony Lindgren
* arun c [EMAIL PROTECTED] [080611 15:12]: From c379ad7c092bd0230d6c24652a86abb2d8184d64 Mon Sep 17 00:00:00 2001 From: arun [EMAIL PROTECTED] Date: Wed, 11 Jun 2008 14:43:34 +0530 Subject: [PATCH] Renaming files to reflect name change from 2430OSK to OMAP2EVM renamed:

Re: [PATCH 1/3] mtd omap2 nand driver: extend to work with omap3 boards

2008-06-23 Thread Tony Lindgren
* Steve Sakoman [EMAIL PROTECTED] [080612 12:41]: From: Teerth Reddy [EMAIL PROTECTED], Steve Sakoman [EMAIL PROTECTED] Extend omap2 mtd nand driver to work with ARCH_OMAP3 boards Has anybody tested this on earlier omaps? BTW, we should move all the MTD discussion to MTD list and start

Re: [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card

2008-06-23 Thread Tony Lindgren
* Purushotam Kumar [EMAIL PROTECTED] [080616 16:03]: OMAP3:devices.c:Enabling 4-bit for SD card SD card was working in 1-bit mode.This patch will configure SD card in 4-bit mode and hence performance will increase. Signed-off-by: Purushotam Kumar [EMAIL PROTECTED] Acked-by: Madhusudhan

Re: [PATCH] i2c: twl4030: warning: mixed declarations and code

2008-06-23 Thread Tony Lindgren
* Eduardo Valentin [EMAIL PROTECTED] [080611 17:04]: Hi Balbi, On Wed, Jun 11, 2008 at 9:55 AM, Felipe Balbi [EMAIL PROTECTED] wrote: On Wed, Jun 11, 2008 at 09:53:45AM -0400, ext Eduardo Valentin wrote: - struct twl4030_usb *twl = xceiv_to_twl(xceiv); u32 l; +

Re: [RFC/PATCH 1/2] Triton Battery charger interface driver for OMAP3430

2008-06-23 Thread Madhusudhan Chikkature
Hi Felipe, Thanks for the comments. I will fix them and resend the patch.I have some clarification inlined for some of the comments. Best regards, Madhu - Original Message - From: Felipe Balbi [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: linux-omap@vger.kernel.org Sent: Monday, June 23,

Re: [RFC/PATCH 2/2] Triton Battery charger interface driver for OMAP3430

2008-06-23 Thread Madhusudhan Chikkature
Hi Felipe, Thanks for the comments. I will fix it and resend the patch. Best regards, Madhu - Original Message - From: Felipe Balbi [EMAIL PROTECTED] To: [EMAIL PROTECTED] Cc: linux-omap@vger.kernel.org Sent: Monday, June 23, 2008 2:21 PM Subject: Re: [RFC/PATCH 2/2] Triton Battery

Re: [PATCH v2] OMAP3 clock: fix omap2_clk_wait_ready for OMAP3430ES2 DSS

2008-06-23 Thread Paul Walmsley
Hi Jouni On Mon, 23 Jun 2008, Högander Jouni wrote: Hello Paul, It should actually wait for SSI also. Read my comments below. ... And add this part + if (cpu_is_omap34xx() + prcm_mod == OMAP34XX_CM_REGADDR(CORE_MOD, 0) + clk-enable_bit ==

Re: [RFC/PATCH 1/2] Triton Battery charger interface driver for OMAP3430

2008-06-23 Thread Felipe Balbi
Hi, On Mon, 23 Jun 2008 19:04:51 +0530, Madhusudhan Chikkature [EMAIL PROTECTED] wrote: On Fri, 20 Jun 2008 17:33:41 +0530 (IST), [EMAIL PROTECTED] wrote: Index: linux-omap-2.6/arch/arm/mach-omap2/devices.c === ---

Re: [PATCH 1/3] mtd omap2 nand driver: extend to work with omap3 boards

2008-06-23 Thread Koen Kooi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Op 23 jun 2008, om 13:35 heeft Tony Lindgren het volgende geschreven: * Steve Sakoman [EMAIL PROTECTED] [080612 12:41]: From: Teerth Reddy [EMAIL PROTECTED], Steve Sakoman [EMAIL PROTECTED] Extend omap2 mtd nand driver to work with ARCH_OMAP3

Re: DSP BIOS Link support on OMAP3430

2008-06-23 Thread Dirk Behme
Anil S wrote: Hi, Is DSP/BIOS Link ported onto OMAP3430 (linux flavor), if yes from where can I download the sources/archive? I think there was some discussion about this yesterday at beagle IRC http://www.beagleboard.org/irclogs/index.php?date=2008-06-22 Maybe Koen or Philip have

Re: DSP BIOS Link support on OMAP3430

2008-06-23 Thread Koen Kooi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Op 23 jun 2008, om 17:25 heeft Dirk Behme het volgende geschreven: Anil S wrote: Hi, Is DSP/BIOS Link ported onto OMAP3430 (linux flavor), if yes from where can I download the sources/archive? I think there was some discussion about

[PATCH v2] ARM: OMAP3: Fix warnings in clock34xx.h

2008-06-23 Thread Dirk Behme
Fix warnings arch/arm/mach-omap2/clock34xx.h:178: warning: initialization makes pointer from integer without a cast arch/arm/mach-omap2/clock34xx.h:204: warning: initialization makes pointer from integer without a cast arch/arm/mach-omap2/clock34xx.h:229: warning: initialization makes

Re: [PATCH 01/02] OMAP3 CPUidle driver

2008-06-23 Thread Kevin Hilman
[EMAIL PROTECTED] (Högander Jouni) writes: ext Kevin Hilman [EMAIL PROTECTED] writes: [EMAIL PROTECTED] (Högander Jouni) writes: ext Kevin Hilman [EMAIL PROTECTED] writes: Rajendra Nayak [EMAIL PROTECTED] writes: Rajendra Nayak [EMAIL PROTECTED] writes: This patch adds the OMAP3

Re: [PATCH v2] ARM: OMAP3: Fix warnings in clock34xx.h

2008-06-23 Thread Paul Walmsley
On Mon, 23 Jun 2008, Dirk Behme wrote: Fix warnings arch/arm/mach-omap2/clock34xx.h:178: warning: initialization makes pointer from integer without a cast arch/arm/mach-omap2/clock34xx.h:204: warning: initialization makes pointer from integer without a cast

[PATCH 3/3] OMAP3 EVM: Add twl4030 keypad driver support

2008-06-23 Thread Miguel Angel Aguilar Ulloa
Enable twl4030 keypad driver in omap3_evm_defconfig Signed-off-by: Miguel Angel Aguilar [EMAIL PROTECTED] --- a/arch/arm/configs/omap3_evm_defconfig 2008-06-11 08:32:45.0 -0600 +++ b/arch/arm/configs/omap3_evm_defconfig 2008-06-23 14:35:23.0 -0600 @@ -601,7 +601,16

[PATCH 2/3] OMAP3 EVM: Add twl4030 keypad driver support

2008-06-23 Thread Miguel Angel Aguilar Ulloa
Add twl4030 keypad driver support to OMAP3 EVM Signed-off-by: Miguel Angel Aguilar [EMAIL PROTECTED] --- a/drivers/input/keyboard/Kconfig2008-06-23 15:06:17.0 -0600 +++ b/drivers/input/keyboard/Kconfig2008-06-23 14:32:29.0 -0600 @@ -261,7 +261,7 @@ config KEYBOARD_OMAP

[PATCH 1/3] OMAP3 EVM: Add twl4030 keypad driver support

2008-06-23 Thread Miguel Angel Aguilar Ulloa
Add twl4030 keypad driver support to OMAP3 EVM Signed-off-by: Miguel Angel Aguilar [EMAIL PROTECTED] --- a/arch/arm/mach-omap2/board-omap3evm.c 2008-06-23 15:07:13.0 -0600 +++ b/arch/arm/mach-omap2/board-omap3evm.c 2008-06-23 14:32:29.0 -0600 @@ -19,6 +19,7 @@

Re: [PATCH 1/3] OMAP3 EVM: Add twl4030 keypad driver support

2008-06-23 Thread Felipe Balbi
On Mon, Jun 23, 2008 at 03:51:09PM -0600, Miguel Angel Aguilar Ulloa wrote: Add twl4030 keypad driver support to OMAP3 EVM Generally all your patches look really good but the subject should be something more self-explanatory. For this first is ok, but second and third should be something like:

Re: [PATCH 3/3] OMAP3 EVM: Add twl4030 keypad driver support

2008-06-23 Thread Felipe Balbi
On Mon, Jun 23, 2008 at 03:51:20PM -0600, Miguel Angel Aguilar Ulloa wrote: Enable twl4030 keypad driver in omap3_evm_defconfig Signed-off-by: Miguel Angel Aguilar [EMAIL PROTECTED] --- a/arch/arm/configs/omap3_evm_defconfig2008-06-11 08:32:45.0 -0600 +++

RE: [PATCH 1/4] usb: musb: musb on omap3 has 32 endpoints

2008-06-23 Thread Gadiyar, Anand
Fix hdrc_cnf.h for omap3 configuration. Does this break the configuration for omap2? We should set these dynamically if different for omap2 and omap3 so we can compile both into the same kernel. Should check omap2430 trm to be sure, maybe someone in TI could help us with it ? It

Re: [PATCH v2] OMAP3 clock: fix omap2_clk_wait_ready for OMAP3430ES2 DSS

2008-06-23 Thread Högander Jouni
ext Paul Walmsley [EMAIL PROTECTED] writes: Hi Jouni On Mon, 23 Jun 2008, Högander Jouni wrote: Hello Paul, It should actually wait for SSI also. Read my comments below. ... And add this part + if (cpu_is_omap34xx() +prcm_mod == OMAP34XX_CM_REGADDR(CORE_MOD, 0) +