[PATCH 0/3]TWL4030 BCI patches

Hi Tony, I am resending the BCI 3 patch series after fixing the comments provided by Mikko. Regards, Madhu -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[Resending - PATCH 1/3] Triton BCI driver board/device setup for OMAP3430

From: Madhusudhan Chikkature[EMAIL PROTECTED] Device setup/board level initialization for the Triton battery charger interface driver for the OMAP3430 SDP. Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED] --- arch/arm/mach-omap2/Makefile |3 + arch/arm/mach-omap2/bci.c

[Resending - PATCH 3/3] Triton BCI driver for OMAP3430 - USB changes

From: Madhusudhan Chikkature[EMAIL PROTECTED] This patch calls the functionality supported by the TWL4030 battery charger interface driver to enable/disable battery charging upon cable attach/detach. Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED] --- drivers/i2c/chips/twl4030-usb.c |

[Resending - PATCH 2/3] Triton BCI driver for OMAP3430

From: Madhusudhan Chikkature[EMAIL PROTECTED] ARM: OMAP: Triton Battery Charger Interface This patch provides a OMAP Triton battery charger interface driver to moniter the battery through power class subsystem. Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED] --- drivers/power/Kconfig

[PATCH] Free HDQ clocks in error path

Hi, This patch provides the fix to free the HDQ clocks in the error path. Regards, Madhu - From: Madhusudhan Chikkature[EMAIL PROTECTED] ARM: OMAP3: Free HDQ clocks when a read is tried with no battery connected Signed-off-by:

RE: OMAP3 SYS_OFF_MODE support

I am just wondering why these changes are present in smartreflex.c. These should be initialized during prcm init or PMIC init (if there are parameters dependent on PMIC) ideally. I can't think of any dependency between smartreflex and SYS_OFF_MODE feature. -Original Message- From:

Re: N800 problems with MMC, LM8323 on current linux-omap git head

On Tue, 22 Jul 2008 15:47:43 +0300, Riku Voipio [EMAIL PROTECTED] wrote: Hmm. I think it would be better to avoid calling the probe in first place. git diff made the attached patch look more confusing than it actually is. Personally I'd eliminate all ifdefs from those i2c_board_info

Re: N800 problems with MMC, LM8323 on current linux-omap git head

Subject: [PATCH] input: add more error checks to lm8323 driver If we can't reach the driver, we stop trying to probe it. Useful when building kernel for n800 and n810. n800 doesn't have lm8323, so that driver shouldn't probe there. Hmm. I think it would be better to avoid calling the probe

Re: N800 problems with MMC, LM8323 on current linux-omap git head

On Tue, Jul 22, 2008 at 07:52:44AM -0500, Felipe Balbi wrote: On Tue, 22 Jul 2008 15:47:43 +0300, Riku Voipio [EMAIL PROTECTED] wrote: Hmm. I think it would be better to avoid calling the probe in first place. git diff made the attached patch look more confusing than it actually is.

Re: [i2c] N800 problems with MMC, LM8323 on current linux-omap git head

On Tue, Jul 22, 2008 at 04:37:42PM +0300, Riku Voipio wrote: On Tue, Jul 22, 2008 at 07:52:44AM -0500, Felipe Balbi wrote: On Tue, 22 Jul 2008 15:47:43 +0300, Riku Voipio [EMAIL PROTECTED] wrote: Hmm. I think it would be better to avoid calling the probe in first place. git diff made

Re: [i2c] N800 problems with MMC, LM8323 on current linux-omap git head

Hi, On Tue, 22 Jul 2008 14:43:14 +0100, Ben Dooks [EMAIL PROTECTED] wrote: Split them into a common and then machine specfic structures, you are allowed to register more than one board per bus. Good to know :-) Riku, could you update your patch then ? but it anyways doesn't annul the need of

RE: OMAP3 SYS_OFF_MODE support

Currently sr_configure_vc() is the only dedicated API to configure Voltage controller parameter. But still SYSOFF specific configuration shall be moved to prcm init. Regards, Deva -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of TK, Pratheesh

Re: [Resending - PATCH 1/3] Triton BCI driver board/device setup for OMAP3430

Hi Felipe, Tony, weird that we still have these prototypes in these headers. Could be some merging conflict ? Yes. I see that these prototypes are still present in the board3430 and board2430 header files in the omap tree. Anyways, please apply the attached patch. We're using

[PATCH 0/9] TWL4030 bugfixes and cleanups: version 2

[ This is the second version of these patches - they now check the SIH_CTRL.COR bit to determine whether to read or write to clear ] At boot, twl_init_irq() tries to mask off all TWL4030 secondary interrupts and clear them, since no secondary interrupt handlers are registered yet (that happens

[PATCH 2/9] TWL4030: clear TWL GPIO interrupt status registers

twl_init_irq() does not clear the TWL GPIO ISR registers, but the PIH ISR thinks that it has. This causes any previously-latched GPIO interrupts to be stuck on until twl4030-gpio.c initializes, often drowning the console in TWL4030 module irq 368 is disabled but can't be masked! messages.

[PATCH 3/9] TWL4030: use correct register addresses for BCI IMR registers

The existing code to mask and clear BCI interrupts in twl_init_irq() is wrong. It uses the wrong register offsets, it does not mask all of the BCI IMR registers, and it does not clear all of the BCI ISR registers. Signed-off-by: Paul Walmsley [EMAIL PROTECTED] ---

[PATCH 4/9] TWL4030: clear MADC interrupt status registers upon init

twl_init_irq() does not clear MADC interrupt status registers upon init - fix. Signed-off-by: Paul Walmsley [EMAIL PROTECTED] --- drivers/i2c/chips/twl4030-core.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/chips/twl4030-core.c

[PATCH 5/9] TWL4030: use *_SIH_CTRL.COR bit to determine whether to read or write ISR to clear

TWL4030 interrupt status register bits can be cleared in one of two ways: either by reading from the register, or by writing a 1 to the appropriate bit(s) in the register. This behavior can be altered at any time by the twlmodule_SIH_CTRL.COR register bit (clear-on-read). The TWL4030 TRM is

[PATCH 6/9] TWL4030: change init-time IMR mask code to WARN if error

twl_init_irq() prints error messages and returns if any interrupt mask register writes fail. Change this to generate a warning traceback and to continue execution rather than skipping TWL init. (These mask writes should not fail at all unless either the I2C bus or the TWL4030 is somehow wedged.)