On Wed, Sep 24, 2008 at 9:21 AM, Hiroshi DOYU [EMAIL PROTECTED] wrote:
Hi,
How about introducing a new typedef in order to accommodate the
different size of enable_regs without ifdefs?
I think that this is apparently the case categorized into (a) in
'CodyingStyle'.
I am not sure which is
* Arun KS [EMAIL PROTECTED] [080924 10:05]:
On Wed, Sep 24, 2008 at 9:21 AM, Hiroshi DOYU [EMAIL PROTECTED] wrote:
Hi,
How about introducing a new typedef in order to accommodate the
different size of enable_regs without ifdefs?
I think that this is apparently the case categorized
* Tony Lindgren [EMAIL PROTECTED] [080924 10:12]:
* Arun KS [EMAIL PROTECTED] [080924 10:05]:
On Wed, Sep 24, 2008 at 9:21 AM, Hiroshi DOYU [EMAIL PROTECTED] wrote:
Hi,
How about introducing a new typedef in order to accommodate the
different size of enable_regs without ifdefs?
On Wed, 24 Sep 2008, Tony Lindgren wrote:
* Tony Lindgren [EMAIL PROTECTED] [080924 10:12]:
* Arun KS [EMAIL PROTECTED] [080924 10:05]:
On Wed, Sep 24, 2008 at 9:21 AM, Hiroshi DOYU [EMAIL PROTECTED] wrote:
Hi,
How about introducing a new typedef in order to accommodate the
* Paul Walmsley [EMAIL PROTECTED] [080924 11:03]:
On Wed, 24 Sep 2008, Tony Lindgren wrote:
* Tony Lindgren [EMAIL PROTECTED] [080924 10:12]:
* Arun KS [EMAIL PROTECTED] [080924 10:05]:
On Wed, Sep 24, 2008 at 9:21 AM, Hiroshi DOYU [EMAIL PROTECTED] wrote:
Hi,
How about
On Wed, 24 Sep 2008, Tony Lindgren wrote:
* Paul Walmsley [EMAIL PROTECTED] [080924 11:03]:
On Wed, 24 Sep 2008, Tony Lindgren wrote:
* Tony Lindgren [EMAIL PROTECTED] [080924 10:12]:
* Arun KS [EMAIL PROTECTED] [080924 10:05]:
On Wed, Sep 24, 2008 at 9:21 AM, Hiroshi DOYU
* Paul Walmsley [EMAIL PROTECTED] [080924 11:08]:
On Wed, 24 Sep 2008, Tony Lindgren wrote:
* Paul Walmsley [EMAIL PROTECTED] [080924 11:03]:
On Wed, 24 Sep 2008, Tony Lindgren wrote:
* Tony Lindgren [EMAIL PROTECTED] [080924 10:12]:
* Arun KS [EMAIL PROTECTED] [080924 10:05]:
* Russell King - ARM Linux [EMAIL PROTECTED] [080917 10:58]:
On Tue, Sep 16, 2008 at 04:13:57PM -0700, Tony Lindgren wrote:
OK
Here's the patch updated. If necessary, the patch could be broken into
several parts.
I've already got a patch doing what I've outlined (and some other
On Wed, Sep 24, 2008 at 2:04 PM, Tony Lindgren [EMAIL PROTECTED] wrote:
* Paul Walmsley [EMAIL PROTECTED] [080924 11:08]:
On Wed, 24 Sep 2008, Tony Lindgren wrote:
* Paul Walmsley [EMAIL PROTECTED] [080924 11:03]:
On Wed, 24 Sep 2008, Tony Lindgren wrote:
* Tony Lindgren [EMAIL
* Jarkko Nikula [EMAIL PROTECTED] [080922 16:48]:
Bootloader may let McBSP logic running so make sure that block is idle
before requesting IRQs. Also make sure that TX and RX waitqueues are
initialized before request_irq.
Pushing today and adding to upstream queue for RMK.
Tony
* Jarkko Nikula [EMAIL PROTECTED] [080916 16:02]:
Without RX and TX interrupt definitions, the omap_mcbsp_request will
fail on OMAP2430 and OMAP34xx for ports 3-5 since default io_type is
OMAP_MCBSP_IRQ_IO.
Pushing to l-o and merging into your earlier patch
Add support for OMAP2430 in McBSP
* shekhar, chandra [EMAIL PROTECTED] [080910 14:45]:
- Original Message - From: Jarkko Nikula
[EMAIL PROTECTED]
To: ext shekhar, chandra [EMAIL PROTECTED]
Cc: Tony Lindgren [EMAIL PROTECTED]; linux-omap@vger.kernel.org
Sent: Wednesday, September 10, 2008 4:44 PM
Subject: Re: [PATCH
Hi all,
This series contains pending McBSP patches from linux-omap tree
for review.
These patches are against Russell's devel branch as patches
against the mainline tree would currently produce merge conflicts.
Regards,
Tony
--
To unsubscribe from this list: send the line unsubscribe
From: Chandra Shekhar [EMAIL PROTECTED]
Based on Chandra's earlier patches in linux-omap tree.
Signed-off-by: Chandra Shekhar [EMAIL PROTECTED]
Signed-off-by: Tony Lindgren [EMAIL PROTECTED]
---
arch/arm/mach-omap1/mcbsp.c | 37 +--
arch/arm/mach-omap2/mcbsp.c | 74
From: Jarkko Nikula [EMAIL PROTECTED]
Bootloader may let McBSP logic running so make sure that block is idle
before requesting IRQs. Also make sure that TX and RX waitqueues are
initialized before request_irq.
Signed-off-by: Jarkko Nikula [EMAIL PROTECTED]
Signed-off-by: Tony Lindgren [EMAIL
Hi,
clk_disable_unused (in plat-omap/clock.c) is bugged in latest kernel. It
checks whether ck-enable_reg is zero, and in most cases this happens to
be so (CM_FCLKEN = 0.) Seems to be caused by some late change to
clocktree where enable_reg fields are defined as module offsets, not
register
On Tue, Sep 23, 2008 at 12:45:42PM -0700, David Brownell wrote:
On Tuesday 23 September 2008, Koen Kooi wrote:
The clean fix requires twl4030 to be a new style driver.
Fix not yet available. :(
Pushing until we have a better fix.
But twl4030 now is a new style driver, so we
Hi Tony,
I am posting a series of nine patches for the HDQ driver. The patch series
provides cleanup of the driver pointed out by Filipe's diff file, use ioremap
for HDQ base, replace usage of semaphore with mutex, fixes some commenting
style and indentation.
Regards,
Madhu
--
To unsubscribe
From: Madhusudhan Chikkature[EMAIL PROTECTED]
This patch provides the necessary modifications to the driver to remove the
global ptr hdq_data.
Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED]
---
drivers/w1/masters/omap_hdq.c | 137 ++
1 files
From: Madhusudhan Chikkature[EMAIL PROTECTED]
Replace pr_debug with dev_dbg with device information added for debug prints.
Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED]
---
drivers/w1/masters/omap_hdq.c | 54 +++---
1 files changed, 30
From: Madhusudhan Chikkature[EMAIL PROTECTED]
This patch fix the exit paths in the probe function.
Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED]
---
drivers/w1/masters/omap_hdq.c | 85 ++
1 files changed, 45 insertions(+), 40 deletions(-)
* Felipe Balbi [EMAIL PROTECTED] [080924 13:45]:
On Tue, Sep 23, 2008 at 12:45:42PM -0700, David Brownell wrote:
On Tuesday 23 September 2008, Koen Kooi wrote:
The clean fix requires twl4030 to be a new style driver.
Fix not yet available. :(
Pushing until we have a better
From: Madhusudhan Chikkature[EMAIL PROTECTED]
Convert declaration to static.
Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED]
---
drivers/w1/masters/omap_hdq.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
Index: linux-omap-2.6/drivers/w1/masters/omap_hdq.c
From: Madhusudhan Chikkature[EMAIL PROTECTED]
This patch provides the ioremap related changes to the driver.
Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED]
---
drivers/w1/masters/omap_hdq.c | 21 ++---
1 files changed, 14 insertions(+), 7 deletions(-)
Index:
From: Madhusudhan Chikkature[EMAIL PROTECTED]
This patch replaces the usage of semaphore by mutex.
Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED]
---
drivers/w1/masters/omap_hdq.c | 42 ++
1 files changed, 22 insertions(+), 20 deletions(-)
From: Madhusudhan Chikkature[EMAIL PROTECTED]
This patch moves the shared variable into the local structure and protects its
updation.
Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED]
---
drivers/w1/masters/omap_hdq.c | 52 ++
1 files changed, 38
From: Madhusudhan Chikkature[EMAIL PROTECTED]
This patch fixes the indentation, commenting style of a single line comment.
Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED]
---
drivers/w1/masters/omap_hdq.c | 81 +++---
1 files changed, 29
Hello Tony,
This series contains pending McBSP patches from linux-omap tree
for review.
what about adding the patch I sent some time ago[1] to your series?
Best regards
Uwe
[1] Message-Id: [EMAIL PROTECTED]
http://mid.gmane.org/[EMAIL PROTECTED]
--
To unsubscribe from this list: send the
On Wed, Sep 24, 2008 at 04:49:40PM +0530, ext Madhusudhan Chikkature wrote:
From: Madhusudhan Chikkature[EMAIL PROTECTED]
This patch provides the necessary modifications to the driver to remove the
global ptr hdq_data.
Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED]
---
On Wed, Sep 24, 2008 at 05:01:27PM +0530, ext Madhusudhan Chikkature wrote:
From: Madhusudhan Chikkature[EMAIL PROTECTED]
This patch replaces the usage of semaphore by mutex.
Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED]
---
drivers/w1/masters/omap_hdq.c | 42
On Wed, Sep 24, 2008 at 04:49:08PM +0530, ext Madhusudhan Chikkature wrote:
Hi Tony,
I am posting a series of nine patches for the HDQ driver. The patch series
provides cleanup of the driver pointed out by Filipe's diff file, use ioremap
for HDQ base, replace usage of semaphore with mutex,
Hello,
I wonder if this patch should be further split.
To my taste this should be at least:
- Allocate McBSP devices dynamically,
- add 34xx support
maybe more, see below.
diff --git a/arch/arm/mach-omap1/mcbsp.c b/arch/arm/mach-omap1/mcbsp.c
index afb5789..7de7c69 100644
---
* Uwe Kleine-König [EMAIL PROTECTED] [080924 14:45]:
Hello Tony,
This series contains pending McBSP patches from linux-omap tree
for review.
what about adding the patch I sent some time ago[1] to your series?
Best regards
Uwe
[1] Message-Id: [EMAIL PROTECTED]
* Uwe Kleine-König [EMAIL PROTECTED] [080924 14:58]:
Hello,
I wonder if this patch should be further split.
To my taste this should be at least:
- Allocate McBSP devices dynamically,
- add 34xx support
Sure, I think it's a bit hard to read too. Will repost split.
maybe more, see
* Tony Lindgren [EMAIL PROTECTED] [080924 15:10]:
* Uwe Kleine-König [EMAIL PROTECTED] [080924 14:58]:
snip
Hhm, it looks there is already some 34xx support in the file. Should
the commit log be more detailed?
Will split into a separate patch.
I'll change it to say add support for
On Wed, Sep 24, 2008 at 02:55:35PM +0300, Felipe Balbi ([EMAIL PROTECTED])
wrote:
If you fix the comments I gave now, I think the patches should be
applied unless someone else has any comments to them. After that, you
could also prepare a patch sending this particular driver to
Evgeniy
- Original Message -
From: Felipe Balbi [EMAIL PROTECTED]
To: ext Madhusudhan Chikkature [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED];
linux-omap@vger.kernel.org
Sent: Wednesday, September 24, 2008 5:20 PM
Subject: Re: [PATCH 7/9]HDQ driver:replace
-Original Message-
From: [EMAIL PROTECTED] On Behalf Of Chikkature Rajashekar, Madhusudhan
- Original Message - From: Felipe Balbi [EMAIL PROTECTED]
On Wed, Sep 24, 2008 at 05:01:27PM +0530, ext Madhusudhan Chikkature wrote:
From: Madhusudhan Chikkature[EMAIL PROTECTED]
- Original Message -
From: Gadiyar, Anand [EMAIL PROTECTED]
To: Chikkature Rajashekar, Madhusudhan [EMAIL PROTECTED]; [EMAIL
PROTECTED]
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED];
linux-omap@vger.kernel.org
Sent: Wednesday, September 24, 2008 6:35 PM
Subject: RE:
Hi all,
This series contains pending McBSP patches from linux-omap tree
for review.
These patches are against Russell's devel branch as patches
against the mainline tree would currently produce merge conflicts.
Regards,
Tony
--
To unsubscribe from this list: send the line unsubscribe
From: Uwe Kleine-König [EMAIL PROTECTED]
echo -n omap-mcbsp.1 /sys/bus/platform/driver/omap-mcbsp/unbind
echo -n omap-mcbsp.1 /sys/bus/platform/driver/omap-mcbsp/bind
While at it move the remove function to the .devexit.text section.
Signed-off-by: Uwe Kleine-König [EMAIL
From: Chandra Shekhar [EMAIL PROTECTED]
Based on Chandra's earlier patches in linux-omap tree.
Note that omap1_mcbsp_check and omap2_mcbsp_check are no longer
needed as there's now omap_mcbsp_check_valid_id() defined.
Also some functions can now be marked __init.
Signed-off-by: Chandra Shekhar
From: Chandra Shekhar [EMAIL PROTECTED]
Based on Chandra's earlier patches in linux-omap tree.
Signed-off-by: Chandra Shekhar [EMAIL PROTECTED]
Signed-off-by: Tony Lindgren [EMAIL PROTECTED]
---
arch/arm/mach-omap2/mcbsp.c | 56 ++-
From: Jarkko Nikula [EMAIL PROTECTED]
Bootloader may let McBSP logic running so make sure that block is idle
before requesting IRQs. Also make sure that TX and RX waitqueues are
initialized before request_irq.
Signed-off-by: Jarkko Nikula [EMAIL PROTECTED]
Signed-off-by: Tony Lindgren [EMAIL
* Tony Lindgren [EMAIL PROTECTED] [080924 16:29]:
From: Uwe Kleine-König [EMAIL PROTECTED]
echo -n omap-mcbsp.1 /sys/bus/platform/driver/omap-mcbsp/unbind
echo -n omap-mcbsp.1 /sys/bus/platform/driver/omap-mcbsp/bind
While at it move the remove function to the .devexit.text
On Wed, 24 Sep 2008, Tony Lindgren wrote:
How about this for a quick fix? It produces now a bunch of warnings
until omap1 clock uses offsets too.
Looks good to me. Good to see that VIRTUAL_IO_ADDRESS flag gone --
- Paul
--
To unsubscribe from this list: send the line unsubscribe linux-omap
Signed-off-by: Peter 'p2' De Schrijver [EMAIL PROTECTED]
---
arch/arm/mach-omap2/pm-debug.c | 107 ++--
1 files changed, 16 insertions(+), 91 deletions(-)
diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
index 380a2a0..a375312
This patchset makes the PM counters no longer debug only. This will allow
drivers to decide if they need to reinitialize the hardware due to an off to on
transition.
This probably needs some more work/thinking.
Peter 'p2' De Schrijver (5):
Move some counter functions to powerdomain.c
Adapt
Signed-off-by: Peter 'p2' De Schrijver [EMAIL PROTECTED]
---
arch/arm/mach-omap2/pm.h | 14 --
1 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
index aad4aeb..16212c1 100644
--- a/arch/arm/mach-omap2/pm.h
+++
Hello Tero (and anyone else),
On Wed, 24 Sep 2008, [EMAIL PROTECTED] wrote:
clk_disable_unused (in plat-omap/clock.c) is bugged in latest kernel. It
checks whether ck-enable_reg is zero, and in most cases this happens to
be so (CM_FCLKEN = 0.) Seems to be caused by some late change to
Signed-off-by: Peter 'p2' De Schrijver [EMAIL PROTECTED]
---
arch/arm/mach-omap2/clock.c |3 ++-
arch/arm/mach-omap2/clockdomain.c |4 ++--
arch/arm/mach-omap2/pm34xx.c | 10 +-
3 files changed, 9 insertions(+), 8 deletions(-)
diff --git
This patchset makes the PM counters no longer debug only. This will allow
drivers to decide if they need to reinitialize the hardware due to an off to on
transition. Patchset was made against the pm-0 branch.
Peter 'p2' De Schrijver (5):
Move some counter functions to powerdomain.c
Adapt
Signed-off-by: Peter 'p2' De Schrijver [EMAIL PROTECTED]
---
arch/arm/mach-omap2/pm-debug.c | 107 ++--
1 files changed, 16 insertions(+), 91 deletions(-)
diff --git a/arch/arm/mach-omap2/pm-debug.c b/arch/arm/mach-omap2/pm-debug.c
index 380a2a0..a375312
Signed-off-by: Peter 'p2' De Schrijver [EMAIL PROTECTED]
---
arch/arm/mach-omap2/pm.h | 14 --
1 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
index aad4aeb..16212c1 100644
--- a/arch/arm/mach-omap2/pm.h
+++
Signed-off-by: Peter 'p2' De Schrijver [EMAIL PROTECTED]
---
arch/arm/plat-omap/include/mach/powerdomain.h | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/arch/arm/plat-omap/include/mach/powerdomain.h
b/arch/arm/plat-omap/include/mach/powerdomain.h
index
This patch adds ads7846 touchscreen support to omap2evm board
Signed-off-by: Arun KS [EMAIL PROTECTED]
---
arch/arm/mach-omap2/board-omap2evm.c | 64 ++
arch/arm/mach-omap2/mux.c| 11
This patch enables mcspi support in defconfig
Signed-off-by: Arun KS [EMAIL PROTECTED]
---
arch/arm/configs/omap2_evm_defconfig |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/arm/configs/omap2_evm_defconfig
b/arch/arm/configs/omap2_evm_defconfig
index
* Arun KS [EMAIL PROTECTED] [080924 17:14]:
This patch adds ads7846 touchscreen support to omap2evm board
Can you please split the mux changes into a separate patch?
Thanks,
Tony
Signed-off-by: Arun KS [EMAIL PROTECTED]
---
arch/arm/mach-omap2/board-omap2evm.c | 64
* Paul Walmsley [EMAIL PROTECTED] [080924 17:06]:
On Wed, 24 Sep 2008, Tony Lindgren wrote:
How about this for a quick fix? It produces now a bunch of warnings
until omap1 clock uses offsets too.
Looks good to me. Good to see that VIRTUAL_IO_ADDRESS flag gone --
OK, pushed with a
On Wed, 24 Sep 2008, Tony Lindgren wrote:
* Paul Walmsley [EMAIL PROTECTED] [080924 17:06]:
On Wed, 24 Sep 2008, Tony Lindgren wrote:
How about this for a quick fix? It produces now a bunch of warnings
until omap1 clock uses offsets too.
Looks good to me. Good to see that
This patch adds ads7846 touchscreen support to omap2evm board
Signed-off-by: Arun KS [EMAIL PROTECTED]
---
arch/arm/mach-omap2/board-omap2evm.c | 64 ++
arch/arm/plat-omap/include/mach/board-omap2evm.h |2 +
2 files changed, 66 insertions(+), 0 deletions(-)
This patch enables mcspi support in omap2evm defconfig.
Signed-off-by: Arun KS [EMAIL PROTECTED]
---
arch/arm/configs/omap2_evm_defconfig |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/arm/configs/omap2_evm_defconfig
b/arch/arm/configs/omap2_evm_defconfig
Hi Tony,
just ignore this patch.
I will resend this patch.
Thanks,
Arun
On Wed, Sep 24, 2008 at 8:08 PM, Arun KS [EMAIL PROTECTED] wrote:
This patch adds mcspi1 and gpio_85 mux configuration for 2430.
Signed-off-by: Arun KS [EMAIL PROTECTED]
---
arch/arm/mach-omap2/mux.c | 11
This patch adds mcspi1 and gpio_85 mux configuration on 2430
Signed-off-by: Arun KS [EMAIL PROTECTED]
---
arch/arm/mach-omap2/mux.c | 10 ++
arch/arm/plat-omap/include/mach/mux.h |9 +
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git
On Wednesday 24 September 2008, Felipe Balbi wrote:
I'll do the GPIO code, which will be a slightly more
interesting example than the RTC.
I can do the keypad since I'm already working on the usb as well.
OK. Good to know folk are actively working on getting
this in shape for upstream!
On Wed, Sep 24, 2008 at 08:34:16AM -0700, David Brownell wrote:
On Wednesday 24 September 2008, Felipe Balbi wrote:
I'll do the GPIO code, which will be a slightly more
interesting example than the RTC.
I can do the keypad since I'm already working on the usb as well.
OK. Good
On Wed, Sep 24, 2008 at 06:35:57PM +0530, Gadiyar, Anand wrote:
Oh, I guess Felipe uses `checkpatch.pl --strict`, right Felipe?
right ;-)
--
balbi
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Hi,
Please ignore all the previous patches I have send.
I did some modifications and here are the final series.
Patch 1 : Adds mux settings required for mspi1 and gpio_85.
Patch 2 : Adds support for ads7846 touchscreen driver on omap2evm.
Patch 3 : Updates the defconfig of omap2evm board with
This patch adds mcspi1 and gpio_85 mux configuration for 2430.
Signed-off-by: Arun KS [EMAIL PROTECTED]
---
arch/arm/mach-omap2/mux.c | 10 ++
arch/arm/plat-omap/include/mach/mux.h |9 +
2 files changed, 19 insertions(+), 0 deletions(-)
diff --git
Adding ads7846 touchscreen support to omap2evm board
Signed-off-by: Arun KS [EMAIL PROTECTED]
---
arch/arm/mach-omap2/board-omap2evm.c | 67 ++
arch/arm/plat-omap/include/mach/board-omap2evm.h |5 +-
2 files changed, 70 insertions(+), 2 deletions(-)
diff
On Thu, 25 Sep 2008 11:04:07 +0530
ext Arun KS [EMAIL PROTECTED] wrote:
This patch adds mcspi1 and gpio_85 mux configuration for 2430.
Signed-off-by: Arun KS [EMAIL PROTECTED]
---
arch/arm/mach-omap2/mux.c | 10 ++
arch/arm/plat-omap/include/mach/mux.h |9
On Thu, Sep 25, 2008 at 11:23 AM, Jarkko Nikula [EMAIL PROTECTED] wrote:
On Thu, 25 Sep 2008 11:04:07 +0530
ext Arun KS [EMAIL PROTECTED] wrote:
This patch adds mcspi1 and gpio_85 mux configuration for 2430.
Signed-off-by: Arun KS [EMAIL PROTECTED]
---
arch/arm/mach-omap2/mux.c
72 matches
Mail list logo
