Re: [PATCH] ARM: OMAP2+: watchdog: fix !PM boot crash, disarm timer after hwmod reset

2012-04-24 Thread Shilimkar, Santosh
On Sat, Apr 21, 2012 at 2:29 AM, Paul Walmsley p...@pwsan.com wrote: cc Santosh Hi Kevin, Nice changelog! On Fri, 13 Apr 2012, Kevin Hilman wrote: Without runtime PM enabled, hwmod needs to leave all IP blocks in an enabled state by default so any driver access to the HW will succeed.

Re: [PATCH 1/2] OMAP2+: UART: Fix incorrect population of default uart pads

2012-04-24 Thread Raja, Govindraj
On Tue, Apr 24, 2012 at 5:15 AM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: From: Govindraj.R govindraj.r...@ti.com The following commit: (7496ba3  ARM: OMAP2+: UART: Add default mux for all uarts) added default pads for all uarts. But not all boards tend

Re: defconfig for panda

2012-04-24 Thread Raja, Govindraj
On Fri, Apr 20, 2012 at 10:43 PM, Tony Lindgren t...@atomide.com wrote: * Matt Porter mpor...@ti.com [120420 09:04]: On Fri, Mar 30, 2012 at 02:39:32PM -0700, Tony Lindgren wrote: * Kumar Gala ga...@kernel.crashing.org [120330 14:14]: On Mar 30, 2012, at 1:48 PM, Tony Lindgren wrote:

Re: PM related performance degradation on OMAP3

2012-04-24 Thread Jean Pihet
Hi Grazvydas, Kevin, I did some gather some performance measurements and statistics using custom tracepoints in __omap3_enter_idle. All the details are at http://www.omappedia.org/wiki/Power_Management_Device_Latencies_Measurement#C1_performance_problem:_analysis . The setup is: - Beagleboard

[PATCH-V4 1/3] ARM: OMAP2/3: Add idle_st bits for ST_32KSYNC timer to prcm-common header

2012-04-24 Thread Vaibhav Hiremath
Add missing idle_st bit for 32k-sync timer into the prcm-common header file, required for hwmod data. Signed-off-by: Vaibhav Hiremath hvaib...@ti.com Cc: Felipe Balbi ba...@ti.com Cc: Benoit Cousson b-cous...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Paul Walmsley p...@pwsan.com ---

[PATCH-V4 2/3] ARM: OMAP2/3: hwmod data: Add 32k-sync timer data to hwmod database

2012-04-24 Thread Vaibhav Hiremath
Add 32k-sync timer hwmod-data and add ocp_if details to omap2 3 hwmod table. Signed-off-by: Vaibhav Hiremath hvaib...@ti.com Signed-off-by: Felipe Balbi ba...@ti.com Cc: Benoit Cousson b-cous...@ti.com Cc: Tony Lindgren t...@atomide.com Cc: Paul Walmsley p...@pwsan.com ---

[PATCH-V4 3/3] ARM: OMAP: Make OMAP clocksource source selection using kernel param

2012-04-24 Thread Vaibhav Hiremath
Current OMAP code supports couple of clocksource options based on compilation flag (CONFIG_OMAP_32K_TIMER). The 32KHz sync-timer and a gptimer which can run on 32KHz or system clock (e.g 38.4 MHz). So there can be 3 options - 1. 32KHz sync-timer 2. Sys_clock based (e.g 13/19.2/26/38.4 MHz)

[PATCH-V4 0/3] ARM: OMAP: Make OMAP clocksource source selection runtime

2012-04-24 Thread Vaibhav Hiremath
Current OMAP code supports couple of clocksource options based on compilation flag (CONFIG_OMAP_32K_TIMER). The 32KHz sync-timer and a gptimer which can run on 32KHz or system clock (e.g 38.4 MHz) This patch series cleans up the existing 32k-sync timer implementation without any major code

Re: [PATCH-V4 0/3] ARM: OMAP: Make OMAP clocksource source selection runtime

2012-04-24 Thread Shilimkar, Santosh
On Tue, Apr 24, 2012 at 3:15 PM, Vaibhav Hiremath hvaib...@ti.com wrote: Current OMAP code supports couple of clocksource options based on compilation flag (CONFIG_OMAP_32K_TIMER). The 32KHz sync-timer and a gptimer which can run on 32KHz or system clock (e.g 38.4 MHz) This patch series

RE: [PATCH-V4 0/3] ARM: OMAP: Make OMAP clocksource source selection runtime

2012-04-24 Thread Hiremath, Vaibhav
On Tue, Apr 24, 2012 at 15:36:43, Shilimkar, Santosh wrote: On Tue, Apr 24, 2012 at 3:15 PM, Vaibhav Hiremath hvaib...@ti.com wrote: Current OMAP code supports couple of clocksource options based on compilation flag (CONFIG_OMAP_32K_TIMER). The 32KHz sync-timer and a gptimer which can run

Re: [PATCH 3/8] dmaengine: split out virtual channel DMA support from sa11x0 driver

2012-04-24 Thread Laxman Dewangan
On Wednesday 18 April 2012 03:41 PM, Russell King wrote: +/** + * vchan_cookie_complete - report completion of a descriptor + * vd: virtual descriptor to update + * + * vc.lock must be held by caller + */ +static inline void vchan_cookie_complete(struct virt_dma_desc *vd) +{ + struct

Re: PM related performance degradation on OMAP3

2012-04-24 Thread Santosh Shilimkar
+ Tero On Tuesday 24 April 2012 03:20 PM, Jean Pihet wrote: Hi Grazvydas, Kevin, I did some gather some performance measurements and statistics using custom tracepoints in __omap3_enter_idle. All the details are at

Re: [RFC 00/12] OMAP DMA engine conversion

2012-04-24 Thread Russell King - ARM Linux
Here's another patch - for the OMAP NAND driver. One thing this doesn't do is configure up the source/destination bursts, which the old code did: omap_set_dma_dest_burst_mode(info-dma_ch, OMAP_DMA_DATA_BURST_16);

Re: [PATCH 3/8] dmaengine: split out virtual channel DMA support from sa11x0 driver

2012-04-24 Thread Russell King - ARM Linux
On Tue, Apr 24, 2012 at 04:05:29PM +0530, Laxman Dewangan wrote: On Wednesday 18 April 2012 03:41 PM, Russell King wrote: +/** + * vchan_cookie_complete - report completion of a descriptor + * vd: virtual descriptor to update + * + * vc.lock must be held by caller + */ +static inline void

Re: [PATCH 3/8] dmaengine: split out virtual channel DMA support from sa11x0 driver

2012-04-24 Thread Laxman Dewangan
On Tuesday 24 April 2012 04:20 PM, Russell King - ARM Linux wrote: For cyclic case, we will not like to call the dma_cookie_complete() but want to put the desc in callback list. So can we have one more arg on this function which byspass the call of dma_cookie_complete() See the discussion on

RE: OMAP3EVM not booting on l-o master

2012-04-24 Thread Mohammed, Afzal
Hi Tero, On Mon, Apr 23, 2012 at 17:29:48, Kristo, Tero wrote: Okay thats good (although I wonder why the attachment got corrupted.) Did you check if the device suspends / resumes properly also? Can you check what do you have in the /proc/interrupts for the hwmod_io interrupt just after boot

Re: PM related performance degradation on OMAP3

2012-04-24 Thread Tero Kristo
On Tue, 2012-04-24 at 16:08 +0530, Santosh Shilimkar wrote: + Tero On Tuesday 24 April 2012 03:20 PM, Jean Pihet wrote: Hi Grazvydas, Kevin, I did some gather some performance measurements and statistics using custom tracepoints in __omap3_enter_idle. All the details are at

RE: OMAP3EVM not booting on l-o master

2012-04-24 Thread Tero Kristo
On Tue, 2012-04-24 at 14:00 +0200, Mohammed, Afzal wrote: Hi Tero, On Mon, Apr 23, 2012 at 17:29:48, Kristo, Tero wrote: Okay thats good (although I wonder why the attachment got corrupted.) Did you check if the device suspends / resumes properly also? Can you check what do you have in

Re: PM related performance degradation on OMAP3

2012-04-24 Thread Jean Pihet
Hi Tero, On Tue, Apr 24, 2012 at 2:21 PM, Tero Kristo t-kri...@ti.com wrote: On Tue, 2012-04-24 at 16:08 +0530, Santosh Shilimkar wrote: + Tero On Tuesday 24 April 2012 03:20 PM, Jean Pihet wrote: Hi Grazvydas, Kevin, I did some gather some performance measurements and statistics using

Re: PM related performance degradation on OMAP3

2012-04-24 Thread Tero Kristo
On Tue, 2012-04-24 at 14:50 +0200, Jean Pihet wrote: Hi Tero, On Tue, Apr 24, 2012 at 2:21 PM, Tero Kristo t-kri...@ti.com wrote: On Tue, 2012-04-24 at 16:08 +0530, Santosh Shilimkar wrote: + Tero On Tuesday 24 April 2012 03:20 PM, Jean Pihet wrote: Hi Grazvydas, Kevin, I did

[PATCH 00/18][V3] ARM: OMAP3/4 : cpuidle34xx and cpuidle44xx cleanups

2012-04-24 Thread Daniel Lezcano
This patchset makes some cleanup on these cpuidle drivers and consolidate the code across both architecture. Tested on OMAP3 (igepV2). Partially tested on OMAP4 (pandaboard), without offlining the cpu1. V3 : * replace OMAP4_NUM_STATES and OMAP3_NUM_STATES by ARRAY_SIZE * Fixed changelog

[PATCH 01/18][V3] ARM: OMAP4: cpuidle - Remove unused valid field

2012-04-24 Thread Daniel Lezcano
The 'valid' field is never used in the code, let's remove it. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c |9 +++-- 1 files changed, 3

[PATCH 02/18][V3] ARM: OMAP4: cpuidle - Declare the states with the driver declaration

2012-04-24 Thread Daniel Lezcano
The cpuidle API allows to declare statically the states in the driver structure. Let's use it. We do no longer need the fill_cstate function called at runtime and by the way adding more instructions at boot time. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet

[PATCH 03/18][V3] ARM: OMAP4: cpuidle - Remove the cpuidle_params_table table

2012-04-24 Thread Daniel Lezcano
We do not longer need this table as we defined the values in the driver states. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c | 11 +-- 1 files

[PATCH 04/18][V3] ARM: OMAP4: cpuidle - fix static omap4_idle_data declaration

2012-04-24 Thread Daniel Lezcano
Add the static declaration for the omap4_idle_data variable because its scope is in the file only. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c |2

[PATCH 05/18][V3] ARM: OMAP4: cpuidle - Initialize omap4_idle_data at compile time

2012-04-24 Thread Daniel Lezcano
We initialize the omap4_idle_data variable at compile time allowing us to remove in the next patch the initialization done at boot time. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com ---

[PATCH 06/18][V3] ARM: OMAP4: cpuidle - use the omap4_idle_data variable directly

2012-04-24 Thread Daniel Lezcano
We are storing the 'omap4_idle_data' in the private data field of the cpuidle device. As we are using this variable only in this file, that does not really make sense. Let's use the global variable directly. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet

[PATCH 07/18][V3] ARM: OMAP4: cpuidle - remove omap4_idle_data initialization at boot time

2012-04-24 Thread Daniel Lezcano
We initialized it at compile time, no need to do that at boot time. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/cpuidle44xx.c | 24 1

[PATCH 08/18][V3] ARM: OMAP3: cpuidle - remove rx51 cpuidle parameters table

2012-04-24 Thread Daniel Lezcano
As suggested, this table is an optimized version for rx51 and we remove it in order to consolidate the cpuidle code between omap3 and omap4, we remove this specific data definition which is used to override the default omap3 latencies but at the cost of extra code and complexity. In order to not

[PATCH 09/18][V3] ARM: OMAP3: define cpuidle statically

2012-04-24 Thread Daniel Lezcano
Use the new cpuidle API and define in the driver the states. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 86 +--- 1 files changed, 60 insertions(+), 26 deletions(-) diff

[PATCH 10/18][V3] ARM: OMAP3: cpuidle - remove errata check in the init function

2012-04-24 Thread Daniel Lezcano
The errata check is done in the next_valid_state function, no need to check that in the omap3_idle_init function. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- arch/arm/mach-omap2/cpuidle34xx.c | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git

[PATCH 11/18][V3] ARM: OMAP3: cpuidle - remove the 'valid' field

2012-04-24 Thread Daniel Lezcano
With the previous changes all the states are valid, except the last state which can be handled by decreasing the number of states. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 11 ++- 1 files

[PATCH 12/18][V3] ARM: OMAP3: cpuidle - remove cpuidle_params_table

2012-04-24 Thread Daniel Lezcano
We do not longer need the ''cpuidle_params_table' array as we defined the states in the driver and we checked they are all valid. We also remove the structure definition as it is no longer used. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com ---

[PATCH 13/18][V3] ARM: OMAP3: define statically the omap3_idle_data

2012-04-24 Thread Daniel Lezcano
Initialize the omap3_idle_data array at compile time, that will allow to remove the initialization at boot time. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c | 37 - 1

[PATCH 14/18][V3] ARM: OMAP3: cpuidle - use omap3_idle_data directly

2012-04-24 Thread Daniel Lezcano
We are storing the 'omap3_idle_data' in the private data field of the cpuidle device. As we are using this variable only in this file, that does not really make sense. Let's use the global variable directly. As the table is initialized statically, let's remove the initialization at startup too.

[PATCH 15/18][V3] ARM: OMAP3: cpuidle - simplify next_valid_state

2012-04-24 Thread Daniel Lezcano
Simplify the indentation by removing the useless 'else' statement. Remove the first loop for the 'idx' search as we have it already with the 'index' passed as parameter. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com ---

[PATCH 16/18][V3] ARM: OMAP3: set omap3_idle_data as static

2012-04-24 Thread Daniel Lezcano
Reduce the scope of the omap3_idle_data to the file as it is only used in cpuidle34xx.c. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 17/18][V3] ARM: OMAP3/4: consolidate cpuidle Makefile

2012-04-24 Thread Daniel Lezcano
Define a CPU_IDLE section in the makefile, declare the functions in the header files conforming to the kernel coding rules and remove the 'define's in the C files. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/Makefile

[PATCH 18/18][V3] ARM: OMAP3: cpuidle - set global variables static

2012-04-24 Thread Daniel Lezcano
and check the powerdomain lookup is successful. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org Reviewed-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/cpuidle34xx.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/cpuidle34xx.c

[PATCH v3 1/2] ARM: OMAP2+: omap_hwmod: Add api to enable/disable module level wakeup events

2012-04-24 Thread Govindraj.R
From: Govindraj.R govindraj.r...@ti.com On 24xx/34xx/36xx Module level wakeup events are enabled/disabled using PM_WKEN1_CORE/PM_WKEN_PER regs. Add api to control the module level wakeup mechanism from info provided from hwmod data. omap_hwmod_enable/disable_wakeup is used from serial.c which

[PATCH v3 2/2] ARM: omap3: pm: Remove uart module level wakeup configurations

2012-04-24 Thread Govindraj.R
From: Govindraj.R govindraj.r...@ti.com The uart module level wakeups enabling and disabling are now handled from uart driver itself remove the uart module level configurations from pm code. Cc: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@ti.com Cc: Benoit Cousson b-cous...@ti.com Cc:

[PATCH v3 0/2] ARM: omap_hwmod: add api to enable/disable module level wakeup

2012-04-24 Thread Govindraj.R
From: Govindraj.R govindraj.r...@ti.com On omap2/3 module level wakeup is handled using PM_WKEN registers. Expand the hwmod framework to handle the module level wakeup enable registers. Tested on Beagle-xm by enabling and disabling uart wakeups from sysfs Series depends on following patches for

[PATCH/RFT 0/3] ARM: OMAP: PM: reduce overhead of pwrdm pre/post transitions

2012-04-24 Thread Kevin Hilman
Here's a first pass attempt to reduce the overhead of the pre/post transitions by allowing them to be called per powerdomain and making them conditional on powerdomain transtions. This can be used for testing/measurements to see the reduction the latencies involved in entering/exiting idle with

[PATCH/RFT 1/3] ARM: OMAP2+: powerdomain: allow pre/post transtion to be per pwrdm

2012-04-24 Thread Kevin Hilman
Iteration over all power domains in the idle path is unnecessary since only power domains that are transitioning need to be accounted for. Also PRCM register accesses are known to be expensive, so the additional latency added to the idle path is signficiant. In order allow the pre/post

[PATCH/RFT 2/3] ARM: OMAP3: PM: call pre/post transition per powerdomain

2012-04-24 Thread Kevin Hilman
We only need to call the pre/post transtion methods when we know the power state is changing. First, split up the pre/post transition calls to be per-powerdomain, and then make them conditional on whether the power domain is actually changing states. Signed-off-by: Kevin Hilman khil...@ti.com

[PATCH/RFT 3/3] ARM: OMAP3: PM: cleanup cam_pwrdm leftovers

2012-04-24 Thread Kevin Hilman
commit e7410cf7 (02fdb03e69699f26e1370d0e51593dbc8a4e5265) moved mangement of cam_pwrdm to CPUidle but left some remnants behind, namely the call to clkcm_allo_idle() for the clockdomains in the MPU pwrdm. Remove these since they are not necessary and cause unwanted latency in the idle path. Cc:

Re: PM related performance degradation on OMAP3

2012-04-24 Thread Kevin Hilman
Jean Pihet jean.pi...@newoldbits.com writes: Hi Grazvydas, Kevin, I did some gather some performance measurements and statistics using custom tracepoints in __omap3_enter_idle. All the details are at

Re: [PATCH/RFT 1/3] ARM: OMAP2+: powerdomain: allow pre/post transtion to be per pwrdm

2012-04-24 Thread Shilimkar, Santosh
On Tue, Apr 24, 2012 at 7:53 PM, Kevin Hilman khil...@ti.com wrote: Iteration over all power domains in the idle path is unnecessary since only power domains that are transitioning need to be accounted for. Also PRCM register accesses are known to be expensive, so the additional latency added

Re: [PATCHv4 4/8] ARM: OMAP4: hwmod: flag hwmods/modules supporting module level context status

2012-04-24 Thread Jon Hunter
Hi Tero, On 04/20/2012 04:19 AM, Tero Kristo wrote: From: Rajendra Nayak rna...@ti.com On OMAP4 most modules/hwmods support module level context status. On OMAP3 and earlier, we relyed on the power domain level context status. Identify all such modules using a 'HWMOD_CONTEXT_REG' flag, all

Re: [PATCH 01/19] ARM: OMAP4: PM: save/restore all DPLL settings in OFF mode

2012-04-24 Thread Jon Hunter
Hi Tero, On 04/20/2012 04:33 AM, Tero Kristo wrote: [...] +/** + * omap4_dpll_print_reg - dump out a single DPLL register value + * @dpll_reg: register to dump + * @name: name of the register + * @tuple: content of the register + * + * Helper dump function to print out a DPLL register

Re: [PATCHv4 4/8] ARM: OMAP4: hwmod: flag hwmods/modules supporting module level context status

2012-04-24 Thread Tero Kristo
On Mon, 2012-04-23 at 10:52 -0500, Jon Hunter wrote: Hi Tero, On 04/20/2012 04:19 AM, Tero Kristo wrote: From: Rajendra Nayak rna...@ti.com On OMAP4 most modules/hwmods support module level context status. On OMAP3 and earlier, we relyed on the power domain level context status.

Re: HSI: any status updates on omap_ssi?

2012-04-24 Thread Tony Lindgren
* Sebastian Reichel s...@debian.org [120421 04:26]: Hi, Missing omap_ssi support is currently the most important missing feature, to make the mainline kernel on the Nokia N900 useful, see also [0]. Can you prepare SSI inclusion into the mainline kernel, now that HSI has been pulled into

Re: [PATCH v9 11/25] gpio/omap: cleanup omap_gpio_mod_init function

2012-04-24 Thread DebBarma, Tarun Kanti
Hi Janusz, On Tue, Apr 24, 2012 at 12:24 AM, DebBarma, Tarun Kanti tarun.ka...@ti.com wrote: On Sat, Apr 21, 2012 at 7:33 PM, Janusz Krzysztofik jkrzy...@tis.icnet.pl wrote: On Thursday 02 of February 2012 23:00:37 Tarun Kanti DebBarma wrote: With register offsets now defined for respective

Re: [PATCH v9 11/25] gpio/omap: cleanup omap_gpio_mod_init function

2012-04-24 Thread Tony Lindgren
* DebBarma, Tarun Kanti tarun.ka...@ti.com [120424 08:40]: Hi Janusz, On Tue, Apr 24, 2012 at 12:24 AM, DebBarma, Tarun Kanti tarun.ka...@ti.com wrote: On Sat, Apr 21, 2012 at 7:33 PM, Janusz Krzysztofik jkrzy...@tis.icnet.pl wrote: On Thursday 02 of February 2012 23:00:37 Tarun Kanti

Re: [PATCH v3 1/2] ARM: OMAP2+: omap_hwmod: Add api to enable/disable module level wakeup events

2012-04-24 Thread Tony Lindgren
* Govindraj.R govindraj.r...@ti.com [120424 07:12]: From: Govindraj.R govindraj.r...@ti.com On 24xx/34xx/36xx Module level wakeup events are enabled/disabled using PM_WKEN1_CORE/PM_WKEN_PER regs. Add api to control the module level wakeup mechanism from info provided from hwmod data.

Re: [PATCH-V4 3/3] ARM: OMAP: Make OMAP clocksource source selection using kernel param

2012-04-24 Thread Tony Lindgren
Hi, * Vaibhav Hiremath hvaib...@ti.com [120424 02:54]: Current OMAP code supports couple of clocksource options based on compilation flag (CONFIG_OMAP_32K_TIMER). The 32KHz sync-timer and a gptimer which can run on 32KHz or system clock (e.g 38.4 MHz). So there can be 3 options - 1. 32KHz

Re: HSI: any status updates on omap_ssi?

2012-04-24 Thread Sebastian Reichel
On Tue, Apr 24, 2012 at 08:23:16AM -0700, Tony Lindgren wrote: * Sebastian Reichel s...@debian.org [120421 04:26]: Hi, Missing omap_ssi support is currently the most important missing feature, to make the mainline kernel on the Nokia N900 useful, see also [0]. Can you prepare SSI

Re: [PATCH 05/19] ARM: OMAP4: PM: Add SAR backup support towards device OFF

2012-04-24 Thread Tony Lindgren
* Tero Kristo t-kri...@ti.com [120420 02:39]: + +static int omap4_sar_not_accessible(void) +{ + u32 usbhost_state, usbtll_state; + + /* + * Make sure that USB host and TLL modules are not + * enabled before attempting to save the context + * registers, otherwise

Re: [PATCH 06/19] ARM: OMAP4: Auto generate SAR layout contents

2012-04-24 Thread Tony Lindgren
* Tero Kristo t-kri...@ti.com [120420 02:38]: -void omap4_sar_overwrite(void) +void omap_sar_overwrite(void) { u32 val = 0; - u32 offset = 0; + u32 usb_offset = 0x2ec; + u32 usb_offset2 = 0x91c; - if (cpu_is_omap446x()) - offset = 0x04; + if

Re: [PATCH 12/19] ARM: OMAP4: PM: update ROM return address for OSWR and OFF

2012-04-24 Thread Tony Lindgren
* Tero Kristo t-kri...@ti.com [120420 02:39]: @@ -384,6 +386,17 @@ int omap4_enter_lowpower(unsigned int cpu, unsigned int power_state) set_cpu_next_pwrst(wakeup_cpu, PWRDM_POWER_ON); if (omap4_mpuss_read_prev_context_state()) { + /* + * Dummy

Re: HSI: any status updates on omap_ssi?

2012-04-24 Thread Tony Lindgren
* Sebastian Reichel s...@debian.org [120424 09:31]: On Tue, Apr 24, 2012 at 08:23:16AM -0700, Tony Lindgren wrote: * Sebastian Reichel s...@debian.org [120421 04:26]: Hi, Missing omap_ssi support is currently the most important missing feature, to make the mainline kernel on the

Re: [RFC 00/12] OMAP DMA engine conversion

2012-04-24 Thread Tony Lindgren
* Russell King - ARM Linux li...@arm.linux.org.uk [120424 03:42]: Here's another patch - for the OMAP NAND driver. One thing this doesn't do is configure up the source/destination bursts, which the old code did: omap_set_dma_dest_burst_mode(info-dma_ch,

OMAPDSS basic concepts

2012-04-24 Thread Felix Lin
Hello All, I'm pretty new to the OMAP DSS and would like to understand how it works under Linux/Android. I have read the TRM and understood that the DSS uses DMA to move pixels from the main memory to several hardware pipelines, with each burst of a few lines. But I am wondering - 1 - when

Re: OMAP3EVM not booting on l-o master

2012-04-24 Thread Kevin Hilman
Hi Tero, Tero Kristo t-kri...@ti.com writes: On Fri, 2012-04-06 at 07:52 +, Mohammed, Afzal wrote: Hi Paul, On Fri, Apr 06, 2012 at 12:43:06, Paul Walmsley wrote: Perhaps you might be willing to add some debugging to omap_mux_late_init() to find out what part of that function is

Re: [PATCHv4 4/8] ARM: OMAP4: hwmod: flag hwmods/modules supporting module level context status

2012-04-24 Thread Cousson, Benoit
On 4/24/2012 4:46 PM, Tero Kristo wrote: On Mon, 2012-04-23 at 10:52 -0500, Jon Hunter wrote: Hi Tero, On 04/20/2012 04:19 AM, Tero Kristo wrote: From: Rajendra Nayakrna...@ti.com On OMAP4 most modules/hwmods support module level context status. On OMAP3 and earlier, we relyed on the power

Re: [PATCH] OMAP4: panda: add statics to remove warnings

2012-04-24 Thread Tony Lindgren
* Tomi Valkeinen tomi.valkei...@ti.com [120423 00:43]: Add statics to board-omap4-panda.c's internal functions and data structures to remove warnings. Care to update with the warnings produced? Tony Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com ---

Re: [PATCH 08/19] ARM: OMAP4: PM: Add device-off support

2012-04-24 Thread Jon Hunter
Hi Tero, On 04/20/2012 04:33 AM, Tero Kristo wrote: This patch adds device off support to OMAP4 device type. OFF mode is disabled by default, however, there are two ways to enable OFF mode: a) In the board file, call omap4_pm_off_mode_enable(1) b) Enable OFF mode using the debugfs entry

Re: [PATCH 10/19] ARM: OMAP4: PM: Work-around for ROM code BUG of IVAHD/TESLA

2012-04-24 Thread Jon Hunter
Hi Tero, On 04/20/2012 04:33 AM, Tero Kristo wrote: From: Santosh Shilimkar santosh.shilim...@ti.com The ROM BUG is when MPU Domain OFF wake up sequence that can compromise IVA and Tesla execution. At wakeup from MPU OFF on HS device only (not GP device), when restoring the Secure RAM,

Re: [PATCH 11/19] ARM: OMAP4: PM: save/restore CM L3INSTR registers when MPU hits OSWR/OFF mode

2012-04-24 Thread Jon Hunter
Hi Tero, On 04/20/2012 04:33 AM, Tero Kristo wrote: From: Rajendra Nayak rna...@ti.com On HS devices on the way out of MPU OSWR and OFF ROM code wrongly overwrites the CM L3INSTR registers. So to avoid this, save them and restore on the way out from MPU OSWR/OFF. This appears to be an

Re: [PATCHv8 06/10] I2C: OMAP: Fix the crash in i2c remove

2012-04-24 Thread Shubhrajyoti
On Monday 23 April 2012 10:19 PM, Wolfram Sang wrote: [ 154.901153] Exception stack(0xdf9b9fb0 to 0xdf9b9ff8) [ 154.907104] 9fa0: beaf1f04 4006be00 000f 000c [ 154.915710] 9fc0: 4006c000 8034 ff40 0007

Re: [PATCHv8 06/10] I2C: OMAP: Fix the crash in i2c remove

2012-04-24 Thread Wolfram Sang
On Tue, Apr 24, 2012 at 11:44:15PM +0530, Shubhrajyoti wrote: On Monday 23 April 2012 10:19 PM, Wolfram Sang wrote: [ 154.901153] Exception stack(0xdf9b9fb0 to 0xdf9b9ff8) [ 154.907104] 9fa0: beaf1f04 4006be00 000f 000c [

Re: [PATCH 15/19] ARM: OMAP4430: PM: workaround for DDR corruption on second CS

2012-04-24 Thread Jon Hunter
Hi Tero, On 04/20/2012 04:33 AM, Tero Kristo wrote: From: Santosh Shilimkar santosh.shilim...@ti.com Work around for Errata ID: i632 LPDDR2 Corruption After OFF Mode Transition When CS1 Is Used On EMIF which impacts OMAP443x silicon The issue occurs when EMIF_SDRAM_CONFIG is restored first

Re: [PATCH 03/12] arm: omap3: Only sleep in cpuidle driver if I/O wake-ups work

2012-04-24 Thread Mark A. Greer
On Wed, Apr 11, 2012 at 03:37:47PM -0600, Paul Walmsley wrote: Hi Hi Paul, Kevin. On Wed, 11 Apr 2012, Mark A. Greer wrote: From: Mark A. Greer mgr...@animalcreek.com Currently, the OMAP3 cpuidle driver calls omap3_enter_idle() which calls omap_sram_idle(). omap_sram_idle()

Re: [PATCH 06/12] mmc: omap_hsmmc: remove private DMA API implementation

2012-04-24 Thread Grazvydas Ignotas
On Mon, Apr 23, 2012 at 7:06 PM, Russell King rmk+ker...@arm.linux.org.uk wrote: Remove the private DMA API implementation from omap_hsmmc, making it use entirely the DMA engine API. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Since the driver becomes useless without DMA_ENGINE,

Re: [PATCH 06/12] mmc: omap_hsmmc: remove private DMA API implementation

2012-04-24 Thread Russell King - ARM Linux
On Wed, Apr 25, 2012 at 12:51:09AM +0300, Grazvydas Ignotas wrote: On Mon, Apr 23, 2012 at 7:06 PM, Russell King rmk+ker...@arm.linux.org.uk wrote: Remove the private DMA API implementation from omap_hsmmc, making it use entirely the DMA engine API. Signed-off-by: Russell King

Re: [PATCH v9 11/25] gpio/omap: cleanup omap_gpio_mod_init function

2012-04-24 Thread Janusz Krzysztofik
Dnia wtorek, 24 kwietnia 2012 21:06:59 DebBarma, Tarun Kanti pisze: Hi Janusz, Here is the patch, with attachment as well. I have just tested on OMAP4 platform. Testing on other OMAP2+ platforms is pending. In the meantime can you please validate on OMAP1 platform and confirm? Thanks. Hi,

Re: [RFC 00/12] OMAP DMA engine conversion

2012-04-24 Thread Grazvydas Ignotas
On Tue, Apr 24, 2012 at 7:51 PM, Tony Lindgren t...@atomide.com wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [120424 03:42]: Here's another patch - for the OMAP NAND driver. One thing this doesn't do is configure up the source/destination bursts, which the old code did:          

Re: [PATCH/RFT 0/3] ARM: OMAP: PM: reduce overhead of pwrdm pre/post transitions

2012-04-24 Thread Grazvydas Ignotas
On Tue, Apr 24, 2012 at 5:23 PM, Kevin Hilman khil...@ti.com wrote: Here's a first pass attempt to reduce the overhead of the pre/post transitions by allowing them to be called per powerdomain and making them conditional on powerdomain transtions. This can be used for testing/measurements to

Re: [PATCH 03/12] arm: omap3: Only sleep in cpuidle driver if I/O wake-ups work

2012-04-24 Thread Mark A. Greer
On Tue, Apr 24, 2012 at 01:51:05PM -0700, Mark A. Greer wrote: On Wed, Apr 11, 2012 at 03:37:47PM -0600, Paul Walmsley wrote: Hi Hi Paul, Kevin. On Wed, 11 Apr 2012, Mark A. Greer wrote: From: Mark A. Greer mgr...@animalcreek.com Currently, the OMAP3 cpuidle driver calls

Re: [RFC 00/12] OMAP DMA engine conversion

2012-04-24 Thread Russell King - ARM Linux
On Wed, Apr 25, 2012 at 01:47:21AM +0300, Grazvydas Ignotas wrote: On Tue, Apr 24, 2012 at 7:51 PM, Tony Lindgren t...@atomide.com wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [120424 03:42]: Here's another patch - for the OMAP NAND driver. One thing this doesn't do is

Re: [RFC 00/12] OMAP DMA engine conversion

2012-04-24 Thread Grazvydas Ignotas
On Wed, Apr 25, 2012 at 2:29 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Apr 25, 2012 at 01:47:21AM +0300, Grazvydas Ignotas wrote: On Tue, Apr 24, 2012 at 7:51 PM, Tony Lindgren t...@atomide.com wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [120424 03:42]:

Re: [PATCH-V3 2/3] ARM: OMAP3+: clockdomain33xx: Add clockdomain data and respective operations

2012-04-24 Thread Paul Walmsley
Hello Vaibhav, Afzal, Vaibhav, A few questions while reviewing this patch: On Tue, 3 Apr 2012, Vaibhav Hiremath wrote: AM33XX PRCM module consist of, various clockdomains, in all total we have 18 clockdomains available, with following controlling options, - NO Sleep: sleep transition can

Re: [PATCH-V3 3/3] ARM: OMAP3+: clock33xx: Add AM33XX clock tree data

2012-04-24 Thread Paul Walmsley
Hello Vaibhav, Afzal, Vaibhav, On Tue, 3 Apr 2012, Vaibhav Hiremath wrote: AM33XX clock implementation is different than any existing OMAP family of devices. Although DPLL module is similar to OMAP4 device, but the usage is very much different than OMAP4. AM33XX has different peripheral set

[PATCH v2] ASoC: omap-pcm: Free dma buffers in case of error.

2012-04-24 Thread Oleg Matcovschi
Change-Id: I4ba9de0de4681332539246ccc5e11a7a8fb32e79 Signed-off-by: Oleg Matcovschi oleg.matcovs...@ti.com --- v1: initial revision v2: resending patch including maintainers sound/soc/omap/omap-pcm.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 01/10] OMAPDSS: HDMI: Remove ASoC codec

2012-04-24 Thread Ricardo Neri
Hi Tomi, Thanks for your comments! On 04/23/2012 08:17 AM, Tomi Valkeinen wrote: On Wed, 2012-03-28 at 16:38 -0600, Ricardo Neri wrote: Instead of having an ASoC codec embedded into DSS code, use the generic DSS device driverinterface for audio support. This allows to any potential user,

[PATCH 1/2] ARM: omap_hdq: Fix some error/debug handling.

2012-04-24 Thread NeilBrown
- some debug messages missed spaces. The did this because they broke a string onto 2 lines - badly. That practice is currently out of favour, so join the two strings together, insert the space, and put newlines elsewhere. - sometimes no error was returned when it should have been -

[PATCH 2/2] ARM: omap_hdq: use wait_event_timeout to wait for read to complete.

2012-04-24 Thread NeilBrown
There is no gain in having a loop - there is no risk of missing the interrupt with wait_event_timeout. Signed-off-by: NeilBrown ne...@suse.de --- drivers/w1/masters/omap_hdq.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/w1/masters/omap_hdq.c

[PATCH 0/3] Ensure twl4030 interrupts are lost during suspend.

2012-04-24 Thread NeilBrown
Sorry for the scatter-gun list of email address, but while each of these patches only touches one subsystem, they really needed each other to provide proper context. The goal is to ensure that an interrupt that arrives on a TWL4030 connected to an OMAP3, during the 'late-suspend' stage will cause

[PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts.

2012-04-24 Thread NeilBrown
All interrupts can wake-from-sleep (I think) so it should be permissible to call enable_irq_wake(). Setting this flag allows that. It is needed because without this, an interrupt which is delivered during late suspend will get ignored but will not cause suspend to abort. If enable_irq_wake() is

[PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts.

2012-04-24 Thread NeilBrown
Level triggered interrupts do not cause IRQS_PENDING to be set, so check_wakeup_irqs ignores them. They don't need to set IRQS_PENDING as the level stays high which shows that they must be pending. However if such an interrupt fired during late suspend, it will have been masked so the fact that

[PATCH 3/3] twl4030: enable wakeup on twl4030 IRQ.

2012-04-24 Thread NeilBrown
Most of the interrupts that come through this line should trigger wakeups: power button RTC alarm power available usb plug/unplug so mark the interrupt as a wakeup interrupt. This is particularly important for when the interrupt arrives during the late suspend phase. Without this setting

Re: [PATCH 02/10] OMAPDSS: HDMI: OMAP4: Remove CEA-861 audio infoframe and IEC-60958 enums

2012-04-24 Thread Ricardo Neri
On 04/23/2012 08:12 AM, Tomi Valkeinen wrote: On Wed, 2012-03-28 at 16:38 -0600, Ricardo Neri wrote: In order to avoid duplication of definitions. Use the definitions provided by asoundef.h. Furthermore, as CEA-861 and IEC-60958 are used by both DisplayPort and HDMI, this helps to make the code

Re: [PATCH 03/10] OMAPDSS: HDMI: OMAP4: Correcty typo in I2S definitions

2012-04-24 Thread Ricardo Neri
On 04/23/2012 07:42 AM, Tomi Valkeinen wrote: On Wed, 2012-03-28 at 16:38 -0600, Ricardo Neri wrote: Signed-off-by: Ricardo Neriricardo.n...@ti.com There's a typo in the subject of the typo fix =). Oops! I totally missed it. I will fix. And always provide a patch description, please. In

Re: [PATCH 05/10] OMAPDSS: HDMI: Decouple HDMI audio from ASoC

2012-04-24 Thread Ricardo Neri
On 04/23/2012 08:25 AM, Tomi Valkeinen wrote: On Wed, 2012-03-28 at 16:38 -0600, Ricardo Neri wrote: Instead of having OMAPDSS HDMI audio functionality depending on the ASoC HDMI audio driver, use a new config option so that potential users, including ASoC, may select if needed.

Re: [PATCH v9 11/25] gpio/omap: cleanup omap_gpio_mod_init function

2012-04-24 Thread DebBarma, Tarun Kanti
On Tue, Apr 24, 2012 at 9:34 PM, Tony Lindgren t...@atomide.com wrote: * DebBarma, Tarun Kanti tarun.ka...@ti.com [120424 08:40]: Hi Janusz, On Tue, Apr 24, 2012 at 12:24 AM, DebBarma, Tarun Kanti tarun.ka...@ti.com wrote: On Sat, Apr 21, 2012 at 7:33 PM, Janusz Krzysztofik

Re: [PATCH 10/10] OMAPDSS: HDMI: Implement DSS driver interface for audio

2012-04-24 Thread Ricardo Neri
On 04/23/2012 08:01 AM, Tomi Valkeinen wrote: On Wed, 2012-03-28 at 16:38 -0600, Ricardo Neri wrote: Implement the DSS device driver audio support interface in the HDMI panel driver and generic driver. The implementation relies on the IP-specific functions that are defined at DSS probe time. A

RE: [PATCH-V3 3/3] ARM: OMAP3+: clock33xx: Add AM33XX clock tree data

2012-04-24 Thread Hiremath, Vaibhav
On Wed, Apr 25, 2012 at 06:33:26, Paul Walmsley wrote: Hello Vaibhav, Afzal, Vaibhav, On Tue, 3 Apr 2012, Vaibhav Hiremath wrote: AM33XX clock implementation is different than any existing OMAP family of devices. Although DPLL module is similar to OMAP4 device, but the usage is very