RE: [PATCH 3/3] ARM: OMAP2+: gpmc: handle additional timings

2012-06-15 Thread Mohammed, Afzal
Hi Tony, On Fri, Jun 15, 2012 at 11:12:46, Mohammed, Afzal wrote: But I am unable to find reason for failure upon using gpmc_ticks_to_ns(1), which seems to me right thing to be used. Let me try to invoke tusb6010 functions in beagle board, observe timings so that at least I will get an idea

RE: [PATCH 2/3] ARM: OMAP2+: onenand: cleanup for gpmc driver conversion

2012-06-15 Thread Mohammed, Afzal
Hi Jon, On Thu, Jun 14, 2012 at 23:23:48, Hunter, Jon wrote: On 06/14/2012 12:40 AM, Mohammed, Afzal wrote: During gpmc driver probe, it will configure all the connected peripherals, if configuration details are not present at that point of time, gpmc driver will cry out saying that

Re: [PATCH v3 4/4] memory: emif: add device tree support to emif driver

2012-06-15 Thread Shilimkar, Santosh
On Thu, Jun 14, 2012 at 9:18 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Jun 14, 2012 at 03:59:24PM +0530, Santosh Shilimkar wrote: From: Aneesh V ane...@ti.com Device tree support for the EMIF driver. Reviewed-by: Benoit Cousson b-cous...@ti.com Reviewed-by:

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-15 Thread Guennadi Liakhovetski
On Thu, 14 Jun 2012, Jon Hunter wrote: On 06/14/2012 10:17 AM, Guennadi Liakhovetski wrote: Hi all Sorry for jumping in so late in the game. But I think, the model, to which this discussion is slowly converging, is not very well suitable for the shdma DMACs, present on SH and ARM

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-15 Thread Arnd Bergmann
On Thursday 14 June 2012, Jon Hunter wrote: On 06/14/2012 06:48 AM, Arnd Bergmann wrote: On Wednesday 13 June 2012, Jon Hunter wrote: So in that case, I don't see why the first cell after the phandle could not be an index which could be either a direction or request-id and then the next

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-15 Thread Arnd Bergmann
On Thursday 14 June 2012, Jon Hunter wrote: Generic DMACs can perform memory-to-memory DMA, USB DMACs cannot. Generic DMACs can serve any slave (peripheral) request line on any their physical channel, USB DMACs only serve fixed USB controller instances. To configure (connect) a

Re: [PATCHv2 08/12] ARM: OMAP4: hwmod data: add SL2IF hardreset line

2012-06-15 Thread Cousson, Benoit
On 6/15/2012 1:02 AM, Paul Walmsley wrote: On Thu, 14 Jun 2012, Cousson, Benoit wrote: Yep, but for that I'd rather add a flag than a information that is a duplication of the parent data. Great, send a patch. Cool. Well, in fact the HWMOD_EXT_OPT_MAIN_CLK patch is already good enough

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-15 Thread Guennadi Liakhovetski
Hi Arnd On Fri, 15 Jun 2012, Arnd Bergmann wrote: On Thursday 14 June 2012, Jon Hunter wrote: Generic DMACs can perform memory-to-memory DMA, USB DMACs cannot. Generic DMACs can serve any slave (peripheral) request line on any their physical channel, USB DMACs only serve fixed

Re: [RFC PATCH 03/11] arm: omap: device: create a device for system control module

2012-06-15 Thread Valentin, Eduardo
Hello Konstantin, Sorry for the delayed reply. On Thu, Jun 14, 2012 at 4:50 PM, Konstantin Baydarov kbaida...@dev.rtsoft.ru wrote:  Hi. On 05/29/2012 01:44 PM, Eduardo Valentin wrote: On Fri, May 25, 2012 at 02:30:44PM +0200, Cousson Benoit wrote: On 5/25/2012 10:25 AM, Eduardo Valentin

Re: [PATCH] pinctrl: Add one-register-per-pin type device tree based pinctrl driver

2012-06-15 Thread Tony Lindgren
Hi, * Stephen Warren swar...@wwwdotorg.org [120614 16:16]: On 06/11/2012 07:58 AM, Tony Lindgren wrote: Add one-register-per-pin type device tree based pinctrl driver. Currently this driver only works on omap2+ series of processors, where there is either an 8 or 16-bit padconf register

RE: [PATCH v5 02/14] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-06-15 Thread Mohammed, Afzal
Hi Jon, On Fri, Jun 15, 2012 at 00:28:44, Hunter, Jon wrote: On 06/14/2012 08:32 AM, Mohammed, Afzal wrote: On Thu, Jun 14, 2012 at 18:52:55, Hunter, Jon wrote: Why? You currently have a global variable storing the clock handle. It can be quite common for drivers to know the clock

RE: [PATCH v5 02/14] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-06-15 Thread Mohammed, Afzal
Hi Jon, On Fri, Jun 15, 2012 at 02:21:50, Hunter, Jon wrote: On 06/14/2012 01:17 AM, Mohammed, Afzal wrote: gpmc_cs_set_timings() does currently convert time to clock cycles required, and this gpmc driver have the capability to do it. What I was saying is a different issue, input to

Re: [PATCH 3/3] ARM: OMAP2+: gpmc: handle additional timings

2012-06-15 Thread Tony Lindgren
* Mohammed, Afzal af...@ti.com [120614 23:20]: Hi Tony, On Fri, Jun 15, 2012 at 11:12:46, Mohammed, Afzal wrote: But I am unable to find reason for failure upon using gpmc_ticks_to_ns(1), which seems to me right thing to be used. Let me try to invoke tusb6010 functions in beagle board,

RE: [PATCH 3/3] ARM: OMAP2+: gpmc: handle additional timings

2012-06-15 Thread Mohammed, Afzal
Hi Tony, On Fri, Jun 15, 2012 at 16:15:43, Tony Lindgren wrote: something yesterday when manually patching the clk_activation, maybe I put the clk_activation value into async timings instead as I was seeing the tick value set to 0 for the sync mode. I too thought like that initially, but

RE: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-15 Thread Mohammed, Afzal
Hi Jon, On Fri, Jun 15, 2012 at 02:36:26, Hunter, Jon wrote: On 06/14/2012 03:48 AM, Mohammed, Afzal wrote: What I meant is we are not dependent on absolute value of flag to find waitpin, and I disagree in depending on its absolute value, which can change, while flag would be the same.

RE: [PATCH v5 00/14] GPMC driver conversion

2012-06-15 Thread Mohammed, Afzal
Hi Tony, On Wed, Jun 13, 2012 at 18:03:05, Tony Lindgren wrote: Cool, yeah looks like the old interface almost works. I had to undo the new additions for tusb6010 DMA to work as below. Then Jon has some good comments. I also made few comments to the GPMC using driver changes. Thanks and

Re: usage of sparse or other trick for improved type safety

2012-06-15 Thread Jean Pihet
Hi! Added Paul in Cc:. On Thu, Jun 14, 2012 at 10:05 AM, Jean Pihet jean.pi...@newoldbits.com wrote: Hi Richard, all, On Tue, Jun 12, 2012 at 6:34 PM, Woodruff, Richard r-woodru...@ti.com wrote: Hi Tony, From: Tony Lindgren [mailto:t...@atomide.com] Sent: Friday, May 25, 2012 2:53 AM

Re: [PATCH 2/8] ARM: OMAP2+: PM: introduce power domains functional states

2012-06-15 Thread Jean Pihet
Hi, Here are some remarks I got after an internal review. I think those points need to be discussed with a broader audience. On Thu, Jun 14, 2012 at 4:53 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Introduce functional (or logical) states for power domains and the API functions to read the

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-15 Thread Arnd Bergmann
On Friday 15 June 2012, Guennadi Liakhovetski wrote: In the common case, you could have one device connected to the third slave ID of the first controller but the fifth slave ID of the second controller. In this case, you really have to specify each controller with its slave ID separately,

Re: [PATCH 5/8] ARM: OMAP2+: PM: introduce power domains achievable functional states

2012-06-15 Thread Jean Pihet
Hi, Here are some remarks I got after an internal review. I think those points need to be discussed with a broader audience. On Thu, Jun 14, 2012 at 4:53 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Note: the patch is in RFC state because the state machine for setting the next power domain

Re: [PATCH 01/10] ARM: OMAP2+: PM QoS: control the power domains next state from the constraints

2012-06-15 Thread Jean Pihet
Hi, Here are some remarks I got after an internal review. I think those points need to be discussed with a broader audience. On Thu, Jun 14, 2012 at 5:05 PM, Jean Pihet jean.pi...@newoldbits.com wrote: When a PM QoS device latency constraint is requested or removed the constraint is stored in

Re: MFD USB host: prevents CORE retention in idle

2012-06-15 Thread Munegowda, Keshava
On Tue, Jun 12, 2012 at 6:28 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: hi kevin     now I am using initramfs with kernel linux3.5.rc1, but the retention is not working in 3430 sdp.  I am seeing the following error followed by a crash echo mem /sys/power/state [   35.609252]

Re: [PATCH v5 02/14] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-06-15 Thread Tony Lindgren
* Mohammed, Afzal af...@ti.com [120615 03:26]: Hi Jon, On Fri, Jun 15, 2012 at 00:28:44, Hunter, Jon wrote: On 06/14/2012 08:32 AM, Mohammed, Afzal wrote: On Thu, Jun 14, 2012 at 18:52:55, Hunter, Jon wrote: Why? You currently have a global variable storing the clock handle. It

board_onenand_init() build error in linux-next

2012-06-15 Thread Joe Woodward
Someone may have spotted this already... But if you build todays linux-next (next-20120615) without CONFIG_MTD_ONENAND_OMAP2 or CONFIG_MTD_ONENAND_OMAP2_MODULE then board_onenand_init() is defined in two places (in board-flash.c:102 as an empty function, and board-flash.h:56 as a static

Re: [PATCH v5 00/14] GPMC driver conversion

2012-06-15 Thread Tony Lindgren
* Mohammed, Afzal af...@ti.com [120615 04:00]: On Wed, Jun 13, 2012 at 18:03:05, Tony Lindgren wrote: And we need the device tree bindings for GPMC so we can start dropping board-*.c files as the GPMC seems to be last remaining blocker for making rarely used legacy boards DT only. So

Re: [PATCHv2 02/12] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-15 Thread Cousson, Benoit
Hi Paul, On 6/15/2012 2:18 AM, Paul Walmsley wrote: On Thu, 14 Jun 2012, Cousson, Benoit wrote: On 6/14/2012 8:04 PM, Paul Walmsley wrote: On Thu, 14 Jun 2012, Cousson, Benoit wrote: (attribution lost) Furthermore, the PRCM will never request target idle for this IP block while the

[PATCH] ARM: OMAP2: twl-common: Fix compiler warning

2012-06-15 Thread Peter Ujfalusi
If the kernel is built only for OMAP2 the following warning will show up: arch/arm/mach-omap2/twl-common.c:52: warning: ‘twl_set_voltage’ defined but not used arch/arm/mach-omap2/twl-common.c:58: warning: ‘twl_get_voltage’ defined but not used The twl_set/get_voltage callbacks only used when

Re: MFD USB host: prevents CORE retention in idle

2012-06-15 Thread Jean Pihet
Hi Keshava, On Fri, Jun 15, 2012 at 2:04 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: On Tue, Jun 12, 2012 at 6:28 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: hi kevin     now I am using initramfs with kernel linux3.5.rc1, but the retention is not working in 3430 sdp.  I

Re: [PATCH V4 12/12] ARM: OMAP2+: Simplify dmtimer clock aliases

2012-06-15 Thread Jon Hunter
Hi Paul, On 06/14/2012 03:31 PM, Paul Walmsley wrote: Hi Jon On Tue, 5 Jun 2012, Jon Hunter wrote: The OMAP dmtimer driver allows you to dynamically configure the functional clock that drives the timer logic. The dmtimer driver uses the device name and a con-id string to search for the

Re: [PATCH v5 02/14] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-06-15 Thread Jon Hunter
Hi Paul, On 06/14/2012 07:20 PM, Paul Walmsley wrote: On Thu, 14 Jun 2012, Jon Hunter wrote: What does make this a bit more difficult is the function gpmc_round_ns_to_ticks(). It appears to convert nanoseconds to ticks and back to nanoseconds. I am guessing to account for some rounding

Re: [PATCH] pinctrl: Add one-register-per-pin type device tree based pinctrl driver

2012-06-15 Thread Stephen Warren
On 06/15/2012 03:49 AM, Tony Lindgren wrote: (Arnd, Grant, Rob, CC'ing you mainly re: the very last set of comments in this email; can you take a look at Tony's patch and comment on the binding) * Stephen Warren swar...@wwwdotorg.org [120614 16:16]: On 06/11/2012 07:58 AM, Tony Lindgren wrote:

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-15 Thread Mitch Bradley
On 6/15/2012 1:27 AM, Arnd Bergmann wrote: On Friday 15 June 2012, Guennadi Liakhovetski wrote: In the common case, you could have one device connected to the third slave ID of the first controller but the fifth slave ID of the second controller. In this case, you really have to specify each

Re: Problems in the DaVinci EMAC driver AM35xx?

2012-06-15 Thread CF Adad
We continue to try to sort this out.  Ignoring the errors for a moment, has anyone else experienced the performance slowdown quoted below between two EMACs? If not, could anyone with two AM3517-baed platforms with the EMACs exposed please test this for us?  We've run several tests between all

[PATCH] OMAPDSS: HDMI: Discard phy_tx_enabled member

2012-06-15 Thread jaswinder . singh
From: Jassi Brar jaswinder.si...@linaro.org Explicitly maintaining HDMI phy power state using a flag is prone to race and un-necessary when we have a zero-cost alternative of checking the state before trying to set it. Signed-off-by: Jassi Brar jaswinder.si...@linaro.org ---

Re: [PATCH V2 5/5] Input: ads7846: set proper debounce time in driver level

2012-06-15 Thread zumeng.chen
On 2012年06月14日 14:59, Zumeng Chen wrote: 于 2012年06月14日 14:31, Hiremath, Vaibhav 写道: On Thu, Jun 14, 2012 at 10:16:55, Zumeng Chen wrote: 于 2012年06月13日 20:18, Hiremath, Vaibhav 写道: On Wed, Jun 13, 2012 at 07:14:10, Zumeng Chen wrote: From: Zumeng Chenzumeng.c...@windriver.com If we don't set

Re: [PATCH V4 12/12] ARM: OMAP2+: Simplify dmtimer clock aliases

2012-06-15 Thread Paul Walmsley
On Tue, 5 Jun 2012, Jon Hunter wrote: The OMAP dmtimer driver allows you to dynamically configure the functional clock that drives the timer logic. The dmtimer driver uses the device name and a con-id string to search for the appropriate functional clock. Currently, we define a clock alias

[PATCH 0/3] OMAP: hwmod: reset API proposal

2012-06-15 Thread Omar Ramirez Luna
Recent changes in omap_hwmod framework have reworked the behaviour towards hardreset handling, commit 747834a (ARM: OMAP2+: hwmod: revise hardreset behavior) recommends for drivers to implement their own reset sequences until code out-of-tree hits mainline and then their needs and code can be

[PATCH 1/3] ARM: OMAP: hwmod: partially un-reset hwmods might not be properly enabled

2012-06-15 Thread Omar Ramirez Luna
Some IP blocks might not be using/controlling more than one reset line, this check loosens the restriction to fully use hwmod framework for those drivers. E.g.: ipu has reset lines: mmu_cache, cpu0 and cpu1. - cpu1 might not be used and hence (with previous check) won't be fully enabled by

[PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-06-15 Thread Omar Ramirez Luna
For a reset sequence to complete cleanly, a module needs its associated clocks to be enabled, otherwise the timeout check in prcm code can print a false failure (failed to hardreset) that occurs because the clocks aren't powered ON and the status bit checked can't transition without them.

[PATCH 3/3] ARM: OMAP: omap_device: expose hwmod assert/deassert to omap devices

2012-06-15 Thread Omar Ramirez Luna
This APIs are meant to be an interface to hwmod assert/deassert function, omap devices can call them through their platform data to control their reset lines, they are expected to know the name of the reset line they are trying to control. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org ---

[PATCH 0/6] OMAP: iommu: hwmod, reset handling and runtime PM

2012-06-15 Thread Omar Ramirez Luna
Introduced hwmod support for OMAP3 (iva, isp) and OMAP4 (ipu, dsp), along with the corresponding runtime PM and routines to deassert reset lines, enable/disable clocks and configure sysc registers. Due to compatibility an ifdef needs to be propagated (previously on iommu resource info) to hwmod

[PATCH 1/6] ARM: OMAP: iommu: fix including iommu.h without IOMMU_API selected

2012-06-15 Thread Omar Ramirez Luna
If included without IOMMU_API being selected it will break compilation: arch/arm/plat-omap/include/plat/iommu.h: In function 'dev_to_omap_iommu': arch/arm/plat-omap/include/plat/iommu.h:148: error: 'struct dev_archdata' has no member named 'iommu' This will be seen, when hwmod

[PATCH 2/6] ARM: OMAP3: hwmod data: add mmu data for iva and isp

2012-06-15 Thread Omar Ramirez Luna
Add mmu hwmod data for iva and isp. Due to compatibility an ifdef CONFIG_OMAP_IOMMU_IVA2 needs to be propagated (previously on iommu resource info) to hwmod data in OMAP3, so users of iommu and tidspbridge can avoid issues of two modules managing mmu data/irqs/resets; this until tidspbridge can

[PATCH 3/6] ARM: OMAP4: hwmod data: add mmu hwmod for ipu and dsp

2012-06-15 Thread Omar Ramirez Luna
Add mmu hwmod data for ipu and dsp. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 136 +++- 1 files changed, 134 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c

[PATCH 4/6] ARM: OMAP3/4: iommu: migrate to hwmod framework

2012-06-15 Thread Omar Ramirez Luna
Use hwmod data and device attributes to build and register an omap device for iommu driver. - Update the naming convention in isp module. - Remove unneeded check for number of resources, as this is now handled by omap_device and prevents driver from loading. - Now unused, remove platform

[PATCH 5/6] ARM: OMAP2+: iommu: add reset handling

2012-06-15 Thread Omar Ramirez Luna
Recent changes in hwmod now require for drivers to handle reset lines. Otherwise iommu initialization will fail. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/omap-iommu.c|6 ++ arch/arm/plat-omap/include/plat/iommu.h |6 ++

[PATCH 6/6] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-06-15 Thread Omar Ramirez Luna
Use runtime PM functionality interfaced with hwmod enable/idle functions, to replace direct clock operations and sysconfig handling. Due to reset sequence, pm_runtime_put_sync must be used, to avoid possible operations with the module under reset. Signed-off-by: Omar Ramirez Luna