[PATCH] RTC: rtc-twl: Convert to module_platform_driver() and relocate reg_map init

2013-04-16 Thread Peter Ujfalusi
Convert the driver to use module_platform_driver() to register the platform driver and relocate the rtc_reg_map initialization to platform driver's probe function. In this way we can make sure that the twl-core has been already probed since the core driver will create the device at the end of it's

Re: [BUG] omap: mfd/regulator: twl/core: init order

2013-04-16 Thread Peter Ujfalusi
On 04/15/2013 06:25 PM, Tony Lindgren wrote: This fix should not be needed. It just means the real problem is somewhere else. Pinctrl is already before the i2c in drivers/Makefile. Maybe one of the MFD drivers has a wrong initcall level? FYI; I just sent a patch which I believe is the correct

Re: [PATCH] RTC: rtc-twl: Convert to module_platform_driver() and relocate reg_map init

2013-04-16 Thread Tomi Valkeinen
Hi, On 2013-04-16 10:44, Peter Ujfalusi wrote: Convert the driver to use module_platform_driver() to register the platform driver and relocate the rtc_reg_map initialization to platform driver's probe function. In this way we can make sure that the twl-core has been already probed since the

Re: [PATCH] RTC: rtc-twl: Convert to module_platform_driver() and relocate reg_map init

2013-04-16 Thread Peter Ujfalusi
Hi Tomi, On 04/16/2013 10:10 AM, Tomi Valkeinen wrote: Hi, On 2013-04-16 10:44, Peter Ujfalusi wrote: Convert the driver to use module_platform_driver() to register the platform driver and relocate the rtc_reg_map initialization to platform driver's probe function. In this way we can make

[PATCH v2 1/2] RTC: rtc-twl: Fix rtc_reg_map initialization

2013-04-16 Thread Peter Ujfalusi
Initialize the rtc_reg_map in platform_driver's probe function instead at module_init time. This way we can make sure that the twl-core has been already probed and initialized (twl_priv-twl_id is valid) since the platform device for the RTC driver will be created by the twl-core after it finished

[PATCH v2 2/2] RTC: rtc-twl: Cleanup with module_platform_driver() conversion

2013-04-16 Thread Peter Ujfalusi
Use module_platform_driver() to register the platform driver. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com --- drivers/rtc/rtc-twl.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/rtc/rtc-twl.c b/drivers/rtc/rtc-twl.c index c385e9b..22b2fd6 100644

Re: [BUG] omap: mfd/regulator: twl/core: init order

2013-04-16 Thread Grygorii Strashko
On 04/16/2013 10:45 AM, Peter Ujfalusi wrote: On 04/15/2013 06:25 PM, Tony Lindgren wrote: This fix should not be needed. It just means the real problem is somewhere else. Pinctrl is already before the i2c in drivers/Makefile. Maybe one of the MFD drivers has a wrong initcall level? FYI; I

Re: [PATCH] Documentation: dt: update properties in TI GPMC NAND example

2013-04-16 Thread Grant Likely
On Tue, 9 Apr 2013 12:23:35 -0500, Jon Hunter jon-hun...@ti.com wrote: The GPMC timing properties for device-tree have been updated by adding a -ns or -ps suffix to indicate the units of time the property represents. Therefore, update the timing property names for TI GPMC NAND example.

Re: [PATCH v3 1/6] drivers: phy: add generic PHY framework

2013-04-16 Thread Kishon Vijay Abraham I
Hi, On Tuesday 16 April 2013 01:20 AM, Grant Likely wrote: On Mon, 15 Apr 2013 17:56:10 +0530, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Monday 15 April 2013 05:04 PM, Grant Likely wrote: On Wed, 20 Mar 2013 14:42:00 +0530, Kishon Vijay Abraham I kis...@ti.com wrote: The PHY

Re: [PATCH 0/3] Dual EMAC mode implementation of CPSW

2013-04-16 Thread Mark Jackson
On 15/04/13 18:34, Mugunthan V N wrote: On 4/15/2013 10:58 PM, Mark Jackson wrote: On 15/04/13 18:07, Mugunthan V N wrote: On 4/15/2013 12:46 AM, Mark Jackson wrote: snip Notice that at the end, the nfs link appears to come back ok, but the ps command never completes. Any ideas of

Re: [RFC PATCH v2 5/6] ARM: OMAP3+: ABB: introduce ABB driver

2013-04-16 Thread Andrii Tseglytskyi
Hi Mike, On 04/15/2013 07:43 PM, Mike Turquette wrote: Quoting Andrii Tseglytskyi (2013-04-15 06:28:10) Cc: Mike Turquette mturque...@linaro.org Signed-off-by: Andrii.Tseglytskyi andrii.tseglyts...@ti.com Signed-off-by: Mike Turquette mturque...@linaro.org It is very strange to Cc me and

Re: [RFC PATCH v2 0/6] ARM: OMAP3+: Introduce ABB driver

2013-04-16 Thread Andrii Tseglytskyi
Hi Kevin, On 04/16/2013 12:53 AM, Kevin Hilman wrote: Andrii Tseglytskyi andrii.tseglyts...@ti.com writes: From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com Following patch series introduces the Adaptive Body-Bias LDO driver, which handles LDOs voltage during OPP change routine. Current

Re: [PATCH 1/2] USB: ehci-omap: Don't select any PHY driver

2013-04-16 Thread Alan Stern
On Mon, 15 Apr 2013, Roger Quadros wrote: Don't select NOP_USB_XCEIV. Instead, board config must select USB_PHY and the appropriate PHY driver. Also add a hint in Kconfig so that users enabling this driver manually enable the right PHY drivers as well. Gets rid of the below warnings when

Re: [PATCH 2/2] USB: ehci-omap: Improve PHY error handling

2013-04-16 Thread Alan Stern
On Mon, 15 Apr 2013, Roger Quadros wrote: As the USB PHY layer never returns NULL we don't need to check for that condition. If we fail to get the PHY device it could be due to missing USB PHY drivers. Give this hint to the user in the error message. CC: Alan Stern

Re: 4430sdp nfsroot broken with ff5c9059

2013-04-16 Thread Jon Hunter
On 04/15/2013 04:27 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130415 11:15]: ... From 56598ba51a75481b050433bb38b7ae31a5ed4ae8 Mon Sep 17 00:00:00 2001 From: Jon Hunter jon-hun...@ti.com Date: Mon, 15 Apr 2013 13:06:54 -0500 Subject: [PATCH] gpio/omap: ensure gpio context is

Re: adding rpmsg.git to linux next

2013-04-16 Thread Ohad Ben-Cohen
Hi Stephen, On Tue, Apr 16, 2013 at 3:07 AM, Stephen Rothwell s...@canb.auug.org.au wrote: On Mon, 15 Apr 2013 09:28:17 +0300 Ohad Ben-Cohen o...@wizery.com wrote: Could you please add: git://git.kernel.org/pub/scm/linux/kernel/git/ohad/rpmsg.git#for-next to linux-next to include new stuff

Re: [BUG] omap: mfd/regulator: twl/core: init order

2013-04-16 Thread Tony Lindgren
* Grygorii Strashko grygorii.stras...@ti.com [130416 01:39]: On 04/16/2013 10:45 AM, Peter Ujfalusi wrote: On 04/15/2013 06:25 PM, Tony Lindgren wrote: This fix should not be needed. It just means the real problem is somewhere else. Pinctrl is already before the i2c in drivers/Makefile. Maybe

Re: 4430sdp nfsroot broken with ff5c9059

2013-04-16 Thread Tony Lindgren
* Jon Hunter jon-hun...@ti.com [130416 10:19]: On 04/15/2013 04:27 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130415 11:15]: ... From 56598ba51a75481b050433bb38b7ae31a5ed4ae8 Mon Sep 17 00:00:00 2001 From: Jon Hunter jon-hun...@ti.com Date: Mon, 15 Apr 2013 13:06:54

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-16 Thread Stephen Warren
On 04/15/2013 05:04 PM, Jon Hunter wrote: On 04/15/2013 05:16 PM, Stephen Warren wrote: On 04/15/2013 03:40 PM, Jon Hunter wrote: ... mmc { label = pandaboard::status2; gpios = gpio1 8 0; ... }; But that's a gpio-leds instance, not an MMC controller... I really really hope

Re: 4430sdp nfsroot broken with ff5c9059

2013-04-16 Thread Jon Hunter
On 04/16/2013 01:06 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130416 10:19]: On 04/15/2013 04:27 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130415 11:15]: ... From 56598ba51a75481b050433bb38b7ae31a5ed4ae8 Mon Sep 17 00:00:00 2001 From: Jon Hunter

Re: [RFC PATCH v2 0/6] ARM: OMAP3+: Introduce ABB driver

2013-04-16 Thread Mike Turquette
Quoting Andrii Tseglytskyi (2013-04-16 05:40:44) On 04/16/2013 12:53 AM, Kevin Hilman wrote: In addition to Mike's comments (which I completely agree with), it would be very helfpul to see how this is actually used. e.g, how the regulators are chained together, how the proper ordering is

Re: [RFC PATCH v2 0/6] ARM: OMAP3+: Introduce ABB driver

2013-04-16 Thread Kevin Hilman
Andrii Tseglytskyi andrii.tseglyts...@ti.com writes: Hi Kevin, On 04/16/2013 12:53 AM, Kevin Hilman wrote: Andrii Tseglytskyi andrii.tseglyts...@ti.com writes: From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com Following patch series introduces the Adaptive Body-Bias LDO driver, which

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-16 Thread Jon Hunter
On 04/16/2013 01:40 PM, Stephen Warren wrote: On 04/15/2013 05:04 PM, Jon Hunter wrote: On 04/15/2013 05:16 PM, Stephen Warren wrote: On 04/15/2013 03:40 PM, Jon Hunter wrote: ... mmc { label = pandaboard::status2; gpios = gpio1 8 0; ... }; But that's a gpio-leds instance,

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-16 Thread Jon Hunter
On 04/16/2013 02:27 PM, Jon Hunter wrote: ... Right. In the DT case though, if someone does provide the IRQ and GPIO IDs then at least they would use a different xlate function. Another option to consider would be defining the #interrupt-cells = 3 where we would have ... cell-#1 -- IRQ

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-16 Thread Stephen Warren
On 04/16/2013 01:27 PM, Jon Hunter wrote: On 04/16/2013 01:40 PM, Stephen Warren wrote: On 04/15/2013 05:04 PM, Jon Hunter wrote: ... If some driver is calling gpio_request() directly, then they will most likely just call gpio_to_irq() when requesting the interrupt and so the xlate function

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-16 Thread Jon Hunter
On 04/16/2013 05:11 PM, Stephen Warren wrote: On 04/16/2013 01:27 PM, Jon Hunter wrote: On 04/16/2013 01:40 PM, Stephen Warren wrote: On 04/15/2013 05:04 PM, Jon Hunter wrote: ... If some driver is calling gpio_request() directly, then they will most likely just call gpio_to_irq() when

Re: adding rpmsg.git to linux next

2013-04-16 Thread Stephen Rothwell
Hi Ohad, On Tue, 16 Apr 2013 20:51:13 +0300 Ohad Ben-Cohen o...@wizery.com wrote: On Tue, Apr 16, 2013 at 3:07 AM, Stephen Rothwell s...@canb.auug.org.au wrote: On Mon, 15 Apr 2013 09:28:17 +0300 Ohad Ben-Cohen o...@wizery.com wrote: Could you please add:

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-16 Thread Javier Martinez Canillas
On Wed, Apr 17, 2013 at 1:14 AM, Jon Hunter jon-hun...@ti.com wrote: On 04/16/2013 05:11 PM, Stephen Warren wrote: On 04/16/2013 01:27 PM, Jon Hunter wrote: On 04/16/2013 01:40 PM, Stephen Warren wrote: On 04/15/2013 05:04 PM, Jon Hunter wrote: ... If some driver is calling gpio_request()

Re: [PATCH] ARM: dts: omap3-beagle-xm: Add USB Host support for Rev Ax/Bx

2013-04-16 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [130415 05:44]: On 04/15/2013 03:35 PM, Roger Quadros wrote: Provide RESET and Power regulators for the USB PHY, the USB Host port mode and the PHY device. Also provide pin multiplexer information for USB host pins. This will not work for Rev Cx

Re: 4430sdp nfsroot broken with ff5c9059

2013-04-16 Thread Tony Lindgren
* Jon Hunter jon-hun...@ti.com [130416 11:45]: On 04/16/2013 01:06 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130416 10:19]: On 04/15/2013 04:27 PM, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [130415 11:15]: ... From

Re: [PATCH] ARM: dts: omap3-beagle-xm: Add USB Host support for Rev Ax/Bx

2013-04-16 Thread Robert Nelson
On Tue, Apr 16, 2013 at 7:52 PM, Tony Lindgren t...@atomide.com wrote: * Roger Quadros rog...@ti.com [130415 05:44]: On 04/15/2013 03:35 PM, Roger Quadros wrote: Provide RESET and Power regulators for the USB PHY, the USB Host port mode and the PHY device. Also provide pin multiplexer

Re: [PATCH 3/5] gpio/omap: Add DT support to GPIO driver

2013-04-16 Thread Jon Hunter
On 04/16/2013 07:41 PM, Javier Martinez Canillas wrote: On Wed, Apr 17, 2013 at 1:14 AM, Jon Hunter jon-hun...@ti.com wrote: On 04/16/2013 05:11 PM, Stephen Warren wrote: On 04/16/2013 01:27 PM, Jon Hunter wrote: On 04/16/2013 01:40 PM, Stephen Warren wrote: On 04/15/2013 05:04 PM, Jon