Re: [PATCH 00/11] Exynos7: Adding USB 3.0 support

2014-11-22 Thread Kishon Vijay Abraham I
On Friday 21 November 2014 08:41 PM, Felipe Balbi wrote: On Fri, Nov 21, 2014 at 07:05:43PM +0530, Vivek Gautam wrote: The series has dependency on a) [PATCH v7 0/7] Enable support for Samsung Exynos7 SoC http://www.spinics.net/lists/linux-samsung-soc/msg38734.html b) [GIT PULL] Samsung

Re: [PATCH v2] input: touchscreen: edt-ft5x06: fix driver autoprobing

2014-11-22 Thread Wolfram Sang
Can you comment on this ? As of today i2c-based drivers will probe with DT-based boot if DT's compatible is set to the same id as in struct i2c_device_id. No i2c driver with of_device_id can autoprobe using OF ids. Long standing problem. Last one to tackle this was Lee Jones:

[PATCH 1/1] ARM: OMAP2: Deletion of unnecessary checks before three function calls

2014-11-22 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Sat, 22 Nov 2014 10:50:33 +0100 The functions clk_disable(), of_node_put() and omap_device_delete() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by

Re: [PATCH 2/4] i2c: omap: implement workaround for handling invalid BB-bit values

2014-11-22 Thread Wolfram Sang
On Fri, Nov 21, 2014 at 10:08:08AM -0600, Felipe Balbi wrote: On Fri, Nov 21, 2014 at 01:28:43AM +0400, Alexander Kochetkov wrote: In a multimaster environment, after IP software reset, BB-bit value doesn't correspond to the current bus state. It may happen what BB-bit will be 0, while the

Re: [PATCH 01/11] pinctrl: exynos: Add BUS1 pin controller for exynos7

2014-11-22 Thread Alim Akhtar
Hi Vivek, On Fri, Nov 21, 2014 at 7:05 PM, Vivek Gautam gautam.vi...@samsung.com wrote: USB and Power regulator on Exynos7 require gpios available in BUS1 pin controller block. So adding the BUS1 pinctrl support. Signed-off-by: Naveen Krishna Ch naveenkrishna...@gmail.com Signed-off-by:

Re: [PATCH 09/11] arm64: exynos: Add bus1 pinctrl node on exynos7

2014-11-22 Thread Alim Akhtar
Hi Vivek, On Fri, Nov 21, 2014 at 7:05 PM, Vivek Gautam gautam.vi...@samsung.com wrote: BUS1 pinctrl provides gpios for usb and power regulator available on exynos7-espresso board. So add relevant device node for pinctrl-bus1. Signed-off-by: Naveen Krishna Ch naveenkrishna...@gmail.com

Re: [PATCH 2/4] i2c: omap: implement workaround for handling invalid BB-bit values

2014-11-22 Thread Alexander Kochetkov
22 нояб. 2014 г., в 16:23, Wolfram Sang w...@the-dreams.de написал(а): Huh, I can't apply this one? Which kernel version is this based on? v.3.13-rc8 It depends on PATCH 1/4 alexander@ubuntu:git.kernel.org.pub.scm.linux.kernel.git.stable.linux-stable$ git log --pretty=oneline --abbrev-commit

[PATCH] usb: dwc3: return error code from the most recent call

2014-11-22 Thread Julia Lawall
From: Julia Lawall julia.law...@lip6.fr Copy-paste error from the previous block of error handling code. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression e,e1; @@ if (IS_ERR(e)) { ... ( ret = PTR_ERR(e); |

Re: [PATCH 00/11] Exynos7: Adding USB 3.0 support

2014-11-22 Thread Kukjin Kim
On 11/22/14 17:40, Kishon Vijay Abraham I wrote: On Friday 21 November 2014 08:41 PM, Felipe Balbi wrote: On Fri, Nov 21, 2014 at 07:05:43PM +0530, Vivek Gautam wrote: The series has dependency on a) [PATCH v7 0/7] Enable support for Samsung Exynos7 SoC

Re: [PATCH 2/4] i2c: omap: implement workaround for handling invalid BB-bit values

2014-11-22 Thread Wolfram Sang
On Sat, Nov 22, 2014 at 05:06:10PM +0300, Alexander Kochetkov wrote: 22 нояб. 2014 г., в 16:23, Wolfram Sang w...@the-dreams.de написал(а): Huh, I can't apply this one? Which kernel version is this based on? v.3.13-rc8 Wow, that's old. Can you please rebase the series on top of

Re: [RFC] adp1653: Add device tree bindings for LED controller

2014-11-22 Thread Ivaylo Dimitrov
Hi, Can you capture raw bayer images correctly? I assume green means YUV buffers that are all zero. Do you know more specifically which patch breaks it? CCing freemangordon (Ivaylo Dimitrov). He tried to debug it months ago but without success. Should know more info about this problem. I

[PATCH v3 3/4] i2c: omap: don't reset controller if Arbitration Lost detected

2014-11-22 Thread Alexander Kochetkov
Arbitration Lost is an expected situation in a multimaster environment. I2C controller (IP) correctly detect and report AL. The only one visible reason for reseting IP in the AL case is to avoid advisory 1.94 (omap3) and errata i595 (omap4): I2C: After an Arbitration is Lost the Module

[PATCH v3 4/4] i2c: omap: add notes related to i2c multimaster mode

2014-11-22 Thread Alexander Kochetkov
No functional changes. Signed-off-by: Alexander Kochetkov al.koc...@gmail.com Reviewed-by: Felipe Balbi ba...@ti.com --- drivers/i2c/busses/i2c-omap.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c

[PATCH v3 1/4] i2c: omap: cleanup register definitions

2014-11-22 Thread Alexander Kochetkov
Delete STAT_AD0 mask as unrelated to current IP (omap1?). Delete DEBUG conditional around SYSTEST masks group. Add SYSTEST functional mode masks for SCL and SDA. Add STAT_BF mask. Signed-off-by: Alexander Kochetkov al.koc...@gmail.com Tested-by: Felipe Balbi ba...@ti.com Reviewed-by: Felipe Balbi

[PATCH v3 0/4] i2c: omap: patch series related to multimaster mode

2014-11-22 Thread Alexander Kochetkov
Here is the patch series intended to improve stability of i2c-omap driver in the i2c multimaster environments. Tested on Beagleboard XM C. For now all fine. No controller timeouts, no data corruptions. Also impelemented i2c bus fault detection during startup and after reset. So, instead of the

[PATCH v3 2/4] i2c: omap: implement workaround for handling invalid BB-bit values

2014-11-22 Thread Alexander Kochetkov
In a multimaster environment, after IP software reset, BB-bit value doesn't correspond to the current bus state. It may happen what BB-bit will be 0, while the bus is busy due to another I2C master activity. Any transfer started when BB=0 and bus is busy wouldn't be completed by IP and results in

Re: [PATCH v3 0/4] i2c: omap: patch series related to multimaster mode

2014-11-22 Thread Wolfram Sang
On Sat, Nov 22, 2014 at 11:47:10PM +0400, Alexander Kochetkov wrote: Here is the patch series intended to improve stability of i2c-omap driver in the i2c multimaster environments. Tested on Beagleboard XM C. For now all fine. No controller timeouts, no data corruptions. Also impelemented

Re: [PATCH] i2c: omap: fix i207 errata handling

2014-11-22 Thread Wolfram Sang
On Fri, Nov 21, 2014 at 04:16:51AM +0400, Alexander Kochetkov wrote: commit 6d9939f651419a63e091105663821f9c7d3fec37 (i2c: omap: split out [XR]DR and [XR]RDY) changed the way how errata i207 (I2C: RDR Flag May Be Incorrectly Set) get handled. 6d9939f6514 code doesn't correspond to workaround

Re: [PATCH] i2c: omap: fix i207 errata handling

2014-11-22 Thread Wolfram Sang
Guys, I really appreciate you help. So much testing and review. I could not have done one. Thank you! Well, thank YOU, for your hard work in verifying this controller at low-level and in corner-cases. This is very much appreciated. Plus, you have been very responsive to comments. Really good

[GIT PULL 2/2] part 2 of omap dts changes for v3.19

2014-11-22 Thread Tony Lindgren
The following changes since commit 065bd7fe50de5e6d0fd5034cbc87120a558a1219: ARM: dts: DRA7: Add aliases for all serial ports (2014-11-12 07:04:37 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap omap-for-v3.19/dt-v2 for you to

[GIT PULL 1/2] part 2 of omap soc changes for v3.19

2014-11-22 Thread Tony Lindgren
The following changes since commit 9889278181bcdbae882664d8cee5bb0e064397e4: Merge tag 'for-v3.19/omap-a' of git://git.kernel.org/pub/scm/linux/kernel/git/pjw/omap-pending into omap-for-v3.19/soc (2014-11-14 10:25:12 -0800) are available in the git repository at:

Re: [PATCH 2/4] i2c: omap: implement workaround for handling invalid BB-bit values

2014-11-22 Thread Felipe Balbi
On Sat, Nov 22, 2014 at 07:02:22PM +0100, Wolfram Sang wrote: On Sat, Nov 22, 2014 at 05:06:10PM +0300, Alexander Kochetkov wrote: 22 нояб. 2014 г., в 16:23, Wolfram Sang w...@the-dreams.de написал(а): Huh, I can't apply this one? Which kernel version is this based on? v.3.13-rc8