Re: [PATCH v6 2/6] wl12xx: use frequency instead of enumerations for pdata clocks

2015-03-15 Thread Eliad Peller
+Kalle On Fri, Mar 13, 2015 at 5:00 PM, Tony Lindgren wrote: > * Eliad Peller [150312 05:09]: >> From: Luciano Coelho >> >> Instead of defining an enumeration with the FW specific values for the >> different clock rates, use the actual frequency instead. Also add a >> boolean to specify whethe

Re: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data

2015-03-15 Thread Eliad Peller
On Fri, Mar 13, 2015 at 5:13 PM, Tony Lindgren wrote: > * Eliad Peller [150312 05:10]: >> Now that we have wlcore device-tree bindings in place >> (for both wl12xx and wl18xx), remove the legacy >> wl12xx_platform_data struct, and move its members >> into the platform device data (that is passed

Re: [PATCH v6 5/6] ARM: dts: add wl12xx/wl18xx bindings

2015-03-15 Thread Eliad Peller
On Fri, Mar 13, 2015 at 5:27 PM, Tony Lindgren wrote: > * Eliad Peller [150312 05:09]: >> --- a/arch/arm/mach-omap2/pdata-quirks.c >> +++ b/arch/arm/mach-omap2/pdata-quirks.c >> >> -static void __init omap3_evm_legacy_init(void) >> -{ >> - legacy_init_wl12xx(3840, 0, 149); >> -} > > FYI,

Re: [PATCH v6 0/6] wlcore: add device-tree support

2015-03-15 Thread Eliad Peller
hi Sébastien, On Fri, Mar 13, 2015 at 6:11 PM, Sébastien Szymanski wrote: > Hello, > > On 03/12/2015 01:09 PM, Eliad Peller wrote: >> >> NOTE: all the platform patches were compile-tested >> only. I'm looking for some wl12xx card (that i should >> have somewhere) to test the wl12xx changes (wrt.

Re: [PATCH 00/10] omap3 crypto fixes

2015-03-15 Thread Pali Rohár
On Sunday 08 March 2015 17:35:13 Paul Walmsley wrote: > On Sun, 8 Mar 2015, Pali Rohár wrote: > > On Friday 06 March 2015 23:23:06 Aaro Koskinen wrote: > > > On Fri, Mar 06, 2015 at 10:36:32AM -0800, Tony Lindgren wrote: > > > > Are there any fixes in this series that should go into > > > > v4.0-r

Re: [PATCH v6 2/6] wl12xx: use frequency instead of enumerations for pdata clocks

2015-03-15 Thread Arnd Bergmann
On Sunday 15 March 2015 10:43:35 Eliad Peller wrote: > > > The other option would be to have the whole series in a immutable > > branch against v3.0-rc1 that can be merged into both wirelss tree > > and omap tree. > > > i think that could be easier. > > or maybe you can just take them all through

Re: [PATCH v6 6/6] wlcore: remove wl12xx_platform_data

2015-03-15 Thread Arnd Bergmann
On Sunday 15 March 2015 10:50:42 Eliad Peller wrote: > yeah, i missed it :/ > > looks like there's no platform that defines platform data for it. > i'll replace the dev_get_platdata() with a function that only parses > the clock-frequency properties (the irq is taken in this case from the > spi_de

[PATCH] regulator: tps65910: Add missing #include

2015-03-15 Thread Geert Uytterhoeven
drivers/regulator/tps65910-regulator.c: In function ‘tps65910_parse_dt_reg_data’: drivers/regulator/tps65910-regulator.c:1018: error: implicit declaration of function ‘of_get_child_by_name’ drivers/regulator/tps65910-regulator.c:1018: warning: assignment makes pointer from integer without a cast

[PATCH 0/4] OMAP 3 ISP (and N9/N950 primary camera support) dts changes

2015-03-15 Thread Sakari Ailus
Hi Tony and others, I had a couple of patches that contained dts changes in my OMAP 3 ISP / N9 camera DT support set. Since it became apparent that at least some of the changes should go through linux-omap due to potential conflicts with other patches, I decided to separate the dts changes from th

[PATCH 2/4] dt: bindings: Add bindings for omap3isp

2015-03-15 Thread Sakari Ailus
Signed-off-by: Sakari Ailus --- .../devicetree/bindings/media/ti,omap3isp.txt | 71 MAINTAINERS|1 + include/dt-bindings/media/omap3-isp.h | 22 ++ 3 files changed, 94 insertions(+) create mode 100644 Docu

[PATCH 4/4] arm: dts: n950, n9: Add primary camera support

2015-03-15 Thread Sakari Ailus
Add support for the primary camera of the Nokia N950 and N9. Signed-off-by: Sakari Ailus --- arch/arm/boot/dts/omap3-n9.dts | 37 + arch/arm/boot/dts/omap3-n950.dts | 37 + 2 files changed, 74 insertions(+) diff --git

[PATCH 1/4] arm: dts: omap3: Extend the syscon register range

2015-03-15 Thread Sakari Ailus
The OMAP 3630 syscon register set was missing OMAP3630_CONTROL_CAMERA_PHY_CTRL register at offset 0x2f0. This register used to be mapped directly by the omap3isp driver, which is now moving to use syscon instead. The omap3isp driver did not support DT so no driver change is needed in this patch. S

[PATCH 3/4] arm: dts: omap3: Add DT entries for OMAP 3

2015-03-15 Thread Sakari Ailus
The resources the ISP needs are slightly different on 3[45]xx and 3[67]xx. Especially the phy-type property is different. Signed-off-by: Sakari Ailus --- arch/arm/boot/dts/omap34xx.dtsi | 17 + arch/arm/boot/dts/omap36xx.dtsi | 17 + 2 files changed, 34 insert

Re: [PATCH 4/4] arm: dts: n950, n9: Add primary camera support

2015-03-15 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Monday 16 March 2015 02:01:20 Sakari Ailus wrote: > Add support for the primary camera of the Nokia N950 and N9. > > Signed-off-by: Sakari Ailus > --- > arch/arm/boot/dts/omap3-n9.dts | 37 +++ > arch/arm/boot/dts/omap3

Re: [PATCH 3/4] arm: dts: omap3: Add DT entries for OMAP 3

2015-03-15 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Monday 16 March 2015 02:01:19 Sakari Ailus wrote: > The resources the ISP needs are slightly different on 3[45]xx and 3[67]xx. > Especially the phy-type property is different. > > Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart > --- > arch/arm/

Re: [PATCH 2/4] dt: bindings: Add bindings for omap3isp

2015-03-15 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Monday 16 March 2015 02:01:18 Sakari Ailus wrote: > Signed-off-by: Sakari Ailus > --- > .../devicetree/bindings/media/ti,omap3isp.txt | 71 + > MAINTAINERS|1 + > include/dt-bindings/media/

Re: [PATCH 1/4] arm: dts: omap3: Extend the syscon register range

2015-03-15 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Monday 16 March 2015 02:01:17 Sakari Ailus wrote: > The OMAP 3630 syscon register set was missing > OMAP3630_CONTROL_CAMERA_PHY_CTRL register at offset 0x2f0. This register > used to be mapped directly by the omap3isp driver, which is now moving to > use sys

[PATCH 02/15] omap3isp: Avoid a BUG_ON() in media_entity_create_link()

2015-03-15 Thread Sakari Ailus
If an uninitialised v4l2_subdev struct was passed to media_entity_create_link(), one of the BUG_ON()'s in the function will be hit since media_entity.num_pads will be zero. Avoid this by checking whether the num_pads field is non-zero for the interface. Signed-off-by: Sakari Ailus Acked-by: Laure

[PATCH 00/15] omap3isp driver DT support

2015-03-15 Thread Sakari Ailus
Hi folks, Here's the first non-RFC version of the omap3isp driver DT support patchset. It's a sub-set of patches in this RFC set: http://www.spinics.net/lists/linux-media/msg87263.html> What has been changed since the RFC set in these patches is roughly: - The patches have been rebased on Laure

[PATCH 01/15] omap3isp: Fix error handling in probe

2015-03-15 Thread Sakari Ailus
The mutex was not destroyed correctly if dma_coerce_mask_and_coherent() failed for some reason. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- drivers/media/platform/omap3isp/isp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/omap3isp

[PATCH 10/15] omap3isp: Move the syscon register out of the ISP register maps

2015-03-15 Thread Sakari Ailus
The syscon register isn't part of the ISP, use it through the syscom driver regmap instead. The syscom block is considered to be from 343x on ISP revision 2.0 whereas 15.0 is assumed to have 3630 syscon. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart Acked-by: Tony Lindgren --- arch/ar

[PATCH 13/15] v4l: of: Read lane-polarity endpoint property

2015-03-15 Thread Sakari Ailus
Add lane_polarity field to struct v4l2_of_bus_mipi_csi2 and write the contents of the lane polarity property to it. The field tells the polarity of the physical lanes starting from the first one. Any unused lanes are ignored, i.e. only the polarity of the used lanes is specified. Also rework readi

[PATCH 15/15] omap3isp: Deprecate platform data support

2015-03-15 Thread Sakari Ailus
Print a warning when the driver is used with platform data. Existing platform data user should move to DT now. Signed-off-by: Sakari Ailus --- drivers/media/platform/omap3isp/isp.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/pla

[PATCH 06/15] omap3isp: Refactor device configuration structs for Device Tree

2015-03-15 Thread Sakari Ailus
Make omap3isp configuration data structures more suitable for consumption by the DT by separating the I2C bus information of all the sub-devices in a group and the ISP bus information from each other. The ISP bus information is made a pointer instead of being directly embedded in the struct. In th

[PATCH 12/15] dt: bindings: Add lane-polarity property to endpoint nodes

2015-03-15 Thread Sakari Ailus
Add lane-polarity property to endpoint nodes. This essentially tells that the order of the differential signal wires is inverted. Signed-off-by: Sakari Ailus --- Documentation/devicetree/bindings/media/video-interfaces.txt |6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentatio

[PATCH 07/15] omap3isp: Rename regulators to better suit the Device Tree

2015-03-15 Thread Sakari Ailus
Rename VDD_CSIPHY1 as vdd-csiphy1 and VDD_CSIPHY2 as vdd-csiphy2. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- drivers/media/platform/omap3isp/isp.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/pl

[PATCH 08/15] omap3isp: Calculate vpclk_div for CSI-2

2015-03-15 Thread Sakari Ailus
The video port clock is l3_ick divided by vpclk_div. This clock must be high enough for the external pixel rate. The video port requires two clock cycles to process a pixel. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- drivers/media/platform/omap3isp/ispcsi2.c |8 +++- inc

[PATCH 04/15] omap3isp: DT support for clocks

2015-03-15 Thread Sakari Ailus
From: Laurent Pinchart Signed-off-by: Laurent Pinchart --- drivers/media/platform/omap3isp/isp.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index f694615..82499cd 100644 --- a/dr

[PATCH 03/15] omap3isp: Separate external link creation from platform data parsing

2015-03-15 Thread Sakari Ailus
Move the code which connects the external entity to an ISP entity into a separate function. This disconnects it from parsing the platform data. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- drivers/media/platform/omap3isp/isp.c | 143 + 1 file chang

[PATCH 09/15] omap3isp: Replace mmio_base_phys array with the histogram block base

2015-03-15 Thread Sakari Ailus
Only the histogram sub-block driver uses the physical address. Do not store it for other sub-blocks. Signed-off-by: Sakari Ailus Acked-by: Laurent Pinchart --- drivers/media/platform/omap3isp/isp.c |3 ++- drivers/media/platform/omap3isp/isp.h |6 +++--- drivers/media/platform/o

[PATCH 05/15] omap3isp: Platform data could be NULL

2015-03-15 Thread Sakari Ailus
Only check for call platform data callback functions if there's platform data. Also take care of a few other cases where the NULL pdata pointer could have been accessed, and remove the check for NULL dev->platform_data pointer. Removing the check for NULL dev->platform_data isn't strictly needed b

[PATCH 14/15] omap3isp: Add support for the Device Tree

2015-03-15 Thread Sakari Ailus
Add the ISP device to omap3 DT include file and add support to the driver to use it. Also obtain information on the external entities and the ISP configuration related to them through the Device Tree in addition to the platform data. Signed-off-by: Sakari Ailus --- drivers/media/platform/omap3i

[PATCH 11/15] omap3isp: Replace many MMIO regions by two

2015-03-15 Thread Sakari Ailus
The omap3isp MMIO register block is contiguous in the MMIO register space apart from the fact that the ISP IOMMU register block is in the middle of the area. Ioremap it at two occasions, and keep the rest of the layout of the register space internal to the omap3isp driver. Signed-off-by: Sakari Ai

Re: [PATCH v6 2/6] wl12xx: use frequency instead of enumerations for pdata clocks

2015-03-15 Thread Kalle Valo
Arnd Bergmann writes: > On Sunday 15 March 2015 10:43:35 Eliad Peller wrote: >> >> > The other option would be to have the whole series in a immutable >> > branch against v3.0-rc1 that can be merged into both wirelss tree >> > and omap tree. >> > >> i think that could be easier. >> >> or maybe