RE: [RFC][PATCH 1/9] OMAP: ID: introduce chip detection for OMAP4460

2011-05-26 Thread Premi, Sanjeev
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Menon, Nishanth Sent: Thursday, May 26, 2011 7:27 AM To: linux-omap Cc: V, Aneesh; Menon, Nishanth Subject: [RFC][PATCH 1/9] OMAP: ID: introduce chip detection for

RE: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-26 Thread Premi, Sanjeev
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Menon, Nishanth Sent: Thursday, May 26, 2011 7:27 AM To: linux-omap Cc: Sonasath, Moiz; Menon, Nishanth Subject: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1

RE: [RFC][PATCH 4/9] OMAP4: clocks: distinguish 4430 and 4460

2011-05-26 Thread Premi, Sanjeev
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Menon, Nishanth Sent: Thursday, May 26, 2011 7:27 AM To: linux-omap Cc: Nayak, Rajendra Subject: [RFC][PATCH 4/9] OMAP4: clocks: distinguish 4430 and 4460 From:

RE: [RFC][PATCH 8/9] OMAP4: clockdomain: Use CHIP_IS_44XX to reuse all CD's on 4460

2011-05-26 Thread Premi, Sanjeev
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Menon, Nishanth Sent: Thursday, May 26, 2011 7:27 AM To: linux-omap Cc: Nayak, Rajendra Subject: [RFC][PATCH 8/9] OMAP4: clockdomain: Use CHIP_IS_44XX to reuse all

RE: [RFC][PATCH 7/9] OMAP4: powerdomain: Update MPU powerdomain for 4460

2011-05-26 Thread Premi, Sanjeev
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Menon, Nishanth Sent: Thursday, May 26, 2011 7:27 AM To: linux-omap Cc: Nayak, Rajendra Subject: [RFC][PATCH 7/9] OMAP4: powerdomain: Update MPU powerdomain for 4460

RE: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Premi, Sanjeev
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of DebBarma, Tarun Kanti Sent: Tuesday, May 24, 2011 7:55 PM To: linux-omap@vger.kernel.org Cc: Hilman, Kevin; Shilimkar, Santosh; t...@atomide.com;

Re: [PATCH 12/15] OMAP: GPIO: Fix: use wake set/clear regs

2011-05-26 Thread Varadarajan, Charulatha
On Thu, May 26, 2011 at 04:44, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com In set_24xx_gpio_triggering(), for OMAP4, GPIO wakeup request is set for all type of GPIO triggers whereas as per TRM the GPIO wakeup request can

Re: [PATCH 11/15] OMAP: GPIO: Remove hardcoded offsets in ctxt save/restore

2011-05-26 Thread Varadarajan, Charulatha
On Thu, May 26, 2011 at 04:31, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: It is not required to use hard-coded offsets any more in context save and restore functions and instead use the generic offsets which have been correctly initialized during device

Re: [PATCH 08/15] OMAP2+: GPIO: make workaround_enabled bank specific

2011-05-26 Thread Varadarajan, Charulatha
On Thu, May 26, 2011 at 04:09, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Make workaround_enabled flag bank-specific instead of using a single flag for all the banks together. This would be helpful while making use of

Re: [PATCH 06/15] OMAP4: GPIO: Save/restore context

2011-05-26 Thread Varadarajan, Charulatha
Kevin, Thanks for the comments on this series. On Thu, May 26, 2011 at 03:13, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Modify the omap_gpio_save/restore_context to support OMAP4 architecture so that the OMAP GPIO

Re: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Varadarajan, Charulatha
On Thu, May 26, 2011 at 03:04, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Non-wakeup GPIOs are available only in OMAP2420 and OMAP3430. But the GPIO driver initializes the non-wakeup GPIO bits for OMAP24xx (bothe OMAP

Re: [PATCH 01/15] OMAP: GPIO: Avoid cpu_is checks during module ena/disable

2011-05-26 Thread Varadarajan, Charulatha
On Thu, May 26, 2011 at 02:49, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Remove cpu-is checks while enabling/disabling OMAP GPIO module during a gpio request/free. Signed-off-by: Charulatha V ch...@ti.com This looks

RE: [PATCH 11/15] OMAP: GPIO: Remove hardcoded offsets in ctxt save/restore

2011-05-26 Thread Premi, Sanjeev
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of DebBarma, Tarun Kanti Sent: Tuesday, May 24, 2011 7:55 PM To: linux-omap@vger.kernel.org Cc: Hilman, Kevin; Shilimkar, Santosh; t...@atomide.com;

Re: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Varadarajan, Charulatha
Sanjeev, Thanks for the comments. On Thu, May 26, 2011 at 14:53, Premi, Sanjeev pr...@ti.com wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of DebBarma, Tarun Kanti Sent: Tuesday, May 24, 2011 7:55 PM To:

[OFF TOPIC] away on business travel

2011-05-26 Thread Felipe Balbi
Hi all, I'll be away until 31st of May on a business travel. Don't expect me to look into patches during that period. Thanks :-) -- balbi signature.asc Description: Digital signature

Re: [PATCH 11/15] OMAP: GPIO: Remove hardcoded offsets in ctxt save/restore

2011-05-26 Thread Varadarajan, Charulatha
Sanjeev, On Thu, May 26, 2011 at 15:12, Premi, Sanjeev pr...@ti.com wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of DebBarma, Tarun Kanti Sent: Tuesday, May 24, 2011 7:55 PM To: linux-omap@vger.kernel.org Cc:

Re: [PATCH 13/15] OMAP: GPIO: clean set_gpio_triggering function

2011-05-26 Thread Varadarajan, Charulatha
Kevin, On Thu, May 26, 2011 at 04:57, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Getting rid of ifdefs within the function by adding register offset intctrl and associating OMAP_GPIO_INT_CONTROL in respective SoC

RE: [PATCH 05/15] OMAP: GPIO: Make gpio_context part of gpio_bank structure

2011-05-26 Thread Premi, Sanjeev
-Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of DebBarma, Tarun Kanti Sent: Tuesday, May 24, 2011 7:55 PM To: linux-omap@vger.kernel.org Cc: Hilman, Kevin; Shilimkar, Santosh; t...@atomide.com;

RE: [PATCH 05/15] OMAP: GPIO: Make gpio_context part of gpio_bank structure

2011-05-26 Thread Premi, Sanjeev
-Original Message- From: Premi, Sanjeev Sent: Thursday, May 26, 2011 3:29 PM To: DebBarma, Tarun Kanti; linux-omap@vger.kernel.org Cc: Hilman, Kevin; Shilimkar, Santosh; t...@atomide.com; linux-arm-ker...@lists.infradead.org; Varadarajan, Charulatha Subject: RE: [PATCH 05/15]

Re: [PATCH 09/15] OMAP: GPIO: cleanup suspend and resume functions

2011-05-26 Thread Varadarajan, Charulatha
Kevin, On Thu, May 26, 2011 at 04:27, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: Since wake_status, wake_clear, wake_set is common for all banks on a given OMAP version it is enough to get their values once during probe(). Also, register offsets are

Re: [PATCH 05/15] OMAP: GPIO: Make gpio_context part of gpio_bank structure

2011-05-26 Thread Varadarajan, Charulatha
On Thu, May 26, 2011 at 15:28, Premi, Sanjeev pr...@ti.com wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of DebBarma, Tarun Kanti Sent: Tuesday, May 24, 2011 7:55 PM To: linux-omap@vger.kernel.org Cc: Hilman,

Re: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Cousson, Benoit
On 5/26/2011 11:23 AM, Premi, Sanjeev wrote: From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of DebBarma, Tarun Kanti Sent: Tuesday, May 24, 2011 7:55 PM From: Charulatha Vch...@ti.com Non-wakeup GPIOs are available only in OMAP2420 and OMAP3430. But

[PATCH] OMAP: clockdomain: Remove redundant call to pwrdm_wait_transition()

2011-05-26 Thread Vaibhav Bedia
The call to pwrdm_wait_transition() in clkdm_clk_enable() is redundant since the function pwrdm_clkdm_state_switch() which is called next also does the same thing. Signed-off-by: Vaibhav Bedia vaibhav.be...@ti.com --- arch/arm/mach-omap2/clockdomain.c |1 - 1 files changed, 0 insertions(+),

[GIT PULL] omap updates for 2.6.40

2011-05-26 Thread Tony Lindgren
Hi Linus, Please pull omap updates for this merge window from: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-for-linus This contains clean-up to shrink down omap specific code a bit. Also included are some fixes. But basically no new code at this point. Regards,

RE: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Premi, Sanjeev
-Original Message- From: Cousson, Benoit Sent: Thursday, May 26, 2011 3:41 PM To: Premi, Sanjeev Cc: DebBarma, Tarun Kanti; linux-omap@vger.kernel.org; Hilman, Kevin; Shilimkar, Santosh; t...@atomide.com; linux-arm-ker...@lists.infradead.org; Varadarajan, Charulatha; Paul

Re: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Cousson, Benoit
On 5/26/2011 1:47 PM, Premi, Sanjeev wrote: -Original Message- From: Cousson, Benoit Sent: Thursday, May 26, 2011 3:41 PM To: Premi, Sanjeev Cc: DebBarma, Tarun Kanti; linux-omap@vger.kernel.org; Hilman, Kevin; Shilimkar, Santosh; t...@atomide.com; linux-arm-ker...@lists.infradead.org;

Re: [GIT PULL] omap updates for 2.6.40

2011-05-26 Thread Igor Grinberg
Tony, What about this one: [PATCH v2] arm: omap2plus: move NAND_BLOCK_SIZE out of boards Why not include it? It is no new code, just generalize stuff and 11 lines off... not much but still. On 05/26/11 14:39, Tony Lindgren wrote: Hi Linus, Please pull omap updates for this merge window

Re: [GIT PULL] omap updates for 2.6.40

2011-05-26 Thread Tony Lindgren
* Igor Grinberg grinb...@compulab.co.il [110526 05:10]: What about this one: [PATCH v2] arm: omap2plus: move NAND_BLOCK_SIZE out of boards Why not include it? It is no new code, just generalize stuff and 11 lines off... not much but still. Sorry I must have missed it.. Let's see if we

RE: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Premi, Sanjeev
-Original Message- From: Cousson, Benoit Sent: Thursday, May 26, 2011 5:41 PM To: Premi, Sanjeev Cc: DebBarma, Tarun Kanti; linux-omap@vger.kernel.org; Hilman, Kevin; Shilimkar, Santosh; t...@atomide.com; linux-arm-ker...@lists.infradead.org; Varadarajan, Charulatha; Paul

Re: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Cousson, Benoit
On 5/26/2011 2:38 PM, Premi, Sanjeev wrote: -Original Message- From: Cousson, Benoit Sent: Thursday, May 26, 2011 5:41 PM To: Premi, Sanjeev Cc: DebBarma, Tarun Kanti; linux-omap@vger.kernel.org; Hilman, Kevin; Shilimkar, Santosh; t...@atomide.com; linux-arm-ker...@lists.infradead.org;

Re: [GIT PULL] omap updates for 2.6.40

2011-05-26 Thread Igor Grinberg
On 05/26/11 15:24, Tony Lindgren wrote: * Igor Grinberg grinb...@compulab.co.il [110526 05:10]: What about this one: [PATCH v2] arm: omap2plus: move NAND_BLOCK_SIZE out of boards Why not include it? It is no new code, just generalize stuff and 11 lines off... not much but still. Sorry I

Re: [GIT PULL] omap updates for 2.6.40

2011-05-26 Thread Tony Lindgren
* Igor Grinberg grinb...@compulab.co.il [110526 05:48]: On 05/26/11 15:24, Tony Lindgren wrote: * Igor Grinberg grinb...@compulab.co.il [110526 05:10]: What about this one: [PATCH v2] arm: omap2plus: move NAND_BLOCK_SIZE out of boards Why not include it? It is no new code, just

[PATCH] ARM: OMAP: Get rid of section mismatch warnings

2011-05-26 Thread Silesh C V
Get rid of the following and 8 other similar section mismatch warnings WARNING: vmlinux.o(.text+0x2740c): Section mismatch in reference from the function zoom_lcd_panel_init() to the (unknown reference) .init.data:(unknown) The function zoom_lcd_panel_init() references the (unknown reference)

Re: [PATCH] ARM: OMAP: Get rid of section mismatch warnings

2011-05-26 Thread Santosh Shilimkar
On 5/26/2011 6:30 PM, Silesh C V wrote: Get rid of the following and 8 other similar section mismatch warnings I send this [1] patch a month back. It's still not considered though even after reminder. Regards Santosh [1] https://patchwork.kernel.org/patch/684831/ -- To unsubscribe from this

RE: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Premi, Sanjeev
-Original Message- From: Cousson, Benoit Sent: Thursday, May 26, 2011 6:17 PM To: Premi, Sanjeev Cc: DebBarma, Tarun Kanti; linux-omap@vger.kernel.org; Hilman, Kevin; Shilimkar, Santosh; t...@atomide.com; linux-arm-ker...@lists.infradead.org; Varadarajan, Charulatha; Paul

Re: [PATCH] ARM: OMAP: Get rid of section mismatch warnings

2011-05-26 Thread Tony Lindgren
* Santosh Shilimkar santosh.shilim...@ti.com [110526 05:56]: On 5/26/2011 6:30 PM, Silesh C V wrote: Get rid of the following and 8 other similar section mismatch warnings I send this [1] patch a month back. It's still not considered though even after reminder. [1]

Re: [GIT PULL] omap changes for v2.6.39 merge window

2011-05-26 Thread Pavel Machek
Hi! There's a number of down-counting clocksources using various methods to convert to an up-counting value - sometimes -readl(), sometimes cs-mask - readl() and sometimes ~readl(). Then there's those which are either 16-bit or 32-bit, and some of those 16-bit implementations must use

Re: [PATCH] ARM: OMAP: Get rid of section mismatch warnings

2011-05-26 Thread Russell King - ARM Linux
On Thu, May 26, 2011 at 06:37:32AM -0700, Tony Lindgren wrote: * Santosh Shilimkar santosh.shilim...@ti.com [110526 05:56]: On 5/26/2011 6:30 PM, Silesh C V wrote: Get rid of the following and 8 other similar section mismatch warnings I send this [1] patch a month back. It's still not

Re: [PATCH] arm: omap2plus: fix ads7846 pendown gpio request

2011-05-26 Thread Igor Grinberg
ping On 05/11/11 10:35, Igor Grinberg wrote: Tony, You can fold this one to the original patch from Mike as well, or do you want it into the rc1? On 05/04/11 20:22, Thomas Weber wrote: Am 04.05.2011 17:04, schrieb Igor Grinberg: introduced by: 96974a24 (omap: consolidate touch

Re: [PATCH] ARM: OMAP: Get rid of section mismatch warnings

2011-05-26 Thread Igor Grinberg
On 05/26/11 16:37, Tony Lindgren wrote: * Santosh Shilimkar santosh.shilim...@ti.com [110526 05:56]: On 5/26/2011 6:30 PM, Silesh C V wrote: Get rid of the following and 8 other similar section mismatch warnings I send this [1] patch a month back. It's still not considered though even

Re: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Cousson, Benoit
On 5/26/2011 3:38 PM, B.J. Buchalter wrote: Why not do the following: #define OMAP_GPIO_REV_0 0 #define OMAP_GPIO_REV_1 1 #define OMAP_GPIO_REV_2 2 #define OMAP_GPIO_REV_3 3 /* OMAP_GPIO_REV_0:OMAP2420 OMAP_GPIO_REV_1:OMAP2430

Re: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread B.J. Buchalter
Why not do the following: #define OMAP_GPIO_REV_0 0 #define OMAP_GPIO_REV_1 1 #define OMAP_GPIO_REV_2 2 #define OMAP_GPIO_REV_3 3 /* OMAP_GPIO_REV_0:OMAP2420 OMAP_GPIO_REV_1:OMAP2430 OMAP_GPIO_REV_2:OMAP3, DMxxx

Re: [RFC][PATCH 1/9] OMAP: ID: introduce chip detection for OMAP4460

2011-05-26 Thread Nishanth Menon
On 14:03-20110526, Premi, Sanjeev wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Menon, Nishanth Sent: Thursday, May 26, 2011 7:27 AM To: linux-omap Cc: V, Aneesh; Menon, Nishanth Subject: [RFC][PATCH 1

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-26 Thread Nishanth Menon
On 14:06-20110526, Premi, Sanjeev wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Menon, Nishanth Sent: Thursday, May 26, 2011 7:27 AM To: linux-omap Cc: Sonasath, Moiz; Menon, Nishanth Subject: [RFC

Re: [RFC][PATCH 7/9] OMAP4: powerdomain: Update MPU powerdomain for 4460

2011-05-26 Thread Nishanth Menon
On 14:22-20110526, Premi, Sanjeev wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Menon, Nishanth Sent: Thursday, May 26, 2011 7:27 AM To: linux-omap Cc: Nayak, Rajendra Subject: [RFC][PATCH 7/9] OMAP4

Re: context_loss_count error value

2011-05-26 Thread Kevin Hilman
Tomi Valkeinen tomi.valkei...@ti.com writes: On Wed, 2011-05-25 at 13:30 -0700, Kevin Hilman wrote: Tomi Valkeinen tomi.valkei...@ti.com writes: On Wed, 2011-05-25 at 11:34 -0700, Kevin Hilman wrote: Tomi Valkeinen tomi.valkei...@ti.com writes: snip + if

Re: [GIT PULL] omap updates for 2.6.40

2011-05-26 Thread Koen Kooi
Op 26 mei 2011, om 13:39 heeft Tony Lindgren het volgende geschreven: Hi Linus, Please pull omap updates for this merge window from: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-for-linus This contains clean-up to shrink down omap specific code a bit.

[PATCH 0/3] Some omap_device/hwmod/pwrdomain patches

2011-05-26 Thread Tomi Valkeinen
I came up with these patches while implementing pm runtime adaptation for DSS driver. I'm not quite sure on who's turf they belong, or do they even belong together, but here they are anyway. get_context_loss_count patch was discussed on l-o with Kevin. The omap_device_reset patch I made as some

[PATCH 2/3] OMAP: add omap_device_reset()

2011-05-26 Thread Tomi Valkeinen
Add omap_device_reset() function which can be used to reset the hwmods associated with the given platform device. Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com --- arch/arm/plat-omap/include/plat/omap_device.h |1 + arch/arm/plat-omap/omap_device.c | 23

[PATCH 1/3] OMAP: change get_context_loss_count ret value to int

2011-05-26 Thread Tomi Valkeinen
get_context_loss_count functions return context loss count as u32, and zero means an error. However, zero is also returned when context has never been lost and could also be returned when the context loss count has wrapped and goes to zero. Change the functions to return an int, with negative

[PATCH 3/3] OMAP: Add (omap_device|omap_hwmod)_can_ever_lose_context functions

2011-05-26 Thread Tomi Valkeinen
Add hwmod and omap_device versions of can_ever_lose_context functions so that drivers are able to use it. Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com --- arch/arm/mach-omap2/omap_hwmod.c | 22 ++ arch/arm/plat-omap/include/plat/omap_device.h |1 +

Re: [PM-WIP_CPUFREQ][PATCH V3 6/8] OMAP2+: cpufreq: fix freq_table leak

2011-05-26 Thread Kevin Hilman
Menon, Nishanth n...@ti.com writes: On Wed, May 25, 2011 at 17:16, Kevin Hilman khil...@ti.com wrote: Nishanth Menon n...@ti.com writes: Since we have multiple CPUs, the cpuinit call for CPU1 causes freq_table of CPU0 to be overwritten. Instead, we maintain a counter to keep track of

Re: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Kevin Hilman
Varadarajan, Charulatha ch...@ti.com writes: On Thu, May 26, 2011 at 03:04, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Non-wakeup GPIOs are available only in OMAP2420 and OMAP3430. But the GPIO driver initializes the

Re: [PATCH 1/3] OMAP: change get_context_loss_count ret value to int

2011-05-26 Thread Kevin Hilman
Tomi Valkeinen tomi.valkei...@ti.com writes: get_context_loss_count functions return context loss count as u32, and zero means an error. However, zero is also returned when context has never been lost and could also be returned when the context loss count has wrapped and goes to zero.

Re: [PATCH 0/3] Some omap_device/hwmod/pwrdomain patches

2011-05-26 Thread Kevin Hilman
Tomi Valkeinen tomi.valkei...@ti.com writes: I came up with these patches while implementing pm runtime adaptation for DSS driver. I'm not quite sure on who's turf they belong, or do they even belong together, but here they are anyway. get_context_loss_count patch was discussed on l-o with

Re: [PM-WIP_CPUFREQ][PATCH V3 1/8] OMAP2+: cpufreq: move clk name decision to init

2011-05-26 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Clk name does'nt need to dynamically detected during clk init. move them off to driver initialization, if we dont have a clk name, there is no point in registering the driver anyways. The actual clk get and put is left at cpu_init and exit functions.

Re: [PM-WIP_CPUFREQ][PATCH V3 2/8] OMAP2+: cpufreq: deny initialization if no mpudev

2011-05-26 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: if we do not have mpu_dev we normally fail in cpu_init. It is better to fail driver registration if the devices are not available. Signed-off-by: Nishanth Menon n...@ti.com Thanks, applied. Kevin -- To unsubscribe from this list: send the line unsubscribe

Re: [PM-WIP_CPUFREQ][PATCH V3 3/8] OMAP2+: cpufreq: use opp/clk_*cpufreq_table based on silicon

2011-05-26 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: OMAP2 is the only family using clk_[init|exit]_cpufreq_table, while OMAP3+ use OPP table to generate and release the cpufreq tables. Hence use a flag to mark which API to use for allocating and freeing the tables. Signed-off-by: Nishanth Menon n...@ti.com

Re: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Varadarajan, Charulatha
Kevin, On Thu, May 26, 2011 at 12:15, Kevin Hilman khil...@ti.com wrote: Varadarajan, Charulatha ch...@ti.com writes: On Thu, May 26, 2011 at 03:04, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From: Charulatha V ch...@ti.com Non-wakeup GPIOs are

Re: [PM-WIP_CPUFREQ][PATCH 0/6 V3] Cleanups for cpufreq

2011-05-26 Thread Kevin Hilman
So here's a dumb question, being rather ignorant of CPUfreq on SMP. Should we be running a CPUfreq instance on both CPUs when they cannot be scaled independently? What is being scaled here is actually the cluster (the MPU SS via dpll_mpu_ck), not an individual CPU. So to me, it only makes sense

Re: [PM-WIP_CPUFREQ][PATCH V3 8/8] OMAP: cpufreq: minor file header updates

2011-05-26 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Minor file header updates to reflect 2011 for omap2-cpufreq code and remove misleading OMAP3 reference in omap1 cpufreq code. Should probably be squashed to: OMAP: cpufreq: Split OMAP1 and OMAP2PLUS CPUfreq drivers. Thanks, squashed. Kevin Reported-by:

Re: [PATCH 02/15] OMAP2PLUS: GPIO: Fix non-wakeup GPIO and rev_ids

2011-05-26 Thread Kevin Hilman
Varadarajan, Charulatha ch...@ti.com writes: Kevin, On Thu, May 26, 2011 at 12:15, Kevin Hilman khil...@ti.com wrote: Varadarajan, Charulatha ch...@ti.com writes: On Thu, May 26, 2011 at 03:04, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: From:

Re: [PM-WIP_CPUFREQ][PATCH V3 6/8] OMAP2+: cpufreq: fix freq_table leak

2011-05-26 Thread Menon, Nishanth
On Thu, May 26, 2011 at 10:11, Kevin Hilman khil...@ti.com wrote: When you're talking about potentially concurrent modification of data, that make sense.  Here you're implementing a plugin for an existing framework, and you can (and have to) make assumptions about when the callbacks are used.

Re: [PM-WIP_CPUFREQ][PATCH V3 3/8] OMAP2+: cpufreq: use opp/clk_*cpufreq_table based on silicon

2011-05-26 Thread Menon, Nishanth
On Thu, May 26, 2011 at 10:38, Kevin Hilman khil...@ti.com wrote: I'd prefer to see this even cleaner by dropping the clk_* versions all together.  Then, for those who want OMAP2 support (currently not working or validated anyways), all that's needed is to add a function simlilar to

Re: [PATCH 1/3] OMAP: change get_context_loss_count ret value to int

2011-05-26 Thread Paul Walmsley
Hello Tomi, Kevin, On Thu, 26 May 2011, Tomi Valkeinen wrote: get_context_loss_count functions return context loss count as u32, and zero means an error. However, zero is also returned when context has never been lost and could also be returned when the context loss count has wrapped and

Re: [PM-WIP_CPUFREQ][PATCH 0/6 V3] Cleanups for cpufreq

2011-05-26 Thread Menon, Nishanth
On Thu, May 26, 2011 at 11:10, Kevin Hilman khil...@ti.com wrote: So here's a dumb question, being rather ignorant of CPUfreq on SMP. Should we be running a CPUfreq instance on both CPUs when they cannot be scaled independently? What is being scaled here is actually the cluster (the MPU SS

Re: [PM-WIP_CPUFREQ][PATCH V3 3/8] OMAP2+: cpufreq: use opp/clk_*cpufreq_table based on silicon

2011-05-26 Thread Menon, Nishanth
On Thu, May 26, 2011 at 11:35, Menon, Nishanth n...@ti.com wrote: On Thu, May 26, 2011 at 10:38, Kevin Hilman khil...@ti.com wrote: I'd prefer to see this even cleaner by dropping the clk_* versions all together.  Then, for those who want OMAP2 support (currently not working or validated

[PATCH] ARM: OMAP2: Add missing iounmap in omap4430_phy_init

2011-05-26 Thread Todd Poynor
!dev case needs iounmap before return. Signed-off-by: Todd Poynor toddpoy...@google.com --- arch/arm/mach-omap2/omap_phy_internal.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/omap_phy_internal.c b/arch/arm/mach-omap2/omap_phy_internal.c index

[PATCH] free rev gpios when they are read, so others can read them later

2011-05-26 Thread Tasslehoff Kjappfot
A script of mine that reads the rev gpios on the beagleboard started failing when I upgraded to .37, since board-omap3beagle.c doesn´t free the rev gpios after using them. Signed-off-by: Tasslehoff Kjappfot tasskj...@gmail.com --- arch/arm/mach-omap2/board-omap3beagle.c |3 +++ 1 files

Re: [PM-WIP_CPUFREQ][PATCH V3 3/8] OMAP2+: cpufreq: use opp/clk_*cpufreq_table based on silicon

2011-05-26 Thread Kevin Hilman
Menon, Nishanth n...@ti.com writes: On Thu, May 26, 2011 at 11:35, Menon, Nishanth n...@ti.com wrote: On Thu, May 26, 2011 at 10:38, Kevin Hilman khil...@ti.com wrote: I'd prefer to see this even cleaner by dropping the clk_* versions all together.  Then, for those who want OMAP2 support

Re: [PATCH 03/13] OMAP2+: PM: clean up usage of SRAM functions

2011-05-26 Thread Kevin Hilman
jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Clean-up SRAM functions usage to better isolate PM code, in order to allow it to be used as a module. Could use some more description as to why this is needed. e.g. SRAM code is built-in, but PM code pushed to SRAM is module,

Re: [PATCH 07/13] OMAP2+: PM: move the powerdomains time stats to powerdomain code

2011-05-26 Thread Kevin Hilman
jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Move the powerdomains time accounting code from in pm-debug to the powerdomain code. The pm-debug code only displays the information on request. This also cleans up the core PM code, in order to allow it to be used as a

[PATCH/RFC 0/4] OMAP: PM debug: remove register dump, misc cleanups

2011-05-26 Thread Kevin Hilman
Inspired by Jean's work to move PM code to modules, I decided it's time to remove a bunch of ugly and difficult to maintain code from PM debug. The main chunk here is removing the register dump features for OMAP2/OMAP3 which are awful to read, and impossible to scale for OMAP4+. Also, there are

[PATCH/RFC 1/4] OMAP3: PM debug: remove sleep_while_idle feature

2011-05-26 Thread Kevin Hilman
Remove the OMAP-specific PM debug 'sleep_while_idle' feature which is currently available as an OMAP-specific debugfs entry. This duplicates existing ARM-generic functionality available as a boot-time option using the boot cmdline option 'hohlt'. If runtime configuration of this is needed, then

[PATCH/RFC 3/4] OMAP3: PM debug: remove register dumping

2011-05-26 Thread Kevin Hilman
Remove OMAP3-specific register dumping feature from PM debug layer. This is removed because: - it's ugly - it's OMAP3-specific, and will obviously not scale to OMAP4+ - userspace /dev/mem-based tools (like omapconf) can do this much better Signed-off-by: Kevin Hilman khil...@ti.com ---

[PATCH/RFC 2/4] OMAP2: PM debug: remove register dumping

2011-05-26 Thread Kevin Hilman
Signed-off-by: Kevin Hilman khil...@ti.com --- arch/arm/mach-omap2/pm-debug.c | 119 arch/arm/mach-omap2/pm.h |4 - arch/arm/mach-omap2/pm24xx.c |6 +- 3 files changed, 2 insertions(+), 127 deletions(-) diff --git

[PATCH/RFC 4/4] OMAP2: PM debug: move wakeup timer into clockevent code

2011-05-26 Thread Kevin Hilman
Move suspend wakeup timer from suspend path to be triggered based on clockevent suspend path. When gptimers are eventually converted to be a driver, the wakeup timer feature can be made to be a driver-specific feature using the driver's suspend method. Signed-off-by: Kevin Hilman khil...@ti.com

Re: [PATCH 08/13] OMAP2+: PM: provide the next timer event API to PM modules

2011-05-26 Thread Kevin Hilman
jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Provide omap_pm_tick_nohz_get_sleep_length_us so that the code from the OMAP PM modules can use it. Signed-off-by: Jean Pihet j-pi...@ti.com This patch is doing more than mentioned in the changelog. ---

Re: [PATCH 09/13] OMAP2+: PM: export suspend_set_ops to PM modules

2011-05-26 Thread Kevin Hilman
jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Export the suspend_set_ops API as omap_pm_suspend_set_ops in the pm generic code, under CONFIG_SUSPEND. Note -hack warning-: since the 'suspend_valid_only_mem' function is not exported to modules, fill the 'valid' field

Re: [RFC][PATCH 1/9] OMAP: ID: introduce chip detection for OMAP4460

2011-05-26 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: On 14:03-20110526, Premi, Sanjeev wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Menon, Nishanth Sent: Thursday, May 26, 2011 7:27 AM To: linux-omap Cc: V, Aneesh

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-26 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: From: Moiz Sonasath m-sonas...@ti.com For OMAP4460, GPIO-7 of bank1 is used for controling the TPS modes, hence GPIO1 should not be reset during init as reset will cause the TPS voltage to drop to 0.9 V. ouch. I knew one of these days something like this

Re: [RFC][PATCH 1/9] OMAP: ID: introduce chip detection for OMAP4460

2011-05-26 Thread Menon, Nishanth
On Thu, May 26, 2011 at 16:15, Kevin Hilman khil...@ti.com wrote: Nishanth Menon n...@ti.com writes: On 14:03-20110526, Premi, Sanjeev wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Menon, Nishanth Sent

Re: [RFC][PATCH 3/9] OMAP4460: HWMOD: DO not reset GPIO1 during HWMOD init

2011-05-26 Thread Menon, Nishanth
On Thu, May 26, 2011 at 16:24, Kevin Hilman khil...@ti.com wrote: Nishanth Menon n...@ti.com writes: From: Moiz Sonasath m-sonas...@ti.com For OMAP4460, GPIO-7 of bank1 is used for controling the TPS modes, hence GPIO1 should not be reset during init as reset will cause the TPS voltage to

[PM-WIP_CPUFREQ][PATCH v4 0/4] Cleanups for cpufreq

2011-05-26 Thread Nishanth Menon
Rev 4 of cleanups for cpufreq to take care of the review comments on the remaining rev3 patches. Applies on top of: git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git branch: pm-wip/cpufreq Tested on SDP4430 - with a TI internal loadgenerator controlled on each cpu while

[PM-WIP_CPUFREQ][PATCH v4 1/4] OMAP2+: cpufreq: dont support !freq_table

2011-05-26 Thread Nishanth Menon
OMAP2+ all have frequency tables, hence the hacks we had for older silicon do not need to be carried forward. As part of this change, use cpufreq_frequency_table_target to find the best match for frequency requested. Signed-off-by: Nishanth Menon n...@ti.com ---

[PM-WIP_CPUFREQ][PATCH v4 2/4] OMAP2+: cpufreq: use OPP library

2011-05-26 Thread Nishanth Menon
OMAP2 is the only family using clk_[init|exit]_cpufreq_table, however, the cpufreq code has does not use clk_init_cpufreq_table. As a result, it is unusuable for OMAP2 and only usable only on platforms using OPP library. So move the compilation for cpufreq only if OPP is available for the

[PM-WIP_CPUFREQ][PATCH v4 3/4] OMAP2+: cpufreq: put clk if cpu_init failed

2011-05-26 Thread Nishanth Menon
Release the mpu_clk in fail paths. Reported-by: Todd Poynor toddpoy...@google.com Signed-off-by: Nishanth Menon n...@ti.com --- arch/arm/mach-omap2/omap2plus-cpufreq.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c

[PM-WIP_CPUFREQ][PATCH v4 4/4] OMAP2+: cpufreq: fix freq_table leak

2011-05-26 Thread Nishanth Menon
We use a single frequency table for multiple CPUs. But, with OMAP4, since we have multiple CPUs, the cpu_init call for CPU1 causes freq_table previously allocated for CPU0 to be overwritten. In addition, we dont free the table on exit path. We solve this by maintaining an atomic type counter to

[PATCH pm_wip/voltdm_nm] ARM: OMAP: Explicitly mask VPVOLTAGE field

2011-05-26 Thread Todd Poynor
Reading the VPVOLTAGE field of PRM_VP_*_VOLTAGE registers currently relies on a u32 - u8 conversion to mask off the FORCEUPDATEWAIT field in the upper bits. Make this explicit using the mask and shift symbols already defined, added as new fields in struct omap_vp_common. Signed-off-by: Todd

Re: [PATCH 00/14] GPIO: OMAP: first round of cleanup

2011-05-26 Thread Grant Likely
On Fri, May 20, 2011 at 05:14:43PM +0200, Kevin Hilman wrote: Start moving SoC-specific register handling out of the driver by passing in register offsets in via platform data. Also, move OMAP1 MPUIO IRQ handling over to genric IRQ chip. Applies on top of Tony's for-next branch (which

Re: [PM-WIP_CPUFREQ][PATCH 0/6 V3] Cleanups for cpufreq

2011-05-26 Thread Santosh Shilimkar
On 5/26/2011 11:40 PM, Kevin Hilman wrote: So here's a dumb question, being rather ignorant of CPUfreq on SMP. Should we be running a CPUfreq instance on both CPUs when they cannot be scaled independently? What is being scaled here is actually the cluster (the MPU SS via dpll_mpu_ck), not an

Re: [PATCH/RFC 4/4] OMAP2: PM debug: move wakeup timer into clockevent code

2011-05-26 Thread Santosh Shilimkar
On 5/27/2011 4:32 AM, Kevin Hilman wrote: Move suspend wakeup timer from suspend path to be triggered based on clockevent suspend path. When gptimers are eventually converted to be a driver, the wakeup timer feature can be made to be a driver-specific feature using the driver's suspend method.

Re: [PATCH 1/3] OMAP: change get_context_loss_count ret value to int

2011-05-26 Thread Tomi Valkeinen
On Thu, 2011-05-26 at 12:37 -0600, Paul Walmsley wrote: Hello Tomi, Kevin, On Thu, 26 May 2011, Tomi Valkeinen wrote: get_context_loss_count functions return context loss count as u32, and zero means an error. However, zero is also returned when context has never been lost and could

Re: [PATCH 0/3] Some omap_device/hwmod/pwrdomain patches

2011-05-26 Thread Tomi Valkeinen
On Thu, 2011-05-26 at 10:30 -0700, Kevin Hilman wrote: Tomi Valkeinen tomi.valkei...@ti.com writes: I came up with these patches while implementing pm runtime adaptation for DSS driver. I'm not quite sure on who's turf they belong, or do they even belong together, but here they are