Re: [PATCH v6 10/16] OMAP2+: UART: Modify omap_uart_can_sleep function

Hi Govindraj, On Thu, Oct 13, 2011 at 3:09 AM, Govindraj govindraj...@gmail.com wrote: ... Yes, but obviously comes at the expense of power savings.  IOW, This is a hard-coded power vs. performance trade off that we are trying to get away from. So, the root of the problem is that the MPU

Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

On Tue, Sep 27, 2011 at 6:48 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: On Tue, Sep 27, 2011 at 6:12 PM, Tero Kristo t-kri...@ti.com wrote: On Tue, 2011-09-27 at 08:04 +0200, Basak, Partha wrote: Texas Instruments Oy, Tekniikantie 12, 02150 Espoo. Y-tunnus: 0115040-6. Kotipaikka:

[PATCH 01/27] cbus: tahvo: convert spinlock into mutex

GPIO operations can sleep, so move to a mutex. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c index d4a89a6..bc3ca6d 100644 ---

[PATCH 02/27] cbus: tahvo: move to __devinit/__devexit sections

while at that, also remove a few annoying and pretty much useless comments. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c | 36 +++- 1 files changed, 3 insertions(+), 33 deletions(-) diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c

[PATCH 04/27] cbus: tahvo: don't go over 80 columns

cleanup only, no functional changes. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c index 647d263..0e28208 100644 --- a/drivers/cbus/tahvo.c +++

[PATCH 05/27] cbus: tahvo: drop the tasklet

by moving to threaded IRQ. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c | 16 1 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c index 0e28208..4b062de 100644 --- a/drivers/cbus/tahvo.c +++

[PATCH 03/27] cbus: tahvo: a switch looks better

cleanup only, no functional changes. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c index 0da156e..647d263 100644 --- a/drivers/cbus/tahvo.c +++

[PATCH 07/27] cbus: tahvo: git it a context structure

just moving things around. It's a lot easier to handle a dynamically allocated structure as it allows for multiple instances of the same device. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c | 128 -- 1 files changed, 82

[PATCH 06/27] cbus: retu: set IRQF_ONESHOT flag

for handlers which don't have top half, it's necessary to IRQF_ONESHOT. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/retu.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/cbus/retu.c b/drivers/cbus/retu.c index b58c6e5..b7fbd18 100644 ---

[PATCH 08/27] cbus: tahvo: pass tahvo to IRQ handler

that way we don't need to access the global pointer Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c index 3a77d12..740bb05 100644 --- a/drivers/cbus/tahvo.c

[PATCH 10/27] cbus: tahvo: drop some unneded defines

no functional changes. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c index 04b8203..a538f13 100644 --- a/drivers/cbus/tahvo.c +++ b/drivers/cbus/tahvo.c

[PATCH 09/27] cbus: tahvo: introduce __tahvo_(read/write)_reg

those two functions are local to tahvo.c and should be used to read/write Tahvo's registers. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c | 56 +++-- 1 files changed, 40 insertions(+), 16 deletions(-) diff --git

[PATCH 12/27] cbus: tahvo: give it an irq_chip

tahvo also has IRQs to demux to its children, so lets give it a struct irq_chip so that child drivers can use standard request_threaded_irq(). This is still an unused irq_chip, later patches will come to make proper use of it. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c |

[PATCH 13/27] cbus: tahvo: start using irq_chip

in order to chieve that, we needed to allocate our children devices (currently only one) and fix up the irq handler. Signed-off-by: Felipe Balbi ba...@ti.com --- arch/arm/mach-omap1/board-nokia770.c |6 -- arch/arm/mach-omap2/board-n8x0.c |6 -- drivers/cbus/tahvo.c |

[PATCH 14/27] cbus: tahvo: usb: fix up to use threaded irqs

fix up tahvo-usb to use threaded irqs and the new IRQ chip. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo-usb.c | 35 +-- 1 files changed, 13 insertions(+), 22 deletions(-) diff --git a/drivers/cbus/tahvo-usb.c b/drivers/cbus/tahvo-usb.c index

[PATCH 15/27] cbus: tahvo drop the legacy interfaces

those tahvo-specific IRQ handling routines aren't needed anymore. Drop'em. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c | 64 -- drivers/cbus/tahvo.h |5 2 files changed, 0 insertions(+), 69 deletions(-) diff --git

[PATCH 16/27] cbus: tahvo: usb: drop unused variable

no functional changes. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo-usb.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/cbus/tahvo-usb.c b/drivers/cbus/tahvo-usb.c index 10619a8..e078440 100644 --- a/drivers/cbus/tahvo-usb.c +++

[PATCH 17/27] cbus: tahvo: no need to mask interrupts on exit

the children will be unloaded first and they will make sure to mask their own IRQ. While at that, also move subsys_init_call() close to tahvo_init(). Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git

[PATCH 18/27] cbus: tahvo: drop the get_status hack

that's really not needed. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo-usb.c |4 drivers/cbus/tahvo.c |6 -- drivers/cbus/tahvo.h |1 - 3 files changed, 0 insertions(+), 11 deletions(-) diff --git a/drivers/cbus/tahvo-usb.c

[PATCH 19/27] cbus: tahvo: drop more unused interfaces

we have the IRQ chip which is the standard way of handling IRQs. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c | 34 -- 1 files changed, 0 insertions(+), 34 deletions(-) diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c index

[PATCH 20/27] cbus: tahvo: pass child device pointer

on read/write register operations, if we pass the child device pointer, it becomes really easy to access our device structure. Let's do so. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo-usb.c | 18 ++ drivers/cbus/tahvo.c | 18 +++---

[PATCH 21/27] cbus: tahvo: drop backlight interfaces

they aren't used by anyone and they should be, anyways, on a child LED driver not on core Tahvo. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c | 51 +- drivers/cbus/tahvo.h |3 -- 2 files changed, 1 insertions(+), 53

[PATCH 22/27] cbus: tahvo: drop static global pointer

that's not used anywhere anymore. We can safely drop it. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c index 784431c..43f6d6a 100644 ---

[PATCH 23/27] cbus: tahvo: prepare for children without IRQ

not all tahvo children have a dedicated IRQ so don't add a resource for those. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c index

[PATCH 11/27] cbus: retu: IRQ demux optimization

it's definitely not always that we will have all 16 interrupts fired at the same time, so in order to avoid looping so many times, we are now using ffs() which is implemented (on ARM) using the far better clz instruction. This will save us quite some loops and could improve IRQ latency on Retu

[PATCH 24/27] cbus: tahvo: allocate tahvo-pwm child

this will serve as a backlight driver. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/tahvo.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/cbus/tahvo.c b/drivers/cbus/tahvo.c index 1540042..623dacb 100644 --- a/drivers/cbus/tahvo.c +++

[PATCH 25/27] cbus: fix compile issue on tahvo and retu

set_irq_noprobe has been renamed to irq_set_noprobe on commit a0cd9ca2b907d7ee26575e7b63ac92dad768a75e (genirq: Namespace cleanup) and cbus drivers were left with broken compilation. Fix it. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/retu.c |2 +- drivers/cbus/tahvo.c |2

[PATCH 26/27] cbus: use platform_driver_register on tahvo and retu

there's no need to use platform_driver_probe() here. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/retu.c |9 + drivers/cbus/tahvo.c |3 ++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/cbus/retu.c b/drivers/cbus/retu.c index

[PATCH 27/27] cbus: mark dependencies for ARCH_OMAP

This is just a temporary commit. Ideally, all these drivers wouldn't depend on a particular architecture, but some of those Retu/Tahvo children are using headers under plat, so we must add this dependency until that's sorted out. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/cbus/Kconfig

Re: [PATCH 5/5 v14] omap: usb: host: Replace usbhs core driver APIs by Runtime pm APIs

On Thu, 13 Oct 2011, Felipe Balbi wrote: Hi, On Tue, Oct 11, 2011 at 01:22:11PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com The ehci and ohci drivers does not use the APIs of the usbhs core driver; the runtime pm APIs are used for clock

Re: [PATCH v2 2/5] dt: add empty dt helpers for non-dt build

On Mon, Oct 10, 2011 at 09:49:35PM +0530, Rajendra Nayak wrote: Add empty of_device_is_compatible(), of_find_property() and of_parse_phandle() for non-dt builds to work. Signed-off-by: Rajendra Nayak rna...@ti.com Applied, thanks. The of_find_property() already had an empty version in