Re: [PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

2012-07-12 Thread S, Venkatraman
On Wed, Jul 11, 2012 at 5:10 AM, Kevin Hilman khil...@ti.com wrote: If platform_get_resource_by_name() fails, driver probe is aborted an should return an error so the driver is not bound to the device. However, in the current error path of platform_get_resource_by_name(), probe returns zero

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-12 Thread Munegowda, Keshava
On Wed, Jul 11, 2012 at 7:53 PM, Kevin Hilman khil...@ti.com wrote: Munegowda, Keshava keshava_mgo...@ti.com writes: On Wed, Jul 11, 2012 at 3:59 PM, Samuel Ortiz sa...@linux.intel.com wrote: Hi Keshava, Kevin, On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, Keshava wrote: Samuel

Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?

2012-07-12 Thread Joe Woodward
...snip... Hmm, interesting, I don't see this on my 3730-based Over FireSTORM. But, after converting mine into an AirStorm[1], I see the same errors as you're seeing. We're obviously doing something wrong when IVA and/or SGX are not present, so I will look into it. With the hack

Re: suspend broken on 3.5-rc1?

2012-07-12 Thread Tero Kristo
On Thu, 2012-07-12 at 10:57 +0530, Rajendra Nayak wrote: On Thursday 12 July 2012 05:28 AM, Omar Ramirez Luna wrote: I suspect this might be specific to 4460 as Rajendra reported it was working for him on 4430 but not on 4460, I haven't tried 4430 but let me see if I can find one. Yes,

Re: [PATCH] ARM: OMAP2+: omap2plus_defconfig: EHCI driver is not stable, disable it

2012-07-12 Thread Munegowda, Keshava
On Fri, Jul 6, 2012 at 11:50 PM, Kevin Hilman khil...@ti.com wrote: The EHCI driver is not stable enough to be enabled by default. In v3.5, it has at least the following problems: - warning dump during bootup - hang during suspend - prevents CORE powerdomain from entering retention during

RE: [PATCH v2 1/3] arm: omap: hwmod: add new memory resource for usb phy control

2012-07-12 Thread Santhapuri, Damodar
Hi, Hello. On 11-07-2012 14:29, Damodar Santhapuri wrote: From: Ajay Kumar Gupta ajay.gu...@ti.com Added usb_ctrl0 and usb_ctrl1 base address as new memory resources which will be used at am335x musb driver glue layer to turn on or off builin PHY untill we have a separate system

Re: [PATCHv3 5/9] ARM: OMAP3: set autoidle flags for a few clocks

2012-07-12 Thread Rajendra Nayak
Hi Tero, On Thursday 31 May 2012 06:58 PM, Tero Kristo wrote: dpll3, dpll4 and sdrc_ick are controlled automatically by hardware. sdrc_ick does not seem to have a software control to enable/disable this automatic control in hardware, so what you are doing in the patch below seems fine.

Re: [PATCHv3 8/9] ARM: OMAP3: prevent per_clkdm from attempting manual domain transitions

2012-07-12 Thread Rajendra Nayak
On Thursday 31 May 2012 06:59 PM, Tero Kristo wrote: Previously, PER clock domain was always enabled, as the usecounts for this domain incorrectly always showed positive value. On HW level though, the domain enters idle as it is set in HW supervised mode. Now, when the usecounts reflect real

[PATCH 06/11] arm/dts: am33xx: Add dt data for usbss

2012-07-12 Thread Ajay Kumar Gupta
Added device tree data for usbss on am33xx. There are two musb controllers on am33xx platform so have port0_mode and port1_mode additional data. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- arch/arm/boot/dts/am33xx.dtsi | 11 +++ 1 files changed, 11 insertions(+), 0

[PATCH 07/11] usb: otg: nop: add dt support

2012-07-12 Thread Ajay Kumar Gupta
Added device tree support for nop transceiver driver and updated the Documentation with device tree binding information for am33xx platform. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- .../devicetree/bindings/usb/am33xx-usb.txt |3 +++ drivers/usb/otg/nop-usb-xceiv.c

[PATCH 01/11] usb: musb: add musb-id to identify core instance

2012-07-12 Thread Ajay Kumar Gupta
Added 'id' field within 'struct musb' which can be used to determine the current instance of musb controller. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- drivers/usb/musb/am35x.c |2 +- drivers/usb/musb/blackfin.c |2 +- drivers/usb/musb/da8xx.c |2 +-

[PATCH 08/11] arm/dts: am33xx: add dt data for usb nop phy

2012-07-12 Thread Ajay Kumar Gupta
AM33xx has two musb controller and they have one NOP PHY each. Added the device tree data for NOP PHY. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- arch/arm/boot/dts/am33xx.dtsi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi

[PATCH 03/11] usb: musb: am335x: add support for dual instance

2012-07-12 Thread Ajay Kumar Gupta
AM335x and TI81xx platform has dual musb controller so updating the musb_dspc.c to support the same. Changes: - Moved otg_workaround timer to glue structure - Moved static local variable last_timer to glue structure - PHY on/off related cleanups Signed-off-by: Ajay Kumar

[PATCH 04/11] usb: otg: nop: add support for multiple tranceiver

2012-07-12 Thread Ajay Kumar Gupta
Currently we have one single nop transceiver support as same is defined as a global variable in drivers/usb/otg/nop-usb-xceiv.c. This need to be changed to support multiple otg controller each using nop transceiver on a platform such as am335x. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com

[PATCH 05/11] usb: musb: dsps: add dt support

2012-07-12 Thread Ajay Kumar Gupta
Added device tree support for dsps musb glue driver and updated the Documentation with device tree binding information. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- .../devicetree/bindings/usb/am33xx-usb.txt | 14 + drivers/usb/musb/musb_dsps.c | 62

[PATCH 09/11] usb: musb: dsps: remove explicit NOP device creation

2012-07-12 Thread Ajay Kumar Gupta
As NOP device node is now added in am33xx tree so remove the call which creates the NOP platform_device. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- drivers/usb/musb/musb_dsps.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/usb/musb/musb_dsps.c

[PATCH 00/11] usb: musb: adding multi instance support

2012-07-12 Thread Ajay Kumar Gupta
Hi, This series of patches adds, a) Multi instances support in musb driver b) DT support for musb_dsps glue layer c) DT support for NOP transceiver AM33xx and TI81xx has dual musb controller and has two usb PHY of same type. This patch series uses 'phandle' based API

[PATCH 02/11] usb: musb: kill global and static for multi instance

2012-07-12 Thread Ajay Kumar Gupta
Moved global variable musb_debugfs_root and static variable old_state to 'struct musb' to help support multi instance of musb controller as present on AM335x platform. Also removed the global variable orig_dma_mask and filled the dev-dma_mask with parent device's dma_mask. Signed-off-by: Ajay

[PATCH 10/11] usb: musb: dsps: get the PHY using phandle api

2012-07-12 Thread Ajay Kumar Gupta
AM33xx has two PHY of same type used by each musb controller so use phandle of phy nodes to get the phy pointer. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- .../devicetree/bindings/usb/am33xx-usb.txt |2 ++ drivers/usb/musb/musb_dsps.c |4 +++- 2

[PATCH 11/11] arm/dts: am33xx: add phy phandle to usbss

2012-07-12 Thread Ajay Kumar Gupta
Added NOP PHY phandle to usbss device node as same will be used to get the phy from otg framework. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com --- arch/arm/boot/dts/am33xx.dtsi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi

[PATCH v3 3/3] usb: musb: dsps: enable phy control for am335x

2012-07-12 Thread Damodar Santhapuri
From: Ajay Kumar Gupta ajay.gu...@ti.com Enabled the phy control logic for am335x also based on usbss revision register. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com Signed-off-by: Damodar Santhapuri damodar.santhap...@ti.com --- arch/arm/plat-omap/include/plat/usb.h |1 +

[PATCH v3 2/3] usb: musb: dsps: add phy control logic to glue

2012-07-12 Thread Damodar Santhapuri
From: Ajay Kumar Gupta ajay.gu...@ti.com AM335x uses NOP transceiver driver and need to enable builtin PHY by writing into usb_ctrl register available in system control module register space. This is being added at musb glue driver layer untill a separate system control module driver is

[PATCH v3 1/3] arm: omap: hwmod: add new memory resource for usb phy control

2012-07-12 Thread Damodar Santhapuri
From: Ajay Kumar Gupta ajay.gu...@ti.com Added usb_ctrl0 and usb_ctrl1 base address as new memory resources which will be used at am335x musb driver glue layer to turn on or off builin PHY untill we have a separate system control module driver. Signed-off-by: Ajay Kumar Gupta ajay.gu...@ti.com

[PATCH] ARM: OMAP3: clockdomain: fix accidental duplicate registration

2012-07-12 Thread Paul Walmsley
Commit 3dd50d0545bd5a8ad83d4339f07935cd3e883271 (Merge tag 'omap-cleanup-for-v3.6' into tmp-merge) inadvertently caused a clockdomain to be registered twice on OMAP3 boards. This causes warnings on boot, wild pointer dereferences, and PM regressions. Fix the double registration and add some

Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?

2012-07-12 Thread Paul Walmsley
Hi Joe can you give this one a try to see if it helps: http://marc.info/?l=linux-omapm=134209072829531w=2 - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-12 Thread Linus Walleij
On Thu, Jul 12, 2012 at 1:25 AM, Kevin Hilman khil...@ti.com wrote: There is quite a bit of other things to do in remove to properly cleanup what is done in probe. OK I'm dropping this patch for now... Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCHv11 1/6] i2c: omap: Optimise the remove code

2012-07-12 Thread Wolfram Sang
On Thu, Jun 28, 2012 at 08:41:27PM +0530, Shubhrajyoti D wrote: The omap_i2c_remove function may not be needed after device exit so the memory could be freed. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com Changed the title from optimise to annotate and pushed to next. -- Pengutronix

Re: [PATCHv11 2/6] i2c: omap: Use SET_RUNTIME_PM_OPS

2012-07-12 Thread Wolfram Sang
On Thu, Jun 28, 2012 at 08:41:28PM +0530, Shubhrajyoti D wrote: Use SET_RUNTIME_PM_OPS macro to set runtime functions. Acked-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com Applied to next, thanks. -- Pengutronix e.K. | Wolfram Sang

Re: [PATCHv11 3/6] i2c: omap: Do not initialise the completion everytime

2012-07-12 Thread Wolfram Sang
On Thu, Jun 28, 2012 at 08:41:29PM +0530, Shubhrajyoti D wrote: Use INIT_COMPLETION instead of init_completion in transfer. Reviewed-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com Applied to next, thanks. -- Pengutronix e.K. |

Re: [PATCHv11 4/6] i2c: omap: Remove the definition of SYSS_RESETDONE_MASK

2012-07-12 Thread Wolfram Sang
On Thu, Jun 28, 2012 at 08:41:30PM +0530, Shubhrajyoti D wrote: Remove the definition of SYSS_RESETDONE_MASK and use the one in omap_hwmod.h. Reviewed-by: Felipe Balbi ba...@ti.com Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com --- - Add Felipe's reviewed by tag

Re: [PATCHv11 5/6] i2c: omap: Correct I2C revision for OMAP3

2012-07-12 Thread Wolfram Sang
On Thu, Jun 28, 2012 at 08:41:31PM +0530, Shubhrajyoti D wrote: From: Jon Hunter jon-hun...@ti.com The OMAP3530 is based upon the same silicon as the OMAP3430 and so the I2C revision is the same for 3430 and 3530. However, the OMAP3630 device has the same I2C revision as OMAP4. Correct the

Re: [PATCHv11 6/6] i2c: omap: Recover from Bus Busy condition

2012-07-12 Thread Wolfram Sang
On Thu, Jun 28, 2012 at 08:41:32PM +0530, Shubhrajyoti D wrote: From: Vikram Pandita vikram.pand...@ti.com In case a peripheral is driving SDA bus low (ie. a start condition), provide a constant clock output using the test mode of the OMAP I2C controller to try and clear the bus. Soft reset

Re: [PATCHv11 0/6] I2C cleanups

2012-07-12 Thread Wolfram Sang
On Mon, Jul 09, 2012 at 05:17:07PM +0530, Shubhrajyoti Datta wrote: On Thu, Jun 28, 2012 at 8:41 PM, Shubhrajyoti D shubhrajy...@ti.com wrote: This is a minimal cleanup series. If there are no further comments can this series be queued? I just applied a few of them. BTW I get a build

[PATCH V2] Add missing modules aliases to get sound working on omap devices

2012-07-12 Thread Guillaume Gardet
This patch add missing modules aliases to get sound working on omap devices. Tested on Beagleboard xM rev. B. This patch is against 3.5-rc6 vanilla. Signed-off-by: Guillaume GARDET guillaume.gar...@free.fr Signed-off-by: Mans Rullgard mans.rullg...@linaro.org From

[PATCH] OMAP4: 4430sdp: OTG: increase max allowed output current

2012-07-12 Thread Ruslan Bilovol
TWL6030/32 that is used on 4430sdp board can deliver up to 200mA for OTG port power supply in the HOST mode. Signed-off-by: Ruslan Bilovol ruslan.bilo...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?

2012-07-12 Thread Joe Woodward
-Original Message- From: Paul Walmsley p...@pwsan.com To: Joe Woodward j...@terrafix.co.uk Cc: Kevin Hilman khil...@ti.com, linux-omap\\@vger.kernel.org linux-omap@vger.kernel.org Date: Thu, 12 Jul 2012 04:59:09 -0600 (MDT) Subject: Re: PM/RTC 3.5-rc5: System suspends fails when not built

Re: [PATCHv3 5/9] ARM: OMAP3: set autoidle flags for a few clocks

2012-07-12 Thread Tero Kristo
On Thu, 2012-07-12 at 14:43 +0530, Rajendra Nayak wrote: Hi Tero, On Thursday 31 May 2012 06:58 PM, Tero Kristo wrote: dpll3, dpll4 and sdrc_ick are controlled automatically by hardware. sdrc_ick does not seem to have a software control to enable/disable this automatic control in

Re: [PATCHv3 8/9] ARM: OMAP3: prevent per_clkdm from attempting manual domain transitions

2012-07-12 Thread Tero Kristo
On Thu, 2012-07-12 at 15:11 +0530, Rajendra Nayak wrote: On Thursday 31 May 2012 06:59 PM, Tero Kristo wrote: Previously, PER clock domain was always enabled, as the usecounts for this domain incorrectly always showed positive value. On HW level though, the domain enters idle as it is set

Re: [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver

2012-07-12 Thread Kevin Hilman
Hi Linus, Linus Walleij linus.wall...@linaro.org writes: On Thu, Jul 12, 2012 at 1:25 AM, Kevin Hilman khil...@ti.com wrote: There is quite a bit of other things to do in remove to properly cleanup what is done in probe. OK I'm dropping this patch for now... Thanks. For future

Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?

2012-07-12 Thread Kevin Hilman
Joe Woodward j...@terrafix.co.uk writes: ...snip... Hmm, interesting, I don't see this on my 3730-based Over FireSTORM. But, after converting mine into an AirStorm[1], I see the same errors as you're seeing. We're obviously doing something wrong when IVA and/or SGX are not present,

Re: suspend broken on 3.5-rc1?

2012-07-12 Thread Omar Ramirez Luna
On 12 July 2012 00:27, Rajendra Nayak rna...@ti.com wrote: On Thursday 12 July 2012 05:28 AM, Omar Ramirez Luna wrote: I suspect this might be specific to 4460 as Rajendra reported it was working for him on 4430 but not on 4460, I haven't tried 4430 but let me see if I can find one. Yes,

Re: [PATCH V2 08/10] ARM: OMAP4: Prevent EMU power domain transitioning to OFF when in-use

2012-07-12 Thread Paul Walmsley
Hello Jon On Thu, 7 Jun 2012, Jon Hunter wrote: By removing the CLKDM_CAN_ENABLE_AUTO flag, the EMU clock domain will always remain on and hence, this will break low-power modes. The EMU clock domain only support the SW_WKUP and HW_AUTO transition modes (for more details refer to the

Re: [PATCH 1/1] Fix sprz319 erratum 2.1

2012-07-12 Thread Paul Walmsley
Hi, On Fri, 24 Feb 2012, Paul Walmsley wrote: cc'ing beagleboard list, Kevin Hi Richard, thanks for the patch. A quick question for you or anyone else who is experiencing this problem. On Mon, 20 Feb 2012, Richard Watts wrote: There is an erratum in DM3730 which results in the

Criteria for merging new board support files

2012-07-12 Thread Raphael Assenat
Hello, We have designed a board based on the AM3505 to use in one of our products, an unattended payment terminal. I am wondering if it would be meaningful to clean up and submit our patches to add support for our board in the mainline. As this board is neither a development/evm platform nor a

RE: [PATCH v5 3/3] ARM: OMAP2+: onenand: prepare for gpmc driver migration

2012-07-12 Thread Mohammed, Afzal
Hi Tony, Jon, Thanks for your explanations, ideas suggestions. Let me try to come up with a solution based on these. Regards Afzal On Wed, Jul 11, 2012 at 12:17:25, Tony Lindgren wrote: * Jon Hunter jon-hun...@ti.com [120710 10:20]: Hi Afzal, On 07/10/2012 08:47 AM, Mohammed, Afzal

Re: [PATCH 2/8] ARM: OMAP2+: PM: introduce power domains functional states

2012-07-12 Thread Menon, Nishanth
On Fri, Jul 13, 2012 at 12:26 AM, Rajendra Nayak rna...@ti.com wrote: On Friday 13 July 2012 08:31 AM, Menon, Nishanth wrote: my Crib about the above apis are lack of logic power state handling:( which forces code like cpuidle to use different apis for logic power state and force them to use

RE: [PATCH v2 1/3] regulator: tps65217: Add device tree support

2012-07-12 Thread AnilKumar, Chimata
Hi Mark, On Thu, Jul 12, 2012 at 22:58:37, Mark Brown wrote: On Tue, Jul 10, 2012 at 04:39:42PM +0530, AnilKumar Ch wrote: This commit adds device tree support for tps65217 pmic. And usage details are added to device tree documentation. Driver is tested by using kernel module with

Re: [PATCH] OMAP4: 4430sdp: OTG: increase max allowed output current

2012-07-12 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Jul 12, 2012 at 6:55 PM, Ruslan Bilovol ruslan.bilo...@ti.com wrote: TWL6030/32 that is used on 4430sdp board can deliver up to 200mA for OTG port power supply in the HOST mode. Signed-off-by: Ruslan Bilovol ruslan.bilo...@ti.com --- arch/arm/mach-omap2/board-4430sdp.c |2