[PATCH] usb/dwc3: comment update

2015-03-30 Thread Michael S. Tsirkin
The top of include/linux/pci_ids.h says: Do not add new entries to this file unless the definitions are shared between multiple drivers. Drop comment in usb/dwc3 which conflicts with this. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- drivers/usb/dwc3/dwc3-pci.c | 1 - 1

Re: [PATCH 3/3] mfd: menelaus: use macro for magic number

2015-03-30 Thread Lee Jones
On Sat, 28 Mar 2015, Aaro Koskinen wrote: Use macro to check a register bit. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/mfd/menelaus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c

Re: [PATCH 86/86] usb/dwc3: move ids to pci_ids.h

2015-03-30 Thread Michael S. Tsirkin
On Mon, Mar 30, 2015 at 08:58:10AM +0200, Greg Kroah-Hartman wrote: On Mon, Mar 30, 2015 at 08:50:34AM +0200, Michael S. Tsirkin wrote: On Sun, Mar 29, 2015 at 10:42:00PM +0200, Greg Kroah-Hartman wrote: On Sun, Mar 29, 2015 at 03:43:40PM +0200, Michael S. Tsirkin wrote: Comment says IDs

Re: [PATCH 2/3] mfd: menelaus: drop support for SW controller VCORE

2015-03-30 Thread Lee Jones
On Sat, 28 Mar 2015, Aaro Koskinen wrote: Drop support for SW controlled VCORE, nobody uses it. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/mfd/menelaus.c | 23 --- include/linux/mfd/menelaus.h | 1 - 2 files changed, 24 deletions(-) Applied,

Re: [PATCH 86/86] usb/dwc3: move ids to pci_ids.h

2015-03-30 Thread Greg Kroah-Hartman
On Mon, Mar 30, 2015 at 08:50:34AM +0200, Michael S. Tsirkin wrote: On Sun, Mar 29, 2015 at 10:42:00PM +0200, Greg Kroah-Hartman wrote: On Sun, Mar 29, 2015 at 03:43:40PM +0200, Michael S. Tsirkin wrote: Comment says IDs should move to pci_ids.h, let's do it. No, please remove the

Re: [PATCH 86/86] usb/dwc3: move ids to pci_ids.h

2015-03-30 Thread Michael S. Tsirkin
On Sun, Mar 29, 2015 at 10:42:00PM +0200, Greg Kroah-Hartman wrote: On Sun, Mar 29, 2015 at 03:43:40PM +0200, Michael S. Tsirkin wrote: Comment says IDs should move to pci_ids.h, let's do it. No, please remove the comment, it's not needed in pci_ids.h at all. vendor ID does belong in

Re: [PATCH 1/3] mfd: menelaus: delete omap_has_menelaus

2015-03-30 Thread Lee Jones
On Sat, 28 Mar 2015, Aaro Koskinen wrote: Delete unused macro. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- include/linux/mfd/menelaus.h | 6 -- 1 file changed, 6 deletions(-) Applied, thanks. diff --git a/include/linux/mfd/menelaus.h b/include/linux/mfd/menelaus.h index

Re: [PATCH 6/6] mmc: omap_hsmmc: use generic slot-gpio isr to manage card detect pin

2015-03-30 Thread Ulf Hansson
On 3 March 2015 at 13:28, Andreas Fenkart afenk...@gmail.com wrote: Signed-off-by: Andreas Fenkart afenk...@gmail.com Thanks! Applied. Kind regards Uffe --- drivers/mmc/host/omap_hsmmc.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c

Re: [PATCH 5/6] mmc: omap_hsmmc: simplify card/cover detect isr

2015-03-30 Thread Ulf Hansson
On 3 March 2015 at 13:28, Andreas Fenkart afenk...@gmail.com wrote: strip the card dectet logic from cover detect isr and vice versa the generic mmc_gpio_cd_irqt isr, uses 200ms on removal/insertion, hence that should be fine here as well Signed-off-by: Andreas Fenkart afenk...@gmail.com

Re: [PATCH] mfd: twl6040: Remove wrong and unneeded platform:twl6040 modalias

2015-03-30 Thread Lee Jones
On Mon, 30 Mar 2015, Axel Lin wrote: This is a I2C driver, so it's wrong to use platform prefix for the modalias. We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, so let's remove the wrong and unneeded platform:twl6040 modalias. Signed-off-by: Axel Lin axel@ingics.com

Re: [GIT PULL] OMAP-GPMC driver updates for v4.1

2015-03-30 Thread Roger Quadros
Arnd, Olof, On 23/03/15 12:32, Roger Quadros wrote: Hi Arnd, Hi Olof, Based on Tony's request I will be sending you pull requests for OMAP-GPMC driver hence forth. I've sent this earlier on the 9th of March but had missed to copy Olof. Please pull in these OMAP-GPMC driver fixes for

[PATCH] mfd: twl6040: Remove wrong and unneeded platform:twl6040 modalias

2015-03-30 Thread Axel Lin
This is a I2C driver, so it's wrong to use platform prefix for the modalias. We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, so let's remove the wrong and unneeded platform:twl6040 modalias. Signed-off-by: Axel Lin axel@ingics.com --- drivers/mfd/twl6040.c | 1 - 1 file

[PATCH] genirq: provide dummy set_irq_wake()

2015-03-30 Thread Roger Quadros
Without this system suspend is broken on systems that have drivers calling enable/disable_irq_wake() for interrupts based off the dummy irq hook. (e.g. drivers/gpio/gpio-pcf857x.c) http://article.gmane.org/gmane.linux.kernel/1879035 Signed-off-by: Roger Quadros rog...@ti.com ---

[PATCH] mfd: twl4030-power: Fix pmic for boards that need AC charger disabled

2015-03-30 Thread Tony Lindgren
I noticed the PMIC configuration on 37xx-evm won't actually shut down the voltages during off-idle. Turns out 37xx-evm needs the AC charger state transitions disabled like we are doing for SDP and LDP in the legacy booting case. Let's fix this for device tree based booting by setting up the quirk

Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages

2015-03-30 Thread Jarkko Nikula
On 03/30/2015 07:42 PM, Tony Lindgren wrote: * Jarkko Nikula jarkko.nik...@bitmer.com [150330 09:31]: On 03/01/2015 09:07 PM, Jarkko Nikula wrote: From: Pavel Machek pa...@ucw.cz N900 audio recording needs that codec provides bias voltage for integrated digital microphone and headset

Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages

2015-03-30 Thread Tony Lindgren
* Jarkko Nikula jarkko.nik...@bitmer.com [150330 10:46]: On 03/30/2015 07:42 PM, Tony Lindgren wrote: * Jarkko Nikula jarkko.nik...@bitmer.com [150330 09:31]: On 03/01/2015 09:07 PM, Jarkko Nikula wrote: From: Pavel Machek pa...@ucw.cz N900 audio recording needs that codec provides bias

Re: [PATCH] genirq: provide dummy set_irq_wake()

2015-03-30 Thread Felipe Balbi
On Mon, Mar 30, 2015 at 04:15:45PM +0300, Roger Quadros wrote: Without this system suspend is broken on systems that have drivers calling enable/disable_irq_wake() for interrupts based off the dummy irq hook. (e.g. drivers/gpio/gpio-pcf857x.c)

Re: [PATCH v2 14/15] omap3isp: Add support for the Device Tree

2015-03-30 Thread Sebastian Reichel
Hi, The code crashed for me on Nokia N900. I found the following problem: On Thu, Mar 26, 2015 at 12:57:38AM +0200, Sakari Ailus wrote: [...] +static int isp_of_parse_nodes(struct device *dev, + struct v4l2_async_notifier *notifier) +{ + struct device_node

Re: [PATCH 2/5] dmaengine: omap-dma: Fix memory leak when terminating running transfer

2015-03-30 Thread Vinod Koul
On Fri, Mar 27, 2015 at 01:35:52PM +0200, Peter Ujfalusi wrote: In omap_dma_start_desc the vdesc-node is removed from the virt-dma framework managed lists (to be precise from the desc_issued list). If a terminate_all comes before the transfer finishes the omap_desc will not be freed up because

Re: [PATCH 1/5] dmaengine: edma: fix memory leak when terminating running transfers

2015-03-30 Thread Vinod Koul
On Fri, Mar 27, 2015 at 01:35:51PM +0200, Peter Ujfalusi wrote: From: Petr Kulhavy p...@barix.com If edma_terminate_all() was called while a transfer was running (i.e. after edma_execute() but before edma_callback()) the echan-edesc was not freed. This was due to the fact that a running

Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages

2015-03-30 Thread Tony Lindgren
* Jarkko Nikula jarkko.nik...@bitmer.com [150330 09:31]: On 03/01/2015 09:07 PM, Jarkko Nikula wrote: From: Pavel Machek pa...@ucw.cz N900 audio recording needs that codec provides bias voltage for integrated digital microphone and headset microphone depending which one is used.

Re: [PATCH v2 1/7] dmaengine: of_dma: Support for DMA routers

2015-03-30 Thread Vinod Koul
On Fri, Mar 27, 2015 at 02:25:29PM +0200, Peter Ujfalusi wrote: On 03/26/2015 05:32 PM, Vinod Koul wrote: I have added the DT binding document since this series adds support for routers for platforms booting with DT: Documentation/devicetree/bindings/dma/dma.txt | 28 I meant

Re: [PATCH] genirq: provide dummy set_irq_wake()

2015-03-30 Thread Felipe Balbi
On Mon, Mar 30, 2015 at 01:06:24PM -0500, Felipe Balbi wrote: On Mon, Mar 30, 2015 at 04:15:45PM +0300, Roger Quadros wrote: Without this system suspend is broken on systems that have drivers calling enable/disable_irq_wake() for interrupts based off the dummy irq hook. (e.g.

Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages

2015-03-30 Thread Jarkko Nikula
On 03/01/2015 09:07 PM, Jarkko Nikula wrote: From: Pavel Machek pa...@ucw.cz N900 audio recording needs that codec provides bias voltage for integrated digital microphone and headset microphone depending which one is used. Digital microphone uses 2 V bias and it comes from the codec A part.

Re: [PATCH] arm: dts: omap3: Add #iommu-cells to isp iommu

2015-03-30 Thread Sakari Ailus
Hi Sebastian, On Tue, Mar 31, 2015 at 01:13:23AM +0200, Sebastian Reichel wrote: Add missing #iommu-cells property to the image signal processor's iommu node. This fixes the binding (property is required according to the generic iommu binding) and removes the following kernel warning

Re: [PATCHv5 30/35] ARM: dts: omap4: add minimal l4 bus layout with control module support

2015-03-30 Thread Tony Lindgren
Hi, * Tero Kristo t-kri...@ti.com [150320 11:46]: This patch creates the l4_cfg and l4_wkup interconnects for OMAP4, and moves some of the generic peripherals under it. System control module support is added to the device tree also, and the existing SCM related functionality is moved under

Re: [PATCH v2 14/15] omap3isp: Add support for the Device Tree

2015-03-30 Thread Sakari Ailus
Hi Sebastian, On Mon, Mar 30, 2015 at 07:41:23PM +0200, Sebastian Reichel wrote: Hi, The code crashed for me on Nokia N900. I found the following problem: On Thu, Mar 26, 2015 at 12:57:38AM +0200, Sakari Ailus wrote: [...] +static int isp_of_parse_nodes(struct device *dev, +

[PATCH] arm: dts: omap3: Add #iommu-cells to isp iommu

2015-03-30 Thread Sebastian Reichel
Add missing #iommu-cells property to the image signal processor's iommu node. This fixes the binding (property is required according to the generic iommu binding) and removes the following kernel warning triggered once the iommu node is referenced: [0.647521] /ocp/isp@480bc000: could not get

[PATCH 1/1] omap3isp: Don't pass uninitialised arguments to of_graph_get_next_endpoint()

2015-03-30 Thread Sakari Ailus
isp_of_parse_nodes() passed an uninitialised prev argument to of_graph_get_next_endpoint(). This is bad, fix it by assigning NULL to it in the initialisation. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Reported-by: Sebastian Reichel s...@kernel.org --- drivers/media/platform/omap3isp/isp.c

Re: [PATCHv5 26/35] ARM: dts: omap3: add minimal l4 bus layout with control module support

2015-03-30 Thread Tony Lindgren
Hi, * Tero Kristo t-kri...@ti.com [150320 11:46]: --- a/arch/arm/boot/dts/omap3.dtsi +++ b/arch/arm/boot/dts/omap3.dtsi @@ -87,6 +87,60 @@ ranges; ti,hwmods = l3_main; + l4_core: l4@4800 { + compatible = ti,omap3-l4-core,

Re: [PATCH 1/1] omap3isp: Don't pass uninitialised arguments to of_graph_get_next_endpoint()

2015-03-30 Thread Sebastian Reichel
Hi, On Tue, Mar 31, 2015 at 02:13:28AM +0300, Sakari Ailus wrote: isp_of_parse_nodes() passed an uninitialised prev argument to of_graph_get_next_endpoint(). This is bad, fix it by assigning NULL to it in the initialisation. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Reported-by:

[PATCH 01/25] arm: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
Use the normal return values for bool functions Signed-off-by: Joe Perches j...@perches.com --- arch/arm/include/asm/dma-mapping.h | 8 arch/arm/include/asm/kvm_emulate.h | 2 +- arch/arm/mach-omap2/powerdomain.c | 14 +++--- 3 files changed, 12 insertions(+), 12 deletions(-)

[PATCH 00/25] treewide: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
Joe Perches (25): arm: Use bool function return values of true/false not 1/0 arm64: Use bool function return values of true/false not 1/0 hexagon: Use bool function return values of true/false not 1/0 ia64: Use bool function return values of true/false not 1/0 mips: Use bool function

Re: [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0

2015-03-30 Thread Casey Schaufler
On 3/30/2015 4:45 PM, Joe Perches wrote: Joe Perches (25): arm: Use bool function return values of true/false not 1/0 arm64: Use bool function return values of true/false not 1/0 hexagon: Use bool function return values of true/false not 1/0 ia64: Use bool function return values of

Re: [PATCHv5 00/35] ARM: OMAP2+: PRCM/SCM cleanups against 4.0-rc

2015-03-30 Thread Tony Lindgren
Hi Tero, * Tero Kristo t-kri...@ti.com [150320 11:45]: Hi, v5 contains the following changes still: - re-ordered patches a bit, the single clock driver fix moved to beginning of the set, waiting for a separate merge from Mike - Changed patch #23 to fix the slightly misleading logic

[PATCHv2] arm: dts: omap3: Add #iommu-cells to isp and iva iommu

2015-03-30 Thread Sebastian Reichel
Add missing #iommu-cells property to the isp and iva iommu nodes. This fixes the binding (property is required according to the generic iommu binding) and removes the following kernel warning triggered once the iommu nodes are referenced: [0.647521] /ocp/isp@480bc000: could not get

Re: [PATCHv5 00/35] ARM: OMAP2+: PRCM/SCM cleanups against 4.0-rc

2015-03-30 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [150330 17:15]: Hi Tero, * Tero Kristo t-kri...@ti.com [150320 11:45]: Hi, v5 contains the following changes still: - re-ordered patches a bit, the single clock driver fix moved to beginning of the set, waiting for a separate merge from Mike -

Re: [PATCH 00/25] treewide: Use bool function return values of true/false not 1/0

2015-03-30 Thread Joe Perches
On Mon, 2015-03-30 at 17:07 -0700, Casey Schaufler wrote: On 3/30/2015 4:45 PM, Joe Perches wrote: Joe Perches (25): arm: Use bool function return values of true/false not 1/0 [etc...] Why, and why these in particular? bool functions are probably better returning bool values instead of

[PATCH] crypto: omap-aes: Fix support for unequal lengths

2015-03-30 Thread Lokesh Vutla
For cases where total length of an input SGs is not same as length of the input data for encryption, omap-aes driver crashes. This happens in the case when IPsec is trying to use omap-aes driver. To avoid this, we copy all the pages from the input SG list into a contiguous buffer and prepare a

[PATCH] crypto: omap-sham: Check for HIGHMEM before mapping SG pages

2015-03-30 Thread Lokesh Vutla
Commit 26a05489ee0e (crypto: omap-sham - Map SG pages if they are HIGHMEM before accessing) says that HIGHMEM pages may not be mapped so we must kmap them before accessing, but it doesn't check whether the corresponding page is in highmem or not. Because of this all the crypto tests are failing.

[PATCH] crypto: omap-sham: Use pm_runtime_irq_safe()

2015-03-30 Thread Lokesh Vutla
omap_sham_handle_queue() can be called as part of done_task tasklet. During this its atomic and any calls to pm functions cannot sleep. But there is a call to pm_runtime_get_sync() (which can sleep) in omap_sham_handle_queue(), because of which the following appears: [ 116.169969] BUG: