Re: [PATCH 2/2] rtc: omap: Add external clock enabling support

2015-08-14 Thread Alexandre Belloni
On 13/08/2015 at 12:37:48 +0530, Keerthy wrote : Configure the clock source to either internal clock or external clock based on the availability of the clocks. External clock is preferred as it can be ticking during suspend. Signed-off-by: Keerthy j-keer...@ti.com ---

Re: [PATCH v2 2/6] rtc: omap: Add external clock enabling support

2015-08-14 Thread Alexandre Belloni
On 13/08/2015 at 20:17:23 +, Paul Walmsley wrote : I'd say that I don't really care. I'd say the best would be to make a decision based on clock-accuracy but maybe that is an information you don't have yet. Anyway, this could be added at a later date. Either the clock mux logic is

Re: [PATCH 2/2] rtc: omap: Add external clock enabling support

2015-08-14 Thread Vaibhav Hiremath
On Friday 14 August 2015 02:03 PM, Alexandre Belloni wrote: On 13/08/2015 at 12:37:48 +0530, Keerthy wrote : Configure the clock source to either internal clock or external clock based on the availability of the clocks. External clock is preferred as it can be ticking during suspend.

Re: [PATCH] gpiolib: irqchip: use different lockdep class for each gpio irqchip

2015-08-14 Thread Roger Quadros
On 13/08/15 17:58, Grygorii Strashko wrote: Since IRQ chip helpers were introduced drivers lose ability to register separate lockdep classes for each registered GPIO IRQ chip and the gpiolib now is using shared lockdep class for all GPIO IRQ chips (gpiochip_irq_lock_class). As result, lockdep

[PATCH RFC v3 7/7] ARM: dts: am335x-boneblack: Add HDMI audio support

2015-08-14 Thread Jyri Sarha
Add HDMI audio support. Adds mcasp0_pins, clk_mcasp0_fixed, clk_mcasp0, mcasp0, sound node, and updates the tda19988 node to follow the new binding. Signed-off-by: Jyri Sarha jsa...@ti.com --- arch/arm/boot/dts/am335x-boneblack.dts | 90 -- 1 file changed, 86

[PATCH RFC v3 4/7] drm/i2c: tda998x: Add support of a DT graph of ports

2015-08-14 Thread Jyri Sarha
From: Jean-Francois Moine moin...@free.fr Two kinds of ports may be declared in a DT graph of ports: video and audio. This patch accepts the port value from a video port as an alternative to the video-ports property. It also accepts audio ports in the case the transmitter is not used as a slave

[PATCH RFC v3 0/7] Implement generic ASoC HDMI codec and use it in tda998x

2015-08-14 Thread Jyri Sarha
This is my third RFC patch series on the subject. This time also the tda998x driver patches are a serious attempt to come up with an initial implementation for HDMI audio ASoC support. Russell's drm/edid: add function to help find SADs is here just to produce a working patch-set on top of

[PATCH RFC v3 6/7] drm/i2c: tda998x: Register ASoC HDMI codec for audio functionality

2015-08-14 Thread Jyri Sarha
Register ASoC HDMI codec for audio functionality. This is an initial ASoC audio implementation for tda998x driver and it does not use all the features provided by hdmi-codec. HDMI audio info-frame and audio stream header is generated by the ASoC HDMI codec. The codec also applies constraints for

[PATCH RFC v3 5/7] drm/i2c: tda998x: Remove include/sound/tda998x.h and fix graph parsing

2015-08-14 Thread Jyri Sarha
Move struct tda998x_audio definition to tda998x_drv.c and remove include/sound/tda998x.h. There is no external use for struct tda998x_audio. Fix graph parsing to allow ports to be inside a separate ports-node as specified in Documentation/devicetree/bindings/graph.txt. Signed-off-by: Jyri Sarha

[PATCH RFC v3 2/7] ASoC: hdmi: Remove obsolete dummy HDMI codec

2015-08-14 Thread Jyri Sarha
The hdmi stub codec has not been used since refactoring of OMAP HDMI audio support. Signed-off-by: Jyri Sarha jsa...@ti.com --- sound/soc/codecs/Kconfig | 4 -- sound/soc/codecs/Makefile | 2 - sound/soc/codecs/hdmi.c | 109 -- 3 files changed,

[RFT PATCH] arm: omap1_defconfig: convert to use libata PATA drivers

2015-08-14 Thread Bartlomiej Zolnierkiewicz
IDE subsystem has been deprecated since 2009 and the majority (if not all) of Linux distributions have switched to use libata for ATA support exclusively. However there are still some users (mostly old or/and embedded non-x86 systems) that have not converted from using IDE subsystem to libata

Re: Nokia N900 - audio TPA6130A2 problems

2015-08-14 Thread Pavel Machek
Hi! Maybe some power management problem? Something is not always initialized correctly? I remember that there is some problem (maybe in NoLo - Nokia bootloader) that sometimes chainloaded U-Boot (booted via NoLo) is not able to initialize mmc chip (all read operation fails). In U-Boot I

Re: Nokia N900 - audio TPA6130A2 problems

2015-08-14 Thread Pali Rohár
On Friday 14 August 2015 22:46:49 Pavel Machek wrote: Hi! Maybe some power management problem? Something is not always initialized correctly? I remember that there is some problem (maybe in NoLo - Nokia bootloader) that sometimes chainloaded U-Boot (booted via NoLo) is not able to

Re: [PATCH RFC v2 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-08-14 Thread Mark Brown
On Tue, May 26, 2015 at 09:59:07PM +0300, Jyri Sarha wrote: + + mutex_lock(hcp-current_stream_lock); + if (hcp-current_stream hcp-current_stream-runtime + snd_pcm_running(hcp-current_stream)) { + dev_info(dev, HDMI audio playback aborted\n); Does this really

Re: [PATCH RFC v3 2/7] ASoC: hdmi: Remove obsolete dummy HDMI codec

2015-08-14 Thread Mark Brown
On Fri, Aug 14, 2015 at 12:30:40PM +0300, Jyri Sarha wrote: The hdmi stub codec has not been used since refactoring of OMAP HDMI audio support. grep tells me that the OMAP HDMI4 and HDMI5 drivers are still registering this device in -next... signature.asc Description: Digital signature

Re: [PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-08-14 Thread Mark Brown
On Fri, Aug 14, 2015 at 12:30:41PM +0300, Jyri Sarha wrote: +struct hdmi_codec_ops { + /* For runtime clock configuration from ASoC machine driver. + * A direct forward from set_sysclk in struct snd_soc_dai_ops. + * Optional */ + int (*set_clk)(struct device *dev, int

Re: [PATCH 1/2] regulator: pbias: use untranslated address to program pbias regulator

2015-08-14 Thread Mark Brown
On Mon, Jul 27, 2015 at 04:54:09PM +0530, Kishon Vijay Abraham I wrote: vsel_reg and enable_reg of the pbias regulator descriptor should actually have the offset from syscon. However after the pbias device tree node I'm having a hard time understanding this statement, sorry. What makes you

[PATCH v2] tty: serial: 8250_omap: do not use RX DMA if pause is not supported

2015-08-14 Thread Sebastian Andrzej Siewior
The 8250-omap driver requires the DMA-engine driver to support the pause command in order to properly turn off programmed RX transfer before the driver stars manually reading from the FIFO. The lacking support of the requirement has been discovered recently. In order to stay safe here we disable

[PATCH 2/3] serial: 8250_omap: check how many bytes were injected

2015-08-14 Thread Sebastian Andrzej Siewior
The function tty_insert_flip_string() returns an int and as such it might fail. So the result is that I kindly asked to insert 48 bytes and the function only insterted 32. I have no idea what to do with the remaining 16 so I think dropping them is the only option. I also increase the buf_overrun

[PATCH 1/3] serial: 8250: move rx_running out of the bitfield

2015-08-14 Thread Sebastian Andrzej Siewior
From: John Ogness john.ogn...@linutronix.de That bitfield is modified by read + or + write operation. If someone sets any of the other two bits it might render the lock useless. While at it, remove other bitfields as well to avoid more such errors. Cc: Greg Kroah-Hartman

[RFC 3/3] serial: 8250_omap: try to avoid IER_RDI with DMA

2015-08-14 Thread Sebastian Andrzej Siewior
It has been observed on DRA7-evm that the UART triggers the interrupt and reading IIR says IIR_NO_INT. It seems that we receive data via RX-DMA but the interrupt is triggered anyway. I have hardly observed it on AM335x and not in *that* quantity. On DRA7-evm with continuous transfers at 3MBaud and

Re: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE

2015-08-14 Thread Marc Zyngier
On 14/08/15 11:18, Grygorii Strashko wrote: On 08/13/2015 03:58 PM, Grygorii Strashko wrote: On 08/13/2015 01:31 PM, Grygorii Strashko wrote: On 08/13/2015 01:01 PM, Marc Zyngier wrote: On 12/08/15 18:45, Grygorii Strashko wrote: The irqchip_set_wake_parent should not fail if IRQ chip

Re: [PATCH 2/2] rtc: omap: Add external clock enabling support

2015-08-14 Thread Johan Hovold
On Thu, Aug 13, 2015 at 12:37:48PM +0530, Keerthy wrote: Configure the clock source to either internal clock or external clock based on the availability of the clocks. External clock is preferred as it can be ticking during suspend. Signed-off-by: Keerthy j-keer...@ti.com @@ -627,6 +642,17

[PATCH v3 2/6] genirq: introduce irq_chip_set_type_parent() helper

2015-08-14 Thread Grygorii Strashko
It's expected to use this helper when the current domain doesn't implement .irq_set_type(), but expect the parent to do so. Cc: Sudeep Holla sudeep.ho...@arm.com Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com --- include/linux/irq.h | 1 + kernel/irq/chip.c | 17 +

[PATCH v3 3/6] irqchip: crossbar: fix arm gic irq type configuration

2015-08-14 Thread Grygorii Strashko
It's observed that ARM GIC IRQ triggering type is not configured properly when IRQ is routed through IRQ domain hierarchy and system started using DT. As result, system will start using default ARM GIC configuration, ignore DT IRQ triggering configuration, and value of

[PATCH v3 0/6] genirq: irqdomain_hierarchy: fixes

2015-08-14 Thread Grygorii Strashko
Hi All, I've had able to identify and reproduce four issues related to switching on using IRQ domain hierarchy on TI OMAP DRA7 (dra7-evm). Most of them were discovered during testing of Suspend to RAM and IRQ wakeup functionality. In my opinion, most of these issue could also affect on other ARM

Re: [PATCH] gpiolib: irqchip: use different lockdep class for each gpio irqchip

2015-08-14 Thread Linus Walleij
On Thu, Aug 13, 2015 at 4:58 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: Since IRQ chip helpers were introduced drivers lose ability to register separate lockdep classes for each registered GPIO IRQ chip and the gpiolib now is using shared lockdep class for all GPIO IRQ chips

Re: [PATCH] gpiolib: irqchip: use different lockdep class for each gpio irqchip

2015-08-14 Thread Lars-Peter Clausen
On 08/14/2015 02:34 PM, Linus Walleij wrote: [...] Every chip will get their own lock class on the heap. But I think it is a bit kludgy. Is it not possible to have the lock key in struct gpio_chip be a real member instead of a pointer and get a per-chip lock that way? (...) struct

[PATCH v3 4/6] ARM: OMAP: wakeupgen: fix arm gic irq type configuration

2015-08-14 Thread Grygorii Strashko
It's observed that ARM GIC IRQ triggering type is not configured properly when IRQ is routed through IRQ domain hierarchy and system started using DT. As result, system will start using default ARM GIC configuration, ignore DT IRQ triggering configuration, and value of

[PATCH v3 1/6] genirq: fix irq_chip_retrigger_hierarchy

2015-08-14 Thread Grygorii Strashko
Now irq_chip_retrigger_hierarchy() returns -ENOSYS if it was not able to find at least one .irq_retrigger() callback implemented in IRQ domain hierarchy. As result, IRQ re-triggering is not working now on ARM (TI OMAP) where ARM GIC is not implemented this callback. The .irq_retrigger() is

[PATCH v3 6/6] irqchip: crossbar: fix set_wake functionality

2015-08-14 Thread Grygorii Strashko
The TI crossbar doesn't provides any facility to configure the wakeup sources, but it implements .irq_set_wake() callback: .irq_set_wake = irq_chip_set_wake_parent As result, the irq_chip_set_wake_parent() will try to execute .irq_set_wake() callback for parent IRQ domain, which

[PATCH v3 5/6] irqchip: crossbar: fix irq masking at suspend

2015-08-14 Thread Grygorii Strashko
All ARM GIC IRQs have to masked during suspend if they are not wakeup source - this is expected behavior.Now this is not happen, since switching to use IRQ domain hierarchy, because suspend_device_irq() only checks flags in the last IRQ chip in hierarchy for IRQCHIP_MASK_ON_SUSPEND bit set. And in

[RFC 6/7] ARM: OMAP2+: PRCM: add support for registering prcm domains from DT

2015-08-14 Thread Tero Kristo
Power and clock domains can now be registered from DT based layout. Some data is retained in the kernel for initialization purposes. The platforms that require DT based domain support, shall have their DT and the clock/powerdomainxyz_data.c files updated. The template clock/powerdomain data

[RFC 7/7] ARM: OMAP4: PRCM: convert to DT based pwrdm/clkdm data

2015-08-14 Thread Tero Kristo
Clock and powerdomain data can now be moved partially to DT. Some init data is still left to the existing data files, to act as templates for the DT based data. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/clockdomains44xx_data.c | 327 +++

[RFC 2/7] ARM: OMAP4+: PRCM: add support for registering PRCM partition against DT node

2015-08-14 Thread Tero Kristo
The PRCM core code contains a notion of PRCM partition and instances, and all PRCM driver register accesses are done through the partitions. The APIs provided in this patch make it possible for PRCM child nodes to map their register spaces against proper PRCM partition, and access the correct

[RFC 3/7] ARM: OMAP4+: PRCM: parse PRCM MPU base address from DT

2015-08-14 Thread Tero Kristo
All the OMAP4+ boards are DT based only, so the prcm_mpu base address can be parsed from DT. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/io.c |4 arch/arm/mach-omap2/prm_common.c | 18 ++ 2 files changed, 18 insertions(+), 4 deletions(-)

[RFC 4/7] ARM: OMAP2+: PRCM: move PRCM data init later in boot sequence

2015-08-14 Thread Tero Kristo
This avoids the need to use memblock_virt_alloc in the code. Done in preparation of adding generic PM domains to OMAP platform codebase; generic PM domain registration doesn't work during early_init. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/io.c | 180

[RFC 1/7] ARM: dts: OMAP4+: add prcm_mpu node

2015-08-14 Thread Tero Kristo
PRCM has a local instance directly under the MPU domain, for controlling local MPU powerdomains and clockdomains. Add a DT node for this for omap4, omap5 and dra7. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/boot/dts/dra7.dtsi |8 arch/arm/boot/dts/omap4.dtsi |8

[RFC 0/7] ARM: OMAP2+: support for DT based pwrdm/clkdm data

2015-08-14 Thread Tero Kristo
Hi, This series provides DT based support for clock/powerdomain data. Some parts of the data is retained under the existing *_data.c files to act as templates. Also, minimal support for generic power domains is added, but without power_off / power_on support at this point (should be relatively

[RFC 5/7] ARM: dts: omap4: add clockdomain / powerdomain data

2015-08-14 Thread Tero Kristo
Clockdomain / powerdomain nodes with corresponding register addresses and PRCM hierarchy is added to the DT. This data can be parsed to create the clock/powerdomain data required by the kernel. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/boot/dts/omap4.dtsi | 32 +++-

[PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-08-14 Thread Jyri Sarha
The hdmi-codec is a platform device driver to be registered from drivers of external HDMI encoders with I2S and/or spdif interface. The driver in turn registers an ASoC codec for the HDMI encoder's audio functionality. The structures and definitions in the API header are mostly redundant copies

[PATCH RFC v3 1/7] drm/edid: add function to help find SADs, DO NOT MERGE

2015-08-14 Thread Jyri Sarha
From: Russell King - ARM Linux li...@arm.linux.org.uk Add a function to find the start of the SADs in the ELD. This complements the helper to retrieve the SAD count. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk This should already be coming in from drm-next. Signed-off-by: Jyri

Re: [PATCH v3 07/11] usb: otg: add OTG core

2015-08-14 Thread Roger Quadros
Hi Peter, On 13/07/15 13:20, Roger Quadros wrote: On 13/07/15 05:14, Peter Chen wrote: On Wed, Jul 08, 2015 at 01:19:33PM +0300, Roger Quadros wrote: The OTG core instantiates the OTG Finite State Machine per OTG controller and manages starting/stopping the host and gadget controllers based

Re: [PATCH RFC v3 3/7] ASoC: hdmi-codec: Add hdmi-codec for external HDMI-encoders

2015-08-14 Thread Russell King - ARM Linux
On Fri, Aug 14, 2015 at 12:30:41PM +0300, Jyri Sarha wrote: +static int hdmi_codec_hw_params(struct snd_pcm_substream *substream, + struct snd_pcm_hw_params *params, + struct snd_soc_dai *dai) +{ + struct hdmi_codec_priv *hcp =

Re: [PATCH RFC v3 6/7] drm/i2c: tda998x: Register ASoC HDMI codec for audio functionality

2015-08-14 Thread Russell King - ARM Linux
On Fri, Aug 14, 2015 at 12:30:44PM +0300, Jyri Sarha wrote: +static int tda998x_write_aif(struct tda998x_priv *priv, + struct hdmi_audio_infoframe *cea) +{ + uint8_t buf[HDMI_INFOFRAME_SIZE(AUDIO)]; + int len; + + len = hdmi_audio_infoframe_pack(cea,

Re: [PATCH v3 07/11] usb: otg: add OTG core

2015-08-14 Thread Peter Chen
On Fri, Aug 14, 2015 at 12:42:38PM +0300, Roger Quadros wrote: Hi Peter, On 13/07/15 13:20, Roger Quadros wrote: On 13/07/15 05:14, Peter Chen wrote: On Wed, Jul 08, 2015 at 01:19:33PM +0300, Roger Quadros wrote: The OTG core instantiates the OTG Finite State Machine per OTG controller

Re: [PATCH v2 2/6] genirq: fix irqchip_set_wake_parent if IRQCHIP_SKIP_SET_WAKE

2015-08-14 Thread Grygorii Strashko
On 08/13/2015 03:58 PM, Grygorii Strashko wrote: On 08/13/2015 01:31 PM, Grygorii Strashko wrote: On 08/13/2015 01:01 PM, Marc Zyngier wrote: On 12/08/15 18:45, Grygorii Strashko wrote: The irqchip_set_wake_parent should not fail if IRQ chip specifies IRQCHIP_SKIP_SET_WAKE. Otherwise, IRQ

Re: [PATCH] gpiolib: irqchip: use different lockdep class for each gpio irqchip

2015-08-14 Thread Grygorii Strashko
On 08/14/2015 03:40 PM, Lars-Peter Clausen wrote: On 08/14/2015 02:34 PM, Linus Walleij wrote: [...] Every chip will get their own lock class on the heap. But I think it is a bit kludgy. Is it not possible to have the lock key in struct gpio_chip be a real member instead of a pointer and