[PATCH] ARM: omap: Enable low-level omap3 PM code to work with CONFIG_THUMB2_KERNEL

2010-11-30 Thread Dave Martin
on Beagle xM A2: * CONFIG_THUMB2_KERNEL !CONFIG_SMP_ON_UP * CONFIG_THUMB2_KERNEL CONFIG_SMP_ON_UP * !CONFIG_THUMB2_KERNEL !CONFIG_SMP_ON_UP * !CONFIG_THUMB2_KERNEL CONFIG_SMP_ON_UP Signed-off-by: Dave Martin dave.mar...@linaro.org --- KernelVersion: 2.6.37-rc4 arch/arm/mach-omap2/pm.h

[PATCH v2 0/3] ARM: omap: Thumb-2 kernel compatibility fixes

2010-12-06 Thread Dave Martin
other platforms yet. Dave Martin (3): ARM: omap: Enable low-level omap3 PM code to work with CONFIG_THUMB2_KERNEL ARM: omap4: Correct definition of do_wfi() for CONFIG_THUMB2_KERNEL ARM: omap4: Convert END() to ENDPROC() for correct linkage with CONFIG_THUMB2_KERNEL arch/arm/mach

[PATCH v2 3/3] ARM: omap4: Convert END() to ENDPROC() for correct linkage with CONFIG_THUMB2_KERNEL

2010-12-06 Thread Dave Martin
on the compatibility status of bootloaders. Signed-off-by: Dave Martin dave.mar...@linaro.org --- KernelVersion: 2.6.37-rc4 arch/arm/mach-omap2/omap-headsmp.S |2 +- arch/arm/mach-omap2/omap44xx-smc.S |8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() for CONFIG_THUMB2_KERNEL

2010-12-06 Thread Dave Martin
For the Thumb-2 case, the wfi mnemonic is used, since in this case the tools will necessarily be new enough to support it. Signed-off-by: Dave Martin dave.mar...@linaro.org --- KernelVersion: 2.6.37-rc4 arch/arm/mach-omap2/include/mach/omap4-common.h |5 + 1 files changed, 5 insertions

[PATCH v2 1/3] ARM: omap: Enable low-level omap3 PM code to work with CONFIG_THUMB2_KERNEL

2010-12-06 Thread Dave Martin
on Beagle xM A2: * CONFIG_THUMB2_KERNEL !CONFIG_SMP_ON_UP * CONFIG_THUMB2_KERNEL CONFIG_SMP_ON_UP * !CONFIG_THUMB2_KERNEL !CONFIG_SMP_ON_UP * !CONFIG_THUMB2_KERNEL CONFIG_SMP_ON_UP Signed-off-by: Dave Martin dave.mar...@linaro.org --- KernelVersion: 2.6.37-rc4 arch/arm/mach-omap2/pm.h

Re: [PATCH v2 1/3] ARM: omap: Enable low-level omap3 PM code to work with CONFIG_THUMB2_KERNEL

2010-12-06 Thread Dave Martin
Hi, On Mon, Dec 6, 2010 at 6:17 PM, Catalin Marinas catalin.mari...@arm.com wrote: On 6 December 2010 17:35, Dave Martin dave.mar...@linaro.org wrote:  * Explicitly build a few parts of sleep34xx.S as ARM.      * lock_scratchpad_sem is kept as ARM because of the need to        synchronise

Re: [PATCH v2 1/3] ARM: omap: Enable low-level omap3 PM code to work withCONFIG_THUMB2_KERNEL

2010-12-07 Thread Dave Martin
On Tue, Dec 7, 2010 at 6:31 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: Dave, -Original Message- From: linaro-dev-boun...@lists.linaro.org [mailto:linaro-dev- boun...@lists.linaro.org] On Behalf Of Dave Martin Sent: Monday, December 06, 2010 11:06 PM To: linux-arm-ker

Re: [PATCH v2 1/3] ARM: omap: Enable low-level omap3 PM code to work withCONFIG_THUMB2_KERNEL

2010-12-07 Thread Dave Martin
Hi, On Tue, Dec 7, 2010 at 11:59 AM, Jean Pihet jean.pi...@newoldbits.com wrote: Hi Dave, On Tue, Dec 7, 2010 at 11:16 AM, Dave Martin dave.mar...@linaro.org wrote: On Tue, Dec 7, 2010 at 6:31 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: Dave, -Original Message- From

Re: [PATCH v2 1/3] ARM: omap: Enable low-level omap3 PM code to work withCONFIG_THUMB2_KERNEL

2010-12-07 Thread Dave Martin
On Tue, Dec 7, 2010 at 2:53 PM, Dave Martin dave.mar...@linaro.org wrote: [...] Note that converting to C doesn't mean that code which attempts to copy function bodies will work: you still need to handle the fact that if f() is a C function symbol, then the value of the symbol f is actually

Re: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() forCONFIG_THUMB2_KERNEL

2010-12-07 Thread Dave Martin
Hi, On Tue, Dec 7, 2010 at 6:28 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: Dave, -Original Message- From: linaro-dev-boun...@lists.linaro.org [mailto:linaro-dev- boun...@lists.linaro.org] On Behalf Of Dave Martin Sent: Monday, December 06, 2010 11:06 PM To: linux-arm-ker

[PATCH] ARM: Thumb-2: Make CONFIG_THUMB2_KERNEL depend on !CPU_V6

2010-12-07 Thread Dave Martin
trying to put v5 and v7 in the same kernel is low, and I'm not aware of any mach which can do this. These could be added later if it matters. Signed-off-by: Dave Martin dave.mar...@linaro.org --- KernelVersion: 2.6.37-rc4 diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index f1d9297..bf1f8db 100644

Re: [PATCH v2 1/3] ARM: omap: Enable low-level omap3 PM code to work withCONFIG_THUMB2_KERNEL

2010-12-08 Thread Dave Martin
Hi, On Tue, Dec 7, 2010 at 7:15 PM, Nicolas Pitre nicolas.pi...@linaro.org wrote: On Tue, 7 Dec 2010, Dave Martin wrote: On Tue, Dec 7, 2010 at 2:53 PM, Dave Martin dave.mar...@linaro.org wrote: [...] Note that converting to C doesn't mean that code which attempts to copy function bodies

Re: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() forCONFIG_THUMB2_KERNEL

2010-12-08 Thread Dave Martin
On Wed, Dec 8, 2010 at 5:59 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: Dave, -Original Message- From: Santosh Shilimkar [mailto:santosh.shilim...@ti.com] Sent: Wednesday, December 08, 2010 11:27 AM To: Dave Martin Cc: linux-arm-ker...@lists.infradead.org; Tony Lindgren

Re: [PATCH] ARM: Thumb-2: Make CONFIG_THUMB2_KERNEL depend on !CPU_V6

2010-12-08 Thread Dave Martin
On Wed, Dec 8, 2010 at 7:43 AM, David Brownell davi...@pacbell.net wrote: --- On Tue, 12/7/10, Dave Martin dave.mar...@linaro.org wrote: From: Dave Martin dave.mar...@linaro.org Subject: [PATCH] ARM: Thumb-2: Make CONFIG_THUMB2_KERNEL depend on !CPU_V6... This makes sense, because Thumb-2

Re: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() forCONFIG_THUMB2_KERNEL

2010-12-08 Thread Dave Martin
On Wed, Dec 8, 2010 at 10:45 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: -Original Message- From: Dave Martin [mailto:dave.mar...@linaro.org] Sent: Wednesday, December 08, 2010 4:11 PM To: Santosh Shilimkar Cc: linux-arm-ker...@lists.infradead.org; Tony Lindgren; linux- o

Re: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() forCONFIG_THUMB2_KERNEL

2010-12-08 Thread Dave Martin
On Wed, Dec 8, 2010 at 11:10 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: -Original Message- From: Dave Martin [mailto:dave.mar...@linaro.org] Sent: Wednesday, December 08, 2010 4:35 PM To: Santosh Shilimkar Cc: Tony Lindgren; linux-omap@vger.kernel.org; linaro- d

Re: [PATCH v2 2/3] ARM: omap4: Correct definition of do_wfi() forCONFIG_THUMB2_KERNEL

2010-12-08 Thread Dave Martin
On Tue, Dec 7, 2010 at 7:29 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Dec 07, 2010 at 04:50:50PM +, Dave Martin wrote: I'll follow up shortly with a patch to the generic ARM Kconfig to make this explicit, so that ARCH_OMAP2 and THUMB2_KERNEL can't accidentally

Re: [PATCH] ARM: Thumb-2: Make CONFIG_THUMB2_KERNEL depend on !CPU_V6

2010-12-08 Thread Dave Martin
Hi, On Wed, Dec 8, 2010 at 4:38 PM, David Brownell davi...@pacbell.net wrote: So to recapitulate ... you're agreeing with me on my key point -- that ARM1156, a V6T2 core with  Thumb2 support (used in fact to introduce Thumb2), should  work for some in-kernel Thumb2 usage, degree TBD, but

[PATCH 0/2] ARM: Thumb-2: Fix Kconfig rules to avoid nonworking configs

2010-12-09 Thread Dave Martin
Some configurations don't make sense with Thumb-2, or don't currently work and are unlikely to be relevant. The patches avoid Kconfig from allowing these problematic combinations, for now. Dave Martin (2): ARM: Thumb-2: Make CONFIG_THUMB2_KERNEL depend on !CPU_V6 ARM: Make CONFIG_FPE_NWFPE

[PATCH 1/2] ARM: Thumb-2: Make CONFIG_THUMB2_KERNEL depend on !CPU_V6

2010-12-09 Thread Dave Martin
ARMv6T2 extensions, which add support for Thumb-2 and a few other ARMv7 features. Signed-off-by: Dave Martin dave.mar...@linaro.org Acked-by: Catalin Marinas catalin.mari...@arm.com --- arch/arm/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/Kconfig b/arch

[PATCH 2/2] ARM: Make CONFIG_FPE_NWFPE depend on !CONFIG_THUMB2_KERNEL

2010-12-09 Thread Dave Martin
it doesn't appear useful to port this code. All ARMv7-A/R platforms necessarily have VFPv3 hardware floating- point natively, making emulation unnecessary. Signed-off-by: Dave Martin dave.mar...@linaro.org Acked-by: Catalin Marinas catalin.mari...@arm.com --- arch/arm/Kconfig |2 +- 1 files changed

[PATCH 0/0] RFC: ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-11 Thread Dave Martin
the requirement for function body copying is in the arch/arm/ tree, however. Signed-off-by: Dave Martin dave.mar...@linaro.org --- KernelVersion: next-20110111 arch/arm/include/asm/unified.h | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/arch/arm/include/asm

[PATCH 1/1] ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-11 Thread Dave Martin
observed to lead to strange optimisation side-effects when doing the arithmetic which is required in order to copy/move function bodies correctly in Thumb-2. Signed-off-by: Dave Martin dave.mar...@linaro.org --- KernelVersion: next-20110111 arch/arm/include/asm/unified.h | 26

Re: [PATCH 0/0] RFC: ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-12 Thread Dave Martin
Hi, On Wed, Jan 12, 2011 at 3:32 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Jan 11, 2011 at 06:02:30PM -0600, Dave Martin wrote: To make it easier to deal with cases like this, I've had a go at writing some macros to make copying function bodies easier, while being

Re: [PATCH 0/0] RFC: ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-12 Thread Dave Martin
On Wed, Jan 12, 2011 at 10:11 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Jan 12, 2011 at 10:00:25AM -0600, Dave Martin wrote: omap provides some infrastructure for both allocating SRAM space and doing the copy, using omap_sram_push() and friends.  So I wasn't sure what

[PATCH v2 0/1] ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-13 Thread Dave Martin
the size of a function from C code. This must be done by other means, such as adding extra symbols in the assembler code where scary_function is defined. Signed-off-by: Dave Martin dave.mar...@linaro.org --- KernelVersion: v2.6.37 arch/arm/include/asm/unified.h | 26 ++ 1

[PATCH 1/1 v2] ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-13 Thread Dave Martin
observed to lead to strange optimisation side-effects when doing the arithmetic which is required in order to copy/move function bodies correctly in Thumb-2. Thanks to Russell King for his input on this patch. Signed-off-by: Dave Martin dave.mar...@linaro.org --- KernelVersion: v2.6.37 arch/arm

[PATCH v3 0/1] ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-13 Thread Dave Martin
the size of a function from C code. This must be done by other means, such as adding extra symbols in the assembler code where scary_function is defined. Signed-off-by: Dave Martin dave.mar...@linaro.org --- KernelVersion: v2.6.37 Dave Martin (1): ARM: Thumb-2: Symbol manipulation macros

[PATCH v3 1/1] ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-13 Thread Dave Martin
observed to lead to strange optimisation side-effects when doing the arithmetic which is required in order to copy/move function bodies correctly in Thumb-2. Thanks to Russell King and Nicolas Pitre for their input. Signed-off-by: Dave Martin dave.mar...@linaro.org --- KernelVersion: v2.6.37 arch

Re: [PATCH 1/1 v2] ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-14 Thread Dave Martin
On Thu, Jan 13, 2011 at 5:55 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Jan 13, 2011 at 02:51:45PM -0600, Dave Martin wrote: +/* Cast function pointer to integer: */ +#define __funcp_to_uint(funcp) ({                            \ uint is confusing here - it suggests

Re: [PATCH 1/1 v2] ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-14 Thread Dave Martin
+ alignment - 1; } ...to guarantee the possibility of rounding the copied function address up far enough to achieve the required alignment without overrunning the buffer. Of course, we can probably get simpler that that... Any thoughts? Cheers ---Dave On Fri, Jan 14, 2011 at 9:42 AM, Dave Martin

Re: [PATCH 1/1 v2] ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-14 Thread Dave Martin
On Fri, Jan 14, 2011 at 11:43 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Jan 14, 2011 at 11:15:19AM -0600, Dave Martin wrote: There's another problem which I hadn't spotted before: In the Thumb case, we risk violating the alignment constraints of the code which gets

[PATCH v4] ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-14 Thread Dave Martin
. This has been observed to lead to strange optimisation side-effects when doing the arithmetic which is required in order to copy/move function bodies correctly in Thumb-2. Thanks to Russell King and Nicolas Pitre for their input on this patch. Signed-off-by: Dave Martin dave.mar...@linaro.org Tested

Re: [PATCH v4] ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-17 Thread Dave Martin
Hi, On Mon, Jan 17, 2011 at 2:02 PM, Jean Pihet jean.pi...@newoldbits.com wrote: [...] Note that aligning the source and destination pointers to a multiple of 8 bytes has an impact on the behavio(u)r and so must be carefully thought and tested on OMAP1/2/3 platforms. Do you have any

Re: [PATCH] OMAP: use fncpy to copy the PM code functions to SRAM

2011-01-17 Thread Dave Martin
On Mon, Jan 17, 2011 at 2:01 PM, Jean Pihet jean.pi...@newoldbits.com wrote: On Fri, Jan 14, 2011 at 6:34 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Jan 14, 2011 at 05:13:01PM +0100, Jean Pihet wrote: Is the name 'omap_sram_push' wrong then? What about the following?

Re: [PATCH v4] ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-20 Thread Dave Martin
On Wed, Jan 19, 2011 at 10:29 PM, Kevin Hilman khil...@ti.com wrote: Dave Martin dave.mar...@linaro.org writes: In low-level board support code, there is sometimes a need to copy a function body to another location at run-time. A straightforward call to memcpy doesn't work in Thumb-2

Re: [PATCH v4] ARM: Thumb-2: Symbol manipulation macros for function body copying

2011-01-24 Thread Dave Martin
On Thu, Jan 20, 2011 at 9:42 AM, Dave Martin dave.mar...@linaro.org wrote: On Wed, Jan 19, 2011 at 10:29 PM, Kevin Hilman khil...@ti.com wrote: Dave Martin dave.mar...@linaro.org writes: In low-level board support code, there is sometimes a need to copy a function body to another location

Re: [PATCH v2] OMAP: use fncpy to copy the PM code functions to SRAM

2011-01-25 Thread Dave Martin
On Mon, Jan 24, 2011 at 5:25 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Hi, On Mon, Jan 24, 2011 at 5:11 PM, Dave Martin dave.mar...@linaro.org wrote: Hi there, I just spotted a couple of things merging your patch... On Tue, Jan 18, 2011 at 12:02 PM,  jean.pi...@newoldbits.com wrote

Re: [PATCH 03/14] ARM: v6k: remove CPU_32v6K dependencies in asm/spinlock.h

2011-01-25 Thread Dave Martin
Hi there, On Mon, Jan 17, 2011 at 7:22 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: SMP requires at least the ARMv6K extensions to be present, so if we're running on SMP, the WFE and SEV instructions must be available. However, when we run on UP, the v6K extensions may not be

Re: [PATCH] OMAP: fix fncpy API call

2011-01-25 Thread Dave Martin
On Tue, Jan 25, 2011 at 5:21 PM, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Fix a potential problem with function types when calling the fncpy API to copy the PM code functions to SRAM. Tested on OMAP3 in low power modes (RET/OFF) using omap2plus_defconfig with

Re: [PATCH 03/14] ARM: v6k: remove CPU_32v6K dependencies in asm/spinlock.h

2011-01-25 Thread Dave Martin
On Tue, Jan 25, 2011 at 4:59 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Jan 25, 2011 at 04:43:52PM +, Dave Martin wrote: A couple of questions on this: 1) I notice these spinlock functions are generally marked inline. Is that likely to happen in modules?  If so

Re: [PATCH 03/14] ARM: v6k: remove CPU_32v6K dependencies in asm/spinlock.h

2011-01-26 Thread Dave Martin
On Tue, Jan 25, 2011 at 9:21 PM, Nicolas Pitre nicolas.pi...@linaro.org wrote: On Tue, 25 Jan 2011, Russell King - ARM Linux wrote: On Tue, Jan 25, 2011 at 05:33:14PM +, Dave Martin wrote: On Tue, Jan 25, 2011 at 4:59 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue

Re: [PATCH 03/14] ARM: v6k: remove CPU_32v6K dependencies in asm/spinlock.h

2011-01-26 Thread Dave Martin
On Wed, Jan 26, 2011 at 3:52 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Jan 26, 2011 at 10:42:41AM -0500, Nicolas Pitre wrote: On Wed, 26 Jan 2011, Dave Martin wrote: Alternatively, I wonder .alt.smp.init could make weak references instead of normal references

[PATCH v2] ARM: Avoid discarding sections that might have SMP_ON_UP fixups SMP_ON_UP fixups

2011-01-27 Thread Dave Martin
and probably wrong! Signed-off-by: Dave Martin dave.mar...@linaro.org --- arch/arm/kernel/vmlinux.lds.S | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/arch/arm/kernel/vmlinux.lds.S b/arch/arm/kernel/vmlinux.lds.S index 45b5651..5774b95 100644 --- a/arch/arm/kernel

Re: [PATCH v2] OMAP: fix fncpy API call

2011-02-01 Thread Dave Martin
);    \        _res;                                                   \  }) I believe this is sound, though I'm not yet in a position to test it fully. When I have the OMAP kernel building with Thumb-2 again I will follow up. Cheers ---Dave Reviewed-by: Dave Martin dave.mar...@linaro.org

[PATCH v2 0/5] ARM: omap[34]: Thumb-2 compatibility fixes

2011-02-03 Thread Dave Martin
://ftp.arm.linux.org.uk/pub/linux/arm/kernel/git-cur/linux-2.6-arm.git devel git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git omap-testing Dave Martin (5): ARM: omap4: Correct definition of do_wfi() for CONFIG_THUMB2_KERNEL ARM: omap4: Convert END() to ENDPROC() for correct linkage

[PATCH v2 1/5] ARM: omap4: Correct definition of do_wfi() for CONFIG_THUMB2_KERNEL

2011-02-03 Thread Dave Martin
For the Thumb-2 case, the wfi mnemonic is used, since in this case the tools will necessarily be new enough to support it. Signed-off-by: Dave Martin dave.mar...@linaro.org --- arch/arm/mach-omap2/include/mach/omap4-common.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff

[PATCH v2 2/5] ARM: omap4: Convert END() to ENDPROC() for correct linkage with CONFIG_THUMB2_KERNEL

2011-02-03 Thread Dave Martin
instruction set. Signed-off-by: Dave Martin dave.mar...@linaro.org Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/omap-headsmp.S |2 +- arch/arm/mach-omap2/omap44xx-smc.S |8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach

[PATCH v2 4/5] ARM: omap3: Thumb-2 compatibility for sram34xx.S

2011-02-03 Thread Dave Martin
* Remove deprecated/undefined PC-relative stores * Add the required ENDPROC() directive for each ENTRY(). * .align before data words Signed-off-by: Dave Martin dave.mar...@linaro.org --- arch/arm/mach-omap2/sram34xx.S | 28 1 files changed, 20 insertions(+), 8

[PATCH v2 5/5] ARM: omap3: Thumb-2 compatibility for sleep34xx.S

2011-02-03 Thread Dave Martin
(). * .align before data words Signed-off-by: Dave Martin dave.mar...@linaro.org --- arch/arm/mach-omap2/sleep34xx.S | 42 +- 1 files changed, 32 insertions(+), 10 deletions(-) diff --git a/arch/arm/mach-omap2/sleep34xx.S b/arch/arm/mach-omap2/sleep34xx.S index

[PATCH v2 3/5] ARM: omap3: Remove hand-encoded SMC instructions

2011-02-03 Thread Dave Martin
of the code). The Makefile already ensures that this file is built with a high enough gcc -march= flag (armv7-a). Signed-off-by: Dave Martin dave.mar...@linaro.org --- arch/arm/mach-omap2/sleep34xx.S | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-omap2

Re: [PATCH v2 1/5] ARM: omap4: Correct definition of do_wfi() forCONFIG_THUMB2_KERNEL

2011-02-04 Thread Dave Martin
On Thu, Feb 3, 2011 at 7:30 PM, Santosh Shilimkar santosh.shilim...@ti.com wrote: -Original Message- From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] Sent: Friday, February 04, 2011 12:38 AM To: Santosh Shilimkar Cc: Dave Martin; linux-arm-ker...@lists.infradead.org

Re: [PATCH v2 0/5] ARM: omap[34]: Thumb-2 compatibility fixes

2011-02-04 Thread Dave Martin
On Fri, Feb 4, 2011 at 10:45 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: Dave, -Original Message- From: Dave Martin [mailto:dave.mar...@linaro.org] Sent: Thursday, February 03, 2011 11:33 PM To: linux-arm-ker...@lists.infradead.org Cc: Dave Martin; Tony Lindgren; Santosh

Re: [PATCH v2 0/5] ARM: omap[34]: Thumb-2 compatibility fixes

2011-02-04 Thread Dave Martin
On Fri, Feb 4, 2011 at 11:16 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: -Original Message- From: Dave Martin [mailto:dave.mar...@linaro.org] Sent: Friday, February 04, 2011 4:33 PM To: Santosh Shilimkar Cc: linux-arm-ker...@lists.infradead.org; Tony Lindgren; Jean Pihet

Re: [PATCH 2/2] ARM: Make CONFIG_FPE_NWFPE depend on !CONFIG_THUMB2_KERNEL

2011-02-04 Thread Dave Martin
On Fri, Feb 4, 2011 at 11:03 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Dec 09, 2010 at 11:59:42AM +, Dave Martin wrote: Because the nwfpe support is unlikely to be used on new platforms and requires CONFIG_OABI_COMPAT, which is not generally used with ARMv7+, we

[PATCH] ARM: Define wfi(), wfe(), sev() macros for pre-v7 processors

2011-02-04 Thread Dave Martin
, some CPU- specific wfi() will have to be defined elsewhere. Signed-off-by: Dave Martin dave.mar...@linaro.org --- arch/arm/include/asm/system.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/arch/arm/include/asm/system.h b/arch/arm/include/asm/system.h index 97f6d60

[PATCH v3 0/5] ARM: omap[34]: Thumb-2 compatibility fixes

2011-02-04 Thread Dave Martin
://git.linaro.org/people/dmart/linux-2.6-arm.git arm/wfi-macro Dave Martin (5): ARM: omap4: Replace custom do_wfi() with generic wfi() ARM: omap4: Convert END() to ENDPROC() for correct linkage with CONFIG_THUMB2_KERNEL ARM: omap3: Remove hand-encoded SMC instructions ARM: omap3: Thumb-2

[PATCH v3 1/5] ARM: omap4: Replace custom do_wfi() with generic wfi()

2011-02-04 Thread Dave Martin
Now that wfi() in asm/system.h is suitably generic, we can remove the omap-specific do_wfi() macro. Signed-off-by: Dave Martin dave.mar...@linaro.org --- arch/arm/mach-omap2/include/mach/omap4-common.h |7 --- arch/arm/mach-omap2/omap-hotplug.c |3 ++- arch/arm/mach

[PATCH v3 2/5] ARM: omap4: Convert END() to ENDPROC() for correct linkage with CONFIG_THUMB2_KERNEL

2011-02-04 Thread Dave Martin
instruction set. Signed-off-by: Dave Martin dave.mar...@linaro.org Tested-by: Santosh Shilimkar santosh.shilim...@ti.com Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/omap-headsmp.S |2 +- arch/arm/mach-omap2/omap44xx-smc.S |8 2 files changed, 5

[PATCH v3 4/5] ARM: omap3: Thumb-2 compatibility for sram34xx.S

2011-02-04 Thread Dave Martin
* Remove deprecated/undefined PC-relative stores * Add the required ENDPROC() directive for each ENTRY(). * .align before data words Signed-off-by: Dave Martin dave.mar...@linaro.org Tested-by: Santosh Shilimkar santosh.shilim...@ti.com Acked-by: Santosh Shilimkar santosh.shilim...@ti.com

[PATCH v3 5/5] ARM: omap3: Thumb-2 compatibility for sleep34xx.S

2011-02-04 Thread Dave Martin
(). * .align before data words Signed-off-by: Dave Martin dave.mar...@linaro.org Tested-by: Santosh Shilimkar santosh.shilim...@ti.com Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/sleep34xx.S | 42 +- 1 files changed, 32 insertions

[PATCH v3 3/5] ARM: omap3: Remove hand-encoded SMC instructions

2011-02-04 Thread Dave Martin
of the code). The Makefile already ensures that this file is built with a high enough gcc -march= flag (armv7-a). Signed-off-by: Dave Martin dave.mar...@linaro.org Tested-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/sleep34xx.S | 14 +++--- 1 files changed, 7

Re: [PATCH v3 3/5] ARM: omap3: Remove hand-encoded SMC instructions

2011-02-04 Thread Dave Martin
On Fri, Feb 04, 2011 at 08:28:53PM +0530, Santosh Shilimkar wrote: -Original Message- From: Dave Martin [mailto:dave.mar...@linaro.org] Sent: Friday, February 04, 2011 7:52 PM To: linux-arm-ker...@lists.infradead.org Cc: Dave Martin; Tony Lindgren; Santosh Shilimkar; Jean Pihet

[PATCH v3.1] ARM: omap3: Remove hand-encoded SMC instructions

2011-02-04 Thread Dave Martin
of the code). The Makefile already ensures that this file is built with a high enough gcc -march= flag (armv7-a). Signed-off-by: Dave Martin dave.mar...@linaro.org Tested-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/sleep34xx.S | 14 +++--- 1 files changed, 7

Re: [PATCH v2 0/5] ARM: omap[34]: Thumb-2 compatibility fixes

2011-02-04 Thread Dave Martin
On Fri, Feb 04, 2011 at 04:46:57PM +0530, Santosh Shilimkar wrote: -Original Message- From: Dave Martin [mailto:dave.mar...@linaro.org] Sent: Friday, February 04, 2011 4:33 PM To: Santosh Shilimkar Cc: linux-arm-ker...@lists.infradead.org; Tony Lindgren; Jean Pihet- XID; linux

[PATCH v2] ARM: Define wfi() macro for v6 processors

2011-02-08 Thread Dave Martin
For v6, wfi is architected as a defined MCR instruction, so use that definition. Doing a no-op instead of wfi() is probably bad, so for older processors than v6, wfi() is not defined. If needed, some CPU- specific wfi() will have to be defined elsewhere. Signed-off-by: Dave Martin dave.mar

Re: [PATCH v2] ARM: Define wfi() macro for v6 processors

2011-02-08 Thread Dave Martin
On Tue, Feb 08, 2011 at 11:08:08AM +, Russell King - ARM Linux wrote: On Tue, Feb 08, 2011 at 11:01:25AM +, Dave Martin wrote: For v6, wfi is architected as a defined MCR instruction, so use that definition. Doing a no-op instead of wfi() is probably bad, so for older

Re: [PATCH v2] ARM: Define wfi() macro for v6 processors

2011-02-08 Thread Dave Martin
On Tue, Feb 08, 2011 at 11:01:25AM +, Dave Martin wrote: For v6, wfi is architected as a defined MCR instruction, so use that definition. [...] On Tue, Feb 08, 2011 at 01:11:51PM +0100, Arnd Bergmann wrote: I don't see any users of the sev/wfe/wfi macros in the current kernel, so

Re: [PATCH v2] ARM: Define wfi() macro for v6 processors

2011-02-08 Thread Dave Martin
On Tue, Feb 8, 2011 at 12:53 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 08 February 2011, Russell King - ARM Linux wrote: I don't see any users of the sev/wfe/wfi macros in the current kernel, so removing them seems like a good strategy to avoid people from using them incorrectly.

Re: [PATCH v2] ARM: Define wfi() macro for v6 processors

2011-02-08 Thread Dave Martin
On Tue, Feb 8, 2011 at 2:54 PM, Santosh Shilimkar santosh.shilim...@ti.com wrote: Dave, -Original Message- From: Dave Martin [mailto:dave.mar...@linaro.org] [...] I don't like the practice of pre-assembling bits of code with .long, in order to allow a file to be built with wrong

Re: [PATCH v2] ARM: Define wfi() macro for v6 processors

2011-02-08 Thread Dave Martin
On Tue, Feb 8, 2011 at 3:15 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 08 February 2011, Dave Martin wrote: I guess there are two problems we're trying to solve here: 1) a lowest-common denominator implementation of things like wfi(), for use in common code.  This must be based

Re: [PATCH v2] ARM: Define wfi() macro for v6 processors

2011-02-08 Thread Dave Martin
On Tue, Feb 8, 2011 at 3:42 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 08 February 2011, Dave Martin wrote: Why not have macros for these cases?  (Which kinda brings the discussion full-circle...) My immediate concern is that too often, the Thumb-2 case will be handled incorrectly

Re: [PATCH v2] ARM: Define wfi() macro for v6 processors

2011-02-08 Thread Dave Martin
On Tue, Feb 8, 2011 at 4:20 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Feb 08, 2011 at 02:45:51PM +, Dave Martin wrote: If support for a v6K processor is included, we have no way to know from preprocessor definitions whether a plain v6 processor is also

Re: [PATCH v2] ARM: Define wfi() macro for v6 processors

2011-02-08 Thread Dave Martin
On Tue, Feb 8, 2011 at 4:25 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Feb 08, 2011 at 04:15:15PM +0100, Arnd Bergmann wrote: But that doesn't work if you build a combined v5/v6/v7 kernel, because v5 supports neither form, right? I think to do that, it needs the same

Re: [PATCH v2] ARM: Define wfi() macro for v6 processors

2011-02-08 Thread Dave Martin
On Tue, Feb 8, 2011 at 4:55 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Feb 08, 2011 at 05:47:18PM +0100, Arnd Bergmann wrote: On Tuesday 08 February 2011 17:25:16 Russell King - ARM Linux wrote: On Tue, Feb 08, 2011 at 04:15:15PM +0100, Arnd Bergmann wrote: But that

Re: [PATCH v2] ARM: Define wfi() macro for v6 processors

2011-02-08 Thread Dave Martin
On Tue, Feb 8, 2011 at 4:58 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 08 February 2011 17:32:29 Russell King - ARM Linux wrote: On Tue, Feb 08, 2011 at 04:17:58PM +0100, Arnd Bergmann wrote: On Tuesday 08 February 2011, Dave Martin wrote: CFLAGS_cpu_specific_object.o

Re: [PATCH v2 0/5] ARM: omap[34]: Thumb-2 compatibility fixes

2011-02-08 Thread Dave Martin
Hi Santosh, [...] Which tree did you use to test this?  It didn't seem to work for me -- sometimes the system wouldn't suspend, complaining about USB suspend errors; and other times I couldn't bring it out of suspend (by poking a USB input device). I might be doing something wrong... I

Re: [PATCH 00/14] Fix issues with ARMv6+v6k+v7 kernels

2011-02-09 Thread Dave Martin
On Wed, Feb 9, 2011 at 6:04 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Tony Lindgren Sent: Wednesday, February 09, 2011 6:06 AM To: Nicolas Pitre Cc: Santosh

Re: [PATCH v2 0/5] ARM: omap[34]: Thumb-2 compatibility fixes

2011-02-09 Thread Dave Martin
On Wed, Feb 9, 2011 at 5:45 AM, Santosh Shilimkar santosh.shilim...@ti.com wrote: -Original Message- From: Dave Martin [mailto:dave.mar...@linaro.org] Sent: Tuesday, February 08, 2011 11:11 PM To: Santosh Shilimkar Cc: linux-arm-ker...@lists.infradead.org; Tony Lindgren; Jean Pihet

[PATCH v4 0/5] ARM: omap[34]: Thumb-2 compatibility fixes

2011-02-09 Thread Dave Martin
the wfi() macro: git://git.linaro.org/people/dmart/linux-2.6-arm.git arm/wfi-macro Dave Martin (5): ARM: omap4: Provide do_wfi() for Thumb-2 ARM: omap4: Convert END() to ENDPROC() for correct linkage with CONFIG_THUMB2_KERNEL ARM: omap3: Remove hand-encoded SMC instructions ARM: omap3

[PATCH v4 1/5] ARM: omap4: Provide do_wfi() for Thumb-2

2011-02-09 Thread Dave Martin
For CONFIG_THUMB2_KERNEL, the existing definition of do_wfi() will insert invalid code into the instruction stream. Any assembler which can assemble Thumb-2 is guaranteed to accept the wfi mnemonic, so for the Thumb-2 case, just use the mnemonic. The ARM case is left as-is. Signed-off-by: Dave

[PATCH v4 3/5] ARM: omap3: Remove hand-encoded SMC instructions

2011-02-09 Thread Dave Martin
of the code). The Makefile already ensures that this file is built with a high enough gcc -march= flag (armv7-a). Signed-off-by: Dave Martin dave.mar...@linaro.org Tested-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/sleep34xx.S | 14 +++--- 1 files changed, 7

[PATCH v4 4/5] ARM: omap3: Thumb-2 compatibility for sram34xx.S

2011-02-09 Thread Dave Martin
* Remove deprecated/undefined PC-relative stores * Add the required ENDPROC() directive for each ENTRY(). * .align before data words Signed-off-by: Dave Martin dave.mar...@linaro.org Tested-by: Santosh Shilimkar santosh.shilim...@ti.com Acked-by: Santosh Shilimkar santosh.shilim...@ti.com

[PATCH v4 2/5] ARM: omap4: Convert END() to ENDPROC() for correct linkage with CONFIG_THUMB2_KERNEL

2011-02-09 Thread Dave Martin
instruction set. Signed-off-by: Dave Martin dave.mar...@linaro.org Tested-by: Santosh Shilimkar santosh.shilim...@ti.com Acked-by: Santosh Shilimkar santosh.shilim...@ti.com --- arch/arm/mach-omap2/omap-headsmp.S |2 +- arch/arm/mach-omap2/omap44xx-smc.S |8 2 files changed, 5

Re: [RFC PATCH 1/6] ARM: mm: define LoUIS API for cache maintenance ops

2012-09-13 Thread Dave Martin
On Thu, Sep 13, 2012 at 11:20:46AM +0100, Lorenzo Pieralisi wrote: ARM v7 architecture introduced the concept of cache levels and related coherency requirements. New processors like A7 and A15 embed an L2 unified cache controller that becomes part of the cache level hierarchy. Some operations

Re: [RFC PATCH 4/6] ARM: kernel: update cpu_suspend code to use cache LoUIS operations

2012-09-13 Thread Dave Martin
On Thu, Sep 13, 2012 at 11:20:49AM +0100, Lorenzo Pieralisi wrote: In processors like A15/A7 L2 cache is unified and integrated within the processor cache hierarchy, so that it is not considered an outer cache anymore. For processors like A15/A7 flush_cache_all() ends up cleaning all cache

Re: [RFC PATCH 1/6] ARM: mm: define LoUIS API for cache maintenance ops

2012-09-13 Thread Dave Martin
On Thu, Sep 13, 2012 at 02:03:34PM +0100, Russell King - ARM Linux wrote: On Thu, Sep 13, 2012 at 12:39:49PM +0100, Dave Martin wrote: We could introduce something like CONFIG_ARM_HAVE_CACHEFLUSH_LOUIS, and do: asm/glue-cache.h #ifndef MULTI_CACHE #ifdef

Re: [RFC PATCH v2 3/5] ARM: kernel: update cpu_suspend code to use cache LoUIS operations

2012-09-19 Thread Dave Martin
On Tue, Sep 18, 2012 at 05:35:33PM +0100, Lorenzo Pieralisi wrote: In processors like A15/A7 L2 cache is unified and integrated within the processor cache hierarchy, so that it is not considered an outer cache anymore. For processors like A15/A7 flush_cache_all() ends up cleaning all cache

Re: [RFC PATCH v2 2/5] ARM: mm: rename jump labels in v7_flush_dcache_all function

2012-09-19 Thread Dave Martin
On Tue, Sep 18, 2012 at 05:35:32PM +0100, Lorenzo Pieralisi wrote: This patch renames jump labels in v7_flush_dcache_all in order to define a specific flush cache levels entry point. TODO: factor out the level flushing loop if considered worthwhile and define the input registers

Re: [RFC PATCH v2 2/5] ARM: mm: rename jump labels in v7_flush_dcache_all function

2012-09-20 Thread Dave Martin
On Thu, Sep 20, 2012 at 11:32:12AM +0100, Lorenzo Pieralisi wrote: On Wed, Sep 19, 2012 at 02:51:56PM +0100, Dave Martin wrote: On Tue, Sep 18, 2012 at 05:35:32PM +0100, Lorenzo Pieralisi wrote: This patch renames jump labels in v7_flush_dcache_all in order to define a specific flush

Re: [RFC PATCH v2 3/5] ARM: kernel: update cpu_suspend code to use cache LoUIS operations

2012-09-20 Thread Dave Martin
On Thu, Sep 20, 2012 at 11:25:14AM +0100, Lorenzo Pieralisi wrote: On Wed, Sep 19, 2012 at 02:46:58PM +0100, Dave Martin wrote: On Tue, Sep 18, 2012 at 05:35:33PM +0100, Lorenzo Pieralisi wrote: In processors like A15/A7 L2 cache is unified and integrated within the processor cache

Re: [PATCH v2 2/7] ARM: virt: allow the kernel to be entered in HYP mode

2012-10-08 Thread Dave Martin
On Sat, Oct 06, 2012 at 09:00:32AM -0700, Tony Lindgren wrote: * Marc Zyngier marc.zyng...@arm.com [121006 03:19]: If so, that indicates some side effect of the safe_svcmode_maskall macro, and I suspect the movs pc, lr bit. Can you try the attached patch? It basically falls back to

Re: [PATCH v2 2/7] ARM: virt: allow the kernel to be entered in HYP mode

2012-10-08 Thread Dave Martin
On Mon, Oct 08, 2012 at 12:01:09PM +0100, Dave Martin wrote: On Sat, Oct 06, 2012 at 09:00:32AM -0700, Tony Lindgren wrote: * Marc Zyngier marc.zyng...@arm.com [121006 03:19]: If so, that indicates some side effect of the safe_svcmode_maskall macro, and I suspect the movs pc, lr bit

Re: [PATCH] arm: omap2: enable smc instruction for sleep34xx

2011-04-19 Thread Dave Martin
On Tue, Apr 19, 2011 at 12:13:26PM +0200, Anderö, Oskar wrote: Ping! Anyone else that gets bitten by the following when compiling omap2plus_defconfig with gcc 4.5: arch/arm/mach-omap2/sleep34xx.S:150: Error: selected processor does not support ARM mode `smc #1'

[PATCH v4 REPOST 0/5] Refactor common Kconfigs for easier maintenance

2011-12-14 Thread Dave Martin
to Rob Herring, Shawn Guo and Russell King for their contributions to this series. Thanks also to David Brown for pointing out the lack of a comprehensive CC list. I have briefly build-tested on some of the affected boards, but any further reviews or Tested-Bys would be much appreciated. Dave

[PATCH v4 REPOST 1/5] ARM: l2x0/pl310: Refactor Kconfig to be more maintainable

2011-12-14 Thread Dave Martin
to some TrustZone-enabled boards where Linux runs in the Normal World, for example. Signed-off-by: Dave Martin dave.mar...@linaro.org --- arch/arm/Kconfig |8 arch/arm/mach-exynos/Kconfig |1 + arch/arm/mach-omap2/Kconfig|1 + arch/arm/mach-realview/Kconfig

[PATCH v4 REPOST 2/5] ARM: SMP: Refactor Kconfig to be more maintainable

2011-12-14 Thread Dave Martin
to indicate that they can run in a SMP configuration. Signed-off-by: Dave Martin dave.mar...@linaro.org --- arch/arm/Kconfig | 15 +++ arch/arm/mach-exynos/Kconfig |1 + arch/arm/mach-imx/Kconfig |1 + arch/arm/mach-msm/Kconfig |1 + arch/arm

[PATCH v4 REPOST 4/5] highbank: Unconditionally require l2x0 L2 cache controller support

2011-12-14 Thread Dave Martin
for the Highbank SoC. Thanks to Rob Herring for this suggestion. [1] Signed-off-by: Dave Martin dave.mar...@linaro.org [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2011-November/074495.html --- arch/arm/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm

[PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 cache controller support

2011-12-14 Thread Dave Martin
for the OMAP4 SoCs. Thanks to Rob Herring for this suggestion. [1] Signed-off-by: Dave Martin dave.mar...@linaro.org [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2011-November/074495.html --- arch/arm/mach-omap2/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on l2x0 L2 cache support

2011-12-14 Thread Dave Martin
. Thanks to Shawn Guo for this suggestion. [1] Signed-off-by: Dave Martin dave.mar...@linaro.org [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2011-November/074602.html --- arch/arm/mach-imx/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm

  1   2   >