Re: [PATCH v10 10/10] mtd: nand: omap: remove selection of BCH ecc-scheme via KConfig

2013-10-23 Thread Ezequiel Garcia
Pekon, On Wed, Oct 23, 2013 at 01:55:58PM +, Gupta, Pekon wrote: I'm wondering how are you testing this in your SOC_AM33XX board (which is not ARCH_OMAP3). You probably have ARCH_OMAP3 always selected? Yes, omap2plus_defconfig is a super set.. arch/arm/configs/omap2plus_defconfig

Re: [PATCH v10 04/10] mtd: nand: omap: fix device scan: NAND_CMD_READID, NAND_CMD_RESET, CMD_CMD_PARAM use only x8 bus

2013-10-23 Thread Ezequiel Garcia
Pekon, On Wed, Oct 23, 2013 at 10:24:57AM -0300, Ezequiel Garcia wrote: [..] I'm currently trying mainline (just for this issue not for my product). I just need some time to prepare the bootargs and write a DT node for the NAND cape. Again, not sure if I'll make some progress, but I'll

Re: [PATCH v10 04/10] mtd: nand: omap: fix device scan: NAND_CMD_READID, NAND_CMD_RESET, CMD_CMD_PARAM use only x8 bus

2013-10-24 Thread Ezequiel Garcia
Pekon, On Thu, Oct 24, 2013 at 12:59:26PM +, Gupta, Pekon wrote: Hi Ezequiel, From: Ezequiel Garcia [mailto:ezequiel.gar...@free-electrons.com] I won't be able to make too much progress without some help or without squeezing my brains out :P Care to push some git branch on some

Re: [PATCH v11 00/10] [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes

2013-10-24 Thread Ezequiel Garcia
Hi Pekon, Just as suggestion, I think you should reconsider your 'upstream strategy'. On Thu, Oct 24, 2013 at 06:20:16PM +0530, Pekon Gupta wrote: [..] Pekon Gupta (10): ARM: OMAP2+: cleaned-up DT support of various ECC schemes mtd: nand: omap: combine different flavours of 1-bit

Re: [PATCH v10 10/10] mtd: nand: omap: remove selection of BCH ecc-scheme via KConfig

2013-10-24 Thread Ezequiel Garcia
Javier, On Thu, Oct 24, 2013 at 09:49:09PM +0200, Javier Martinez Canillas wrote: Hi Ezequiel On Wed, Oct 23, 2013 at 4:13 PM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: Pekon, On Wed, Oct 23, 2013 at 01:55:58PM +, Gupta, Pekon wrote: I'm wondering how are you

Re: [PATCH v11 04/10] mtd: nand: omap: use DT specified bus-width only for scanning NAND device

2013-10-24 Thread Ezequiel Garcia
On Thu, Oct 24, 2013 at 06:20:20PM +0530, Pekon Gupta wrote: This patch: - calls nand_scan_ident() using bus-width as passed by DT - removes double calls to nand_scan_ident(), incase first call fails then omap_nand_probe just returns error. Signed-off-by: Pekon Gupta pe...@ti.com ---

[PATCH 4/5] mtd: nand: omap2: Use devm_kzalloc

2013-10-24 Thread Ezequiel Garcia
This simplifies the error path and makes the code less error-prone. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- drivers/mtd/nand/omap2.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index

[PATCH 3/5] mtd: nand: omap2: Fix OMAP_BCH option dependency

2013-10-24 Thread Ezequiel Garcia
This option does not need to depend in MTD_NAND, for it's enclosed under it. Also, it's wrong to make it depend in ARCH_OMAP3 only since the controller is used in a wider range of SoCs. Instead, just leave the dependency on the OMAP2 driver option. Signed-off-by: Ezequiel Garcia ezequiel.gar

[PATCH 1/5] ARM: am335x-bone: Add support for 16-bit NAND cape

2013-10-24 Thread Ezequiel Garcia
=BeagleBone_4Gb_16-Bit_NAND_Module Signed-off-by: Pekon Gupta pe...@ti.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- This patch is not really intended for inclusion. I'm just adding it to the series for reference and in case anyone wants to test. arch/arm/boot/dts

[PATCH 5/5] mtd: nand: omap2: Use devm_ioremap_resource

2013-10-24 Thread Ezequiel Garcia
This simplifies the code and makes it less error-prone. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- drivers/mtd/nand/omap2.c | 30 +++--- 1 file changed, 7 insertions(+), 23 deletions(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand

[PATCH 0/5] Assorted OMAP2 NAND clean-ups

2013-10-24 Thread Ezequiel Garcia
for 8-bit and 16-bit devices? Feel free to comment or provide any feedback! Ezequiel Garcia (3): mtd: nand: omap2: Fix OMAP_BCH option dependency mtd: nand: omap2: Use devm_kzalloc mtd: nand: omap2: Use devm_ioremap_resource Pekon Gupta (2): ARM: am335x-bone: Add support for 16-bit NAND

[PATCH 2/5] mtd: nand: omap2: Fix device detection path

2013-10-24 Thread Ezequiel Garcia
the nand_chip struct 'option' field to use the appropriate read/write functions and configure the ECC engine. Signed-off-by: Pekon Gupta pe...@ti.com [rebased and clean-up a bit pekon's original work] Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- drivers/mtd/nand/omap2.c | 18

Re: [PATCH v11 04/10] mtd: nand: omap: use DT specified bus-width only for scanning NAND device

2013-10-24 Thread Ezequiel Garcia
On Thu, Oct 24, 2013 at 03:43:00PM -0700, Brian Norris wrote: On Thu, Oct 24, 2013 at 06:27:15PM -0300, Ezequiel Garcia wrote: On Thu, Oct 24, 2013 at 06:20:20PM +0530, Pekon Gupta wrote: This patch: - calls nand_scan_ident() using bus-width as passed by DT - removes double calls

Re: [PATCH 4/5] mtd: nand: omap2: Use devm_kzalloc

2013-10-24 Thread Ezequiel Garcia
On Fri, Oct 25, 2013 at 12:24:38AM +0200, Belisko Marek wrote: Hi, On Fri, Oct 25, 2013 at 12:12 AM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: This simplifies the error path and makes the code less error-prone. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free

[PATCH v2 2/5] mtd: nand: omap2: Fix device detection path

2013-10-25 Thread Ezequiel Garcia
the nand_chip struct 'option' field to use the appropriate read/write functions and configure the ECC engine. Signed-off-by: Pekon Gupta pe...@ti.com [rebased and clean-up a bit pekon's original work] Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- drivers/mtd/nand/omap2.c | 18

[PATCH v2 3/5] mtd: nand: omap2: Fix OMAP_BCH option dependency

2013-10-25 Thread Ezequiel Garcia
This option does not need to depend in MTD_NAND, for it's enclosed under it. Also, it's wrong to make it depend in ARCH_OMAP3 only since the controller is used in a wider range of SoCs. Instead, just leave the dependency on the OMAP2 driver option. Signed-off-by: Ezequiel Garcia ezequiel.gar

[PATCH v2 4/5] mtd: nand: omap2: Use devm_kzalloc

2013-10-25 Thread Ezequiel Garcia
This simplifies the error path and makes the code less error-prone. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- drivers/mtd/nand/omap2.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index

[PATCH v2 1/5] ARM: am335x-bone: Add support for 16-bit NAND cape

2013-10-25 Thread Ezequiel Garcia
=BeagleBone_4Gb_16-Bit_NAND_Module Signed-off-by: Pekon Gupta pe...@ti.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- This patch is not really intended for inclusion. I'm just adding it to the series for reference and in case anyone wants to test. In particular

[PATCH v2 0/5] Assorted OMAP2 NAND clean-ups

2013-10-25 Thread Ezequiel Garcia
in PATCH 4/5 to prevent build failures. The result is the same and the label is removed in the last patch, together with the last users of it. Ezequiel Garcia (3): mtd: nand: omap2: Fix OMAP_BCH option dependency mtd: nand: omap2: Use devm_kzalloc mtd: nand: omap2: Use

[PATCH v2 5/5] mtd: nand: omap2: Use devm_ioremap_resource

2013-10-25 Thread Ezequiel Garcia
This simplifies the code and makes it less error-prone. In fact, this commit fixes a missing iounmap() in the cleanup error path. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- drivers/mtd/nand/omap2.c | 31 +++ 1 file changed, 7 insertions

Re: [PATCH v2 4/5] mtd: nand: omap2: Use devm_kzalloc

2013-10-25 Thread Ezequiel Garcia
On Fri, Oct 25, 2013 at 10:25:02AM +, Gupta, Pekon wrote: Hi, This simplifies the error path and makes the code less error-prone. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- drivers/mtd/nand/omap2.c | 5 + 1 file changed, 1 insertion(+), 4

Re: [PATCH v11 00/10] [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes

2013-10-25 Thread Ezequiel Garcia
tested this using the AM335x device tree you posted earlier with the 16-bit NAND Beaglebone cape. For all the patches: Tested-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com The ECC bindings look much much cleaner now, nice job! -- Ezequiel García, Free Electrons Embedded Linux, Kernel

Re: [PATCH v2 4/5] mtd: nand: omap2: Use devm_kzalloc

2013-10-25 Thread Ezequiel Garcia
On Fri, Oct 25, 2013 at 11:09:14AM +, Gupta, Pekon wrote: From: Ezequiel Garcia [mailto:ezequiel.gar...@free-electrons.com] Hm.. well the problem with that patch is that it's in the middle of an unrelated series. As I already told you, I think you should have pushed that as a one

Re: [PATCH v2 0/5] Assorted OMAP2 NAND clean-ups

2013-10-25 Thread Ezequiel Garcia
Pekon, On Fri, Oct 25, 2013 at 11:15:57AM +, Gupta, Pekon wrote: Hi, -Original Message- From: Ezequiel Garcia [mailto:ezequiel.gar...@free-electrons.com] [...] Pekon, Brian: Do you think this solution might work for 8-bit and 16-bit devices? I think

Re: [PATCH v2 3/5] mtd: nand: omap2: Fix OMAP_BCH option dependency

2013-10-25 Thread Ezequiel Garcia
On Fri, Oct 25, 2013 at 11:26:06AM +, Gupta, Pekon wrote: From: Ezequiel Garcia [mailto:ezequiel.gar...@free-electrons.com] Subject: [PATCH v2 3/5] mtd: nand: omap2: Fix OMAP_BCH option dependency This option does not need to depend in MTD_NAND, for it's enclosed under it. Also

[PATCH 3/3] omap2: gpmc: Move legacy GPMC width setting

2013-10-27 Thread Ezequiel Garcia
-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-nand.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-omap2/gpmc-nand.c b/arch/arm/mach-omap2/gpmc-nand.c index 9dd40e7..174caec 100644 --- a/arch/arm/mach-omap2/gpmc

[PATCH 1/3] omap2: gpmc: Move initialization outside the gpmc_t condition

2013-10-27 Thread Ezequiel Garcia
This commit moves a bunch of initialization previously enclosed under a 'if (gpmc_t)' check, to be outside such condition. These initializations are not related to gpmc_t (timings) in any way so it's nonsense to enclose them under such check. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free

[PATCH 2/3] omap2: gpmc: Introduce gpmc_set_legacy()

2013-10-27 Thread Ezequiel Garcia
Introduce a helper function to complete the setting of some GPMC parameters, only used when the gpmc is probed from a board file. As such, it will go away once the DT conversion is completed. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/mach-omap2/gpmc-nand.c

[PATCH 0/3] omap2: Assorted GPMC cleanups

2013-10-27 Thread Ezequiel Garcia
, on a device with NAND flash. Jon: If you happen to read this, I'd like if you could take a look at patch 1/3, since you were the last to touch that part of the code. Thanks! Ezequiel Garcia (3): omap2: gpmc: Move initialization outside the gpmc_t condition omap2: gpmc: Introduce gpmc_set_legacy

Re: [PATCH v2 0/5] Assorted OMAP2 NAND clean-ups

2013-10-29 Thread Ezequiel Garcia
Hey Pekon, On Fri, Oct 25, 2013 at 08:48:36AM -0300, Ezequiel Garcia wrote: Pekon, On Fri, Oct 25, 2013 at 11:15:57AM +, Gupta, Pekon wrote: Hi, -Original Message- From: Ezequiel Garcia [mailto:ezequiel.gar...@free-electrons.com] [...] Pekon, Brian: Do you think

Re: [PATCH v2 0/5] Assorted OMAP2 NAND clean-ups

2013-10-29 Thread Ezequiel Garcia
Hey Pekon, On Tue, Oct 29, 2013 at 08:14:34PM +, Gupta, Pekon wrote: Sorry I'm bit out of my place.. so not able to sync often with mails.. However plz see my replies below.. Sure, no problem. Thanks for taking the time to discuss this! [..] You seem to think that GPMC + NAND

Re: [PATCH v11 00/10] [PATCH v10 00/10] mtd:nand:omap2: clean-up of supported ECC schemes

2013-10-30 Thread Ezequiel Garcia
On Tue, Oct 29, 2013 at 11:59:57PM -0400, Brian Norris wrote: Pekon/Ezequiel/others: please feel free to send any follow up cleanups for this driver. I'll take a look at what Ezequiel has already sent out and see if it's still applicable on top. They won't. I'll prepare a new patch in top

[PATCH 0/1] Fix OMAP2 NAND ONFI device detection

2013-10-30 Thread Ezequiel Garcia
-tree's or a badly configured memory controller (GPMC). [1] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg97760.html Ezequiel Garcia (1): mtd: nand: omap2: Fix device detection path drivers/mtd/nand/omap2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 1.8.1.5

[PATCH 1/1] mtd: nand: omap2: Fix device detection path

2013-10-30 Thread Ezequiel Garcia
the appropriate read/write functions and configure the ECC engine. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- drivers/mtd/nand/omap2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c index ec40b8d

Re: [PATCH 0/1] Fix OMAP2 NAND ONFI device detection

2013-10-30 Thread Ezequiel Garcia
Pekon, Let me answer this one alone, given it's an important question. On Wed, Oct 30, 2013 at 09:18:53PM +, Gupta, Pekon wrote: I'm not sure, of course, but I don't see why not. It's more likely to break for x16 than it is for x8. Another question here is .. The above patch

Re: [PATCH 0/3] omap2: Assorted GPMC cleanups

2013-11-06 Thread Ezequiel Garcia
On Sun, Oct 27, 2013 at 09:51:45PM -0300, Ezequiel Garcia wrote: (I'm CCing the MTD list, because GPMC is the memory controller used for NOR, NAND and OneNAND devices). Hi all, Just a small patchset containing two small cleanups and a minor fix for the GPMC memory controller. The first

Re: [PATCH 0/1] Fix OMAP2 NAND ONFI device detection

2013-11-06 Thread Ezequiel Garcia
On Wed, Nov 06, 2013 at 08:54:56PM +, Gupta, Pekon wrote: From: Ezequiel Garcia [mailto:ezequiel.gar...@free-electrons.com] On Wed, Oct 30, 2013 at 09:18:53PM +, Gupta, Pekon wrote: I'm not sure, of course, but I don't see why not. It's more likely to break for x16 than

Re: [PATCH 0/1] Fix OMAP2 NAND ONFI device detection

2013-11-06 Thread Ezequiel Garcia
On Wed, Nov 06, 2013 at 10:00:09PM +, Gupta, Pekon wrote: From: Ezequiel Garcia [...] But: on the other hand, I'd really like you to convince me as to why is it so bad to require the DTB to have the proper GPMC bus width. No its not at all bad, all I want is either of the one way

Re: [PATCH v2 3/5] mtd: nand: omap2: Fix OMAP_BCH option dependency

2013-11-12 Thread Ezequiel Garcia
On Fri, Oct 25, 2013 at 11:26:06AM +, Gupta, Pekon wrote: From: Ezequiel Garcia [mailto:ezequiel.gar...@free-electrons.com] Subject: [PATCH v2 3/5] mtd: nand: omap2: Fix OMAP_BCH option dependency This option does not need to depend in MTD_NAND, for it's enclosed under it. Also

Re: [PATCH 2/2] ARM: OMAP2+: move gpmc headers to include/linux/platform_data

2013-11-12 Thread Ezequiel Garcia
Hey Javier, On Sat, Nov 09, 2013 at 05:34:02PM +0100, Javier Martinez Canillas wrote: The OMAP2+ General-Purpose Memory Controller (GPMC) driver should eventually be moved from arch/arm/mach-omap2 to drivers/memory. Unfortunately this is not trivial since it includes headers files that still

Re: [PATCH v2 3/5] mtd: nand: omap2: Fix OMAP_BCH option dependency

2013-11-12 Thread Ezequiel Garcia
On Tue, Nov 12, 2013 at 02:56:47PM -0800, Brian Norris wrote: On Tue, Nov 12, 2013 at 05:45:56PM -0300, Ezequiel Garcia wrote: On Fri, Oct 25, 2013 at 11:26:06AM +, Gupta, Pekon wrote: From: Ezequiel Garcia [mailto:ezequiel.gar...@free-electrons.com] Subject: [PATCH v2 3/5] mtd

Re: [RFC] mtd: gpmc: add BCH support for plain AM335x

2013-11-20 Thread Ezequiel Garcia
Hey Wolfram: On Wed, Nov 20, 2013 at 06:39:12PM +0100, Wolfram Sang wrote: When building a kernel without OMAP3 support but only AM335x, we can't activate the needed MTD_NAND_OMAP_BCH symbol. Signed-off-by: Wolfram Sang w...@the-dreams.de --- Actually, I wonder if this is fix will scale.

Re: [PATCH] usb: phy: am335x: Prevent GPIO reset line request

2013-11-20 Thread Ezequiel Garcia
(Forgot to Cc OMAP people) On Wed, Nov 20, 2013 at 06:58:34PM -0300, Ezequiel Garcia wrote: The 'gpio_reset' field was implicitly set to zero, which is a valid GPIO line and results in the NOP PHY layer trying to request it. Instead, the AM335x SoC need special USB PHY reset handling so

Re: [PATCH] usb: phy: am335x: Prevent GPIO reset line request

2013-11-21 Thread Ezequiel Garcia
On Thu, Nov 21, 2013 at 09:16:40AM +0100, Sebastian Andrzej Siewior wrote: On 11/20/2013 11:02 PM, Ezequiel Garcia wrote: (Forgot to Cc OMAP people) Felipe posted a redo of this area to fix this problem a while back. See http://www.spinics.net/lists/linux-usb/msg97286.html Ah, good

Re: [PATCH] usb: phy: am335x: Prevent GPIO reset line request

2013-11-21 Thread Ezequiel Garcia
On Thu, Nov 21, 2013 at 12:44:51PM +0100, Sebastian Andrzej Siewior wrote: On 11/21/2013 12:30 PM, Ezequiel Garcia wrote: Ah, good to know. That patch should be picked ASAP, without it the USB in AM335x is broken. Is it already too late to -rc1? Yes. Who is supposed to merge that? Greg

Re: [PATCH v4 0/4] pm: Add power off control

2013-11-22 Thread Ezequiel Garcia
Hi Russ, On Fri, Jan 11, 2013 at 12:09:56AM -0800, Russ Dill wrote: I personally like the series, it certainly adds needed functionality. I just wish there was a way to get it without a possible 4 second delay. I was just going through this patches and got confused by the same thing, could

Re: [rtc-linux] Re: [PATCH v4 0/4] pm: Add power off control

2013-11-26 Thread Ezequiel Garcia
On Sat, Nov 23, 2013 at 12:23:35PM -0500, Vaibhav Bedia wrote: On Fri, Nov 22, 2013 at 2:50 PM, Ezequiel Garcia ezequiel.gar...@free-electrons.com wrote: [...] And why specifically *2* seconds, instead of *1* or *33* ? Sounds a bit like voodoo magic on this side :-) Consider

[RFC/PATCH] mtd: nand: auto-detection of NAND bus-width from ONFI param or nand_id[]

2013-11-29 Thread Ezequiel Garcia
-bit data bus width in the parameter page. Signed-off-by: Pekon Gupta pe...@ti.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- drivers/mtd/nand/nand_base.c | 43 +-- include/linux/mtd/nand.h | 7 --- 2 files changed, 13

[RFC/PATCH] NAND bus-width detection extreme makeover

2013-11-29 Thread Ezequiel Garcia
Here's my proposal, based in Pekon's latest work. This patch removes the flash device bus-width configuration, prior to the device detection. With this modification, a NAND driver is no longer able to force the device width, and instead can only obtain the detected bus-width after the call to

Re: The state of AM33xx power management.

2013-11-29 Thread Ezequiel Garcia
(Ccing Vaibhav, who worked on this, iirc) On Thu, Nov 28, 2013 at 02:04:37PM +0100, Brian Murphy wrote: Hi Folks, even though I have seen some references to power management on AM33xx class devices recently on this list it seems to me that just about the only omap device without

Re: [RFC/PATCH] NAND bus-width detection extreme makeover

2013-11-30 Thread Ezequiel Garcia
Hi Brian, On Sat, Nov 30, 2013 at 12:35:37AM -0800, Brian Norris wrote: Hi Ezequiel, On Fri, Nov 29, 2013 at 10:40:55AM -0300, Ezequiel Garcia wrote: Here's my proposal, based in Pekon's latest work. This patch removes the flash device bus-width configuration, prior to the device

[RFC/PATCH v2] NAND bus-width detection extreme makeover

2013-11-30 Thread Ezequiel Garcia
, this commit now clears the NAND_BUSWIDTH_16 flag from chip-options as it prevented device from getting detected. * This v2 no longer removes the NAND_BUSWIDTH_AUTO option. We can do that later after some proper discussion. Ezequiel Garcia (1): mtd: nand: Fix ONFI detection of 16-bit width

[RFC/PATCH v2] mtd: nand: Fix ONFI detection of 16-bit width NAND devices

2013-11-30 Thread Ezequiel Garcia
in the parameter page. Signed-off-by: Pekon Gupta pe...@ti.com Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- drivers/mtd/nand/nand_base.c | 43 +-- 1 file changed, 13 insertions(+), 30 deletions(-) diff --git a/drivers/mtd/nand/nand_base.c b

Re: [PATCH] usb: phy: am335x: Prevent GPIO reset line request

2013-11-30 Thread Ezequiel Garcia
On Thu, Nov 21, 2013 at 07:01:55AM -0600, Felipe Balbi wrote: On Thu, Nov 21, 2013 at 08:55:20AM -0300, Ezequiel Garcia wrote: On Thu, Nov 21, 2013 at 12:44:51PM +0100, Sebastian Andrzej Siewior wrote: On 11/21/2013 12:30 PM, Ezequiel Garcia wrote: Ah, good to know. That patch should

Re: OMAP3 NAND ECC selection

2013-12-05 Thread Ezequiel Garcia
Hi Javier, (CCing Brian: What do you think about this?) On Thu, Dec 05, 2013 at 06:39:10PM +0100, Javier Martinez Canillas wrote: On Thu, Dec 5, 2013 at 6:13 PM, Tony Lindgren t...@atomide.com wrote: In the another thread [0] pointed out by Enric we were discussing the same issue. Thomas

Re: [PATCH] usb: phy: am335x: Prevent GPIO reset line request

2013-12-06 Thread Ezequiel Garcia
On Fri, Dec 06, 2013 at 02:16:23PM -0600, Felipe Balbi wrote: On Sat, Nov 30, 2013 at 07:45:05PM -0300, Ezequiel Garcia wrote: On Thu, Nov 21, 2013 at 07:01:55AM -0600, Felipe Balbi wrote: On Thu, Nov 21, 2013 at 08:55:20AM -0300, Ezequiel Garcia wrote: On Thu, Nov 21, 2013 at 12:44:51PM

[PATCH] ARM: configs: Select USB PHY for AM335x SoC

2013-12-12 Thread Ezequiel Garcia
Enable this option as it's required to use USB on AM335x SoC. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/configs/omap2plus_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs

Re: [PATCH] ARM: configs: Select USB PHY for AM335x SoC

2013-12-19 Thread Ezequiel Garcia
On Thu, Dec 12, 2013 at 12:14:29PM -0300, Ezequiel Garcia wrote: Enable this option as it's required to use USB on AM335x SoC. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/configs/omap2plus_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2] usb: musb: Rework USB and USB_GADGET dependency

2013-12-21 Thread Ezequiel Garcia
This USB controller can work in as host-only, gadget-only or dual-role modes. Rework the dependency on the USB and USB_GADGET configs in order to allow building the driver when !USB or !USG_GADGET. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- Changes from v1: * Rework

AM335x USB DMA seems broken on ISOC URBs

2013-12-21 Thread Ezequiel Garcia
Hello, While doing some experiments with the stk1160 driver (for Easycap TV video capture devices), ran into problems using v3.13-rc4. The problem is that the stk1160 IRQ handler receives no URBs at all. When configuring with CONFIG_MUSB_PIO_ONLY this looks solved, but the bandwidth requirements

Re: [PATCH] ARM: configs: Select USB PHY for AM335x SoC

2013-12-26 Thread Ezequiel Garcia
Felipe, On Thu, Dec 12, 2013 at 12:14:29PM -0300, Ezequiel Garcia wrote: Enable this option as it's required to use USB on AM335x SoC. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- arch/arm/configs/omap2plus_defconfig | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 2/2] usb: musb: Rework USB and USB_GADGET dependency

2013-12-26 Thread Ezequiel Garcia
This USB controller can work in as host-only, gadget-only or dual-role modes. Rework the dependency on the USB and USB_GADGET configs in order to allow building the driver when !USB or !USG_GADGET. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com --- This is just a resend

[PATCH 0/2] musb: Rework USB and USB_GADGET config

2013-12-26 Thread Ezequiel Garcia
. Hope it looks better now. Ezequiel Garcia (2): usb: musb: Remove usb_disable() check in module_init() usb: musb: Rework USB and USB_GADGET dependency drivers/usb/Kconfig | 4 ++-- drivers/usb/musb/Kconfig | 8 drivers/usb/musb/musb_core.c | 17 + 3 files

[PATCH 1/2] usb: musb: Remove usb_disable() check in module_init()

2013-12-26 Thread Ezequiel Garcia
Removing the check to usb_disable() before registering the platform driver allows to build this driver when !USB USB_GADGET, to be used in gadget-only mode. Also, use module_platform_driver() to register the platform driver. Signed-off-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com

Re: [PATCH] ARM: configs: Select USB PHY for AM335x SoC

2013-12-26 Thread Ezequiel Garcia
On Thu, Dec 26, 2013 at 09:55:55AM -0600, Felipe Balbi wrote: On Thu, Dec 26, 2013 at 09:08:34AM -0300, Ezequiel Garcia wrote: Felipe, On Thu, Dec 12, 2013 at 12:14:29PM -0300, Ezequiel Garcia wrote: Enable this option as it's required to use USB on AM335x SoC. Signed-off

Re: [PATCH 0/3] omap2: Assorted GPMC cleanups

2014-01-08 Thread Ezequiel Garcia
On Wed, Jan 08, 2014 at 11:18:37AM -0800, Tony Lindgren wrote: * Ezequiel Garcia ezequiel.gar...@free-electrons.com [131027 17:52]: (I'm CCing the MTD list, because GPMC is the memory controller used for NOR, NAND and OneNAND devices). Hi all, Just a small patchset containing two

Re: AM335x USB DMA seems broken on ISOC URBs

2014-01-17 Thread Ezequiel Garcia
On Sun, Dec 22, 2013 at 02:59:45AM -0300, Ezequiel Garcia wrote: Hello, While doing some experiments with the stk1160 driver (for Easycap TV video capture devices), ran into problems using v3.13-rc4. The problem is that the stk1160 IRQ handler receives no URBs at all. When configuring

Re: AM335x USB DMA seems broken on ISOC URBs

2014-01-20 Thread Ezequiel Garcia
On Mon, Jan 20, 2014 at 12:15:40PM +0100, Daniel Mack wrote: On 01/18/2014 04:12 PM, Daniel Mack wrote: On 01/17/2014 05:27 PM, Ezequiel Garcia wrote: On Sun, Dec 22, 2013 at 02:59:45AM -0300, Ezequiel Garcia wrote: While doing some experiments with the stk1160 driver (for Easycap TV

Re: AM335x USB DMA seems broken on ISOC URBs

2014-01-20 Thread Ezequiel Garcia
Hi Daniel, On Sat, Jan 18, 2014 at 04:12:24PM +0100, Daniel Mack wrote: On 01/17/2014 05:27 PM, Ezequiel Garcia wrote: On Sun, Dec 22, 2013 at 02:59:45AM -0300, Ezequiel Garcia wrote: [..] Did you try this with a different type of peripheral hardware, a USB audio device for example

Re: regressions in linux-next?

2014-04-22 Thread Ezequiel Garcia
On Apr 22, Javier Martinez Canillas wrote: On Tue, Apr 22, 2014 at 3:29 PM, Peter Ujfalusi peter.ujfal...@ti.com wrote: On 04/22/2014 04:18 PM, Nishanth Menon wrote: next-20140422-omap2plus_defconfig 1: am335x-sk: Boot FAIL: http://slexy.org/raw/s2gh6XsLve 2: am3517-evm: Boot PASS:

Re: [PATCH RFC] ARM: dts: am335x: update USB DT references

2014-04-23 Thread Ezequiel Garcia
On Apr 23, Tony Lindgren wrote: * Benoit Cousson bcous...@baylibre.com [140422 07:14]: Hi Leigh, On 16/04/2014 13:26, Leigh Brown wrote: In ARM: dts: am33xx: correcting dt node unit address for usb, the usb_ctrl_mod and cppi41dma nodes were updated with the correct register

Re: [PATCH RFC] ARM: dts: am335x: update USB DT references

2014-04-23 Thread Ezequiel Garcia
On Apr 23, Benoit Cousson wrote: Hi Ezequiel, On 23/04/2014 17:17, Ezequiel Garcia wrote: On Apr 23, Tony Lindgren wrote: * Benoit Cousson bcous...@baylibre.com [140422 07:14]: Hi Leigh, On 16/04/2014 13:26, Leigh Brown wrote: In ARM: dts: am33xx: correcting dt node unit address for usb

[PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early

2014-04-24 Thread Ezequiel Garcia
-by: Ezequiel Garcia ezequ...@vanguardiasur.com.ar -- v1-v2: * Added a comment to prevent a future clean-up based on the memory offset. arch/arm/boot/dts/am33xx.dtsi | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/arch/arm/boot/dts

[RFC/PATCH] usb: musb: Prevent musb_am335x from being removed

2014-05-08 Thread Ezequiel Garcia
-by: Ezequiel Garcia ezequ...@vanguardiasur.com.ar --- Given I'm not 100% sure my analisys is correct, I've marked this as RFC and not Cced stable. Feel free to provide a better patch to fix this issue, instead of disabling the removal. drivers/usb/musb/musb_am335x.c | 23 ++- 1 file

Re: [PATCH v2] ARM: dts: am33xx: Move the cppi41dma node so it's probed early

2014-05-12 Thread Ezequiel Garcia
On 12 May 10:29 AM, George Cherian wrote: On 4/25/2014 2:41 AM, Ezequiel Garcia wrote: The DMA controller is needed for the USB controller to be correctly registered. Therefore, if the DMA node is located at the end an unecessary probe deferral is produced systematically. This is easily

Re: [RFC/PATCH] usb: musb: Prevent musb_am335x from being removed

2014-05-12 Thread Ezequiel Garcia
On 12 May 10:29 AM, George Cherian wrote: On 5/8/2014 10:57 PM, Ezequiel Garcia wrote: At probe time, the musb_am335x driver registers its childs by calling of_platform_populate(), which registers all childs in the devicetree hierarchy recursively. On the other side, the driver's remove

Re: [PATCH v2 1/2] ARM: dts: am335x-bone: add support for beaglebone NAND cape

2014-05-12 Thread Ezequiel Garcia
Pekon, A few questions regarding this patch, despite the fact I'm not sure it will ever be included. On 20 Mar 01:04 PM, Pekon Gupta wrote: + 0x70 (MUX_MODE0 | PIN_INPUT_PULLUP )/* gpmc_wait0.gpmc_wait0 */ + 0x74 (MUX_MODE7 | PIN_OUTPUT_PULLUP)

Re: [PATCH v6 1/4] ARM: dts: am335x-bone: add support for beaglebone NAND cape

2014-05-16 Thread Ezequiel Garcia
to try? Pekon, have you noticed that there's no devicetree property to enable ready/busy? In other words, the NAND driver dev_ready field will never be true when probed from DT. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line unsubscribe

[PATCH for v3.15] usb: musb: Fix panic upon musb_am335x module removal

2014-05-17 Thread Ezequiel Garcia
] (SyS_delete_module) from [c000e500] (ret_fast_syscall+0x0/0x48) Fixes: 97238b35d5bb (usb: musb: dsps: use proper child nodes) Cc: sta...@vger.kernel.org # v3.12+ Acked-by: George Cherian george.cher...@ti.com Signed-off-by: Ezequiel Garcia ezequ...@vanguardiasur.com.ar --- drivers/usb/musb/musb_am335x.c

Re: [RFC PATCH] ARM: dts: am33xx: Re-arrange the USB dt to reflect the h/w configuration

2014-05-17 Thread Ezequiel Garcia
, this fixes a serious problem so I've marked it for stable. For the DMA init order issue, I've done a new patch that forces the probe order in the driver. I'll post that soon. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH v7 1/4] ARM: dts: am335x-bone: add support for beaglebone NAND cape

2014-05-19 Thread Ezequiel Garcia
On 19 May 05:52 PM, Gupta, Pekon wrote: Hi Tony, From: Tony Lindgren [mailto:t...@atomide.com] * Pekon Gupta pe...@ti.com [140519 02:16]: --- a/arch/arm/boot/dts/am335x-bone.dts +++ b/arch/arm/boot/dts/am335x-bone.dts @@ -9,6 +9,7 @@ #include am33xx.dtsi #include

Re: [PATCH for v3.15] usb: musb: Fix panic upon musb_am335x module removal

2014-05-20 Thread Ezequiel Garcia
On 17 May 09:04 PM, Ezequiel Garcia wrote: At probe time, the musb_am335x driver register its childs by calling of_platform_populate(), which registers all childs in the devicetree hierarchy recursively. On the other side, the driver's remove() function uses of_device_unregister() to remove

Re: [RFC PATCH 00/16] OMAP: GPMC: Restructure OMAP GPMC driver (NAND)

2014-05-21 Thread Ezequiel Garcia
Hi Roger, On 21 May 02:20 PM, Roger Quadros wrote: For DT boot: - The GPMC controller node should have a chip select (CS) node for each used chip select. The CS node must have a child device node for each device attached to that chip select. Properties for that child are GPMC agnostic.

Re: [RFC PATCH 00/16] OMAP: GPMC: Restructure OMAP GPMC driver (NAND) : DT binding change proposal

2014-05-22 Thread Ezequiel Garcia
On 22 May 01:51 PM, Javier Martinez Canillas wrote: On Thu, May 22, 2014 at 10:12 AM, Roger Quadros rog...@ti.com wrote: On 21 May 02:20 PM, Roger Quadros wrote: For DT boot: - The GPMC controller node should have a chip select (CS) node for each used chip select. The CS node must

Re: [PATCH for v3.15] usb: musb: Fix panic upon musb_am335x module removal

2014-06-14 Thread Ezequiel Garcia
Hi Felipe, On 20 May 01:55 PM, Ezequiel Garcia wrote: On 17 May 09:04 PM, Ezequiel Garcia wrote: At probe time, the musb_am335x driver register its childs by calling of_platform_populate(), which registers all childs in the devicetree hierarchy recursively. On the other side

[PATCH] usb: musb: Fix panic upon musb_am335x module removal

2014-06-23 Thread Ezequiel Garcia
] (SyS_delete_module) from [c000e500] (ret_fast_syscall+0x0/0x48) Fixes: 97238b35d5bb (usb: musb: dsps: use proper child nodes) Cc: sta...@vger.kernel.org # v3.12+ Acked-by: George Cherian george.cher...@ti.com Signed-off-by: Ezequiel Garcia ezequ...@vanguardiasur.com.ar --- drivers/usb/musb/musb_am335x.c

Re: [PATCH v1 3/3] ARM: dts: am335x-bone: add support for beaglebone LCD4 cape

2014-06-24 Thread Ezequiel Garcia
to 'EHRPWM1A' on cape board, but its used for enabling backlight power-supply. So 'gpio-backlight' driver is used instead of 'pwm-backlight' driver (Kconfig: BACKLIGHT_GPIO=y). I'm confused about this, can you clarify why you are not using pwm-backlight? -- Ezequiel Garcia

Re: [PATCH v1 3/3] ARM: dts: am335x-bone: add support for beaglebone LCD4 cape

2014-06-25 Thread Ezequiel Garcia
On 25 Jun 04:38 AM, Gupta, Pekon wrote: From: Ezequiel Garcia On 24 Jun 05:54 PM, Pekon Gupta wrote: This patch adds support for LCD4 cape as advertised on http://elinux.org/CircuitCo:BeagleBone_LCD4 This cape has: * 480x272 TFT-LCD panel - LCD panel datasheet and timing

Re: [PATCH v1 1/3] ARM: dts: am335x-bone: add support for beaglebone NAND cape

2014-06-25 Thread Ezequiel Garcia
; + pinctrl-0 = bbcape_nand_flash_pins; + ti,nand-ecc-opt = bch8; + ti,elm-id = elm; Don't you need something like this to turn on the elm device? elm { status = okay; }; -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from

Re: [PATCH 1/5] [RFC-HACK] pinctrl-single: init by postcore_initcall()

2014-07-16 Thread Ezequiel Garcia
, we'll be able to move all the drivers to module_init. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/5] [RFC-HACK] pinctrl-single: init by postcore_initcall()

2014-07-16 Thread Ezequiel Garcia
On 16 Jul 05:36 AM, Tony Lindgren wrote: * Ezequiel Garcia ezequ...@vanguardiasur.com.ar [140716 04:48]: On 22 May 04:31 PM, Tony Lindgren wrote: * Christoph Fritz chf.fr...@googlemail.com [140522 16:07]: --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c

Re: [PATCH 6/9] ARM: dts: am33xx: Add external clock provider

2014-08-08 Thread Ezequiel Garcia
On 06 Aug 04:47 PM, Jyri Sarha wrote: Add external clock provaider for am33xx devices. Typo: s/provaider/provider -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH 0/9] Beaglebone-Black HDMI audio

2014-08-08 Thread Ezequiel Garcia
, this worked out of the box. Did some simple tests with mpg123 and mplayer. Tested-by: Ezequiel Garcia ezequiel.gar...@free-electrons.com Thanks a lot! -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line

Re: OMAP baseline test results for v3.16-rc4

2014-08-09 Thread Ezequiel Garcia
to be tracked down. I'm seeing it on my 37xx evm also with linux next too. It's commit a71e3c37960ce5f9c6a519bc1215e3ba9fa83e75: Author: Ezequiel Garcia ezequiel.gar...@free-electrons.com Date: Wed Jul 23 16:47:31 2014 -0300 net: phy: Set the driver when registering an MDIO bus device

Re: [PATCH 2/3] nand: omap2: Remove horrible ifdefs to fix module probe

2014-09-06 Thread Ezequiel Garcia
On 07 Sep 02:40 AM, pekon wrote: + linux-omap, as this patch touches arch/arm/mach-omap2/gpmc.c Hi Ezequiel, On Sunday 07 September 2014 01:26 AM, Ezequiel Garcia wrote: The current code abuses ifdefs to determine if the selected ECC scheme is supported by the running kernel. As a result

Re: [PATCH 2/3] nand: omap2: Remove horrible ifdefs to fix module probe

2014-09-06 Thread Ezequiel Garcia
, to keep the current behavior as much as possible. In addition, if we don't check for the configs explicitly at probe time, we would only defer the error until some later point, for instance in the call to nand_chip-ecc.correct(). I don't think that's user-friendly. -- Ezequiel Garcia, VanguardiaSur

Re: [PATCH 2/3] nand: omap2: Remove horrible ifdefs to fix module probe

2014-09-07 Thread Ezequiel Garcia
to fail at probe time if the driver cannot deal with the selected ECC, and that's exactly what omap2_nand_ecc_check() does. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

[PATCH v2 3/3] nand: omap2: Replace pr_err with dev_err

2014-09-08 Thread Ezequiel Garcia
Usage of pr_err is frowned upon, so replace it with dev_err. Aditionally, the message on nand_bch_init() error is redundant, since proper error is showed if the function fails. Signed-off-by: Ezequiel Garcia ezequ...@vanguardiasur.com.ar --- drivers/mtd/nand/omap2.c | 26

[PATCH v2 1/3] nand: omap2: Add support for flash-based bad block table

2014-09-08 Thread Ezequiel Garcia
on the flash. Signed-off-by: Ezequiel Garcia ezequ...@vanguardiasur.com.ar --- arch/arm/mach-omap2/gpmc.c | 2 ++ drivers/mtd/nand/omap2.c | 6 +- include/linux/platform_data/mtd-nand-omap2.h | 1 + 3 files changed, 8 insertions(+), 1 deletion(-) diff --git

[PATCH v2 0/3] nand: omap2: Two and a half improvements

2014-09-08 Thread Ezequiel Garcia
that. The third patch is just a dummy cleanup replacing pr_errs with dev_errs. This driver is abusing from user messages, but I'm not sure fixing them worths the trouble. Ezequiel Garcia (3): nand: omap2: Add support for flash-based bad block table nand: omap2: Remove horrible ifdefs to fix module

<    1   2   3   >