Re: [PATCH 5/6] phy: omap-usb2: Balance pm_runtime_enable() on probe failure

2014-07-03 Thread Kishon Vijay Abraham I
Hi Roger, On Wednesday 02 July 2014 05:33 PM, Roger Quadros wrote: > If probe fails then we need to call pm_runtime_disable() to balance > out the previous pm_runtime_enable() call. Else it will cause > unbalanced pm_runtime_enable() call in the succeding probe call. > > This anomaly was observed

[PATCH v2] arm: dra7xx: Add hwmod data for pcie1 and pcie2 subsystems

2014-07-09 Thread Kishon Vijay Abraham I
Added hwmod data for pcie1 and pcie2 subsystem present in DRA7xx SOC. Cc: Tony Lindgren Cc: Russell King Cc: Paul Walmsley Signed-off-by: Kishon Vijay Abraham I Tested-by: Kishon Vijay Abraham I --- Changes from v1: * changed the clock domain to "pcie_clkdm" * Added PCIe as a slav

Re: [PATCH v2] arm: dra7xx: Add hwmod data for pcie1 and pcie2 subsystems

2014-07-14 Thread Kishon Vijay Abraham I
On Wednesday 09 July 2014 04:32 PM, Rajendra Nayak wrote: > On Wednesday 09 July 2014 02:32 PM, Kishon Vijay Abraham I wrote: >> Added hwmod data for pcie1 and pcie2 subsystem present in DRA7xx SOC. >> >> Cc: Tony Lindgren >> Cc: Russell King >> Cc: Paul Walmsle

[RESEND PATCH 1/8] ARM: dts: dra7xx-clocks: Add divider table to optfclk_pciephy_div clock

2014-07-14 Thread Kishon Vijay Abraham I
Subsystem of PCIe PHY module. The divider value if '1' should be programmed in order to get the correct PCIE_PHY_DIV_GCLK frequency (2.5GHz). Cc: Rajendra Nayak Cc: Tero Kristo Cc: Paul Walmsley Signed-off-by: Keerthy Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/

[RESEND PATCH 2/8] ARM: dts: dra7xx-clocks: Change the parent of apll_pcie_in_clk_mux to dpll_pcie_ref_m2ldo_ck

2014-07-14 Thread Kishon Vijay Abraham I
Overview shows CLKOUTLDO is used as input to apll mux. So the actual output of dpll is dpll_pcie_ref_m2ldo_ck which is also the input of apll. Cc: Rajendra Nayak Cc: Tero Kristo Cc: Paul Walmsley Signed-off-by: Keerthy Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7xx

[RESEND PATCH 5/8] ARM: dts: dra7xx-clocks: Add missing clocks for second PCIe PHY instance

2014-07-14 Thread Kishon Vijay Abraham I
: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7xx-clocks.dtsi | 24 1 file changed, 24 insertions(+) diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi index fe5db55..b48f18b 100644 --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi +++ b

[RESEND PATCH 8/8] ARM: dts: dra7: Add dt data for PCIe controller

2014-07-14 Thread Kishon Vijay Abraham I
Cc: Bjorn Helgaas Cc: Jingoo Han Cc: Jason Gunthorpe Cc: Marek Vasut Cc: Arnd Bergmann Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi | 69 +++ 1 file changed, 69 insertions(+) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch

[RESEND PATCH 6/8] ARM: dts: dra7: Add dt data for PCIe PHY control module

2014-07-14 Thread Kishon Vijay Abraham I
Added dt data for PCIe PHY control module used by PCIe PHY. The documention for this node can be found @ ../bindings/phy/ti-phy.txt Cc: Tony Lindgren Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Kumar Gala Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi | 17

[RESEND PATCH 7/8] ARM: dts: dra7: Add dt data for PCIe PHY

2014-07-14 Thread Kishon Vijay Abraham I
: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Kumar Gala Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7.dtsi | 41 + 1 file changed, 41 insertions(+) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index

[RESEND PATCH 3/8] ARM: dts: dra7xx-clocks: Add missing 32KHz clocks used for PHY

2014-07-14 Thread Kishon Vijay Abraham I
-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7xx-clocks.dtsi |8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/dra7xx-clocks.dtsi b/arch/arm/boot/dts/dra7xx-clocks.dtsi index f5dca1f..3ff6d7c 100644 --- a/arch/arm/boot/dts/dra7xx-clocks.dtsi +++ b/arch

[RESEND PATCH 4/8] ARM: dts: dra7xx-clocks: rename pcie clocks to accommodate second PHY instance

2014-07-14 Thread Kishon Vijay Abraham I
: Rajendra Nayak Cc: Tero Kristo Cc: Paul Walmsley Cc: Tony Lindgren Cc: Rob Herring Cc: Pawel Moll Cc: Mark Rutland Cc: Kumar Gala Signed-off-by: Keerthy Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/dra7xx-clocks.dtsi |6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[RESEND PATCH 0/8] arm: dts: dra7: Add PCIe data and PCIe PHY data

2014-07-14 Thread Kishon Vijay Abraham I
(2): ARM: dts: dra7xx-clocks: Add divider table to optfclk_pciephy_div clock ARM: dts: dra7xx-clocks: Change the parent of apll_pcie_in_clk_mux to dpll_pcie_ref_m2ldo_ck Kishon Vijay Abraham I (6): ARM: dts: dra7xx-clocks: Add missing 32KHz clocks used for PHY ARM: dts: dra7xx-clo

Re: [PATCH v2] arm: dra7xx: Add hwmod data for pcie1 and pcie2 subsystems

2014-07-15 Thread Kishon Vijay Abraham I
On Wednesday 16 July 2014 01:43 AM, Paul Walmsley wrote: > On Mon, 14 Jul 2014, Kishon Vijay Abraham I wrote: > >> On Wednesday 09 July 2014 04:32 PM, Rajendra Nayak wrote: >>> On Wednesday 09 July 2014 02:32 PM, Kishon Vijay Abraham I wrote: >>>> Added hwmod d

Re: [RESEND PATCH 0/8] arm: dts: dra7: Add PCIe data and PCIe PHY data

2014-07-15 Thread Kishon Vijay Abraham I
On Tuesday 15 July 2014 12:48 PM, Tony Lindgren wrote: > * Kishon Vijay Abraham I [140714 03:44]: >> [1] is split into separate series in order for individual subsystem >> Maintainers to pick up the patches. This series handles the PCIe >> dt data for DRA7. >> >&

Re: [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform

2014-07-23 Thread Kishon Vijay Abraham I
r 2013 17:48:29 Felipe Balbi wrote: >>> On Mon, Dec 16, 2013 at 02:38:27PM -0800, Tony Lindgren wrote: >>>> * Felipe Balbi [131216 13:31]: >>>>> On Mon, Dec 16, 2013 at 09:23:43PM +0530, Kishon Vijay Abraham I wrote: >>>>>> After the platform

Re: [PATCH] usb: phy: twl4030-usb: Fix regressions to runtime PM on omaps

2014-08-21 Thread Kishon Vijay Abraham I
Hi, On Thursday 21 August 2014 10:13 PM, Tony Lindgren wrote: > Commit 30a70b026b4cd ("usb: musb: fix obex in g_nokia.ko causing kernel > panic") attempted to fix runtime PM handling for PHYs that are on the > I2C bus. Commit 3063a12be2b0 (usb: musb: fix PHY power on/off) then > changed things aro

[PATCH 2/5] usb: musb: omap: always glue have the correct vbus/id status

2013-03-13 Thread Kishon Vijay Abraham I
In the case where omap glue is loaded and musb core is not, glue->status wont have a valid status if the phy drivers call omap_musb_mailbox. So fixed the conditions here. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/omap2430.c | 11 +-- 1 file changed, 5 insertions(+)

[PATCH 5/5] usb: otg: twl4030: fix cold plug on OMAP3

2013-03-13 Thread Kishon Vijay Abraham I
. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/otg/twl4030-usb.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/otg/twl4030-usb.c b/drivers/usb/otg/twl4030-usb.c index 5b20bb4..4040124 100644 --- a/drivers/usb/otg/twl4030-usb.c +++ b/drivers/usb

[PATCH 1/5] usb: musb: omap: remove the check before calling otg_set_vbus

2013-03-13 Thread Kishon Vijay Abraham I
No functional change. otg_set_vbus is already protected so removed the check before calling otg_set_vbus. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/omap2430.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers

[PATCH 4/5] usb: musb: omap: add usb_phy_init in omap2430_musb_init

2013-03-13 Thread Kishon Vijay Abraham I
Some PHYs load too early (twl4030) making omap glue to miss cable connect events if the board is booted with cable connected. So adding usb_phy_init in omap2430_musb_init lets PHYs to report events once glue is ready. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/omap2430.c |2

[PATCH 3/5] usb: otg: twl4030: use devres API for regulator get and request irq

2013-03-13 Thread Kishon Vijay Abraham I
Used devres APIs devm_request_threaded_irq and devm_regulator_get for requesting irq and for getting regulator respectively. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/otg/twl4030-usb.c | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git

[PATCH 0/5] usb: musb/otg: cleanup and fixes

2013-03-13 Thread Kishon Vijay Abraham I
pandaboard and beagleboard in both cold plug and hot plug case. Any kind of testing for this series is welcome. Kishon Vijay Abraham I (5): usb: musb: omap: remove the check before calling otg_set_vbus usb: musb: omap: always glue have the correct vbus/id status usb: otg: twl4030: use devres API

[PATCH v2 2/4] usb: otg: twl4030: use devres API for regulator get and request irq

2013-03-13 Thread Kishon Vijay Abraham I
Used devres APIs devm_request_threaded_irq and devm_regulator_get for requesting irq and for getting regulator respectively. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/otg/twl4030-usb.c | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git

[PATCH v2 3/4] usb: musb: omap: add usb_phy_init in omap2430_musb_init

2013-03-13 Thread Kishon Vijay Abraham I
Some PHYs load too early (twl4030) making omap glue to miss cable connect events if the board is booted with cable connected. So adding usb_phy_init in omap2430_musb_init lets PHYs to report events once glue is ready. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/omap2430.c |2

[PATCH v2 4/4] usb: otg: twl4030: fix cold plug on OMAP3

2013-03-13 Thread Kishon Vijay Abraham I
. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/otg/twl4030-usb.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/otg/twl4030-usb.c b/drivers/usb/otg/twl4030-usb.c index 5b20bb4..4040124 100644 --- a/drivers/usb/otg/twl4030-usb.c +++ b/drivers/usb

[PATCH v2 0/4] usb: musb/otg: cleanup and fixes

2013-03-13 Thread Kishon Vijay Abraham I
pandaboard and beagleboard in both cold plug and hot plug case. Any kind of testing for this series is welcome. Changes from v1: * removed *usb: musb: omap: remove the check before calling otg_set_vbus* a similar patch is already merged. Kishon Vijay Abraham I (4): usb: musb: omap: remove the

[PATCH v2 1/4] usb: musb: omap: remove the check before calling otg_set_vbus

2013-03-13 Thread Kishon Vijay Abraham I
No functional change. otg_set_vbus is already protected so removed the check before calling otg_set_vbus. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/omap2430.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers

[PATCH 2/4] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-15 Thread Kishon Vijay Abraham I
ixed it by doing *unmap_dma_buffer* only for valid DMA addr. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/musb_gadget.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index c454375..ec3cf29 10

[PATCH 4/4] usb: otg: twl4030: fix cold plug on OMAP3

2013-03-15 Thread Kishon Vijay Abraham I
. Signed-off-by: Kishon Vijay Abraham I Tested-by: Grazvydas Ignotas --- drivers/usb/phy/phy-twl4030-usb.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/usb/phy/phy-twl4030-usb.c b/drivers/usb/phy/phy-twl4030-usb.c index e14b03e..1986c78 100644 --- a

[PATCH 3/4] usb: otg: twl4030: use devres API for regulator get and request irq

2013-03-15 Thread Kishon Vijay Abraham I
Used devres APIs devm_request_threaded_irq and devm_regulator_get for requesting irq and for getting regulator respectively. Signed-off-by: Kishon Vijay Abraham I Tested-by: Grazvydas Ignotas --- drivers/usb/phy/phy-twl4030-usb.c | 28 1 file changed, 8

[PATCH 1/4] usb: Fix linker errors during build

2013-03-15 Thread Kishon Vijay Abraham I
commit 63378a (usb: phy: remove CONFIG_USB_OTG_UTILS) removed CONFIG_USB_OTG_UTILS from Kconfig but failed to removed from Makefile. Fixed it here. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb

[PATCH v3 5/6] ARM: dts: omap: update usb_otg_hs data

2013-03-20 Thread Kishon Vijay Abraham I
Updated the usb_otg_hs dt data to include the *phy* and *phy-names* binding in order for the driver to use the new generic PHY framework. Also updated the Documentation to include the binding information. Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/omap

[PATCH v3 6/6] usb: musb: omap2430: use the new generic PHY framework

2013-03-20 Thread Kishon Vijay Abraham I
te state machine to handle otg, these can be moved out of xceiv and then we can start using the generic PHY framework. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/musb_core.h |2 ++ drivers/usb/musb/omap2430.c | 22 -- 2 files changed, 18 insertio

[PATCH v3 3/6] usb: otg: twl4030: use the new generic PHY framework

2013-03-20 Thread Kishon Vijay Abraham I
completely will break OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/otg/twl4030-usb.c | 36 1 file changed, 36 insertions(+) diff --git a/drivers/usb/otg/twl4030

[PATCH v3 1/6] drivers: phy: add generic PHY framework

2013-03-20 Thread Kishon Vijay Abraham I
hy b/Documentation/ABI/testing/sysfs-class-phy new file mode 100644 index 000..47f17c9 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-class-phy @@ -0,0 +1,15 @@ +What: /sys/class/phy//label +Date: Feb 2013 +KernelVersion: 3.10 +Contact: Kishon Vijay Abraham I +Descri

[PATCH v3 4/6] ARM: OMAP: USB: Add phy binding information

2013-03-20 Thread Kishon Vijay Abraham I
s OTG in it (struct usb_phy has struct usb_otg as member). Until we have a separate OTG state machine to handle all of that, the new generic PHY framework and the old phy library will co-exist. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/mach-omap2/board-2430sdp.c |2 ++ arc

[PATCH v3 0/6] Generic PHY Framework

2013-03-20 Thread Kishon Vijay Abraham I
d*. Changes from v1: * Added Documentation for the PHY framework * Added few more APIs mostly w.r.t devres * Modified omap-usb2 and twl4030 to make use of the new framework Did USB enumeration testing in panda and beagle. Kishon Vijay Abraham I (6): drivers: phy: add generic PHY framework usb:

[PATCH v3 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-03-20 Thread Kishon Vijay Abraham I
framework will break OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/omap-usb2.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/drivers/usb/phy/omap-usb2.c

Re: [PATCH v3 5/6] ARM: dts: omap: update usb_otg_hs data

2013-03-22 Thread Kishon Vijay Abraham I
Hi, On Thursday 21 March 2013 10:40 PM, Stephen Warren wrote: On 03/21/2013 12:23 AM, kishon wrote: Hi, On Thursday 21 March 2013 02:29 AM, Stephen Warren wrote: On 03/20/2013 03:12 AM, Kishon Vijay Abraham I wrote: Updated the usb_otg_hs dt data to include the *phy* and *phy-names* binding

[PATCH v4 4/6] ARM: OMAP: USB: Add phy binding information

2013-03-27 Thread Kishon Vijay Abraham I
In order for controllers to get PHY in case of non dt boot, the phy binding information should be added in the platform specific initialization code using phy_bind. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/mach-omap2/usb-musb.c |7 ++- 1 file changed, 6 insertions(+), 1

[PATCH v4 1/6] drivers: phy: add generic PHY framework

2013-03-27 Thread Kishon Vijay Abraham I
or dt binding is can be found at Documentation/devicetree/bindings/phy/phy-bindings.txt Signed-off-by: Kishon Vijay Abraham I --- Documentation/ABI/testing/sysfs-class-phy | 15 + .../devicetree/bindings/phy/phy-bindings.txt | 76 +++ Documentation/ph

[PATCH v4 3/6] usb: otg: twl4030: use the new generic PHY framework

2013-03-27 Thread Kishon Vijay Abraham I
completely will break OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/otg/twl4030-usb.c | 36 1 file changed, 36 insertions(+) diff --git a/drivers/usb/otg/twl4030

[PATCH v4 0/6] Generic PHY Framework

2013-03-27 Thread Kishon Vijay Abraham I
ges from v1: * Added Documentation for the PHY framework * Added few more APIs mostly w.r.t devres * Modified omap-usb2 and twl4030 to make use of the new framework Did USB enumeration testing in panda and beagle. Kishon Vijay Abraham I (6): drivers: phy: add generic PHY framework usb: phy: om

[PATCH v4 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-03-27 Thread Kishon Vijay Abraham I
framework will break OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/omap-usb2.c | 47 +++ 1 file changed, 47 insertions(+) diff --git a/drivers/usb/phy/omap-usb2.c

[PATCH v4 6/6] usb: musb: omap2430: use the new generic PHY framework

2013-03-27 Thread Kishon Vijay Abraham I
te state machine to handle otg, these can be moved out of xceiv and then we can start using the generic PHY framework. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/musb_core.h |2 ++ drivers/usb/musb/omap2430.c | 22 -- 2 files changed, 18 insertio

[PATCH v4 5/6] ARM: dts: omap: update usb_otg_hs data

2013-03-27 Thread Kishon Vijay Abraham I
-bindings.txt Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/omap-usb.txt |5 + arch/arm/boot/dts/omap3.dtsi |2 ++ arch/arm/boot/dts/omap4.dtsi |2 ++ 3 files changed, 9 insertions(+) diff --git a/Documentation

Re: [PATCH v4 1/6] drivers: phy: add generic PHY framework

2013-04-02 Thread Kishon Vijay Abraham I
Hi, On Thursday 28 March 2013 09:15 PM, Stephen Warren wrote: On 03/27/2013 11:43 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the diff --git a/Documentation

Re: [PATCH v4 1/6] drivers: phy: add generic PHY framework

2013-04-02 Thread Kishon Vijay Abraham I
Hi, On Tuesday 02 April 2013 01:04 AM, Sylwester Nawrocki wrote: Just couple minor comments... On 03/28/2013 06:43 AM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-02 Thread Kishon Vijay Abraham I
Hi, On Monday 01 April 2013 07:24 PM, Vivek Gautam wrote: Adding APIs to handle runtime power management on PHY devices. PHY consumers may need to wake-up/suspend PHYs when they work across autosuspend. Signed-off-by: Vivek Gautam --- include/linux/usb/phy.h | 141 +

Re: [PATCH v4 1/6] drivers: phy: add generic PHY framework

2013-04-02 Thread Kishon Vijay Abraham I
On Tuesday 02 April 2013 09:10 PM, Stephen Warren wrote: On 04/02/2013 02:37 AM, Kishon Vijay Abraham I wrote: Hi, On Thursday 28 March 2013 09:15 PM, Stephen Warren wrote: On 03/27/2013 11:43 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to

Re: [PATCH v4 0/6] Generic PHY Framework

2013-04-02 Thread Kishon Vijay Abraham I
Hi, On Friday 29 March 2013 12:01 AM, David Miller wrote: You really need to CC: net...@vger.kernel.org rather than me explicitly on this patch set. I was CC'ing whatever get_maintainer shows. I'll make sure to CC net...@vger.kernel.org though there's nothing related to network in this patc

Re: [PATCH v4 0/6] Generic PHY Framework

2013-04-02 Thread Kishon Vijay Abraham I
Hi, On Wednesday 03 April 2013 12:01 PM, David Miller wrote: From: Kishon Vijay Abraham I Date: Wed, 3 Apr 2013 11:29:53 +0530 Hi, On Friday 29 March 2013 12:01 AM, David Miller wrote: You really need to CC: net...@vger.kernel.org rather than me explicitly on this patch set. I was

[PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-03 Thread Kishon Vijay Abraham I
framework will break OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/omap-usb2.c | 48 +++ 1 file changed, 48 insertions(+) diff --git a/drivers/usb/phy/omap-usb2.c

[PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Kishon Vijay Abraham I
or dt binding is can be found at Documentation/devicetree/bindings/phy/phy-bindings.txt Signed-off-by: Kishon Vijay Abraham I --- Documentation/ABI/testing/sysfs-class-phy | 15 + .../devicetree/bindings/phy/phy-bindings.txt | 67 +++ Documentation/ph

[PATCH v5 0/6] Generic PHY Framework

2013-04-03 Thread Kishon Vijay Abraham I
t and phy_bind_mutex). * Changed the sysfs entry name from *bind* to *phy_bind*. Changes from v1: * Added Documentation for the PHY framework * Added few more APIs mostly w.r.t devres * Modified omap-usb2 and twl4030 to make use of the new framework Did USB enumeration testing in panda and beagle. Kisho

[PATCH v5 4/6] ARM: OMAP: USB: Add phy binding information

2013-04-03 Thread Kishon Vijay Abraham I
In order for controllers to get PHY in case of non dt boot, the phy binding information should be added in the platform specific initialization code using phy_bind. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/mach-omap2/usb-musb.c |7 ++- 1 file changed, 6 insertions(+), 1

[PATCH v5 6/6] usb: musb: omap2430: use the new generic PHY framework

2013-04-03 Thread Kishon Vijay Abraham I
te state machine to handle otg, these can be moved out of xceiv and then we can start using the generic PHY framework. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/musb_core.h |2 ++ drivers/usb/musb/omap2430.c | 22 -- 2 files changed, 18 insertio

[PATCH v5 3/6] usb: otg: twl4030: use the new generic PHY framework

2013-04-03 Thread Kishon Vijay Abraham I
completely will break OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/otg/twl4030-usb.c | 37 + 1 file changed, 37 insertions(+) diff --git a/drivers/usb/otg/twl4030

[PATCH v5 5/6] ARM: dts: omap: update usb_otg_hs data

2013-04-03 Thread Kishon Vijay Abraham I
-bindings.txt Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/omap-usb.txt |5 + Documentation/devicetree/bindings/usb/usb-phy.txt |6 ++ arch/arm/boot/dts/omap3.dtsi |2 ++ arch/arm/boot/dts/omap4.dtsi

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Kishon Vijay Abraham I
Hi, On Wednesday 03 April 2013 07:12 PM, Felipe Balbi wrote: On Wed, Apr 03, 2013 at 06:23:49PM +0530, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-03 Thread Kishon Vijay Abraham I
Hi, On Wednesday 03 April 2013 07:57 PM, Felipe Balbi wrote: hi, On Wed, Apr 03, 2013 at 07:48:42PM +0530, Kishon Vijay Abraham I wrote: +struct phy *of_phy_xlate(struct phy *phy, struct of_phandle_args *args) +{ + return phy; +} +EXPORT_SYMBOL_GPL(of_phy_xlate); so you get a PHY and

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-04 Thread Kishon Vijay Abraham I
Hi, On Wednesday 03 April 2013 09:17 PM, Felipe Balbi wrote: Hi, On Wed, Apr 03, 2013 at 08:02:52PM +0530, Kishon Vijay Abraham I wrote: + ret = -EINVAL; + goto err0; + } + + if (!phy_class) + phy_core_init(); why don't you setu

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-04 Thread Kishon Vijay Abraham I
Hi, On Thursday 04 April 2013 03:16 AM, Sylwester Nawrocki wrote: On 04/03/2013 02:53 PM, Kishon Vijay Abraham I wrote: . . . . diff --git a/Documentation/phy.txt b/Documentation/phy.txt new file mode 100644 index 000..7785ec0 --- /dev/null +++ b/Documentation/phy.txt @@ -0,0 +1,113

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-04 Thread Kishon Vijay Abraham I
Hi, On Thursday 04 April 2013 04:11 PM, Sylwester Nawrocki wrote: Hi, On 04/04/2013 11:21 AM, Kishon Vijay Abraham I wrote: On Thursday 04 April 2013 03:16 AM, Sylwester Nawrocki wrote: On 04/03/2013 02:53 PM, Kishon Vijay Abraham I wrote: +4. Getting a reference to the PHY + +Before the

Re: [PATCH] ARM: OMAP4: PM: fix PM regression introduced by recent clock cleanup

2013-04-08 Thread Kishon Vijay Abraham I
Hi, On Wednesday 13 February 2013 01:58 AM, Paul Walmsley wrote: Commit 17b7e7d33530e2bbd3bdc90f4db09b91cfdde2bb ("ARM: OMAP4: clock/hwmod data: start to remove some IP block control "clocks"") introduced a regression preventing the L3INIT clockdomain of OMAP4 systems from entering idle. This

Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework

2013-04-08 Thread Kishon Vijay Abraham I
Hi, On Thursday 04 April 2013 05:24 AM, Stephen Warren wrote: On 04/03/2013 06:53 AM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. To

[PATCH] ARM: OMAP4: HWMOD: make 'ocp2scp_usb_phy_phy_48m" as the main clock

2013-04-09 Thread Kishon Vijay Abraham I
or ocp2scp. Cc: Keerthy Cc: BenoƮt Cousson Cc: Paul Walmsley Signed-off-by: Kishon Vijay Abraham I --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c b/arch/arm/

Re: [PATCH] ARM: OMAP4: HWMOD: make 'ocp2scp_usb_phy_phy_48m" as the main clock

2013-04-09 Thread Kishon Vijay Abraham I
Hi, On Tuesday 09 April 2013 02:24 PM, Benoit Cousson wrote: Hi Kishon, On 04/09/2013 10:28 AM, Kishon Vijay Abraham I wrote: commit 92702d (ARM: OMAP4: PM: fix PM regression introduced by recent clock cleanup) makes the 'ocp2scp_usb_phy_phy_48m' as optional functional clo

Re: [PATCH v2] ARM: OMAP4: hwmod data: make 'ocp2scp_usb_phy_phy_48m" as the main clock

2013-04-12 Thread Kishon Vijay Abraham I
Hi, On Thursday 11 April 2013 01:11 AM, Paul Walmsley wrote: From: Kishon Vijay Abraham I Commit 92702df3570e ("ARM: OMAP4: PM: fix PM regression introduced by recent clock cleanup") makes the 'ocp2scp_usb_phy_phy_48m' as optional functional clock causing regression in

Re: [PATCH v3 0/6] Generic PHY Framework

2013-04-15 Thread Kishon Vijay Abraham I
Hi, On Monday 15 April 2013 03:50 PM, Grant Likely wrote: On Wed, 20 Mar 2013 14:41:59 +0530, Kishon Vijay Abraham I wrote: Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with

Re: [PATCH v3 1/6] drivers: phy: add generic PHY framework

2013-04-15 Thread Kishon Vijay Abraham I
Hi, On Monday 15 April 2013 05:04 PM, Grant Likely wrote: On Wed, 20 Mar 2013 14:42:00 +0530, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using

Re: [PATCH v3 0/6] Generic PHY Framework

2013-04-15 Thread Kishon Vijay Abraham I
Hi, On Monday 15 April 2013 05:56 PM, Grant Likely wrote: On Mon, 15 Apr 2013 16:06:37 +0530, Kishon Vijay Abraham I wrote: Hi, On Monday 15 April 2013 03:50 PM, Grant Likely wrote: On Wed, 20 Mar 2013 14:41:59 +0530, Kishon Vijay Abraham I wrote: Added a generic PHY framework that

Re: [PATCH v3 1/6] drivers: phy: add generic PHY framework

2013-04-16 Thread Kishon Vijay Abraham I
Hi, On Tuesday 16 April 2013 01:20 AM, Grant Likely wrote: On Mon, 15 Apr 2013 17:56:10 +0530, Kishon Vijay Abraham I wrote: Hi, On Monday 15 April 2013 05:04 PM, Grant Likely wrote: On Wed, 20 Mar 2013 14:42:00 +0530, Kishon Vijay Abraham I wrote: The PHY framework provides a set of

Re: [PATCH v3 01/11] usb: phy: Add APIs for runtime power management

2013-04-18 Thread Kishon Vijay Abraham I
On Tuesday 02 April 2013 06:10 PM, Vivek Gautam wrote: Hi, On Tue, Apr 2, 2013 at 5:40 PM, Felipe Balbi wrote: Hi, On Tue, Apr 02, 2013 at 04:04:01PM +0530, Vivek Gautam wrote: On Mon, Apr 01, 2013 at 07:24:00PM +0530, Vivek Gautam wrote: Adding APIs to handle runtime power management on

Re: [PATCH v3 1/6] drivers: phy: add generic PHY framework

2013-04-21 Thread Kishon Vijay Abraham I
Hi, On Friday 19 April 2013 02:39 PM, Grant Likely wrote: On Tue, 16 Apr 2013 15:48:07 +0530, Kishon Vijay Abraham I wrote: On Tuesday 16 April 2013 01:20 AM, Grant Likely wrote: On Mon, 15 Apr 2013 17:56:10 +0530, Kishon Vijay Abraham I wrote: On Monday 15 April 2013 05:04 PM, Grant

Re: Multiple issues with omap4 panda es in linux next

2013-04-22 Thread Kishon Vijay Abraham I
Hi, On Friday 19 April 2013 10:43 PM, Tony Lindgren wrote: Hi all, Here's a list of breakage I've noticed so far while trying to use linux next on my pandaboard es. Probably similar issues exist on other boards as well. Ideally we would not have any breakage by the merge window, so let's try t

[PATCH] ARM: OMAP4: change the device names in usb_bind_phy

2013-04-22 Thread Kishon Vijay Abraham I
Vijay Abraham I --- Tested in OMAP4 PANDA. arch/arm/mach-omap2/board-4430sdp.c|2 +- arch/arm/mach-omap2/board-omap4panda.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/board-4430sdp.c b/arch/arm/mach-omap2/board-4430sdp.c index 00d7290

Re: Multiple issues with omap4 panda es in linux next

2013-04-23 Thread Kishon Vijay Abraham I
Hi Tony, On Monday 22 April 2013 11:33 PM, Tony Lindgren wrote: * Kishon Vijay Abraham I [130422 01:46]: Hi, On Friday 19 April 2013 10:43 PM, Tony Lindgren wrote: Hi all, Here's a list of breakage I've noticed so far while trying to use linux next on my pandaboard es. Probab

[PATCH v6 3/9] usb: phy: twl4030: use the new generic PHY framework

2013-04-29 Thread Kishon Vijay Abraham I
be completely removed because otg is intertwined with phy and moving to the new framework completely will break otg. Once we have a separate otg state machine, we can get rid of the usb phy library. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/phy-twl4030-usb.c | 44

[PATCH v6 1/9] drivers: phy: add generic PHY framework

2013-04-29 Thread Kishon Vijay Abraham I
Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/phy/phy-bindings.txt | 66 +++ Documentation/phy.txt | 123 + MAINTAINERS|7 + drivers/Kconfig|2 + drivers

[PATCH v6 4/9] usb: phy: twl4030: twl4030 shouldn't be subsys_initcall

2013-04-29 Thread Kishon Vijay Abraham I
Changed the inticall from subsys_initcall to module_init for twl4030-usb. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/phy-twl4030-usb.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/usb/phy/phy-twl4030-usb.c b/drivers/usb/phy/phy

[PATCH v6 2/9] usb: phy: omap-usb2: use the new generic PHY framework

2013-04-29 Thread Kishon Vijay Abraham I
OTG. Once we have a separate OTG state machine, we can get rid of the USB PHY library. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/phy-omap-usb2.c | 36 1 file changed, 36 insertions(+) diff --git a/drivers/usb/phy/phy-omap-usb2.c b/drivers

[PATCH v6 0/9] Generic PHY Framework

2013-04-29 Thread Kishon Vijay Abraham I
ation testing in panda and beagle. Kishon Vijay Abraham I (9): drivers: phy: add generic PHY framework usb: phy: omap-usb2: use the new generic PHY framework usb: phy: twl4030: use the new generic PHY framework usb: phy: twl4030: twl4030 shouldn't be subsys_initcall ARM: OMAP: USB: Add p

[PATCH v6 6/9] ARM: dts: omap: update usb_otg_hs data

2013-04-29 Thread Kishon Vijay Abraham I
-bindings.txt Signed-off-by: Kishon Vijay Abraham I --- Documentation/devicetree/bindings/usb/omap-usb.txt |5 + Documentation/devicetree/bindings/usb/usb-phy.txt |6 ++ arch/arm/boot/dts/omap3.dtsi |2 ++ arch/arm/boot/dts/omap4.dtsi

[PATCH v6 7/9] usb: musb: omap2430: use the new generic PHY framework

2013-04-29 Thread Kishon Vijay Abraham I
ere is a separate state machine to handle otg, these can be moved out of xceiv and then we can start using the generic PHY framework. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/musb_core.c |1 + drivers/usb/musb/musb_core.h |3 +++ drivers/usb/musb/omap2430.c

[PATCH v6 9/9] usb: phy: twl4030-usb: remove *set_suspend* and *phy_init* ops

2013-04-29 Thread Kishon Vijay Abraham I
Now that twl4030-usb is adapted to the new generic PHY framework, *set_suspend* and *phy_init* ops can be removed from twl4030-usb driver. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/phy-twl4030-usb.c | 55 - 1 file changed, 12 insertions

[PATCH v6 8/9] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2

2013-04-29 Thread Kishon Vijay Abraham I
Now that omap-usb2 is adapted to the new generic PHY framework, *set_suspend* ops can be removed from omap-usb2 driver. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/phy-omap-usb2.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/usb/phy/phy

[PATCH v6 5/9] ARM: OMAP: USB: Add phy binding information

2013-04-29 Thread Kishon Vijay Abraham I
In order for controllers to get PHY in case of non dt boot, the phy binding information (phy device name) should be added in the platform data of the controller. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/mach-omap2/usb-musb.c |6 +- include/linux/usb/musb.h |3 +++ 2

Re: [PATCH] ARM: dts: OMAP: Add usb_otg and glue data to OMAP3+ boards

2013-05-14 Thread Kishon Vijay Abraham I
specific interrupt controller, not GIC. Fix this by specifying the interrupt following the TI INTC binding. Without this fix MUSB won't work as it is trying to use irq0 instead of irq92. Signed-off-by: Tony Lindgren Tested in beagleboard-xm Tested-by: Kishon Vijay Abraham I --- a/arc

[PATCH] ARM: dts: omap3 beagle: Add usb otg hs dt data

2013-05-14 Thread Kishon Vijay Abraham I
Added board specific dt data for omap3 beagle in omap3-beagle.dts file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap3-beagle.dts |7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts index

Re: [PATCH] ARM: OMAP4: change the device names in usb_bind_phy

2013-05-16 Thread Kishon Vijay Abraham I
Hi, On Thursday 16 May 2013 09:50 PM, Tony Lindgren wrote: * Tomi Valkeinen [130516 09:11]: On 16/05/13 18:58, Tony Lindgren wrote: * Tomi Valkeinen [130515 03:59]: Just checking.. Do you have CONFIG_OMAP_OCP2SCP=y in your .config? Sounds like the some transceivers should depend on that for

[RFC PATCH 4/4] arm: omap: remove using usb_bind_phy for binding musb and phy

2013-05-17 Thread Kishon Vijay Abraham I
Now that MUSB for OMAP started using devm_usb_get_phy_by_name which does not require PHY library to already have the binding information, removed usb_bind_phy calls that binds the MUSB controller with the PHY from the board files. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/mach-omap2

[RFC PATCH 3/4] usb: musb: omap: use the new API to get PHY reference by label

2013-05-17 Thread Kishon Vijay Abraham I
After the devices are created using PLATFORM_DEVID_AUTO, devm_usb_get_phy_dev and usb_get_phy_dev can't be used reliably as it relies on the device_names passed in usb_bind_phy. So used the new API devm_usb_get_phy_by_name to get the PHY reference. Signed-off-by: Kishon Vijay Abra

[RFC PATCH 1/4] arm: omap: Add phy binding info for musb in plat data

2013-05-17 Thread Kishon Vijay Abraham I
In order for controllers to get PHY in case of non dt boot, the phy binding information (phy label) should be added in the platform data of the controller. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/mach-omap2/usb-musb.c |6 +- include/linux/usb/musb.h |3 +++ 2 files

[RFC PATCH 2/4] usb: phy: add a new API to get PHY ref by label

2013-05-17 Thread Kishon Vijay Abraham I
igned-off-by: Kishon Vijay Abraham I --- drivers/usb/phy/phy.c | 78 +++ include/linux/usb/phy.h | 16 ++ 2 files changed, 94 insertions(+) diff --git a/drivers/usb/phy/phy.c b/drivers/usb/phy/phy.c index a9984c7..0dfdc38 100644 --- a/driver

Re: [PATCH v6 0/9] Generic PHY Framework

2013-05-20 Thread Kishon Vijay Abraham I
Hi, On Monday 29 April 2013 03:33 PM, Kishon Vijay Abraham I wrote: Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle. This framework will be of use

Re: [PATCH 6/6] ARM: OMAP2+: Remove omap4 ocp2scp pdata

2013-05-21 Thread Kishon Vijay Abraham I
On Saturday 18 May 2013 12:48 AM, Tony Lindgren wrote: This is omap4+ only and no longer needed as omap4+ can be booted using device tree. Also remove the related pdata handling from the driver and the now unneeded platform_data/omap_ocp2scp.h. Cc: Kishon Vijay Abraham I Cc: Felipe Balbi Cc

[PATCH v5 2/3] extcon: Palmas Extcon Driver

2013-05-24 Thread Kishon Vijay Abraham I
re Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * Author: Graeme Gregory + * Author: Kishon Vijay Abraham I + * + * Based on twl6030_usb.c + * + * Author: Hema HK + * + * This program is distributed in the hope that it will be useful, + * but WITHOU

[PATCH 1/3] drivers: regulator: palmas: add an API to set/clear the switch bit on SMPS10

2013-05-24 Thread Kishon Vijay Abraham I
From: Graeme Gregory Added an API to set/clear the switch bit on SMPS10 which can be used by palmas usb. The switch bit should be set in order for palmas to supply VBUS and is needed when OMAP is acting as USB HOST. Signed-off-by: Graeme Gregory Signed-off-by: Kishon Vijay Abraham I

[PATCH 3/3] usb: dwc3: use extcon fwrk to receive connect/disconnect notification

2013-05-24 Thread Kishon Vijay Abraham I
Modified dwc3-omap to receive connect and disconnect notification using extcon framework. Also did the necessary cleanups required after adapting to extcon framework. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/dwc3-omap.c | 80

<    3   4   5   6   7   8   9   10   11   12   >