Re: [PATCH v3 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-13 Thread Lee Jones
16 -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH v4 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2014-11-18 Thread Lee Jones
+ 2 files changed, 6 insertions(+), 2 deletions(-) Code looks better now. Acked-by: Lee Jones lee.jo...@linaro.org What's the plan for this series? diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index d877e777cce6..110038859a8d 100644 --- a/drivers/mfd

Re: [PATCH 13/14] mfd: twl-core: Constify struct regmap_config and reg_default array

2015-01-20 Thread Lee Jones
irq_base = 0; int status; unsignedi, num_slaves; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list

Re: [PATCH 14/14] mfd: twl6040: Constify struct regmap_config and reg_default array

2015-01-20 Thread Lee Jones
regmap_config twl6040_regmap_config = { .reg_bits = 8, .val_bits = 8, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2015-01-20 Thread Lee Jones
: Acked-by: Lee Jones lee.jo...@linaro.org Can this patch be applied on its own? diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index 467c80e1c4ae..e4e4b22eebc9 100644 --- a/drivers/mfd/ti_am335x_tscadc.c +++ b/drivers/mfd/ti_am335x_tscadc.c @@ -68,12 +68,6 @@ static

Re: [PATCH 12/14] mfd: tps65218: Constify struct regmap_config

2015-01-20 Thread Lee Jones
, .cache_type = REGCACHE_RBTREE, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org

Re: [PATCH 11/14] mfd: tps65217: Constify struct regmap_config

2015-01-20 Thread Lee Jones
+145,7 @@ int tps65217_clear_bits(struct tps65217 *tps, unsigned int reg, } EXPORT_SYMBOL_GPL(tps65217_clear_bits); -static struct regmap_config tps65217_regmap_config = { +static const struct regmap_config tps65217_regmap_config = { .reg_bits = 8, .val_bits = 8, -- Lee

Re: [PATCH 6/7] mfd: menelaus: make vcore and regulator controls internal

2015-01-20 Thread Lee Jones
2) +#define EN_DC2_SLEEP (1 1) +#define EN_VC_SLEEP (1 0) Better to use the BIT() macro for this kind of stuff. Please take this opportunity to use it. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs

Re: [PATCH 1/7] mfd: menelaus: delete omap_has_menelaus

2015-01-20 Thread Lee Jones
) defined(CONFIG_MENELAUS) -#define omap_has_menelaus() 1 -#else -#define omap_has_menelaus() 0 -#endif - #endif -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from

Re: [PATCH 2/7] mfd: menelaus: drop support for SW controller VCORE

2015-01-20 Thread Lee Jones
int mV); extern int menelaus_set_vcore_hw(unsigned int roof_mV, unsigned int floor_mV); #define EN_VPLL_SLEEP(1 7) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe

Re: [PATCH 5/7] mfd: menelaus: delete platform data support

2015-01-20 Thread Lee Jones
), void *data); extern void menelaus_unregister_mmc_callback(void); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 6/7] mfd: menelaus: make vcore and regulator controls internal

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Lee Jones wrote: On Sat, 27 Dec 2014, Aaro Koskinen wrote: Make vcore and regulator control functions internal to the driver. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/mfd/menelaus.c | 13 +++-- include/linux/mfd/menelaus.h

Re: [PATCH 7/7] mfd: menelaus: use macro for magic number

2015-01-20 Thread Lee Jones
)) + if (err VCORE_CTRL1_HW_NSW) menelaus-vcore_hw_mode = 1; else menelaus-vcore_hw_mode = 0; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from

Re: [PATCH 0/7] Menelaus cleanup for DT, phase 1

2015-01-20 Thread Lee Jones
Documentation/devicetree/bindings/mfd/menelaus.txt Scrap that. Looks like I can't apply the other patches without 03/07. Please sort this out with Felipe and re-submit. Don't forget to apply my Ack to the patches I said I applied. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open

Re: [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, R, Vignesh wrote: On 1/20/2015 5:23 PM, Lee Jones wrote: On Wed, 07 Jan 2015, Vignesh R wrote: In one shot mode, sequencer automatically disables all enabled steps at the end of each cycle. (both ADC steps and TSC steps) Hence these steps need not be saved

Re: [PATCH 2/5] mfd: tps65218: make INT1 our status_base register

2015-01-18 Thread Lee Jones
j-keer...@ti.com Cc: Lee Jones lee.jo...@linaro.org Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/mfd/tps65218.c | 1 + 1 file changed, 1 insertion(+) Sorry for the delay. It's difficult to get a WiFi signal 2000m up in an Austrian mountain. :) Applied now, thanks. diff --git

Re: [PATCH 1/5] mfd: tps65218: make INT[12] and STATUS registers volatile

2015-01-18 Thread Lee Jones
be able to clear the interrupt, which will cause our IRQ line to be disabled due to IRQ throttling. Fixes: 44b4dc6 mfd: tps65218: Add driver for the TPS65218 PMIC Cc: sta...@vger.kernel.org # v3.15+ Cc: Keerthy j-keer...@ti.com Cc: Lee Jones lee.jo...@linaro.org Signed-off-by: Felipe Balbi

Re: [PATCH] mfd: menelaus: rmove incorrect __exit markups

2015-03-10 Thread Lee Jones
= menelaus_id, }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 3/3] mfd: menelaus: use macro for magic number

2015-03-30 Thread Lee Jones
)) + if (err VCORE_CTRL1_HW_NSW) menelaus-vcore_hw_mode = 1; else menelaus-vcore_hw_mode = 0; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from

Re: [PATCH 2/3] mfd: menelaus: drop support for SW controller VCORE

2015-03-30 Thread Lee Jones
int mV); extern int menelaus_set_vcore_hw(unsigned int roof_mV, unsigned int floor_mV); #define EN_VPLL_SLEEP(1 7) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe

Re: [PATCH 1/3] mfd: menelaus: delete omap_has_menelaus

2015-03-30 Thread Lee Jones
) defined(CONFIG_MENELAUS) -#define omap_has_menelaus() 1 -#else -#define omap_has_menelaus() 0 -#endif - #endif -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from

Re: [PATCH] mfd: twl6040: Remove wrong and unneeded platform:twl6040 modalias

2015-03-30 Thread Lee Jones
); MODULE_AUTHOR(Misael Lopez Cruz misael.lo...@ti.com); MODULE_AUTHOR(Jorge Eduardo Candelaria jorge.candela...@ti.com); MODULE_LICENSE(GPL); -MODULE_ALIAS(platform:twl6040); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook

Re: [PATCH 21/35 linux-next] mfd: constify of_device_id array

2015-03-23 Thread Lee Jones
osc_off_idle = { .board_config = osc_off_rconfig, }; -static struct of_device_id twl4030_power_of_match[] = { +static const struct of_device_id twl4030_power_of_match[] = { { .compatible = ti,twl4030-power, }, -- Lee Jones Linaro STMicroelectronics

Re: [PATCH v6 3/6] mfd: ti_am335x_tscadc: Remove unwanted reg_se_cache save

2015-02-24 Thread Lee Jones
/ti_am335x_tscadc.h @@ -128,6 +128,7 @@ /* Sequencer Status */ #define SEQ_STATUS BIT(5) +#define CHARGE_STEP 0x11 #define ADC_CLK 300 #define TOTAL_STEPS 16 -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software

Re: [PATCH 04/15] twl4030_charger: use runtime_pm to keep usb phy active while charging.

2015-02-24 Thread Lee Jones
reference to the USB phy whenever the charger wants to use it as a current source. So this patch reverts the above commit, and adds the necessary runtime_pm calls. Signed-off-by: NeilBrown ne...@suse.de --- drivers/mfd/twl-core.c |9 - Acked-by: Lee Jones lee.jo

Re: [PATCH] mfd: Constify regmap and irq configuration data

2015-04-28 Thread Lee Jones
*da9055); -extern struct regmap_config da9055_regmap_config; +extern const struct regmap_config da9055_regmap_config; #endif /* __DA9055_CORE_H */ -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter

Re: [RFC v1 08/25] mfd: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc

2015-05-20 Thread Lee Jones
as this has been properly tested: Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c index 5991faddd3c6..e5f4ffaa5414 100644 --- a/drivers/mfd/ezx-pcap.c +++ b/drivers/mfd/ezx-pcap.c @@ -207,7 +207,7 @@ static void pcap_isr_work(struct

Re: [PATCH 09/15] mfd: kill off set_irq_flags usage

2015-06-11 Thread Lee Jones
and this has been maintained although it is not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring r...@kernel.org Cc: Samuel Ortiz sa...@linux.intel.com Cc: Lee Jones lee.jo...@linaro.org Cc: Linus Walleij linus.wall

Re: [PATCH 16/27] mfd: Export OF module alias information in missing drivers

2015-08-10 Thread Lee Jones
, }, {} }; +MODULE_DEVICE_TABLE(of, of_tps65218_match_table); static int tps65218_probe(struct i2c_client *client, const struct i2c_device_id *ids) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow

Re: [PATCH v4 1/2] extcon: palmas: Support GPIO based USB ID detection

2015-08-10 Thread Lee Jones
/extcon/extcon-usb-gpio.c | 1 + include/linux/mfd/palmas.h | 7 ++ 4 files changed, 126 insertions(+), 16 deletions(-) Acked-by: Lee Jones lee.jo...@linaro.org diff --git a/Documentation/devicetree/bindings/extcon/extcon-palmas.txt b/Documentation

Re: [PATCH v3] mfd: kill off set_irq_flags usage

2015-07-27 Thread Lee Jones
and this has been maintained although it is not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring r...@kernel.org Cc: Samuel Ortiz sa...@linux.intel.com Acked-by: Lee Jones lee.jo...@linaro.org Acked-by: Linus Walleij

Re: [PATCH v2 3/3] [media] include/media: move platform_data to linux/platform_data/media

2015-11-16 Thread Lee Jones
t; drivers/media/platform/soc_camera/omap1_camera.c | 2 +- > drivers/media/platform/soc_camera/soc_camera_platform.c | 2 +- > drivers/media/platform/timblogiw.c| 2 +- > drivers/media/radio/radio-timb.c | 2

Re: [PATCH v2 1/3] iio:adc: add iio driver for Palmas (twl6035/7) gpadc

2015-10-13 Thread Lee Jones
gt; drivers/iio/adc/Kconfig| 9 + > > drivers/iio/adc/Makefile | 1 + > > drivers/iio/adc/palmas_gpadc.c | 818 > > + > > include/linux/mfd/palmas.h | 75 ++-- Acked-by: Lee Jones <lee.jo...@linaro.org> > >

Re: [PATCH] mfd: Drop owner assignment from i2c_drivers

2015-07-10 Thread Lee Jones
, .of_match_table = of_match_ptr(wm8994_of_match), }, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 3/3] mfd: Add battery charger as subdevice to the tps65217.

2015-09-19 Thread Lee Jones
t;, > .of_compatible = "ti,tps65217-bl", > }, > + { > + .name = "tps65217-charger", > + .of_compatible = "ti,tps65217-charger", > + }, > }; > > /** -- Lee Jones Linaro STMicroelectronics Landing Team Lead L

Re: [PATCH 1/2] mfd: twl6040: Fix deferred probe handling for clk32k

2015-09-19 Thread Lee Jones
> Fixes: 68bab8662f49 ("mfd: twl6040: Optional clk32k clock handling") > Cc: Benoit Cousson <bcous...@baylibre.com> > Cc: Dr. H. Nikolaus Schaller <h...@goldelico.com> > Cc: Grazvydas Ignotas <nota...@gmail.com> > Cc: Lee Jones <lee.jo...@linar

Re: [PATCH 004/182] gpio: generic: factor into gpio_chip struct

2015-12-10 Thread Lee Jones
. > > Modify all users to handle the change and use a struct > gpio_chip directly. And while we're at it: replace all > container_of() dereferencing by gpiochip_get_data() and > registering the gpio_chip with gpiochip_add_data(). > > Cc: a...@kernel.org > Cc: Lee Jones <le

Re: [PATCH] regulator: tps65218: add support for LS3 current regulator

2015-11-26 Thread Lee Jones
com> > Cc: Liam Girdwood <lgirdw...@gmail.com> > Cc: Mark Brown <broo...@kernel.org> > Cc: Samuel Ortiz <sa...@linux.intel.com> > Cc: Lee Jones <lee.jo...@linaro.org> > --- > drivers/regulator/tps65218-regulator.c | 137 > +----

<    1   2   3