Re: [PATCH] select NOP_USB_XCEIV for OMAP4

2010-06-23 Thread Sergei Shtylyov
Hello. David Anders wrote: Add select statement to force selection of NOP_USB_XCEIV for OMAP4. Signed-off-by: David Anders [...] diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig index cfd38ed..e4624bc 100644 --- a/drivers/usb/musb/Kconfig +++ b/drivers/usb/musb/Kconfig @@

Re: [PATCH] select NOP_USB_XCEIV for OMAP4

2010-06-23 Thread Sergei Shtylyov
Hello. Koen Kooi wrote: Add select statement to force selection of NOP_USB_XCEIV for OMAP4. Signed-off-by: David Anders --- drivers/usb/musb/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig index cfd38ed..e

Re: [PATCH 4/8] USB: musb: suppress warning about unused flags

2010-06-24 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: From: Jon Povey Wrap flags with uninitialized_var() to suppress this: drivers/usb/musb/cppi_dma.c:1158: warning: 'flags' may be used uninitialized in this function Signed-off-by: Jon Povey Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/cppi_dma.c |

Re: [PATCH 3/8] musb: fix compilation warning in host only mode

2010-06-24 Thread Sergei Shtylyov
Hello. Gupta, Ajay Kumar wrote: +#ifdef CONFIG_USB_MUSB_HDRC_HCD + void __iomem*mbase = musb->mregs; +#endif then you add another ifdef to this file, which is already insane. I'd rather see you either keep the local variables and just fix what needs to be fixed, or use musb->mr

Re: [PATCH 3/4]usb: musb: HWMOD database structures addition for OMAP3

2010-06-28 Thread Sergei Shtylyov
Hello. Hema HK wrote: OMAP3 hwmod data stuctures are populated with base address, L3 and L4 interface clocks, IRQs,and sysconfig register details. Signed-off-by: Hema HK Cc: Felipe Balbi ,t...@atomide.com [...] @@ -90,6 +99,37 @@ static struct omap_hwmod_ocp_if omap3xxx .user =

Re: [PATCH 4/8] USB: musb: suppress warning about unused flags

2010-06-28 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: I think the problem here is different. First of all, an IRQ of number 0 is valid It's not valid for this driver. it's not valid for the boards we have available so far. And the current driver doesn't accept it as a valid IRQ. WBR, Sergei -- To unsubscr

Re: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-29 Thread Sergei Shtylyov
Hello. Hema HK wrote: From: Hema HK I think the patch description has clarity issues... Changed the musb driver to use omap_build_device api instead of I don't see where are you changing the MUSB driver. platform_device_registration. Why underscores here? The device specif

Re: [PATCH resend 2/3] musb: add musb support for AM35x

2010-07-02 Thread Sergei Shtylyov
Hello. Ajay Kumar Gupta wrote: AM35x has musb interface and uses CPPI4.1 DMA engine. Current patch supports only PIO mode. DMA support can be added later once basic CPPI4.1 DMA patch is accepted. Signed-off-by: Ajay Kumar Gupta [...] diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/mus

Re: [PATCH resend 2/3] musb: add musb support for AM35x

2010-07-03 Thread Sergei Shtylyov
Hello. Gupta, Ajay Kumar wrote: +{ + unsigned long timeout = jiffies + msecs_to_jiffies(100); + u32 devconf2; + + /* +* Start the on-chip PHY and its PLL. +*/ + devconf2 = omap_ctrl_readl(AM35XX_CONTROL_DEVCONF2); + + devconf2 &= ~(CONF2_RESET | CON

Re: [PATCH resend 1/3] AM35x: Add musb support

2010-07-05 Thread Sergei Shtylyov
Hello. Tony Lindgren wrote: AM35x has musb interface (version 1.8) and uses CPPI41 DMA engine. It has USB phy built inside the IP itself. Also added ARCH_AM35x which is required to differentiate musb ips between OMAP3x and AM35x. This config would be used for below purposes, - Select a

Re: [PATCH] usb: musb: tusb6010: fix compile error with n8x0_defconfig

2010-07-05 Thread Sergei Shtylyov
Hello. felipe.ba...@nokia.com wrote: From: Felipe Balbi Drop the unnecessary empty stubs in tusb6010.c and avoid But will this compile on other OMAPs? a compile error when building kernel for n8x0. I wonder what kind of compile error... Signed-off-by: Felipe Balbi WBR, Serg

Re: [PATCH resend 1/3] AM35x: Add musb support

2010-07-05 Thread Sergei Shtylyov
Hello. Tony Lindgren wrote: AM35x has musb interface (version 1.8) and uses CPPI41 DMA engine. It has USB phy built inside the IP itself. Also added ARCH_AM35x which is required to differentiate musb ips between OMAP3x and AM35x. This config would be used for below purposes, - Select

Re: [PATCH resend 1/3] AM35x: Add musb support

2010-07-05 Thread Sergei Shtylyov
Hello. Tony Lindgren wrote: I think Ajay has explained why it's needed. The option is necessary in one or another form. It's not needed for omaps, we can already build in support for omap2, omap3 and omap4 into the same kernel binary. Don't see how it hinders that. Not with AM35x

Re: [PATCH] usb: musb: Offmode fix for idle path

2010-07-08 Thread Sergei Shtylyov
Hello. Hema HK wrote: With OMAP coreoff support usb was not functional as context was getting lost after wakeup from coreoff. And also usb was blocking the coreoff USB is an acronym. after loading the gadget driver even with no cable connected sometimes. Added the conext save/restore

Re: [PATCH V2 6/8] usb: musb: Offmode fix for idle path

2010-08-07 Thread Sergei Shtylyov
Hello. Hema HK wrote: With OMAP core-off support musb was not functional as context was getting lost after wakeup from core-off. And also musb was blocking the core-off after loading the gadget driver even with no cable connected sometimes. Added the conext save/restore api in the platform

Re: [PATCH 8/8 ]usb : musb:Using runtime pm apis for musb.

2010-08-07 Thread Sergei Shtylyov
Hello. Hema HK wrote: Calling runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() for enabling/disabling the clocks,sysconfig settings. used omap_hwmod_enable_wakeup & omap_hwmod_disable_wakeup apis to set/clear the wakeup enable bit. Also need to put the USB in force standby and

Re: [PATCH V2 6/8] usb: musb: Offmode fix for idle path

2010-08-10 Thread Sergei Shtylyov
Hello. Kalliguddi, Hema wrote: With OMAP core-off support musb was not functional as context was getting lost after wakeup from core-off. And also musb was blocking the core-off after loading the gadget driver even with no cable connected sometimes. Added the conext save/restore api in the

Re: [PATCH V2 6/8] usb: musb: Offmode fix for idle path

2010-08-10 Thread Sergei Shtylyov
Hello. Kalliguddi, Hema wrote: Hema, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Hema HK Sent: Friday, August 06, 2010 10:57 PM To: linux-...@vger.kernel.org; linux-omap@vger.kernel.org Cc: Kalliguddi, Hema; Mankad

Re: [PATCH 8/8 ]usb : musb:Using runtime pm apis for musb.

2010-08-11 Thread Sergei Shtylyov
Hello. I wrote: Calling runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() for enabling/disabling the clocks,sysconfig settings. used omap_hwmod_enable_wakeup & omap_hwmod_disable_wakeup apis to set/clear the wakeup enable bit. Also need to put the USB in force standby and for

Re: [PATCH 3/6] OMAP3: PM: ensure IO wakeups are properly disabled

2010-08-13 Thread Sergei Shtylyov
Hello. Tony Lindgren wrote: From: Kevin Hilman Commit 5a5f561 (convert OMAP3 PRCM macros to the _SHIFT/_MASK suffixes) mistakenly removed the check for PER when disabling the IO chain. During idle, if the PER powerdomain transitions and CORE does not (as Does not what? is the case wi

Re: [PATCH 3/6] OMAP3: PM: ensure IO wakeups are properly disabled

2010-08-13 Thread Sergei Shtylyov
Hello. Tony Lindgren wrote: From: Kevin Hilman Commit 5a5f561 (convert OMAP3 PRCM macros to the _SHIFT/_MASK suffixes) mistakenly removed the check for PER when disabling the IO chain. During idle, if the PER powerdomain transitions and CORE does not (as Does not what? How about "..

Re: [PATCH 3/6] OMAP3: PM: ensure IO wakeups are properly disabled

2010-08-19 Thread Sergei Shtylyov
Hello. Kevin Hilman wrote: From: Kevin Hilman Commit 5a5f561 (convert OMAP3 PRCM macros to the _SHIFT/_MASK suffixes) mistakenly removed the check for PER when disabling the IO chain. During idle, if the PER powerdomain transitions and CORE does not (as Does not what? How about ".. and

Re: [PATCH 3/6] OMAP4: Re-arrange the low level debug code

2009-12-10 Thread Sergei Shtylyov
Hello. Santosh Shilimkar wrote: On OMAP4430 the UART3 base address is different than that on OMAP3. Because of this existing code needs additional #ifdef'ry to accommodate that code. Hence this patch separates it. Also UART3 base address is fixed for OMAP4430 in this patch. Signed-off-by: Sant

Re: [PATCH 3/6] OMAP4: Re-arrange the low level debug code

2009-12-10 Thread Sergei Shtylyov
Hello. Shilimkar, Santosh wrote: -Original Message- From: Sergei Shtylyov [mailto:sshtyl...@ru.mvista.com] Sent: Thursday, December 10, 2009 4:06 PM To: Shilimkar, Santosh Cc: t...@atomide.com; linux-omap@vger.kernel.org; li...@arm.linux.org.uk; linux-arm- ker...@lists.infradead.org

Re: [patch-v2.6.33-rc2+ 02/12] arm: omap: musb: fix board power budget by passing it to usb_musb_init

2009-12-30 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: each board might have a different charge pump and thus able to source more or less current on vbus so let power be easily configurable. Cc: linux-...@vger.kernel.org Signed-off-by: Felipe Balbi [...] diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-om

Re: [patch-v2.6.34 7/9] usb: musb: use only clk framework for clk handling

2009-12-30 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: get rid of the set_clock hackery. Cc: linux-...@vger.kernel.org Signed-off-by: Felipe Balbi --- Greg, I'll send this patch to you shortly, it's only here so that Tony can have it in linux-omap-2.6 to avoid breaking any of his boards. Er, I'm afraid I have to

Re: [patch-v2.6.34 8/9] arm: omap: musb: do not pass clock name to driver

2009-12-30 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: we are using clkdev and the driver can use whatever name it wants. It's not so actually. This depends on the matching mechanism established within clkdev: by device, by name, or by both. Not all implementations will match by device, e.g. DA8xx/OMAP-L1x will m

Re: [PATCH 2/2] ARM : OMAP4 : MUSB : Add USB support to 4430 SDP board file

2009-12-30 Thread Sergei Shtylyov
Hello. Maulik Mankad wrote: ARM : OMAP4 : Add USB support to 4430 SDP board file This patch adds support for Mentor USB to 4430 SDP board file. It also defines the base address for HS USB OTG controller in OMAP4. Also updates platform specfic structure with base address and IRQ details. Sig

Re: [patch-v2.6.34 7/9] usb: musb: use only clk framework for clk handling

2009-12-30 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: Why always "ick"?! Do you think OMAPs are the only boards using MUSB out there? err, I'm afraid you have to read more about clock framework. The clock name should not matter when you issue clk_get(). It depends on the matching type determined from a clkd

Re: [patch-v2.6.34 8/9] arm: omap: musb: do not pass clock name to driver

2009-12-30 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: It's not so actually. This depends on the matching mechanism established within clkdev: by device, by name, or by both. Not all implementations will match by device, e.g. DA8xx/OMAP-L1x will match by clock name. then it has to be fixed. The name shouldn't

Re: [patch-v2.6.34 7/9] usb: musb: use only clk framework for clk handling

2009-12-30 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: Why always "ick"?! Do you think OMAPs are the only boards using MUSB out there? err, I'm afraid you have to read more about clock framework. The clock name should not matter when you issue clk_get(). It depends on the matching type determin

Re: [patch-v2.6.34 7/9] usb: musb: use only clk framework for clk handling

2009-12-30 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: Gotcha. This will match in clk_find() by both device and clock name, so clk_get() will fail with your patch. then, when it doesn't find, it'll try device id only: /* * Find the correct struct clk for the device and connection ID. * We do slightly fuzzy ma

Re: [patch-v2.6.34 7/9] usb: musb: use only clk framework for clk handling

2009-12-30 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: /* * Find the correct struct clk for the device and connection ID. * We do slightly fuzzy matching here: * An entry with a NULL ID is assumed to be a wildcard. * If an entry has a device ID, it must match * If an entry has a connection ID, it must match * The

Re: [PATCH 2/2] ARM : OMAP : Add empty function in header file

2009-12-31 Thread Sergei Shtylyov
Hello. Maulik Mankad wrote: ARM : OMAP : Add empty function in header file This patch adds empty functions for usb_nop_xceiv_register() and usb_nop_xceiv_unregister() so that these functions can be called even when CONFIG_NOP_USB_XCEIV is not enabled. It allows to remove ifdef's from board

Re: [PATCH 01/12] omap: McBSP: Fix possible port lockout

2010-01-08 Thread Sergei Shtylyov
Tony Lindgren wrote: From: Janusz Krzysztofik In its current form, the omap_mcbsp_request() function can return after irq_request() failure without any cleanups, effectively locking out the port forever with clocks left running. Fix it. Signed-off-by: Janusz Krzysztofik Acked-by: Jarkko N

Re: [PATCH] USB: musb: allow unaligned memory data transfers

2010-01-14 Thread Sergei Shtylyov
Hello. Gadiyar, Anand wrote: From: Felipe Balbi wrote: + /* On MUSB:RTL1.8 and above, DMA has to be word aligned */ + if ((dma_addr % 4) && + (musb->hwvers >= MUSB_HWVERS_1800)) { is it only inventra dma that suffers from this ? If not, we could move this

Re: [PATCH 4/5] musb: use system DMA for unaligned buffers on RTL >= 1.8

2010-05-12 Thread Sergei Shtylyov
Hello. Ajay Kumar Gupta wrote: MUSB RTL version 1.8 onward (OMAP3630, AM/DM37x, OMAP4) DMA requires the buffers to be aligned on a four byte boundary. This affects USB CDC/RNDIS class application where buffers are always unaligned. Use system DMA for unaligned buffers as a workaround of this i

Re: [PATCH 4/5] musb: use system DMA for unaligned buffers on RTL >= 1.8

2010-05-12 Thread Sergei Shtylyov
Hello. Gupta, Ajay Kumar wrote: Hi, if (channel->status == MUSB_DMA_STATUS_BUSY) { if (musb_channel->transmit) { + if (musb_channel->sysdma_channel != -1) + omap_stop_dma(musb_channel->sysdma_channel); +

Re: [PATCH 03/15] omap: mailbox: 2420 should be detected at run-time

2010-05-14 Thread Sergei Shtylyov
Hello. Felipe Contreras wrote: Signed-off-by: Felipe Contreras --- arch/arm/mach-omap2/mailbox.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c index 252e53b..6d17da8 100644 --- a/arch/arm/mach-omap2/mai

Re: [PATCH 6/6] musb: dma: use optimal transfer element for sdma

2010-05-18 Thread Sergei Shtylyov
Hello. Ajay Kumar Gupta wrote: Use optimal values of transfer element based on buffer address in system DMA programming. This would improve the performance. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/musbhsdma.c | 29 ++--- 1 files changed, 26 insertions(+

Re: [PATCH 3/3] musb: AM35x: Workaround for fifo read issue

2010-05-18 Thread Sergei Shtylyov
Hello. Ajay Kumar Gupta wrote: AM35x supports only 32bit read operations so we need to have workaround for 8bit and 16bit read operations. Signed-off-by: Ajay Kumar Gupta --- Patch created against linus'tree + all musb patches in Greg's queue Changes from v2: - fixed multipline comm

Re: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-18 Thread Sergei Shtylyov
Hello. Ajay Kumar Gupta wrote: AM35x supports only 32bit read operations so we need to have workaround for 8bit and 16bit read operations. But don't we need to override musb_readb() and musb_readw() then? Signed-off-by: Ajay Kumar Gupta WBR, Sergei -- To unsubscribe from this list:

Re: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-20 Thread Sergei Shtylyov
Hello. Gupta, Ajay Kumar wrote: AM35x supports only 32bit read operations so we need to have workaround for 8bit and 16bit read operations. Signed-off-by: Ajay Kumar Gupta --- Patch created against linus'tree + all musb patches in Greg's queue Changes from v1: - removed unnecessary

Re: [PATCH 07/22] OMAP: hwmod: Replace WARN by pr_warning if clock lookup failed

2010-05-21 Thread Sergei Shtylyov
Hello. Paul Walmsley wrote: From: Benoit Cousson The WARN is a little bit too verbose and is not providing usefull information in that case. Signed-off-by: Benoit Cousson Signed-off-by: Paul Walmsley [...] diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmo

Re: [PATCH 10/22] OMAP: hwmod: Replace WARN by pr_warning for clockdomain check

2010-05-21 Thread Sergei Shtylyov
Hello. Paul Walmsley wrote: From: Benoit Cousson Most of the clock nodes belong to a clock domain, but it is perfectly valid to have clock without clock domain. Root clocks for example does not belong to any clock domain. Keep the warning but reduce the verbosity. Signed-off-by: Benoit C

Re: [PATCH 10/22] OMAP: hwmod: Replace WARN by pr_warning for clockdomain check

2010-05-21 Thread Sergei Shtylyov
Hello. I wrote: From: Benoit Cousson Most of the clock nodes belong to a clock domain, but it is perfectly valid to have clock without clock domain. Root clocks for example does not belong to any clock domain. Keep the warning but reduce the verbosity. Signed-off-by: Benoit Cousson Sig

Re: [PATCH 1/3 v3] AM35x: Add musb support

2010-05-28 Thread Sergei Shtylyov
Hello. Ajay Kumar Gupta wrote: AM35x has musb interface (version 1.8) and uses CPPI41 DMA engine. It has USB phy built inside the IP itself. Also added ARCH_AM35x which is required to differentiate musb ips between OMAP3x and AM35x. This config would be used to for below purposes, -

Re: [PATCH 1/3 v3] AM35x: Add musb support

2010-05-29 Thread Sergei Shtylyov
Hello. Gupta, Ajay Kumar wrote: AM35x has musb interface (version 1.8) and uses CPPI41 DMA engine. It has USB phy built inside the IP itself. So it's more like DaVinci (earlier CPPI as well as integrated PHY) than OMAP3... Yes. Actually they removed original musb controller from OMAP3 a

Re: [PATCH 12/19] OMAP3 clock: Remove FreqSel for 3630

2010-02-16 Thread Sergei Shtylyov
Hello. Paul Walmsley wrote: From: Vishwanath BS DPLL_FREQSEL field in CLKEN_PLL register is no longer valid for OMAP3630. So remove references to that. Signed-off-by: Vishwanath BS Signed-off-by: Paul Walmsley --- arch/arm/mach-omap2/dpll3xxx.c | 11 +++ 1 files changed, 7 inser

Re: [PATCH 3/4] USB: MUSB: Add OMAP4 support in MUSB driver

2010-02-25 Thread Sergei Shtylyov
Hello. Maulik Mankad wrote: This patch adds CONFIG_ARCH_OMAP4 macro within MUSB driver code and builds the MUSB driver for OMAP4. Signed-off-by: Maulik Mankad Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: David Brownell --- Index: mainline/drivers/usb/musb/Makefile ===

Re: [PATCH 01/03] omap hsmmc: prevent race between dma and hsmmc callback

2010-03-01 Thread Sergei Shtylyov
Hello. Venkatraman S wrote: It is observed that sometimes the MMC Transfer Complete (TC) is not received when DMA completion callback is processed (or takes too long to process) This patch moves the releasing of DMA channel from dma callback to the mmc transfer complete handler. This is observe

Re: [PATCH 1/2] musb: add musb support for AM35x

2010-03-12 Thread Sergei Shtylyov
Hello. Ajay Kumar Gupta wrote: AM35x has musb interface and uses CPPI4.1 DMA engine. Current patch supports only PIO mode and there are on-going discussions on location of CPPI4.1 DMA. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/Kconfig |4 +- drivers/usb/musb/Makefile|

Re: [PATCH 1/2] musb: add musb support for AM35x

2010-03-12 Thread Sergei Shtylyov
Ajay Kumar Gupta wrote: AM35x has musb interface and uses CPPI4.1 DMA engine. Current patch supports only PIO mode and there are on-going discussions on location of CPPI4.1 DMA. Signed-off-by: Ajay Kumar Gupta Overlooked one thing... [...] +int musb_platform_exit(struct musb *musb) +{

Re: [PATCH 2/2] USB: musb: omap2430: add mode change from A to B

2010-03-15 Thread Sergei Shtylyov
Hello. Wang Hui wrote: On omap2/3 series platforms, the musb can't raise id pin change detection interrupt, so we must change otg mode through sysfs interface manually. Currently when the musb is in B mode, if we want musb to be changed to A mode, we should plug a mini-A cable and then execute

Re: [PATCH] AM35x: Add musb support

2010-03-20 Thread Sergei Shtylyov
Hello. Ajay Kumar Gupta wrote: AM35x has musb interface (version 1.8) and uses CPPI41 DMA engine. It supports upto 500mA of power in host mode. Signed-off-by: Ajay Kumar Gupta --- Created against latest l-o master branch and below patches. [1] AM35xx: Add clock support for new modules on AM35

Re: [PATCH] AM35x: Add musb support

2010-03-21 Thread Sergei Shtylyov
Hello. Gupta, Ajay Kumar wrote: Hi, AM35x has musb interface (version 1.8) and uses CPPI41 DMA engine. It supports upto 500mA of power in host mode. Signed-off-by: Ajay Kumar Gupta --- Created against latest l-o master branch and below patches. [1] AM35xx: Add clock support for new module

Re: [PATCH] AM35x: Add musb support

2010-03-22 Thread Sergei Shtylyov
Hello. Gupta, Ajay Kumar wrote: +/* USB 2.0 OTG module registers */ +#define USB_REVISION_REG 0x00 +#define USB_CTRL_REG 0x04 +#define USB_STAT_REG 0x08 +#define USB_EMULATION_REG0x0c +/* 0x10 Reserved */ Wait... so the mode register isn't supported? Does AM35x support

Re: [PATCH] AM35x: Add musb support

2010-03-22 Thread Sergei Shtylyov
Gupta, Ajay Kumar wrote: I have not added CPPI4.1 DMA specific register here.. Ah. Then they're not compatible with DA8xx anyway... We could make it compatible with some change as done at, http://arago-project.org/git/people/?p=sriram/ti-psp- omap.git;a=commi

Re: [PATCH] AM35x: Add musb support

2010-03-22 Thread Sergei Shtylyov
Gupta, Ajay Kumar wrote: -Original Message- From: Sergei Shtylyov [mailto:sshtyl...@mvista.com] Sent: Monday, March 22, 2010 4:33 PM To: Gupta, Ajay Kumar Cc: Sergei Shtylyov; linux-omap@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH] AM35x: Add musb support Gupta, Ajay

Re: [patch-2.6.34-rc2+ 10/11] musb_core: don't call musb_platform_exit() twice

2010-03-24 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: From: Sergei Shtylyov musb_platform_exit() is called twice from musb_init_controller() iff controller initialization fails. Move the call (and the DevCtl register writes surrounding it) from musb_free() to musb_remove(). Fix misplaced and now incorrect 'goto

Re: [patch-2.6.34-rc2+ 11/11] musb_core: fix musb_init_controller() error cleanup path

2010-03-24 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: From: Sergei Shtylyov This function forgets to call usb_remove_hcd() or musb_gadget_cleanup() iff sysfs_create_group() fails. Signed-off-by: Sergei Shtylyov [ felipe.ba...@nokia.com : review the entire error path not only when we fail hcd or gadget

Re: [patch-2.6.34-rc2+ 10/11] musb_core: don't call musb_platform_exit() twice

2010-03-24 Thread Sergei Shtylyov
Hello, I wrote: From: Sergei Shtylyov musb_platform_exit() is called twice from musb_init_controller() iff controller initialization fails. Move the call (and the DevCtl register writes surrounding it) from musb_free() to musb_remove(). Fix misplaced and now incorrect 'goto

Re: [patch-2.6.35 09/11] usb: musb: Makefile: remove unexistent config option

2010-03-24 Thread Sergei Shtylyov
Felipe Balbi wrote: Remove the unexistent CONFIG_USB_INVENTRA_MUSB_HAS_AHB_ID option from our Makefile. Problem reported by Sergei Shtylyov Well, there's Reported-by: line for that... :-) Signed-off-by: Felipe Balbi WBR, Sergei -- To unsubscribe from this list: send the

Re: [patch-2.6.35 04/11] MUSB: Blackfin: remove bfin_vbus_power()

2010-03-24 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: From: Sergei Shtylyov This function does nothing... Signed-off-by: Sergei Shtylyov -- Oops, missed one dash here. The patch is against the recent Linus' tree plus the series of 6 fixes posted yesterday... drivers/usb/musb/blackfin.c |7 -

Re: [patch-2.6.35 09/11] usb: musb: Makefile: remove unexistent config option

2010-03-24 Thread Sergei Shtylyov
Felipe Balbi wrote: Remove the unexistent CONFIG_USB_INVENTRA_MUSB_HAS_AHB_ID option from our Makefile. Problem reported by Sergei Shtylyov Signed-off-by: Felipe Balbi --- drivers/usb/musb/Makefile |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb

Re: [patch-2.6.35 09/11] usb: musb: Makefile: remove unexistent config option

2010-03-25 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: Remove the unexistent CONFIG_USB_INVENTRA_MUSB_HAS_AHB_ID option from our Makefile. Problem reported by Sergei Shtylyov Signed-off-by: Felipe Balbi --- drivers/usb/musb/Makefile |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers

Re: [PATCH 1/2] musb: add musb support for AM35x

2010-03-26 Thread Sergei Shtylyov
Gupta, Ajay Kumar wrote: AM35x has musb interface and uses CPPI4.1 DMA engine. Current patch supports only PIO mode and there are on-going discussions on location of CPPI4.1 DMA. Signed-off-by: Ajay Kumar Gupta tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)' @@ -140,7

Re: [PATCH 6/6 v7] usb: musb: Using runtime pm APIs for musb.

2011-02-16 Thread Sergei Shtylyov
Hello. On 16-02-2011 15:28, Hema HK wrote: Calling runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() for enabling/disabling the clocks, sysconfig settings. Enable clock, configure no-idle/standby when active and configure force idle/standby and disable clock when idled. This i

Re: [patch v2.6.39 2/3] usb: musb: gadget: beautify usb_gadget_probe_driver()/usb_gadget_unregister_driver

2011-02-17 Thread Sergei Shtylyov
Hello. On 17-02-2011 14:30, Felipe Balbi wrote: Just a few cosmetic fixes to usb_gadget_probe_driver() and usb_gadget_unregister_driver(). Decreased a few indentation levels with goto statements. Signed-off-by: Felipe Balbi [...] diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/us

Re: [GIT PULL] OMAP USB Patches for 2.6.39

2011-02-18 Thread Sergei Shtylyov
Hello. On 18-02-2011 15:11, Felipe Balbi wrote: Here are the patches I have for the next merge window. IIRC, you wrote yesterday that we have several days to send the patches still. I have one almost ready... WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH] ARM: Fix compile after delay page freeing patch

2011-02-22 Thread Sergei Shtylyov
Hello. Tony Lindgren wrote: Commit 06824ba824b3e9f2fedb38bee79af0643198ed7f (ARM: tlb: delay page freeing for SMP and ARMv7 CPUs) causes the following compile error for at least omap1_defconfig: In file included from arch/arm/mm/init.c:27: arch/arm/include/asm/tlb.h: In function 'tlb_flush_m

Re: [PATCH] OMAP2+: sdrc: fix compile break on OMAP4-only config on current omap-for-linus

2011-02-26 Thread Sergei Shtylyov
Hello. On 26-02-2011 4:40, Paul Walmsley wrote: On non-OMAP2 and non-OMAP3 kernel configs, turn omap2_sdrc_init() into a no-op. Otherwise, compilation breaks on an OMAP4-only config with the current omap-for-linus branch: arch/arm/mach-omap2/built-in.o: In function `omap2_init_common_device

Re: [PATCH] OMAP2+: sdrc: fix compile break on OMAP4-only config on current omap-for-linus

2011-02-28 Thread Sergei Shtylyov
-in.o: In function `omap2_init_common_devices': ../mach-omap2/io.c:421: undefined reference to `omap2_sdrc_init' Thanks to Sergei Shtylyov for suggesting the use of a empty static inline function rather than a macro. Not at all. :-) Signed-off-by: Paul Walmsley Cc: Tony Lindgren

Re: [PATCH v2 10/18] omap3+: sr: call handler with interrupt disabled

2011-03-02 Thread Sergei Shtylyov
Hello. On 02-03-2011 13:55, Nishanth Menon wrote: Request the handler irq such that there is no nesting for calls. the notifiers are not expected to be nested, further the interrupt events for status change should be handled prior to the next event else there is a risk of loosing events. Sig

Re: [PATCH v2 15/18] omap3+: sr: disable spamming interrupts

2011-03-02 Thread Sergei Shtylyov
Hello. On 02-03-2011 13:55, Nishanth Menon wrote: At times with bad SR configurations especially during silicon bringups, we could get continuous spurious interrupts which end up hanging the platform in the form of an ISR call for status bits that are automatically enabled by the h/w without an

Re: [PATCH v2 10/18] omap3+: sr: call handler with interrupt disabled

2011-03-02 Thread Sergei Shtylyov
I wrote: Request the handler irq such that there is no nesting for calls. the notifiers are not expected to be nested, further the interrupt events for status change should be handled prior to the next event else there is a risk of loosing events. Signed-off-by: Nishanth Menon --- arch/arm/

Re: [PATCH V3 03/19] OMAP3+: voltage: remove initial voltage

2011-03-06 Thread Sergei Shtylyov
Hello. On 05-03-2011 18:29, Nishanth Menon wrote: Blindly setting a 1.2V setting Hm, seems tautological... in the initial structure may not even match the default voltages stored in the voltage table which are supported for the domain. For example, OMAP3430 core domain does not use 1.2V

Re: [PATCH V3 03/19] OMAP3+: voltage: remove initial voltage

2011-03-07 Thread Sergei Shtylyov
Hello. On 07-03-2011 5:52, Nishanth Menon wrote: Blindly setting a 1.2V setting Hm, seems tautological... As a non native English speaker, I would like to understand how we could improve this. I suppose you mean "Blindly setting 1.2V" is better here. Am i correct? Yes. WBR, Sergei -

Re: [PATCH] can : AM3517EVM : add platform specific init

2011-03-11 Thread Sergei Shtylyov
Hello. On 10-03-2011 19:39, Abhilash K V wrote: CAN module on AM3517 requires programming of IO expander as part of init sequence. Added transceiver_switch callback to handle this. Signed-off-by: Sriramakrishnan Reviewed-by: Vaibhav Hiremath Signed-off-by: Abhilash K V --- arch/arm/mach-o

Re: [PATCH] omap3: beaglexm: fix user button.

2011-03-18 Thread Sergei Shtylyov
Hello. On 17-03-2011 15:44, Javier Martin wrote: User push button in Beagleboard xM is 4 instead of 7. Signed-off-by: Javier Martin [...] diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c index 46d814a..abf87d1 100644 --- a/arch/arm/mach-omap2

Re: [PATCH 1/2] USB: twl4030-usb: do board specific phy_power up/down

2011-03-21 Thread Sergei Shtylyov
Hello. Kalle Jokiniemi wrote: In case some board has special powering sequences for the USB tranceiver, call those during __twl4030_phy_power calls. This is a preparation patch to allow powering down the ISP1707 USB serial tranceiver in Nokia N900. Signed-off-by: Kalle Jokiniemi --- dri

Re: [PATCH 2/2] OMAP3: rx51: specify phy_power for usb tranceiver

2011-03-21 Thread Sergei Shtylyov
Hello. Kalle Jokiniemi wrote: This patch allows the ISP1707 USB tranceiver on Nokia N900 to be disabled when usb cable is disconnected. This saves approximately 14mA of battery current. Patch based on work done by Heikki Krogerus on N900 maemo kernel. Signed-off-by: Kalle Jokiniemi Cc: H

Re: [PATCH 1/2] usb: otg: OMAP4430: Fix omap4430_phy_init function

2011-03-24 Thread Sergei Shtylyov
Hello. On 24-03-2011 14:06, Hema HK wrote: omap4430_phy_init() function can be called with no device pointer to powerdown the UTMI PHY during board init when USB is disabled. Fix the function accordingly. Signed-off-by: Hema HK --- arch/arm/mach-omap2/omap_phy_internal.c | 44 +++

Re: [PATCH] OMAP: iovmm: fix SW flags passed by user

2011-03-25 Thread Sergei Shtylyov
Hello. Omar Ramirez Luna wrote: Commit d038aee24dcd changes iovmm to receive flags specified by user, Please also specify that commit's summary for the human readers. Bare ID is only usable to gitweb... however the upper 16 bits of the flags are wiped by iovmm itself. This fixes IOV

Re: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message

2011-03-26 Thread Sergei Shtylyov
Hello. On 26-03-2011 3:29, Omar Ramirez Luna wrote: If an error occurs in the L3 on any other initiator than MPU, the interrupt goes unhandled given that the 'base' register was calculated with the initialized err_base value (which coincidentally points to MPU) and not with the actual source of

Re: [PATCH v2 1/2] isp1704_charger: allow board specific powering routine

2011-03-28 Thread Sergei Shtylyov
Hello. On 28-03-2011 10:51, Kalle Jokiniemi wrote: The ISP1704/1707 chip can be put to full power down state by asserting the CHIP_SEL line. This patch enables platform or board specific hooks to put the device into power down mode in case not needed. These patches are preparatio for enablin

Re: [PATCH v2 2/2] RX-51: Enable isp1704 power on/off

2011-03-28 Thread Sergei Shtylyov
On 28-03-2011 10:51, Kalle Jokiniemi wrote: The isp1704 usb tranceiver is used for charging and can be disabled when not in use. Provide the powering routine to the driver via platform data. Loosely based on earlier patches from Heikki Krogerus in Nokia N900 maemo kernel. Signed-off-by: Ka

Re: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message

2011-03-28 Thread Sergei Shtylyov
Hello. On 28-03-2011 5:49, Ramirez Luna, Omar wrote: If an error occurs in the L3 on any other initiator than MPU, the interrupt goes unhandled given that the 'base' register was calculated with the initialized err_base value (which coincidentally points to MPU) and not with the actual source o

Re: [PATCH v2 1/2] isp1704_charger: allow board specific powering routine

2011-03-30 Thread Sergei Shtylyov
Hello. On 29.03.2011 9:52, kalle.jokini...@nokia.com wrote: > > diff --git a/include/linux/power/isp1704_charger.h > > b/include/linux/power/isp1704_charger.h > > > new file mode 100644 > > > index 000..68096a6 > > > --- /dev/null > > > +++ b/include/linux/

Re: [PATCH 4/8] OMAP2+: omap_hwmod: manage the omap_devices the wake-up latency constraints

2011-03-31 Thread Sergei Shtylyov
Hello. On 30-03-2011 19:19, jean.pi...@newoldbits.com wrote: From: Jean Pihet Hwmod is queried from the omap device layer to manage the power domains wake-up latency constraints. Hwmod retrieves the correct power domain and if it exists it calls the corresponding power domain function. Te

Re: [RFC PATCH v2 09/11] ARM: DT: Add support to system control module for OMAP4

2012-06-18 Thread Sergei Shtylyov
Hello. On 18-06-2012 15:32, Konstantin Baydarov wrote: This patch adds device tree entries on OMAP4 based boards for System Control Module (SCM). TODO: The IOMEM windows of ctrl_module_core, bandgap, usbphy overlap, so probably only specific registers should be specified in dts for bandgap a

Re: [PATCHv3 6/7] ARM: OMAP2+: CM: increase the module disable timeout

2012-06-19 Thread Sergei Shtylyov
Hello. On 18-06-2012 10:16, Paul Walmsley wrote: Increase the timeout for disabling an IP block to five milliseconds. This is to handle the usb_host_fs idle latency, which takes almost four milliseconds after a host controller reset. This is the second of two patches needed to resolve the fo

Re: [PATCH 3/5] ARM: omap3evm: enable VBUS switch for EHCI tranceiver

2012-06-20 Thread Sergei Shtylyov
Hello. On 20-06-2012 13:14, Zumeng Chen wrote: This was chosen by following the trace on the schematic from component U131 and U134 to the CPEN pin on the USB3320 device. TWL4030.GPIO2-...->(T2_GPIO2_3V3)U131-..>nUSB2_EN-..>U134-..>EXP_nUSB2_1V8 which starts EHCI tranceiver USB3320. This

Re: [PATCH 1/2] ARM: OMAP: USB: Fixup ehci_hcd_omap_probe error path

2012-06-21 Thread Sergei Shtylyov
Hello. On 21-06-2012 14:44, Russ Dill wrote: A recent commit, [PATCH] Fix OMAP EHCI suspend/resume failure (i693) '354ab856' Usually commit ID follows the word "commit", and then the commit summary. causes ehci probe to fail on omap3xxx. This exposed bugs in the ehci_hcd_omap_probe error

Re: [PATCH 2/2] OMAP4430: USB Host: Implement workaround for Errata i687

2012-06-30 Thread Sergei Shtylyov
Hello. On 29-06-2012 13:11, Ruslan Bilovol wrote: The OMAP4 EHCI controller has the following defect (errata ID i687): Title: USB TLL Hold Timing Violation Description: There is a timing hold violation on an internal logic on the clock USB TLL path resulting in a s

Re: [PATCH v2 1/3] arm: omap: hwmod: add new memory resource for usb phy control

2012-07-11 Thread Sergei Shtylyov
Hello. On 11-07-2012 14:29, Damodar Santhapuri wrote: From: Ajay Kumar Gupta Added usb_ctrl0 and usb_ctrl1 base address as new memory resources which will be used at am335x musb driver glue layer to turn on or off builin PHY untill we have a separate system control module driver. Signed-

Re: [PATCH v2 02/11] arm/dts: omap: Add omap-usb2 dt data

2012-07-17 Thread Sergei Shtylyov
Hello. On 17-07-2012 12:10, Kishon Vijay Abraham I wrote: Add omap-usb2 data node in omap4 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap4.dtsi b/

Re: [PATCH 2/2] arm/dts: omap4: Add ocp2scp data

2012-07-17 Thread Sergei Shtylyov
Hello. On 16-07-2012 18:13, Kishon Vijay Abraham I wrote: Add ocp2scp data node in omap4 device tree file. Signed-off-by: Kishon Vijay Abraham I --- arch/arm/boot/dts/omap4.dtsi |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/omap4.dtsi

Re: [PATCH v2 06/11] arm/dts: am33xx: Add dt data for usbss

2012-07-17 Thread Sergei Shtylyov
Hello. On 17-07-2012 13:13, Ajay Kumar Gupta wrote: Added device tree data for usbss on am33xx. There are two musb controllers on am33xx platform so have port0_mode and port1_mode additional data. Signed-off-by: Ajay Kumar Gupta --- arch/arm/boot/dts/am33xx.dtsi | 11 +++ 1 fil

Re: [PATCH v2 07/11] usb: otg: nop: add dt support

2012-07-17 Thread Sergei Shtylyov
Hello. On 17-07-2012 13:13, Ajay Kumar Gupta wrote: Added device tree support for nop transceiver driver and updated the Documentation with device tree binding information for am33xx platform. Signed-off-by: Ajay Kumar Gupta --- .../devicetree/bindings/usb/am33xx-usb.txt |3 ++

<    1   2   3   4   5   >