Hi Kevin,
Could you please take a look to the following patch series.
It consists of two patches, which are needed for proper
SmartReflex Interrupt handling.
Based on Linux v3.10. Verified on OMAP4430.
Thank you in advance.
Regards,
Andrii
Nishanth Menon (2):
PM / AVS: SmartReflex: fix
.
The same condition applies when a notifier does not exist OR is unable
to handle the interrupt as well.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Andrii Tseglytskyi andrii.tseglyts...@ti.com
---
drivers/power/avs/smartreflex.c | 23 +--
1 file changed, 21
of SmartReflex AVS block.
Reported-by: Honda Kenji x0092...@ti.com
Reported-by: Maki Tanaka m-tana...@ti.com
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Andrii Tseglytskyi andrii.tseglyts...@ti.com
---
drivers/power/avs/smartreflex.c |8
1 file changed, 4 insertions(+), 4 deletions
On 06/12/2013 04:32 PM, Tony Lindgren wrote:
* Kevin Hilman khil...@linaro.org [130610 10:58]:
Andrii Tseglytskyi andrii.tseglyts...@ti.com writes:
SmartReflex consists of three entities: SR device, SR class and
SR driver. SmartReflex driver depends on SmartReflex class, but
order
Signed-off-by: Andrii Tseglytskyi andrii.tseglyts...@ti.com
---
drivers/power/avs/smartreflex.c | 76 +++
1 file changed, 21 insertions(+), 55 deletions(-)
diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
index 6b2238b..fd71d5a
(),
and removes redundant call of sr_late_init().
This provides predictable order of SmartReflex initcalls:
1. device_initcall() - SmartReflex class init
2. late_initcall() - SmartReflex driver init
Signed-off-by: Andrii Tseglytskyi andrii.tseglyts...@ti.com
---
arch/arm/mach-omap2/smartreflex
#define removed from PM / AVS: SmartReflex: use devm_* API to
initialize SmartReflex
- rebased to v3.10-rc4
Andrii Tseglytskyi (2):
PM / AVS: SmartReflex: use devm_* API to initialize SmartReflex
PM / AVS: SmartReflex/class3: Fix order of initialization of SR class
and SR driver
arch/arm
-rc3
- minor comment update in disable errgen before vpbound disable patch
Andrii Tseglytskyi (2):
PM / AVS: SmartReflex: disable runtime PM on driver remove
PM / AVS: SmartReflex: fix driver name
Nishanth Menon (1):
PM / AVS: SmartReflex: disable errgen before vpbound disable
drivers/power
DRIVER_NAME was undefined for SmartReflex. Now it is
defined with valid value smartreflex. It is needed
to define proper value for:
MODULE_ALIAS(platform: DRIVER_NAME);
Signed-off-by: Andrii Tseglytskyi andrii.tseglyts...@ti.com
Acked-by: Nishanth Menon n...@ti.com
---
drivers/power/avs
Runtime PM should be disabled for device on driver remove,
otherwise runtime PM will be not balanced, and this will cause
an error message, on next driver probe.
Signed-off-by: Andrii Tseglytskyi andrii.tseglyts...@ti.com
Acked-by: Nishanth Menon n...@ti.com
---
drivers/power/avs/smartreflex.c
From: Nishanth Menon n...@ti.com
vpboundsintr_en is available inside the IP block as an re-sycned
version and one which is not. Due to this, there is an 1 sysclk
cycle window where the SR_SInterruptz signal could be asserted low.
IF, intr_en is cleared on the exact same cycle as the irqclr, an
Available on GitHub:
https://github.com/andriit/linux-omap-k3.8/commits/avs_sr_driver_optimization_v02
Andrii Tseglytskyi (2):
PM / AVS: SmartReflex: use devm_* API to initialize SmartReflex
PM / AVS: SmartReflex/class3: Fix order of initialization of SR class
and SR driver
arch/arm/mach
Signed-off-by: Andrii Tseglytskyi andrii.tseglyts...@ti.com
---
drivers/power/avs/smartreflex.c | 77 +++
1 file changed, 22 insertions(+), 55 deletions(-)
diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
index 6b2238b..60cf0ee
(),
and removes redundant call of sr_late_init().
This provides predictable order of SmartReflex initcalls:
1. device_initcall() - SmartReflex class init
2. late_initcall() - SmartReflex driver init
Signed-off-by: Andrii Tseglytskyi andrii.tseglyts...@ti.com
---
arch/arm/mach-omap2/smartreflex
Hi Kevin,
Thanks a lot for your comments.
On 05/28/2013 09:45 PM, Kevin Hilman wrote:
Andrii Tseglytskyi andrii.tseglyts...@ti.com writes:
From: Nishanth Menon n...@ti.com
vpboundsintr_en is available inside the IP block as an re-sycned
version and one which is not. Due
On 05/29/2013 12:03 AM, Kevin Hilman wrote:
Andrii Tseglytskyi andrii.tseglyts...@ti.com writes:
The following patch series contain several misc fixes to SmartReflex driver:
1. disable errgen before vpbound disable. Critical fix, needed for
proper work of AVS-VP communicaton protocol.
2
On 05/29/2013 12:58 PM, Andrii Tseglytskyi wrote:
Hi Kevin,
Thanks a lot for your comments.
On 05/28/2013 09:45 PM, Kevin Hilman wrote:
Andrii Tseglytskyi andrii.tseglyts...@ti.com writes:
From: Nishanth Menon n...@ti.com
vpboundsintr_en is available inside the IP block as an re-sycned
://github.com/andriit/linux-omap-k3.8/commits/avs_sr_driver_misc_fixes_v01
Andrii Tseglytskyi (2):
PM / AVS: SmartReflex: disable runtime PM on driver remove
PM / AVS: SmartReflex: fix driver name
Nishanth Menon (1):
PM / AVS: SmartReflex: disable errgen before vpbound disable
drivers/power/avs
From: Nishanth Menon n...@ti.com
vpboundsintr_en is available inside the IP block as an re-sycned
version and one which is not. Due to this, there is an 1 sysclk
cycle window where interruptz could be asserted low for 1 cycle.
IF, intr_en is cleared on the exact same cycle as the irqclr, an
DRIVER_NAME was undefined for SmartReflex. Now it is
defined with valid value smartreflex. It is needed
to define proper value for:
MODULE_ALIAS(platform: DRIVER_NAME);
Signed-off-by: Andrii Tseglytskyi andrii.tseglyts...@ti.com
Acked-by: Nishanth Menon n...@ti.com
---
drivers/power/avs
Runtime PM should be disabled for device on driver remove,
otherwise runtime PM will be not balanced, and this will cause
an error message, on next driver probe.
Signed-off-by: Andrii Tseglytskyi andrii.tseglyts...@ti.com
Acked-by: Nishanth Menon n...@ti.com
---
drivers/power/avs/smartreflex.c
on GitHub:
https://github.com/andriit/linux-omap-k3.8/commits/avs_sr_driver_std_class_interfaces_v01
Andrii Tseglytskyi (3):
PM / AVS: SmartReflex: use omap_sr * for errgen interfaces
PM / AVS: SmartReflex: use omap_sr * for minmax interfaces
PM / AVS: SmartReflex: use omap_sr * for enable/disable
omap_sr* as input parameter.
Signed-off-by: Andrii Tseglytskyi andrii.tseglyts...@ti.com
Acked-by: Nishanth Menon n...@ti.com
---
drivers/power/avs/smartreflex.c | 14 +++---
include/linux/power/smartreflex.h |2 +-
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git
struct omap_sr* as input parameter.
Signed-off-by: Andrii Tseglytskyi andrii.tseglyts...@ti.com
Acked-by: Nishanth Menon n...@ti.com
---
arch/arm/mach-omap2/smartreflex-class3.c |4 ++--
drivers/power/avs/smartreflex.c | 23 +++
include/linux/power/smartreflex.h
SmartReflex enable/disable sequence.
Now they take struct omap_sr* as input parameter.
Signed-off-by: Andrii Tseglytskyi andrii.tseglyts...@ti.com
Acked-by: Nishanth Menon n...@ti.com
---
arch/arm/mach-omap2/smartreflex-class3.c |4 ++--
drivers/power/avs/smartreflex.c | 26
On 04/16/2013 10:18 PM, Kevin Hilman wrote:
Andrii Tseglytskyi andrii.tseglyts...@ti.com writes:
Hi Kevin,
On 04/16/2013 12:53 AM, Kevin Hilman wrote:
Andrii Tseglytskyi andrii.tseglyts...@ti.com writes:
From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
Following patch series introduces
Hi Mike,
On 04/15/2013 07:43 PM, Mike Turquette wrote:
Quoting Andrii Tseglytskyi (2013-04-15 06:28:10)
Cc: Mike Turquette mturque...@linaro.org
Signed-off-by: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
Signed-off-by: Mike Turquette mturque...@linaro.org
It is very strange to Cc me
Hi Kevin,
On 04/16/2013 12:53 AM, Kevin Hilman wrote:
Andrii Tseglytskyi andrii.tseglyts...@ti.com writes:
From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
Following patch series introduces the Adaptive Body-Bias
LDO driver, which handles LDOs voltage during OPP change routine.
Current
From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
Following patch series introduces the Adaptive Body-Bias
LDO driver, which handles LDOs voltage during OPP change routine.
Current implementation is based on patch series from
Mike Turquette:
http://marc.info/?l=linux-omapm=134931341818379w=2
From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
Add DT ABB data for OMAP36xx family of devices.
Data is based on OMAP36XX TRM document.
Signed-off-by: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
---
Documentation/devicetree/bindings/power/abb.txt | 38 +++
From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
Add DT ABB data for OMAP44xx family of devices.
Data is based on OMAP44xx TRM document.
Signed-off-by: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
---
arch/arm/boot/dts/omap4.dtsi| 22 ++
From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
Add DT ABB data for OMAP543x family of devices.
Data is based on OMAP543x TRM document.
Signed-off-by: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
---
arch/arm/boot/dts/omap5.dtsi | 39 +++
1 file changed,
From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
This patch introduces aliases for SYS clock nedded for ABB
driver, which will be introduced in the following patch.
Signed-off-by: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
---
arch/arm/mach-omap2/cclock3xxx_data.c |1 +
--- /dev/null
+++ b/drivers/regulator/abb-regulator.c
@@ -0,0 +1,638 @@
+/*
+ * OMAP Adaptive Body-Bias core
+ *
+ * Copyright (C) 2011 Texas Instruments, Inc.
+ * Mike Turquette mturque...@ti.com
+ *
+ * Copyright (C) 2013 Texas Instruments, Inc.
+ * Andrii Tseglytskyi andrii.tseglyts...@ti.com
From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
Patch adds debugfs entry for each ABB:
/sys/kernel/debug/ABB device name
This entry is read-only. It prints current state of ABB.
Signed-off-by: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
---
drivers/regulator/abb-regulator.c | 74
Hi Mark,
On 04/15/2013 06:50 PM, Mark Brown wrote:
In addition, such locking scheme allows to have access to the supplier
regulator API from inside child's (consumer) regulator API.
I've still not seen any use case articulated for doing this...
Use case is introduced in ABB series:
On 04/02/2013 08:16 PM, Mike Turquette wrote:
Quoting Nishanth Menon (2013-04-01 20:35:45)
On 17:05-20130401, Mike Turquette wrote:
OK, so we're in agreement on what The Future looks like. What does that
mean for Andrii's patchset?
Unless anyone has an fundamental issue with the approach of
:
Quoting Andrii Tseglytskyi (2013-03-28 10:16:07)
From: Andrii.Tseglytskyiandrii.tseglyts...@ti.com
Ownership of ABB driver patch probably still belongs to Mike as the
original
author of the code and working out all the details to entitle ABB on OMAP
platforms
Agreed with Mike to keep mine
:
Quoting Andrii Tseglytskyi (2013-03-28 10:16:07)
From: Andrii.Tseglytskyiandrii.tseglyts...@ti.com
Ownership of ABB driver patch probably still belongs to Mike as the
original
author of the code and working out all the details to entitle ABB on OMAP
platforms
Agreed with Mike to keep mine
From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
Add DT ABB data for OMAP36xx family of devices.
This data is based on OMAP36XX_ES1.x_NDA_TRM_vAB.pdf
document.
Cc: Mike Turquette mturque...@linaro.org
Cc: Tero Kristo t-kri...@ti.com
Cc: Nishanth Menon n...@ti.com
Cc: Benoît Cousson
From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
Add DT ABB data for OMAP44xx family of devices.
This data is based on OMAP4430_ES2.x_NDA_TRM_vAA.pdf
document.
Cc: Mike Turquette mturque...@linaro.org
Cc: Tero Kristo t-kri...@ti.com
Cc: Nishanth Menon n...@ti.com
Cc: Benoît Cousson
From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
Add DT ABB data for OMAP543x family of devices.
This data is based on OMAP543x_ES2.0_NDA_TRM_vR.pdf
document.
Cc: Mike Turquette mturque...@linaro.org
Cc: Tero Kristo t-kri...@ti.com
Cc: Nishanth Menon n...@ti.com
Cc: Benoît Cousson
From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
This patch introduces aliases for SYS clock, MPU clock
and IVA clock. These aliases will be used in ABB driver,
which will be introduced in the following patches.
Cc: Mike Turquette mturque...@linaro.org
Cc: Tero Kristo t-kri...@ti.com
Cc:
new file mode 100644
index 000..f5bbb8d
--- /dev/null
+++ b/drivers/power/avs/abb.c
@@ -0,0 +1,570 @@
+/*
+ * OMAP Adaptive Body-Bias core
+ *
+ * Copyright (C) 2011 Texas Instruments, Inc.
+ * Mike Turquette mturque...@ti.com
+ *
+ * Copyright (C) 2013 Texas Instruments, Inc.
+ * Andrii
From: Andrii.Tseglytskyi andrii.tseglyts...@ti.com
Patch adds debugfs entry for each ABB:
/sys/kernel/debug/ABB device name
This entry is read-only. It prints current state of ABB.
Cc: Mike Turquette mturque...@linaro.org
Cc: Tero Kristo t-kri...@ti.com
Cc: Nishanth Menon n...@ti.com
Cc: Benoît
45 matches
Mail list logo
