Re: [PATCH v5 4/5] iommu/omap: adapt to runtime pm

2012-11-22 Thread Felipe Contreras
. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Beagleboard xM - play video file : BUG: scheduling while atomic: queue1:src/92/0x0000008e , then kernel panic

2012-10-25 Thread Felipe Contreras
On Thu, Oct 25, 2012 at 12:49 AM, Omar Ramirez Luna omar.rami...@copitl.com wrote: On Wed, Oct 24, 2012 at 10:34 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Selso, hopefully you don't mind, but I'll forward this to the linux-omap mailing list, as this seems to be an interesting

Re: Beagleboard xM - play video file : BUG: scheduling while atomic: queue1:src/92/0x0000008e , then kernel panic

2012-10-24 Thread Felipe Contreras
, stack limit = 0xdc4742f8) [ 468.056091] ---[ end trace 7346e43bee93ae33 ]--- [ 468.068725] note: dspvdec0:src[94] exited with preempt_count 141 [ 468.084838] NOHZ: local_softirq_pending 40 -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: Beagleboard xM - play video file : BUG: scheduling while atomic: queue1:src/92/0x0000008e , then kernel panic

2012-10-24 Thread Felipe Contreras
with the linux-omap tree repo, and may repeat the test with this one. It should work with a vanilla kernel. I think you might have better luck with older kernels, 3.2, or maybe even 3.0. I don't recall the last one I tried, but it was working fine. Cheers. -- Felipe Contreras -- To unsubscribe from

Re: [PATCH 2/6] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-10-17 Thread Felipe Contreras
On Thu, Oct 18, 2012 at 1:51 AM, Omar Ramirez Luna omar.l...@linaro.org wrote: On 15 October 2012 22:23, Felipe Contreras felipe.contre...@gmail.com wrote: On probe this patch does pm_runtime_enable, however this doesn't mean the device is turned ON or resumed or kept ON all the time. In fact

Re: [PATCH 2/6] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-10-12 Thread Felipe Contreras
, cam_ick, cam_ick, CK_34XX | CK_36XX), CLK(NULL, csi2_96m_fck, csi2_96m_fck, CK_34XX | CK_36XX), CLK(NULL, usbhost_120m_fck, usbhost_120m_fck, CK_3430ES2PLUS | CK_AM35XX | CK_36XX), Cheers. -- Felipe Contreras -- To unsubscribe from this list: send

Re: [PATCH 2/6] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-10-12 Thread Felipe Contreras
On Fri, Oct 12, 2012 at 7:46 PM, Omar Ramirez Luna omar.l...@linaro.org wrote: On 12 October 2012 02:48, Felipe Contreras felipe.contre...@gmail.com wrote: I already made most of these comments, but here they go again. I replied to all, but here it goes again: Mostly, but not all

Re: [PATCH v2 08/15] tidspbridge: Fix VM_PFNMAP mapping

2012-09-21 Thread Felipe Contreras
with the patch, but I think there's a lot of changes, and perhaps a bit more of explanation of how it's doing this might help. Also, it seems to be reordering match_exact_map_obj(), which messes up the diff a bit. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe

[PATCH v2] arm: omap: fix trivial warnings for dspbridge

2012-04-23 Thread Felipe Contreras
: format '%x' expects type 'unsigned int', but argument 3 has type 'phys_addr_t' arch/arm/mach-omap2/dsp.c:60: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'phys_addr_t' Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- arch/arm/mach-omap2/dsp.c|5

[PATCH] staging: tidspbridge: fix build errors for OMAP2_L4_IO_ADDRESS

2012-04-23 Thread Felipe Contreras
/wdt.c:56: error: implicit declaration of function 'OMAP2_L4_IO_ADDRESS' The proper fix will come later. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/staging/tidspbridge/include/dspbridge/dbdefs.h |8 1 file changed, 8 insertions(+) diff --git a/drivers/staging

Re: [PATCH] staging: tidspbridge: fix build errors for OMAP2_L4_IO_ADDRESS

2012-04-23 Thread Felipe Contreras
On Mon, Apr 23, 2012 at 5:39 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Apr 23, 2012 at 05:34:14PM +0300, Felipe Contreras wrote: drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_start': drivers/staging/tidspbridge/core/tiomap3430.c:425: error

Test: please ignore

2012-04-22 Thread Felipe Contreras
there is some activity with tidspbridge (by Víctor). Is there any interest in fixing these errors for v3.4 (or even v3.4-rc5)? Along those lines, what's the plans on getting this code _out_ of staging? I haven't seen anything going on here in a while... Test 6. -- Felipe Contreras

[PATCH] arm: omap: fix trivial warnings for dspbridge

2012-04-20 Thread Felipe Contreras
: format '%x' expects type 'unsigned int', but argument 3 has type 'phys_addr_t' arch/arm/mach-omap2/dsp.c:60: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'phys_addr_t' Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- arch/arm/mach-omap2/dsp.c|5

Re: [PATCH] arm: omap: fix trivial warnings for dspbridge

2012-04-20 Thread Felipe Contreras
/? I prefer to keep the size also as hex, as it's usually how it's configured. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-15 Thread Felipe Contreras
2012/2/15 Víctor M. Jáquez L. vjaq...@igalia.com: On Tue, Feb 14, 2012 at 08:56:11PM -0600, Ramirez Luna, Omar wrote: On Tue, Feb 14, 2012 at 10:23 AM, Felipe Contreras felipe.contre...@gmail.com wrote: When that case is applicable, we should first modify the loader code or prepare

Re: [RFC PATCH 0/2] staging: tidspbridge: detecting wdt from baseimage

2012-02-15 Thread Felipe Contreras
/sysfs entry if needed, I didn't include such a patch as we first need to decide which fix to take (between this and default y for CONFIG_TIDSPBRIDGE_WDT3[1]). [1] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg62119.html LGTM. -- Felipe Contreras -- To unsubscribe from this list

Re: OMAP34xx

2012-02-15 Thread Felipe Contreras
On Thu, Feb 9, 2012 at 2:47 AM, Greg KH gre...@linuxfoundation.org wrote: Show me an OMAP user that actually runs a mainline kernel :) I haven't used anything but mainline kernel since years when I test stuff on my Nokia N900. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-14 Thread Felipe Contreras
On Tue, Feb 14, 2012 at 3:06 AM, Ramirez Luna, Omar omar.rami...@ti.com wrote: On Feb 11, 2012 3:03 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, Feb 11, 2012 at 9:19 PM, Ramirez Luna, Omar omar.rami...@ti.com wrote: On Feb 10, 2012 12:44 PM, Felipe Contreras

Re: [PATCH v2] usb: musb: fix pm_runtime mismatch

2012-02-13 Thread Felipe Contreras
On Mon, Feb 13, 2012 at 2:54 PM, Grazvydas Ignotas nota...@gmail.com wrote: On Thu, Jan 12, 2012 at 5:40 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Thu, Jan 12, 2012 at 1:56 PM, Grazvydas Ignotas nota...@gmail.com wrote: On Mon, Dec 19, 2011 at 10:01 PM, Felipe Contreras

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-11 Thread Felipe Contreras
On Sat, Feb 11, 2012 at 9:19 PM, Ramirez Luna, Omar omar.rami...@ti.com wrote: On Feb 10, 2012 12:44 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Feb 10, 2012 at 10:35 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Feb 10, 2012 at 09:42:32PM +0200, Felipe

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Felipe Contreras
On Fri, Feb 10, 2012 at 5:35 PM, Justin P. Mattock justinmatt...@gmail.com wrote: On Thu, 9 Feb 2012 21:18:49 -0800 Greg KH gre...@linuxfoundation.org wrote: On Thu, Feb 09, 2012 at 04:45:00PM -0800, Ramirez Luna, Omar wrote: Hi, On Thu, Feb 9, 2012 at 3:30 PM, Felipe Contreras

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Felipe Contreras
On Fri, Feb 10, 2012 at 7:18 AM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Feb 09, 2012 at 04:45:00PM -0800, Ramirez Luna, Omar wrote: Hi, On Thu, Feb 9, 2012 at 3:30 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Again, I'm totally confused as to _WHY_ this needs to be y

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Felipe Contreras
On Fri, Feb 10, 2012 at 6:16 PM, Greg KH gre...@linuxfoundation.org wrote: On Fri, Feb 10, 2012 at 06:05:59PM +0200, Felipe Contreras wrote: From 5c7ad6c00d051d574007cdbecdf14bf3d0cb Mon Sep 17 00:00:00 2001 From: Justin P. Mattock justinmatt...@gmail.com Date: Fri, 10 Feb 2012 07:19:45

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Felipe Contreras
On Fri, Feb 10, 2012 at 8:00 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Feb 10, 2012 at 01:30:48AM +0200, Felipe Contreras wrote: It's not an oops, it's a warning, and again, it depends on the firmware being used. We don't have control over that, and we have no way to detect

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-10 Thread Felipe Contreras
On Fri, Feb 10, 2012 at 10:35 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Feb 10, 2012 at 09:42:32PM +0200, Felipe Contreras wrote: On Fri, Feb 10, 2012 at 8:00 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Feb 10, 2012 at 01:30:48AM +0200, Felipe Contreras wrote

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-09 Thread Felipe Contreras
On Thu, Feb 9, 2012 at 7:35 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Feb 01, 2012 at 09:26:16AM +0200, Felipe Contreras wrote: On Wed, Feb 1, 2012 at 5:44 AM, Greg KH g...@kroah.com wrote: On Wed, Feb 01, 2012 at 03:37:55AM +0200, Felipe Contreras wrote: On Wed, Feb 1, 2012 at 3

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-09 Thread Felipe Contreras
On Thu, Feb 9, 2012 at 8:41 PM, Felipe Contreras felipe.contre...@gmail.com wrote: I already gave you a good reason, and this came from Linus Torvalds. http://article.gmane.org/gmane.linux.kernel/995419 Notice how he agreed that setting defaults was a good idea. I can't point to the mails

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-09 Thread Felipe Contreras
On Thu, Feb 9, 2012 at 8:59 PM, Greg KH gre...@linuxfoundation.org wrote: On Thu, Feb 09, 2012 at 08:41:55PM +0200, Felipe Contreras wrote: On Thu, Feb 9, 2012 at 7:35 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Feb 01, 2012 at 09:26:16AM +0200, Felipe Contreras wrote: On Wed, Feb

Re: [PATCH 0/4] staging: tidspbridge: remove desgin-by-contract macros

2012-02-06 Thread Felipe Contreras
and it will be perfect. The whole series is fine by me :) Even the warnings that don't depend on DEBUG have been neglected anyway =/ Will send some patches for a few of them soon. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: patch tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA added to tty tree

2012-02-03 Thread Felipe Contreras
On Fri, Feb 3, 2012 at 6:07 AM, NeilBrown ne...@suse.de wrote: If I then enabled runtime_pm with a 5 second autosuspend delay:  CORE is still permanently ON (I think the USB might be doing that). Maybe related to this: http://thread.gmane.org/gmane.linux.usb.general/56096 -- Felipe Contreras

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-02-01 Thread Felipe Contreras
it would not be easy. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] staging: tidspbridge: fix incorrect free to drv_datap

2012-01-31 Thread Felipe Contreras
faults, and reload the module =/ IIRC this is still the case on the Nokia N900. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] staging: tidspbridge: enable watchdog by default

2012-01-31 Thread Felipe Contreras
From: Felipe Contreras felipe.contre...@nokia.com The public images have it enabled, it's safer, and we get rid of this warning: WARNING: at arch/arm/mach-omap2/omap_l3_smx.c:162 omap3_l3_app_irq+0x114/0x15c() In-band Error seen by IVA_SS at address 0 Modules linked in: bridgedriver(C

[PATCH] mfd: twl4030: trivial code-style fixes

2012-01-31 Thread Felipe Contreras
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/mfd/twl4030-irq.c | 26 ++ 1 files changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c index b69bb51..b31f920 100644 --- a/drivers/mfd

[PATCH] power: isp1704: fix probe error path

2012-01-31 Thread Felipe Contreras
We enable power, but don't disable it in case of an error. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/power/isp1704_charger.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/power/isp1704_charger.c b/drivers/power/isp1704_charger.c

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-01-31 Thread Felipe Contreras
On Wed, Feb 1, 2012 at 3:12 AM, Greg KH gre...@suse.de wrote: On Wed, Feb 01, 2012 at 03:01:32AM +0200, Felipe Contreras wrote: From: Felipe Contreras felipe.contre...@nokia.com The public images have it enabled, it's safer, and we get rid of this warning: WARNING: at arch/arm/mach-omap2

Re: [PATCH] staging: tidspbridge: enable watchdog by default

2012-01-31 Thread Felipe Contreras
On Wed, Feb 1, 2012 at 5:44 AM, Greg KH g...@kroah.com wrote: On Wed, Feb 01, 2012 at 03:37:55AM +0200, Felipe Contreras wrote: On Wed, Feb 1, 2012 at 3:12 AM, Greg KH gre...@suse.de wrote: On Wed, Feb 01, 2012 at 03:01:32AM +0200, Felipe Contreras wrote: From: Felipe Contreras felipe.contre

Re: [PATCH 2/2] staging: tidspbridge: fix incorrect free to drv_datap

2012-01-31 Thread Felipe Contreras
On Wed, Feb 1, 2012 at 8:58 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Tue, Jan 31, 2012 at 09:39:00PM +0200, Felipe Contreras wrote: On Tue, Jan 31, 2012 at 8:43 PM, Dan Carpenter dan.carpen...@oracle.com wrote: How often do people rmmod things on a production system?  Hopefully

Re: [PATCH] tidspbridge: Rename module from bridgedriver to tidspbridge

2012-01-30 Thread Felipe Contreras
also have thought on doing this. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] omap2+: add drm device

2012-01-24 Thread Felipe Contreras
On Mon, Jan 16, 2012 at 11:24 PM, Rob Clark rob.cl...@linaro.org wrote: On Mon, Jan 16, 2012 at 2:37 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Jan 16, 2012 at 7:01 PM, Rob Clark rob.cl...@linaro.org wrote: On Mon, Jan 16, 2012 at 10:59 AM, Felipe Contreras felipe.contre

[PATCH] omap: mailbox: trivial whitespace fix

2012-01-24 Thread Felipe Contreras
Signed-off-by: Felipe Contreras felipe.contre...@nokia.com --- arch/arm/plat-omap/mailbox.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index ad80112..ad32621 100644 --- a/arch/arm/plat-omap/mailbox.c +++ b

Re: [PATCH 2/5] staging: tidspbridge: remove unused header

2012-01-24 Thread Felipe Contreras
too. 'Also' is a keyword that usually denotes that we are talking about two patches here: one that reshuffles the code, and another one that removes the header. But looks good to me either way. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH 1/5] staging: tidspbridge: more readable code

2012-01-24 Thread Felipe Contreras
2012/1/23 Víctor Manuel Jáquez Leal vjaq...@igalia.com: Uppercase function names are not pretty. Also the code flow readability is enhanced. Looks good to me. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 1/2] omap2+: add drm device

2012-01-24 Thread Felipe Contreras
On Tue, Jan 24, 2012 at 5:54 PM, Rob Clark rob.cl...@linaro.org wrote: On Tue, Jan 24, 2012 at 9:33 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Jan 16, 2012 at 11:24 PM, Rob Clark rob.cl...@linaro.org wrote: On Mon, Jan 16, 2012 at 2:37 PM, Felipe Contreras felipe.contre

Re: [PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Felipe Contreras
On Fri, Jan 13, 2012 at 11:19 PM, Rob Clark rob.cl...@linaro.org wrote: On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Jan 13, 2012 at 10:41 PM, Rob Clark rob.cl...@linaro.org wrote: diff --git a/arch/arm/plat-omap/Makefile b/arch/arm/plat-omap

Re: [PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Felipe Contreras
On Mon, Jan 16, 2012 at 6:37 PM, Rob Clark rob.cl...@linaro.org wrote: On Mon, Jan 16, 2012 at 8:12 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Jan 13, 2012 at 11:19 PM, Rob Clark rob.cl...@linaro.org wrote: On Fri, Jan 13, 2012 at 2:59 PM, Felipe Contreras felipe.contre

Re: [PATCH 1/2] omap2+: add drm device

2012-01-16 Thread Felipe Contreras
On Mon, Jan 16, 2012 at 7:01 PM, Rob Clark rob.cl...@linaro.org wrote: On Mon, Jan 16, 2012 at 10:59 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Jan 16, 2012 at 6:37 PM, Rob Clark rob.cl...@linaro.org wrote: On Mon, Jan 16, 2012 at 8:12 AM, Felipe Contreras felipe.contre

Re: [PATCH] omap2+: add drm device

2012-01-13 Thread Felipe Contreras
/staging/omapdrm/omap_dmm_tiler.h btw, I'm not a huge fan of doing #includes this way, so if someone has a better suggestion (given that staging drivers should not have headers outside of drivers/staging) please let me know Move those structs to /arch/arm/plat-omap/drm.h? -- Felipe Contreras

Re: [PATCH] omap2+: add drm device

2012-01-13 Thread Felipe Contreras
On Fri, Jan 13, 2012 at 9:53 PM, Rob Clark r...@ti.com wrote: On Fri, Jan 13, 2012 at 1:49 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Jan 13, 2012 at 9:46 PM, Rob Clark r...@ti.com wrote: On Fri, Jan 13, 2012 at 1:41 PM, Rob Clark rob.cl...@linaro.org wrote: +/* files from

Re: [PATCH] omap2+: add drm device

2012-01-13 Thread Felipe Contreras
: __ARCH_OMAP_FOO_H Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] omap2+: add drm device

2012-01-13 Thread Felipe Contreras
:= common.o sram.o clock.o devices.o dma.o mux.o \ -        usb.o fb.o counter_32k.o +        usb.o fb.o counter_32k.o drm.o Should be something like this: obj-$(CONFIG_DRM_OMAP) += drm.o No? -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH RFC] OMAP: I2C: Fix the mismatch of pm_runtime enable and disable

2012-01-12 Thread Felipe Contreras
. Strange however  I see many drivers doing the same in the kernel on greping . Besides I expect a warn to come up. Felipe could you explain the issue? When do you see the warning? kfree(dev) should disable runtime pm, but without waking up the device. -- Felipe Contreras -- To unsubscribe from

Re: [PATCH v2] usb: musb: fix pm_runtime mismatch

2012-01-12 Thread Felipe Contreras
On Thu, Jan 12, 2012 at 1:56 PM, Grazvydas Ignotas nota...@gmail.com wrote: On Mon, Dec 19, 2011 at 10:01 PM, Felipe Contreras felipe.contre...@nokia.com wrote: From: Felipe Contreras felipe.contre...@gmail.com In musb_init_controller() there's a pm_runtime_put(), but there's

Re: [PATCH] usb: musb: drop superfluous pm_runtime calls around musb_shutdown

2012-01-12 Thread Felipe Contreras
() doesn't access the device, so just drop those runtime_pm calls. I don't understand what is the relationship with 4f9edd2d7e8d and musb_shutdown(), it seems this patch is basically reverting 4f9edd2d7e8d. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] usb: musb: drop superfluous pm_runtime calls around musb_shutdown

2012-01-12 Thread Felipe Contreras
On Thu, Jan 12, 2012 at 5:55 PM, Grazvydas Ignotas nota...@gmail.com wrote: On Thu, Jan 12, 2012 at 5:45 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Thu, Jan 12, 2012 at 3:21 PM, Grazvydas Ignotas nota...@gmail.com wrote: Since commit 4f9edd2d7e8d usb: musb: Fix the crash issue

Re: It looks like snd-soc-rx51 only works as built-in, not as a module

2012-01-02 Thread Felipe Contreras
On Sat, Dec 31, 2011 at 2:59 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Fri, Dec 30, 2011 at 10:00:55PM +0200, Felipe Contreras wrote: On Thu, Dec 29, 2011 at 11:54 PM, Mark Brown On Thu, Dec 29, 2011 at 11:51:11PM +0200, Felipe Contreras wrote: That should

Re: It looks like snd-soc-rx51 only works as built-in, not as a module

2011-12-30 Thread Felipe Contreras
On Thu, Dec 29, 2011 at 11:54 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Dec 29, 2011 at 11:51:11PM +0200, Felipe Contreras wrote: On Thu, Dec 29, 2011 at 11:27 PM, Mark Brown On Thu, Dec 29, 2011 at 11:25:50PM +0200, Felipe Contreras wrote: On Thu, Dec 29, 2011 at 8

Re: It looks like snd-soc-rx51 only works as built-in, not as a module

2011-12-29 Thread Felipe Contreras
On Thu, Dec 29, 2011 at 8:37 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Sat, Dec 10, 2011 at 05:59:57PM +0200, Felipe Contreras wrote: It was not working for me, but it seems the problem was related to mdev/udev; snd_soc_tlv320aic3x has to be loaded before snd-soc-rx51

Re: It looks like snd-soc-rx51 only works as built-in, not as a module

2011-12-29 Thread Felipe Contreras
On Thu, Dec 29, 2011 at 11:27 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Dec 29, 2011 at 11:25:50PM +0200, Felipe Contreras wrote: On Thu, Dec 29, 2011 at 8:37 PM, Mark Brown On Sat, Dec 10, 2011 at 05:59:57PM +0200, Felipe Contreras wrote: It was not working for me

Re: [PATCH v4 4/4] OMAP3/4: iommu: adapt to runtime pm

2011-12-27 Thread Felipe Contreras
On Sun, Dec 25, 2011 at 2:03 AM, Ramirez Luna, Omar omar.rami...@ti.com wrote: On Fri, Dec 23, 2011 at 11:04 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Which omap-iommu? The platform driver, or the device stuff? The device stuff is always built-in, but not the platform driver

Re: [PATCH v4 4/4] OMAP3/4: iommu: adapt to runtime pm

2011-12-23 Thread Felipe Contreras
On Fri, Dec 23, 2011 at 6:30 PM, Ramirez Luna, Omar omar.rami...@ti.com wrote: On Mon, Dec 19, 2011 at 10:27 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Fri, Dec 16, 2011 at 5:18 AM, Ramirez Luna, Omar omar.rami...@ti.com wrote: On Thu, Dec 15, 2011 at 6:53 PM, Felipe Contreras

Re: [PATCH 01/10] arm: omap4: fix kconfig warning

2011-12-22 Thread Felipe Contreras
On Thu, Dec 22, 2011 at 8:22 PM, Tony Lindgren t...@atomide.com wrote: * Felipe Contreras felipe.contre...@gmail.com [111219 16:11]: warning: (ARCH_OMAP4 ARCH_VEXPRESS_CA9X4) selects ARM_ERRATA_720789 which has unmet direct dependencies (CPU_V7 SMP) Thanks applying into fixes-non-critical

Re: [PATCH 1/3] usb: musb: fix pm_runtime mismatches

2011-12-20 Thread Felipe Contreras
On Tue, Dec 20, 2011 at 1:19 PM, Felipe Balbi ba...@ti.com wrote: On Mon, Dec 19, 2011 at 10:20:09PM +0200, Felipe Contreras wrote: On Mon, Dec 19, 2011 at 10:11 AM, Felipe Balbi ba...@ti.com wrote: On Fri, Dec 16, 2011 at 01:05:08AM +0200, Felipe Contreras wrote: Properly call

Re: [PATCH v4 1/4] OMAP3: hwmod data: add mmu data for iva and isp

2011-12-19 Thread Felipe Contreras
On Fri, Dec 16, 2011 at 4:01 AM, Ramirez Luna, Omar omar.rami...@ti.com wrote: On Thu, Dec 15, 2011 at 6:39 PM, Felipe Contreras felipe.contre...@gmail.com wrote: Are you sure you are not missing something like:  .clk = cam_ick, I believe in this case cam_ick is used as the main clock

Re: [PATCH v4 4/4] OMAP3/4: iommu: adapt to runtime pm

2011-12-19 Thread Felipe Contreras
On Fri, Dec 16, 2011 at 5:18 AM, Ramirez Luna, Omar omar.rami...@ti.com wrote: On Thu, Dec 15, 2011 at 6:53 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Thu, Dec 15, 2011 at 6:18 AM, Omar Ramirez Luna omar.rami...@ti.com wrote: Use runtime PM functionality interfaced with hwmod

Re: ZOOM2 doesn't boot on upstream kernel

2011-12-19 Thread Felipe Contreras
On Fri, Dec 16, 2011 at 10:53 PM, Tony Lindgren t...@atomide.com wrote: You should use ttyO for the omap ports, but zoom debug board has external 8250 ftdi ports, so those show up as ttyS and not ttyO. Plus that was changed on 2.6.36 (or after?) and he is using 2.6.35. -- Felipe Contreras

[PATCH v2] usb: musb: fix pm_runtime mismatch

2011-12-19 Thread Felipe Contreras
From: Felipe Contreras felipe.contre...@gmail.com In musb_init_controller() there's a pm_runtime_put(), but there's no pm_runtime_get(), which creates a mismatch that causes the driver to sleep when it shouldn't. This was introduced in 7acc619[1], but it wasn't triggered in my setup until

[PATCH v2 4/4] musb: omap2430: avoid pm_runtime_disable()

2011-12-19 Thread Felipe Contreras
From: Felipe Contreras felipe.contre...@gmail.com These are handled by drivers core, and in a way that doesn't wake up the devices. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/usb/musb/omap2430.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/3] usb: musb: fix pm_runtime mismatches

2011-12-19 Thread Felipe Contreras
On Mon, Dec 19, 2011 at 10:11 AM, Felipe Balbi ba...@ti.com wrote: On Fri, Dec 16, 2011 at 01:05:08AM +0200, Felipe Contreras wrote: Properly call pm_runtime_put() afer pm_runttime_get() on errors. Untested. sorry, but I'm not applying untested patches. I need someone to give a Tested

[PATCH v2 1/4] usb: musb: fix pm_runtime mismatches

2011-12-19 Thread Felipe Contreras
From: Felipe Contreras felipe.contre...@gmail.com Properly call pm_runtime_put() afer pm_runttime_get() on errors. Comments from Alan Stern. Untested. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/usb/musb/musb_gadget.c |1 + drivers/usb/musb/omap2430.c|1

[PATCH v2 3/4] usb: musb: remove a bit of indentation

2011-12-19 Thread Felipe Contreras
From: Felipe Contreras felipe.contre...@gmail.com And use dev instead of musb-controller. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/usb/musb/omap2430.c | 27 +-- 1 files changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/usb

[PATCH v2 2/4] usb: musb: trivial cleanup

2011-12-19 Thread Felipe Contreras
From: Felipe Contreras felipe.contre...@gmail.com enabled driver || !enabled can be simplified to !enabled || driver. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/usb/musb/omap2430.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git

[PATCH v2 0/4] musb fixes and cleanups

2011-12-19 Thread Felipe Contreras
Hi, Here's a few cleanups and possible fixes. Nothing major. In v2 I added comments from Alan Stern, and another possible fix by removing some pm_runtime_disable() calls. Felipe Contreras (4): usb: musb: fix pm_runtime mismatches usb: musb: trivial cleanup usb: musb: remove a bit

Re: [PATCH 1/3] usb: musb: fix pm_runtime mismatches

2011-12-19 Thread Felipe Contreras
On Fri, Dec 16, 2011 at 5:30 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 16 Dec 2011, Felipe Contreras wrote: Should these calls be pm_runtime_put_sync() instead of pm_runtime_put()? I don't see why... The thing failed, it's not going to be used any more so better let PM

[PATCH 01/10] arm: omap4: fix kconfig warning

2011-12-19 Thread Felipe Contreras
warning: (ARCH_OMAP4 ARCH_VEXPRESS_CA9X4) selects ARM_ERRATA_720789 which has unmet direct dependencies (CPU_V7 SMP) Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- arch/arm/mach-omap2/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm

[PATCH 04/10] arm: omap2: fix regulator warnings

2011-12-19 Thread Felipe Contreras
warning: (MACH_OMAP_ZOOM2 MACH_OMAP_ZOOM3 MACH_OMAP_4430SDP MACH_OMAP4_PANDA TPS6105X) selects REGULATOR_FIXED_VOLTAGE which has unmet direct dependencies (REGULATOR) Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- arch/arm/mach-omap2/Kconfig | 10 +- 1 files

[PATCH 03/10] arm: omap2: fix omap3 touchbook kconfig warning

2011-12-19 Thread Felipe Contreras
BACKLIGHT_LCD_SUPPORT) A lot of boards need BACKLIGHT_CLASS_DEVICE for the framebuffers to work, but it's not *needed* for the device itself. It might be nice to enable it by default somewhoe if graphics stuff is enabled, but that's another story. Signed-off-by: Felipe Contreras felipe.contre

Re: Issue with isp1704 loaded too soon

2011-12-15 Thread Felipe Contreras
On Thu, Dec 15, 2011 at 1:15 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Tue, Dec 13, 2011 at 11:19 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Dec 12, 2011 at 9:09 AM, Jarkko Nikula jarkko.nik...@bitmer.com wrote: Indeed yes. I checked that in 3.0 it still

Re: Issue with isp1704 loaded too soon

2011-12-15 Thread Felipe Contreras
On Thu, Dec 15, 2011 at 7:51 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Thu, Dec 15, 2011 at 1:15 AM, Felipe Contreras felipe.contre...@gmail.com wrote: On Tue, Dec 13, 2011 at 11:19 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Dec 12, 2011 at 9:09 AM, Jarkko

[PATCH 0/3] musb fixes and cleanups

2011-12-15 Thread Felipe Contreras
Hi, Here's a few cleanups and a possible fix. Nothing major. Felipe Contreras (3): usb: musb: fix pm_runtime mismatches usb: musb: trivial cleanup usb: musb: remove a bit of indentation drivers/usb/musb/musb_gadget.c |1 + drivers/usb/musb/omap2430.c| 36

[PATCH 1/3] usb: musb: fix pm_runtime mismatches

2011-12-15 Thread Felipe Contreras
Properly call pm_runtime_put() afer pm_runttime_get() on errors. Untested. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/usb/musb/musb_gadget.c |1 + drivers/usb/musb/omap2430.c|1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/usb

[PATCH 2/3] usb: musb: trivial cleanup

2011-12-15 Thread Felipe Contreras
enabled driver || !enabled can be simplified to !enabled || driver. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/usb/musb/omap2430.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430

[PATCH 3/3] usb: musb: remove a bit of indentation

2011-12-15 Thread Felipe Contreras
And use dev instead of musb-controller. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- drivers/usb/musb/omap2430.c | 27 +-- 1 files changed, 13 insertions(+), 14 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index

Re: [PATCH v4 4/4] OMAP3/4: iommu: adapt to runtime pm

2011-12-15 Thread Felipe Contreras
if this is needed; you want to resume the driver? AFAICS kfree will take care of that _without_ resuming.        dev_info(pdev-dev, %s removed\n, obj-name);        kfree(obj);        return 0; Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: [PATCH v4 1/4] OMAP3: hwmod data: add mmu data for iva and isp

2011-12-15 Thread Felipe Contreras
, +       .slaves         = omap3xxx_isp_mmu_slaves, +       .slaves_cnt     = ARRAY_SIZE(omap3xxx_isp_mmu_slaves), +       .flags          = HWMOD_NO_IDLEST, +}; Most of the stuff I see the hwmods is .main_lock = foo_fck, slave .clk = foo_ick. Maybe that explains the irq issues you get. Cheers. -- Felipe

Re: [PATCH v4 3/4] OMAP3/4: iommu: migrate to hwmod framework

2011-12-15 Thread Felipe Contreras
by omap_device and prevents driver from loading.  - Now unused, remove platform device and resource data, handling   of sysconfig register for softreset purposes, use default   latency structure. Looks good to me. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v4 4/4] OMAP3/4: iommu: adapt to runtime pm

2011-12-15 Thread Felipe Contreras
() be called in omap_iommu_init(), and omap_iommu_probe() call pm_runtime_get_sync()/put() on the sections where the device should be active? Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: problem with twl4030 GPIO irqs

2011-12-15 Thread Felipe Contreras
irq code better look at this? I think this should reproduce on beagle too. Basically all the modules of twl4030 should be converted to use request_threaded_irq(), if they are not, they will fail, and that's good, as trying to workaround the issue would just cause more trouble. -- Felipe Contreras

Re: [PATCH 1/3] usb: musb: fix pm_runtime mismatches

2011-12-15 Thread Felipe Contreras
On Fri, Dec 16, 2011 at 1:22 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 16 Dec 2011, Felipe Contreras wrote: Properly call pm_runtime_put() afer pm_runttime_get() on errors. Untested. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com ---  drivers/usb/musb

Re: Interrupt issue in twl4030_keypad

2011-12-15 Thread Felipe Contreras
On Mon, Dec 12, 2011 at 11:34 PM, Felipe Balbi ba...@ti.com wrote: On Mon, Dec 12, 2011 at 10:55:11PM +0200, Felipe Contreras wrote: Samuel assumed it was ok and, like I said above, it worked for my simple GPIO usecase with beagleboard. Well, for 3.2 I think the situation is fine

Re: [PATCH 2/2] Revert ARM: RX-51: Enable isp1704 power on/off

2011-12-14 Thread Felipe Contreras
On Wed, Dec 14, 2011 at 9:30 AM, Felipe Balbi ba...@ti.com wrote: On Wed, Dec 14, 2011 at 01:02:09AM +0200, Felipe Contreras wrote: On Wed, Dec 14, 2011 at 12:53 AM, Felipe Balbi ba...@ti.com wrote: patches are welcome The were not last times: http://mid.gmane.org/1288656853-4625-1-git-send

Issue with isp1704 loaded too soon

2011-12-14 Thread Felipe Contreras
On Tue, Dec 13, 2011 at 11:19 PM, Felipe Contreras felipe.contre...@gmail.com wrote: On Mon, Dec 12, 2011 at 9:09 AM, Jarkko Nikula jarkko.nik...@bitmer.com wrote: Indeed yes. I checked that in 3.0 it still works but not in 3.1 so some non isp1704_charger change has broke it as there hasn't

Re: [PATCH 0/4] fixes for twl4030-irq in mainline

2011-12-13 Thread Felipe Contreras
that has a twl4030 chip will immediately hang on the first interrupt, and many functions of twl4030 will just not work without the second one. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] omap: rx51: initialize isp1704 properly

2011-12-13 Thread Felipe Contreras
On Mon, Dec 12, 2011 at 9:44 PM, Tony Lindgren t...@atomide.com wrote: * Felipe Contreras felipe.contre...@gmail.com [111208 11:52]: On Thu, Dec 8, 2011 at 4:40 PM, Heikki Krogerus kro...@gmail.com wrote: On Wed, Dec 07, 2011 at 09:56:56PM +0200, Felipe Contreras wrote: From: Heikki Krogerus

Re: [PATCH 2/2] Revert ARM: RX-51: Enable isp1704 power on/off

2011-12-13 Thread Felipe Contreras
this USB Kconfig stuff is completely messed up. *Sigh* -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] Revert ARM: RX-51: Enable isp1704 power on/off

2011-12-13 Thread Felipe Contreras
On Wed, Dec 14, 2011 at 12:53 AM, Felipe Balbi ba...@ti.com wrote: On Tue, Dec 13, 2011 at 11:19:52PM +0200, Felipe Contreras wrote: On Mon, Dec 12, 2011 at 9:09 AM, Jarkko Nikula jarkko.nik...@bitmer.com wrote: Indeed yes. I checked that in 3.0 it still works but not in 3.1 so some non

Re: [PATCH 6/7] mfd: twl4030-irq: set irq nested flag

2011-12-12 Thread Felipe Contreras
*/ -       local_irq_enable();        isr = sih_read_isr(sih); -       local_irq_disable(); But handle_twl4030_sih is still not nested. Fortunately, Neil Brown already fixed the issues in this patch by making handle_twl4030_sih truly nested: http://article.gmane.org/gmane.linux.kernel/1220708 Cheers. -- Felipe

Interrupt issue in twl4030_keypad

2011-12-12 Thread Felipe Contreras
://article.gmane.org/gmane.linux.ports.arm.omap/67333 -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Interrupt issue in twl4030_keypad

2011-12-12 Thread Felipe Contreras
On Mon, Dec 12, 2011 at 9:12 PM, Felipe Balbi ba...@ti.com wrote: On Mon, Dec 12, 2011 at 08:30:49PM +0200, Felipe Contreras wrote: The short version is this: either we revert this patch[1], or we apply this patch series[2], as well as its essential fixes[3]. The long version is this. There's

Re: Interrupt issue in twl4030_keypad

2011-12-12 Thread Felipe Contreras
On Mon, Dec 12, 2011 at 9:23 PM, Greg KH gre...@suse.de wrote: On Mon, Dec 12, 2011 at 08:30:49PM +0200, Felipe Contreras wrote: The short version is this: either we revert this patch[1], or we apply this patch series[2], as well as its essential fixes[3]. The long version is this. There's

  1   2   3   4   5   6   7   8   >