Re: [PATCH v2] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup

2012-05-11 Thread Raja, Govindraj
On Fri, May 11, 2012 at 12:41 AM, Tony Lindgren t...@atomide.com wrote: * Govindraj.R govindraj.r...@ti.com [120510 06:09]: From: Govindraj.R govindraj.r...@ti.com The commit (bce492c0  ARM: OMAP2+: UART: Fix incorrect population of default uart pads) removed default uart pads that where

Re: [PATCH v2] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup

2012-05-11 Thread Raja, Govindraj
On Fri, May 11, 2012 at 2:04 PM, Russ Dill russ.d...@gmail.com wrote: On Thu, May 10, 2012 at 6:05 AM, Govindraj.R govindraj.r...@ti.com wrote: From: Govindraj.R govindraj.r...@ti.com The commit (bce492c0  ARM: OMAP2+: UART: Fix incorrect population of default uart pads) removed default uart

Re: [PATCH 0/8] gpio/omap: remaining cleanups and fix

2012-05-10 Thread Raja, Govindraj
Hi Tarun, On Fri, Apr 27, 2012 at 7:43 PM, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: Here are the remaining cleanup patches. There are broadly two categories of cleanups. Cat-1: Those missed while introducing new feature like SPARSE_IRQ       handling and DT support; use edge/level

Re: Broken UART I/O wakeups on v3.4-rc4+

2012-05-08 Thread Raja, Govindraj
On Tue, May 8, 2012 at 10:35 AM, Paul Walmsley p...@pwsan.com wrote: Govindraj, After your commit bce492c04ba8fc66a4ea0a52b181ba255daaaf54 (ARM: OMAP2+: UART: Fix incorrect population of default uart pads), the kernel does not return from static suspend when off-mode is enabled upon

Re: [PATCH] omap3_beagle: init uart2 for beagle rev AX/BX only

2012-05-07 Thread Raja, Govindraj
On Fri, May 4, 2012 at 11:48 PM, Tony Lindgren t...@atomide.com wrote: Hi, Looking at this again.. * Govindraj.R govindraj.r...@ti.com [120306 00:34]: From: Govindraj.R govindraj.r...@ti.com All beagle boards rev AX/BX have external usb hubs connected to ehci interface, external

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-05-03 Thread Raja, Govindraj
On Thu, May 3, 2012 at 6:55 AM, Russ Dill russ.d...@ti.com wrote: On Wed, May 2, 2012 at 3:38 AM, Raja, Govindraj govindraj.r...@ti.com wrote: On Wed, May 2, 2012 at 2:17 PM, Russ Dill russ.d...@ti.com wrote: On Mon, Mar 19, 2012 at 6:34 AM, Raja, Govindraj govindraj.r...@ti.com wrote

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-05-02 Thread Raja, Govindraj
On Wed, May 2, 2012 at 2:17 PM, Russ Dill russ.d...@ti.com wrote: On Mon, Mar 19, 2012 at 6:34 AM, Raja, Govindraj govindraj.r...@ti.com wrote: On Mon, Mar 19, 2012 at 12:12 PM, Keshava Munegowda keshava_mgo...@ti.com wrote: From: Keshava Munegowda keshava_mgo...@ti.com It is observed

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-05-02 Thread Raja, Govindraj
On Wed, May 2, 2012 at 4:20 PM, Koen Kooi k...@dominion.thruhere.net wrote: Op 2 mei 2012, om 12:38 heeft Raja, Govindraj het volgende geschreven: On Wed, May 2, 2012 at 2:17 PM, Russ Dill russ.d...@ti.com wrote: On Mon, Mar 19, 2012 at 6:34 AM, Raja, Govindraj govindraj.r...@ti.com wrote

Re: [PATCH 1/2] OMAP2+: UART: Fix incorrect population of default uart pads

2012-04-24 Thread Raja, Govindraj
On Tue, Apr 24, 2012 at 5:15 AM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: From: Govindraj.R govindraj.r...@ti.com The following commit: (7496ba3  ARM: OMAP2+: UART: Add default mux for all uarts) added default pads for all uarts. But not all boards tend

Re: defconfig for panda

2012-04-24 Thread Raja, Govindraj
On Fri, Apr 20, 2012 at 10:43 PM, Tony Lindgren t...@atomide.com wrote: * Matt Porter mpor...@ti.com [120420 09:04]: On Fri, Mar 30, 2012 at 02:39:32PM -0700, Tony Lindgren wrote: * Kumar Gala ga...@kernel.crashing.org [120330 14:14]: On Mar 30, 2012, at 1:48 PM, Tony Lindgren wrote:

Re: [PATCH] tty: serial_core: Add mechanism to identify port closure.

2012-04-23 Thread Raja, Govindraj
Hi Alan, On Fri, Apr 20, 2012 at 6:57 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index 9c4c05b..0dc246d 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -1284,6 +1284,8

Re: [PATCH] tty: omap-serial: Keep the wakeup mechanism enabled by default

2012-04-19 Thread Raja, Govindraj
On Thu, Apr 19, 2012 at 12:38 AM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: The point is that wakeups should be enabled whenever driver is in use, and disabled when the driver is not in use. Which is the tty_port methods for initialisation and shutdown, which are mutex protected against each

Re: [PATCH] tty: omap-serial: Keep the wakeup mechanism enabled by default

2012-04-18 Thread Raja, Govindraj
On Wed, Apr 18, 2012 at 4:55 AM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: From: Govindraj.R govindraj.r...@ti.com The wakeups can be left enabled by default and should be disabled only when disabled from sysfs and while entering suspend. Left enabled?  

Re: [PATCH 2/2] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup

2012-04-17 Thread Raja, Govindraj
On Tue, Apr 17, 2012 at 7:11 AM, Tony Lindgren t...@atomide.com wrote: Hi, Few more comments below. * Raja, Govindraj govindraj.r...@ti.com [120411 04:53]: ... +static int  __init omap_serial_fill_default_pads(struct omap_board_data *bdata

Re: [GIT PULL]: omap-serial updates for 3.4-rc

2012-04-16 Thread Raja, Govindraj
Hi Tony, On Tue, Apr 10, 2012 at 3:36 PM, Raja, Govindraj govindraj.r...@ti.com wrote: CC'ing Linux-ARM On Tue, Apr 10, 2012 at 3:32 PM, Govindraj.R govindraj.r...@ti.com wrote: Hi Tony, Please Pull the following omap uart changes. Changes basically involves getting rid of cpu checks

Re: [PATCH] ARM: OMAP: serial: Fix the ocp smart idlemode handling bug

2012-04-16 Thread Raja, Govindraj
On Fri, Apr 13, 2012 at 11:25 PM, Santosh Shilimkar santosh.shilim...@ti.com wrote: The current serial UART code, while fidling with ocp idlemode bits, forget about the smart idle wakeup bit even if it is supported by UART IP block. This will lead to missing the module wakeup on OMAP's where

Re: [GIT PULL]: omap-serial updates for 3.4-rc

2012-04-16 Thread Raja, Govindraj
On Mon, Apr 16, 2012 at 12:52 PM, Raja, Govindraj govindraj.r...@ti.com wrote: Hi Tony, On Tue, Apr 10, 2012 at 3:36 PM, Raja, Govindraj govindraj.r...@ti.com wrote: CC'ing Linux-ARM On Tue, Apr 10, 2012 at 3:32 PM, Govindraj.R govindraj.r...@ti.com wrote: Hi Tony, Please Pull

Re: omap-serial: transmission of x-char with DMA (and other issues)

2012-04-16 Thread Raja, Govindraj
On Fri, Apr 13, 2012 at 4:11 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Can someone tell me how this works with the current omap-serial driver please?  It looks to me like this has been broken when DMA support was added to the driver. Yes x-char transmission in dma case is

Re: Suspend broken on 3.3?

2012-04-12 Thread Raja, Govindraj
On Thu, Apr 12, 2012 at 1:04 AM, Paul Walmsley p...@pwsan.com wrote: Hi a few brief comments based on a quick scan: On Wed, 11 Apr 2012, Raja, Govindraj wrote: Here is the patch [1] to do the same. - I don't see where it affects I/O wakeups for the UART.  If I/O wakeups are still set

Re: [PATCH 2/2] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup

2012-04-11 Thread Raja, Govindraj
On Tue, Apr 10, 2012 at 9:41 PM, Tony Lindgren t...@atomide.com wrote: * Govindraj.R govindraj.r...@ti.com [120410 06:44]: --- a/arch/arm/mach-omap2/serial.c +++ b/arch/arm/mach-omap2/serial.c @@ -120,11 +120,63 @@ static void omap_uart_set_smartidle(struct platform_device *pdev) {}  #endif

Re: Suspend broken on 3.3?

2012-04-11 Thread Raja, Govindraj
On Tue, Apr 10, 2012 at 11:33 PM, Kevin Hilman khil...@ti.com wrote: Raja, Govindraj govindraj.r...@ti.com writes: Hi Kevin, On Mon, Apr 9, 2012 at 10:40 PM, Kevin Hilman khil...@ti.com wrote: Paul Walmsley p...@pwsan.com writes: [...] Just to summarize on how the behavior should be IIUC

Re: Suspend broken on 3.3?

2012-04-10 Thread Raja, Govindraj
Hi Kevin, On Mon, Apr 9, 2012 at 10:40 PM, Kevin Hilman khil...@ti.com wrote: Paul Walmsley p...@pwsan.com writes: [...] I don't understand why a user would ever want to disable dynamic wakeups on an in-use serial port via the sysfs power/wakeup file.  (Disabling wakeups from suspend is a

Re: [GIT PULL]: omap-serial updates for 3.4-rc

2012-04-10 Thread Raja, Govindraj
CC'ing Linux-ARM On Tue, Apr 10, 2012 at 3:32 PM, Govindraj.R govindraj.r...@ti.com wrote: Hi Tony, Please Pull the following omap uart changes. Changes basically involves getting rid of cpu checks for populating erratas and features and move the same from serial.c to omap-serial.c, MVR

Re: [RESEND PATCH] ARM :OMAP2+: UART: Remove some of uart default pads

2012-04-09 Thread Raja, Govindraj
Hi Tony, On Fri, Apr 6, 2012 at 11:45 PM, Tony Lindgren t...@atomide.com wrote: * Raja, Govindraj govindraj.r...@ti.com [120405 23:08]: On Thu, Apr 5, 2012 at 10:28 PM, Tony Lindgren t...@atomide.com wrote: Hmm I don't think any muxing was done automatically unless omap_serial_init_port

Re: Suspend broken on 3.3?

2012-04-09 Thread Raja, Govindraj
Hi Kevin / Paul, On Fri, Apr 6, 2012 at 7:51 PM, Kevin Hilman khil...@ti.com wrote: Paul Walmsley p...@pwsan.com writes: On Wed, 4 Apr 2012, Raja, Govindraj wrote: On Wed, Apr 4, 2012 at 8:26 PM, Paul Walmsley p...@pwsan.com wrote: On Mon, 2 Apr 2012, Raja, Govindraj wrote: As of now

Re: [RESEND PATCH] ARM :OMAP2+: UART: Remove some of uart default pads

2012-04-06 Thread Raja, Govindraj
On Thu, Apr 5, 2012 at 10:28 PM, Tony Lindgren t...@atomide.com wrote: * Raja, Govindraj govindraj.r...@ti.com [120403 23:18]: On Tue, Apr 3, 2012 at 11:49 PM, Tony Lindgren t...@atomide.com wrote: * Govindraj.R govindraj.r...@ti.com [120321 03:06]: From: Govindraj.R govindraj.r...@ti.com

Re: OMAP3EVM not booting on l-o master

2012-04-05 Thread Raja, Govindraj
Hi Afzal, On Thu, Apr 5, 2012 at 3:47 PM, Paul Walmsley p...@pwsan.com wrote: cc Tony Hi, On Thu, 5 Apr 2012, Mohammed, Afzal wrote: On Thu, Apr 05, 2012 at 15:03:36, Paul Walmsley wrote: Could you try booting with initcall_debug and posting the boot log? Logs as follows, thanks.

Re: [PATCH 0/3] OMAP2+: UART: Enable tx wakeup + remove cpu checks

2012-04-05 Thread Raja, Govindraj
On Wed, Mar 21, 2012 at 3:54 PM, Govindraj.R govindraj.r...@ti.com wrote: From: Govindraj.R govindraj.r...@ti.com Based on Linux-OMAP tree uart branch. (git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git remotes/origin/uart) * Removes the cpu checks wherever possible and

Re: [RESEND PATCH] ARM :OMAP2+: UART: Remove some of uart default pads

2012-04-04 Thread Raja, Govindraj
On Tue, Apr 3, 2012 at 11:49 PM, Tony Lindgren t...@atomide.com wrote: * Govindraj.R govindraj.r...@ti.com [120321 03:06]: From: Govindraj.R govindraj.r...@ti.com The following commit: (7496ba3  ARM: OMAP2+: UART: Add default mux for all uarts) added default pads for all uarts. But not all

Re: Suspend broken on 3.3?

2012-04-04 Thread Raja, Govindraj
On Wed, Apr 4, 2012 at 8:26 PM, Paul Walmsley p...@pwsan.com wrote: Hello Govindraj On Mon, 2 Apr 2012, Raja, Govindraj wrote: As of now what I can think of is to update qos reqest to prevent MPU from transitioning in case of port activity if wakeup capability for port is disabled

Re: Suspend broken on 3.3?

2012-04-03 Thread Govindraj
On Mon, Apr 2, 2012 at 6:07 PM, Joe Woodward j...@terrafix.co.uk wrote: -Original Message- From: Raja, Govindraj govindraj.r...@ti.com To: Joe Woodward j...@terrafix.co.uk, Kevin Hilman khil...@ti.com Cc: Paul Walmsley p...@pwsan.com, linux-omap@vger.kernel.org, Felipe Balbi ba

Re: Suspend broken on 3.3?

2012-03-30 Thread Raja, Govindraj
On Fri, Mar 30, 2012 at 1:23 PM, Joe Woodward j...@terrafix.co.uk wrote: -Original Message- From: Raja, Govindraj govindraj.r...@ti.com To: Joe Woodward j...@terrafix.co.uk Cc: Paul Walmsley p...@pwsan.com, Kevin Hilman khil...@ti.com, linux-omap@vger.kernel.org, Felipe Balbi ba

Re: Suspend broken on 3.3?

2012-03-30 Thread Raja, Govindraj
On Fri, Mar 30, 2012 at 2:56 PM, Joe Woodward j...@terrafix.co.uk wrote: ...[snip]... Could you please try attached patch and let me know if this solves the rx issue as well, without using dma mode. Right, I think we've getting closer, but still not quite there... Firstly, the patch

Re: Suspend broken on 3.3?

2012-03-30 Thread Raja, Govindraj
On Fri, Mar 30, 2012 at 4:34 PM, Joe Woodward j...@terrafix.co.uk wrote: -Original Message- From: Raja, Govindraj govindraj.r...@ti.com To: Joe Woodward j...@terrafix.co.uk Cc: Paul Walmsley p...@pwsan.com, Kevin Hilman khil...@ti.com, linux-omap@vger.kernel.org, Felipe Balbi ba

Re: [PATCH 1/3] OMAP2+: UART: Remove cpu checks for populating errata flags

2012-03-29 Thread Raja, Govindraj
On Wed, Mar 28, 2012 at 10:13 PM, Jon Hunter jon-hun...@ti.com wrote: Hi Govindraj, On 3/28/2012 6:09, Raja, Govindraj wrote: On Wed, Mar 28, 2012 at 2:38 AM, Jon Hunterjon-hun...@ti.com  wrote: Hi Govindraj, [...] +       u32 mvr, scheme; +       u16 revision, major, minor

Re: Suspend broken on 3.3?

2012-03-29 Thread Raja, Govindraj
On Thu, Mar 29, 2012 at 5:10 PM, Joe Woodward j...@terrafix.co.uk wrote: -Original Message- From: Joe Woodward j...@terrafix.co.uk To: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@ti.com, Raja\\, Govindraj govindraj.r...@ti.com, linux-omap@vger.kernel.org, Felipe Balbi

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-03-28 Thread Raja, Govindraj
On Wed, Mar 28, 2012 at 2:22 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Mar 27, 2012 at 04:08:55PM +0200, Igor Grinberg wrote: When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not call the gpio_set_value() function, but gpio_set_value_cansleep().

Re: Suspend broken on 3.3?

2012-03-28 Thread Raja, Govindraj
On Wed, Mar 28, 2012 at 3:07 AM, Kevin Hilman khil...@ti.com wrote: Raja, Govindraj govindraj.r...@ti.com writes: Hi Kevin, On Tue, Mar 27, 2012 at 6:04 AM, Kevin Hilman khil...@ti.com wrote: +Govindraj, Joe Woodward j...@terrafix.co.uk writes: Right, I've stepped back a bit and dug out

Re: [PATCH 1/3] OMAP2+: UART: Remove cpu checks for populating errata flags

2012-03-28 Thread Raja, Govindraj
On Wed, Mar 28, 2012 at 2:38 AM, Jon Hunter jon-hun...@ti.com wrote: Hi Govindraj, On 3/21/2012 5:24, Govindraj.R wrote: From: Govindraj.Rgovindraj.r...@ti.com Currently the errata is populated based on cpu checks this can be removed and replaced with module version check of uart ip block

Re: Suspend broken on 3.3?

2012-03-27 Thread Raja, Govindraj
Hi Kevin, On Tue, Mar 27, 2012 at 6:04 AM, Kevin Hilman khil...@ti.com wrote: +Govindraj, Joe Woodward j...@terrafix.co.uk writes: Right, I've stepped back a bit and dug out a GUSMTIX Palo43 carrier board on which to test the Overo OMAP3530 COM and I've found:  - Running a stock 3.3

Re: [PATCH 0/3] OMAP2+: UART: Enable tx wakeup + remove cpu checks

2012-03-23 Thread Raja, Govindraj
Hi Paul, On Fri, Mar 23, 2012 at 5:10 AM, Paul Walmsley p...@pwsan.com wrote: Hi On Thu, 22 Mar 2012, Raja, Govindraj wrote: Sorry I for got to add that, here are details on what was tested. 1.) OMAP2430 SDP : Boot tested with uart1 as console. 2.) OMAP3430 SDP: Boot test, suspend/resume

Re: [PATCH 0/3] OMAP2+: UART: Enable tx wakeup + remove cpu checks

2012-03-22 Thread Raja, Govindraj
On Wed, Mar 21, 2012 at 7:58 PM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: From: Govindraj.R govindraj.r...@ti.com Based on Linux-OMAP tree uart branch. (git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git remotes/origin/uart) * Removes

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-03-19 Thread Raja, Govindraj
On Mon, Mar 19, 2012 at 12:12 PM, Keshava Munegowda keshava_mgo...@ti.com wrote: From: Keshava Munegowda keshava_mgo...@ti.com It is observed that the echi ports of 3430 sdp board are not working due to the random timing of programming the associated GPIOs of the ULPI PHYs of the EHCI for

Re: [PATCH] omap_hwmod: Allow io_ring wakeup configuration for all modules.

2012-03-12 Thread Raja, Govindraj
On Wed, Mar 7, 2012 at 7:40 PM, Raja, Govindraj govindraj.r...@ti.com wrote: On Wed, Mar 7, 2012 at 5:49 PM, Govindraj.R govindraj.r...@ti.com wrote: [...] From b3aa1dac5909cad1b959f5b97bbf408b2f974060 Mon Sep 17 00:00:00 2001 From: Govindraj.R govindraj.r...@ti.com Date: Wed, 7 Mar 2012

Re: [RFC PATCH] OMAP: UART: Enable tx wakeup bit in wer

2012-03-08 Thread Raja, Govindraj
On Wed, Mar 7, 2012 at 11:27 AM, Paul Walmsley p...@pwsan.com wrote: Hi On Tue, 6 Mar 2012, Raja, Govindraj wrote: I see two ways of adding this tx wake-up flag. 1.) passing a feature flag from pdata and populating the feature value to wer. 2.) Duplicating the uart1/2/3 hwmod

Re: [PATCH] omap_hwmod: Allow io_ring wakeup configuration for all modules.

2012-03-07 Thread Raja, Govindraj
On Wed, Mar 7, 2012 at 5:49 PM, Govindraj.R govindraj.r...@ti.com wrote: From: Govindraj.R govindraj.r...@ti.com Some modules doesn't have SYSC_HAS_ENAWAKEUP bit available (ex: usb host uhh module) in absence of this flag omap_hwmod_enable/disable_wakeup avoids configuring pad mux wakeup

Re: help: BeagleBoard xM RevC ethernet port

2012-03-07 Thread Govindraj
On Thu, Mar 8, 2012 at 2:26 AM, Brian Austin brian.aus...@cirrus.com wrote: On Wed, 7 Mar 2012, Brian Austin wrote: On Thu, 1 Mar 2012, Govindraj wrote: On Wed, Feb 29, 2012 at 11:36 PM, Brian Austin brian.aus...@cirrus.com wrote: Applying this patch gives this on my beagleboard xM revC

Re: [PATCH] omap3_beagle: Init only uart3 used for console

2012-03-06 Thread Raja, Govindraj
On Mon, Mar 5, 2012 at 7:36 PM, Koen Kooi k...@dominion.thruhere.net wrote: Op 5 mrt. 2012, om 12:12 heeft Govindraj.R het volgende geschreven: From: Govindraj.R govindraj.r...@ti.com On beagle some of uart mux lines are used for other purpose so init only uart3. Uart2 rx line clashes

Re: [PATCH] omap3_beagle: Init only uart3 used for console

2012-03-06 Thread Raja, Govindraj
On Tue, Mar 6, 2012 at 1:30 AM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: From: Govindraj.R govindraj.r...@ti.com On beagle some of uart mux lines are used for other purpose so init only uart3. OK, but you should also be clear that this patch is

Re: [PATCH] omap3_beagle: Init only uart3 used for console

2012-03-06 Thread Raja, Govindraj
On Tue, Mar 6, 2012 at 2:21 AM, Tony Lindgren t...@atomide.com wrote: * Kevin Hilman khil...@ti.com [120305 11:28]: Govindraj.R govindraj.r...@ti.com writes: From: Govindraj.R govindraj.r...@ti.com On beagle some of uart mux lines are used for other purpose so init only uart3. OK, but

Re: [RFC PATCH] OMAP: UART: Enable tx wakeup bit in wer

2012-03-06 Thread Raja, Govindraj
On Tue, Mar 6, 2012 at 1:53 AM, Paul Walmsley p...@pwsan.com wrote: Hello Govindraj Do you intend to update and repost this serial patch?  Or should someone else deal with it?  It would be good to get support for this additional wakeup bit. Thanks for reminding. (I had got preempted

Re: [PATCH] ARM: OMAP: USB: fix the pointer type mismatch compilation warning

2012-03-05 Thread Govindraj
On Mon, Mar 5, 2012 at 4:49 PM, Keshava Munegowda keshava_mgo...@ti.com wrote: From: Keshava Munegowda keshava_mgo...@ti.com The compilation of usb-host.c file was resulting compilation warning due to pointer type mismatch in assignment of return pointer type of the function

Re: help: BeagleBoard xM RevC ethernet port

2012-02-28 Thread Govindraj
Hi Peter, On Mon, Feb 27, 2012 at 8:02 PM, Peter Ujfalusi peter.ujfal...@ti.com wrote: Hi, On 02/23/2012 12:23 PM, Richard Watts wrote: On 22/02/12 22:00, Kevin Hilman wrote: The first thing I try when I see these regulator failures is to add CONFIG_REGULATOR_DUMMY=y to the .config to see

Re: [PATCH 1/2] mfd: omap-usb-host: Remove magic numbers for dev dma mask

2012-02-15 Thread Govindraj
On Wed, Feb 15, 2012 at 4:47 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Feb 15, 2012 at 03:53:33PM +0530, Govindraj.R wrote: From: Govindraj.R govindraj.r...@ti.com Remove the hardcoded magic values for dma mask and use the dma mask macros available. CC: Felipe Balbi ba...@ti.com CC:

Re: [PATCH v2] usb: host: ehci: allow ehci_* symbols to be unused

2012-02-15 Thread Govindraj
On Wed, Feb 15, 2012 at 1:04 PM, Felipe Balbi ba...@ti.com wrote: not all platforms will use all of those ehci_* symbols on their hc_driver structure. Sometimes we might need to provide a modified version of a certain method or not provide it at all, as is the case with OMAPs which don't

Re: [PATCH RFC] OMAP: serial: Remove the hardcode serial_omap_console_ports array.

2012-02-09 Thread Govindraj
On Thu, Feb 9, 2012 at 7:18 PM, Shubhrajyoti D shubhrajy...@ti.com wrote: Currently the array serial_omap_console_ports is hard coded to 4. Make it depend on the macro OMAP_MAX_HSUART_PORTS(which is 4) which the maximum uart count. Cc: Govindraj Raja govindraj.r...@ti.com Signed-off

Re: patch tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA added to tty tree

2012-02-02 Thread Govindraj
On Fri, Feb 3, 2012 at 9:37 AM, NeilBrown ne...@suse.de wrote: On Thu, 2 Feb 2012 13:03:01 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: Hi Greg, On Thu, 26 Jan 2012, Paul Walmsley wrote: On Thu, 26 Jan 2012, Greg KH wrote: Ok, I've just reverted both of these patches for now,

Re: [PATCH v2 3/3] tty: serial: omap-serial: wakeup latency constraint is in microseconds, not milliseconds

2012-01-26 Thread Govindraj
On Thu, Jan 26, 2012 at 8:20 AM, Paul Walmsley p...@pwsan.com wrote: The receive FIFO wakeup latency estimate in the omap-serial driver is three orders of magnitude too small.  This effectively prevents the MPU from going to a low-power state when CONFIG_CPU_IDLE=y.  This is a major power

Re: [PATCH 2/3] tty: serial: OMAP: block idle while the UART is transferring data in PIO mode

2012-01-26 Thread Govindraj
On Thu, Jan 26, 2012 at 8:20 AM, Paul Walmsley p...@pwsan.com wrote: Prevent OMAP UARTs from going idle while they are still transferring data in PIO mode.  This works around an oversight in the OMAP UART hardware present in OMAP34xx and earlier: an idle UART won't send a wakeup when the TX

Re: [PATCH 2/2] tty: serial: OMAP: transmit FIFO threshold interrupts don't wake the chip

2012-01-23 Thread Govindraj
...@ti.com Cc: Govindraj Raja govindra...@ti.com Cc: Kevin Hilman khil...@ti.com ---  arch/arm/plat-omap/include/plat/omap-serial.h |    1  drivers/tty/serial/omap-serial.c              |   51 +  2 files changed, 51 insertions(+), 1 deletions(-) diff --git a/arch/arm

Re: [PATCH 2/2] tty: serial: OMAP: transmit FIFO threshold interrupts don't wake the chip

2012-01-23 Thread Govindraj
On Mon, Jan 23, 2012 at 2:20 PM, Govindraj govindraj...@gmail.com wrote: On Sat, Jan 21, 2012 at 12:57 PM, Paul Walmsley p...@pwsan.com wrote: It seems that when the transmit FIFO threshold is reached on OMAP UARTs, it does not result in a PRCM wakeup.  This appears to be a silicon bug

Re: omap-serial RX DMA polling?

2012-01-23 Thread Govindraj
On Mon, Jan 23, 2012 at 6:03 AM, Paul Walmsley p...@pwsan.com wrote: Hello Govindraj while trying to track down some of the serial-related PM issues in v3.3-rc1, I noticed that the omap-serial.c driver sets a 1 microsecond polling timer when DMA is enabled (uart_dma.rx_timer) (!)  This seems

Re: [PATCH 1/2] tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA mode

2012-01-23 Thread Govindraj
will address these. DMA operation is unaffected by this patch. Signed-off-by: Paul Walmsley p...@pwsan.com Cc: Tomi Valkeinen tomi.valkei...@ti.com Cc: Govindraj Raja govindra...@ti.com Cc: Kevin Hilman khil...@ti.com ---  drivers/tty/serial/omap-serial.c |   35

Re: [PATCH 1/2] tty: serial: OMAP: ensure FIFO levels are set correctly in non-DMA mode

2012-01-23 Thread Govindraj
On Mon, Jan 23, 2012 at 3:51 PM, Govindraj govindraj...@gmail.com wrote: On Sat, Jan 21, 2012 at 12:57 PM, Paul Walmsley p...@pwsan.com wrote: Ensure FIFO levels are set correctly in non-DMA mode (the default). This patch will cause a receive FIFO threshold interrupt to be raised when

Re: omap-serial RX DMA polling?

2012-01-23 Thread Govindraj
On Mon, Jan 23, 2012 at 4:17 PM, Paul Walmsley p...@pwsan.com wrote: On Mon, 23 Jan 2012, Govindraj wrote: On Mon, Jan 23, 2012 at 6:03 AM, Paul Walmsley p...@pwsan.com wrote: while trying to track down some of the serial-related PM issues in v3.3-rc1, I noticed that the omap-serial.c

Re: omap-serial RX DMA polling?

2012-01-23 Thread Govindraj
On Tue, Jan 24, 2012 at 1:18 AM, Paul Walmsley p...@pwsan.com wrote: On Mon, 23 Jan 2012, Govindraj wrote: On Mon, Jan 23, 2012 at 4:17 PM, Paul Walmsley p...@pwsan.com wrote: On Mon, 23 Jan 2012, Govindraj wrote: On Mon, Jan 23, 2012 at 6:03 AM, Paul Walmsley p...@pwsan.com wrote

Re: [PATCH 0/5] uart updates

2012-01-20 Thread Govindraj
On Mon, Jan 16, 2012 at 3:52 PM, Shubhrajyoti D shubhrajy...@ti.com wrote: The patch series does the following - Make the Make the suspend/resume functions depend on    CONFIG_PM_SLEEP - Fix the serial omap probe's error handling - Make he context_loss_cnt signed so that error handling is  

Re: [PATCH 3/5] omap-serial: Fix the error handling in the omap_serial probe

2012-01-20 Thread Govindraj
On Mon, Jan 16, 2012 at 3:52 PM, Shubhrajyoti D shubhrajy...@ti.com wrote: The patch does the following - The pm_runtime_disable is called in the remove not in the error  case of probe.The patch calls the pm_runtime_disable in the error  case. - The  up is not freed in the error path. Fix

Re: [PATCH 5/5] OMAP : serial : Check for error in get_context_loss_count

2012-01-20 Thread Govindraj
On Mon, Jan 16, 2012 at 3:52 PM, Shubhrajyoti D shubhrajy...@ti.com wrote: In serial_omap_runtime_resume in case of errors returned by get_context_loss_count print a warning and do a restore. Signed-off-by: Shubhrajyoti D shubhrajy...@ti.com ---  drivers/tty/serial/omap-serial.c |   10

Re: [PATCH 4/5] ARM : OMAP : serial : Make context_loss_cnt signed

2012-01-20 Thread Govindraj
On Mon, Jan 16, 2012 at 3:52 PM, Shubhrajyoti D shubhrajy...@ti.com wrote: get_context_loss_count returns an int however it is stored in unsigned integer context_loss_cnt . This patch tries to make context_loss_cnt int. So that in case of errors(which may be negative) the value is not

Re: PM(?) problems on v3.3-rc1 on OMAP3

2012-01-20 Thread Govindraj
On Fri, Jan 20, 2012 at 4:03 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, I'm testing v3.3-rc1 on OMAP3 overo, and I'm having problems probably related to PM. First, when I boot up, the console (via USB serial) is very laggy, it often takes many seconds until the key pressed appears

Re: PM(?) problems on v3.3-rc1 on OMAP3

2012-01-20 Thread Govindraj
On Fri, Jan 20, 2012 at 4:37 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-01-20 at 16:19 +0530, Govindraj wrote: On Fri, Jan 20, 2012 at 4:03 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, I'm testing v3.3-rc1 on OMAP3 overo, and I'm having problems probably

Re: PM(?) problems on v3.3-rc1 on OMAP3

2012-01-20 Thread Govindraj
On Fri, Jan 20, 2012 at 4:03 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Hi, I'm testing v3.3-rc1 on OMAP3 overo, and I'm having problems probably related to PM. First, when I boot up, the console (via USB serial) is very laggy, it often takes many seconds until the key pressed appears

Re: PM(?) problems on v3.3-rc1 on OMAP3

2012-01-20 Thread Govindraj
On Fri, Jan 20, 2012 at 6:02 PM, Jean Pihet jean.pi...@newoldbits.com wrote: Govindraj, On Fri, Jan 20, 2012 at 12:21 PM, Govindraj govindraj...@gmail.com wrote: On Fri, Jan 20, 2012 at 4:37 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-01-20 at 16:19 +0530, Govindraj wrote

Re: PM(?) problems on v3.3-rc1 on OMAP3

2012-01-20 Thread Govindraj
On Fri, Jan 20, 2012 at 5:31 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: On Fri, 2012-01-20 at 17:26 +0530, Govindraj wrote: On Fri, Jan 20, 2012 at 4:03 PM, Tomi Valkeinen tomi.valkei...@ti.com wrote: Is there a way to lock the OPP to the full power OPP? btw, I think enabling

Re: DSS2/PM on 3.2 broken?

2012-01-13 Thread Govindraj
On Fri, Jan 13, 2012 at 3:35 PM, Paul Walmsley p...@pwsan.com wrote: cc Tero, Govindraj On Thu, 12 Jan 2012, NeilBrown wrote: On Wed, 11 Jan 2012 06:43:04 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: I spent some time exploring why cpuidle never drops below state 0 and found out

Re: [PATCH RFC] omap-serial: make serial_omap_restore_context depend on CONFIG_PM_RUNTIME

2012-01-11 Thread Govindraj
On Wed, Jan 11, 2012 at 11:26 AM, Shubhrajyoti D shubhrajy...@ti.com wrote: The function serial_omap_restore_context is called only from serial_omap_runtime_resume which depends on CONFIG_PM_RUNTIME. Make serial_omap_restore_context also compile conditionally. if CONFIG_PM_RUNTIME is not

Re: [PATCH v8 19/20] OMAP2+: UART: Do not gate uart clocks if used for debug_prints

2012-01-03 Thread Govindraj
On Tue, Jan 3, 2012 at 3:54 PM, Bedia, Vaibhav vaibhav.be...@ti.com wrote: Hi Govindraj, On Mon, Jan 02, 2012 at 16:00:37, Govindraj wrote: currently runtime pm is available from omap-serial device and not from tty_dev. Setting tty_dev wakeup is to use irq_wakeup from suspend available

Re: [PATCH v8 19/20] OMAP2+: UART: Do not gate uart clocks if used for debug_prints

2012-01-03 Thread Govindraj
On Tue, Jan 3, 2012 at 5:22 PM, Bedia, Vaibhav vaibhav.be...@ti.com wrote: On Tue, Jan 03, 2012 at 16:01:52, Govindraj wrote: I have basic suspend-resume working on it. Strangely this works irrespective of the value of tty_dev wakeup entry. Do you know if this is expected on OMAP

Re: [PATCH v8 19/20] OMAP2+: UART: Do not gate uart clocks if used for debug_prints

2012-01-02 Thread Govindraj
Hi Vaibhav, On Mon, Jan 2, 2012 at 2:55 PM, Bedia, Vaibhav vaibhav.be...@ti.com wrote: Hello, On Fri, Nov 11, 2011 at 15:31:52, R, Govindraj wrote: [...] -     if ((cpu_is_omap34xx() || cpu_is_omap44xx()) bdata-pads) +     if (((cpu_is_omap34xx() || cpu_is_omap44xx()) bdata-pads

Re: [PATCH v8 00/20] OMAP2+: UART: Runtime adaptation + cleanup

2011-12-14 Thread Govindraj
On Wed, Dec 14, 2011 at 12:56 AM, Kevin Hilman khil...@ti.com wrote: Govindraj govindraj...@gmail.com writes: [...] I have re-based this patch series against LO master commit id: deee6d5359969a0ce4e2760cfd7b9f379bd5698a Same is available here [1] I have tested this patch series along

Re: [PATCH v8 00/20] OMAP2+: UART: Runtime adaptation + cleanup

2011-12-14 Thread Govindraj
On Wed, Dec 14, 2011 at 5:02 AM, Kevin Hilman khil...@ti.com wrote: Govindraj govindraj...@gmail.com writes: [...] I have re-based this patch series against LO master commit id: deee6d5359969a0ce4e2760cfd7b9f379bd5698a Same is available here [1] I have tested this patch series along

Re: [PATCH v3 0/4] OMAP serial device tree support

2011-12-14 Thread Govindraj
Hi Rajendra, On Wed, Dec 14, 2011 at 5:25 PM, Rajendra Nayak rna...@ti.com wrote: v3 is rebased on top of the latest serial runtime patches[1] and boot tested with/without DT on OMAP4 SDP and OMAP4 Panda boards. Patches can be found here.. git://gitorious.org/omap-pm/linux.git for-dt/serial

Re: [PATCH v8 00/20] OMAP2+: UART: Runtime adaptation + cleanup

2011-12-14 Thread Govindraj
On Wed, Dec 14, 2011 at 8:59 PM, Kevin Hilman khil...@ti.com wrote: Govindraj govindraj...@gmail.com writes: On Wed, Dec 14, 2011 at 12:56 AM, Kevin Hilman khil...@ti.com wrote: Govindraj govindraj...@gmail.com writes: [...] I have re-based this patch series against LO master commit id

Re: [PATCH v8 00/20] OMAP2+: UART: Runtime adaptation + cleanup

2011-12-13 Thread Govindraj
Hi Tony/kevin, On Fri, Nov 11, 2011 at 3:27 PM, Govindraj.R govindraj.r...@ti.com wrote: Converting uart driver to adapt to pm runtime API's. Code re-org + cleanup. Moving some functionality from serial.c to omap-serial.c Changes involves: 1.) Cleaning up certain uart

Re: [PATCH v2] ARM: OMAP2+: hwmod: Add a new state to handle hwmods left enabled at init

2011-11-21 Thread Govindraj
Hi Rajendra, On Mon, Nov 21, 2011 at 11:45 AM, Rajendra Nayak rna...@ti.com wrote: An hwmod with a 'HWMOD_INIT_NO_IDLE' flag set, is left in enabled state by the hwmod framework post the initial setup. Once a real user of the device (a driver) tries to enable it at a later point, the hwmod

Re: [PATCH v8 17/20] OMAP2+: UART: Use custom activate func for console uart.

2011-11-21 Thread Govindraj
On Sat, Nov 19, 2011 at 2:54 AM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: Omap-uart can be used as console uart to print early boot messages using earlyprintk so for console uart prevent hwmod reset or idling during bootup. Identify the console_uart set

Re: [PATCH v8 17/20] OMAP2+: UART: Use custom activate func for console uart.

2011-11-21 Thread Govindraj
On Mon, Nov 21, 2011 at 7:17 PM, Govindraj govindraj...@gmail.com wrote: On Sat, Nov 19, 2011 at 2:54 AM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: Omap-uart can be used as console uart to print early boot messages using earlyprintk so for console uart

Re: [PATCH] ARM: omap_hwmod: Add a new state to handle hwmods left enabled at init

2011-11-17 Thread Govindraj
On Thu, Nov 17, 2011 at 3:41 PM, Rajendra Nayak rna...@ti.com wrote: A hwmod with a 'HWMOD_INIT_NO_IDLE' flag set, is left in enabled state by the hwmod framework post the initial setup. Once a real user of the device (a driver) tries to enable it at a later point, the hmwod framework throws a

Re: [PATCH v8 11/20] OMAP2+: UART: Move errata handling from serial.c to omap-serial

2011-11-16 Thread Govindraj
On Tue, Nov 15, 2011 at 1:20 AM, Jon Hunter jon-hun...@ti.com wrote: Hi Govindraj, [...]        oh = uart-oh; -       uart-dma_enabled = 0;        name = DRIVER_NAME;        omap_up.dma_enabled = uart-dma_enabled;        omap_up.uartclk = OMAP24XX_BASE_BAUD * 16;        omap_up.flags

Re: [PATCH v7 11/21] OMAP2+: UART: Move errata handling from serial.c to omap-serial

2011-11-11 Thread Govindraj
Hi Jon, On Fri, Nov 11, 2011 at 5:14 AM, Jon Hunter jon-hun...@ti.com wrote: Hi Govindraj, On 10/18/2011 10:26, Govindraj.R wrote: Move the errata handling mechanism from serial.c to omap-serial file and utilise the same func in driver file. Errata i202, i291 are moved to be handled

Re: [PATCH v7 17/21] OMAP2+: UART: Remove omap_uart_can_sleep and add pm_qos

2011-11-11 Thread Govindraj
On Fri, Nov 11, 2011 at 12:32 AM, Kevin Hilman khil...@ti.com wrote: Govindraj govindraj...@gmail.com writes: [..] I have fixed this and other uart_v7 comments and have re-based the patch series on top of 3.2-rc1 along with Tero's v9 irq chaining patches and tested the same. Available

Re: [PATCH v7 17/21] OMAP2+: UART: Remove omap_uart_can_sleep and add pm_qos

2011-11-10 Thread Govindraj
Hi Kevin, On Wed, Nov 9, 2011 at 12:50 AM, Kevin Hilman khil...@ti.com wrote: Rajendra Nayak rna...@ti.com writes: Hi Kevin, On Saturday 05 November 2011 04:12 AM, Kevin Hilman wrote: However, as mentioned previously[1], due to a HW sleepdep between MPU and CORE, this constraint isn't

Re: [PATCH] OMAP2+: Fix Compilation error on current mainline

2011-11-09 Thread Govindraj
On Tue, Nov 8, 2011 at 8:55 PM, Cousson, Benoit b-cous...@ti.com wrote: On 11/8/2011 12:59 PM, Govindraj wrote: On Tue, Nov 8, 2011 at 4:24 PM, Santosh Shilimkar santosh.shilim...@ti.com  wrote: [...] Opps. I missed that one while acking the patch. Indeed the semi-colon one was agreed

Re: [PATCH] OMAP2+: Fix Compilation error on current mainline

2011-11-08 Thread Govindraj
On Tue, Nov 8, 2011 at 4:24 PM, Santosh Shilimkar santosh.shilim...@ti.com wrote: On Tuesday 08 November 2011 04:16 PM, Cousson, Benoit wrote: Hi Govind, On 11/8/2011 7:28 AM, Govindraj.R wrote: Patch to fix below compilation error on latest mainline commit

Re: [PATCH v7 16/21] OMAP2+: UART: Remove custom activate funcs and use generic funcs.

2011-11-07 Thread Govindraj
On Sat, Nov 5, 2011 at 3:30 AM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: The custom hwmod activate and deactivate funcs does hwmod_enable and idle same can be done with omap_device generic API's. Signed-off-by: Govindraj.R govindraj.r...@ti.com This one

Re: [PATCH v7 19/21] OMAP2+: UART: Use custom activate func for console uart.

2011-11-07 Thread Govindraj
On Sat, Nov 5, 2011 at 4:30 AM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: Omap-uart can be used as console uart to print early boot messages using earlyprintk so for console uart prevent hwmod reset or idling during bootup. Identify the console_uart set

Re: [PATCH v6 06/16] OMAP2+: UART: Remove certain feilds from omap_uart_state struct

2011-10-12 Thread Govindraj
On Tue, Oct 11, 2011 at 5:01 AM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: Removing some of the uart info that is maintained in omap_uart_state struct used for UART PM in serial.c. Remove omap_uart_state struct dependency from omap_serial_init,

Re: [PATCH v6 09/16] OMAP2+: UART: Add runtime pm support for omap-serial driver

2011-10-12 Thread Govindraj
On Tue, Oct 11, 2011 at 5:12 AM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: Adapts omap-serial driver to use pm_runtime API's. [...] @@ -1065,19 +1123,18 @@ static struct uart_driver serial_omap_reg = {       .cons           = OMAP_CONSOLE,  }; -static

Re: [PATCH v6 09/16] OMAP2+: UART: Add runtime pm support for omap-serial driver

2011-10-12 Thread Govindraj
On Tue, Oct 11, 2011 at 5:26 AM, Kevin Hilman khil...@ti.com wrote: Govindraj.R govindraj.r...@ti.com writes: Adapts omap-serial driver to use pm_runtime API's. Use runtime runtime API's to handle uart clocks and obtain device_usage statics. Set runtime API's usage to irq_safe so that we

  1   2   3   >