Re: [PATCH 01/32] arm/omap: use system_wq in mailbox

2011-01-25 Thread Hari Kanigeri
Tejun, On Tue, Jan 25, 2011 at 5:47 AM, Tejun Heo t...@kernel.org wrote: On Tue, Jan 04, 2011 at 06:24:21AM +0100, Tejun Heo wrote: Using dedicated workqueue or system_wq doesn't make any difference in terms of execution latency anymore.  Sleeping work items no longer delay execution of other

Re: [PATCH] OMAP: device: make rt_va easily avaialable to drivers

2010-12-09 Thread Hari Kanigeri
by drivers, as per the comment there. [1] http://marc.info/?l=linux-omapm=127808467703366w=2 Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- Acked-by: Hari Kanigeri h-kanige...@ti.com  arch/arm/plat-omap/include/plat/omap_device.h |    3 +--  arch/arm/plat-omap/omap_device.c

Re: [PATCH 2/7] usb: otg: Adding twl6030-usb transceiver driver for

2010-12-07 Thread Hari Kanigeri
Hema, On Tue, Dec 7, 2010 at 6:11 PM, Hema HK hem...@ti.com wrote: Adding the twl6030-usb transceiver support for OMAP4 musb driver. OMAP4 supports 2 types of transceiver interface. +} + +int omap4430_phy_set_clk(struct device *dev, int on) +{ +       static int state; probably good to

Re: [RFC v2 1/8] TILER-DMM: DMM-PAT driver for TI TILER

2010-12-02 Thread Hari Kanigeri
On Wed, Dec 1, 2010 at 11:16 PM, Varadarajan, Charulatha ch...@ti.com wrote: On Thu, Dec 2, 2010 at 07:57, Kanigeri, Hari h-kanige...@ti.com wrote: On Wed, Dec 1, 2010 at 8:10 PM, Kanigeri, Hari h-kanige...@ti.com wrote: On Wed, Dec 1, 2010 at 12:04 AM, Varadarajan, Charulatha ch...@ti.com

[PATCH v5 0/4] OMAP: mailbox: fixes and enhancements

2010-11-29 Thread Hari Kanigeri
instead of global Hari Kanigeri (3): OMAP: mailbox: fix checkpatch warnings OMAP: mailbox: send message in process context OMAP: mailbox: add notification support for multiple readers arch/arm/plat-omap/include/plat/mailbox.h |8 +- arch/arm/plat-omap/mailbox.c | 130

[PATCH v5 1/4] OMAP: mailbox: change full flag per mailbox queue instead of global

2010-11-29 Thread Hari Kanigeri
Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/include/plat/mailbox.h |1 + arch/arm/plat-omap/mailbox.c |9 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm/plat-omap/include/plat/mailbox.h b/arch/arm/plat-omap/include

[PATCH v5 2/4] OMAP: mailbox: fix checkpatch warnings

2010-11-29 Thread Hari Kanigeri
+ fail_alloc_txq:$ WARNING: please, no space for starting a line, excluding comments + fail_request_irq:$ WARNING: line over 80 characters + mbox_kfifo_size = max_t(unsigned int, mbox_kfifo_size, sizeof(mbox_msg_t)); Signed-off-by: Hari Kanigeri h-kanige...@ti.com

[PATCH v5 3/4] OMAP: mailbox: send message in process context

2010-11-29 Thread Hari Kanigeri
Schedule the Tasklet to send only when mailbox fifo is full and there are pending messages in kfifo, else send the message directly in the Process context. This would avoid needless scheduling of Tasklet for every message transfer Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat

[PATCH v5 4/4] OMAP: mailbox: add notification support for multiple readers

2010-11-29 Thread Hari Kanigeri
-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- arch/arm/plat-omap/include/plat/mailbox.h |7 +- arch/arm/plat-omap/mailbox.c | 103 - 2 files changed, 61 insertions(+), 49 deletions(-) diff --git a/arch

[PATCH v4 0/5] OMAP: mailbox: fixes and enhancements

2010-11-23 Thread Hari Kanigeri
: mailbox: change full flag per mailbox queue instead of global Hari Kanigeri (4): OMAP: mailbox: fix rx interrupt disable in omap4 OMAP: mailbox: fix checkpatch warnings OMAP: mailbox: send message in process context OMAP: mailbox: add notification support for multiple readers arch/arm

[PATCH v4 1/5] OMAP: mailbox: change full flag per mailbox queue instead of global

2010-11-23 Thread Hari Kanigeri
Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/include/plat/mailbox.h |1 + arch/arm/plat-omap/mailbox.c |9 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm/plat-omap/include/plat/mailbox.h b/arch/arm/plat-omap/include

[PATCH v4 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-23 Thread Hari Kanigeri
disablign rx interrupt on omap4 is different than its pre-decessors. The bit in OMAP4_MAILBOX_IRQENABLE_CLR should be set to disable the interrupts instead of clearing the bit. Defined rev field in mailbox structure to differentiate the mailbox versions. Signed-off-by: Hari Kanigeri h-kanige

[PATCH v4 3/5] OMAP: mailbox: fix checkpatch warnings

2010-11-23 Thread Hari Kanigeri
+ fail_alloc_txq:$ WARNING: please, no space for starting a line, excluding comments + fail_request_irq:$ WARNING: line over 80 characters + mbox_kfifo_size = max_t(unsigned int, mbox_kfifo_size, sizeof(mbox_msg_t)); Signed-off-by: Hari Kanigeri h-kanige...@ti.com

[PATCH v4 4/5] OMAP: mailbox: send message in process context

2010-11-23 Thread Hari Kanigeri
Schedule the Tasklet to send only when mailbox fifo is full and there are pending messages in kifo, else send the message directly in the Process context. This would avoid needless scheduling of Tasklet for every message transfer Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat

[PATCH v4 5/5] OMAP: mailbox: add notification support for multiple readers

2010-11-23 Thread Hari Kanigeri
-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- arch/arm/plat-omap/include/plat/mailbox.h |7 +- arch/arm/plat-omap/mailbox.c | 104 - 2 files changed, 62 insertions(+), 49 deletions(-) diff --git a/arch

[PATCH v3 3/5] OMAP: mailbox: fix checkpatch warnings

2010-11-18 Thread Hari Kanigeri
Fix the checkpatch warnings observed in mailbox module Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/mailbox.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index 9ce3570

[PATCH v3 1/5] OMAP: mailbox: change full flag per mailbox queue instead of global

2010-11-18 Thread Hari Kanigeri
protection. When the full flag is true the interrupt for that mailbox is disabled. So there is no race condition if full flag is modified before calling omap_mbox_enable_irq. Reported-by: Ohad Ben-Cohen o...@wizery.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com Signed-off-by: Hari Kanigeri h

[PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4

2010-11-18 Thread Hari Kanigeri
disabling rx interrupt on omap4 is different than its pre-decessors. The bit in OMAP4_MAILBOX_IRQENABLE_CLR should be set to disable the interrupts instead of clearing the bit. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/mailbox.c |5 - 1 files changed, 4

[PATCH v3 0/5] OMAP: mailbox: enhancements and fixes

2010-11-18 Thread Hari Kanigeri
/lists/linux-omap/msg39988.html http://www.spinics.net/lists/linux-omap/msg39931.html http://www.mail-archive.com/linux-omap@vger.kernel.org/msg37278.html Fernando Guzman Lugo (1): OMAP: mailbox: change full flag per mailbox queue instead of global Hari Kanigeri (4): OMAP: mailbox: fix rx

[PATCH v3 4/5] OMAP: mailbox: send message in process context

2010-11-18 Thread Hari Kanigeri
Schedule the Tasklet to send only when mailbox fifo is full and there are pending messages in kifo, else send the message directly in the Process context. This would avoid needless scheduling of Tasklet for every message transfer Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat

[PATCH v3 5/5] OMAP: mailbox: add notification support for multiple readers

2010-11-18 Thread Hari Kanigeri
-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- arch/arm/plat-omap/include/plat/mailbox.h |7 +- arch/arm/plat-omap/mailbox.c | 102 - 2 files changed, 60 insertions(+), 49 deletions(-) diff --git a/arch

[PATCH] OMAP4: clocks: add dummy clock for mailbox

2010-11-18 Thread Hari Kanigeri
In omap4, there is no explicit configuration register to enable mailbox clocks. Defining dummy clock for mailbox clock module to keep the mailbox driver backward compatible with previous omaps. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/clock44xx_data.c |1 + 1

[PATCH 6/6] omap:clocks44x-add dummy clock for mailbox

2010-11-10 Thread Hari Kanigeri
In omap4, there is no explicit configuration register to enable mailbox clocks. Defining dummy clock for mailbox clock module to keep the mailbox driver backward compatible with previous omaps. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/clock44xx_data.c |1 + 1

[PATCH 2/6] omap:mailbox: fix rx interrupt disable in omap4

2010-11-10 Thread Hari Kanigeri
disabling rx interrupt on omap4 is different than its pre-decessors. The bit in OMAP4_MAILBOX_IRQENABLE_CLR should be set to disable the interrupts instead of clearing the bit. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/mailbox.c |5 - 1 files changed, 4

[PATCH 3/6] omap:mailbox-fix checkpatch warnings

2010-11-10 Thread Hari Kanigeri
Fix the checkpatch warnings observed in mailbox module Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/mailbox.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index 9ce3570

[PATCH 5/6] omap:mailbox-add notification support for multiple readers

2010-11-10 Thread Hari Kanigeri
-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- arch/arm/plat-omap/include/plat/mailbox.h |7 +- arch/arm/plat-omap/mailbox.c | 102 - 2 files changed, 60 insertions(+), 49 deletions(-) diff --git a/arch

[PATCH 1/6] mailbox: change full flag per mailbox queue instead of global

2010-11-10 Thread Hari Kanigeri
protection. When the full flag is true the interrupt for that mailbox is disabled. So there is no race condition if full flag is modified before calling omap_mbox_enable_irq. Reported-by: Ohad Ben-Cohen o...@wizery.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com Signed-off-by: Hari Kanigeri h

[PATCH 4/6] omap:mailbox-send message in process context

2010-11-10 Thread Hari Kanigeri
Schedule the Tasklet to send only when mailbox fifo is full and there are pending messages in kifo, else send the message directly in the Process context. This would avoid needless scheduling of Tasklet for every message transfer Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat

[PATCH 0/6] [v2] omap:mailbox-enhancements and fixes

2010-11-10 Thread Hari Kanigeri
omap:mailbox-resolve multiple receiver problem The patch set is tested on omap4 SDP board. Fernando Guzman Lugo (1): mailbox: change full flag per mailbox queue instead of global Hari Kanigeri (5): omap:mailbox: fix rx interrupt disable in omap4 omap:mailbox-fix checkpatch warnings

[PATCH v2 3/6] OMAP: mailbox: fix checkpatch warnings

2010-11-10 Thread Hari Kanigeri
Fix the checkpatch warnings observed in mailbox module Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/mailbox.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index 9ce3570

[PATCH v2 6/6] OMAP4: clocks: add dummy clock for mailbox

2010-11-10 Thread Hari Kanigeri
In omap4, there is no explicit configuration register to enable mailbox clocks. Defining dummy clock for mailbox clock module to keep the mailbox driver backward compatible with previous omaps. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/clock44xx_data.c |1 + 1

[PATCH v2 5/6] OMAP: mailbox: add notification support for multiple readers

2010-11-10 Thread Hari Kanigeri
-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- arch/arm/plat-omap/include/plat/mailbox.h |7 +- arch/arm/plat-omap/mailbox.c | 102 - 2 files changed, 60 insertions(+), 49 deletions(-) diff --git a/arch

[PATCH v2 4/6] OMAP: mailbox: send message in process context

2010-11-10 Thread Hari Kanigeri
Schedule the Tasklet to send only when mailbox fifo is full and there are pending messages in kifo, else send the message directly in the Process context. This would avoid needless scheduling of Tasklet for every message transfer Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat

[PATCH v2 1/6] OMAP: mailbox: change full flag per mailbox queue instead of global

2010-11-10 Thread Hari Kanigeri
protection. When the full flag is true the interrupt for that mailbox is disabled. So there is no race condition if full flag is modified before calling omap_mbox_enable_irq. Reported-by: Ohad Ben-Cohen o...@wizery.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com Signed-off-by: Hari Kanigeri h

Re: [PATCH 0/6] [v2] OMAP: mailbox: enhancements and fixes

2010-11-10 Thread Hari Kanigeri
Benoit, Resending correcting the subject format based on Benoit's comment and fixing the over-indentation pointed out by Sergei. Pure nitpicking: That's a pretty fast update... but then it should be a v3 :-) Have to do it fast to keep your attention :). Since you are saying it is pure

Re: [PATCH 6/6] omap:clocks44x-add dummy clock for mailbox

2010-11-10 Thread Hari Kanigeri
Paul, On Wed, Nov 10, 2010 at 5:27 PM, Paul Walmsley p...@pwsan.com wrote: Hello Hari On Wed, 10 Nov 2010, Hari Kanigeri wrote: In omap4, there is no explicit configuration register to enable mailbox clocks. Defining dummy clock for mailbox clock module to keep the mailbox driver

Re: [PATCH 6/7] omap:mailbox-add notification support for multiple readers

2010-10-29 Thread Hari Kanigeri
Omar,  static void omap_mbox_fini(struct omap_mbox *mbox)  { +       if (!--mbox-use_count) { +               tasklet_kill(mbox-txq-tasklet); +               flush_work(mbox-rxq-work); +               mbox_queue_free(mbox-txq); +               mbox_queue_free(mbox-rxq); +       } + +  

Re: [PATCH 5/7] omap:mailbox-resolve multiple receiver problem

2010-10-29 Thread Hari Kanigeri
Omar, OMAP4 shares one interrupt line for all the mailbox instances. The ISR is handling only the mailbox instance that was registered last. This shouldn't be needed, request_irq is being called with IRQF_SHARED flag and different device ids, so if a message arrives it fires an interrupt

Re: [PATCH 4/7] omap:mailbox-send message in process context

2010-10-21 Thread Hari Kanigeri
Rene, Thanks for your comment. @@ -92,20 +92,25 @@ int omap_mbox_msg_send(struct omap_mbox *mbox,       mbox_msg_t msg) struct omap_mbox_queue *mq = mbox-txq;       int ret = 0, len; -     spin_lock(mq-lock); +     spin_lock_bh(mq-lock); Please check if this scenario looks valid to

[PATCH 3/7] omap:mailbox-fix checkpatch warnings

2010-10-14 Thread Hari Kanigeri
Fix the checkpatch warnings observed in mailbox module Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/mailbox.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index 9ce3570

[PATCH 0/7] omap:mailbox-enhancements and fixes

2010-10-14 Thread Hari Kanigeri
of global Hari Kanigeri (6): omap:mailbox: fix rx interrupt disable in omap4 omap:mailbox-fix checkpatch warnings omap:mailbox-send message in process context omap:mailbox-resolve multiple receiver problem omap:mailbox-add notification support for multiple readers omap:clocks44x-add dummy

[PATCH 1/7] mailbox: change full flag per mailbox queue instead of global

2010-10-14 Thread Hari Kanigeri
protection. When the full flag is true the interrupt for that mailbox is disabled. So there is no race condition if full flag is modified before calling omap_mbox_enable_irq. Reported-by: Ohad Ben-Cohen o...@wizery.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com Signed-off-by: Hari Kanigeri h

[PATCH 4/7] omap:mailbox-send message in process context

2010-10-14 Thread Hari Kanigeri
Schedule the Tasklet to send only when mailbox fifo is full, else send the message in the Process context. This would avoid needless scheduling of Tasklet for every message transfer Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/mailbox.c |9 +++-- 1 files changed

[PATCH 2/7] omap:mailbox: fix rx interrupt disable in omap4

2010-10-14 Thread Hari Kanigeri
disabling rx interrupt on omap4 is different than its pre-decessors. The bit in OMAP4_MAILBOX_IRQENABLE_CLR should be set to disable the interrupts instead of clearing the bit. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/mailbox.c |5 - 1 files changed, 4

[PATCH 5/7] omap:mailbox-resolve multiple receiver problem

2010-10-14 Thread Hari Kanigeri
in Transmit Interrupt case too. Only the last registered mailbox is handled. The fix is to iterate through the list of mailboxes that were registered checking for the mailbox TX and RX interrupt source. Signed-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Ramesh Gupta grgu...@ti.com Signed-off

[PATCH 6/7] omap:mailbox-add notification support for multiple readers

2010-10-14 Thread Hari Kanigeri
-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- arch/arm/plat-omap/include/plat/mailbox.h |9 ++- arch/arm/plat-omap/mailbox.c | 102 - 2 files changed, 62 insertions(+), 49 deletions(-) diff --git

[PATCH 2/7] omap:mailbox: fix rx interrupt disable in omap4

2010-10-14 Thread Hari Kanigeri
disabling rx interrupt on omap4 is different than its pre-decessors. The bit in OMAP4_MAILBOX_IRQENABLE_CLR should be set to disable the interrupts instead of clearing the bit. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/mailbox.c |5 - 1 files changed, 4

[PATCH 7/7] omap:clocks44x-add dummy clock for mailbox

2010-10-14 Thread Hari Kanigeri
In omap4, there is no explicit configuration register to enable mailbox clocks. Defining dummy clock for mailbox clock module to keep the mailbox driver backward compatible with previous omaps. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/clock44xx_data.c |1 + 1

[PATCH 3/7] omap:mailbox-fix checkpatch warnings

2010-10-14 Thread Hari Kanigeri
Fix the checkpatch warnings observed in mailbox module Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/mailbox.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index 9ce3570

[PATCH 0/7] omap:mailbox-enhancements and fixes

2010-10-14 Thread Hari Kanigeri
://patchwork.kernel.org/patch/105650/ Fernando Guzman Lugo (1): mailbox: change full flag per mailbox queue instead of global Hari Kanigeri (6): omap:mailbox: fix rx interrupt disable in omap4 omap:mailbox-fix checkpatch warnings omap:mailbox-send message in process context omap:mailbox-resolve

[PATCH 4/7] omap:mailbox-send message in process context

2010-10-14 Thread Hari Kanigeri
Schedule the Tasklet to send only when mailbox fifo is full, else send the message in the Process context. This would avoid needless scheduling of Tasklet for every message transfer Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/mailbox.c |9 +++-- 1 files changed

[PATCH 1/7] mailbox: change full flag per mailbox queue instead of global

2010-10-14 Thread Hari Kanigeri
protection. When the full flag is true the interrupt for that mailbox is disabled. So there is no race condition if full flag is modified before calling omap_mbox_enable_irq. Reported-by: Ohad Ben-Cohen o...@wizery.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com Signed-off-by: Hari Kanigeri h

[PATCH 6/7] omap:mailbox-add notification support for multiple readers

2010-10-14 Thread Hari Kanigeri
-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- arch/arm/plat-omap/include/plat/mailbox.h |9 ++- arch/arm/plat-omap/mailbox.c | 102 - 2 files changed, 62 insertions(+), 49 deletions(-) diff --git

[PATCH 5/7] omap:mailbox-resolve multiple receiver problem

2010-10-14 Thread Hari Kanigeri
in Transmit Interrupt case too. Only the last registered mailbox is handled. The fix is to iterate through the list of mailboxes that were registered checking for the mailbox TX and RX interrupt source. Signed-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Ramesh Gupta grgu...@ti.com Signed-off

[PATCH 4/7] omap:mailbox-send message in process context

2010-10-13 Thread Hari Kanigeri
Schedule the Tasklet to send only when mailbox fifo is full, else send the message in the Process context. This would avoid needless scheduling of Tasklet for every message transfer Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/mailbox.c |9 +++-- 1 files changed

[PATCH 6/7] omap:mailbox-add notification support for multiple readers

2010-10-13 Thread Hari Kanigeri
-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- arch/arm/plat-omap/include/plat/mailbox.h |9 ++- arch/arm/plat-omap/mailbox.c | 102 - 2 files changed, 62 insertions(+), 49 deletions(-) diff --git

[PATCH 1/7] mailbox: change full flag per mailbox queue instead of global

2010-10-13 Thread Hari Kanigeri
protection. When the full flag is true the interrupt for that mailbox is disabled. So there is no race condition if full flag is modified before calling omap_mbox_enable_irq. Reported-by: Ohad Ben-Cohen o...@wizery.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com Signed-off-by: Hari Kanigeri h

[PATCH 5/7] omap:mailbox-resolve multiple receiver problem

2010-10-13 Thread Hari Kanigeri
in Transmit Interrupt case too. Only the last registered mailbox is handled. The fix is to iterate through the list of mailboxes that were registered checking for the mailbox TX and RX interrupt source. Signed-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Ramesh Gupta grgu...@ti.com Signed-off

[PATCH 2/7] omap:mailbox: fix rx interrupt disable in omap4

2010-10-13 Thread Hari Kanigeri
disabling rx interrupt on omap4 is different than its pre-decessors. The bit in OMAP4_MAILBOX_IRQENABLE_CLR should be set to disable the interrupts instead of clearing the bit. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/mailbox.c |5 - 1 files changed, 4

[PATCH 7/7] omap:clocks44x-add dummy clock for mailbox

2010-10-13 Thread Hari Kanigeri
In omap4, there is no explicit configuration register to enable mailbox clocks. Defining dummy clock for mailbox clock module to keep the mailbox driver backward compatible with previous omaps. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/clock44xx_data.c |1 + 1

[PATCH 3/7] omap:mailbox-fix checkpatch warnings

2010-10-13 Thread Hari Kanigeri
Fix the checkpatch warnings observed in mailbox module Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/mailbox.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c index 9ce3570

[PATCH 0/7] omap:mailbox-enhancments and fixes

2010-10-13 Thread Hari Kanigeri
from Fernando was sent to LO, but looks like it didn't get merged, resending the patch after revising and rebasing. Fernando Guzman Lugo (1): mailbox: change full flag per mailbox queue instead of global Hari Kanigeri (6): omap:mailbox: fix rx interrupt disable in omap4

[PATCH] omap:iommu-load cam register before flushing the entry

2010-08-20 Thread Hari Kanigeri
flushing the TLB entry. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/iommu.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c index 2e603fe..c534280 100644 --- a/arch/arm/plat-omap/iommu.c +++ b

Re: dspbridge and the omapl1x

2010-08-12 Thread Hari Kanigeri
Mugdha, On Thu, Aug 12, 2010 at 1:16 AM, Kamoolkar, Mugdha mug...@ti.com wrote: Ben, I'm still not sure about the iommu features required by dspbridge, I will need to look into this. But 2+3 sound like they could be provided by DSPLink itself. Would it be sane to put dspbridge on top

Re: dspbridge and the omapl1x

2010-08-12 Thread Hari Kanigeri
On Thu, Aug 12, 2010 at 2:16 AM, Kamoolkar, Mugdha mug...@ti.com wrote: You are correct that dynamic linking and loading is a feature that is available in DSPBridge, and which is missing in DSPLink, which could work on OMAPL1xx if you ported DSPBridge to OMAPL1xx I imagined that the lack

Re: dspbridge and the omapl1x

2010-08-11 Thread Hari Kanigeri
Ben, Yes, dynamic memory management. With DSP Link on the OMAPL138 the memory allocated to the DSP must be specified as a 'hole' in Linux memory at boot-time [1[2][3]. It seems (perhaps this is wishful thinking) that dspbridge does not have this limitation. DSPBridge doesn't has this

Re: dspbridge and the omapl1x

2010-08-11 Thread Hari Kanigeri
Ben, On Wed, Aug 11, 2010 at 2:25 PM, Ben Gardiner bengardi...@nanometrics.ca wrote: Hello Hari, On Wed, Aug 11, 2010 at 12:55 PM, Hari Kanigeri hari.kanig...@gmail.com wrote: Ben, Yes, dynamic memory management. With DSP Link on the OMAPL138 the memory allocated to the DSP must

Re: dspbridge and the omapl1x

2010-08-10 Thread Hari Kanigeri
Ben, We are attracted to DSPBridge over DSPLink because it appears to have better dynamic resource management and it is headed for mainline (fingers crossed). Do you mean dynamic memory management ? Can you please elaborate on what feature you are referring to ? Thank you, Best regards,

Re: [PATCH 6/7] save and restore etm state across core OFF modes

2010-07-25 Thread Hari Kanigeri
+config ENABLE_OFF_MODE_JTAG_ETM_DEBUG +       bool Enable hardware emulation context save and restore +       depends on ARCH_OMAP3 -- Shouldn't this be depends on OMAP3_EMU instead ? +       default y -- As this is debug option, can you keep this n by default ? +       help +        

Re: [RFC 7/8] TILER-DMM: Main TILER driver implementation.

2010-07-24 Thread Hari Kanigeri
+s32 tiler_mmap_blk(struct tiler_block_t *blk, u32 offs, u32 size, +                             struct vm_area_struct *vma, u32 voffs) +{ +     u32 v, p, len; + +     /* don't allow mremap */ +     vma-vm_flags |= VM_DONTEXPAND | VM_RESERVED; Should we add VM_LOCKED as well considering

Re: [PATCH 2/2] omap:mailbox-provide multiple reader support

2010-07-22 Thread Hari Kanigeri
is both more idiomatic in linux, and I'm sure a simpler patch. -- Sure, I will make the change. Phil From: linux-omap-ow...@vger.kernel.org [linux-omap-ow...@vger.kernel.org] On Behalf Of ext Hari Kanigeri [h-kanige...@ti.com] Sent: 21 July 2010 01

Re: [PATCH 2/2] omap:mailbox-provide multiple reader support

2010-07-22 Thread Hari Kanigeri
Fernando, Thanks for looking at the patch. On Tue, Jul 20, 2010 at 4:59 PM, Guzman Lugo, Fernando fernando.l...@ti.com wrote: Hi Hari, @@ -252,28 +252,30 @@ static int omap_mbox_startup(struct omap_mbox *mbox)               }       } -     ret = request_irq(mbox-irq, mbox_interrupt,

[PATCH 0/2] omap:mailbox-provide multiple readers support

2010-07-20 Thread Hari Kanigeri
This patch series provides the support for mutiple readers per mailbox instance. The first patch is mostly cleanup and the second patch consists of the changes to provide multiple readers support. Hari Kanigeri (2): omap:mailbox-make mailbox reference counter atomic omap:mailbox-provide

[PATCH 2/2] omap:mailbox-provide multiple reader support

2010-07-20 Thread Hari Kanigeri
This patch provides mutiple readers support for a mailbox instance. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/include/plat/mailbox.h |6 ++- arch/arm/plat-omap/mailbox.c | 63 2 files changed, 40 insertions(+), 29

[PATCH 2/5] omap:hwspinlock-define HWSPINLOCK base address

2010-07-19 Thread Hari Kanigeri
From: Simon Que s...@ti.com Add HWSPINLCOK base address information in omap44xx.h Signed-off-by: Simon Que s...@ti.com Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/plat-omap/include/plat/omap44xx.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch

[PATCH 1/5] omap:hwmod-hwspinlock-enable

2010-07-19 Thread Hari Kanigeri
From: Simon Que s...@ti.com uncomment the hwmod part for hwspinlock Signed-off-by: Simon Que s...@ti.com Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH 3/5] omap:hwspinlock-added hwspinlock driver

2010-07-19 Thread Hari Kanigeri
it returns a spinlock handle. int hwspinlock_free(struct hwspinlock *); Frees an allocated hardware spinlock (either reserved or unreserved). Signed-off-by: Simon Que s...@ti.com Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/hwspinlocks.c| 70

[PATCH 0/5] omap:hwspinlock support-omap4

2010-07-19 Thread Hari Kanigeri
(struct hwspinlock *); Frees an allocated hardware spinlock (either reserved or unreserved). Hari Kanigeri (1): omap:hwspinlocks-ensure the order of registration Simon Que (4): omap:hwmod-hwspinlock-enable omap:hwspinlock-define HWSPINLOCK base address omap:hwspinlock-added

[PATCH 5/5] omap:hwspinlocks-ensure the order of registration

2010-07-19 Thread Hari Kanigeri
Ensure that the hwspinlock driver is registered prior to I2C driver registration since I2C is dependent on hwspinlock. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/hwspinlocks.c |2 +- arch/arm/plat-omap/hwspinlock.c |3 +-- 2 files changed, 2 insertions

[PATCH 4/5] omap:hwspinlock-add build support

2010-07-19 Thread Hari Kanigeri
From: Simon Que s...@ti.com Patch to add suport to build hwspinlock modules Signed-off-by: Simon Que s...@ti.com --- arch/arm/mach-omap2/Makefile |2 ++ arch/arm/plat-omap/Makefile |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/Makefile

Re: [RFC 3/3] mm: iommu: The Virtual Contiguous Memory Manager

2010-07-01 Thread Hari Kanigeri
He demonstrated the usage of his code in one of the emails he sent out initially. Did you go over that, and what (or how many) step would you use with the current code to do the same thing? -- So is this patch set adding layers and abstractions to help the User ? If the idea is to share some

Re: [RFC 3/3] mm: iommu: The Virtual Contiguous Memory Manager

2010-07-01 Thread Hari Kanigeri
The VCMM takes the long view. Its designed for a future in which the number of IOMMUs will go up and the ways in which these IOMMUs are composed will vary from system to system, and may vary at runtime. Already, there are ~20 different IOMMU map implementations in the kernel. Had the Linux

[PATCH 0/3][v3] omap:iommu-enable TLB miss interrupt

2010-05-23 Thread Hari Kanigeri
on Hiroshi, the initial patch set was revised to add more flexibility to enable TWL and cleanup the part of the code that had layering violations. https://patchwork.kernel.org/patch/101336/ Hari Kanigeri (2): omap: iommu-update irq mask to be specific about twl and tlb omap: iommu-add

[PATCH 2/3] omap: iommu-add functionality to get TLB miss interrupt

2010-05-23 Thread Hari Kanigeri
miss interrupt. Signed-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Ramesh Gupta grgu...@ti.com Signed-off-by: Hiroshi Doyu hiroshi.d...@nokia.com --- arch/arm/mach-omap2/iommu2.c| 32 ++ arch/arm/plat-omap/include/plat/iommu.h |2 + arch

[PATCH 0/2][v2] omap:iommu-enable TLB miss interrupt

2010-05-20 Thread Hari Kanigeri
on Hiroshi, the initial patch set was revised to add more flexibility to enable TWL. Hari Kanigeri (2): omap: iommu-update irq mask to be specific about twl and tlb omap: iommu-add functionality to get TLB miss interrupt arch/arm/mach-omap2/iommu2.c| 36

[PATCH 2/2] omap: iommu-add functionality to get TLB miss interrupt

2010-05-20 Thread Hari Kanigeri
miss interrupt. Signed-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Ramesh Gupta grgu...@ti.com Signed-off-by: Hiroshi Doyu hiroshi.d...@nokia.com --- arch/arm/mach-omap2/iommu2.c| 26 +- arch/arm/plat-omap/include/plat/iommu.h |2 ++ arch/arm

[PATCH 1/2] omap: iommu-update irq mask to be specific about twl and tlb

2010-05-20 Thread Hari Kanigeri
Revise the IRQ mask definitions to handle the MMU faults related to TWL fault as well as TLB miss fault. Signed-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Hiroshi Doyu hiroshi.d...@nokia.com --- arch/arm/mach-omap2/iommu2.c | 12 1 files changed, 8 insertions(+), 4

[PATCH] omap:hwmod-remove prm header from prm-regbits-xxxx headers

2010-05-19 Thread Hari Kanigeri
The prm-regbits-.h header files are not dependent on prm.h header file. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c |1 + arch/arm/mach-omap2/prm-regbits-24xx.h |1 - arch/arm/mach-omap2/prm-regbits-34xx.h |1 - arch/arm

[PATCH 1/2] omap: iommu-update irq mask to be specific about twl

2010-05-17 Thread Hari Kanigeri
Update the irq mask so that is is clear that the MMU interrupt is related to TWL fault. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/iommu2.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach

[PATCH 0/2] omap:iommu-enable TLB miss interrupt

2010-05-17 Thread Hari Kanigeri
The current iommu module doesn't provide the mechanism to get MMU fault on TLB miss when working with locked TLB entries and TWL disabled. To get the TLB miss interrupt, the TWL should be disabled. This patch set provides the mechanism to disable TWL and enable TLB miss interrupt. Hari Kanigeri

[PATCH 2/2] omap: iommu-add functionality to get TLB miss interrupt

2010-05-17 Thread Hari Kanigeri
miss interrupt. Signed-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Ramesh Gupta grgu...@ti.com --- arch/arm/mach-omap2/iommu2.c| 13 + arch/arm/plat-omap/include/plat/iommu.h |2 ++ arch/arm/plat-omap/iommu.c | 12 3 files changed

[PATCH] omap: iommu- update ducati mmu irq define name

2010-05-14 Thread Hari Kanigeri
2.6.34-rc6 kernel has the Ducati mmu irq define name changed, which is resulting in compilation error. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/omap-iommu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/omap-iommu.c b

[PATCH 0/4][v4]OMAP:IOMMU support for OMAP4 and TLB preservation support

2010-04-22 Thread Hari Kanigeri
Following are the revised patches addressing the comments from Tony, Felipe, and Hiroshi to address multi-omap support and make TLB locking mechanism generic. Hari Kanigeri (4): OMAP:iommu renamed omap3-iommu to omap-iommu OMAP:iommu support for OMAP4 OMAP:iommu - missing check for TLB

[PATCH 2/4][v4] OMAP:iommu support for OMAP4

2010-04-22 Thread Hari Kanigeri
This patch provides the iommu support for OMAP4 co-processors. Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/omap-iommu.c | 59 +-- arch/arm/plat-omap/include/plat/omap44xx.h |3 + 2 files changed, 57 insertions(+), 5 deletions

[PATCH 1/4][v4] OMAP:iommu renamed omap3-iommu to omap-iommu

2010-04-22 Thread Hari Kanigeri
This patch includes changes to omap3-iommu.c file to make it generic for all OMAPs. Renamed omap3-iommu.c to omap-iommu.c Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/Makefile |4 +-- .../arm/mach-omap2/{omap3-iommu.c = omap-iommu.c} | 23

[PATCH 3/4][v4] OMAP:iommu - missing check for TLB valid entry

2010-04-22 Thread Hari Kanigeri
Added the missing TLB valid entry setting for cam register Signed-off-by: Hari Kanigeri h-kanige...@ti.com --- arch/arm/mach-omap2/iommu2.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c index 6f4b7cc..f01f985

[PATCH 4/4][v4] OMAP:iommu- add TLB preservation support

2010-04-22 Thread Hari Kanigeri
This patch adds TLB preservation support to IOMMU module Signed-off-by: Hari Kanigeri h-kanige...@ti.com Signed-off-by: Hiroshi Doyu hiroshi.d...@nokia.com --- arch/arm/mach-omap2/iommu2.c |4 ++- arch/arm/plat-omap/iommu.c | 43 + 2 files changed