Re: [PATCH V2] mmc: omap_hsmmc: Fix sleep too long in ISR context.

2013-08-20 Thread Hein Tibosch
my test,it looks good. Reported-by: Yuzheng Ma mayuzh...@kedacom.com Tested-by: Yuzheng Ma mayuzh...@kedacom.com Reviewed-by: Hein Tibosch hein_tibo...@yahoo.es Signed-off-by: Jianpeng Ma majianp...@gmail.com --- drivers/mmc/host/omap_hsmmc.c | 25 +++-- 1 file changed

Re: [PATCH] mmc: omap_hsmmc: Fix sleep too long in ISR context.

2013-08-01 Thread Hein Tibosch
Hi Jianpeng Ma, On 8/1/2013 10:18 AM, majianpeng wrote: We found a problem when we removed a working sd card that the irqaction of omap_hsmmc can sleep to 3.6s. This cause our watchdog to work. In func omap_hsmmc_reset_controller_fsm, it should watch a 0-1 transition.It used loops_per_jiffy

[PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Hein Tibosch
after the last command. Thanks, Hein Signed-off-by: Hein Tibosch hein_tibo...@yahoo.es --- drivers/i2c/busses/i2c-omap.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index e02f9e3..2f7a712 100644

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Hein Tibosch
On 7/16/2013 5:03 PM, Felipe Balbi wrote: Hi, On Tue, Jul 16, 2013 at 04:19:35PM +0800, Hein Tibosch wrote: Hi Vikram, On a OMAP4460, i2c-bus-3: A driver (lm75) is causing many 'timeout waiting for bus ready' errors. SDA remains high (as it should), but SCL remains low after a NACK

Re: [PATCH] i2c-omap: always send stop after nack

2013-07-16 Thread Hein Tibosch
problem as i2c-omap, and will need the same change. Grygorii, if you submit the patch, please add my Signed-off-by: Hein Tibosch hein_tibo...@yahoo.es cause you were earlier to notice and fix this problem. Hein -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: omapfb-main.c: check result of simple_strtoul

2012-05-10 Thread Hein Tibosch
On 5/10/2012 4:23 PM, Tomi Valkeinen wrote: On Wed, 2012-05-09 at 22:47 +0800, Hein Tibosch wrote: fbnum = simple_strtoul(p, p, 10); -if (p == param) +if (p == start) correct? Yes, looks like a correct fix. I'll cook up a patch. How did you encounter

omapfb-main.c: check result of simple_strtoul

2012-05-09 Thread Hein Tibosch
Tomi, In drivers/video/omap2/omapfb/omapfb-main.c: static int omapfb_parse_vram_param(const char *param, int max_entries, unsigned long *sizes, unsigned long *paddrs) { int fbnum; unsigned long size; unsigned long paddr = 0; char *p, *start;