Re: [PATCH v2] hw_random: omap3-rom-rng: convert timer to delayed work

2015-11-23 Thread Herbert Xu
rted-by: Sebastian Reichel <s...@kernel.org> > Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hw_random: omap3-rom-rng: convert timer to delayed work

2015-11-17 Thread Herbert Xu
rted-by: Sebastian Reichel <s...@kernel.org> > Signed-off-by: Aaro Koskinen <aaro.koski...@iki.fi> Thanks for the patch. Can you please remove timer.h and include workqueue.h instead? Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gond

Re: [PATCH v3] crypto: omap-aes: Add support for GCM mode

2015-09-18 Thread Herbert Xu
. Also tmp must not be reused by a subsequent call to scatterwalk_ffwd. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

2015-07-11 Thread Herbert Xu
context on the other hand is specific to a request so it can be used to store information. Cheers, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

2015-07-08 Thread Herbert Xu
On Wed, Jul 08, 2015 at 03:48:05PM +0800, Herbert Xu wrote: On Wed, Jul 08, 2015 at 12:29:47PM +0530, Lokesh Vutla wrote: +if (req-assoclen + req-cryptlen == 0) { +scatterwalk_map_and_copy(ctx-auth_tag, req-dst, 0, authlen

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

2015-07-08 Thread Herbert Xu
if assoclen and cryptlen is 0. Correct me if I am wrong. It should be E(K, Y0) ^ GHASH(0). So unless GHASH(0) == 0, your code doesn't work. Cheers, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/7] crypto: omap-aes: Add support for GCM mode

2015-07-08 Thread Herbert Xu
On Tue, Jul 07, 2015 at 09:01:42PM +0530, Lokesh Vutla wrote: This series does some basic cleanup and adds support for AES GCM mode for omap aes driver. Changes since v1: - Switched GCM to new AEAD interface Patches 1-4 and 7 applied. Cheers, -- Email: Herbert Xu herb

Re: [PATCH v2 5/7] crypto: aead: Add aead_request_cast() api

2015-07-07 Thread Herbert Xu
posted. Thanks, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 6/7] crypto: omap-aes: Add support for GCM mode

2015-07-07 Thread Herbert Xu
, + 1); + return 0; + } How can this be right? Did you enable the selftest? Cheers, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 10/10] crypto: tcrypt: Added speed tests for Async AEAD crypto alogrithms

2015-07-06 Thread Herbert Xu
On Thu, Jul 02, 2015 at 10:48:40AM +0530, Lokesh Vutla wrote: Adding simple speed tests for a range of block sizes for Async AEAD crypto algorithms. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com What's wrong with the existing AEAD speed tests? -- Email: Herbert Xu herb

Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info

2015-07-06 Thread Herbert Xu
will not be accepting any new implementations using the old interface. Please convert your driver over to the new interface. Also please merge your GCM patches into a single patch. Splitting out bug fixes makes no sense. Thanks, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http

Re: [PATCH 10/10] crypto: tcrypt: Added speed tests for Async AEAD crypto alogrithms

2015-07-06 Thread Herbert Xu
On Mon, Jul 06, 2015 at 02:15:06PM +0530, Lokesh Vutla wrote: The existing AEAD test case does not do a wait_for_completion(), when the return value is EINPROGRESS or EBUSY like it is done for acipher_speed tests. Please fix them to do the wait. Thanks, -- Email: Herbert Xu herb

Re: [PATCH 01/10] crypto: omap-aes: Add support for lengths not aligned with AES_BLOCK_SIZE

2015-07-06 Thread Herbert Xu
should state that explicitly. Because partial blocks make no sense otherwise. Cheers, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line

Re: [PATCH 04/10] crypto: omap-aes: Use BIT() macro

2015-07-06 Thread Herbert Xu
, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] crypto: omap-des: Fix unmapping of dma channels

2015-07-06 Thread Herbert Xu
(). Reported-by: Tomi Valkeinen tomi.valkei...@ti.com Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Applied to crypto. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from

Re: [PATCH 03/10] crypto: aead: Add aead_request_cast() api

2015-07-06 Thread Herbert Xu
); } +static inline struct aead_request *aead_request_cast( + struct crypto_async_request *req) +{ + return container_of(req, struct aead_request, base); +} + This should go into include/crypto/internal/aead.h. Thanks, -- Email: Herbert Xu herb

Re: [PATCH v2] crypto: omap-sham: Add the offset of sg page to vaddr

2015-04-03 Thread Herbert Xu
for omap-sha256 So adding the scatterlist offset to vaddr. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Patch applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: omap-sham: Check for HIGHMEM before mapping SG pages

2015-04-01 Thread Herbert Xu
either your architecture is broken (because the same problem would obviously affect the core crypto code which does exactly the same thing), or there is some other bug causing the selftest to fail. Cheers, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au

Re: [PATCH] crypto: omap-sham: Use pm_runtime_irq_safe()

2015-04-01 Thread Herbert Xu
(), because of which the following appears: [ 116.169969] BUG: scheduling while atomic: kworker/0:2/2676/0x0100 Add pm_runtime_irq_safe() to avoid this. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Applied. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http

Re: [PATCH] crypto: omap-aes: Fix support for unequal lengths

2015-04-01 Thread Herbert Xu
lengths) Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Applied. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [v3] hwrng: omap - Change RNG_CONFIG_REG to RNG_CONTROL_REG when, checking and disabling TRNG

2015-03-01 Thread Herbert Xu
. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH V2] crypto: omap-des - handle error of pm_runtime_get_sync

2014-04-16 Thread Herbert Xu
proper acknowledgement of your report. adding the following for patchworks to pickup. Reported-by: Joachim Eastwood manab...@gmail.com Acked-by: Joel Fernandes jo...@ti.com Patch applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au

Re: [PATCH v3] crypto: omap-sham: Map SG pages if they are HIGHMEM before accessing

2014-03-10 Thread Herbert Xu
! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2] crypto: omap-sham: kmap SG pages before appending

2014-03-05 Thread Herbert Xu
this from softirq context. Cheers, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH v2 0/2] Introduce omap-des driver for OMAP SoCs

2014-02-25 Thread Herbert Xu
and build options Both patches applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH] crypto: omap-sham: Fix Polling mode for larger blocks

2013-12-20 Thread Herbert Xu
. But it should be made 0 only if it is a final update or a total is not zero(This condition is similar to what is done in DMA case). Because of this wrong hashes are produced. Fixing the same. Signed-off-by: Lokesh Vutla lokeshvu...@ti.com Patch applied. Thanks! -- Email: Herbert Xu herb

Re: [PATCH] crypto: omap-sham - Only release DMA channel if successfully requested

2013-12-05 Thread Herbert Xu
. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] crypto: omap-aes: add error check for pm_runtime_get_sync

2013-12-05 Thread Herbert Xu
://bugzilla.kernel.org/show_bug.cgi?id=66441 Reported-by: Tobias Jakobi tjak...@math.uni-bielefeld.de Signed-off-by: Nishanth Menon n...@ti.com Patch applied. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 2/3] hwrng: OMAP3 ROM Random Number Generator support

2013-11-18 Thread Herbert Xu
On Mon, Nov 18, 2013 at 10:51:30PM +0100, Pali Rohár wrote: On Wednesday 16 October 2013 14:57:34 Herbert Xu wrote: On Tue, Oct 08, 2013 at 12:04:09PM -0700, Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [130920 06:33]: This driver provides kernel-side support for the Random

Re: [PATCH] crypto: omap-aes: Fix CTR mode counter length

2013-10-29 Thread Herbert Xu
Patch applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH v2 2/3] hwrng: OMAP3 ROM Random Number Generator support

2013-10-16 Thread Herbert Xu
on Nokia RX-51. It is platform device because it needs board specific function for smc calls. This one is should be merged via the hw_random patches seprately: Acked-by: Tony Lindgren t...@atomide.com Patch applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http

Re: [PATCH 0/2] crypto: omap-sham: Misc updates for driver

2013-08-21 Thread Herbert Xu
burst size Both patches applied. Thanks. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH v2 00/14] crypto: omap-aes: Improve DMA, add PIO mode and support for AM437x

2013-08-21 Thread Herbert Xu
. Tests have been performed on AM335x, OMAP4 and AM437x SoCs. Below is a sample run on AM335x SoC (beaglebone board), showing performance improvement (20% for 8K blocks): All applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP

Re: [PATCH] hwrng: reorder OMAP TRNG driver code

2013-08-21 Thread Herbert Xu
applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 0/6] hwrng: OMAP: Updates for OMAP RNG module

2013-08-09 Thread Herbert Xu
All applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 0/4] crypto: omap-sham: Add support for SHA384/SHA512 for OMAP5/AM43xx Soc's

2013-07-31 Thread Herbert Xu
. All applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH v2] OMAP: AES: Don't idle/start AES device between Encrypt operations

2013-06-05 Thread Herbert Xu
Patch applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH v2] OMAP: AES: Don't idle/start AES device between Encrypt operations

2013-05-28 Thread Herbert Xu
the current cryptodev tree. Please rebase and repost. Thanks, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH v2 00/10] crypto: omap-aes - Updates New Functionality

2013-01-19 Thread Herbert Xu
has All applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH] crypto: omap-sham - Fix compile errors when CONFIG_OF not defined

2013-01-19 Thread Herbert Xu
() to omap_sham_get_res_of() and creating an empty version of omap_sham_of_match[]. Signed-off-by: Mark A. Greer mgr...@animalcreek.com Also applied. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/9] crypto: omap-sham - Updates New Functionality

2013-01-05 Thread Herbert Xu
) - some misc patches required by the EDMA patches - a hack to fix the compilation error that the current k.o. kernel has All applied. Thaks a lot! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/5] hwrng/ARM: OMAP: convert to use runtime PM

2012-08-30 Thread Herbert Xu
? Acked-by: Herbert Xu herb...@gondor.apana.org.au This series will conflict with the planned ARM common zImage changes that we have planned so I'd like to merge them via the ARM soc tree. Thanks, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert

Re: [PATCH 00/11] crypto: omap-sham driver fixes

2011-06-08 Thread Herbert Xu
. All applied to cryptodev. Thanks Dmitry! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH 0/4] crypto: omap-sham driver fixes

2011-04-26 Thread Herbert Xu
On Wed, Apr 20, 2011 at 01:34:54PM +0300, Dmitry Kasatkin wrote: Hi, Here is few patches with couple of important fixes... All applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert

Re: [PATCH 1/1] omap-sham: backlog handling fix

2010-12-29 Thread Herbert Xu
not happen in implementation similar to crypto test manager, but it will happen in implementation similar to dm-crypt. Backlog needs to be checked before dequeuing next request. Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com Patch applied. Thanks Dmitry. -- Email: Herbert Xu herb

Re: [PATCHv2 0/6] omap-aes off mode and error handling fixes

2010-12-02 Thread Herbert Xu
it - checkpatch fixes in separate patch All applied. Thanks Dmitry! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH v3 0/8] omap-sham: OMAP SHA1/MD5 driver fixes and improvements

2010-11-27 Thread Herbert Xu
On Fri, Nov 19, 2010 at 04:04:21PM +0200, Dmitry Kasatkin wrote: Hi, Here is a set of patches which provides fixes and improvements. Based on Herbert feedback it also includes fixes so that calling final() is not mandatory. All applied. Thanks Dmitry! -- Email: Herbert Xu herb

Re: linux-next: manual merge of the crypto tree with the omap tree

2010-09-26 Thread Herbert Xu
and commit b744c679f62b368cb94c21c1dcd4618e42d88d63 (crypto: updates to enable omap aes) from the crypto tree. Two versions of the same patch. The version in the omap tree has been updated, so I used that. Thanks for the note Stephen. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page

Re: [PATCH 1/1] crypto: omap-sham: Adjust DMA parameters

2010-09-03 Thread Herbert Xu
percent depending on the bus / memory load. Signed-off-by: Samu Onkalo samu.p.onk...@nokia.com Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com Patch applied. Thanks! -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [PATCH 1/2] crypto: updates to enable omap aes

2010-08-31 Thread Herbert Xu
On Tue, Aug 31, 2010 at 11:52:27AM +0300, Dmitry Kasatkin wrote: Hi, Does anyone want to comment on this? Please be patient. Your patches are still in my queue. Resending them is only going to slow them down. Thanks, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page: http

Re: [PATCH 1/1] omap-sham: OMAP macros corrected

2010-05-13 Thread Herbert Xu
at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 1/1] omap-sham: OMAP macros corrected

2010-05-10 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org

Re: [PATCHv4 0/2] omap-sham: OMAP SHA1/MD5 driver

2010-05-02 Thread Herbert Xu
applied. Thanks for all your hard work Dmitry! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line

Re: [PATCHv3 2/2] crypto: omap-sham - omap sha1 md5 driver

2010-04-14 Thread Herbert Xu
if available Signed-off-by: Dmitry Kasatkin dmitry.kasat...@nokia.com You have not addressed my objections raised earlier. Also, why are you exporting a shash object? You cannot sleep during shash operations (except for setkey). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert

Re: [PATCHv3 2/2] crypto: omap-sham - omap sha1 md5 driver

2010-04-14 Thread Herbert Xu
. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 MD5 driver

2010-04-08 Thread Herbert Xu
On Tue, Mar 23, 2010 at 07:32:39PM +0800, Herbert Xu wrote: My only question is what's your plan with respect to HMAC? If you're going to do it in hardware then it's fine as it is. Otherwise you need to implement export/import and we also need to add ahash support to hmac.c. Dmitry, did

Re: [PATCH 0/2] crypto: omap-sha1-md5: OMAP3 SHA1 MD5 driver

2010-03-23 Thread Herbert Xu
going to do it in hardware then it's fine as it is. Otherwise you need to implement export/import and we also need to add ahash support to hmac.c. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} herb...@gondor.apana.org.au Home Page: http://gondor.apana.org.au