Re: [PATCH] spi: omap2-mcspi: add runtime PM to set_cs()

2015-08-30 Thread Jarkko Nikula
to this patch which made the WLAN working. If you are going to resend this, please feel free to add my tested by: Tested-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: Nokia N900 - audio TPA6130A2 problems

2015-08-03 Thread Jarkko Nikula
Hi On 08/01/2015 01:18 PM, Pali Rohár wrote: On Saturday 25 July 2015 15:17:13 Lars-Peter Clausen wrote: On 07/25/2015 12:28 PM, Pali Rohár wrote: Hello, sometimes after rebooting Nokia N900 initializing alsa audio fails. Here output from dmesg log when it happen: [6.925140] tpa6130a2

Re: Nokia N900 - audio TPA6130A2 problems

2015-08-03 Thread Jarkko Nikula
On 08/03/2015 09:17 PM, Pali Rohár wrote: On Monday 03 August 2015 20:03:16 Jarkko Nikula wrote: Hi On 08/01/2015 01:18 PM, Pali Rohár wrote: On Saturday 25 July 2015 15:17:13 Lars-Peter Clausen wrote: Hello, your patch did not helped. Problem is still there... For me v4.2-rc5 works, i.e

Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages

2015-03-30 Thread Jarkko Nikula
On 03/30/2015 07:42 PM, Tony Lindgren wrote: * Jarkko Nikula jarkko.nik...@bitmer.com [150330 09:31]: On 03/01/2015 09:07 PM, Jarkko Nikula wrote: From: Pavel Machek pa...@ucw.cz N900 audio recording needs that codec provides bias voltage for integrated digital microphone and headset

Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages

2015-03-30 Thread Jarkko Nikula
On 03/01/2015 09:07 PM, Jarkko Nikula wrote: From: Pavel Machek pa...@ucw.cz N900 audio recording needs that codec provides bias voltage for integrated digital microphone and headset microphone depending which one is used. Digital microphone uses 2 V bias and it comes from the codec A part

Re: [PATCH] ASoC: omap-pcm: Allow only formats with 1, 2, and 4 byte physical size

2015-03-03 Thread Jarkko Nikula
On Tue, Mar 03, 2015 at 01:41:21PM +0200, Peter Ujfalusi wrote: On 03/03/2015 01:28 PM, Jyri Sarha wrote: sDMA support only transfer elements with 1, 2, and 4 byte physical size. Initialize the pcm driver accordingly. Acked-by: Peter Ujfalusi peter.ujfal...@ti.com Signed-off-by:

[PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages

2015-03-01 Thread Jarkko Nikula
and that is set to 2.5 V. Signed-off-by: Pavel Machek pa...@ucw.cz [Jarkko: Headset mic bias changed to 2 (2.5 V) as it was before commit e2e8bfdf6157 (ASoC: tlv320aic3x: Convert mic bias to a supply widget)] Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/boot/dts/omap3-n900.dts

Re: v3.19: Nokia N900 - auto not working

2015-01-31 Thread Jarkko Nikula
Hi On 01/31/2015 11:35 AM, Pali Rohár wrote: Hello, audio on (real) n900 device does not working with 3.19 kernel. Here is relevant dmesg output: [5.687438] omap_i2c 4807.i2c: bus 1 rev3.3 at 2200 kHz [5.696166] tpa6130a2 2-0060: Write failed [5.696228] tpa6130a2

[PATCH] ARM: dst: OMAP3-N900: Add microphone bias voltages

2015-01-30 Thread Jarkko Nikula
and that is set to 2.5 V. Signed-off-by: Pavel Machek pa...@ucw.cz [Jarkko: Headset mic bias changed to 2 (2.5 V) as it was before commit e2e8bfdf6157 (ASoC: tlv320aic3x: Convert mic bias to a supply widget)] Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- Pavel: I hope you don't mind I

Re: 3.19 on Nokia n900: audio quality awful

2015-01-28 Thread Jarkko Nikula
On 01/26/2015 03:20 PM, Peter Ujfalusi wrote: On 01/18/2015 02:01 PM, Pavel Machek wrote: In 2.6.28-nokia, it is neccessary to set Input select na digital mic, then it works. Input select being in playback option makes it easy to miss. In 3.18 and 3.19-rc3, all I can record are zeros. Does

Re: 3.19 on Nokia n900: audio quality awful

2015-01-28 Thread Jarkko Nikula
On Wed, Jan 28, 2015 at 11:41:44PM +0100, Pavel Machek wrote: On Wed 2015-01-28 20:15:46, Jarkko Nikula wrote: On 01/26/2015 03:20 PM, Peter Ujfalusi wrote: On 01/18/2015 02:01 PM, Pavel Machek wrote: No need to go that far. N900 has been supported in mainline since 2.6.39 or so. Part

Re: [PATCH] ASoC: OMAP: mcbsp: ensure that CLKX and CLKR are not used as ouput pins when they are used as input clock for the SRG.

2015-01-16 Thread Jarkko Nikula
Hi On Thu, Jan 15, 2015 at 11:28:21PM +0100, Thomas Niederprüm wrote: This patch fixes faulty behaviour in a setup where the input clock for the SRG is fed through the CLKR pin but the McBSP is configured to be master (SND_SOC_DAIFMT_CBS_CFS). In that case of course CLKR must not be

Re: ASoC: omap-mcbsp: Deletion of an unnecessary check before the function call kfree

2014-11-17 Thread Jarkko Nikula
was detected by using the Coccinelle software. Signed-off-by: Markus Elfring elfr...@users.sourceforge.net --- sound/soc/omap/mcbsp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 3/5] ASoC: omap: Add HA (HEAD acoustics) DSP add-on card audio driver for TAO3530

2014-04-28 Thread Jarkko Nikula
On 04/28/2014 03:17 PM, Stefan Roese wrote: From: Jarkko Nikula jarkko.nik...@bitmer.com Same authorship and commit log notes here than to 2/5. One important comment below. --- /dev/null +++ b/sound/soc/omap/ha-dsp-card.c @@ -0,0 +1,307 @@ +/* + * ha-dsp-card.c -- SoC audio HA-DSP add

Re: [PATCH 3/5] ASoC: omap: Add HA (HEAD acoustics) DSP add-on card audio driver for TAO3530

2014-04-28 Thread Jarkko Nikula
On 04/28/2014 03:17 PM, Stefan Roese wrote: From: Jarkko Nikula jarkko.nik...@bitmer.com Same authorship and commit log notes here than to 2/5. One important note below. --- /dev/null +++ b/sound/soc/omap/ha-dsp-card.c @@ -0,0 +1,307 @@ +/* + * ha-dsp-card.c -- SoC audio HA-DSP add

Re: [PATCH 2/5] ASoC: Add HA (HEAD acoustics) DSP codec driver template

2014-04-28 Thread Jarkko Nikula
Hi Stefan On 04/28/2014 03:17 PM, Stefan Roese wrote: From: Jarkko Nikula jarkko.nik...@bitmer.com This codec driver template represents an I2C controlled multichannel audio codec that has many typical ASoC codec driver features like volume controls, mixer stages, mux selection, output

Re: [PATCH] sound: omap: n810: fix init with DT boot

2014-03-03 Thread Jarkko Nikula
. You can add my ack Acked-by: Jarkko Nikula jarkko.nik...@linux.intel.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[RESEND 5/7] mmc: omap: Convert to devm_ioremap_resource

2014-02-22 Thread Jarkko Nikula
Simplify probe and cleanup code by using devm_ioremap_resource. This also makes probe code to follow more common allocate private struct followed by other initialization style. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com Acked-by: Tony Lindgren t...@atomide.com Tested-by: Aaro Koskinen

[RESEND 0/7] mmc: omap: Fixes, cleanup and add ERASE capability

2014-02-22 Thread Jarkko Nikula
no longer works for Samsung and I don't know his personal address. Set goes on top of mmc.git v3.14-rc2-10-g7536d3f83aa4. Jarkko Nikula (7): mmc: omap: Fix NULL pointer dereference due uninitialized cover_tasklet mmc: omap: Convert to devm_kzalloc mmc: omap: Remove duplicate host-irq

[RESEND 4/7] mmc: omap: Remove mem_res field from struct mmc_omap_host

2014-02-22 Thread Jarkko Nikula
Field mem_res in struct mmc_omap_host is used only once in mmc_omap_probe when setting the phys_base field so we may just se the phys_base straight and remove needless mem_res. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com Acked-by: Tony Lindgren t...@atomide.com Tested-by: Aaro Koskinen

[RESEND 1/7] mmc: omap: Fix NULL pointer dereference due uninitialized cover_tasklet

2014-02-22 Thread Jarkko Nikula
mmc_add_host call in mmc_omap_new_slot. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com Acked-by: Tony Lindgren t...@atomide.com Tested-by: Aaro Koskinen aaro.koski...@iki.fi --- v2: a snip of stack dump added to commit log --- drivers/mmc/host/omap.c | 12 +++- 1 file changed, 7

[RESEND 6/7] mmc: omap: Remove always set use_dma flag from struct mmc_omap_host

2014-02-22 Thread Jarkko Nikula
Because use_dma is set only in mmc_omap_probe and unset nowhere there is no need to carry that flag in struct mmc_omap_host for mmc_omap_prepare_data function. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com Acked-by: Tony Lindgren t...@atomide.com Tested-by: Aaro Koskinen aaro.koski

[RESEND 7/7] mmc: omap: Add erase capability

2014-02-22 Thread Jarkko Nikula
This patch adds the erase capability to OMAP1/OMAP2420 MMC driver. Idea is the same than in commit 93caf8e (omap_hsmmc: add erase capability) that we disable the data timeout interrupt for erases. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com Acked-by: Tony Lindgren t...@atomide.com

[RESEND 3/7] mmc: omap: Remove duplicate host-irq assignment

2014-02-22 Thread Jarkko Nikula
host-irq is set twice so remove needless one. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com Acked-by: Tony Lindgren t...@atomide.com Tested-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/mmc/host/omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/omap.c b

[RESEND 2/7] mmc: omap: Convert to devm_kzalloc

2014-02-22 Thread Jarkko Nikula
Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com Acked-by: Tony Lindgren t...@atomide.com Tested-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/mmc/host/omap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c

Re: [PATCH 0/7] mmc: omap: Fixes, cleanup and add ERASE capability

2013-12-06 Thread Jarkko Nikula
On 12/06/2013 01:41 PM, Aaro Koskinen wrote: Set goes on top of v3.13-rc2-208-g8ecffd791448. Patch 5 had some fuzz with plain 3.13-rc2. Otherwise these look fine. I tested these on 770 and N800, so for all patches: Tested-by: Aaro Koskinen aaro.koski...@iki.fi Yes, reason for your fuzz

[PATCH 2/7] mmc: omap: Convert to devm_kzalloc

2013-12-04 Thread Jarkko Nikula
Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- drivers/mmc/host/omap.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 42b665d..927ed24 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c

[PATCH 4/7] mmc: omap: Remove mem_res field from struct mmc_omap_host

2013-12-04 Thread Jarkko Nikula
Field mem_res in struct mmc_omap_host is used only once in mmc_omap_probe when setting the phys_base field so we may just se the phys_base straight and remove needless mem_res. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- drivers/mmc/host/omap.c | 4 +--- 1 file changed, 1 insertion

[PATCH 6/7] mmc: omap: Remove always set use_dma flag from struct mmc_omap_host

2013-12-04 Thread Jarkko Nikula
Because use_dma is set only in mmc_omap_probe and unset nowhere there is no need to carry that flag in struct mmc_omap_host for mmc_omap_prepare_data function. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- drivers/mmc/host/omap.c | 15 +-- 1 file changed, 5 insertions

[PATCH 5/7] mmc: omap: Convert to devm_ioremap_resource

2013-12-04 Thread Jarkko Nikula
Simplify probe and cleanup code by using devm_ioremap_resource. This also makes probe code to follow more common allocate private struct followed by other initialization style. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- drivers/mmc/host/omap.c | 41

[PATCH 1/7] mmc: omap: Fix NULL pointer dereference due uninitialized cover_tasklet

2013-12-04 Thread Jarkko Nikula
mmc_add_host call in mmc_omap_new_slot. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- v2: a snip of stack dump added to commit log --- drivers/mmc/host/omap.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host

[PATCH 7/7] mmc: omap: Add erase capability

2013-12-04 Thread Jarkko Nikula
This patch adds the erase capability to OMAP1/OMAP2420 MMC driver. Idea is the same than in commit 93caf8e (omap_hsmmc: add erase capability) that we disable the data timeout interrupt for erases. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- drivers/mmc/host/omap.c | 18

[PATCH 0/7] mmc: omap: Fixes, cleanup and add ERASE capability

2013-12-04 Thread Jarkko Nikula
the error introduced by 31ee9181eb92: http://www.spinics.net/lists/linux-omap/msg100790.html Patch 6 continue cleanup and 7 adds the ERASE capability to the driver so one could utilize discards with mkfs, mount option or with the fstrim. Set goes on top of v3.13-rc2-208-g8ecffd791448. Jarkko

[PATCH 3/7] mmc: omap: Remove duplicate host-irq assignment

2013-12-04 Thread Jarkko Nikula
host-irq is set twice so remove needless one. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- drivers/mmc/host/omap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 927ed24..b438f0a 100644 --- a/drivers/mmc/host/omap.c +++ b

Re: [PATCH] mmc: omap: Fix error introduced by fix to release_mem_region() path

2013-12-03 Thread Jarkko Nikula
On 12/02/2013 07:34 PM, Tony Lindgren wrote: Commit 31ee9181eb92: (mmc: omap: Fix DMA configuration to not rely on device id) fixed getting of the DMA resources when booted with device tree. This patch however changed the handling of the free_mem_region() error path by reusing the struct

Re: [RFC 4/4] ASoC: RX-51: Add DT support to sound driver

2013-11-30 Thread Jarkko Nikula
Hi On 11/06/2013 04:32 PM, Pavel Machek wrote: Hi! This patch adds device tree support to the Nokia N900 audio driver. Note, N900 audio driver. +- compatible: nokia,rx51-audio Still, it is rx51-audio. If it is feasible, could we move away from rx51 naming and into n900 naming that

Re: [PATCH 2/8] mmc: omap: Fix DMA configuration to not rely on device id

2013-11-28 Thread Jarkko Nikula
Hi On 11/27/2013 11:59 PM, Tony Lindgren wrote: * Chris Ball c...@laptop.org [131127 13:48]: Hi, On Wed, Nov 27 2013, Jarkko Nikula wrote: Can you enlighten me what's the proper way to get patches to mmc since I cannot figure out working methodology from MAINTAINERS file? Sorry about

Re: [PATCH 2/8] mmc: omap: Fix DMA configuration to not rely on device id

2013-11-28 Thread Jarkko Nikula
Hi On 11/27/2013 11:37 PM, Tony Lindgren wrote: * Jarkko Nikula jarkko.nik...@bitmer.com [131127 12:55]: Bummer, sounds like some duplicate work could have been avoided :( I suggest resend to Chris and linux-mmc one more time as Chris should pick up the MMC patches in general. Before

Re: [PATCH] ARM: dts: omap3-beagle: Add omap-twl4030 audio support

2013-11-28 Thread Jarkko Nikula
On 11/28/2013 12:02 AM, Tony Lindgren wrote: * Jarkko Nikula jarkko.nik...@bitmer.com [131127 10:48]: This adds typical McBSP2-TWL4030 audio description to the legacy Beagle Board. Nice to see that work almost out of the box :) BTW, I just noticed that sound/soc/omap/Kconfig has depends

[PATCH] ARM: dts: omap3-beagle: Add omap-twl4030 audio support

2013-11-27 Thread Jarkko Nikula
This adds typical McBSP2-TWL4030 audio description to the legacy Beagle Board. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/boot/dts/omap3-beagle.dts | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts

Re: [PATCH 2/8] mmc: omap: Fix DMA configuration to not rely on device id

2013-11-27 Thread Jarkko Nikula
Hi Chris On Tue, 26 Nov 2013 18:33:50 -0500 Chris Ball c...@laptop.org wrote: Hi Tony, On Mon, Nov 18 2013, Tony Lindgren wrote: We are wrongly relying on device id for the DMA configuration which can lead to wrong DMA channel being selected. Fix the issue by using the standard

Re: [RFC 16/23] ASoC: omap: mcbsp, mcpdm, dmic: raw read and write endian fix

2013-11-16 Thread Jarkko Nikula
by looking at the _relaxed definitions in arch/arm/include/asm/io.h. Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 1/6] ASoC: omap: simplify platform_get_resource_byname/devm_ioremap_resource

2013-08-19 Thread Jarkko Nikula
deletions(-) To the patch and catch of missing clock release in omap-dmic.c in case of failing devm_ioremap_resource: Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 3/8] ARM: OMAP2+: hwmod: Remove remaining DMA channel definitions

2013-06-16 Thread Jarkko Nikula
Hi Felipe On 06/15/2013 06:06 PM, Felipe Balbi wrote: On Sat, Jun 15, 2013 at 11:31:04AM +0300, Jarkko Nikula wrote: Last remaining DMA channel definitions in arch/arm/mach-omap2/dma.h are used only by omap_hwmod_2xxx_3xxx_ipblock_data.c and omap_hwmod_3xxx_data.c. Remove them by using

[PATCH 1/8] ARM: OMAP2+: Remove AES crypto device DMA channel definitions

2013-06-15 Thread Jarkko Nikula
These became unused after commit 660ffd6 (ARM: OMAP2xxx: hwmod: Convert AES crypto devcie data to hwmod). Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/mach-omap2/dma.h |2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/mach-omap2/dma.h b/arch/arm/mach-omap2

[PATCH 0/8] ARM: OMAP: dma.h and legacy code removal

2013-06-15 Thread Jarkko Nikula
with omap1_defconfig and omap2plus_defconfig. Jarkko Nikula (8): ARM: OMAP2+: Remove AES crypto device DMA channel definitions ARM: OMAP2+: Remove duplicated DMA channel definitions ARM: OMAP2+: hwmod: Remove remaining DMA channel definitions ARM: OMAP2+: Remove dma.h ARM: OMAP1: Remove McBSP

[PATCH 2/8] ARM: OMAP2+: Remove duplicated DMA channel definitions

2013-06-15 Thread Jarkko Nikula
\ if [ `git grep -c $i |wc -l` -gt 1 ]; then \ echo removing $i; \ sed -i /${i}/d arch/arm/mach-omap2/dma.h; \ fi; \ done Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/mach-omap2/dma.h | 12 1

[PATCH 3/8] ARM: OMAP2+: hwmod: Remove remaining DMA channel definitions

2013-06-15 Thread Jarkko Nikula
-i /${DEF}/d arch/arm/mach-omap2/dma.h; \ done Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com Cc: Paul Walmsley p...@pwsan.com --- arch/arm/mach-omap2/dma.h | 19 --- .../mach-omap2/omap_hwmod_2xxx_3xxx_ipblock_data.c | 20

[PATCH 4/8] ARM: OMAP2+: Remove dma.h

2013-06-15 Thread Jarkko Nikula
All definitions in arch/arm/mach-omap2/dma.h are removed so it can be removed now. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/mach-omap2/devices.c |1 - arch/arm/mach-omap2/dma.h | 28 .../mach-omap2

[PATCH 6/8] ARM: OMAP1: Remove duplicated DMA channel definitions

2013-06-15 Thread Jarkko Nikula
/arm/mach-omap1/devices.c; \ sed -i /${DDEF}/d arch/arm/mach-omap1/dma.h; \ fi; \ done Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/mach-omap1/devices.c |9 - arch/arm/mach-omap1/dma.h |8 2 files

[PATCH 5/8] ARM: OMAP1: Remove McBSP DMA channel definitions

2013-06-15 Thread Jarkko Nikula
}/${CH}/ arch/arm/mach-omap1/mcbsp.c; \ sed -i /${DEF}/d arch/arm/mach-omap1/dma.h; \ done Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/mach-omap1/dma.h |6 -- arch/arm/mach-omap1/mcbsp.c | 33 - 2 files changed

[PATCH 8/8] ARM: OMAP1: Remove dma.h

2013-06-15 Thread Jarkko Nikula
Add definitions in arch/arm/mach-omap1/dma.h are now removed so remove the file and include statements from dma.c and lcd_dma.c. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/mach-omap1/dma.c |2 -- arch/arm/mach-omap1/dma.h | 26

[PATCH 7/8] ARM: OMAP1: Remove legacy irda.h and irda setup from board files

2013-06-15 Thread Jarkko Nikula
arch/arm/mach-omap1/include/mach/irda.h and unused OMAP_DMA_UART3_* definitions from dma.h. Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/mach-omap1/board-h2.c | 36 --- arch/arm/mach-omap1/board-palmte.c | 31

Re: [PATCH] ASoC: OMAP: Remove obsolete Makefile line

2013-05-30 Thread Jarkko Nikula
/Makefile | 1 - 1 file changed, 1 deletion(-) True, commit 91d94af (omap: Remove support for omap2evm) removed only omap2evm.o. Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

[RFC 1/2] ARM: OMAP1: Remove unused DMA channel definitions

2013-03-13 Thread Jarkko Nikula
; \ done Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/mach-omap1/dma.h | 41 - 1 file changed, 41 deletions(-) diff --git a/arch/arm/mach-omap1/dma.h b/arch/arm/mach-omap1/dma.h index da6345d..d05909c 100644 --- a/arch/arm/mach

[RFC 2/2] ARM: OMAP2+: Remove unused DMA channel definitions

2013-03-13 Thread Jarkko Nikula
; \ done Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com --- arch/arm/mach-omap2/dma.h | 70 - 1 file changed, 70 deletions(-) diff --git a/arch/arm/mach-omap2/dma.h b/arch/arm/mach-omap2/dma.h index eba80db..65f80ca 100644 --- a/arch/arm

Re: [PATCH V2 1/2] ARM: dts: OMAP2+: Add SDMA Audio IPs bindings

2013-03-11 Thread Jarkko Nikula
On 03/11/2013 04:19 PM, Peter Ujfalusi wrote: On 03/11/2013 08:50 AM, Sebastien Guiriec wrote: Populate DMA client information for McBSP DMIC and McPDM periperhal on OMAP2+ devices. Looks good to me: Reviewed-by: Peter Ujfalusi peter.ujfal...@ti.com Reviewed-by: Jarkko Nikula jarkko.nik

Re: [PATCH V2 2/2] ASoC: OMAP2+: Move McBSP, DMIC and McPDM to generic DMA DT binding

2013-03-11 Thread Jarkko Nikula
-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] omap: convert to devm_ioremap_resource()

2013-03-11 Thread Jarkko Nikula
be removed from the failure code paths. Signed-off-by: Silviu-Mihai Popescu silviupopescu1...@gmail.com --- sound/soc/omap/omap-dmic.c |9 +++-- sound/soc/omap/omap-mcpdm.c |8 +++- 2 files changed, 6 insertions(+), 11 deletions(-) Acked-by: Jarkko Nikula jarkko.nik

Re: [PATCH 0/5] ASoC: OMAP2+: Update Audio IP with sDMA binding for DT boot

2013-03-07 Thread Jarkko Nikula
On Thu, 7 Mar 2013 14:03:31 +0100 Peter Ujfalusi peter.ujfal...@ti.com wrote: Hi Sebastien, On 03/07/2013 01:43 PM, Sebastien Guiriec wrote: This patch serie is converting OMAP Audio IPs in order to use OMAP sDMA DT binding in case of DT boot on OMAP2+ platforms. The content of the

Re: [PATCH] ASoC: omap: Check regulator enable for DAC on Pandora

2013-03-03 Thread Jarkko Nikula
of this machine driver uses if (ret 0) or if (ret). I would use: +if (ret) { ... Otherwise: Acked-by: Peter Ujfalusi peter.ujfal...@ti.com To whatever version of (ret != 0), (ret) or (ret 0) is used :-) Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list

Re: [PATCH] spi: spi-omap2-mcspi.c: fix coding style

2013-01-24 Thread Jarkko Nikula
is not terribly wrong I personally favor smaller style fixes when those lines are changing anyway. In case maintainer takes this you could add: Reviewed-by: Jarkko Nikula jarkko.nik...@bitmer.com -- Jarkko -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH 3/3] spi: spi-omap2-mcspi.c: Toggle CS after each word

2013-01-23 Thread Jarkko Nikula
Hi On Wed, 23 Jan 2013 19:08:49 +0100 Matthias Brugger matthias@gmail.com wrote: @@ -1020,7 +1038,7 @@ static void omap2_mcspi_work(struct omap2_mcspi *mcspi, struct spi_message *m) } static int omap2_mcspi_transfer_one_message(struct spi_master *master, -

Re: McBSP functions not exported

2013-01-15 Thread Jarkko Nikula
Hi On Tue, 15 Jan 2013 17:43:54 + Paul Barker p...@paulbarker.me.uk wrote: I'm going to go back to using kernel 3.2 and check that this actually works with the McBSP. If it does, how much hassle is it to export the required symbols in more recent kernels? I'll happily write the patch,

Re: [PATCH_v2] watchdog: Convert twl4030_wdt to watchdog core

2012-12-13 Thread Jarkko Nikula
Hi On 12/14/2012 03:28 AM, Sebastian Reichel wrote: Hi, On Thu, Sep 27, 2012 at 11:23:12PM +0200, Wim Van Sebroeck wrote: On 09/11/2012 09:01 AM, Jarkko Nikula wrote: Convert the twl4030_wdt watchdog driver to watchdog core. While at there use devm_kzalloc and set the default timeout

Re: [PATCH 2/5] ASoC: OMAP: mcbsp fixes for enabling ARM multiplatform support

2012-11-22 Thread Jarkko Nikula
On Wed, 21 Nov 2012 09:42:25 -0800 Tony Lindgren t...@atomide.com wrote: We cannot include any plat or mach headers for the multiplatform support. Fix the issue by defining local mcbsp_omap1(). cc: Peter Ujfalusi peter.ujfal...@ti.com cc: Jarkko Nikula jarkko.nik...@bitmer.com cc: Liam

Re: [PATCH 1/2] ARM: OMAP: Trivial driver changes to remove include plat/cpu.h

2012-10-09 Thread Jarkko Nikula
for omap1 and omap2+. Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH_v2] watchdog: Convert twl4030_wdt to watchdog core

2012-09-27 Thread Jarkko Nikula
Hi On 09/11/2012 09:01 AM, Jarkko Nikula wrote: Convert the twl4030_wdt watchdog driver to watchdog core. While at there use devm_kzalloc and set the default timeout in order to be able test this driver with a simple shell script. Signed-off-by: Jarkko Nikulajarkko.nik...@jollamobile.com

Re: [PATCH 2/2] arm: omap: sram: skip the first 16K on OMAP3 HS

2012-09-26 Thread Jarkko Nikula
Hi Aaro On Thu, 30 Aug 2012 13:40:30 -0700 Tony Lindgren t...@atomide.com wrote: * Shilimkar, Santosh santosh.shilim...@ti.com [120829 08:30]: On Wed, Aug 29, 2012 at 8:24 AM, Aaro Koskinen aaro.koski...@iki.fi wrote: In some OMAP3 HS devices (at least Nokia N9 and N950), the public SRAM

Re: [PATCH] Revert spi: omap2-mcspi: convert to module_platform_driver

2012-09-21 Thread Jarkko Nikula
functions of SPI devices? (Initializing the controller driver at subsys_initcall is one way to accomplish this.) As the N900 framebuffer still appears to be broken would it make sense to queue above change as a workaround for 3.5 and 3.6? Aaro: For above change you could add my 'Tested-by: Jarkko

[PATCH_v2] watchdog: Convert twl4030_wdt to watchdog core

2012-09-11 Thread Jarkko Nikula
Convert the twl4030_wdt watchdog driver to watchdog core. While at there use devm_kzalloc and set the default timeout in order to be able test this driver with a simple shell script. Signed-off-by: Jarkko Nikula jarkko.nik...@jollamobile.com Tested-by: Aaro Koskinen aaro.koski...@iki.fi --- v2

Re: [PATCH v2] watchdog: omap_wdt: convert to new watchdog core

2012-09-10 Thread Jarkko Nikula
as device was probably accessed with some clocks off. Thanks to Jarkko Nikula jarkko.nik...@bitmer.com for reporting this. drivers/watchdog/Kconfig|1 + drivers/watchdog/omap_wdt.c | 266 ++- 2 files changed, 114 insertions(+), 153 deletions

[PATCH] watchdog: Convert twl4030_wdt to watchdog core

2012-09-10 Thread Jarkko Nikula
Convert the twl4030_wdt watchdog driver to watchdog core. While at there use devm_kzalloc and set the default timeout in order to be able test this driver with a simple shell script. Signed-off-by: Jarkko Nikula jarkko.nik...@jollamobile.com --- drivers/watchdog/Kconfig |1 + drivers

Re: [PATCH] watchdog: Convert twl4030_wdt to watchdog core

2012-09-10 Thread Jarkko Nikula
Thanks Aaro! On 09/11/2012 12:59 AM, Aaro Koskinen wrote: On Mon, Sep 10, 2012 at 06:44:46PM +0300, Jarkko Nikula wrote: Convert the twl4030_wdt watchdog driver to watchdog core. While at there use devm_kzalloc and set the default timeout in order to be able test this driver with a simple

Re: [PATCH] watchdog: omap_wdt: convert to new watchdog core

2012-09-07 Thread Jarkko Nikula
Hi On Tue, Sep 04, 2012 at 05:41:24PM +0300, Aaro Koskinen wrote: Convert omap_wdt to new watchdog core. On OMAP boards, there are usually multiple watchdogs. Since the new watchdog core supports multiple watchdogs, all watchdog drivers used on OMAP should be converted. The legacy watchdog

Re: [PATCH] watchdog: omap_wdt: convert to new watchdog core

2012-09-07 Thread Jarkko Nikula
On Fri, Sep 07, 2012 at 06:51:43PM +0300, Aaro Koskinen wrote: Thanks for the report! I'll look into this and test with other Nokia boards. I tested the patch only with N800 and v3.6-rc4 (4cbe5a555fa58a79b6ecbb6c531b8bab0650778d) and did not see any issues with normal use cases (boot,

Re: [PATCH] omap-mcbsp: properly check for availablity of mcbsp mux settings

2012-08-20 Thread Jarkko Nikula
Hi On 08/19/2012 10:14 PM, Andreas Kemnade wrote: The code did return -EINVAl when the mux_signal function pointer is available. If not, the corresponding function (the NULL pointer) is called. This patch inverts that logic. Signed-off-by: Andreas Kemnade andr...@kemnade.info --- Thanks

Re: [PATCH 4/9] sound/soc/omap/am3517evm.c: fix error return code

2012-08-20 Thread Jarkko Nikula
) { printk(KERN_ERR can't set CPU system clock OMAP_MCBSP_FSR_SRC_FSX\n); Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v3 2/9] ARM: OMAP: mcbsp: Enable FIFO use for OMAP2430

2012-08-17 Thread Jarkko Nikula
On 08/17/2012 04:07 PM, Tony Lindgren wrote: * Peter Ujfalusi peter.ujfal...@ti.com [120816 06:41]: On OMAP2430 all McBSP ports have 128 word long buffer, enable the use of the FIFO for the audio stack. Is this the case also for 2420? I thought some only had a FIFO at one port? IRCC (I

Re: [alsa-devel] [PATCH 08/11] ARM: OMAP3: Remove callback for McBSP sidetone ICLK workaround

2012-08-10 Thread Jarkko Nikula
Hi Peter On 08/08/2012 05:00 PM, Peter Ujfalusi wrote: Are you sure it works without any changes to sidetone audio quality or current consumption? What I remember idlemode was broken at least on 3430 and caused bad sidetone audio if autoidle was set and a little bit higher current consumption

Re: [PATCH 00/11] ARM/ASoC: OMAP McBSP device tree support

2012-08-10 Thread Jarkko Nikula
perhaps should go near 11/11?) and apply 7-8/11 (sidetone patches that increase consumption) later? My ack to patches 1, 3-6 and 9-10: Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 08/11] ARM: OMAP3: Remove callback for McBSP sidetone ICLK workaround

2012-08-08 Thread Jarkko Nikula
On 08/08/2012 12:11 PM, Peter Ujfalusi wrote: We can achieve the same result with SIDLEMODE field within McBSP SYSCONFIG register. The ASoC driver has been modified to use this method and we can now remove the workaround using the control module register. Are you sure it works without any

Re: Please help! AM35xx mm/slab.c BUG

2012-06-06 Thread Jarkko Nikula
my 2 cents. On 06/06/2012 11:41 AM, Tony Lindgren wrote: * CF Adad cfa...@rocketmail.com [120606 00:55]: Do you folks know of a good reference for properly calculating these GPMC settings? In theory you just need to know the timings of connected components, then check which ones depend

Re: [PATCH v2] omap: dma: Clear status registers on enable/disable irq.

2012-06-01 Thread Jarkko Nikula
by using mmc and audio Tested-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Compile err when enable CONFIG_SND_OMAP_SOC_OMAP_HDMI

2012-05-31 Thread Jarkko Nikula
On 05/31/2012 09:31 AM, Tomi Valkeinen wrote: It's true that there's a commit range where the asoc stuff doesn't compile, and I agree that it's not good. But you need to explicitly enable the HDMI ASOC support to get the error. You can still hit the build breakage by randconfig or if it's

Re: Compile err when enable CONFIG_SND_OMAP_SOC_OMAP_HDMI

2012-05-31 Thread Jarkko Nikula
On 05/31/2012 10:00 AM, Tomi Valkeinen wrote: One simple - wait for next merge window. It's not that long. Only ~3 months and meanwhile one could keep boss/customer/wife/whatever satisfied by carrying patches in own tree :-) Well... I'm not sure how serious you are here =). Quite serious

Re: Compile err when enable CONFIG_SND_OMAP_SOC_OMAP_HDMI

2012-05-30 Thread Jarkko Nikula
On 05/31/2012 02:35 AM, Ricardo Neri wrote: Build breaks because there some patches [1] that are still missing in Linus' tree. ASoC HDMI audio driver for OMAP[2] now uses the new DSS audio functionality in [1], but ASoC patches were merged first. DSS patches have been accepted and they are

Re: [PATCH] omap: dma: Clear status registers on enable/disable irq.

2012-05-06 Thread Jarkko Nikula
, able to actually listen to the audio, not only watch the IRQ counters rising up ;-). Ok from omap3 Tested-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v2] ASoC: omap-pcm: Free dma buffers in case of error.

2012-04-25 Thread Jarkko Nikula
insertions(+), 0 deletions(-) Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] omap1: mux: add missing include

2012-04-02 Thread Jarkko Nikula
-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/5] ARM: OMAP2+: clean up some cppcheck warnings

2012-03-13 Thread Jarkko Nikula
On 03/13/2012 12:43 AM, Paul Walmsley wrote: Resolve some warnings identified by cppcheck in arch/arm/mach-omap2: ... [arch/arm/mach-omap2/mcbsp.c:133]: (warning) scanf without field width limits can crash with huge input data ... diff --git a/arch/arm/mach-omap2/mcbsp.c

Re: [PATCH v2 2/3] ARM/ASoC: OMAP McBSP: Move remainig defines from arch to ASoC header

2012-03-08 Thread Jarkko Nikula
On 03/08/2012 11:29 AM, Peter Ujfalusi wrote: Hi Jarkko, On 03/08/2012 11:22 AM, Peter Ujfalusi wrote: Clock signal muxing, and functional clock related defines are only needed in ASoC drivers. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com Acked-by: Jarkko Nikula jarkko.nik

Re: [PATCH v2 00/10] OMAP/ASoC: Move and merge McBSP driver under ASoC

2012-02-28 Thread Jarkko Nikula
ack for the series. I'm sending a minor comment to 1/10 but here's ack to whole series Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH v2 01/10] ARM: OMAP: mcbsp: Convert core driver to proper platform driver

2012-02-28 Thread Jarkko Nikula
On 02/28/2012 09:40 AM, Peter Ujfalusi wrote: --- a/arch/arm/plat-omap/mcbsp.c +++ b/arch/arm/plat-omap/mcbsp.c @@ -1354,8 +1354,9 @@ static struct platform_driver omap_mcbsp_driver = { }, }; -int __init omap_mcbsp_init(void) -{ - /* Register the McBSP driver */ - return

Re: [PATCH] ASoC: pandora: switch clock back to internal on stop

2012-02-21 Thread Jarkko Nikula
On 02/20/2012 11:52 AM, Peter Ujfalusi wrote: I have patch on top of the mcbsp merge series which allows users (developers) to switch between McBSP2 master/slave configuration on Beagle. It will have two PCM: 0 is the current configuration (twl4030 master, mcbsp2 slave) 1 is the same as with

Re: [RFC 00/11]O MAP/ASoC: Move and merge McBSP driver under ASoC

2012-02-15 Thread Jarkko Nikula
On 02/15/2012 05:56 PM, Ujfalusi, Peter wrote: Hi, CC-ing Janusz, since he is the only one I know who have, and use OMAP1 with audio... Janusz: if your time allows would you be able to test this series on OMAP1 (it compiles...)? Yeah, it would be shame to break omap1, especially

Re: [PATCH] ASoC: Fix build error in sound/soc/omap/n810.c

2012-02-10 Thread Jarkko Nikula
[2]: *** [sound/soc/omap] Error 2 make[1]: *** [sound/soc] Error 2 make: *** [sound] Error 2 Signed-off-by: Axel Lin axel@gmail.com --- sound/soc/omap/n810.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Acked-by: Jarkko Nikula jarkko.nik...@bitmer.com -- To unsubscribe

Re: OMAP34xx

2012-02-08 Thread Jarkko Nikula
On 02/09/2012 02:47 AM, Greg KH wrote: Show me an OMAP user that actually runs a mainline kernel :) I guess pretty much all these days? Most error reports what I recall seeing during past 2-3 years are from mainline kernel and not that much from linux-omap or some board support package kernel.

Re: ASoC related suspend problems on OMAP3

2012-02-07 Thread Jarkko Nikula
On 02/08/2012 02:34 AM, Grazvydas Ignotas wrote: Hi, On OMAP3 pandora, system suspend stops working properly after using audio at least once: (just after boot): # echo mem /sys/power/state [ 12.578186] PM: Entering mem sleep [ 12.678802] PM: suspend of devices complete after 92.834

Re: [alsa-devel] It looks like snd-soc-rx51 only works as built-in, not as a module

2011-12-30 Thread Jarkko Nikula
On 12/30/2011 12:52 PM, Mark Brown wrote: On Thu, Dec 29, 2011 at 10:22:31PM +, M?ns Rullg?rd wrote: Mark Brownbroo...@opensource.wolfsonmicro.com writes: The reason the driver is not loaded automatically is that the OMAP machine drivers have not been converted to platform devices. I

  1   2   3   4   5   6   7   >