Re: [PATCH RFC v4 4/8] drm/i2c: tda998x: Add support of a DT graph of ports

2015-09-24 Thread Jean-Francois Moine
On Mon, 21 Sep 2015 10:19:18 -0500 Rob Herring <r...@kernel.org> wrote: > On 09/18/2015 06:06 AM, Jyri Sarha wrote: > > From: Jean-Francois Moine <moin...@free.fr> > > > > Two kinds of ports may be declared in a DT graph of ports: video and audio. > >

Re: [PATCH RFC 0/3] Make ti,tilcdc,slave DT binding more sensible

2015-01-13 Thread Jean-Francois Moine
On Tue, 13 Jan 2015 19:12:25 +0200 Jyri Sarha jsa...@ti.com wrote: These patches are needed for Beaglebone-back HDMI audio. There is no direct dependency between these patches and the other (dts and ASoC) changes needed for the HDMI audio so these changes can be merged independently. I also

Re: [alsa-devel] [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-14 Thread Jean-Francois Moine
On Thu, 13 Nov 2014 17:44:38 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: [snip] a) Always keep the audio device operational, no matter what is the status of the video side. How should this work if the HDMI videomode or the HDMI monitor does not support audio? Is it desirable

Re: [alsa-devel] [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-13 Thread Jean-Francois Moine
On Thu, 13 Nov 2014 10:05:28 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: [snip] I don't have much knowledge of the asoc architecture, so I probably can't comment much on the sound/ side design. For me the most important things are that 1) it works 2) I can easily unload/load the

Re: [alsa-devel] [PATCH v7.1 00/19] Rework OMAP4+ HDMI audio support

2014-11-13 Thread Jean-Francois Moine
On Thu, 13 Nov 2014 12:00:41 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: [snip] Jyri or Peter knows this better, but I think one difference with OMAP HDMI case and tda998x is that tda998x is an external encoder, and you transfer audio data to it via i2s or spdif, whereas OMAP

Re: [PATCH v3 4/5] ASoC: davinci: HDMI audio build for AM33XX and TDA998x

2014-09-18 Thread Jean-Francois Moine
On Thu, 18 Sep 2014 00:13:09 +0300 Jyri Sarha jsa...@ti.com wrote: So, Jean-Francois is also trying to do things with the TDA998x - what's the story with that, is this joined up at all? Not really. This basic functionality does not touch tda998x at all on the fly, but just sets i2s

Re: [PATCH RFC v3 0/2] Move dai-link level properties away from dai subnodes

2014-03-26 Thread Jean-Francois Moine
On Mon, 24 Mar 2014 12:15:23 +0200 Jyri Sarha jsa...@ti.com wrote: This patch is implemented on top of late patches from Jean-Francois Moine [1]. These patches implement the main part of the simple-card changes discussed in alsa-devel mailing list [2]. Acked-by: Jean-Francois Moine moin

Re: [PATCH RFC 2/2] ASoC: simple-card: Move dai-link level properties away from dai subnodes

2014-03-23 Thread Jean-Francois Moine
; The np reference count is updated in of_get_next_child(), so: if (ret 0) { of_node_put(np); return ret; } Otherwise, it works for me. Tested-by: Jean-Francois Moine moin...@free.fr

Re: [alsa-devel] [PATCH RFC v3 0/8] Beaglebone-Black HDMI audio

2014-01-30 Thread Jean-Francois Moine
On Thu, 30 Jan 2014 14:20:56 +0200 Jyri Sarha jsa...@ti.com wrote: I am having trouble getting the tda998x-codec working on BBB. The problem is I do not have a DT node for the tda998x driver. Instead I have tilcdc-slave node that provides pdata for the tda-driver. I am thinking of solving

Re: [alsa-devel] [PATCH RFC v3 0/8] Beaglebone-Black HDMI audio

2014-01-28 Thread Jean-Francois Moine
On Mon, 27 Jan 2014 21:31:59 +0200 Jyri Sarha jsa...@ti.com wrote: I would suggest to leave the CTS_N_K to the current setting (3), unless we can change the CTS_N_K on the fly according to the used sample format. Yes, this is possible: - the tda998x codec may call the tda998x hdmi in the

Re: [alsa-devel] [PATCH RFC v3 0/8] Beaglebone-Black HDMI audio

2014-01-27 Thread Jean-Francois Moine
On Mon, 27 Jan 2014 18:17:54 +0200 Jyri Sarha jsa...@ti.com wrote: Support for S16_LE could maybe be added if the tda998x specific codec would fiddle with CTS_N predivider-setting (K select) according to the used sample width. But it appears Cobox plays all the sample formats fine without

Re: [alsa-devel] [PATCH RFC v2 REPOST 3/8] ASoC: davinci-evm: HDMI audio support for TDA998x trough McASP I2S bus

2014-01-24 Thread Jean-Francois Moine
/soc/codecs/tda998x.c /* * ALSA SoC TDA998X driver * * This driver is used by the NXP TDA998x HDMI transmitter. * * Copyright (C) 2014 Jean-Francois Moine * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2

Re: [alsa-devel] [PATCH RFC v2 REPOST 3/8] ASoC: davinci-evm: HDMI audio support for TDA998x trough McASP I2S bus

2014-01-22 Thread Jean-Francois Moine
On Wed, 22 Jan 2014 11:20:32 +0200 Jyri Sarha jsa...@ti.com wrote: On 01/15/2014 05:51 PM, Jean-Francois Moine wrote: On Wed, 15 Jan 2014 13:27:21 +0200 Jyri Sarha jsa...@ti.com wrote: From driver/gpu/drm/i2c/tda998x_drv.c. The driver configures CTS_N register statically to a value

Re: [alsa-devel] [PATCH RFC v2 REPOST 3/8] ASoC: davinci-evm: HDMI audio support for TDA998x trough McASP I2S bus

2014-01-22 Thread Jean-Francois Moine
On Wed, 22 Jan 2014 11:19:53 +0100 Jean-Francois Moine moin...@free.fr wrote: As both I2S and S/PDIF may be used for HDMI output in the Cubox, I wrote a tda998x CODEC which gets the audio ports from the DT and dynamically sets these ports and the audio type (i2s / spdif) on audio streaming

Re: [alsa-devel] [PATCH RFC v2 REPOST 3/8] ASoC: davinci-evm: HDMI audio support for TDA998x trough McASP I2S bus

2014-01-15 Thread Jean-Francois Moine
On Wed, 15 Jan 2014 13:27:21 +0200 Jyri Sarha jsa...@ti.com wrote: From driver/gpu/drm/i2c/tda998x_drv.c. The driver configures CTS_N register statically to a value that works only with 4 byte samples. According to my tests it is possible to support 3 and 2 byte samples too by changing

Re: [PATCH RFC 4/9] ASoC: hdmi-codec: Add devicetree binding with documentation

2013-11-20 Thread Jean-Francois Moine
On Tue, 19 Nov 2013 14:12:24 +0200 Jyri Sarha jsa...@ti.com wrote: Signed-off-by: Jyri Sarha jsa...@ti.com --- Documentation/devicetree/bindings/sound/hdmi.txt | 17 + sound/soc/codecs/hdmi.c | 10 ++ 2 files changed, 27 insertions(+)

Re: [PATCH RFC 4/9] ASoC: hdmi-codec: Add devicetree binding with documentation

2013-11-20 Thread Jean-Francois Moine
On Wed, 20 Nov 2013 10:09:59 + Mark Brown broo...@kernel.org wrote: On Wed, Nov 20, 2013 at 10:23:42AM +0100, Jean-Francois Moine wrote: But now, I am wondering again about these `empty`codecs: - in a DT context, should we continue to add / modify such codecs? - what do you think

Re: [PATCH 1/4] drm/tilcdc: add TI LCD Controller DRM driver (v3)

2013-01-23 Thread Jean-Francois Moine
Hi Rob, As I wanted to re-use your nxp-tda998x driver for the Marvell Dove SoC, I had a look at your IT LCD driver. Comments below. On Tue, 22 Jan 2013 16:36:22 -0600 Rob Clark robdcl...@gmail.com wrote: A simple DRM/KMS driver for the TI LCD Controller found in various smaller TI parts

Re: [PATCH 2/4] drm/i2c: nxp-tda998x (v2)

2013-01-23 Thread Jean-Francois Moine
On Tue, 22 Jan 2013 16:36:23 -0600 Rob Clark robdcl...@gmail.com wrote: Driver for the NXP TDA998X i2c hdmi encoder slave. v1: original v2: fix npix/nline programming Signed-off-by: Rob Clark robdcl...@gmail.com --- drivers/gpu/drm/i2c/Makefile | 3 +