Re: [PATCH v5 0/3] dra7xx: Add PM support to PCIe

2015-08-06 Thread Jingoo Han
i-dra7xx: Disable pm_runtime on get_sync failure > PCI: host: pci-dra7xx: add pm support to pci dra7xx > PCI: host: pci-dra7xx: Idle the module by disabling MSE bit Hi Kishon, Looks good! :-) Reviewed-by: Jingoo Han Best regards, Jingoo Han > > drivers/pci/host/pci-dra7x

Re: [PATCH v3] PCI: kill off set_irq_flags usage

2015-07-27 Thread Jingoo Han
gt; Acked-by: Bjorn Helgaas > Cc: Murali Karicheri > Cc: Thierry Reding > Cc: Stephen Warren > Cc: Alexandre Courbot > Cc: Jingoo Han Acked-by: Jingoo Han Best regards, Jingoo Han > Cc: Pratyush Anand > Cc: Simon Horman > Cc: Michal Simek > Cc: "Söre

Re: [PATCH v2 09/13] PCI: kill off set_irq_flags usage

2015-07-12 Thread Jingoo Han
aham I > Acked-by: Bjorn Helgaas > Cc: Murali Karicheri > Cc: Thierry Reding > Cc: Stephen Warren > Cc: Alexandre Courbot > Cc: Jingoo Han For pcie-designware.c, Acked-by: Jingoo Han I checked that "the irqdomain core code handles clearing and setting IRQ_NOREQUEST already&

Re: [PATCH 2/3] PCI: host: pcie-designware: add support for suspend and resume

2015-07-12 Thread Jingoo Han
h to 'pci-dra7xx.c'. I don't want to include chip-specific codes, because 'pcie-designware.c' is designed for including common codes. Best regards, Jingoo Han > Controller Master Standby Behavior advises to use the clearing > of the local MSE bit to set the master in st

Re: [PATCH v2 1/3] usb: dwc3: add ST dwc3 glue layer to manage dwc3 HC

2014-07-07 Thread Jingoo Han
ve(struct platform_device *pdev) > +{ > + struct st_dwc3 *dwc3_data = platform_get_drvdata(pdev); > + > + platform_device_unregister(dwc3_data->dwc3); > + > + return 0; > +} > + > +#ifdef CONFIG_PM_SLEEP > +static int st_dwc3_suspend(struct device *dev)

Re: [PATCH v2 03/18] PCI: designware: Configuration space should be specified in 'reg'

2014-06-18 Thread Jingoo Han
t; >>> however it should be specified in *reg* making it a platform MEM resource. > >>> Hence used 'platform_get_resource_*' API to get configuration address > >>> space in the designware driver. > >>> > >>> Cc: Jason Gunthorpe > &g

Re: [PATCH v2 16/18] ARM: OMAP: Enable PCI for DRA7

2014-05-28 Thread Jingoo Han
ig option was already removed in v3.12 by the commit ebd97be635 ('PCI: remove ARCH_SUPPORTS_MSI kconfig option'). So, there is NO need to select 'ARCH_SUPPORTS_MSI'. Best regards, Jingoo Han > > config ARCH_OMAP2PLUS > bool > -- > 1.7.9.5 -- To unsubscribe from this l

Re: [RFC PATCH 08/16] mtd: nand: omap: Fix build warning

2014-05-21 Thread Jingoo Han
tch was already sent by Christian Engelmayer. [1] Also, it was applied to mtd tree by Brian Norris. [2] Thank you. [1] http://lists.infradead.org/pipermail/linux-mtd/2014-April/053330.html [2] http://git.infradead.org/users/dedekind/l2-mtd.git/commit/9fd6c6c18c1a4a3220473c76fd447c5708b5ecf9 Best

Re: [PATCH] backlight: gpio-backlight: Fix warning when the GPIO is on a I2C chip

2014-05-12 Thread Jingoo Han
ff-by: Tony Lindgren (+cc Linus Walleij, Alexandre Courbot, Russell King) Hi Lee Jones, Would you apply this patch into backlight git tree? If you have other opinions, please let us know. :-) Thank you. Acked-by: Jingoo Han Best regards, Jingoo Han > > --- a/drivers/video/backlight/gpi

Re: [PATCH 06/17] pci: host: pcie-designware: Use *base-mask* for configuring the iATU

2014-05-11 Thread Jingoo Han
On Friday, May 09, 2014 8:50 PM, Kishon Vijay Abraham I wrote: > On Thursday 08 May 2014 02:48 PM, Arnd Bergmann wrote: > > On Thursday 08 May 2014 18:05:11 Jingoo Han wrote: > >> On Tuesday, May 06, 2014 10:59 PM, Arnd Bergmann wrote: > >>> On Tuesday 06 May 2014 1

Re: [PATCH] backlight: gpio-backlight: Fix warning when the GPIO is on a I2C chip

2014-05-08 Thread Jingoo Han
On Friday, May 09, 2014 12:09 PM, Tony Lindgren wrote: > On Friday, May 09, 2014 11:25 AM, Jingoo Han wrote: > > On Friday, May 09, 2014 10:25 AM, Lee Jones wrote: > > > > > > If the GPIO for the backlight is on an I2C chip, we currently > > > get nast

Re: [PATCH] backlight: gpio-backlight: Fix warning when the GPIO is on a I2C chip

2014-05-08 Thread Jingoo Han
; value. How about the following? - gpio_set_value(gbl->gpio, brightness ? gbl->active : !gbl->active); + if (gpio_cansleep(gbl->gpio)) + gpio_set_value_cansleep(gbl->gpio, + brightness ? gbl->active : !gbl->active); + else +

Re: [PATCH 06/17] pci: host: pcie-designware: Use *base-mask* for configuring the iATU

2014-05-08 Thread Jingoo Han
tbound translation window the *base* should be programmed as > > 0x000_. > > Whenever we try to write to say 0x2000_, it will be translated to > > whatever > > we have programmed in the translation window with base as 0x000_. > > > > Cc: Bjorn Helg

Re: [PATCH 05/17] pci: host: pcie-dra7xx: add support for pcie-dra7xx controller

2014-05-08 Thread Jingoo Han
/* non-prefetchable memory */ 0xc200 0 0xa800 0xa800 0 0x1800>; /* prefetchable memory */ ... ./drivers/pci/host/pci-tegra.c /* request configuration space, but remap later, on demand */ res = platform_get_resource_byna

Re: [PATCH] fbdev: omap2: Fix format string mismatch in display-sysfs.c

2014-04-28 Thread Jingoo Han
device_attribute *attr, char *buf) { struct omap_dss_device *dssdev = to_dss_device_sysfs(dev); - int rotate; + u8 rotate; if (!dssdev->driver->get_rotate) return -ENOENT; rotate = dssdev->driver->get_rotate(dssdev); Best rega

Re: [PATCH 1/3] usb: ohci-exynos: Make provision for vdd regulators

2014-04-23 Thread Jingoo Han
On Thursday, April 24, 2014 3:40 PM, Vivek Gautam wrote: > On Thu, Apr 24, 2014 at 6:56 AM, Jingoo Han wrote: > > On Thursday, April 24, 2014 9:33 AM, Jingoo Han wrote: > >> On Thursday, April 24, 2014 9:18 AM, Anton Tikhomirov wrote: > >> > On Monday, April 21, 20

Re: [PATCH 1/3] usb: ohci-exynos: Make provision for vdd regulators

2014-04-23 Thread Jingoo Han
On Thursday, April 24, 2014 9:33 AM, Jingoo Han wrote: > On Thursday, April 24, 2014 9:18 AM, Anton Tikhomirov wrote: > > On Monday, April 21, 2014 9:17 PM, Vivek Gautam wrote: > > > > > > Facilitate getting required 3.3V and 1.0V VDD supply for > > > OHCI co

Re: [PATCH 1/3] usb: ohci-exynos: Make provision for vdd regulators

2014-04-23 Thread Jingoo Han
; + > > + exynos_ohci->vdd10 = devm_regulator_get(&pdev->dev, "vdd10"); > > + if (IS_ERR(exynos_ohci->vdd10)) { > > + err = PTR_ERR(exynos_ohci->vdd10); > > + goto fail_regulator2; > > + } > > + err = regulator_

Re: [PATCH 2/3] usb: ehci-exynos: Make provision for vdd regulators

2014-04-23 Thread Jingoo Han
ts: add max77686 pmic node for smdk5250, > > certain perripherals will now need to ensure that, > they request VDD regulators in their drivers, and enable > them so as to make them working. > > Signed-off-by: Vivek Gautam > Cc: Jingoo Han Acked-by: Jingoo Han Best reg

Re: [PATCH 1/3] usb: ohci-exynos: Make provision for vdd regulators

2014-04-23 Thread Jingoo Han
ts: add max77686 pmic node for smdk5250, > > certain perripherals will now need to ensure that, > they request VDD regulators in their drivers, and enable > them so as to make them working. > > Signed-off-by: Vivek Gautam > Cc: Jingoo Han Acked-by: Jingoo Han Best reg

Re: [PATCH 3/3] usb: dwc3-exynos: Make provision for vdd regulators

2014-04-23 Thread Jingoo Han
esn't provide it, dwc3-exynos driver probe > >> shouldn't > >> > fail here. > >> > >> These are the VDD regulators (from PMIC ldo supplies), in absence of > >> which the controller will not be powered up. > >> So doesn't it mak

Re: [RFC PATCH 03/12] pci: host: pcie-designware: Use *base-mask* for configuring the iATU

2014-03-27 Thread Jingoo Han
o write to say 0x2000_, it will be translated to whatever > we have programmed in the translation window with base as 0x000_. > > Signed-off-by: Kishon Vijay Abraham I (+cc Pratyush Anand, Marek Vasut, Richard Zhu) Acked-by: Jingoo Han Mohit Kumar, Pratyush Anand, If you

Re: [RFC PATCH 02/12] pci: host: pcie-dra7xx: add support for pcie-dra7xx controller

2014-03-26 Thread Jingoo Han
break; > + case DRA7XX_PCIE_LEG_EP_TYPE: > + dra7xx_pcie_writel(dra7xx->base, > + PCIECTRL_TI_CONF_DEVICE_TYPE, DEVICE_TYPE_LEG_EP); > + break; > + default: > + dev_dbg(dev, "UNKNOWN device type %d\n"

Re: [PATCH 2/4] power_supply: Introduce generic psy charging driver

2014-02-12 Thread Jingoo Han
battery and charger properties */ ^ 'one space' is necessary between '/*' and 'cache'. This can be fixed as below. + /* cache battery and charger properties */ Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-28 Thread Jingoo Han
0ma (0x01 << 7) #define BQ24261_ICHRG_1600MA (0x01 << 7) #define BQ24261_ICHRG_1600mA (0x01 << 7) Best regards, Jingoo Han > > > +u16 bq24261_iterm[][2] = { > > > + {0, 0x00} > > > + , > > > + {50, BQ24261_

RE: [PATCH 1/4] power_supply: Add inlmt,iterm, min/max temp props

2014-01-23 Thread Jingoo Han
2bbfa24387ac7493ffa7ce01c6fae7e800 Please remove this 'Change-Id' from the commit message. Best regards, Jingoo Han > Signed-off-by: Jenny TC > --- > Documentation/power/power_supply_class.txt |6 ++ > drivers/power/power_supply_sysfs.c |4 >

Re: [PATCH 4/4] power_supply: bq24261 charger driver

2014-01-23 Thread Jingoo Han
On Thursday, January 23, 2014 2:20 AM, Jenny TC wrote: > > This patch introduces BQ24261 charger driver. The driver makes use of power > supply charging driver to setup charging. So the driver does hardware > abstraction and handles h/w specific corner cases. The charging logic resides > with powe

Re: [PATCH] OMAPDSS: Add missing dependency on backlight for DSI-CM panel drier

2013-09-25 Thread Jingoo Han
On Wednesday, September 25, 2013 8:31 PM, Mark Brown wrote: > > From: Mark Brown > > The DSI-CM driver uses the backlight class so needs to build depend on it. > > Signed-off-by: Mark Brown Reviewed-by: Jingoo Han I checked that the following build errors are removed. d

Re: [PATCH] usb: dwc3: Remove additional delay of 100ms when resuming

2013-09-22 Thread Jingoo Han
_soft_reset() was > meant to assist USB2PHY and USB3PHY reset, not for usb_phy_init() > sequence. > > We should get rid of this delay, since things will still work > fine without this. > > Signed-off-by: Vivek Gautam Reviewed-by: Jingoo Han OK, I see. There is no reason t

Re: [PATCH v9 1/8] drivers: phy: add generic PHY framework

2013-06-27 Thread Jingoo Han
t and the documentation for dt binding can be found at > Documentation/devicetree/bindings/phy/phy-bindings.txt > > Signed-off-by: Kishon Vijay Abraham I > Tested-by: Sylwester Nawrocki Tested-by: Jingoo Han It looks great to me! I tested this General PHY framework with Exynos525

Re: [RFC 33/42] drivers/video/omap2: don't check resource with devm_ioremap_resource

2013-05-10 Thread Jingoo Han
On Friday, May 10, 2013 5:17 PM, Wolfram Sang wrote: > > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang Reviewed-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/vide

Re: [RFC 34/42] drivers/video/omap2/dss: don't check resource with devm_ioremap_resource

2013-05-10 Thread Jingoo Han
On Friday, May 10, 2013 5:17 PM, Wolfram Sang wrote: > > devm_ioremap_resource does sanity checks on the given resource. No need to > duplicate this in the driver. > > Signed-off-by: Wolfram Sang It looks good. Reviewed-by: Jingoo Han Best regards, Jingoo Han > --- >

Re: [RFC 09/42] drivers/i2c/busses: don't check resource with devm_ioremap_resource

2013-05-10 Thread Jingoo Han
5 - For drivers/i2c/busses/i2c-s3c2410.c Reviewed-by: Jingoo Han Best regards, Jingoo Han > drivers/i2c/busses/i2c-sirf.c |6 -- > drivers/i2c/busses/i2c-tegra.c |5 - > 8 files changed, 5 insertions(+), 42 deletions(-) > >

Re: [PATCH 14/24] USB: ohci: merge ohci_finish_controller_resume with ohci_resume

2012-10-04 Thread Jingoo Han
used to set > themselves the bit HCD_FLAG_HW_ACCESSIBLE, which is now handled by > ohci_resume(). > > Signed-off-by: Florian Fainelli For drivers/usb/host/ohci-exynos.c, it looks good. Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/usb/host/ohci-at91.c |

Re: [PATCH 0/6] OMAPDSS: remove cpu_is_* calls

2012-10-03 Thread Jingoo Han
not preferable in driver. Actually, I thought so, when I saw the OMAPDSS driver a few months ago. Anyway, it looks good. :) Best regards, Jingoo Han > > After these, omapdss no longer contains any plat/ or mach/ includes. omapfb, > vrfb and vram still do, though. > > Tomi > &g

RE: [PATCH] OMAPDSS: HDMI: Discard phy_tx_enabled member

2012-06-17 Thread Jingoo Han
Mythri P K' as the author for OMAP HDMI. Hi Jassi, long time no see. This patch looks good. If there is no problem, checking register is better way. Best regards, Jingoo Han. > > Signed-off-by: Jassi Brar > --- > drivers/video/omap2/dss/ti_hdmi.h |1 - > dri

Re: [PATCH] backlight: initialize struct backlight_properties properly

2012-05-21 Thread Jingoo Han
On Mon, May 21, 2012 at 04:25 PM +, Corentin Chary wrote: > > In all these files, the .power field was never correctly initialized. > > Signed-off-by: Corentin Chary It looks good. Best regards, Jingoo Han > --- > drivers/gpu/drm/i915/intel_panel.c |

RE: [GIT PULL] OMAP DSS fixes for 3.3-rc

2012-02-28 Thread Jingoo Han
en I wrote the HDMI PHY fix > > > (c49d005b6cc8491fad5b24f82805be2d6bcbd3dd). > > > > Merged. You would add > > Cc: sta...@vger.kernel.org > > to patches if appropriate? > > Thanks. Yes, I have sent a separate mail to stable list, as the patches > needed some tunin

RE: [GIT PULL] OMAP DSS fixes for 3.3-rc

2012-02-28 Thread Jingoo Han
Hi. > -Original Message- > From: linux-fbdev-ow...@vger.kernel.org > [mailto:linux-fbdev-ow...@vger.kernel.org] On Behalf Of Florian > Tobias Schandinat > Sent: Wednesday, February 29, 2012 1:03 AM > To: Tomi Valkeinen > Cc: linux-fb...@vger.kernel.org; linux-omap mailing list > Subject: R