Re: [PATCH 0/5] staging: tidspbridge: for 3.9

2013-01-20 Thread Omar Ramirez Luna
Hi Greg, On Thu, Jan 17, 2013 at 6:47 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Jan 10, 2013 at 03:36:57AM -0600, Omar Ramirez Luna wrote: Patches for staging-next, fixing comments and suggestions provided by Chen Gang. There is an additional scm patch, that removes

Re: [PATCH 0/5] staging: tidspbridge: for 3.9

2013-01-20 Thread Omar Ramirez Luna
Hi Tony, On Thu, Jan 17, 2013 at 8:01 PM, Tony Lindgren t...@atomide.com wrote: * Greg Kroah-Hartman gre...@linuxfoundation.org [130117 16:51]: On Thu, Jan 10, 2013 at 03:36:57AM -0600, Omar Ramirez Luna wrote: Patches for staging-next, fixing comments and suggestions provided by Chen Gang

Re: [PATCH 0/5] staging: tidspbridge: for 3.9

2013-01-20 Thread Omar Ramirez Luna
On Sun, Jan 20, 2013 at 5:51 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: That looks good, care to update the TODO file for the driver in the kernel to reflect this? I'll update it. Cheers, Omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of

Re: [PATCH 1/9] mailbox: OMAP: introduce mailbox framework

2013-01-11 Thread Omar Ramirez Luna
On Wed, Jan 9, 2013 at 6:29 AM, Loic PALLARDY loic.palla...@st.com wrote: Hi Vaibhav, On 01/09/2013 01:11 PM, Bedia, Vaibhav wrote: Hi Loic, On Fri, Dec 21, 2012 at 16:23:24, Loic PALLARDY wrote: On 12/21/2012 11:49 AM, Bedia, Vaibhav wrote: On Fri, Dec 21, 2012 at 14:24:26, Loic

[PATCH 0/5] staging: tidspbridge: for 3.9

2013-01-10 Thread Omar Ramirez Luna
Patches for staging-next, fixing comments and suggestions provided by Chen Gang. There is an additional scm patch, that removes hardcoded defines related to direct register handling for SCM, it was dependent on changes that already made it to mainline. Omar Ramirez Luna (5): staging

[PATCH 1/5] staging: tidspbridge: fix potential array out of bounds write

2013-01-10 Thread Omar Ramirez Luna
, because the driver expects the NULL ending to be among the 255 char limit. Reported-by: Chen Gang gang.c...@asianux.com Signed-off-by: Omar Ramirez Luna omar.rami...@copitl.com --- drivers/staging/tidspbridge/rmgr/proc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 2/5] staging: tidspbridge: fix memory corruption on long string names

2013-01-10 Thread Omar Ramirez Luna
The value allocated doesn't match the one that is meant to be stored, resulting in corruption of memory for longer strings that can't be held in such space. Fix by allocating the correct byte value for the string meant to be stored. Signed-off-by: Omar Ramirez Luna omar.rami...@copitl.com

[PATCH 3/5] staging: tidspbridge: fix uninitialized variable sym_name

2013-01-10 Thread Omar Ramirez Luna
On both counts, sym_name could be printed uninitialized, this is solved by moving the pr_* statement to be triggered if the value is assigned. Reported-by: Chen Gang gang.c...@asianux.com Signed-off-by: Omar Ramirez Luna omar.rami...@copitl.com --- drivers/staging/tidspbridge/rmgr/nldr.c |6

[PATCH 4/5] staging: tidspbridge: use scm functions to set boot address and mode

2013-01-10 Thread Omar Ramirez Luna
Instead of ioremapping SCM registers, use the correspondent layer to write into them. This allows us to get rid of a layer violation, since the registers are no longer touched by driver code. Signed-off-by: Omar Ramirez Luna omar.rami...@copitl.com --- drivers/staging/tidspbridge/core

[PATCH 5/5] staging: tidspbridge: remove unused code to handle iva_img

2013-01-10 Thread Omar Ramirez Luna
There is no way to specify the value of iva_img and since this code is not being used, remove it. This analysis resulted from a report by Chen Gang gang.c...@asianux.com, mentioning that the existing code was wrongly specifying the size to be copied. Signed-off-by: Omar Ramirez Luna omar.rami

Re: [PATCH 1/2] staging: tidspbridge: fix breakages due to CM reorganization

2013-01-07 Thread Omar Ramirez Luna
On Mon, Jan 7, 2013 at 5:03 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Mon, Dec 24, 2012 at 08:10:24AM -0600, Omar Ramirez Luna wrote: 3.8-rc1 introduced changes in the clock management header files, this resulted in compilation breakages for this driver. Define this locally

[PATCH 2/2] staging: tidspbridge: use prepare/unprepare on dsp clocks

2012-12-24 Thread Omar Ramirez Luna
in the correct order while handling clocks. Code path to enable/disable dsp clocks can still be reached from an atomic context, hence we can't use clk_prepare_enable and clk_disable_unprepare yet. Signed-off-by: Omar Ramirez Luna omar.rami...@copitl.com --- drivers/staging/tidspbridge/core/dsp-clock.c

[PATCH 1/2] staging: tidspbridge: fix breakages due to CM reorganization

2012-12-24 Thread Omar Ramirez Luna
: error: 'OMAP3430_CM_AUTOIDLE_PLL' undeclared (first use in this function) drivers/staging/tidspbridge/core/tiomap_io.c:416:13: error: 'OMAP3430_CM_CLKEN_PLL' undeclared (first use in this function) Reported-by: Chen Gang gang.c...@asianux.com Signed-off-by: Omar Ramirez Luna omar.rami

Re: [PATCH 0/9] drivers: mailbox: framework creation

2012-12-21 Thread Omar Ramirez Luna
Hi Loic/Ohad, On Fri, Dec 21, 2012 at 2:52 AM, Loic PALLARDY loic.palla...@st.com wrote: On 12/21/2012 08:31 AM, Ohad Ben-Cohen wrote: On Thu, Dec 20, 2012 at 9:19 PM, Olof Johanssono...@lixom.net wrote: While we can make the branch stable, would it make sense to make remoteproc for omap

[PATCH v5 2/5] iommu/omap: keep mmu enabled when requested

2012-11-19 Thread Omar Ramirez Luna
doesn't work if the module is not enabled first, but in future if the mmu is idled withouth freeing, these are needed to debug. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- drivers/iommu/omap-iommu.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH v5 3/5] iommu/omap: migrate to hwmod framework

2012-11-19 Thread Omar Ramirez Luna
device and resource data, handling of sysconfig register for softreset purposes, use default latency structure. - Use hwmod API for reset handling. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/devices.c|2 +- arch/arm/mach-omap2/omap-iommu.c

[PATCH v5 5/5] ARM: OMAP4: hwmod data: ipu and dsp to use parent clocks instead of leaf clocks

2012-11-19 Thread Omar Ramirez Luna
is to get rid of leaf clocks in future. So remove these two while at it. [1] http://lkml.org/lkml/2012/8/20/226 Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/clock44xx_data.c | 22 -- arch/arm/mach-omap2/omap_hwmod_44xx_data.c |4 ++-- 2

[PATCH v5 4/5] iommu/omap: adapt to runtime pm

2012-11-19 Thread Omar Ramirez Luna
through debugfs, some of them doesn't work if the module is not enabled first, but in future if the mmu is idled withouth freeing, these are needed to debug. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/omap-iommu.c |1 - drivers/iommu/omap-iommu.c

[PATCH v5 0/5] OMAP: iommu: hwmod, reset handling and runtime PM

2012-11-19 Thread Omar Ramirez Luna
/mach-omap2. Omar Ramirez Luna (5): iommu/omap: remove redundant clock handling on ISR iommu/omap: keep mmu enabled when requested iommu/omap: migrate to hwmod framework iommu/omap: adapt to runtime pm ARM: OMAP4: hwmod data: ipu and dsp to use parent clocks instead of leaf clocks

[PATCH v5 1/5] iommu/omap: remove redundant clock handling on ISR

2012-11-19 Thread Omar Ramirez Luna
context the handling of clocks inside the ISR doesn't seem to be needed nor helping. Next patch should also correct the dependency on clients to handle iommu clocks. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- drivers/iommu/omap-iommu.c |2 -- 1 files changed, 0 insertions(+), 2

Re: [PATCH] ARM: OMAP4: hwmod data: ipu and dsp to use parent clocks instead of leaf clocks

2012-11-15 Thread Omar Ramirez Luna
Hi, On 14 November 2012 09:44, Paul Walmsley p...@pwsan.com wrote: Hi On Tue, 13 Nov 2012, Omar Ramirez Luna wrote: This prevents hwmod _enable_clocks...omap2_dflt_clk_enable path from enabling modulemode inside CLKCTRL using its clk-enable_reg field. Instead is left

Re: [PATCH v4 2/2] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-11-15 Thread Omar Ramirez Luna
Hi Ohad, On 14 November 2012 03:54, Ohad Ben-Cohen o...@wizery.com wrote: Hi Omar, On Wed, Nov 14, 2012 at 4:34 AM, Omar Ramirez Luna omar.l...@linaro.org wrote: Use runtime PM functionality interfaced with hwmod enable/idle functions, to replace direct clock operations and sysconfig

Re: [PATCH v4 2/2] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-11-15 Thread Omar Ramirez Luna
On 15 November 2012 11:39, Ohad Ben-Cohen o...@wizery.com wrote: I do agree description is missing, again I thought I had done this somewhere but looks like I didn't, will update these. If you think these should be different patches please let me know, otherwise I would like to keep a single

Re: [PATCH 7/8] ARM: OMAP: Remove unnecessary inclusion of dmtimer.h

2012-11-15 Thread Omar Ramirez Luna
that this file needs to include dmtimer.h. Indeed, we don't use it here. Is it ok for this to go through Tony's tree? If so, care to ACK? Looks fine to me, but I believe you will want to let Greg know if this patch will bypass staging tree. Acked-by: Omar Ramirez Luna omar.l...@linaro.org

[PATCH v4 0/2] OMAP: iommu: hwmod, reset handling and runtime PM

2012-11-13 Thread Omar Ramirez Luna
/gmane.linux.kernel/1387788 Minor rebasing might be needed if these are included on top of linux-omap, since they are affected by changes on headers being moved to include/linux/platform_data and arch/arm/mach-omap2. Omar Ramirez Luna (2): ARM: OMAP3/4: iommu: migrate to hwmod framework ARM

[PATCH v4 1/2] ARM: OMAP3/4: iommu: migrate to hwmod framework

2012-11-13 Thread Omar Ramirez Luna
device and resource data, handling of sysconfig register for softreset purposes, use default latency structure. - Use hwmod API for reset handling. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/devices.c|2 +- arch/arm/mach-omap2/omap-iommu.c

[PATCH v4 2/2] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-11-13 Thread Omar Ramirez Luna
Use runtime PM functionality interfaced with hwmod enable/idle functions, to replace direct clock operations and sysconfig handling. Dues to reset sequence, pm_runtime_put_sync must be used, to avoid possible operations with the module under reset. Signed-off-by: Omar Ramirez Luna omar.l

[PATCH] ARM: OMAP4: hwmod data: ipu and dsp to use parent clocks instead of leaf clocks

2012-11-13 Thread Omar Ramirez Luna
is to get rid of leaf clocks in future. So remove these two while at it. [1] http://lkml.org/lkml/2012/8/20/226 Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/clock44xx_data.c | 22 -- arch/arm/mach-omap2/omap_hwmod_44xx_data.c |4 ++-- 2

Re: [PATCH v5 0/6] Move rest of omap-iommu to live in drivers/iommu

2012-11-12 Thread Omar Ramirez Luna
Hi, On 11 November 2012 03:39, Ohad Ben-Cohen o...@wizery.com wrote: On Fri, Nov 2, 2012 at 9:23 PM, Tony Lindgren t...@atomide.com wrote: We need to move the iommu code to live under drivers for arm common zImage support. For the iommu changes in the entire series: Acked-by: Ohad

Re: [PATCH v2 1/2] mailbox: OMAP: introduce mailbox framework

2012-11-06 Thread Omar Ramirez Luna
Hi Stephen, On 5 November 2012 21:40, Stephen Warren swar...@wwwdotorg.org wrote: On 11/05/2012 07:55 PM, Omar Ramirez Luna wrote: Actually moving it from plat-omap, as this framework/driver code is supposed to be under drivers/ folder. The framework should work with the current supported

Re: [PATCH v2 1/2] mailbox: OMAP: introduce mailbox framework

2012-11-06 Thread Omar Ramirez Luna
Hi Greg, On 6 November 2012 02:59, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Tue, Nov 06, 2012 at 09:55:52AM +0100, Linus Walleij wrote: On Tue, Nov 6, 2012 at 4:40 AM, Stephen Warren swar...@wwwdotorg.org wrote: Is this a public interface to the driver? If so, shouldn't the

Re: [PATCH v2 2/2] mailbox: split internal header from API header

2012-11-06 Thread Omar Ramirez Luna
Hi Loic, On 6 November 2012 06:53, Loic PALLARDY loic.palla...@st.com wrote: On 11/06/2012 03:55 AM, Omar Ramirez Luna wrote: Now internal structures can remain hidden to the user and just API related functions and defines are made available. Signed-off-by: Omar Ramirez Lunaomar.l

[PATCH v2 0/2] drivers: mailbox: omap-mailbox out of plat code

2012-11-05 Thread Omar Ramirez Luna
/mailbox and split internal structures from common API for others to use. Based on 3.7-rc4. 1. https://lkml.org/lkml/2012/10/31/123 Omar Ramirez Luna (2): mailbox: OMAP: introduce mailbox framework mailbox: split internal header from API header arch/arm/configs/omap1_defconfig |3

[PATCH v2 2/2] mailbox: split internal header from API header

2012-11-05 Thread Omar Ramirez Luna
Now internal structures can remain hidden to the user and just API related functions and defines are made available. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- drivers/mailbox/mailbox.c | 34 drivers/mailbox/mailbox.h | 48

Re: [PATCH 1/2] ARM: OMAP2+: move mailbox.h out of plat-omap headers

2012-10-31 Thread Omar Ramirez Luna
Hi Greg, On 30 October 2012 16:02, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: OK. Greg, do these patches look OK to you to move to live under drivers/mailbox? Um, I don't know, I wasn't paying attention here, sorry. As part of plat-omap code cleanup, I was planning to move

Re: [PATCH 1/2] ARM: OMAP2+: move mailbox.h out of plat-omap headers

2012-10-30 Thread Omar Ramirez Luna
Tony, On 29 October 2012 12:52, Tony Lindgren t...@atomide.com wrote: --- /dev/null +++ b/include/linux/platform_data/omap_mailbox.h @@ -0,0 +1,105 @@ This file should only contain pure platform data needed by the core omap code to pass to the mailbox driver. Ok, looking at it closely,

[PATCH 2/2] mailbox: OMAP: introduce mailbox framework

2012-10-29 Thread Omar Ramirez Luna
Actually moving it from plat-omap code as this is supposed to be under drivers/ folder. This framework should work with the current OMAP processors that have mailbox and can be used as a method of interprocessor communication. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm

[PATCH 1/2] ARM: OMAP2+: move mailbox.h out of plat-omap headers

2012-10-29 Thread Omar Ramirez Luna
CC: Greg Kroah-Hartman gre...@linuxfoundation.org CC: de...@driverdev.osuosl.org Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/mailbox.c |2 +- arch/arm/plat-omap/include/plat/mailbox.h | 105 arch/arm/plat

[PATCH 0/2] ARM: OMAP: mailbox out of plat code

2012-10-29 Thread Omar Ramirez Luna
From: Omar Ramirez Luna omar.rami...@copitl.com Move Mailbox's headers and driver out of platform code as per current plat-omap cleanup activities. While at it move mailbox code out of platform and to drivers/ folder, given that this is an OMAP specific framework, some people might frown upon

tidspbridge: ARM common zImage?

2012-10-29 Thread Omar Ramirez Luna
Hi, On 26 October 2012 13:00, Tony Lindgren t...@atomide.com wrote: ... I would also like to move the tidspbridge to the DMA API, but I think we'll need to move step by step there, and using the OMAP IOMMU and IOVMM APIs as an intermediate step would allow splitting patches in reviewable

Re: Beagleboard xM - play video file : BUG: scheduling while atomic: queue1:src/92/0x0000008e , then kernel panic

2012-10-24 Thread Omar Ramirez Luna
Hi, On Wed, Oct 24, 2012 at 10:34 AM, Felipe Contreras felipe.contre...@gmail.com wrote: Hi, Selso, hopefully you don't mind, but I'll forward this to the linux-omap mailing list, as this seems to be an interesting kernel problem in tidspbridge. Omar, any ideas? I don't see tidspbridge

Re: [PATCH v3 0/6] OMAP: iommu: hwmod, reset handling and runtime PM

2012-10-19 Thread Omar Ramirez Luna
Tony, On 18 October 2012 18:52, Tony Lindgren t...@atomide.com wrote: Thanks, the related patches are now posted in thread [PATCH v3 0/6] omap iommu changes to remove plat includes. Ok. Also, can you please take a look at the Updated status of the removal of plat headers thread? I've

Re: Updated status of the removal of plat headers

2012-10-19 Thread Omar Ramirez Luna
Hi, On 16 October 2012 18:00, Tony Lindgren t...@atomide.com wrote: Hi all, Here's a quick status update on the removal of remaining #include plat/*.h files. Most files are now fixed up, and we only have the following remaining: cpu.h wrapper only left, will be removed as soon as

Re: [PATCH 2/6] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-10-17 Thread Omar Ramirez Luna
On 15 October 2012 22:23, Felipe Contreras felipe.contre...@gmail.com wrote: On probe this patch does pm_runtime_enable, however this doesn't mean the device is turned ON or resumed or kept ON all the time. In fact it's the other way around; pm_runtime_enable turns off the power (if it's ON).

Re: [PATCH v3 0/6] OMAP: iommu: hwmod, reset handling and runtime PM

2012-10-17 Thread Omar Ramirez Luna
On 16 October 2012 12:22, Tony Lindgren t...@atomide.com wrote: * Omar Ramirez Luna omar.l...@linaro.org [121011 18:07]: These patches are needed for remoteproc to work on OMAP4. Introduced iommu hwmod support for OMAP3 (iva, isp) and OMAP4 (ipu, dsp), along with the corresponding runtime PM

Re: [PATCH 2/6] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-10-15 Thread Omar Ramirez Luna
Hi Felipe, On 12 October 2012 16:25, Felipe Contreras felipe.contre...@gmail.com wrote: @@ -142,11 +142,10 @@ static int iommu_enable(struct omap_iommu *obj) } } - clk_enable(obj-clk); + pm_runtime_get_sync(obj-dev); err =

Re: [PATCH 2/6] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-10-12 Thread Omar Ramirez Luna
On 12 October 2012 02:48, Felipe Contreras felipe.contre...@gmail.com wrote: I already made most of these comments, but here they go again. I replied to all, but here it goes again: @@ -142,11 +142,10 @@ static int iommu_enable(struct omap_iommu *obj) } } -

[PATCH v3 0/6] OMAP: iommu: hwmod, reset handling and runtime PM

2012-10-11 Thread Omar Ramirez Luna
://www.mail-archive.com/linux-omap@vger.kernel.org/msg75701.html [v1] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg70447.html [old iteration without reset, save/restore and device tree] http://www.mail-archive.com/linux-omap@vger.kernel.org/msg60133.html Omar Ramirez Luna (6): ARM

[PATCH v3 1/6] ARM: OMAP3/4: iommu: migrate to hwmod framework

2012-10-11 Thread Omar Ramirez Luna
device and resource data, handling of sysconfig register for softreset purposes, use default latency structure. - Use hwmod API for reset handling. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/devices.c |2 +- arch/arm/mach-omap2/iommu2.c

[PATCH 1/6] ARM: OMAP3/4: iommu: migrate to hwmod framework

2012-10-11 Thread Omar Ramirez Luna
device and resource data, handling of sysconfig register for softreset purposes, use default latency structure. - Use hwmod API for reset handling. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/devices.c |2 +- arch/arm/mach-omap2/iommu2.c

[PATCH v3 2/6] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-10-11 Thread Omar Ramirez Luna
Use runtime PM functionality interfaced with hwmod enable/idle functions, to replace direct clock operations and sysconfig handling. Dues to reset sequence, pm_runtime_put_sync must be used, to avoid possible operations with the module under reset. Signed-off-by: Omar Ramirez Luna omar.l

[PATCH 2/6] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-10-11 Thread Omar Ramirez Luna
Use runtime PM functionality interfaced with hwmod enable/idle functions, to replace direct clock operations and sysconfig handling. Dues to reset sequence, pm_runtime_put_sync must be used, to avoid possible operations with the module under reset. Signed-off-by: Omar Ramirez Luna omar.l

[PATCH v3 3/6] ARM: OMAP: iommu: pm runtime save and restore context

2012-10-11 Thread Omar Ramirez Luna
Save and restore context during pm runtime transitions. For now, the previous API for this purpose will trigger pm runtime functions, and will be left as exported symbol for compatibility with it's only user. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- drivers/iommu/omap-iommu.c

[PATCH 3/6] ARM: OMAP: iommu: pm runtime save and restore context

2012-10-11 Thread Omar Ramirez Luna
Save and restore context during pm runtime transitions. For now, the previous API for this purpose will trigger pm runtime functions, and will be left as exported symbol for compatibility with it's only user. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- drivers/iommu/omap-iommu.c

[PATCH v3 4/6] ARM: OMAP: iommu: optimize save and restore routines

2012-10-11 Thread Omar Ramirez Luna
to be saved but right now there is no API that can alter its value. Also, protected TLB entries must be saved but this can be in a separate patch as the original code didn't implement the loop to traverse protected TLB entries. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach

[PATCH v3 5/6] ARM: OMAP: iommu: add device tree support

2012-10-11 Thread Omar Ramirez Luna
Adapt driver to use DT if provided. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- .../devicetree/bindings/arm/omap/iommu.txt | 10 +++ arch/arm/mach-omap2/omap-iommu.c |4 ++ drivers/iommu/omap-iommu.c | 65

[PATCH 4/6] ARM: OMAP: iommu: optimize save and restore routines

2012-10-11 Thread Omar Ramirez Luna
to be saved but right now there is no API that can alter its value. Also, protected TLB entries must be saved but this can be in a separate patch as the original code didn't implement the loop to traverse protected TLB entries. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach

[PATCH v3 6/6] arm/dts: OMAP3/4: Add iommu nodes

2012-10-11 Thread Omar Ramirez Luna
Add nodes for iommu DT, to interface with hwmods. Cc: Grant Likely grant.lik...@secretlab.ca Cc: Rob Herring rob.herr...@calxeda.com Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/boot/dts/omap3.dtsi | 12 +++- arch/arm/boot/dts

Re: Issue with _are_all_hardreset_lines_asserted()

2012-10-09 Thread Omar Ramirez Luna
is idled first, the other one will cause L3 aborts given that the module is already disabled. So, if ipu is idled and disabled first, then all tear down operations on iommu will cause L3 aborts. I created the following: From: Omar Ramirez Luna omar.l...@linaro.org Subject: [PATCH] ARM: OMAP: hwmod: allow

Re: [PATCH v2 8/9] ARM: OMAP: iommu: add device tree support

2012-10-03 Thread Omar Ramirez Luna
Hi Matt, On 2 October 2012 16:25, Matt Porter mpor...@ti.com wrote: ... I can see why you went this path with the iommu driver as it already had some integration code present here. I have some concerns going forward about how this should be long-term. Take any platform booting only with DT

Re: [PATCH v2 0/2] OMAP: mailbox initial device tree support

2012-09-26 Thread Omar Ramirez Luna
Hi Benoit, On 12 September 2012 19:08, Omar Ramirez Luna omar.l...@linaro.org wrote: To allow mailbox driver to function with device tree. Tested in OMAP4 and OMAP3. OMAP2 untested. Patch: arm/dts: OMAP2+: Add mailbox nodes, was Acked by Benoit however it seems it wasn't picked up, so

Re: tidspbridge build fails

2012-09-25 Thread Omar Ramirez Luna
Hi, On Tue, Sep 25, 2012 at 12:39 PM, Selso LIBERADO s...@cioinfoindus.fr wrote: Hi ! Here what's happening when applying the patch : sli@SLI-V420:~/developpement/INTERNE/BEAGLEBOARD/logiciel/linux-omap$ git apply --check

Re: tidspbridge build fails

2012-09-24 Thread Omar Ramirez Luna
Hi, On Mon, Sep 24, 2012 at 11:37 AM, Selso LIBERADO s...@cioinfoindus.fr wrote: ... CC [M] drivers/staging/tidspbridge/core/tiomap3430.o drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_start': drivers/staging/tidspbridge/core/tiomap3430.c:421:25: error:

Re: [PATCH v2 7/9] ARM: OMAP: iommu: optimize save and restore routines

2012-09-18 Thread Omar Ramirez Luna
Hi Tony, On 18 September 2012 13:04, Tony Lindgren t...@atomide.com wrote: * Omar Ramirez Luna omar.l...@linaro.org [120912 12:47]: --- a/arch/arm/plat-omap/include/plat/iommu.h +++ b/arch/arm/plat-omap/include/plat/iommu.h @@ -27,6 +27,13 @@ struct iotlb_entry { }; }; +/* context

[PATCH v2 0/9] OMAP: iommu: hwmod, reset handling and runtime PM

2012-09-12 Thread Omar Ramirez Luna
-archive.com/linux-omap@vger.kernel.org/msg60133.html Omar Ramirez Luna (9): ARM: OMAP: iommu: fix including iommu.h without IOMMU_API selected ARM: OMAP3: hwmod data: add mmu data for iva and isp ARM: OMAP4: hwmod data: add mmu hwmod for ipu and dsp ARM: OMAP3/4: iommu: migrate to hwmod

[PATCH v2 8/9] ARM: OMAP: iommu: add device tree support

2012-09-12 Thread Omar Ramirez Luna
Adapt driver to use DT if provided. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- .../devicetree/bindings/arm/omap/iommu.txt | 10 +++ arch/arm/mach-omap2/omap-iommu.c |4 ++ drivers/iommu/omap-iommu.c | 65

[PATCH v2 9/9] arm/dts: OMAP3/4: Add iommu nodes

2012-09-12 Thread Omar Ramirez Luna
Add nodes for iommu DT, to interface with hwmods. Cc: Grant Likely grant.lik...@secretlab.ca Cc: Rob Herring rob.herr...@calxeda.com Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/boot/dts/omap3.dtsi | 12 +++- arch/arm/boot/dts

[PATCH v2 7/9] ARM: OMAP: iommu: optimize save and restore routines

2012-09-12 Thread Omar Ramirez Luna
to be saved but right now there is no API that can alter its value. Also, protected TLB entries must be saved but this can be in a separate patch as the original code didn't implement the loop to traverse protected TLB entries. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach

[PATCH v2 5/9] ARM: OMAP3/4: iommu: adapt to runtime pm

2012-09-12 Thread Omar Ramirez Luna
Use runtime PM functionality interfaced with hwmod enable/idle functions, to replace direct clock operations and sysconfig handling. Dues to reset sequence, pm_runtime_put_sync must be used, to avoid possible operations with the module under reset. Signed-off-by: Omar Ramirez Luna omar.l

[PATCH v2 4/9] ARM: OMAP3/4: iommu: migrate to hwmod framework

2012-09-12 Thread Omar Ramirez Luna
device and resource data, handling of sysconfig register for softreset purposes, use default latency structure. - Use hwmod API for reset handling. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/devices.c |2 +- arch/arm/mach-omap2/iommu2.c

[PATCH v2 1/9] ARM: OMAP: iommu: fix including iommu.h without IOMMU_API selected

2012-09-12 Thread Omar Ramirez Luna
includes iommu.h to get the structure for attributes. Also needed for tidspbridge incremental migration to use iommu code. Cc: Tony Lindgren t...@atomide.com Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/plat-omap/include/plat/iommu.h |2 ++ 1 file changed, 2 insertions

[PATCH v2 6/9] ARM: OMAP: iommu: pm runtime save and restore context

2012-09-12 Thread Omar Ramirez Luna
Save and restore context during pm runtime transitions. For now, the previous API for this purpose will trigger pm runtime functions, and will be left as exported symbol for compatibility with it's only user. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- drivers/iommu/omap-iommu.c

[PATCH v2 3/9] ARM: OMAP4: hwmod data: add mmu hwmod for ipu and dsp

2012-09-12 Thread Omar Ramirez Luna
Add mmu hwmod data for ipu and dsp. Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 136 +++- 1 file changed, 134 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2

[PATCH v2 2/9] ARM: OMAP3: hwmod data: add mmu data for iva and isp

2012-09-12 Thread Omar Ramirez Luna
be migrated to iommu framework. Cc: Benoit Cousson b-cous...@ti.com Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 121 arch/arm/plat-omap/include/plat/iommu.h| 13 +++ 2 files changed, 134 insertions

[PATCH v2 0/2] OMAP: mailbox initial device tree support

2012-09-12 Thread Omar Ramirez Luna
: mailbox: add device tree support, there wasn't an opposition other than to cleanup the driver too, however I got quite some patches to send before continuing the cleanup. http://www.mail-archive.com/linux-omap@vger.kernel.org/msg69338.html Omar Ramirez Luna (2): OMAP: mailbox: add device tree

[PATCH v2 0/2] OMAP: mailbox initial device tree support

2012-09-12 Thread Omar Ramirez Luna
: mailbox: add device tree support, there wasn't an opposition other than to cleanup the driver too, however I got quite some patches to send before continuing the cleanup. http://www.mail-archive.com/linux-omap@vger.kernel.org/msg69338.html Omar Ramirez Luna (2): OMAP: mailbox: add device tree

[PATCH v2 2/2] arm/dts: OMAP2+: Add mailbox nodes

2012-09-12 Thread Omar Ramirez Luna
Add nodes for mailbox DT, to interface with hwmods. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org Acked-by: Benoit Cousson b-cous...@ti.com --- arch/arm/boot/dts/omap2.dtsi |5 + arch/arm/boot/dts/omap3.dtsi |5 + arch/arm/boot/dts/omap4.dtsi |5 + 3 files changed

[PATCH v2 1/2] OMAP: mailbox: add device tree support

2012-09-12 Thread Omar Ramirez Luna
Adapt driver to use DT if provided. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- .../devicetree/bindings/arm/omap/mailbox.txt |9 + arch/arm/mach-omap2/devices.c |3 +++ arch/arm/mach-omap2/mailbox.c | 12

Re: [PATCH 2/2] ARM: OMAP: hwmod: revise deassert sequence

2012-09-10 Thread Omar Ramirez Luna
Hi Benoit, On 6 September 2012 10:12, Benoit Cousson b-cous...@ti.com wrote: The sequence is good, I'm just a little bit concern about the duplication of code compared to _enable sequence. That being said, this is the consequence of removing the hardreset sequence outside of the main

Re: [PATCH 0/2] OMAP: hwmod: fix hardreset handling

2012-09-03 Thread Omar Ramirez Luna
On 22 August 2012 00:42, Omar Ramirez Luna omar.l...@linaro.org wrote: From: Omar Ramirez Luna omar.rami...@ti.com The patch to expose hwmod assert/deassert functions through omap_device has been accepted and queued for 3.7[1], however these two patches are needed to make the API functional

Re: [PATCH 1/3] ARM: OMAP: hwmod: partially un-reset hwmods might not be properly enabled

2012-08-21 Thread Omar Ramirez Luna
On 20 August 2012 09:49, Benoit Cousson b-cous...@ti.com wrote: On 07/16/2012 09:21 PM, Omar Ramirez Luna wrote: Some IP blocks might not be using/controlling more than one reset line, this check loosens the restriction to fully use hwmod framework for those drivers. E.g.: ipu has reset

[PATCH 0/2] OMAP: hwmod: fix hardreset handling

2012-08-21 Thread Omar Ramirez Luna
From: Omar Ramirez Luna omar.rami...@ti.com The patch to expose hwmod assert/deassert functions through omap_device has been accepted and queued for 3.7[1], however these two patches are needed to make the API functional. Hence a revised version is being sent according to previous comments

[PATCH 2/2] ARM: OMAP: hwmod: revise deassert sequence

2012-08-21 Thread Omar Ramirez Luna
-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/omap_hwmod.c | 37 + 1 file changed, 37 insertions(+) diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index eaedc33..b65e021 100644 --- a/arch/arm/mach

[PATCH 1/2] ARM: OMAP: hwmod: partially un-reset hwmods might not be properly enabled

2012-08-21 Thread Omar Ramirez Luna
callbacks. c. Do its usecase. d. Disable hwmod through runtime PM. e. Assert the reset line. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/omap_hwmod.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/arch

Re: [PATCH 1/3] ARM: OMAP: hwmod: partially un-reset hwmods might not be properly enabled

2012-08-20 Thread Omar Ramirez Luna
Hi Benoit, On 20 August 2012 09:49, Benoit Cousson b-cous...@ti.com wrote: On 07/16/2012 09:21 PM, Omar Ramirez Luna wrote: Some IP blocks might not be using/controlling more than one reset line, this check loosens the restriction to fully use hwmod framework for those drivers. E.g.: ipu

Re: [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-08-20 Thread Omar Ramirez Luna
Hi Benoit, On 20 August 2012 05:21, Benoit Cousson b-cous...@ti.com wrote: Hi Omar, On 08/03/2012 05:52 PM, Omar Ramirez Luna wrote: On 3 August 2012 00:24, Vaibhav Hiremath hvaib...@ti.com wrote: On 8/3/2012 3:50 AM, Omar Ramirez Luna wrote: So in _enable: _enable_clocks(oh

Re: [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-08-03 Thread Omar Ramirez Luna
On 3 August 2012 00:24, Vaibhav Hiremath hvaib...@ti.com wrote: On 8/3/2012 3:50 AM, Omar Ramirez Luna wrote: So in _enable: _enable_clocks(oh); if (soc_ops.enable_module) soc_ops.enable_module(oh); The enable_module part seems redundant to me, since

Re: [PATCH 3/3] ARM: OMAP: omap_device: expose hwmod assert/deassert to omap devices

2012-08-02 Thread Omar Ramirez Luna
to control. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org This one has been queued for 3.7 with a few changes. Some more detail was added to the function documentationrovement. Also the multiple assignments were removed per Documentation/CodingStyle chapter 1: Don't put multiple

Re: [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-08-02 Thread Omar Ramirez Luna
Hi. On 2 August 2012 02:52, Paul Walmsley p...@pwsan.com wrote: On Mon, 16 Jul 2012, Omar Ramirez Luna wrote: For a reset sequence to complete cleanly, a module needs its associated clocks to be enabled, otherwise the timeout check in prcm code can print a false failure (failed to hardreset

Re: [PATCH 0/6] OMAP: iommu: hwmod, reset handling and runtime PM

2012-07-18 Thread Omar Ramirez Luna
On 17 July 2012 05:51, Ohad Ben-Cohen o...@wizery.com wrote: + Paul On Tue, Jul 17, 2012 at 1:11 PM, Joerg Roedel joerg.roe...@amd.com wrote: On Fri, Jun 15, 2012 at 08:55:58PM -0500, Omar Ramirez Luna wrote: Omar Ramirez Luna (6): ARM: OMAP: iommu: fix including iommu.h without IOMMU_API

[PATCH 1/3] ARM: OMAP: hwmod: partially un-reset hwmods might not be properly enabled

2012-07-16 Thread Omar Ramirez Luna
by hwmod code. While at it, prevent _omap4_module_disable if all the hardreset lines on an IP block are not under reset. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/omap_hwmod.c | 37 ++--- 1 files changed, 22 insertions(+), 15

[PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-07-16 Thread Omar Ramirez Luna
-off-by: Omar Ramirez Luna omar.l...@linaro.org --- arch/arm/mach-omap2/omap_hwmod.c | 33 + 1 files changed, 33 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c index 091c199..f6f8d99 100644 --- a/arch

[PATCH 3/3] ARM: OMAP: omap_device: expose hwmod assert/deassert to omap devices

2012-07-16 Thread Omar Ramirez Luna
This APIs are meant to be an interface to hwmod assert/deassert function, omap devices can call them through their platform data to control their reset lines, they are expected to know the name of the reset line they are trying to control. Signed-off-by: Omar Ramirez Luna omar.l...@linaro.org

Re: suspend broken on 3.5-rc1?

2012-07-12 Thread Omar Ramirez Luna
On 12 July 2012 00:27, Rajendra Nayak rna...@ti.com wrote: On Thursday 12 July 2012 05:28 AM, Omar Ramirez Luna wrote: I suspect this might be specific to 4460 as Rajendra reported it was working for him on 4430 but not on 4460, I haven't tried 4430 but let me see if I can find one. Yes

Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?

2012-07-11 Thread Omar Ramirez Luna
On 11 July 2012 12:07, Kevin Hilman khil...@ti.com wrote: ... [2.311004] omap_hsmmc omap_hsmmc.0: Failed to get debounce clk [2.317382] omap_hsmmc omap_hsmmc.0: unable to obtain RX DMA engine channel 62 [2.325256] omap_hsmmc omap_hsmmc.1: Failed to get debounce clk [2.331512]

Re: suspend broken on 3.5-rc1?

2012-07-11 Thread Omar Ramirez Luna
On 12 June 2012 07:01, Rajendra Nayak rna...@ti.com wrote: On Friday 08 June 2012 06:46 PM, Rajendra Nayak wrote: On Friday 08 June 2012 06:35 PM, Tero Kristo wrote: On Fri, 2012-06-08 at 17:55 +0530, Rajendra Nayak wrote: On Friday 08 June 2012 04:26 PM, Tony Lindgren wrote: * Rajendra

Re: suspend broken on 3.5-rc1?

2012-07-11 Thread Omar Ramirez Luna
Hi Kevin, On 11 July 2012 16:42, Kevin Hilman khil...@ti.com wrote: Omar Ramirez Luna omar.l...@linaro.org writes: On 12 June 2012 07:01, Rajendra Nayak rna...@ti.com wrote: [...] ..anyone knows of any more fixes going around? I'm seeing the same thing, it gets stuck trying to enable

Re: [PATCH 3/6] ARM: OMAP4: hwmod data: add mmu hwmod for ipu and dsp

2012-07-09 Thread Omar Ramirez Luna
Hi Paul, On 27 June 2012 20:27, Omar Ramirez Luna omar.l...@linaro.org wrote: On 19 June 2012 12:48, Cousson, Benoit b-cous...@ti.com wrote: On 6/19/2012 6:39 PM, Omar Ramirez Luna wrote: Hi Benoit, On 19 June 2012 07:36, Cousson, Benoit b-cous...@ti.com wrote: On 6/16/2012 3:56 AM, Omar

Re: [PATCH 0/3] OMAP: hwmod: reset API proposal

2012-06-27 Thread Omar Ramirez Luna
Hi Paul, On 15 June 2012 20:54, Omar Ramirez Luna omar.l...@linaro.org wrote: Recent changes in omap_hwmod framework have reworked the behaviour towards hardreset handling, commit 747834a (ARM: OMAP2+: hwmod: revise hardreset behavior) recommends for drivers to implement their own reset

Re: [PATCH 3/6] ARM: OMAP4: hwmod data: add mmu hwmod for ipu and dsp

2012-06-27 Thread Omar Ramirez Luna
+ Paul On 19 June 2012 12:48, Cousson, Benoit b-cous...@ti.com wrote: On 6/19/2012 6:39 PM, Omar Ramirez Luna wrote: Hi Benoit, On 19 June 2012 07:36, Cousson, Benoit b-cous...@ti.com wrote: On 6/16/2012 3:56 AM, Omar Ramirez Luna wrote: ... +static struct omap_hwmod

  1   2   3   4   5   6   7   >