Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery

2016-01-06 Thread Rob Herring
On Wed, Jan 6, 2016 at 8:36 AM, Nishanth Menon wrote: > On 01/06/2016 02:13 AM, Laxman Dewangan wrote: >> >> On Wednesday 06 January 2016 01:12 PM, H. Nikolaus Schaller wrote: >>> Hi, >>> >>> Am 06.01.2016 um 00:40 schrieb Nishanth Menon : >>> On 01/05/2016 06:01 AM, H. Nikolaus Schaller wrot

Re: [PATCH 2/2] pci: host: pci-dra7xx: Enable x2 mode support

2016-01-06 Thread Rob Herring
On Wed, Jan 06, 2016 at 04:19:53PM +0530, Kishon Vijay Abraham I wrote: > Perform syscon configurations to get x2 mode to working in DRA74x and > DRA72x. Also add a new compatible string to dfferentiate > DRA72x and DRA74x, since b1c0 mask is different for both these platforms. > > Signed-off-by:

Re: [PATCH 2/2] phy: ti-pipe3: configure usb3 phy to be used as pcie phy

2016-01-06 Thread Rob Herring
n/devicetree/bindings/phy/ti-phy.txt |2 ++ > drivers/phy/phy-ti-pipe3.c | 30 > +- > 2 files changed, 31 insertions(+), 1 deletion(-) Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe linux-omap&

Re: [PATCH 2/3] wlcore/wl12xx: spi: add device tree support

2015-12-30 Thread Rob Herring
core,spi.txt| 35 +++ For the binding: Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/3] devicetree/bindings: add reset-gpios and vcc-supply for panel-dpi

2015-12-30 Thread Rob Herring
On Wed, Dec 30, 2015 at 4:29 AM, Geert Uytterhoeven wrote: > On Tue, Dec 29, 2015 at 9:54 PM, Rob Herring wrote: >> On Sun, Dec 20, 2015 at 12:13:20PM +0100, Uwe Kleine-König wrote: >>> Some displays have a reset input and/or need a regulator to function >>> properly

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-29 Thread Rob Herring
On Tue, Dec 29, 2015 at 3:26 PM, Paul Kocialkowski wrote: > Le mardi 29 décembre 2015 à 14:02 -0600, Rob Herring a écrit : >> On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: >> > LP872x regulators are made active via the EN pin, which might be hooked to >

Re: [PATCH v2 1/3] devicetree/bindings: add reset-gpios and vcc-supply for panel-dpi

2015-12-29 Thread Rob Herring
plies? While there are limits to what can be described here, I'm okay with allowing these, so: Acked-by: Rob Herring Rob -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property

2015-12-29 Thread Rob Herring
> Documentation/devicetree/bindings/net/cpsw.txt | 4 ++-- For the binding: Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support

2015-12-29 Thread Rob Herring
On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > LP872x regulators are made active via the EN pin, which might be hooked to a > GPIO. This adds support for driving the GPIO high when the driver is in use. > > Signed-off-by: Paul Kocialkowski > --- > .../devicetree/bindings/re

Re: [PATCH 2/2] dt-bindings: bus: ti-gpmc: Add AAD timings properties

2015-12-29 Thread Rob Herring
changed, 5 insertions(+) Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] ti-st: use device handles and add device tree binding

2015-12-29 Thread Rob Herring
On Wed, Dec 23, 2015 at 11:38:29AM +, Reizer, Eyal wrote: > - Add support for getting the platform data which includes the uart > used and gpio pin used for enable from device tree. > > - Fix the implementation for using device handle for the uart and > gpiod for the enable pin, instead of

Re: [PATCH v3 2/3] wlcore/wl12xx: spi: add device tree support

2015-12-29 Thread Rob Herring
LE_DEVICE_TABLE. > Remove #ifdef CONFIG_OF. > Make the Kconfig symbol to depend on OF. > Replace irqd_get_trigger_type() with irq_get_trigger_type(). > > .../bindings/net/wireless/ti,wlcore,spi.txt | 34 In any case: Acked-by

Re: [PATCH v3 9/9] phy: omap-usb2: use *syscon* framework API to power on/off the PHY

2015-12-22 Thread Rob Herring
On Sun, Dec 20, 2015 at 6:07 AM, Kishon Vijay Abraham I wrote: > Hi Rob, > > On Sunday 20 December 2015 09:09 AM, Rob Herring wrote: >> On Tue, Dec 15, 2015 at 02:46:08PM +0530, Kishon Vijay Abraham I wrote: >>> Deprecate using phy-omap-control driver to power on/off the

Re: [PATCH v3 6/9] phy: ti-pipe3: use *syscon* framework API to power on/off the PHY

2015-12-19 Thread Rob Herring
/ti-phy.txt | 10 ++- > drivers/phy/phy-ti-pipe3.c | 90 > ++ > 2 files changed, 85 insertions(+), 15 deletions(-) For the binding: Acked-by: Rob Herring One comment on the driver though. [...] > --- a/drivers/phy/phy-ti-pipe3.c >

Re: [PATCH v3 7/9] phy: ti-pipe3: use *syscon* framework API to set PCS value of the PHY

2015-12-19 Thread Rob Herring
umentation/devicetree/bindings/phy/ti-phy.txt |2 ++ > drivers/phy/phy-ti-pipe3.c | 34 > +- > 2 files changed, 35 insertions(+), 1 deletion(-) Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe linux-omap&

Re: [PATCH v3 9/9] phy: omap-usb2: use *syscon* framework API to power on/off the PHY

2015-12-19 Thread Rob Herring
On Tue, Dec 15, 2015 at 02:46:08PM +0530, Kishon Vijay Abraham I wrote: > Deprecate using phy-omap-control driver to power on/off the PHY, > and use *syscon* framework to do the same. This handles > powering on/off the PHY for the USB2 PHYs used in various TI SoCs. > > Signed-off-by: Kishon Vijay

Re: [PATCH 2/5] ARM: dts: cm-t335: add support for SBC-T335

2015-12-13 Thread Rob Herring
Acked-by: Igor Grinberg Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/arm/omap/omap.txt | 3 +++ > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/am335x-sbc-t335.dts | 16 > 3 files changed, 20 inser

Re: [PATCH v5 4/5] ARM: dts: DRA7: add entry for qspi mmap region

2015-12-11 Thread Rob Herring
On Fri, Dec 11, 2015 at 09:39:59AM +0530, Vignesh R wrote: > Add qspi memory mapped region entries for DRA7xx based SoCs. Also, > update the binding documents for the controller to document this change. > > Signed-off-by: Vignesh R Acked-by: Rob Herring > --- > > v5: use

Re: [PATCH for 4.4 2/2] dmaengine: edma: DT: Change reserved slot array from 16bit to 32bit type

2015-12-09 Thread Rob Herring
s too should have info on why you are breaking compatibility. Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/dma/ti-edma.txt | 5 ++-- > drivers/dma/edma.c| 31 > ++- > 2 files changed, 27 insertions(+), 9 dele

Re: [PATCH for 4.4 1/2] dmaengine: edma: DT: Change memcpy channel array from 16bit to 32bit type

2015-12-09 Thread Rob Herring
On Wed, Dec 09, 2015 at 10:18:10AM +0200, Peter Ujfalusi wrote: > This change makes the DT file to be easier to read since the memcpy > channels array does not need the '/bits/ 16' to be specified, which might > confuse some people. Why? I don't see the point of this change and plus you are breaki

Re: [PATCH for 4.4 1/2] dmaengine: edma: DT: Change memcpy channel array from 16bit to 32bit type

2015-12-09 Thread Rob Herring
On Wed, Dec 09, 2015 at 02:02:00PM -0600, Rob Herring wrote: > On Wed, Dec 09, 2015 at 10:18:10AM +0200, Peter Ujfalusi wrote: > > This change makes the DT file to be easier to read since the memcpy > > channels array does not need the '/bits/ 16' to be specified, whi

Re: [PATCH V2 12/14] ARM: dts: sb-som: introduce SB-SOM baseboard

2015-12-03 Thread Rob Herring
gle board > computer, which consists of cm-t43 on top of sb-som-t43. > > Signed-off-by: Nikita Kiryanov > Cc: Tony Lindgren > Cc: Benoit Cousson > Cc: Rob Herring > Cc: Mark Rutland > Cc: Pawel Moll > Cc: Igor Grinberg > Cc: Dmitry Lifshitz > Cc: Ian Campbell

Re: [PATCH V3 01/19] ARM: dts: am57xx: cl-som-am57x: add basic module support

2015-12-02 Thread Rob Herring
uter-on-modules/cl-som-am57x-ti-am5728-am5718-system-on-module/ > > Add basic DT support for standalone module (without a carrier board): > > * Memory configuration > * Heartbeat led > * I2C1 and I2C4 > * PMIC > * SATA > > Signed-off-by: Dmitry Lifshitz &

Re: [PATCH V2 11/19] ARM: dts: am57xx: sbc-am57x: add basic board support

2015-12-02 Thread Rob Herring
-on-modules/cl-som-am57x-ti-am5728-am5718-system-on-module/ > > Add basic board support, including UART3, used as a serial console. > > Signed-off-by: Dmitry Lifshitz > Acked-by: Igor Grinberg Acked-by: Rob Herring > --- > > v2: > >* No fuctional changes

Re: [PATCH 01/18] ARM: am57xx: cl-som-am57x: dts: add basic module support

2015-11-30 Thread Rob Herring
On Sun, Nov 29, 2015 at 02:10:01PM +0200, Dmitry Lifshitz wrote: > Hi Nishanth, > > Thank you for the provided feedback. > > On 11/25/2015 11:36 PM, Nishanth Menon wrote: > >On 11/25/2015 12:39 AM, Dmitry Lifshitz wrote: > >[...] > > > >>diff --git a/arch/arm/boot/dts/am57xx-cl-som-am57x.dts > >

Re: [PATCH 01/14] ARM: am437x: cm-t43: dts: add basic support for sbc-t43

2015-11-25 Thread Rob Herring
> top of the SB-SOM-T43 baseboard. > Basic support includes UART, GPIO, and I2C. > > Signed-off-by: Nikita Kiryanov > Cc: Tony Lindgren > Cc: Igor Grinberg > Cc: Dmitry Lifshitz > Cc: Ian Campbell Some minor nits below, otherwise: Acked-by: Rob Herring > ---

Re: [PATCH 12/14] ARM: sb-som: dts: introduce SB-SOM baseboard

2015-11-25 Thread Rob Herring
On Tue, Nov 24, 2015 at 03:19:13PM +0200, Nikita Kiryanov wrote: > CompuLab SB-SOM baseboard is a carrier board for multiple arm-based SoMs. > It currently supports (with minor adjustments to assembly) CM-T43, CM-T54, > and CM-QS600 modules. It is a building block in the SBC-T43 single board > comp

Re: [PATCH v2 1/6] ARM: OMAP2+: dts: cm-t335: add initial support

2015-11-25 Thread Rob Herring
-off-by: Uri Mashiach > Acked-by: Igor Grinberg > --- > v1 -> v2: integrate AM33XX_IOPAD macro in pinmux definitions This macro is exactly the kind we should not be doing in DT files which are ones that expand to multiple cells. But not really much point in doing 1 board differently

Re: [PATCH 11/18] ARM: am57xx: sbc-am57x: dts: add basic board support

2015-11-25 Thread Rob Herring
-on-modules/cl-som-am57x-ti-am5728-am5718-system-on-module/ > > Add basic board support, including UART3, used as a serial console. > > Signed-off-by: Dmitry Lifshitz > Acked-by: Igor Grinberg Acked-by: Rob Herring > --- > .../devicetree/bindings/arm/omap/omap.tx

Re: [PATCH 01/18] ARM: am57xx: cl-som-am57x: dts: add basic module support

2015-11-25 Thread Rob Herring
uter-on-modules/cl-som-am57x-ti-am5728-am5718-system-on-module/ > > Add basic DT support for standalone module (without a carrier board): > > * Memory configuration > * Heartbeat led > * I2C1 bus > * PMIC > * SATA > > Signed-off-by: Dmitry Lifshitz &

Re: [PATCH v2 6/8] drivers:input:ads7846(+tsc2046): recognise old binding for coordinate flipping

2015-11-14 Thread Rob Herring
On Fri, Nov 13, 2015 at 2:35 PM, H. Nikolaus Schaller wrote: > By this patch we still recognise the old binding ti,swap-xy in parallel to > the common binding touchscreen-swapped-x-y. This keeps compatibility > to older (out-of-tree) device tree binaries. > > We do this in a separate patch so tha

Re: [PATCH v2 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2015-11-14 Thread Rob Herring
On Fri, Nov 13, 2015 at 09:35:52PM +0100, H. Nikolaus Schaller wrote: > commit b98abe52fa8e ("Input: add common DT binding for touchscreens") > introduced common DT bindings for touchscreens [1] and a helper function to > parse the DT. > > This has been integrated and interpretation of the inversi

Re: [PATCH v2] regulator: tps65217: remove tps65217.dtsi file

2015-11-12 Thread Rob Herring
On Tue, Oct 27, 2015 at 01:36:36PM +0100, Heiko Schocher wrote: > remove tps65217.dtsi and adapt all boards, which > used it. > > Signed-off-by: Heiko Schocher > Tested-by: Keerthy > Acked-by: Mark Brown Acked-by: Rob Herring > --- > Suggested by Mark Brown, see:

Re: [PATCH 1/7] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2015-11-09 Thread Rob Herring
On Fri, Nov 06, 2015 at 04:14:43PM +0100, H. Nikolaus Schaller wrote: > commit b98abe52fa8e ("Input: add common DT binding for touchscreens") > introduced common DT bindings for touchscreens [1] and a helper function to > parse the DT. > > This has been integrated and interpretation of the inversi

Re: [PATCH 5/7] drivers:input:ads7846(+tsc2046): add new common binding names, pre-calibration and flipping

2015-11-09 Thread Rob Herring
On Fri, Nov 06, 2015 at 04:14:47PM +0100, H. Nikolaus Schaller wrote: > commit b98abe52fa8e ("Input: add common DT binding for touchscreens") > introduced common DT bindings for touchscreens [1] and a helper function to > parse the DT. > > This has been integrated and interpretation of the inversi

Re: [PATCH v2 2/3] dmaengine: ti-dma-crossbar: dra7: Support for reserving DMA event ranges

2015-11-06 Thread Rob Herring
On Fri, Oct 30, 2015 at 10:00:37AM +0200, Peter Ujfalusi wrote: > In eDMA the events are directly mapped to a DMA channel (for example DMA > event 14 can only be handled by DMA channel 14). If the memcpy is enabled > on the eDMA, there is a possibility that the crossbar driver would assign > DMA ev

Re: [PATCH v2 5/5] ARM: dts: AM4372: add entry for qspi mmap region

2015-11-05 Thread Rob Herring
On Tue, Nov 03, 2015 at 03:36:14PM +0530, Vignesh R wrote: > Add qspi memory mapped region entries for AM43xx based SoCs. Also, > update the binding documents for the controller to document this change. > > Signed-off-by: Vignesh R Acked-by: Rob Herring > --- > Docume

Re: [PATCH v2 4/5] ARM: dts: DRA7: add entry for qspi mmap region

2015-11-05 Thread Rob Herring
possibility, but Acked-by: Rob Herring > --- > Documentation/devicetree/bindings/spi/ti_qspi.txt | 13 + > arch/arm/boot/dts/dra7.dtsi | 6 -- > 2 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devic

Re: [PATCH] net, can, ti_hecc: add DT support for the ti,hecc controller

2015-10-21 Thread Rob Herring
On Mon, Oct 19, 2015 at 1:58 AM, Marc Kleine-Budde wrote: > On 10/19/2015 08:39 AM, Heiko Schocher wrote: >> add DT support for the ti hecc controller, used on >> am3517 SoCs. > > A similar patch was posted a few days ago, see > http://comments.gmane.org/gmane.linux.can/8616 and my comments. I do

Re: [PATCH RFC v4 4/8] drm/i2c: tda998x: Add support of a DT graph of ports

2015-09-24 Thread Rob Herring
On Thu, Sep 24, 2015 at 5:36 AM, Jean-Francois Moine wrote: > On Mon, 21 Sep 2015 10:19:18 -0500 > Rob Herring wrote: > >> On 09/18/2015 06:06 AM, Jyri Sarha wrote: >> > From: Jean-Francois Moine >> > >> > Two kinds of ports may be declared in a DT

Re: [PATCH RFC v4 4/8] drm/i2c: tda998x: Add support of a DT graph of ports

2015-09-21 Thread Rob Herring
On 09/18/2015 06:06 AM, Jyri Sarha wrote: > From: Jean-Francois Moine > > Two kinds of ports may be declared in a DT graph of ports: video and audio. > This patch accepts the port value from a video port as an alternative > to the video-ports property. > It also accepts audio ports in the case th

Re: [PATCH] Documentation: DT: cpsw: document missing compatible

2015-09-01 Thread Rob Herring
On Mon, Aug 31, 2015 at 1:21 AM, Mugunthan V N wrote: > CPSW driver has multiple compatibles for errata implentations but not > documented, add necessary documentation. > > Signed-off-by: Mugunthan V N Applied. Thanks. Rob > --- > > The compatibles are added in the commit 7da1160002f1 ('drivers

Re: [PATCH] of: device: fix NULL pointer dereference on driver removal

2015-08-26 Thread Rob Herring
On Tue, Aug 25, 2015 at 2:34 PM, Felipe Balbi wrote: > If we don't insert resources into the resource tree, > calls to of_platform_depopulate() will end up in NULL > pointer dereferences because the resource parent will > be set to NULL even though we still have more resources > to go through. Lo

[PATCH v3] PCI: kill off set_irq_flags usage

2015-07-27 Thread Rob Herring
not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Cc: Kishon Vijay Abraham I Acked-by: Bjorn Helgaas Cc: Murali Karicheri Cc: Thierry Reding Cc: Stephen Warren Cc: Alexandre Courbot Cc: Jingoo Han Cc: Pratyush

[PATCH v3] mfd: kill off set_irq_flags usage

2015-07-27 Thread Rob Herring
not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Cc: Samuel Ortiz Acked-by: Lee Jones Acked-by: Linus Walleij Cc: Milo Kim Cc: Kumar Gala Cc: Andy Gross Cc: David Brown Cc: Tony Lindgren Cc: linu

[PATCH v3] memory: kill off set_irq_flags usage

2015-07-27 Thread Rob Herring
not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Acked-by: Roger Quadros Cc: Tony Lindgren Cc: linux-omap@vger.kernel.org --- Thomas asked that this be merged thru subsystem trees instead of arm-soc, so please appl

[PATCH v3] ARM: kill off set_irq_flags usage

2015-07-27 Thread Rob Herring
not clear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Cc: Russell King Cc: Sekhar Nori Cc: Kevin Hilman Cc: Jason Cooper Cc: Andrew Lunn Cc: Sebastian Hesselbarth Cc: Gregory Clement Acked-by: Hans Ulli Kroll Acked-

[PATCH v2 01/13] ARM: kill off set_irq_flags usage

2015-07-12 Thread Rob Herring
lear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Cc: Russell King Cc: Sekhar Nori Cc: Kevin Hilman Cc: Jason Cooper Cc: Andrew Lunn Cc: Sebastian Hesselbarth Cc: Gregory Clement Acked-by: Hans Ulli Kroll Cc: Shaw

[PATCH v2 07/13] memory: kill off set_irq_flags usage

2015-07-12 Thread Rob Herring
lear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Acked-by: Roger Quadros Cc: Tony Lindgren Cc: linux-omap@vger.kernel.org --- drivers/memory/omap-gpmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) dif

[PATCH v2 09/13] PCI: kill off set_irq_flags usage

2015-07-12 Thread Rob Herring
lear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Cc: Kishon Vijay Abraham I Acked-by: Bjorn Helgaas Cc: Murali Karicheri Cc: Thierry Reding Cc: Stephen Warren Cc: Alexandre Courbot Cc: Jingoo Han Cc: Pratyush

[PATCH v2 08/13] mfd: kill off set_irq_flags usage

2015-07-12 Thread Rob Herring
lear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Cc: Samuel Ortiz Acked-by: Lee Jones Acked-by: Linus Walleij Cc: Milo Kim Cc: Kumar Gala Cc: Andy Gross Cc: David Brown Cc: Tony Lindgren Cc: linu

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Rob Herring
On Mon, Jul 6, 2015 at 11:20 AM, Pali Rohár wrote: > On Monday 06 July 2015 17:22:58 Rob Herring wrote: >> On Mon, Jul 6, 2015 at 8:12 AM, Pali Rohár wrote: >> > On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: >> >> * Pali Rohár [150706 05:25]: >&g

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Rob Herring
On Mon, Jul 6, 2015 at 8:12 AM, Pali Rohár wrote: > On Monday 06 July 2015 14:31:27 Tony Lindgren wrote: >> * Pali Rohár [150706 05:25]: >> > into which file should I put documentation about new DT properties? >> >> If it's Linux generic like linux,revision, then how about >> Documentation/device

Re: [RESEND] [PATCH v2 1/2] arm: devtree: Set system_rev from DT revision

2015-07-06 Thread Rob Herring
On Mon, Jul 6, 2015 at 7:31 AM, Tony Lindgren wrote: > * Pali Rohár [150706 05:25]: >> >> into which file should I put documentation about new DT properties? > > If it's Linux generic like linux,revision, then how about Just "revision" at the top level please. I'd prefer a string still, but eith

Re: [PATCH 10/15] PCI: kill off set_irq_flags usage

2015-06-18 Thread Rob Herring
On Thu, Jun 18, 2015 at 11:59 AM, Bjorn Helgaas wrote: > On Tue, Jun 09, 2015 at 01:26:36PM -0500, Rob Herring wrote: >> set_irq_flags is ARM specific with custom flags which have genirq >> equivalents. Convert drivers to use the genirq interfaces directly, so we >> can k

Re: [PATCH 01/15] ARM: kill off set_irq_flags usage

2015-06-12 Thread Rob Herring
On Fri, Jun 12, 2015 at 9:05 AM, Hans Ulli Kroll wrote: > > > On Tue, 9 Jun 2015, Rob Herring wrote: > >> set_irq_flags is ARM specific with custom flags which have genirq >> equivalents. Convert drivers to use the genirq interfaces directly, so we >> can kill off

Re: [PATCH 08/15] memory: kill off set_irq_flags usage

2015-06-11 Thread Rob Herring
On Thu, Jun 11, 2015 at 7:18 AM, Roger Quadros wrote: > Rob, > > On Tue, 9 Jun 2015 13:26:34 -0500 > Rob Herring wrote: > >> set_irq_flags is ARM specific with custom flags which have genirq >> equivalents. Convert drivers to use the genirq interfaces dire

[PATCH 08/15] memory: kill off set_irq_flags usage

2015-06-09 Thread Rob Herring
lear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Cc: Roger Quadros Cc: Tony Lindgren Cc: linux-omap@vger.kernel.org --- drivers/memory/omap-gpmc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 01/15] ARM: kill off set_irq_flags usage

2015-06-09 Thread Rob Herring
lear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Cc: Russell King Cc: Sekhar Nori Cc: Kevin Hilman Cc: Jason Cooper Cc: Andrew Lunn Cc: Sebastian Hesselbarth Cc: Gregory Clement Cc: Hans Ulli Kroll Cc: Shawn Guo C

[PATCH 09/15] mfd: kill off set_irq_flags usage

2015-06-09 Thread Rob Herring
lear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Cc: Samuel Ortiz Cc: Lee Jones Cc: Linus Walleij Cc: Milo Kim Cc: Kumar Gala Cc: Andy Gross Cc: David Brown Cc: Tony Lindgren Cc: linux-arm-ker...@lists.infrade

[PATCH 10/15] PCI: kill off set_irq_flags usage

2015-06-09 Thread Rob Herring
lear that is really needed. There appears to be a great deal of blind copy and paste of this code. Signed-off-by: Rob Herring Cc: Kishon Vijay Abraham I Cc: Bjorn Helgaas Cc: Murali Karicheri Cc: Thierry Reding Cc: Stephen Warren Cc: Alexandre Courbot Cc: Jingoo Han Cc: Pratyush Anand

Re: [PATCH v4 3/6] Documentation: DT: Document twl4030-madc-battery bindings

2015-04-01 Thread Rob Herring
On Tue, Mar 10, 2015 at 4:27 PM, Marek Belisko wrote: > Signed-off-by: Marek Belisko > --- > .../bindings/power_supply/twl4030_madc_battery.txt | 43 > ++ > 1 file changed, 43 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/power_supply/twl4030_madc_

Re: [PATCH] dtc: parser: Add label while overriding nodes

2015-01-27 Thread Rob Herring
On Thu, Jan 8, 2015 at 8:12 AM, Nikhil Devshatwar wrote: > Current device tree compiler allows to define multiple labels when defining > the device node the first time. Typically device nodes are defined in > DTSI files. Now these nodes can be overriden for updating some of the > properties. Typic

Re: [PATCH v7 1/4] Documentation: dt: add common bindings for hwspinlock

2015-01-15 Thread Rob Herring
he base id is represented by the 'hwlock-base-id' property. >> > The args specifier length is dependent on each vendor-specific >> > implementation and is represented through the '#hwlock-cells' >> > property. Client users need to use the property 'hwlocks&

Re: [RFC PATCH 2/3] core: platform: fix an invalid kfree during of_platform_depopulate

2015-01-13 Thread Rob Herring
On Wed, Jan 7, 2015 at 11:30 AM, Suman Anna wrote: > Drivers can use of_platform_populate() to create platform devices > for children of the device main node, and a complementary API > of_platform_depopulate() is provided to delete these child devices. > Any platform_data supplied for the OF devic

Re: [RFC PATCH 1/3] of/device: manage resources similar to platform_device_add

2015-01-13 Thread Rob Herring
On Tue, Jan 13, 2015 at 3:25 PM, Suman Anna wrote: > Hi Rob, > > On 01/13/2015 02:38 PM, Rob Herring wrote: >> On Wed, Jan 7, 2015 at 11:30 AM, Suman Anna wrote: >>> Drivers can use of_platform_populate() to create platform devices >>> for children of the devi

Re: [RFC PATCH 1/3] of/device: manage resources similar to platform_device_add

2015-01-13 Thread Rob Herring
On Wed, Jan 7, 2015 at 11:30 AM, Suman Anna wrote: > Drivers can use of_platform_populate() to create platform devices > for children of the device main node, and a complementary API > of_platform_depopulate() is provided to delete these child platform > devices. The of_platform_depopulate() lever

Re: [PATCH v2 00/21] irqchip: gic: killing gic_arch_extn and co, slowly

2015-01-12 Thread Rob Herring
On Wed, Jan 7, 2015 at 11:42 AM, Marc Zyngier wrote: > The gic_arch_extn hack that a number of platform use has been nagging > me for too long. It is only there for the benefit of a few platform, > and yet it impacts all GIC users. Moreover, it gives people the wrong > idea ("let's use it to put s

Re: [PATCHv2] media: i2c/adp1653: devicetree support for adp1653

2014-12-26 Thread Rob Herring
On Fri, Dec 26, 2014 at 2:33 PM, Pavel Machek wrote: > Hi! > >> > We are moving to device tree support on OMAP3, but that currently >> > breaks ADP1653 driver. This adds device tree support, plus required >> > documentation. >> > >> > Signed-off-by: Pavel Machek >> > >> > --- >> > >> > Changed -m

Re: [PATCHv2] media: i2c/adp1653: devicetree support for adp1653

2014-12-26 Thread Rob Herring
On Wed, Dec 24, 2014 at 4:34 PM, Pavel Machek wrote: > > We are moving to device tree support on OMAP3, but that currently > breaks ADP1653 driver. This adds device tree support, plus required > documentation. > > Signed-off-by: Pavel Machek > > --- > > Changed -microsec to -us, as requested by d

Re: BCM2048 bluetooth connected over OMAP serial

2014-12-10 Thread Rob Herring
On Wed, Dec 10, 2014 at 10:43 AM, Pavel Machek wrote: > Hi! > > So, there's bluetooth chip that's connected to the SoC by UART and some > GPIOs. What would be right representation in the device tree? > Something like this? > > bluetooth { > compatible = "broadcom,bcm2048"

Re: [PATCH] arm/arm64: DT: Fix GICv2 CPU interface size

2014-06-25 Thread Rob Herring
ing the dts files is good, but that doesn't immediately help you if you have old dtbs. > Signed-off-by: Marc Zyngier > --- > arch/arm/boot/dts/axm55xx.dtsi | 2 +- > arch/arm/boot/dts/dra7.dtsi | 2 +- > arch/arm/boot/dts/ecx-2000.dts | 2

Re: [PATCH v3 1/2] arm: dts: am4372: let boards access all nodes through phandles

2014-06-24 Thread Rob Herring
On Mon, Jun 23, 2014 at 1:20 PM, Felipe Balbi wrote: > by providing phandles to rtc, wdt, cpu and dispc nodes, > boards can access them to add board-specific data. Strictly speaking, you are adding labels, not phandles. You can do phandles without using labels, but the syntax is not so obvious. I

Re: [PATCH v2 04/18] PCI: designware: use untranslated address while programming ATU

2014-06-20 Thread Rob Herring
On Thu, May 29, 2014 at 1:38 AM, Kishon Vijay Abraham I wrote: > In DRA7, the cpu sees 32bit address, but the pcie controller can see only > 28bit > address. So whenever the cpu issues a read/write request, the 4 most > significant bits are used by L3 to determine the target controller. > For exa

Re: [PATCH] ARM: omap: rework platform selection

2014-06-17 Thread Rob Herring
On Tue, Jun 17, 2014 at 10:25 AM, Tony Lindgren wrote: > * Rob Herring [140617 08:05]: >> On Tue, Jun 17, 2014 at 8:57 AM, Arnd Bergmann wrote: >> > On Monday 16 June 2014, Rob Herring wrote: >> >> > So far I have not come up with no great ideas on fixi

Re: [PATCH] ARM: omap: rework platform selection

2014-06-17 Thread Rob Herring
On Tue, Jun 17, 2014 at 8:57 AM, Arnd Bergmann wrote: > On Monday 16 June 2014, Rob Herring wrote: >> > So far I have not come up with no great ideas on fixing this >> > properly short of requiring all omap .config files to add >> > CONFIG_ARCH_OMAP=y manually. A

Re: [PATCH] ARM: omap: rework platform selection

2014-06-16 Thread Rob Herring
On Mon, Jun 16, 2014 at 9:17 AM, Tony Lindgren wrote: > * Tony Lindgren [140616 04:31]: >> * Arnd Bergmann [140616 04:18]: >> > >> > Let's see if others have similar opinions Rob's patch as a whole. >> > I'd still like to keep all the parts aside from the OMAP change >> > and just back out the c

Re: [PATCH] PM / OPP: Remove ARCH_HAS_OPP

2014-06-06 Thread Rob Herring
PP symbol > has become redundant and can be removed. Do so. > > Signed-off-by: Mark Brown Acked-by: Rob Herring > --- > Documentation/power/opp.txt| 3 --- > arch/arm/mach-exynos/Kconfig | 1 - > arch/arm/mach-highbank/Kconfig | 1 - > arch/arm/mach-imx/Kconfig

Re: [PATCH v2 16/18] ARM: OMAP: Enable PCI for DRA7

2014-05-29 Thread Rob Herring
On Thu, May 29, 2014 at 1:38 AM, Kishon Vijay Abraham I wrote: > Now that we have added PCIe driver for DRA7 SOCs, enable PCI on > DRA7 SOCs. > > Cc: Tony Lindgren > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Kumar Gala > Signed-off-by: Kishon Vij

Re: [PATCH v3 1/5] sc_phy:SmartCard(SC) PHY interface to SC controller

2014-05-29 Thread Rob Herring
On Thu, May 29, 2014 at 3:34 AM, Satish Patel wrote: > > > On 5/29/2014 12:23 AM, Greg KH wrote: >> >> On Wed, May 28, 2014 at 02:27:13PM +0530, Satish Patel wrote: >>> >>> SmartCard controller uses this interface to communicate with >>> SmartCard via PHY >>> >>> Some SmartCard PHY has multiple sl

Re: [PATCHv5 RFC 08/15] hwspinlock/core: add support for base id in DT

2014-05-05 Thread Rob Herring
On Wed, Apr 30, 2014 at 7:34 PM, Suman Anna wrote: > The HwSpinlock core requires a base id for registering a bank > of hwspinlocks. This base id needs to be unique across multiple > IP instances of a hwspinlock device, so that each hwlock can be > represented uniquely in a system. > > Support has

Re: [PATCHv5 01/15] Documentation: dt: add common bindings for hwspinlock

2014-05-02 Thread Rob Herring
ifier. The args specifier > length is dependent on each vendor-specific implementation and > is represented through the '#hwlock-cells' property. > > Note that the document is named hwlock.txt deliberately to keep it > a bit more generic. > > Cc: Rob Herring > Signed

Re: [PATCHv3 07/14] HSI: Add common DT binding for HSI client devices

2014-04-21 Thread Rob Herring
On Fri, Mar 28, 2014 at 7:31 PM, Sebastian Reichel wrote: > Implement and document generic DT bindings for HSI clients. > > Signed-off-by: Sebastian Reichel Seems pretty reasonable although I know little about HSI. > --- > .../devicetree/bindings/hsi/client-devices.txt | 44 + > drive

Re: [PATCHv3 09/14] Documentation: DT: omap-ssi binding documentation

2014-04-21 Thread Rob Herring
On Fri, Mar 28, 2014 at 7:31 PM, Sebastian Reichel wrote: > Create device tree binding documentation for > OMAP Synchronous Serial Interface (SSI) device. > > Signed-off-by: Sebastian Reichel > --- > Documentation/devicetree/bindings/hsi/omap-ssi.txt | 85 > ++ > 1 file chan

Re: [PATCHv2 1/5] Input: add common DT binding for touchscreens

2014-04-07 Thread Rob Herring
On Mon, Apr 7, 2014 at 3:00 PM, Sebastian Reichel wrote: > On Mon, Apr 07, 2014 at 11:38:01AM -0500, Rob Herring wrote: >> On Sat, Apr 5, 2014 at 5:26 PM, Sebastian Reichel wrote: >> > Add common DT binding documentation for touchscreen devices

Re: [PATCHv2 1/5] Input: add common DT binding for touchscreens

2014-04-07 Thread Rob Herring
On Sat, Apr 5, 2014 at 5:26 PM, Sebastian Reichel wrote: > Add common DT binding documentation for touchscreen devices and > implement input_parse_touchscreen_of_params, which parses the common > properties and configures the input device accordingly. Good. > > Signed-off-by: Sebastian Reichel

Re: [RFC PATCH 02/12] pci: host: pcie-dra7xx: add support for pcie-dra7xx controller

2014-03-26 Thread Rob Herring
On Wed, Mar 26, 2014 at 8:57 AM, Kishon Vijay Abraham I wrote: > Added support for pcie controller in dra7xx. This driver re-uses > the designware core code that is already present in kernel. > > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/pci/ti-pci.txt | 3

Re: [RFC 2/9] opp-modifier: Add opp-modifier-reg driver

2014-03-17 Thread Rob Herring
On Mon, Mar 17, 2014 at 9:30 AM, Nishanth Menon wrote: > On 03/14/2014 04:00 PM, Rob Herring wrote: >> On Fri, Mar 14, 2014 at 2:25 PM, Dave Gerlach wrote: >>> Driver to read from a register and depending on either set bits or >>> a specific known selectively enable

Re: [RFC 3/5] ARM: OMAP2+: timer: Add clocksource initialization and powerup support

2014-03-14 Thread Rob Herring
On Fri, Mar 14, 2014 at 4:09 PM, Kevin Hilman wrote: > Joel Fernandes writes: > >> On 03/13/2014 04:52 PM, Rob Herring wrote: >>> On Thu, Mar 13, 2014 at 3:35 PM, Joel Fernandes wrote: >>>> Introduce a generic omap timer initialization function that can &

Re: [RFC 2/9] opp-modifier: Add opp-modifier-reg driver

2014-03-14 Thread Rob Herring
On Fri, Mar 14, 2014 at 2:25 PM, Dave Gerlach wrote: > Driver to read from a register and depending on either set bits or > a specific known selectively enable or disable OPPs based on DT node. > > Can support opp-modifier-reg-bit where single bits within the register > determine the availability

Re: [RFC 3/5] ARM: OMAP2+: timer: Add clocksource initialization and powerup support

2014-03-13 Thread Rob Herring
On Thu, Mar 13, 2014 at 3:35 PM, Joel Fernandes wrote: > Introduce a generic omap timer initialization function that can > be used by all SoCs for which support is available in the clocksource > driver introduced in the series. > > The function will also be responsible for calling clock initializa

Re: [RFC PATCH 0/9] drivers: dma: Add support for dma-channel router

2014-03-08 Thread Rob Herring
On Fri, Mar 7, 2014 at 6:16 AM, Sricharan R wrote: > In some SoCs the dma request lines from the peripherals are > routed to the dma-controller through a crossbar. With this the > dma controller's available request lines are shared between the > peripherals. > > This adds support to register the c

Re: [PATCH] ARM: EDMA: Use platform_get_resource functions for DT

2014-02-25 Thread Rob Herring
On Fri, Feb 21, 2014 at 11:36 AM, Joel Fernandes wrote: > On 02/21/2014 06:15 AM, Mark Rutland wrote: >>> Also, while at it get rid of the assumption in the code that "CC" is at reg >>> index 0 in the DT and xbar is at offset 1. Instead use reg-names to get the >>> memory resource in concern keepi

Re: [PATCHv1 1/6] HSI: add Device Tree support for HSI clients

2014-02-24 Thread Rob Herring
On Sun, Feb 23, 2014 at 5:49 PM, Sebastian Reichel wrote: > Add new method hsi_add_clients_from_dt, which can be used > to initialize HSI clients from a device tree node. > > The patch also documents the DT binding for trivial HSI > clients. > > Signed-off-by: Sebastian Reichel > --- > .../devic

Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts

2013-12-31 Thread Rob Herring
On Mon, Dec 30, 2013 at 4:10 PM, Paul Walmsley wrote: > Hi Grant, Rob, > > On Tue, 10 Dec 2013, Paul Walmsley wrote: > >> On Sun, 24 Nov 2013, Grant Likely wrote: >> >> > On Fri, 22 Nov 2013 17:50:35 -0800, Tony Lindgren wrote: >> > > * Tony Lindgren [131122 17:16]: >> > > > * Tony Lindgren [13

Re: [PATCH 1/2] ARM: dts: doc: Document missing binding for omap5-mpu

2013-12-02 Thread Rob Herring
On Fri, Nov 8, 2013 at 4:38 AM, Sricharan R wrote: > The binding and support for omap5-mpu which has a cortex-a15 > smp core, gic and integrated L2 cache has been existing for sometime. > So Documenting the missing binding here. > > Cc: Benoit Cousson > Signed-off-by: Sricharan R > --- > Docume

Re: [PATCH 5/8] ARM: OMAP2+: timer: Introduce OF-friendly clocksource/clockevent system timers

2013-11-23 Thread Rob Herring
On Fri, Nov 22, 2013 at 7:12 PM, Joel Fernandes wrote: > Adding Thomas to the thread since discussion is about clocksource, and Mark > Rutland as discussion is related to timers and DT, thanks. > > On 11/22/2013 02:01 PM, Rob Herring wrote: >> On Fri, Nov 22, 2013 at 10:42

Re: [PATCH 5/8] ARM: OMAP2+: timer: Introduce OF-friendly clocksource/clockevent system timers

2013-11-22 Thread Rob Herring
On Fri, Nov 22, 2013 at 10:42 AM, Joel Fernandes wrote: > On 11/22/2013 09:58 AM, Rob Herring wrote: >> On Thu, Nov 21, 2013 at 7:56 PM, Joel Fernandes wrote: >>> This work is a migration effort of OMAP system timers to the >>> clocksource/clockevent framework. Consi

Re: [PATCH 5/8] ARM: OMAP2+: timer: Introduce OF-friendly clocksource/clockevent system timers

2013-11-22 Thread Rob Herring
On Thu, Nov 21, 2013 at 7:56 PM, Joel Fernandes wrote: > This work is a migration effort of OMAP system timers to the > clocksource/clockevent framework. Consider this as a first-pass in this > effort. > There are few cleanups that need to be done first. The HWMOD code is > intertwined with the t

Re: [PATCH V2 2/2] ARM: dts: doc: Document missing binding for ti-sdma controller

2013-11-20 Thread Rob Herring
On Mon, Nov 11, 2013 at 10:06 AM, Sricharan R wrote: > The binding and support for system DMA module present in OMAP2+ Socs > and DRA7 with dma-engine is already present. So adding the missing > documentation for the same. > > Signed-off-by: Sricharan R Acked-by: Rob Herring --

  1   2   3   >