Hi Tony,
On Tuesday 01 July 2014 01:29 PM, Tony Lindgren wrote:
* Jason Cooper ja...@lakedaemon.net [140630 12:30]:
Whole series applied to irqchip/crossbar, I'll give it a day or two in
-next, then I'll merge it into irqchip/core.
Tony: Right now, it's immutable unless you tell me I
Info(drivers/irqchip/irq-crossbar.c:27): Scanning doc for struct
Warning(drivers/irqchip/irq-crossbar.c:39): No description found for parameter
'write'
2 warnings
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Acked-by: Santosh Shilimkar santosh.shilim
: Unnecessary space before function pointer arguments
#37: FILE: drivers/irqchip/irq-crossbar.c:37:
+ void (*write) (int, int);
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
---
.../devicetree
allocation/programming of crossbar should be avoided.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
---
.../devicetree/bindings/arm/omap/crossbar.txt | 12 ++--
drivers/irqchip/irq-crossbar.c
Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
---
.../devicetree/bindings/arm/omap/crossbar.txt | 17 +
1 file changed, 17 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/omap/crossbar.txt
From: Nishanth Menon n...@ti.com
This is a basic check to ensure that crossbar register needs to be
written. This ensures that we have a common check which is used in
both map and unmap logic.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Acked
If crossbar_of_init returns with a error, then set the cb pointer
to null.
Signed-off-by: Sricharan R r.sricha...@ti.com
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
---
drivers/irqchip/irq-crossbar.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c
in time.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
---
drivers/irqchip/irq-crossbar.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-crossbar.c b
);
WARNING: Prefer kcalloc over kzalloc with multiply
+ cb-register_offsets = kzalloc(max * sizeof(int), GFP_KERNEL);
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
---
drivers/irqchip/irq-crossbar.c
From: Nishanth Menon n...@ti.com
crossbar_of_init always returns -ENOMEM in case of errors.
There can be other causes of failure like invalid data from
DT. So return a appropriate error value for that case.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
From: Nishanth Menon n...@ti.com
Using err1,2,3,4 etc makes it hard to ensure a new exit path in the
middle will not result in spurious changes, so rename the error paths
as per the function it does.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Acked
and use it to
validate requests.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
---
.../devicetree/bindings/arm/omap/crossbar.txt |2 ++
drivers/irqchip/irq-crossbar.c | 21
Adding kerneldoc for unmap callback function.
Signed-off-by: Sricharan R r.sricha...@ti.com
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
---
drivers/irqchip/irq-crossbar.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip
From: Nishanth Menon n...@ti.com
Today '0' is actually reserved, but may not be the same in the future.
So, use a flag to mark the GIC interrupts that are reserved.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Acked-by: Santosh Shilimkar santosh.shilim
for quirky hardware with direct hardwiring
of GIC
Sricharan R (2):
irqchip: crossbar: Set cb pointer to null in case of error
irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback
.../devicetree/bindings/arm/omap/crossbar.txt | 36 +
drivers/irqchip/irq
-by: Sricharan R r.sricha...@ti.com
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
---
.../devicetree/bindings/arm/omap/crossbar.txt |6 ++
drivers/irqchip/irq-crossbar.c | 20
2 files changed, 26 insertions(+)
diff --git a/Documentation/devicetree
.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
---
drivers/irqchip/irq-crossbar.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip
From: Nishanth Menon n...@ti.com
IS_ERR_VALUE makes sense only *if* there could be valid values in
negative error range. But in the cases that we do use it, there is no
such case. Just remove the same.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Acked
This series introduces DT support for crossbar device and
changes dra7 peripherals to use crossbar number instead of irq.
This depends on below driver fixes and cleanup series.
http://marc.info/?l=linux-omapm=140376708127157w=2
[V2] Rebased on 3.15 mainline.
[V3] Added ti,irqs-skip property and
controller's input line. The crossbar device is used to map
a peripheral input to a free mpu's interrupt controller line.
Here, adding a new crossbar device node and replacing all the peripheral
interrupt numbers with its fixed crossbar input lines.
Signed-off-by: Sricharan R r.sricha...@ti.com
-by: Sricharan R r.sricha...@ti.com
Signed-off-by: Nishanth Menon n...@ti.com
Cc: Benoit Cousson bcous...@baylibre.com
Cc: Santosh Shilimkar santosh.shilim...@ti.com
Cc: Rajendra Nayak rna...@ti.com
Cc: Tony Lindgren t...@atomide.com
---
arch/arm/boot/dts/dra7.dtsi |1 +
1 file changed, 1
Hi Tony,
On Thursday 26 June 2014 01:14 PM, Tony Lindgren wrote:
* Sricharan R r.sricha...@ti.com [140626 00:29]:
From: R Sricharan r.sricha...@ti.com
There is a IRQ crossbar device in the soc, which
maps the irq requests from the peripherals to the
mpu interrupt controller's inputs
, Jun 16, 2014 at 04:53:03PM +0530, Sricharan R wrote:
From: Nishanth Menon n...@ti.com
When, in the system due to varied reasons, interrupts might be unusable
due to hardware behavior, but register maps do exist, then those interrupts
should be skipped while mapping irq to crossbars.
Signed
Hi Jason,
On Saturday 21 June 2014 08:27 AM, Jason Cooper wrote:
On Mon, Jun 16, 2014 at 04:53:16PM +0530, Sricharan R wrote:
From: Nishanth Menon n...@ti.com
On certain platforms such as DRA7, SPIs 0, 1, 2, 3, 5, 6, 10, 131,
132, 133 are direct wired to hardware blocks bypassing crossbar
On Monday 16 June 2014 07:34 PM, Santosh Shilimkar wrote:
Sricharan,
On Monday 16 June 2014 07:23 AM, Sricharan R wrote:
This series does some cleanups, fixes for handling two interrupts
getting mapped twice to same crossbar and provides support for
hardwired IRQ and crossbar definitions
valid crossbar mapping
irqchip: crossbar: introduce centralized check for crossbar write
documentation: dt: omap: crossbar: add description for interrupt
consumer
irqchip: crossbar: allow for quirky hardware with direct hardwiring
of GIC
Sricharan R (2):
irqchip: crossbar: set cb
Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
---
.../devicetree/bindings/arm/omap/crossbar.txt | 17 +
1 file changed, 17 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/omap/crossbar.txt
b/Documentation/devicetree/bindings/arm/omap
allocation/programming of crossbar should be avoided.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
---
.../devicetree/bindings/arm/omap/crossbar.txt | 12 ++--
drivers/irqchip/irq-crossbar.c | 20 ++--
2
If crossbar_of_init returns with a error, then set the cb pointer
to null.
Signed-off-by: Sricharan R r.sricha...@ti.com
---
drivers/irqchip/irq-crossbar.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 5bd7f3d
and use it to
validate requests.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
---
.../devicetree/bindings/arm/omap/crossbar.txt |2 ++
drivers/irqchip/irq-crossbar.c | 21 ++--
2 files changed, 21 insertions(+), 2
From: Nishanth Menon n...@ti.com
This is a basic check to ensure that crossbar register needs to be
written. This ensures that we have a common check which is used in
both map and unmap logic.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
---
drivers
From: Nishanth Menon n...@ti.com
crossbar_of_init always returns -ENOMEM in case of errors.
There can be other causes of failure like invalid data from
DT. So return a appropriate error value for that case.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Adding kerneldoc for unmap callback function.
Signed-off-by: Sricharan R r.sricha...@ti.com
---
[V3] Reworded the kerneldoc
drivers/irqchip/irq-crossbar.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index
Info(drivers/irqchip/irq-crossbar.c:27): Scanning doc for struct
Warning(drivers/irqchip/irq-crossbar.c:39): No description found for parameter
'write'
2 warnings
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
---
[V3] Reworded the commit log
drivers
);
WARNING: Prefer kcalloc over kzalloc with multiply
+ cb-register_offsets = kzalloc(max * sizeof(int), GFP_KERNEL);
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
---
[V3] Added checkpatch fixes as well to this.
drivers/irqchip/irq-crossbar.c |7
From: Nishanth Menon n...@ti.com
IS_ERR_VALUE makes sense only *if* there could be valid values in
negative error range. But in the cases that we do use it, there is no
such case. Just remove the same.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
From: Nishanth Menon n...@ti.com
Using err1,2,3,4 etc makes it hard to ensure a new exit path in the
middle will not result in spurious changes, so rename the error paths
as per the function it does.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
in time.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
---
[V3] Added more description to commit log.
drivers/irqchip/irq-crossbar.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers
: Unnecessary space before function pointer arguments
#37: FILE: drivers/irqchip/irq-crossbar.c:37:
+ void (*write) (int, int);
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
---
[V3] introduced ti,irqs-safe-map which defines a safe value
-by: Sricharan R r.sricha...@ti.com
---
[V3] introduced ti,irqs-skip dt property to list the
irqs to be skipped.
.../devicetree/bindings/arm/omap/crossbar.txt |4
drivers/irqchip/irq-crossbar.c | 20
2 files changed, 24 insertions(+)
diff --git
.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
---
drivers/irqchip/irq-crossbar.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 20105bc..51d4b87 100644
From: Nishanth Menon n...@ti.com
Today '0' is actually reserved, but may not be the same in the future.
So, use a flag to mark the GIC interrupts that are reserved.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
---
drivers/irqchip/irq-crossbar.c |5
This series introduces DT support for crossbar device and
changes dra7 peripherals to use crossbar number instead of irq.
This depends on below driver fixes and cleanup series.
https://lkml.org/lkml/2014/6/16/218
[V2] Rebased on 3.15 mainline.
[V3] Added ti,irqs-skip property and
-by: Sricharan R r.sricha...@ti.com
Signed-off-by: Nishanth Menon n...@ti.com
Cc: Benoit Cousson bcous...@baylibre.com
Cc: Santosh Shilimkar santosh.shilim...@ti.com
Cc: Rajendra Nayak rna...@ti.com
Cc: Tony Lindgren t...@atomide.com
---
arch/arm/boot/dts/dra7.dtsi |1 +
1 file changed, 1
controller's input line. The crossbar device is used to map
a peripheral input to a free mpu's interrupt controller line.
Here, adding a new crossbar device node and replacing all the peripheral
interrupt numbers with its fixed crossbar input lines.
Signed-off-by: Sricharan R r.sricha...@ti.com
Hi Jason,
On Thursday 12 June 2014 06:26 PM, Jason Cooper wrote:
On Thu, Jun 12, 2014 at 05:23:13PM +0530, Sricharan R wrote:
From: Nishanth Menon n...@ti.com
Reverse the search algorithm to ensure that address mapping and IRQ
allocation logics are proper. This can open up new bugs which
Hi Jason,
On Thursday 12 June 2014 09:35 PM, Joe Perches wrote:
On Thu, 2014-06-12 at 11:32 -0400, Jason Cooper wrote:
Hi Jason.
But bugfix backports haven't been much of an issue in
other subsystems with fairly active whitespace/style
changes.
Most of the mvebu fixes we've had that
On Thursday 12 June 2014 07:27 PM, Tony Lindgren wrote:
* Jason Cooper ja...@lakedaemon.net [140612 05:52]:
On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote:
From: Nishanth Menon n...@ti.com
When, in the system due to varied reasons, interrupts might be unusable
due to hardware
Hi Jason,
On Thursday 12 June 2014 07:37 PM, Jason Cooper wrote:
On Thu, Jun 12, 2014 at 06:49:17PM +0530, Sricharan R wrote:
Hi Jason,
On Thursday 12 June 2014 06:21 PM, Jason Cooper wrote:
On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote:
From: Nishanth Menon n...@ti.com
When
Hi Jason,
On Thursday 12 June 2014 07:35 PM, Jason Cooper wrote:
On Thu, Jun 12, 2014 at 06:57:15AM -0700, Tony Lindgren wrote:
* Jason Cooper ja...@lakedaemon.net [140612 05:52]:
On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote:
From: Nishanth Menon n...@ti.com
When
Hi Jason,
On Thursday 12 June 2014 07:24 PM, Jason Cooper wrote:
On Thu, Jun 12, 2014 at 05:23:24PM +0530, Sricharan R wrote:
From: Nishanth Menon n...@ti.com
Currently we attempt to map any crossbar value to an IRQ, however,
this is not correct from hardware perspective. There is a max
On Friday 13 June 2014 12:26 PM, Sricharan R wrote:
Hi Jason,
On Thursday 12 June 2014 07:35 PM, Jason Cooper wrote:
On Thu, Jun 12, 2014 at 06:57:15AM -0700, Tony Lindgren wrote:
* Jason Cooper ja...@lakedaemon.net [140612 05:52]:
On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote
From: Nishanth Menon n...@ti.com
DMA interrupts are now available in of, and the definitions are
duplicates in hwmod. This prevents us from dynamically allocating
interrupt resources for dma from devicetree.
Signed-off-by: Nishanth Menon n...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_7xx_data.c
From: Nishanth Menon n...@ti.com
we have currently 2 DMA drivers that try to co-exist.
drivers/dma/omap-dma.c which registers it's own IRQ and is device tree
aware and uses arch/arm/plat-omap/dma.c instance created by
arch/arm/mach-omap2/dma.c to maintain channel usage (omap_request_dma).
This series removes the DMA interrupt registration if DT provides interrupts,
so we have no need for hwmod provided interrupt number.
This is a pre-req for crossbar migration as DMA is the last driver to use
interrupt definition from hwmod.
[V2] Rebased on 3.15 mainline
Nishanth Menon (2):
From: Nishanth Menon n...@ti.com
Today '0' is actually reserved, but may not be the same in the future.
So, use a flag to mark the GIC interrupts that are reserved.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Signed-off-by: Tony Lindgren t
From: Nishanth Menon n...@ti.com
On certain platforms such as DRA7, SPIs 0, 1, 2, 3, 5, 6, 10, 131,
132, 133 are direct wired to hardware blocks bypassing crossbar.
This quirky implementation is *NOT* supposed to be the expectation
of crossbar hardware usage. However, these are already marked in
From: Nishanth Menon n...@ti.com
The current crossbar description does not include the description
required for the consumer of the crossbar, a.k.a devices whoes events
pass through the crossbar into the GIC interrupt controller.
So, provide documentation for the same.
Signed-off-by: Nishanth
From: Nishanth Menon n...@ti.com
This is a basic check to ensure that crossbar register needs to be
written. This ensures that we have a common check which is used in
both map and unmap logic.
Signed-off-by: Nishanth Menon n...@ti.com
---
drivers/irqchip/irq-crossbar.c | 14 --
1
From: Nishanth Menon n...@ti.com
Using err1,2,3,4 etc makes it hard to ensure a new exit path in the
middle will not result in spurious changes, so rename the error paths
as per the function it does.
Signed-off-by: Nishanth Menon n...@ti.com
---
drivers/irqchip/irq-crossbar.c | 22
.
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Signed-off-by: Tony Lindgren t...@atomide.com
---
drivers/irqchip/irq-crossbar.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq
If crossbar_of_init returns with a error, then set the cb pointer
to null.
Signed-off-by: Sricharan R r.sricha...@ti.com
---
drivers/irqchip/irq-crossbar.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index cf0d79f
kerneldoc for unmap callback clarity.
Signed-off-by: Sricharan R r.sricha...@ti.com
---
drivers/irqchip/irq-crossbar.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 5f3e75a..2a73a66 100644
--- a/drivers/irqchip/irq
From: Nishanth Menon n...@ti.com
Currently we attempt to map any crossbar value to an IRQ, however,
this is not correct from hardware perspective. There is a max crossbar
event number upto which hardware supports. So describe the same in
device tree using 'ti,max-crossbar-sources' property and
From: Nishanth Menon n...@ti.com
When the provided unused skip list entry is greater than max irqs
possible, we go to err3, but we fail to free register_offsets,
should have returned to err4 instead which ensures that allocated
register_offsets are freed as well.
Signed-off-by: Nishanth Menon
From: Nishanth Menon n...@ti.com
crossbar_of_init always returns -ENOMEM in case of errors, return proper
error results in case of failures.
Signed-off-by: Nishanth Menon n...@ti.com
---
drivers/irqchip/irq-crossbar.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
From: Nishanth Menon n...@ti.com
There is absolutely no need for crossbar driver to expose functions and
variables into global namespace. So make them all static
Fixes sparse warnings:
drivers/irqchip/irq-crossbar.c:129:29: warning: symbol
'routable_irq_domain_ops' was not declared. Should it
From: Nishanth Menon n...@ti.com
kernel doc style is wrong in code. fix it to squelch
kerneldoc warnings:
Warning(drivers/irqchip/irq-crossbar.c:27): missing initial short description
on line:
* struct crossbar_device: crossbar device description
Info(drivers/irqchip/irq-crossbar.c:27):
-TRMINC00067 is being used to track the update.
Reported-by: Nishanth Menon n...@ti.com
Reported-by: Sricharan R r.sricha...@ti.com
Reported-by: Suman Anna s-a...@ti.com
Signed-off-by: Rajendra Nayak rna...@ti.com
---
drivers/irqchip/irq-crossbar.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions
From: Nishanth Menon n...@ti.com
remove un-necessary space in function pointer.
Fixes checkpatch warning:
WARNING: Unnecessary space before function pointer arguments
#37: FILE: drivers/irqchip/irq-crossbar.c:37:
+ void (*write) (int, int);
WARNING: Missing a blank line after
-by: Sricharan R r.sricha...@ti.com
Signed-off-by: Nishanth Menon n...@ti.com
Cc: Benoit Cousson bcous...@baylibre.com
Cc: Santosh Shilimkar santosh.shilim...@ti.com
Cc: Rajendra Nayak rna...@ti.com
Cc: Tony Lindgren t...@atomide.com
Tested-by: Darren Etheridge detheri...@ti.com
Tested-by: Roger
controller's input line. The crossbar device is used to map
a peripheral input to a free mpu's interrupt controller line.
Here, adding a new crossbar device node and replacing all the peripheral
interrupt numbers with its fixed crossbar input lines.
Signed-off-by: Sricharan R r.sricha...@ti.com
must be written to
ensure that the crossbar mapping matches with interrupt controller
usage.
So provide a safe value in the compatible data to map if
'0' is not safe for the platform and use it during init and unmap
Signed-off-by: Nishanth Menon n...@ti.com
Signed-off-by: Sricharan R
...@ti.com
Signed-off-by: Sricharan R r.sricha...@ti.com
Signed-off-by: Tony Lindgren t...@atomide.com
---
drivers/irqchip/irq-crossbar.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 287d3ce..de021638
This series introduces DT support for crossbar device and
changes dra7 peripherals to use crossbar number instead of irq.
This depends on below driver fixes and cleanup series.
https://lkml.org/lkml/2014/6/12/232
[V2] Rebased on 3.15 mainline.
R Sricharan (2):
ARM: dts: DRA7: Add
From: Nishanth Menon n...@ti.com
IS_ERR_VALUE makes sense only *if* there could be valid values in
negative error range. But in the cases that we do use it, there is no
such case. Just remove the same.
Signed-off-by: Nishanth Menon n...@ti.com
---
drivers/irqchip/irq-crossbar.c |6 +++---
1
-by: Sricharan R r.sricha...@ti.com
Signed-off-by: Tony Lindgren t...@atomide.com
---
drivers/irqchip/irq-crossbar.c | 47
1 file changed, 43 insertions(+), 4 deletions(-)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 51d4b87
check for crossbar write
Documentation: dt: OMAP: crossbar: add description for interrupt
consumer
irqchip: crossbar allow for quirky hardware with direct hardwiring of
GIC
Rajendra Nayak (1):
irqchip: crossbar: DRA7: Fix unused crossbar list
Sricharan R (2):
irqchip: crossbar: set
Hi Jason,
On Thursday 12 June 2014 06:21 PM, Jason Cooper wrote:
On Thu, Jun 12, 2014 at 05:23:11PM +0530, Sricharan R wrote:
From: Nishanth Menon n...@ti.com
When, in the system due to varied reasons, interrupts might be unusable
due to hardware behavior, but register maps do exist
Hi Jason,
On Thursday 12 June 2014 06:46 PM, Jason Cooper wrote:
On Thu, Jun 12, 2014 at 05:23:18PM +0530, Sricharan R wrote:
From: Rajendra Nayak rna...@ti.com
On DRA7 compatible IRQ crossbar, IRQ 10 default mapped to L3_APP_IRQ,
IRQ133 is default mapped to NMI pin, 139 and 140 crossbars
Hi Jason,
On Thursday 12 June 2014 06:40 PM, Jason Cooper wrote:
On Thu, Jun 12, 2014 at 05:23:16PM +0530, Sricharan R wrote:
From: Nishanth Menon n...@ti.com
remove un-necessary space in function pointer.
Fixes checkpatch warning:
WARNING: Unnecessary space before function pointer
Hi Jason,
On Thursday 12 June 2014 06:50 PM, Jason Cooper wrote:
On Thu, Jun 12, 2014 at 05:23:19PM +0530, Sricharan R wrote:
From: Nishanth Menon n...@ti.com
When the provided unused skip list entry is greater than max irqs
possible, we go to err3, but we fail to free register_offsets
Hi Jason,
On Thursday 12 June 2014 06:44 PM, Jason Cooper wrote:
On Thu, Jun 12, 2014 at 05:23:17PM +0530, Sricharan R wrote:
From: Nishanth Menon n...@ti.com
kernel doc style is wrong in code. fix it to squelch
kerneldoc warnings:
I would re-word the above to mention that we need to add
Hi Jason,
On Thursday 12 June 2014 07:19 PM, Jason Cooper wrote:
On Thu, Jun 12, 2014 at 05:23:23PM +0530, Sricharan R wrote:
The crossbar_domain_map/unmap callbacks need not be called same number
of times for a particular irq. But still use counting is not needed
here, because unmap(irq
Documentation: dt: OMAP: crossbar: add description for interrupt
consumer
irqchip: crossbar allow for quirky hardware with direct hardwiring of
GIC
Rajendra Nayak (1):
irqchip: crossbar: DRA7: Fix unused crossbar list
Sricharan R (2):
irqchip: crossbar: set cb pointer to null in case of error
crossbar list
Sricharan R (2):
irqchip: crossbar: set cb pointer to null in case of error
irqchip: crossbar: Add kerneldoc for crossbar_domain_unmap callback
.../devicetree/bindings/arm/omap/crossbar.txt | 27 +
drivers/irqchip/irq-crossbar.c | 127
From: Nishanth Menon n...@ti.com
There is absolutely no need for crossbar driver to expose functions and
variables into global namespace. So make them all static
Fixes sparse warnings:
drivers/irqchip/irq-crossbar.c:129:29: warning: symbol
'routable_irq_domain_ops' was not declared. Should it
From: Nishanth Menon n...@ti.com
IS_ERR_VALUE makes sense only *if* there could be valid values in
negative error range. But in the cases that we do use it, there is no
such case. Just remove the same.
Signed-off-by: Nishanth Menon n...@ti.com
---
drivers/irqchip/irq-crossbar.c |6 +++---
1
From: Nishanth Menon n...@ti.com
remove un-necessary space in function pointer.
Fixes checkpatch warning:
WARNING: Unnecessary space before function pointer arguments
#37: FILE: drivers/irqchip/irq-crossbar.c:37:
+ void (*write) (int, int);
WARNING: Missing a blank line after
From: Nishanth Menon n...@ti.com
kernel doc style is wrong in code. fix it to squelch
kerneldoc warnings:
Warning(drivers/irqchip/irq-crossbar.c:27): missing initial short description
on line:
* struct crossbar_device: crossbar device description
Info(drivers/irqchip/irq-crossbar.c:27):
-TRMINC00067 is being used to track the update.
Reported-by: Nishanth Menon n...@ti.com
Reported-by: Sricharan R r.sricha...@ti.com
Reported-by: Suman Anna s-a...@ti.com
Signed-off-by: Rajendra Nayak rna...@ti.com
---
drivers/irqchip/irq-crossbar.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions
From: Nishanth Menon n...@ti.com
crossbar_of_init always returns -ENOMEM in case of errors, return proper
error results in case of failures.
Signed-off-by: Nishanth Menon n...@ti.com
---
drivers/irqchip/irq-crossbar.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
From: Nishanth Menon n...@ti.com
Using err1,2,3,4 etc makes it hard to ensure a new exit path in the
middle will not result in spurious changes, so rename the error paths
as per the function it does.
Signed-off-by: Nishanth Menon n...@ti.com
---
drivers/irqchip/irq-crossbar.c | 22
From: Nishanth Menon n...@ti.com
When the provided unused skip list entry is greater than max irqs
possible, we go to err3, but we fail to free register_offsets,
should have returned to err4 instead which ensures that allocated
register_offsets are freed as well.
Signed-off-by: Nishanth Menon
From: Nishanth Menon n...@ti.com
On certain platforms such as DRA7, SPIs 0, 1, 2, 3, 5, 6, 10, 131,
132, 133 are direct wired to hardware blocks bypassing crossbar.
This quirky implementation is *NOT* supposed to be the expectation
of crossbar hardware usage. However, these are already marked in
From: Nishanth Menon n...@ti.com
The current crossbar description does not include the description
required for the consumer of the crossbar, a.k.a devices whoes events
pass through the crossbar into the GIC interrupt controller.
So, provide documentation for the same.
Signed-off-by: Nishanth
From: Nishanth Menon n...@ti.com
This is a basic check to ensure that crossbar register needs to be
written. This ensures that we have a common check which is used in
both map and unmap logic.
Signed-off-by: Nishanth Menon n...@ti.com
---
drivers/irqchip/irq-crossbar.c | 14 --
1
From: Nishanth Menon n...@ti.com
Currently we attempt to map any crossbar value to an IRQ, however,
this is not correct from hardware perspective. There is a max crossbar
event number upto which hardware supports. So describe the same in
device tree using 'ti,max-crossbar-sources' property and
kerneldoc for unmap callback clarity.
Signed-off-by: Sricharan R r.sricha...@ti.com
---
drivers/irqchip/irq-crossbar.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 5f3e75a..2a73a66 100644
--- a/drivers/irqchip/irq
If crossbar_of_init returns with a error, then set the cb pointer
to null.
Signed-off-by: Sricharan R r.sricha...@ti.com
---
drivers/irqchip/irq-crossbar.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index cf0d79f
1 - 100 of 327 matches
Mail list logo
