[PATCH 0/4] drivers/iommu/ relocations

2011-06-08 Thread Ohad Ben-Cohen
Create a dedicated iommu drivers folder, put the base iommu code there,
and move the existing IOMMU API users as well (msm-iommu, amd_iommu and
intel-iommu).

Putting all iommu drivers together will ease finding similarities
between different platforms, with the intention of solving problems once,
in a generic framework, which everyone can use.

OMAP's iommu will be moved too as soon as it's migrated.

For previous discussions on this, please see:
https://lkml.org/lkml/2011/6/2/369

Ohad Ben-Cohen (4):
  drivers: iommu: move to a dedicated folder
  msm: iommu: move to drivers/iommu/
  x86: amd_iommu: move to drivers/iommu/
  x86: intel-iommu: move to drivers/iommu/

 arch/arm/mach-msm/Kconfig  |   15 --
 arch/arm/mach-msm/Makefile |2 +-
 arch/x86/Kconfig   |   40 ---
 arch/x86/kernel/Makefile   |2 +-
 drivers/Kconfig|2 +
 drivers/Makefile   |1 +
 drivers/base/Makefile  |1 -
 drivers/iommu/Kconfig  |   53 
 drivers/iommu/Makefile |4 ++
 {arch/x86/kernel = drivers/iommu}/amd_iommu.c |0
 drivers/{pci = iommu}/intel-iommu.c   |1 -
 drivers/{base = iommu}/iommu.c|0
 .../mach-msm/iommu.c = drivers/iommu/msm-iommu.c  |0
 drivers/pci/Makefile   |2 +-
 drivers/pci/pci.h  |2 -
 include/linux/pci.h|   11 
 16 files changed, 74 insertions(+), 62 deletions(-)
 create mode 100644 drivers/iommu/Kconfig
 create mode 100644 drivers/iommu/Makefile
 rename {arch/x86/kernel = drivers/iommu}/amd_iommu.c (100%)
 rename drivers/{pci = iommu}/intel-iommu.c (99%)
 rename drivers/{base = iommu}/iommu.c (100%)
 rename arch/arm/mach-msm/iommu.c = drivers/iommu/msm-iommu.c (100%)

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/4] drivers/iommu/ relocations

2011-06-08 Thread Roedel, Joerg
(Cc'ing Ingo)

On Wed, Jun 08, 2011 at 04:34:18AM -0400, Ohad Ben-Cohen wrote:
 Create a dedicated iommu drivers folder, put the base iommu code there,
 and move the existing IOMMU API users as well (msm-iommu, amd_iommu and
 intel-iommu).
 
 Putting all iommu drivers together will ease finding similarities
 between different platforms, with the intention of solving problems once,
 in a generic framework, which everyone can use.
 
 OMAP's iommu will be moved too as soon as it's migrated.

Great, thanks. I'll apply the patches as soon as the relevant ACKs come
in. Looking at the MAINTAINERS file David Brown needs to ACK the MSM
patch and David Woodhouse the VT-d patch.

David B., David W., is this direction ok for both of you?

A more important question is how we handle the IOMMU tree. Currently the
situation is as follows:

* The AMD IOMMU changes go upstream through Ingo
* David Woohouse has his own tree which he sents directly to
  Linus
* Not sure about the ARM IOMMU code
* And to comlicate things further there is the upcoming ARM
  integration tree which may contain code that depends on IOMMU
  changes

My suggestion is that the ARM tree pulls in the necessary changes from
the IOMMU tree and the IOMMU code goes upstream through Ingo or directly
to Linus (with some time in linux-next, of course). Thoughts?

Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/4] drivers/iommu/ relocations

2011-06-08 Thread Matthew Wilcox
On Wed, Jun 08, 2011 at 11:34:18AM +0300, Ohad Ben-Cohen wrote:
 Create a dedicated iommu drivers folder, put the base iommu code there,
 and move the existing IOMMU API users as well (msm-iommu, amd_iommu and
 intel-iommu).
 
 Putting all iommu drivers together will ease finding similarities
 between different platforms, with the intention of solving problems once,
 in a generic framework, which everyone can use.
 
 OMAP's iommu will be moved too as soon as it's migrated.
 
 For previous discussions on this, please see:
 https://lkml.org/lkml/2011/6/2/369
 
 Ohad Ben-Cohen (4):
   drivers: iommu: move to a dedicated folder
   msm: iommu: move to drivers/iommu/
   x86: amd_iommu: move to drivers/iommu/
   x86: intel-iommu: move to drivers/iommu/

You've missed at least parisc, ia64, alpha, sparc, powerpc and sh which
have IOMMUs.  Not that they necessarily all need to be moved across in
one patchset, but saying all iommu drivers is clearly false.

-- 
Matthew Wilcox  Intel Open Source Technology Centre
Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/4] drivers/iommu/ relocations

2011-06-08 Thread Ohad Ben-Cohen
On Wed, Jun 8, 2011 at 4:05 PM, Matthew Wilcox matt...@wil.cx wrote:
 You've missed at least parisc, ia64, alpha, sparc, powerpc and sh which
 have IOMMUs.

None of these seem to call register_iommu.

 Not that they necessarily all need to be moved across in
 one patchset, but saying all iommu drivers is clearly false.

I've moved only the existing IOMMU API users.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/4] drivers/iommu/ relocations

2011-06-08 Thread Roedel, Joerg
On Wed, Jun 08, 2011 at 09:11:16AM -0400, Ohad Ben-Cohen wrote:
 On Wed, Jun 8, 2011 at 4:05 PM, Matthew Wilcox matt...@wil.cx wrote:
  You've missed at least parisc, ia64, alpha, sparc, powerpc and sh which
  have IOMMUs.
 
 None of these seem to call register_iommu.
 
  Not that they necessarily all need to be moved across in
  one patchset, but saying all iommu drivers is clearly false.
 
 I've moved only the existing IOMMU API users.

And I think that is good for now. The iommu-api needs to be extended to
cover all kinds of iommus (like the iommus available on other
architectures). It is definitly the plan to do that and have a common
dma_ops implementation for all of them. But lets start small by now and
move forward step by step :-)

Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/4] drivers/iommu/ relocations

2011-06-08 Thread Ingo Molnar

* Roedel, Joerg joerg.roe...@amd.com wrote:

 (Cc'ing Ingo)
 
 On Wed, Jun 08, 2011 at 04:34:18AM -0400, Ohad Ben-Cohen wrote:
  Create a dedicated iommu drivers folder, put the base iommu code there,
  and move the existing IOMMU API users as well (msm-iommu, amd_iommu and
  intel-iommu).
  
  Putting all iommu drivers together will ease finding similarities
  between different platforms, with the intention of solving problems once,
  in a generic framework, which everyone can use.
  
  OMAP's iommu will be moved too as soon as it's migrated.
 
 Great, thanks. I'll apply the patches as soon as the relevant ACKs come
 in. Looking at the MAINTAINERS file David Brown needs to ACK the MSM
 patch and David Woodhouse the VT-d patch.
 
 David B., David W., is this direction ok for both of you?
 
 A more important question is how we handle the IOMMU tree. Currently the
 situation is as follows:
 
   * The AMD IOMMU changes go upstream through Ingo
   * David Woohouse has his own tree which he sents directly to
 Linus
   * Not sure about the ARM IOMMU code
   * And to comlicate things further there is the upcoming ARM
 integration tree which may contain code that depends on IOMMU
 changes
 
 My suggestion is that the ARM tree pulls in the necessary changes from
 the IOMMU tree and the IOMMU code goes upstream through Ingo or directly
 to Linus (with some time in linux-next, of course). Thoughts?

I can certainly pull from you trees you pull from elsewhere.

David could help keep things tidier by sending the Intel IOMMU bits 
to me as well.

In any case the tip:core/iommu tree is in linux-next so whatever you 
send me shows up there on the next day or so.

Thanks,

Ingo
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/4] drivers/iommu/ relocations

2011-06-08 Thread David Brown
On Wed, Jun 08 2011, Roedel, Joerg wrote:

 Great, thanks. I'll apply the patches as soon as the relevant ACKs come
 in. Looking at the MAINTAINERS file David Brown needs to ACK the MSM
 patch and David Woodhouse the VT-d patch.

 David B., David W., is this direction ok for both of you?

I think it is a good direction to move in.  I'll reply to the patch
directly to comment on it.

 My suggestion is that the ARM tree pulls in the necessary changes from
 the IOMMU tree and the IOMMU code goes upstream through Ingo or directly
 to Linus (with some time in linux-next, of course). Thoughts?

This seems the cleanest to me.

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html