Re: [PATCH 00/10] pwm-backlight: Add GPIO and power supply support

2013-09-24 Thread Simon Horman
[ Cc: Olof Johansson, Kevin Hilman and Arnd Bergman: arm-soc maintainers ]

On Mon, Sep 23, 2013 at 11:40:57PM +0200, Thierry Reding wrote:
 This series adds the ability to specify a GPIO and a power supply to
 enable a backlight.
 
 Patch 1 refactors the power on and power off sequences into separate
 functions in preparation for subsequent patches.
 
 Patch 2 adds an optional GPIO to enable a backlight. This patch only
 includes the field within the platform data so that it can be properly
 setup before actually being put to use.
 
 Patches 3 to 7 convert all users of the pwm-backlight driver to use the
 new field. For most of them, this just initializes the field to -1,
 marking the field as unused.

 Patch 8 uses the new field within the pwm-backlight driver and at the
 same time allows it to be parsed from device tree.
 
 Patch 9 implements support for an optional power supply. This relies on
 the regulator core to return a dummy regulator when no supply has been
 otherwise setup so the driver doesn't have to handle that specially nor
 require all users to be updated.
 
 Patch 10 adds a way to keep a backlight turned off at boot. This is
 useful when hooking up a backlight with a subsystem such as DRM which
 has more explicit semantics as to when a backlight should be turned on.
 
 Due to the dependencies within the series, I propose to take all these
 patches through the PWM tree, so I'll need acks from OMAP, PXA, Samsung,
 shmobile and Unicore32 maintainers.

I received some feedback regarding shmobile conflicts when
arm-soc was merged between v3.11 and v3.12-rc1. With this
in mind I now have a strong preference for changes inside
arch/arm/mach-shmobile/ to be taken through my renesas
tree and thus more importantly through arm-soc if possible.

 Thierry
 
 Thierry Reding (10):
   pwm-backlight: Refactor backlight power on/off
   pwm-backlight: Add optional enable GPIO
   ARM: OMAP: Initialize PWM backlight enable_gpio field
   ARM: pxa: Initialize PWM backlight enable_gpio field
   ARM: SAMSUNG: Initialize PWM backlight enable_gpio field
   ARM: shmobile: Initialize PWM backlight enable_gpio field
   unicore32: Initialize PWM backlight enable_gpio field
   pwm-backlight: Use new enable_gpio field
   pwm-backlight: Use an optional power supply
   pwm-backlight: Allow backlight to remain disabled on boot
 
  .../bindings/video/backlight/pwm-backlight.txt |   6 +
  arch/arm/mach-omap2/board-zoom-peripherals.c   |   1 +
  arch/arm/mach-pxa/cm-x300.c|   1 +
  arch/arm/mach-pxa/colibri-pxa270-income.c  |   1 +
  arch/arm/mach-pxa/ezx.c|   1 +
  arch/arm/mach-pxa/hx4700.c |   1 +
  arch/arm/mach-pxa/lpd270.c |   1 +
  arch/arm/mach-pxa/magician.c   |   1 +
  arch/arm/mach-pxa/mainstone.c  |   1 +
  arch/arm/mach-pxa/mioa701.c|   1 +
  arch/arm/mach-pxa/palm27x.c|   1 +
  arch/arm/mach-pxa/palmtc.c |  35 +
  arch/arm/mach-pxa/palmte2.c|   1 +
  arch/arm/mach-pxa/pcm990-baseboard.c   |   1 +
  arch/arm/mach-pxa/raumfeld.c   |   1 +
  arch/arm/mach-pxa/tavorevb.c   |   2 +
  arch/arm/mach-pxa/viper.c  |   1 +
  arch/arm/mach-pxa/z2.c |   2 +
  arch/arm/mach-pxa/zylonite.c   |   1 +
  arch/arm/mach-s3c24xx/mach-h1940.c |   1 +
  arch/arm/mach-s3c24xx/mach-rx1950.c|   1 +
  arch/arm/mach-s3c64xx/mach-crag6410.c  |   1 +
  arch/arm/mach-s3c64xx/mach-hmt.c   |   1 +
  arch/arm/mach-s3c64xx/mach-smartq.c|   1 +
  arch/arm/mach-s3c64xx/mach-smdk6410.c  |   1 +
  arch/arm/mach-s5p64x0/mach-smdk6440.c  |   1 +
  arch/arm/mach-s5p64x0/mach-smdk6450.c  |   1 +
  arch/arm/mach-s5pc100/mach-smdkc100.c  |   1 +
  arch/arm/mach-s5pv210/mach-smdkv210.c  |   1 +
  arch/arm/mach-shmobile/board-armadillo800eva.c |   1 +
  arch/arm/plat-samsung/dev-backlight.c  |   5 +
  arch/unicore32/kernel/puv3-nb0916.c|   1 +
  drivers/video/backlight/pwm_bl.c   | 142 
 -
  include/linux/pwm_backlight.h  |   7 +
  34 files changed, 162 insertions(+), 64 deletions(-)
 
 -- 
 1.8.4
 
 --
 To unsubscribe from this list: send the line unsubscribe linux-sh in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 00/10] pwm-backlight: Add GPIO and power supply support

2013-09-24 Thread Thierry Reding
On Tue, Sep 24, 2013 at 05:14:46PM +0900, Simon Horman wrote:
 [ Cc: Olof Johansson, Kevin Hilman and Arnd Bergman: arm-soc maintainers ]
 
 On Mon, Sep 23, 2013 at 11:40:57PM +0200, Thierry Reding wrote:
  This series adds the ability to specify a GPIO and a power supply to
  enable a backlight.
  
  Patch 1 refactors the power on and power off sequences into separate
  functions in preparation for subsequent patches.
  
  Patch 2 adds an optional GPIO to enable a backlight. This patch only
  includes the field within the platform data so that it can be properly
  setup before actually being put to use.
  
  Patches 3 to 7 convert all users of the pwm-backlight driver to use the
  new field. For most of them, this just initializes the field to -1,
  marking the field as unused.
 
  Patch 8 uses the new field within the pwm-backlight driver and at the
  same time allows it to be parsed from device tree.
  
  Patch 9 implements support for an optional power supply. This relies on
  the regulator core to return a dummy regulator when no supply has been
  otherwise setup so the driver doesn't have to handle that specially nor
  require all users to be updated.
  
  Patch 10 adds a way to keep a backlight turned off at boot. This is
  useful when hooking up a backlight with a subsystem such as DRM which
  has more explicit semantics as to when a backlight should be turned on.
  
  Due to the dependencies within the series, I propose to take all these
  patches through the PWM tree, so I'll need acks from OMAP, PXA, Samsung,
  shmobile and Unicore32 maintainers.
 
 I received some feedback regarding shmobile conflicts when
 arm-soc was merged between v3.11 and v3.12-rc1. With this
 in mind I now have a strong preference for changes inside
 arch/arm/mach-shmobile/ to be taken through my renesas
 tree and thus more importantly through arm-soc if possible.

I understand. Unfortunately the nature of patche series such as this is
that they require the whole series to be applied atomically (or at least
in a very specific order). So the patch that uses the new enable_gpio
field can only be applied after all previous patches. The only
reasonable way to ensure that is to take all of the patches through one
tree. Furthermore this patch is tiny (it adds a single line) and touches
code that's unlikely to be modified by anyone else.

But if it makes you more comfortable, I could provide a stable branch
that contains this series for you to merge into the shmobile tree. That
should enable you to handle all conflict resolution prior to submitting
to arm-soc.

Thierry


pgpWmaBVZWHdw.pgp
Description: PGP signature


Re: [PATCH 00/10] pwm-backlight: Add GPIO and power supply support

2013-09-24 Thread Simon Horman
On Tue, Sep 24, 2013 at 11:00:24AM +0200, Thierry Reding wrote:
 On Tue, Sep 24, 2013 at 05:14:46PM +0900, Simon Horman wrote:
  [ Cc: Olof Johansson, Kevin Hilman and Arnd Bergman: arm-soc maintainers ]
  
  On Mon, Sep 23, 2013 at 11:40:57PM +0200, Thierry Reding wrote:
   This series adds the ability to specify a GPIO and a power supply to
   enable a backlight.
   
   Patch 1 refactors the power on and power off sequences into separate
   functions in preparation for subsequent patches.
   
   Patch 2 adds an optional GPIO to enable a backlight. This patch only
   includes the field within the platform data so that it can be properly
   setup before actually being put to use.
   
   Patches 3 to 7 convert all users of the pwm-backlight driver to use the
   new field. For most of them, this just initializes the field to -1,
   marking the field as unused.
  
   Patch 8 uses the new field within the pwm-backlight driver and at the
   same time allows it to be parsed from device tree.
   
   Patch 9 implements support for an optional power supply. This relies on
   the regulator core to return a dummy regulator when no supply has been
   otherwise setup so the driver doesn't have to handle that specially nor
   require all users to be updated.
   
   Patch 10 adds a way to keep a backlight turned off at boot. This is
   useful when hooking up a backlight with a subsystem such as DRM which
   has more explicit semantics as to when a backlight should be turned on.
   
   Due to the dependencies within the series, I propose to take all these
   patches through the PWM tree, so I'll need acks from OMAP, PXA, Samsung,
   shmobile and Unicore32 maintainers.
  
  I received some feedback regarding shmobile conflicts when
  arm-soc was merged between v3.11 and v3.12-rc1. With this
  in mind I now have a strong preference for changes inside
  arch/arm/mach-shmobile/ to be taken through my renesas
  tree and thus more importantly through arm-soc if possible.
 
 I understand. Unfortunately the nature of patche series such as this is
 that they require the whole series to be applied atomically (or at least
 in a very specific order). So the patch that uses the new enable_gpio
 field can only be applied after all previous patches. The only
 reasonable way to ensure that is to take all of the patches through one
 tree. Furthermore this patch is tiny (it adds a single line) and touches
 code that's unlikely to be modified by anyone else.
 
 But if it makes you more comfortable, I could provide a stable branch
 that contains this series for you to merge into the shmobile tree. That
 should enable you to handle all conflict resolution prior to submitting
 to arm-soc.

After some further thought I have reasoned that:

1. It is only a one line change on the shmobile side
2. It is to a file that is not seeing much chainge and in
   a block of code that is seeing even less change.

And thus the chance of a conflict is small.

With this in mind I will ack the shmobile patch.

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 00/10] pwm-backlight: Add GPIO and power supply support

2013-09-23 Thread Thierry Reding
This series adds the ability to specify a GPIO and a power supply to
enable a backlight.

Patch 1 refactors the power on and power off sequences into separate
functions in preparation for subsequent patches.

Patch 2 adds an optional GPIO to enable a backlight. This patch only
includes the field within the platform data so that it can be properly
setup before actually being put to use.

Patches 3 to 7 convert all users of the pwm-backlight driver to use the
new field. For most of them, this just initializes the field to -1,
marking the field as unused.

Patch 8 uses the new field within the pwm-backlight driver and at the
same time allows it to be parsed from device tree.

Patch 9 implements support for an optional power supply. This relies on
the regulator core to return a dummy regulator when no supply has been
otherwise setup so the driver doesn't have to handle that specially nor
require all users to be updated.

Patch 10 adds a way to keep a backlight turned off at boot. This is
useful when hooking up a backlight with a subsystem such as DRM which
has more explicit semantics as to when a backlight should be turned on.

Due to the dependencies within the series, I propose to take all these
patches through the PWM tree, so I'll need acks from OMAP, PXA, Samsung,
shmobile and Unicore32 maintainers.

Thierry

Thierry Reding (10):
  pwm-backlight: Refactor backlight power on/off
  pwm-backlight: Add optional enable GPIO
  ARM: OMAP: Initialize PWM backlight enable_gpio field
  ARM: pxa: Initialize PWM backlight enable_gpio field
  ARM: SAMSUNG: Initialize PWM backlight enable_gpio field
  ARM: shmobile: Initialize PWM backlight enable_gpio field
  unicore32: Initialize PWM backlight enable_gpio field
  pwm-backlight: Use new enable_gpio field
  pwm-backlight: Use an optional power supply
  pwm-backlight: Allow backlight to remain disabled on boot

 .../bindings/video/backlight/pwm-backlight.txt |   6 +
 arch/arm/mach-omap2/board-zoom-peripherals.c   |   1 +
 arch/arm/mach-pxa/cm-x300.c|   1 +
 arch/arm/mach-pxa/colibri-pxa270-income.c  |   1 +
 arch/arm/mach-pxa/ezx.c|   1 +
 arch/arm/mach-pxa/hx4700.c |   1 +
 arch/arm/mach-pxa/lpd270.c |   1 +
 arch/arm/mach-pxa/magician.c   |   1 +
 arch/arm/mach-pxa/mainstone.c  |   1 +
 arch/arm/mach-pxa/mioa701.c|   1 +
 arch/arm/mach-pxa/palm27x.c|   1 +
 arch/arm/mach-pxa/palmtc.c |  35 +
 arch/arm/mach-pxa/palmte2.c|   1 +
 arch/arm/mach-pxa/pcm990-baseboard.c   |   1 +
 arch/arm/mach-pxa/raumfeld.c   |   1 +
 arch/arm/mach-pxa/tavorevb.c   |   2 +
 arch/arm/mach-pxa/viper.c  |   1 +
 arch/arm/mach-pxa/z2.c |   2 +
 arch/arm/mach-pxa/zylonite.c   |   1 +
 arch/arm/mach-s3c24xx/mach-h1940.c |   1 +
 arch/arm/mach-s3c24xx/mach-rx1950.c|   1 +
 arch/arm/mach-s3c64xx/mach-crag6410.c  |   1 +
 arch/arm/mach-s3c64xx/mach-hmt.c   |   1 +
 arch/arm/mach-s3c64xx/mach-smartq.c|   1 +
 arch/arm/mach-s3c64xx/mach-smdk6410.c  |   1 +
 arch/arm/mach-s5p64x0/mach-smdk6440.c  |   1 +
 arch/arm/mach-s5p64x0/mach-smdk6450.c  |   1 +
 arch/arm/mach-s5pc100/mach-smdkc100.c  |   1 +
 arch/arm/mach-s5pv210/mach-smdkv210.c  |   1 +
 arch/arm/mach-shmobile/board-armadillo800eva.c |   1 +
 arch/arm/plat-samsung/dev-backlight.c  |   5 +
 arch/unicore32/kernel/puv3-nb0916.c|   1 +
 drivers/video/backlight/pwm_bl.c   | 142 -
 include/linux/pwm_backlight.h  |   7 +
 34 files changed, 162 insertions(+), 64 deletions(-)

-- 
1.8.4

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html