Re: [PATCH 1/3] staging: tidspbridge: fix an erroneous removal of parentheses

2014-06-26 Thread Greg Kroah-Hartman
On Tue, Jun 24, 2014 at 12:24:25AM -0500, Suman Anna wrote:
 Commit 4a9fdbb (staging: core: tiomap3430.c Fix line over 80 characters.)
 erroneously removed the parentheses around the function pointer leading
 to the following build error (when enabling the build of TI DSP/Bridge
 driver):
 
 drivers/staging/tidspbridge/core/tiomap3430.c: In function 
 'bridge_brd_monitor':
 drivers/staging/tidspbridge/core/tiomap3430.c:283:10: error: invalid type 
 argument of unary '*' (have 'u32')
 make[3]: *** [drivers/staging/tidspbridge/core/tiomap3430.o] Error 1
 
 Fix this build error properly.

This shows that no one really uses this driver :(

Can't we just delete the thing?

I'll go queue this up for 3.16-final, thanks.

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 1/3] staging: tidspbridge: fix an erroneous removal of parentheses

2014-06-23 Thread Suman Anna
Commit 4a9fdbb (staging: core: tiomap3430.c Fix line over 80 characters.)
erroneously removed the parentheses around the function pointer leading
to the following build error (when enabling the build of TI DSP/Bridge
driver):

drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_monitor':
drivers/staging/tidspbridge/core/tiomap3430.c:283:10: error: invalid type 
argument of unary '*' (have 'u32')
make[3]: *** [drivers/staging/tidspbridge/core/tiomap3430.o] Error 1

Fix this build error properly.

Fixes: 4a9fdbb (staging: core: tiomap3430.c Fix line over 80 characters.)
Cc: Aybuke Ozdemir aybuke@gmail.com
Cc: Peter P Waskiewicz Jr peter.p.waskiewicz...@intel.com
Cc: Omar Ramirez Luna omar.rami...@copitl.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Signed-off-by: Suman Anna s-a...@ti.com
---
 drivers/staging/tidspbridge/core/tiomap3430.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c 
b/drivers/staging/tidspbridge/core/tiomap3430.c
index 8945b4e..cb50120 100644
--- a/drivers/staging/tidspbridge/core/tiomap3430.c
+++ b/drivers/staging/tidspbridge/core/tiomap3430.c
@@ -280,8 +280,10 @@ static int bridge_brd_monitor(struct bridge_dev_context 
*dev_ctxt)
OMAP3430_IVA2_MOD, OMAP2_CM_CLKSTCTRL);
 
/* Wait until the state has moved to ON */
-   while (*pdata-dsp_prm_read(OMAP3430_IVA2_MOD, OMAP2_PM_PWSTST)
-   OMAP_INTRANSITION_MASK);
+   while ((*pdata-dsp_prm_read)(OMAP3430_IVA2_MOD,
+ OMAP2_PM_PWSTST) 
+   OMAP_INTRANSITION_MASK)
+   ;
/* Disable Automatic transition */
(*pdata-dsp_cm_write)(OMAP34XX_CLKSTCTRL_DISABLE_AUTO,
OMAP3430_IVA2_MOD, OMAP2_CM_CLKSTCTRL);
-- 
2.0.0

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html