Re: [RFC][PATCH] board-omap3beagle: Remove duplicate DVI reset gpio handling

2010-06-30 Thread Koen Kooi 

Op 29 jun 2010, om 22:32 heeft Sergio Aguirre het volgende geschreven:

 Following commit missed to remove this:
 
  commit 044d32ffbcb4a1d400088e3575508f46c0a9face
  Author: Koen Kooi koen.k...@gmail.com
  Date:   Thu Apr 22 10:23:42 2010 +0200
 
  board-omap3-beagle: add DSS2 support
 
 Signed-off-by: Sergio Aguirre saagui...@ti.com
 Cc: Koen Kooi koen.k...@gmail.com

Looks good to me:

Acked-by: Koen Kooi koen.k...@gmail.com

As a side note, the beagleboard xM uses a different pin for that.

regards,

Koen


 ---
 arch/arm/mach-omap2/board-omap3beagle.c |7 ++-
 1 files changed, 2 insertions(+), 5 deletions(-)
 
 diff --git a/arch/arm/mach-omap2/board-omap3beagle.c 
 b/arch/arm/mach-omap2/board-omap3beagle.c
 index 7b95cc1..867a4ad 100644
 --- a/arch/arm/mach-omap2/board-omap3beagle.c
 +++ b/arch/arm/mach-omap2/board-omap3beagle.c
 @@ -169,6 +169,8 @@ static void __init beagle_display_init(void)
 {
   int r;
 
 + omap_mux_init_gpio(beagle_dvi_device.reset_gpio, OMAP_PIN_INPUT);
 +
   r = gpio_request(beagle_dvi_device.reset_gpio, DVI reset);
   if (r  0) {
   printk(KERN_ERR Unable to get DVI reset GPIO\n);
 @@ -491,11 +493,6 @@ static void __init omap3_beagle_init(void)
   ARRAY_SIZE(omap3_beagle_devices));
   omap_serial_init();
 
 - omap_mux_init_gpio(170, OMAP_PIN_INPUT);
 - gpio_request(170, DVI_nPD);
 - /* REVISIT leave DVI powered down until it's needed ... */
 - gpio_direction_output(170, true);
 -
   usb_musb_init(musb_board_data);
   usb_ehci_init(ehci_pdata);
   omap3beagle_flash_init();
 -- 
 1.6.3.3
 
 

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC][PATCH] board-omap3beagle: Remove duplicate DVI reset gpio handling

2010-06-30 Thread Tomi Valkeinen 
On Tue, 2010-06-29 at 22:32 +0200, ext Sergio Aguirre wrote:
 Following commit missed to remove this:
 
   commit 044d32ffbcb4a1d400088e3575508f46c0a9face
   Author: Koen Kooi koen.k...@gmail.com
   Date:   Thu Apr 22 10:23:42 2010 +0200
 
   board-omap3-beagle: add DSS2 support
 
 Signed-off-by: Sergio Aguirre saagui...@ti.com
 Cc: Koen Kooi koen.k...@gmail.com
 ---
  arch/arm/mach-omap2/board-omap3beagle.c |7 ++-
  1 files changed, 2 insertions(+), 5 deletions(-)
 
 diff --git a/arch/arm/mach-omap2/board-omap3beagle.c 
 b/arch/arm/mach-omap2/board-omap3beagle.c
 index 7b95cc1..867a4ad 100644
 --- a/arch/arm/mach-omap2/board-omap3beagle.c
 +++ b/arch/arm/mach-omap2/board-omap3beagle.c
 @@ -169,6 +169,8 @@ static void __init beagle_display_init(void)
  {
   int r;
  
 + omap_mux_init_gpio(beagle_dvi_device.reset_gpio, OMAP_PIN_INPUT);

It's a reset gpio (actually power up/down, if I recall right), it should
be configured as output, shouldn't it?

 Tomi


--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [RFC][PATCH] board-omap3beagle: Remove duplicate DVI reset gpio handling

2010-06-30 Thread Aguirre, Sergio 
Hi Tomi,

 -Original Message-
 From: Tomi Valkeinen [mailto:tomi.valkei...@nokia.com]
 Sent: Wednesday, June 30, 2010 3:41 AM
 To: Aguirre, Sergio
 Cc: linux-omap@vger.kernel.org; Tony Lindgren; Koen Kooi
 Subject: Re: [RFC][PATCH] board-omap3beagle: Remove duplicate DVI reset
 gpio handling
 
 On Tue, 2010-06-29 at 22:32 +0200, ext Sergio Aguirre wrote:
  Following commit missed to remove this:
 
commit 044d32ffbcb4a1d400088e3575508f46c0a9face
Author: Koen Kooi koen.k...@gmail.com
Date:   Thu Apr 22 10:23:42 2010 +0200
 
board-omap3-beagle: add DSS2 support
 
  Signed-off-by: Sergio Aguirre saagui...@ti.com
  Cc: Koen Kooi koen.k...@gmail.com
  ---
   arch/arm/mach-omap2/board-omap3beagle.c |7 ++-
   1 files changed, 2 insertions(+), 5 deletions(-)
 
  diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-
 omap2/board-omap3beagle.c
  index 7b95cc1..867a4ad 100644
  --- a/arch/arm/mach-omap2/board-omap3beagle.c
  +++ b/arch/arm/mach-omap2/board-omap3beagle.c
  @@ -169,6 +169,8 @@ static void __init beagle_display_init(void)
   {
  int r;
 
  +   omap_mux_init_gpio(beagle_dvi_device.reset_gpio, OMAP_PIN_INPUT);
 
 It's a reset gpio (actually power up/down, if I recall right), it should
 be configured as output, shouldn't it?

You're probably right :)

I just shuffled around the same code, which I guessed that works already. 
(right beagleboard guys?).

Regards,
Sergio

 
  Tomi
 

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[RFC][PATCH] board-omap3beagle: Remove duplicate DVI reset gpio handling

2010-06-29 Thread Sergio Aguirre 
Following commit missed to remove this:

  commit 044d32ffbcb4a1d400088e3575508f46c0a9face
  Author: Koen Kooi koen.k...@gmail.com
  Date:   Thu Apr 22 10:23:42 2010 +0200

  board-omap3-beagle: add DSS2 support

Signed-off-by: Sergio Aguirre saagui...@ti.com
Cc: Koen Kooi koen.k...@gmail.com
---
 arch/arm/mach-omap2/board-omap3beagle.c |7 ++-
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/arch/arm/mach-omap2/board-omap3beagle.c 
b/arch/arm/mach-omap2/board-omap3beagle.c
index 7b95cc1..867a4ad 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -169,6 +169,8 @@ static void __init beagle_display_init(void)
 {
int r;
 
+   omap_mux_init_gpio(beagle_dvi_device.reset_gpio, OMAP_PIN_INPUT);
+
r = gpio_request(beagle_dvi_device.reset_gpio, DVI reset);
if (r  0) {
printk(KERN_ERR Unable to get DVI reset GPIO\n);
@@ -491,11 +493,6 @@ static void __init omap3_beagle_init(void)
ARRAY_SIZE(omap3_beagle_devices));
omap_serial_init();
 
-   omap_mux_init_gpio(170, OMAP_PIN_INPUT);
-   gpio_request(170, DVI_nPD);
-   /* REVISIT leave DVI powered down until it's needed ... */
-   gpio_direction_output(170, true);
-
usb_musb_init(musb_board_data);
usb_ehci_init(ehci_pdata);
omap3beagle_flash_init();
-- 
1.6.3.3

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html