Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-09 Thread Igor Grinberg
On 05/08/12 19:24, Greg Kroah-Hartman wrote: On Tue, May 08, 2012 at 10:53:44AM +0300, Igor Grinberg wrote: On 05/07/12 17:48, Alan Stern wrote: On Mon, 7 May 2012, Igor Grinberg wrote: On 05/07/12 17:04, Alan Stern wrote: On Sun, 6 May 2012, Igor Grinberg wrote: Hi Alan, ... Sorry,

[PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-09 Thread Igor Grinberg
When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not call the gpio_set_value() function, but gpio_set_value_cansleep(). Signed-off-by: Igor Grinberg grinb...@compulab.co.il Acked-by: Felipe Balbi ba...@ti.com Tested-by: Govindraj.R govindraj.r...@ti.com

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-08 Thread Igor Grinberg
On 05/07/12 17:48, Alan Stern wrote: On Mon, 7 May 2012, Igor Grinberg wrote: On 05/07/12 17:04, Alan Stern wrote: On Sun, 6 May 2012, Igor Grinberg wrote: Hi Alan, ... Sorry, for being jumpy... Samuel has not answered yet (it has been more then two weeks already) and I'd like this to

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-08 Thread Greg Kroah-Hartman
On Tue, May 08, 2012 at 10:53:44AM +0300, Igor Grinberg wrote: On 05/07/12 17:48, Alan Stern wrote: On Mon, 7 May 2012, Igor Grinberg wrote: On 05/07/12 17:04, Alan Stern wrote: On Sun, 6 May 2012, Igor Grinberg wrote: Hi Alan, ... Sorry, for being jumpy... Samuel has not

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-07 Thread Samuel Ortiz
Hi Igor, On Sun, May 06, 2012 at 09:25:05AM +0300, Igor Grinberg wrote: Sorry, for being jumpy... Samuel has not answered yet (it has been more then two weeks already) Sorry about that. and I'd like this to go into 3.5. Then you may need a better changelog explaining how this fixes a

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-07 Thread Igor Grinberg
Hi Samuel, On 05/07/12 11:09, Samuel Ortiz wrote: Hi Igor, On Sun, May 06, 2012 at 09:25:05AM +0300, Igor Grinberg wrote: Sorry, for being jumpy... Samuel has not answered yet (it has been more then two weeks already) Sorry about that. and I'd like this to go into 3.5. Then you may

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-07 Thread Samuel Ortiz
Hi Igor, On Mon, May 07, 2012 at 02:46:35PM +0300, Igor Grinberg wrote: Hi Samuel, On 05/07/12 11:09, Samuel Ortiz wrote: Hi Igor, On Sun, May 06, 2012 at 09:25:05AM +0300, Igor Grinberg wrote: Sorry, for being jumpy... Samuel has not answered yet (it has been more then two weeks

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-07 Thread Alan Stern
On Sun, 6 May 2012, Igor Grinberg wrote: Hi Alan, ... Sorry, for being jumpy... Samuel has not answered yet (it has been more then two weeks already) and I'd like this to go into 3.5. Also, the dependency patch is already in Linus' tree. It has been merged with fixes (I thought it will

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-07 Thread Igor Grinberg
On 05/07/12 17:04, Alan Stern wrote: On Sun, 6 May 2012, Igor Grinberg wrote: Hi Alan, ... Sorry, for being jumpy... Samuel has not answered yet (it has been more then two weeks already) and I'd like this to go into 3.5. Also, the dependency patch is already in Linus' tree. It has

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-07 Thread Alan Stern
On Mon, 7 May 2012, Igor Grinberg wrote: On 05/07/12 17:04, Alan Stern wrote: On Sun, 6 May 2012, Igor Grinberg wrote: Hi Alan, ... Sorry, for being jumpy... Samuel has not answered yet (it has been more then two weeks already) and I'd like this to go into 3.5. Also, the

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-06 Thread Igor Grinberg
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Alan, On 04/20/12 14:57, Felipe Balbi wrote: On Thu, Apr 19, 2012 at 11:01:16AM -0400, Alan Stern wrote: On Thu, 19 Apr 2012, Igor Grinberg wrote: ping Alan, Felipe, Can this go into 3.5? It's okay with me. Acked-by: Alan Stern

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-04-20 Thread Felipe Balbi
On Thu, Apr 19, 2012 at 11:01:16AM -0400, Alan Stern wrote: On Thu, 19 Apr 2012, Igor Grinberg wrote: ping Alan, Felipe, Can this go into 3.5? It's okay with me. Acked-by: Alan Stern st...@rowland.harvard.edu Also fine from my side: Acked-by: Felipe Balbi ba...@ti.com The

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-04-19 Thread Igor Grinberg
ping Alan, Felipe, Can this go into 3.5? The dependency patch has already reached Samuel's tree, what would be the best way to apply this one? Should I ask Samuel to apply this one also (after having your acks) via his tree, to reduce possible merge failures/conflicts? On 03/27/12 16:08, Igor

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-04-19 Thread Alan Stern
On Thu, 19 Apr 2012, Igor Grinberg wrote: ping Alan, Felipe, Can this go into 3.5? It's okay with me. Acked-by: Alan Stern st...@rowland.harvard.edu The dependency patch has already reached Samuel's tree, what would be the best way to apply this one? Should I ask Samuel to apply this

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-03-28 Thread Felipe Balbi
On Tue, Mar 27, 2012 at 04:08:55PM +0200, Igor Grinberg wrote: When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not call the gpio_set_value() function, but gpio_set_value_cansleep(). Signed-off-by: Igor Grinberg grinb...@compulab.co.il Acked-by: Felipe

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-03-28 Thread Raja, Govindraj
On Wed, Mar 28, 2012 at 2:22 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Mar 27, 2012 at 04:08:55PM +0200, Igor Grinberg wrote: When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not call the gpio_set_value() function, but gpio_set_value_cansleep().

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-03-28 Thread Igor Grinberg
Hi Shubhrajyoti, On 03/28/12 12:03, Shubhrajyoti wrote: On Tuesday 27 March 2012 07:38 PM, Igor Grinberg wrote: When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not call the gpio_set_value() function, but gpio_set_value_cansleep(). Why so ? Whats the

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-03-28 Thread Igor Grinberg
On 03/28/12 12:53, Raja, Govindraj wrote: On Wed, Mar 28, 2012 at 2:22 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Mar 27, 2012 at 04:08:55PM +0200, Igor Grinberg wrote: When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not call the gpio_set_value()

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-03-28 Thread Munegowda, Keshava
On Wed, Mar 28, 2012 at 4:23 PM, Raja, Govindraj govindraj.r...@ti.com wrote: On Wed, Mar 28, 2012 at 2:22 PM, Felipe Balbi ba...@ti.com wrote: On Tue, Mar 27, 2012 at 04:08:55PM +0200, Igor Grinberg wrote: When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-03-28 Thread Shubhrajyoti Datta
Hi Igor, On Wed, Mar 28, 2012 at 4:43 PM, Igor Grinberg grinb...@compulab.co.il wrote: Hi Shubhrajyoti, On 03/28/12 12:03, Shubhrajyoti wrote: On Tuesday 27 March 2012 07:38 PM, Igor Grinberg wrote: When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not

[PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-03-27 Thread Igor Grinberg
When PHY reset pin is connected to a GPIO on external GPIO chip (e.g. I2C), we should not call the gpio_set_value() function, but gpio_set_value_cansleep(). Signed-off-by: Igor Grinberg grinb...@compulab.co.il --- This patch depends on the patch from Keshava [1]: ARM: OMAP3: USB: Fix the EHCI